[libvirt] Plan for next release

2015-07-22 Thread Daniel Veillard
We are getting close to the end of the month, so we may need to freeze next Monday or Tuesday. Are we ready for 1.3.0 now :-) ? I see that configure.ac targets 1.2.18, so a priori no, but would rather have a clear answer :-) Thanks, Daniel -- Daniel Veillard | Open Source and

Re: [libvirt] Bump tar format?

2015-07-22 Thread Andrea Bolognani
On Wed, 2015-07-22 at 15:58 +0100, Daniel P. Berrange wrote: Any suggestions on how to proceed? We've hit this many times before and always just shorten the file names in GIT to avoid it. Really we could do with adding a check for filename length to make check to avoid this again.

Re: [libvirt] Plan for next release

2015-07-22 Thread Laine Stump
On 07/22/2015 11:50 AM, Daniel Veillard wrote: We are getting close to the end of the month, so we may need to freeze next Monday or Tuesday. Are we ready for 1.3.0 now :-) ? I see that configure.ac targets 1.2.18, so a priori no, but would rather have a clear answer :-) I had posted

Re: [libvirt] [PATCH 1/2] bhyve: add UTC clock support

2015-07-22 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: On Sun, Jul 19, 2015 at 11:20:35AM +0300, Roman Bogorodskiy wrote: Bhyve as of r279225 (FreeBSD -CURRENT) or r284894 (FreeBSD 10-STABLE) supports using UTC time offset via the '-u' argument to bhyve(8). By default it's still using localtime. Make the bhyve

Re: [libvirt] Bump tar format?

2015-07-22 Thread Daniel P. Berrange
On Wed, Jul 22, 2015 at 04:44:56PM +0200, Andrea Bolognani wrote: Hi everyone, commit cc3d52e[1] has apparently broken 'make dist' for at least some platforms: Fedora 20 is fine[2], but both Fedora 21 and rawhide[3][4] are currently failing. My laptop is running Fedora 22 and can make dist

[libvirt] [PATCH] conf: more useful error message when pci function is out of range

2015-07-22 Thread Laine Stump
If a pci address had a function number out of range, the error message would be: Insufficient specification for PCI address This was due to an unnecessary call to virDevicePCIAddressIsValid() during parse of the pci address - we will anyway check for validity of the PCI address later on. With

Re: [libvirt] Bump tar format?

2015-07-22 Thread Eric Blake
On 07/22/2015 08:44 AM, Andrea Bolognani wrote: 1. rename the test case, making it shorter; Works if we can do it, but I agree we should add a syntax check to enforce it. 2. bump tar format from ustar, which has limitations on the length of file names, to posix/pax, which has no

[libvirt] [PATCH] netdev: fix build on FreeBSD

2015-07-22 Thread Roman Bogorodskiy
Commit ac3ed20 breaks build on FreeBSD with: CC util/libvirt_util_la-virnetdev.lo util/virnetdev.c:2967:1: error: unused function 'virNetDevRDMAFeature' [-Werror,-Wunused-function] virNetDevRDMAFeature(const char *ifname, ^ So hide virNetDevRDMAFeature function under the #ifdef

Re: [libvirt] Bump tar format?

2015-07-22 Thread Daniel P. Berrange
On Wed, Jul 22, 2015 at 04:59:35PM +0100, Daniel P. Berrange wrote: On Wed, Jul 22, 2015 at 05:49:20PM +0200, Andrea Bolognani wrote: On Wed, 2015-07-22 at 15:58 +0100, Daniel P. Berrange wrote: Any suggestions on how to proceed? We've hit this many times before and always just

Re: [libvirt] Bump tar format?

2015-07-22 Thread Daniel P. Berrange
On Wed, Jul 22, 2015 at 05:49:20PM +0200, Andrea Bolognani wrote: On Wed, 2015-07-22 at 15:58 +0100, Daniel P. Berrange wrote: Any suggestions on how to proceed? We've hit this many times before and always just shorten the file names in GIT to avoid it. Really we could do with

[libvirt] [PATCH v2 05/12] conf: Add check for host address type while checking in use

2015-07-22 Thread John Ferlan
While searching the hostdevs the drive type can be either *_TYPE_DRIVE or *_TYPE_NONE. If the type is _TYPE_NONE on the first scsi_host, then there is an erroneous match that the address already exists. Although this works by chance currently because hostdev's are added one at a time and

[libvirt] [PATCH v7 0/5] nodeinfo: Add support for subcores

2015-07-22 Thread Andrea Bolognani
Changes from v6 to v7: * rebased on top of master now that the series this one builds on have been merged Again, I'm only sending patch 1/5 to the list because the rest of the series hasn't changed from v5. Here are pointers for your convenience: 2/5

Re: [libvirt] Bump tar format?

2015-07-22 Thread Daniel P. Berrange
On Wed, Jul 22, 2015 at 05:49:20PM +0200, Andrea Bolognani wrote: On Wed, 2015-07-22 at 15:58 +0100, Daniel P. Berrange wrote: Any suggestions on how to proceed? We've hit this many times before and always just shorten the file names in GIT to avoid it. Really we could do with

[libvirt] [PATCH v7 1/5] nodeinfo: Fix output on PPC64 KVM hosts

2015-07-22 Thread Andrea Bolognani
From: Shivaprasad G Bhat sb...@linux.vnet.ibm.com The nodeinfo is reporting incorrect number of cpus and incorrect host topology on PPC64 KVM hosts. The KVM hypervisor on PPC64 needs only the primary thread in a core to be online, and the secondaries offlined. While scheduling a guest in, the kvm

Re: [libvirt] [PATCH 2/2] docs: bhyve: document clock configuration

2015-07-22 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: On Sun, Jul 19, 2015 at 11:20:36AM +0300, Roman Bogorodskiy wrote: --- docs/drvbhyve.html.in | 28 1 file changed, 28 insertions(+) ACK Pushed, thanks! Regards, Daniel -- |: http://berrange.com -o-

Re: [libvirt] [PATCHv2 01/17] conf: reorganize virNetworkDHCPDefParseXML

2015-07-22 Thread Laine Stump
On 07/17/2015 02:43 PM, Laine Stump wrote: This makes the range and static host array management in virNetworkDHCPDefParseXML() more similar to what is done in virNetworkDefUpdateIPDHCPRange() and virNetworkDefUpdateIPDHCPHost() - they use VIR_APPEND_ELEMENT rather than a combination of

Re: [libvirt] [PATCHv2 01/17] conf: reorganize virNetworkDHCPDefParseXML

2015-07-22 Thread John Ferlan
On 07/17/2015 02:43 PM, Laine Stump wrote: This makes the range and static host array management in virNetworkDHCPDefParseXML() more similar to what is done in virNetworkDefUpdateIPDHCPRange() and virNetworkDefUpdateIPDHCPHost() - they use VIR_APPEND_ELEMENT rather than a combination of

Re: [libvirt] [PATCHv2 04/17] conf: add virDomainControllerDefNew()

2015-07-22 Thread John Ferlan
On 07/17/2015 02:43 PM, Laine Stump wrote: There are some non-0 default values in virDomainControllerDef (and will soon be more) that are easier to not forget if the remembering is done by a single initializer function (rather than inline code after allocating the obejct with generic

Re: [libvirt] [PATCHv2 06/17] qemu: implement model subelement to controller

2015-07-22 Thread Laine Stump
On 07/22/2015 03:54 PM, John Ferlan wrote: On 07/17/2015 02:43 PM, Laine Stump wrote: This patch provides qemu support for the contents of model in controller for the two existing PCI controller types that need it (i.e. the two controller types that are backed by a device that must be

Re: [libvirt] [PATCHv2 06/17] qemu: implement model subelement to controller

2015-07-22 Thread John Ferlan
On 07/22/2015 04:18 PM, Laine Stump wrote: On 07/22/2015 03:54 PM, John Ferlan wrote: ... +if (deviceName +VIR_STRDUP(options-type, deviceName) 0) +goto cleanup; + As has been told to me before - virStrdup/VIR_STRDUP is tolerant of

[libvirt] Libvirt error in Openstack Tempest attaching disk on arm64 system

2015-07-22 Thread Clark Laughlin
I am running Openstack Tempest on an arm64 platform and am seeing some test failures related to attaching volumes to an instance. This is an example of the disk XML generated by one of the tests: disk type=block device=diskdriver name=qemu type=raw cache=none/source

Re: [libvirt] [PATCHv2 08/17] qemu: implement target chassisNr='n'/ subelement/attribute of controller

2015-07-22 Thread John Ferlan
On 07/17/2015 02:43 PM, Laine Stump wrote: This uses the new subelement/attribute in two ways: 1) If a pci-bridge pci controller has no chassisNr attribute, it will automatically be set to the controller's index during qemuDomainAssignPCIAddresses() 2) when creating the commandline for

Re: [libvirt] [PATCHv2 02/17] conf: pay attention to bus minSlot/maxSlot when autoassigning PCI addresses

2015-07-22 Thread John Ferlan
On 07/17/2015 02:43 PM, Laine Stump wrote: The function that auto-assigns PCI addresses was written with the hardcoded assumptions that any PCI bus would have slots available starting at 1 and ending at 31. This isn't true for many types of controller (some have a single slot/port at 0, some

Re: [libvirt] [PATCHv2 03/17] qemu: reorganize loop in qemuDomainAssignPCIAddresses

2015-07-22 Thread John Ferlan
On 07/17/2015 02:43 PM, Laine Stump wrote: This loop occurs just after we've assured that all devices that require a PCI device have been assigned and all necessary PCI controllers have been added. It is the perfect place to add other potentially auto-generated PCI controller attributes that

Re: [libvirt] [PATCHv2 06/17] qemu: implement model subelement to controller

2015-07-22 Thread John Ferlan
On 07/17/2015 02:43 PM, Laine Stump wrote: This patch provides qemu support for the contents of model in controller for the two existing PCI controller types that need it (i.e. the two controller types that are backed by a device that must be specified on the qemu commandline): 1)

Re: [libvirt] [PATCHv2 07/17] conf: add new target subelement with chassisNr attribute to controller

2015-07-22 Thread John Ferlan
On 07/17/2015 02:43 PM, Laine Stump wrote: There are some configuration options to some types of pci controllers that are currently automatically derived from other parts of the controller's configuration. For example, a pci-bridge controller has an option that is called chassis_nr in qemu;

Re: [libvirt] [PATCHv2 07/17] conf: add new target subelement with chassisNr attribute to controller

2015-07-22 Thread John Ferlan
On 07/17/2015 02:43 PM, Laine Stump wrote: The one oddity of all this is that if the controller configuration is changed (for example to change the index or the pci address where the controller is plugged in), the items in target will *not* be re-generated, which might lead to conflict. I

Re: [libvirt] [PATCH v2 05/10] nodeinfo: Remove out parameter from nodeGetCPUBitmap()

2015-07-22 Thread Peter Krempa
On Mon, Jul 20, 2015 at 18:37:25 +0200, Andrea Bolognani wrote: Not all users of this API will need the size of the returned bitmap; those who do can simply call virBitmapSize() themselves. --- src/nodeinfo.c | 12 +--- src/nodeinfo.h | 2 +- 2 files changed, 6 insertions(+), 8

Re: [libvirt] [PATCH v2 08/10] nodeinfo: Use nodeGetOnlineCPUBitmap() when parsing node

2015-07-22 Thread Peter Krempa
On Mon, Jul 20, 2015 at 18:37:28 +0200, Andrea Bolognani wrote: No need to look up the online status of each CPU separately when we can get all the information in one go. --- src/nodeinfo.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/nodeinfo.c

[libvirt] [PATCH] qemu: fix the error cover issue in SetMemoryParameters

2015-07-22 Thread Luyao Huang
https://bugzilla.redhat.com/show_bug.cgi?id=1245476 We won't return the errno after commit 0d7f45ae, and the more clearly error will be set in the code in vircgroup*. Also We will always report error Operation not permitted, because the return is -1. Signed-off-by: Luyao Huang lhu...@redhat.com

Re: [libvirt] [Spice-devel] [PATCH v4] qemu: Use heads parameter for QXL driver

2015-07-22 Thread Martin Kletzander
On Tue, Jul 21, 2015 at 04:36:45PM +0100, Daniel P. Berrange wrote: On Tue, Jul 21, 2015 at 11:34:08AM -0400, Laine Stump wrote: On 07/21/2015 09:41 AM, Daniel P. Berrange wrote: On Tue, Jul 21, 2015 at 03:35:50PM +0200, Martin Kletzander wrote: On Tue, Jul 21, 2015 at 01:50:22PM +0100,

Re: [libvirt] [PATCH v2 10/10] nodeinfo: Calculate present and online CPUs only once

2015-07-22 Thread Peter Krempa
On Mon, Jul 20, 2015 at 18:37:30 +0200, Andrea Bolognani wrote: Move the calls to the respective functions from virNodeParseNode(), which is executed once for every NUMA node, to linuxNodeInfoCPUPopulate(), which is executed just once per host. --- src/nodeinfo.c | 53

Re: [libvirt] [PATCH v2 08/10] nodeinfo: Use nodeGetOnlineCPUBitmap() when parsing node

2015-07-22 Thread Andrea Bolognani
On Wed, 2015-07-22 at 10:34 +0200, Peter Krempa wrote: @@ -432,6 +432,9 @@ virNodeParseNode(const char *sysfs_prefix, present_cpumap = nodeGetPresentCPUBitmap(sysfs_prefix); if (!present_cpumap) goto cleanup; +online_cpus_map =

Re: [libvirt] [PATCH v2 00/10] nodeinfo: Various cleanups

2015-07-22 Thread Peter Krempa
On Mon, Jul 20, 2015 at 18:37:20 +0200, Andrea Bolognani wrote: This should take care of Peter's remarks, except the ones that I've addressed separately. This series is pushed now. Peter signature.asc Description: Digital signature -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] Revert qemu: Use heads parameter for QXL driver

2015-07-22 Thread Martin Kletzander
This reverts commit 7b401c3bdacdf8367a0070e625d73eafb802045d. Until libvirt is able to differentiate whether heads='1' is just a leftover from previous libvirt or whether that's added by user on purpose and also whether the domain was started with the support for qxl's max_outputs, we cannot

Re: [libvirt] [PATCH] qemu: fix the error cover issue in SetMemoryParameters

2015-07-22 Thread Martin Kletzander
On Wed, Jul 22, 2015 at 03:35:14PM +0800, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1245476 We won't return the errno after commit 0d7f45ae, and the more clearly error will be set in the code in vircgroup*. Also We will always report error Operation not permitted, because

Re: [libvirt] Continuation of Admin APIs

2015-07-22 Thread Daniel P. Berrange
On Tue, Jun 16, 2015 at 06:03:39PM +0200, Martin Kletzander wrote: So now that we have the Admin API backend merged in, the code is prepared to have new APIs added in. There are many things to be added, but we should start out slowly with the most desired ones. I'll try to outline what I have

Re: [libvirt] [PATCH] qemu: fix the error cover issue in SetMemoryParameters

2015-07-22 Thread lhuang
On 07/22/2015 05:06 PM, Martin Kletzander wrote: On Wed, Jul 22, 2015 at 03:35:14PM +0800, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1245476 We won't return the errno after commit 0d7f45ae, and the more clearly error will be set in the code in vircgroup*. Also We will

Re: [libvirt] [PATCH v2 10/10] nodeinfo: Calculate present and online CPUs only once

2015-07-22 Thread Andrea Bolognani
On Wed, 2015-07-22 at 10:44 +0200, Peter Krempa wrote: -present_cpumap = nodeGetPresentCPUBitmap(sysfs_prefix); -if (!present_cpumap) -goto cleanup; -online_cpus_map = nodeGetOnlineCPUBitmap(sysfs_prefix); -if (!online_cpus_map) -goto cleanup; - -

Re: [libvirt] [libvirt-glib 0/4] gconfig: Leak fixes and small cleanup

2015-07-22 Thread Christophe Fergeau
Hey, On Fri, Jul 17, 2015 at 09:01:46AM +0200, Christophe Fergeau wrote: On Thu, Jul 09, 2015 at 10:13:16AM +0200, Christophe Fergeau wrote: Hey, This patch series makes tests/test-gconfig valgrind-clean, and refactors two setters in GVirConfigDomainVideo to make them use the helpers

Re: [libvirt] [Spice-devel] [PATCH v4] qemu: Use heads parameter for QXL driver

2015-07-22 Thread Martin Kletzander
On Wed, Jul 22, 2015 at 10:14:27AM +0100, Daniel P. Berrange wrote: I'm not sure what you are suggesting by features here, but I'd prefer if we didn't introduce a chunk of XML which would contain an ever growing set of hacks. It seems sufficient for us to just record the libvirt version number

Re: [libvirt] Continuation of Admin APIs

2015-07-22 Thread Martin Kletzander
On Wed, Jul 22, 2015 at 11:02:11AM +0100, Daniel P. Berrange wrote: On Tue, Jun 16, 2015 at 06:03:39PM +0200, Martin Kletzander wrote: So now that we have the Admin API backend merged in, the code is prepared to have new APIs added in. There are many things to be added, but we should start out

Re: [libvirt] [Spice-devel] [PATCH v4] qemu: Use heads parameter for QXL driver

2015-07-22 Thread Daniel P. Berrange
On Wed, Jul 22, 2015 at 09:59:00AM +0200, Martin Kletzander wrote: On Tue, Jul 21, 2015 at 04:36:45PM +0100, Daniel P. Berrange wrote: On Tue, Jul 21, 2015 at 11:34:08AM -0400, Laine Stump wrote: On 07/21/2015 09:41 AM, Daniel P. Berrange wrote: On Tue, Jul 21, 2015 at 03:35:50PM +0200,

Re: [libvirt] [PATCH] Revert qemu: Use heads parameter for QXL driver

2015-07-22 Thread Daniel P. Berrange
On Wed, Jul 22, 2015 at 10:05:48AM +0200, Martin Kletzander wrote: This reverts commit 7b401c3bdacdf8367a0070e625d73eafb802045d. Until libvirt is able to differentiate whether heads='1' is just a leftover from previous libvirt or whether that's added by user on purpose and also whether the

Re: [libvirt] [PATCH] Revert qemu: Use heads parameter for QXL driver

2015-07-22 Thread Martin Kletzander
On Wed, Jul 22, 2015 at 10:12:02AM +0100, Daniel P. Berrange wrote: On Wed, Jul 22, 2015 at 10:05:48AM +0200, Martin Kletzander wrote: This reverts commit 7b401c3bdacdf8367a0070e625d73eafb802045d. Until libvirt is able to differentiate whether heads='1' is just a leftover from previous libvirt

Re: [libvirt] [libvirt-glib 0/4] gconfig: Leak fixes and small cleanup

2015-07-22 Thread Zeeshan Ali (Khattak)
On Wed, Jul 22, 2015 at 11:41 AM, Christophe Fergeau cferg...@redhat.com wrote: Hey, On Fri, Jul 17, 2015 at 09:01:46AM +0200, Christophe Fergeau wrote: On Thu, Jul 09, 2015 at 10:13:16AM +0200, Christophe Fergeau wrote: Hey, This patch series makes tests/test-gconfig valgrind-clean, and

Re: [libvirt] [libvirt-glib 0/4] gconfig: Leak fixes and small cleanup

2015-07-22 Thread Christophe Fergeau
On Wed, Jul 22, 2015 at 01:27:45PM +0100, Zeeshan Ali (Khattak) wrote: On Wed, Jul 22, 2015 at 11:41 AM, Christophe Fergeau cferg...@redhat.com wrote: Hey, On Fri, Jul 17, 2015 at 09:01:46AM +0200, Christophe Fergeau wrote: On Thu, Jul 09, 2015 at 10:13:16AM +0200, Christophe Fergeau

[libvirt] [PATCH glib] configure.ac: update min required versions

2015-07-22 Thread Daniel P. Berrange
Based on the distro target policy we have the following min versions in various distros libvirt glib2gobject-introspection RHEL 7.0: 1.1.12.36.3 1.36.0 Fedora 21: 1.2.92.42.1 1.42.0 Ubuntu 14.10: 1.2.82.42.0 1.41.0 Ubuntu LTS 14.04:

Re: [libvirt] [PATCH glib] README: formally document intended platform support targets

2015-07-22 Thread Zeeshan Ali (Khattak)
On Wed, Jul 22, 2015 at 2:02 PM, Daniel P. Berrange berra...@redhat.com wrote: Give users an indication of what distro platforms the project intends to be buildable on. This policy will be used to decide when it is appropriate to increase the minimum required versions of external dependancies.

Re: [libvirt] [PATCH glib] configure.ac: update min required versions

2015-07-22 Thread Daniel P. Berrange
On Wed, Jul 22, 2015 at 02:51:44PM +0100, Daniel P. Berrange wrote: Based on the distro target policy we have the following min versions in various distros libvirt glib2gobject-introspection RHEL 7.0: 1.1.12.36.3 1.36.0 Fedora 21: 1.2.9

Re: [libvirt] [PATCH v2 06/10] nodeinfo: Rename nodeGetCPUBitmap() to nodeGetOnlineCPUBitmap()

2015-07-22 Thread Peter Krempa
On Mon, Jul 20, 2015 at 18:37:26 +0200, Andrea Bolognani wrote: The new name makes it clear that the returned bitmap contains the information about which CPUs are online, not eg. which CPUs are present. No behavioral change. --- src/libvirt_private.syms | 2 +- src/nodeinfo.c |

Re: [libvirt] [PATCH v2 07/10] nodeinfo: Phase out cpu_set_t usage

2015-07-22 Thread Peter Krempa
On Mon, Jul 20, 2015 at 18:37:27 +0200, Andrea Bolognani wrote: Swap out all instances of cpu_set_t and replace them with virBitmap, which some of the code was already using anyway. The changes are pretty mechanical, with one notable exception: an assumption has been added on the max value

Re: [libvirt] [PATCH v2 09/10] nodeinfo: Use a bitmap to keep track of node CPUs

2015-07-22 Thread Peter Krempa
On Mon, Jul 20, 2015 at 18:37:29 +0200, Andrea Bolognani wrote: Keep track of what CPUs belong to the current node while walking through the sysfs node entry, so we don't need to do it a second time immediately afterwards. This also allows us to loop through all CPUs that are part of a node

Re: [libvirt] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Daniel P. Berrange
On Wed, Jul 22, 2015 at 01:40:25PM +0200, Paolo Bonzini wrote: On 22/07/2015 12:19, Michael S. Tsirkin wrote: SCSI passthrough was no longer supported in virtio 1.0, so this patch fail the get_features() when both 1.0 and scsi is set. And also only advertise VIRTIO_BLK_F_SCSI for

Re: [libvirt] [RFC] domain xml validation for source elements

2015-07-22 Thread Daniel P. Berrange
On Wed, Jul 22, 2015 at 01:43:12PM +0200, Boris Fiuczynski wrote: I ran into a problem that was caused by a missing leading slash (/) in the value of the file attribute of a disks source element. Defining the domain worked without a problem. That's because 'virsh define' does not turn on

Re: [libvirt] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Paolo Bonzini
On 22/07/2015 13:46, Daniel P. Berrange wrote: IIUC, the SCSI passthrough feature for virtio-blk is enabled by setting the 'scsi=on' property on the virtio-blk device, which is exposed by libvirt with XML: disk type='block' device='lun' driver name='qemu' type='raw'/

[libvirt] [libvirt-glib] examples: Don't leak mainloop in conn-test.c

2015-07-22 Thread Christophe Fergeau
The program exits right after this, so it's no big deal, but this gives us a clean valgrind --leak-check=full output. --- examples/conn-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/conn-test.c b/examples/conn-test.c index adc6434..ac5880a 100644 ---

[libvirt] [PATCH glib] README: formally document intended platform support targets

2015-07-22 Thread Daniel P. Berrange
Give users an indication of what distro platforms the project intends to be buildable on. This policy will be used to decide when it is appropriate to increase the minimum required versions of external dependancies. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- README | 65

[libvirt] [RFC] domain xml validation for source elements

2015-07-22 Thread Boris Fiuczynski
I ran into a problem that was caused by a missing leading slash (/) in the value of the file attribute of a disks source element. Defining the domain worked without a problem. Editing the domain and trying to save it resulted in a very generic error message: error: XML document failed to

Re: [libvirt] [libvirt-glib] examples: Don't leak mainloop in conn-test.c

2015-07-22 Thread Christophe Fergeau
On Wed, Jul 22, 2015 at 02:56:53PM +0200, Christophe Fergeau wrote: The program exits right after this, so it's no big deal, but this gives us a clean valgrind --leak-check=full output. Ah, messed up my push of the 4 patches which were ACK'ed earlier, and pushed that one too :( Christophe

Re: [libvirt] [PATCHv2 11/17] qemu: support new pci controller model pcie-root-port

2015-07-22 Thread John Ferlan
On 07/17/2015 02:43 PM, Laine Stump wrote: This is backed by the qemu device ioh3420. chassis and port from the model subelement are used to store/set the respective qemu device options for the ioh3420. Currently, chassis is set to be the index of the controller, and port is set to (slot

Re: [libvirt] [PATCHv2 05/17] conf: add new model subelement with type attribute to controller

2015-07-22 Thread John Ferlan
On 07/17/2015 02:43 PM, Laine Stump wrote: This new subelement is used in PCI controllers: the toplevel *attribute* model of a controller denotes what kind of PCI controller is being described, e.g. a dmi-to-pci-bridge, pci-bridge, or pci-root. But in the future there will be different

Re: [libvirt] [PATCHv2 07/17] conf: add new target subelement with chassisNr attribute to controller

2015-07-22 Thread Laine Stump
On 07/22/2015 04:25 PM, John Ferlan wrote: On 07/17/2015 02:43 PM, Laine Stump wrote: The one oddity of all this is that if the controller configuration is changed (for example to change the index or the pci address where the controller is plugged in), the items in target will *not* be

Re: [libvirt] [PATCHv2 10/17] conf: new pci controller model pcie-root-port

2015-07-22 Thread John Ferlan
On 07/17/2015 02:43 PM, Laine Stump wrote: This controller can be connected (at domain startup time only - not hotpluggable) only to a port on the pcie root complex (pcie-root in libvirt config), hence the new connect type VIR_PCI_CONNECT_TYPE_PCIE_ROOT. It provides a hotpluggable port that

Re: [libvirt] Libvirt error in Openstack Tempest attaching disk on arm64 system

2015-07-22 Thread Daniel P. Berrange
On Wed, Jul 22, 2015 at 02:53:31PM -0500, Clark Laughlin wrote: I am running Openstack Tempest on an arm64 platform and am seeing some test failures related to attaching volumes to an instance. This is an example of the disk XML generated by one of the tests: disk type=block

Re: [libvirt] [PATCHv2 09/17] qemu: add capabilities bit for device ioh3420

2015-07-22 Thread John Ferlan
On 07/17/2015 02:43 PM, Laine Stump wrote: This is a PCIE root port. It connects only to a port of the integrated pcie.0 bus of a Q35 machine (can't be hotplugged), and provides a single PCIe port that can have PCI or PCIe devices hotplugged into it. This device will be used to implement

[libvirt] Bump tar format?

2015-07-22 Thread Andrea Bolognani
Hi everyone, commit cc3d52e[1] has apparently broken 'make dist' for at least some platforms: Fedora 20 is fine[2], but both Fedora 21 and rawhide[3][4] are currently failing. My laptop is running Fedora 22 and can make dist just fine, which is of course very confusing. The issue is caused by

[libvirt] [PATCH v2 00/12] Adjust SCSI generated device address checks

2015-07-22 Thread John Ferlan
v1 here: http://www.redhat.com/archives/libvir-list/2015-June/msg01104.html Some followups into July resulted in the request to move the Hostdev and Disk default (or _NONE) address creation/assignment into domain/ device post processing rather than during XML parsing. Changes in v2 are numerous,

[libvirt] [PATCH v2 01/12] conf: Remove extraneous check in virDomainHostdevAssignAddress

2015-07-22 Thread John Ferlan
Since the only way virDomainHostdevAssignAddress can be called is from within virDomainHostdevDefParseXML when hostdev-source.subsys.type is VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI, thus there's no need for redundancy. Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/domain_conf.c | 3 ---

[libvirt] [PATCH v2 04/12] conf: Add xmlopt to virDomainDeviceDefPostParseInternal

2015-07-22 Thread John Ferlan
Add the xmlopt parameter that was saved during virDomainDefPostParse to the parameters. A future patch will use it. Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/domain_conf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c

[libvirt] [PATCH v2 02/12] conf: Add 'bus' and 'target' to SCSI address conflict checks

2015-07-22 Thread John Ferlan
Modify virDomainDriveAddressIsUsedBy{Disk|Hostdev} and virDomainSCSIDriveAddressIsUsed to take 'bus' and 'target' parameters. Will be used by future patches for more complete address conflict checks Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/domain_conf.c | 28

[libvirt] [PATCH v2 08/12] conf: Remove unused param from virDomainHostdevDefParseXML

2015-07-22 Thread John Ferlan
Remove unused xmlopt param Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/domain_conf.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index eabba68..44ce71b 100644 --- a/src/conf/domain_conf.c +++

[libvirt] [PATCH v2 10/12] conf: Change when virDomainDiskDefAssignAddress is called

2015-07-22 Thread John Ferlan
Rather than calling virDomainDiskDefAssignAddress during the parsing of the XML, moving the setting of disk addresses into the domain/device post processing. Commit id '37588b25' which introduced VIR_DOMAIN_DEF_PARSE_DISK_SOURCE in order to avoid generating the address which wasn't required will

[libvirt] [PATCH v2 03/12] conf: Move hostdev and disk address validations

2015-07-22 Thread John Ferlan
Move the functions above the post processing for upcoming patch Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/domain_conf.c | 284 + 1 file changed, 145 insertions(+), 139 deletions(-) diff --git a/src/conf/domain_conf.c

[libvirt] [PATCH v2 09/12] conf: Add SCSI hostdev check for disk drive address already in use

2015-07-22 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1210587 (partial) If a SCSI subsystem hostdev element address is provided, we need to make sure the address provided doesn't conflict with an existing or libvirt generated address for a SCSI disk element. This will fix the issue where the domain XML

[libvirt] [PATCH v2 06/12] conf: Try controller add when searching hostdev bus for unit

2015-07-22 Thread John Ferlan
If virDomainControllerSCSINextUnit failed to find a slot on the current VIR_DOMAIN_CONTROLLER_TYPE_SCSI controller(s), try to add a new controller; otherwise, there may be multiple unit=0 entries for the same next controller. Signed-off-by: John Ferlan jfer...@redhat.com ---

[libvirt] [PATCH v2 11/12] conf: Create locals for virDomainDiskDefAssignAddress

2015-07-22 Thread John Ferlan
Create local controller/bus variables to be used by a future patch Signed-off-by: John Ferlan jfer...@redhat.com --- src/conf/domain_conf.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

Re: [libvirt] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set

2015-07-22 Thread Michael S. Tsirkin
On Wed, Jul 22, 2015 at 01:53:14PM +0200, Paolo Bonzini wrote: On 22/07/2015 13:46, Daniel P. Berrange wrote: IIUC, the SCSI passthrough feature for virtio-blk is enabled by setting the 'scsi=on' property on the virtio-blk device, which is exposed by libvirt with XML: disk

[libvirt] [PATCH v2 07/12] conf: Change when virDomainHostdevAssignAddress is called

2015-07-22 Thread John Ferlan
Rather than calling virDomainHostdevAssignAddress during the parsing of the XML, move the setting of a default hostdev address to domain/ device post processing. Since the parse code no longer generates an address, we can remove the virDomainDefMaybeAddHostdevSCSIcontroller since the call to

[libvirt] [PATCH v2 12/12] conf: Check for hostdev conflicts when assign default disk address

2015-07-22 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1210587 (completed) When generating the default drive address for a SCSI disk device, check the generated address to ensure it doesn't conflict with a SCSI hostdev address. The disk address generation algorithm uses the target dev name in order to

[libvirt] [PATCH glib 1/2] README: formally document intended platform support targets

2015-07-22 Thread Daniel P. Berrange
Give users an indication of what distro platforms the project intends to be buildable on. This policy will be used to decide when it is appropriate to increase the minimum required versions of external dependancies. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- README | 67

Re: [libvirt] [PATCH glib] README: formally document intended platform support targets

2015-07-22 Thread Daniel P. Berrange
On Wed, Jul 22, 2015 at 02:54:17PM +0100, Zeeshan Ali (Khattak) wrote: On Wed, Jul 22, 2015 at 2:02 PM, Daniel P. Berrange berra...@redhat.com wrote: Give users an indication of what distro platforms the project intends to be buildable on. This policy will be used to decide when it is

[libvirt] [PATCH glib 0/2] Clarify min required versions of deps

2015-07-22 Thread Daniel P. Berrange
This sets out a policy for deciding when it is reasonable to increase the min required versions of external deps, and then updates current min versions accordingly. The aim is to ensure libvirt-glib is easily buildable on latest enterprise and community distros, to maximise the pool of possible

[libvirt] [PATCH glib 2/2] configure.ac: update min required versions

2015-07-22 Thread Daniel P. Berrange
Based on the distro target policy we have the following min versions in various distros libvirt glib2gobject-introspection RHEL 7.0: 1.1.12.36.3 1.36.0 Fedora 21: 1.2.92.42.1 1.42.0 Ubuntu 14.10: 1.2.82.42.0 1.41.0 Ubuntu LTS 14.04:

Re: [libvirt] [PATCH glib] Make use of DHCP API conditionally compiled

2015-07-22 Thread Zeeshan Ali (Khattak)
On Tue, Jul 21, 2015 at 4:09 PM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Jul 21, 2015 at 03:56:54PM +0100, Zeeshan Ali (Khattak) wrote: On Tue, Jul 21, 2015 at 3:20 PM, Daniel P. Berrange berra...@redhat.com wrote: Previously the use of virDomainOpenGraphicsFD API from libvirt