On Mon, 2015-08-03 at 09:27 -0400, John Ferlan wrote:
Pulled in 2-5 from v8 series, rebuilt, checked, and pushed.
The new code caused the build to fail[1] if the KVM headers
were not available on the system, but Martin has already
pushed the fix so we're good now.
Thanks.
[1]
On Sat, Jul 18, 2015 at 07:43:10AM -0400, John Ferlan wrote:
Rather than provide a somewhat generic error message when the API
returns false, allow the caller to supply a report = true option
in order to cause virReportError's to describe which of the 3 paths
that can cause failure.
Some
On 08/03/2015 10:04 AM, Martin Kletzander wrote:
On Mon, Aug 03, 2015 at 04:00:32PM +0200, Martin Kletzander wrote:
On Mon, Aug 03, 2015 at 09:21:51AM -0400, John Ferlan wrote:
On 07/15/2015 03:17 AM, Martin Kletzander wrote:
The virDomainObjListRemove() function unlocks a domain that it's
That function takes string list and returns first string in that list
that starts with the @prefix parameter with that prefix being skipped as
the caller knows what it starts with (also for easier manipulation in
future).
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
This function translates device paths to major:minor string, and all
virCgroupSetBlkioDevice* functions are modified to use it. It's a
cleanup with no functional change.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/util/vircgroup.c | 180
We were blindly setting blkiotune values for devices, but kernel can
throw some of them away. This series reworks the logic the same
wayother tuning values are updated. That is, after the value gets
set, it is read back again to make sure internal structures are in
sync and we can return the
Since now they were not needed, but I sense they will be in a short
while.
Signed-off-by: Martin Kletzander mklet...@redhat.com
---
src/libvirt_private.syms | 5 +
src/util/vircgroup.c | 277 ++-
src/util/vircgroup.h | 20
3 files
The problem here is that there are some values that kernel accepts, but
does not set them, for example 18446744073709551615 which acts the same
way as zero. Let's do the same thing we do with other tuning options
and re-read them right after they are set in order to keep our internal
structures
The problem here is that there are some values that kernel accepts, but
does not set them, for example 18446744073709551615 which acts the same
way as zero. Let's do the same thing we do with other tuning options
and re-read them right after they are set in order to keep our internal
structures
On 07/22/2015 10:54 AM, John Ferlan wrote:
v1 here:
http://www.redhat.com/archives/libvir-list/2015-June/msg01104.html
Some followups into July resulted in the request to move the Hostdev
and Disk default (or _NONE) address creation/assignment into domain/
device post processing rather
On 03.08.2015 11:25, Daniel P. Berrange wrote:
On Mon, Aug 03, 2015 at 11:18:51AM +0200, Michal Privoznik wrote:
On 21.07.2015 17:06, Imran Khan wrote:
Gentle reminder. Humble request for another round of review.
thanks
imran
I'm sorry it took so long but I was on a vacation. I'd like to
On Mon, Aug 03, 2015 at 09:27:37AM +0100, Daniel P. Berrange wrote:
On Mon, Aug 03, 2015 at 09:05:53AM +0200, Martin Kletzander wrote:
Since its introduction in 2011 (particularly in commit f4324e329275),
the option doesn't work. It just effectively disables all incoming
connections. That's
On Mon, Aug 03, 2015 at 11:43:35AM +0200, Martin Kletzander wrote:
On Mon, Aug 03, 2015 at 09:27:37AM +0100, Daniel P. Berrange wrote:
On Mon, Aug 03, 2015 at 09:05:53AM +0200, Martin Kletzander wrote:
Since its introduction in 2011 (particularly in commit f4324e329275),
the option doesn't
On Sat, Jul 25, 2015 at 03:58:25PM -0400, Laine Stump wrote:
This new subelement is used in PCI controllers: the toplevel
*attribute* model of a controller denotes what kind of PCI
controller is being described, e.g. a dmi-to-pci-bridge,
pci-bridge, or pci-root. But in the future there will be
[I reduced the Cc list so I don't need to hear jtomko's whining again]
On Sat, Jul 25, 2015 at 03:58:26PM -0400, Laine Stump wrote:
This patch provides qemu support for the contents of model in
controller for the two existing PCI controller types that need it
(i.e. the two controller types that
On Sat, Jul 25, 2015 at 03:58:30PM -0400, Laine Stump wrote:
This controller can be connected (at domain startup time only - not
hotpluggable) only to a port on the pcie root complex (pcie-root in
libvirt config), hence the new connect type
VIR_PCI_CONNECT_TYPE_PCIE_ROOT. It provides a
On Sat, Jul 25, 2015 at 03:58:36PM -0400, Laine Stump wrote:
This controller can be connected only to a port on a
pcie-switch-upstream-port. It provides a single hotpluggable port that
will accept any PCI or PCIe device, as well as any device requiring a
pcie-*-port (the only current example of
On 07/31/2015 08:33 PM, Martin Kletzander wrote:
On Mon, Jul 20, 2015 at 05:18:37PM +0800, Luyao Huang wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1244664
If user disable cpuset in qemu.conf, we shouldn't
try to use it, also shouldn't make some command which
can work without cpuset
As sketched in previous commits, imagine the following scenario:
virsh # domiftune gentoo vnet0
inbound.average: 100
inbound.peak : 0
inbound.burst : 0
outbound.average: 100
outbound.peak : 0
outbound.burst : 0
virsh # domiftune gentoo vnet0 --inbound 0
virsh # shutdown
There is no guarantee that an enum start it mapped onto a value
of zero. However, we are guaranteed that enum items are
consecutive integers. Moreover, it's a pity to define an enum to
avoid using magical constants but then using them anyway.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
Well, there are just two places that needs adjustment:
qemuDomainGetInterfaceParameters - to report the @floor
qemuDomainSetInterfaceParameters - now that the function has been
fixed, we can allow updating @floor too.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
When a domain vNIC's bandwidth is to be changed (at runtime) it is
possible that guaranteed minimal bandwidth (@floor) will change too.
Well, so far it is, because we still don't have an implementation that
allows setting it dynamically, so it's effectively erased on:
#virsh domiftune $dom
We have a function parseRateStr() that parses --inbound and
--outbound arguments to both attach-interface and domiftune.
Now that we have all virTypedParams macros needed for QoS,
lets parse even floor attribute. The extended format for the
arguments looks like this then:
--inbound
This is no functional change. It's just that later in the series we
will need to pass class_id as an integer.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
src/network/bridge_driver.c | 4 ++--
src/util/virnetdevbandwidth.c | 10 +++---
src/util/virnetdevbandwidth.h | 2 +-
3
This macro represents the single missing field we don't expose
yet within QoS: inbound.floor.
Signed-off-by: Michal Privoznik mpriv...@redhat.com
---
include/libvirt/libvirt-domain.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/libvirt/libvirt-domain.h
So, if a domain vNIC's bandwidth has been successfully set, it's
possible that because @floor is set on network's bridge, this
part may need updating too. And that's exactly what this function
does. While the previous commit introduced a function to check if
@floor can be satisfied, this does all
The first patch is unrelated to the rest, but I have it on the
same branch. The patches 2..5 fix a daemon crasher (since
domain_write ACL is required, I'm not going through
libvirt-security). Then, since after patch 5 we have nearly
everything prepared, patches 6..9 implement new feature: setting
The function is used to parse a tuple delimited by commas into
virNetDevBandwidth structure. So far only three out of fore
fields are supported: average, peak and burst. The single missing
field is floor. Well, the parsing works, but I think we can do
better. Especially when we will need to parse
On 28.07.2015 09:52, Kevin Walker wrote:
Hi All
I am currently getting up to speed with the libvirt api, but have noticed
there are some big gaps in the Application Development Guide available on
the libvirt website.
Is there a more recent version of this document available?
I am
On Mon, Aug 03, 2015 at 10:30:20AM +0200, Jiri Denemark wrote:
libvirt_virDomainGetSecurityLabelList called PyList_Append without
checking its return value. While looking at it I noticed the function
did not properly check several other return values either so I fixed
them all.
It's out ! Tagged in git and with signed tarball and rpms on the server
at the usual place:
ftp://libvirt.org/libvirt/
I also made a libvirt-python release found at:
ftp://libvirt.org/libvirt/python/
This is a rather small size release, the libxl support for dom0 being
the main feature
On Mon, Aug 03, 2015 at 12:17:45PM +0200, Martin Kletzander wrote:
On Sat, Jul 25, 2015 at 03:58:30PM -0400, Laine Stump wrote:
This controller can be connected (at domain startup time only - not
hotpluggable) only to a port on the pcie root complex (pcie-root in
libvirt config), hence the new
On 21.07.2015 17:06, Imran Khan wrote:
Gentle reminder. Humble request for another round of review.
thanks
imran
I'm sorry it took so long but I was on a vacation. I'd like to review,
but the patch is mangled. Can you resend with git send-email?
Michal
--
libvir-list mailing list
On Mon, Aug 03, 2015 at 11:18:51AM +0200, Michal Privoznik wrote:
On 21.07.2015 17:06, Imran Khan wrote:
Gentle reminder. Humble request for another round of review.
thanks
imran
I'm sorry it took so long but I was on a vacation. I'd like to review,
but the patch is mangled. Can you
On Sat, Jul 25, 2015 at 03:58:25PM -0400, Laine Stump wrote:
This new subelement is used in PCI controllers: the toplevel
*attribute* model of a controller denotes what kind of PCI
controller is being described, e.g. a dmi-to-pci-bridge,
pci-bridge, or pci-root. But in the future there will be
On Sat, Jul 25, 2015 at 03:58:27PM -0400, Laine Stump wrote:
There are some configuration options to some types of pci controllers
that are currently automatically derived from other parts of the
controller's configuration. For example, in qemu a pci-bridge
controller has an option that is
On Sat, Jul 25, 2015 at 03:58:24PM -0400, Laine Stump wrote:
Since the first 3 patches of V2 were ACKed and uncontroversial, I
fixed the small problems pointed out in the reviews and pushed
them. Thus, Patches 01-13 here correspond to Patches 04-17 in V2.
4 patches with the DHCP rework that
On Sun, Jul 26, 2015 at 06:57:03PM +0200, Martin Kletzander wrote:
First two patches just prepare the ground for the third one that
explains what needs to be fixed and ho it's done.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1162947
Post-release ping
Martin Kletzander (3):
Since its introduction in 2011 (particularly in commit f4324e329275),
the option doesn't work. It just effectively disables all incoming
connections. That's because the client private data that contain the
'keepalive_supported' boolean, are initialized to zeroes so the bool is
false and the only
On Mon, Aug 03, 2015 at 09:05:53AM +0200, Martin Kletzander wrote:
Since its introduction in 2011 (particularly in commit f4324e329275),
the option doesn't work. It just effectively disables all incoming
connections. That's because the client private data that contain the
On Fri, 2015-07-31 at 16:49 +0200, Peter Krempa wrote:
Peter Krempa (2):
qemu: Make memory alignment helper more universal
qemu: ppc64: Align memory sizes to 256MiB
src/qemu/qemu_domain.c | 33
--
src/qemu/qemu_domain.h
On 20.07.2015 10:43, ychen wrote:
hi:
when I use openstack devstack to test QOS, wired phenomenon appeared,
I set qos ingress rule in tapB, but when I reboot tapA, the ingress rule of
tapB automatically removed, but the egress rule is still exist.
Test enviroment:
Linux: ubuntu 14.04.1 LTS
On 07/30/2015 06:28 PM, Daniel P. Berrange wrote:
On Thu, Jul 23, 2015 at 06:13:46PM +0800, Luyao Huang wrote:
Introduce a new element in shmem device element, this
could help users to change the shm label to a specified
label.
Signed-off-by: Luyao Huang lhu...@redhat.com
---
On Mon, Jul 20, 2015 at 05:42:11PM +0300, Ossi Herrala wrote:
On Sat, Jun 06, 2015 at 07:36:48PM +, Ossi Herrala wrote:
Sorry to miss this mail, it got buried somehow and I haven't got to it
until now since nobody pinged it. Sorry for the long wait then.
No worries and thank you for
On 18.07.2015 10:29, Vasiliy Tolstov wrote:
Hi again =). I have another problem then testing libvirt with massive vm
start:
2015-07-18 08:25:21.687+: 36893: error : qemuMonitorIO:750 :
internal error: early end of file from monitor: possible problem:
2015-07-18T08:25:21.586487Z
On 07/30/2015 06:25 PM, Daniel P. Berrange wrote:
On Thu, Jul 23, 2015 at 06:13:49PM +0800, Luyao Huang wrote:
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_conf.h| 3 +
src/qemu/qemu_driver.c | 4 ++
src/qemu/qemu_process.c | 158
libvirt_virDomainGetSecurityLabelList called PyList_Append without
checking its return value. While looking at it I noticed the function
did not properly check several other return values either so I fixed
them all.
https://bugzilla.redhat.com/show_bug.cgi?id=1249511
Signed-off-by: Jiri Denemark
Hi Marc-André
On 07/27/2015 11:52 PM, Marc-André Lureau wrote:
Hi
On Thu, Jul 23, 2015 at 12:13 PM, Luyao Huang lhu...@redhat.com wrote:
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_conf.h| 3 +
src/qemu/qemu_driver.c | 4 ++
src/qemu/qemu_process.c | 158
On 07/30/2015 06:23 PM, Daniel P. Berrange wrote:
On Thu, Jul 23, 2015 at 06:13:49PM +0800, Luyao Huang wrote:
Signed-off-by: Luyao Huang lhu...@redhat.com
---
src/qemu/qemu_conf.h| 3 +
src/qemu/qemu_driver.c | 4 ++
src/qemu/qemu_process.c | 158
Compiler error:
../../src/nodeinfo.c: In function 'nodeGetThreadsPerSubcore':
../../src/nodeinfo.c:2393: error: label 'out' defined but not used
[-Wunused-label]
../../src/nodeinfo.c:2352: error: unused parameter 'arch' [-Wunused-parameter]
---
src/nodeinfo.c | 17 ++---
1
On Mon, Aug 03, 2015 at 05:02:39PM +0200, Andrea Bolognani wrote:
Compiler error:
../../src/nodeinfo.c: In function 'nodeGetThreadsPerSubcore':
../../src/nodeinfo.c:2393: error: label 'out' defined but not used
[-Wunused-label]
../../src/nodeinfo.c:2352: error: unused parameter 'arch'
On 08/03/2015 06:23 PM, Ján Tomko wrote:
On Thu, Jul 30, 2015 at 07:55:36AM -0400, Kothapally Madhu Pavan wrote:
PowerPC pseries based VMs do not support a floppy disk controller.
Here the commit message mentions a controller, but the code only checks
for the disk type='floppy'/ device,
not
On Mon, Aug 03, 2015 at 10:00:29PM +0530, Imran Khan wrote:
Thanks Daniel and Michal again for your valuable inputs. Please check my
reply with text imran for some of your comments. And request you to help
on those.
BTW: should i reply with rework in the new patch. or i should reply to
On Wed, Jul 15, 2015 at 09:17:46AM +0200, Martin Kletzander wrote:
The virDomainObjListRemove() function unlocks a domain that it's given
due to legacy code. And because of that code, which should be
refactored, that last virObjectUnlock() cannot be just removed. So
instead, lock it right back
On 07/25/2015 03:58 PM, Laine Stump wrote:
Since the first 3 patches of V2 were ACKed and uncontroversial, I
fixed the small problems pointed out in the reviews and pushed
them. Thus, Patches 01-13 here correspond to Patches 04-17 in V2.
Most of these patches were already ACKed in V2
Since its introduction in 2011 (particularly in commit f4324e329275),
the option doesn't work. It just effectively disables all incoming
connections. That's because the client private data that contain the
'keepalive_supported' boolean, are initialized to zeroes so the bool is
false and the only
On 07/18/2015 07:43 AM, John Ferlan wrote:
Resolve a couple of issues regarding failures seen configuring a disk
to be a type='volume' device='lun'. The doc patch just indicates that
using an NPIV storage/source pool is a valid option. The second patch
allows for a clearer error message to
On 07/22/2015 10:54 AM, John Ferlan wrote:
v1 here:
http://www.redhat.com/archives/libvir-list/2015-June/msg01104.html
Some followups into July resulted in the request to move the Hostdev
and Disk default (or _NONE) address creation/assignment into domain/
device post processing rather
On Fri, Jul 31, 2015 at 08:12:01AM +0800, zhang bo wrote:
On 2015/7/30 17:41, zhang bo wrote:
On 2015/7/28 16:33, Ján Tomko wrote:
On Tue, Jul 28, 2015 at 04:25:13PM +0800, zhang bo wrote:
static int
qemuDomainDetachVirtioDiskDevice(virQEMUDriverPtr driver,
On Thu, Jul 30, 2015 at 07:55:36AM -0400, Kothapally Madhu Pavan wrote:
PowerPC pseries based VMs do not support a floppy disk controller.
Here the commit message mentions a controller, but the code only checks
for the disk type='floppy'/ device,
not for controller type='fdc'/
Should we forbid
On Mon, Aug 03, 2015 at 11:02:49 +0200, Andrea Bolognani wrote:
On Fri, 2015-07-31 at 16:49 +0200, Peter Krempa wrote:
Peter Krempa (2):
qemu: Make memory alignment helper more universal
qemu: ppc64: Align memory sizes to 256MiB
src/qemu/qemu_domain.c
On Wed, Jul 22, 2015 at 10:54:30AM -0400, John Ferlan wrote:
Remove unused xmlopt param
Signed-off-by: John Ferlan jfer...@redhat.com
---
src/conf/domain_conf.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
ACK to patches 1 to 8.
Jan
signature.asc
Description:
On Wed, Jul 22, 2015 at 10:54:31AM -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1210587 (partial)
If a SCSI subsystem hostdev element address is provided, we need to
make sure the address provided doesn't conflict with an existing or
libvirt generated address for a
On 07/15/2015 03:17 AM, Martin Kletzander wrote:
The virDomainObjListRemove() function unlocks a domain that it's given
due to legacy code. And because of that code, which should be
refactored, that last virObjectUnlock() cannot be just removed. So
instead, lock it right back for qemu for
On Wed, Jul 22, 2015 at 10:54:29AM -0400, John Ferlan wrote:
Rather than calling virDomainHostdevAssignAddress during the parsing
of the XML, move the setting of a default hostdev address to domain/
device post processing.
Since the parse code no longer generates an address, we can remove
On 07/30/2015 05:37 AM, Andrea Bolognani wrote:
Only patch 1/5 has been updated, all the other patches
are the same as v8:
2/5 https://www.redhat.com/archives/libvir-list/2015-July/msg01045.html
3/5 https://www.redhat.com/archives/libvir-list/2015-July/msg01048.html
4/5
On Wed, Jul 22, 2015 at 10:54:34AM -0400, John Ferlan wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1210587 (completed)
When generating the default drive address for a SCSI disk device,
check the generated address to ensure it doesn't conflict with a SCSI
hostdev address. The disk
On Mon, Aug 03, 2015 at 04:00:32PM +0200, Martin Kletzander wrote:
On Mon, Aug 03, 2015 at 09:21:51AM -0400, John Ferlan wrote:
On 07/15/2015 03:17 AM, Martin Kletzander wrote:
The virDomainObjListRemove() function unlocks a domain that it's given
due to legacy code. And because of that
On Mon, 2015-08-03 at 15:13 +0200, Peter Krempa wrote:
Looks okay overall and works as expected from my limited
testing on ppc64.
One thing, though: the domain XML is not updated with the
rounded-up value, which I think might be a little bit
confusing to the user. Any chance the
On Wed, Jul 22, 2015 at 10:54:32AM -0400, John Ferlan wrote:
Rather than calling virDomainDiskDefAssignAddress during the parsing of
the XML, moving the setting of disk addresses into the domain/device post
processing.
Commit id '37588b25' which introduced VIR_DOMAIN_DEF_PARSE_DISK_SOURCE
On Mon, Aug 03, 2015 at 09:21:51AM -0400, John Ferlan wrote:
On 07/15/2015 03:17 AM, Martin Kletzander wrote:
The virDomainObjListRemove() function unlocks a domain that it's given
due to legacy code. And because of that code, which should be
refactored, that last virObjectUnlock() cannot be
On Sat, Jul 18, 2015 at 07:43:09AM -0400, John Ferlan wrote:
Further clarification (and testing) shows that using a SCSI Fibre
Channel NPIV device/lun from a storage pool as a disk type='volume'
device'lun' will work. So just add that to the allowable options
Related to:
72 matches
Mail list logo
