Re: [libvirt] [PATCH libvirt master v2] interface type: add udp socket support

2015-09-01 Thread Laine Stump
On 08/31/2015 04:06 PM, Jonathan Toppins wrote: On 08/31/2015 03:25 PM, Guido Günther wrote: Hi, On Sat, Aug 29, 2015 at 04:19:10PM -0400, Jonathan Toppins wrote: Adds a new interface type using UDP sockets, this seems only applicable to QEMU but have edited tree-wide to support the new

Re: [libvirt] [PATCH libvirt master v2] interface type: add udp socket support

2015-09-01 Thread Daniel P. Berrange
On Tue, Sep 01, 2015 at 02:11:05PM -0400, Laine Stump wrote: > On 08/31/2015 04:06 PM, Jonathan Toppins wrote: > >On 08/31/2015 03:25 PM, Guido Günther wrote: > >>Hi, > >>On Sat, Aug 29, 2015 at 04:19:10PM -0400, Jonathan Toppins wrote: > >>>Adds a new interface type using UDP sockets, this seems

[libvirt] [PATCHv2 1/2] util: make virNetDev(Replace|Restore)MacAddress public functions

2015-09-01 Thread Laine Stump
These functions were made static as a part of commit cbfe38c since they were no longer called from outside virnetdev.c. We once again need to call them from another file, so this patch makes them once again public. --- src/libvirt_private.syms | 2 + src/util/virnetdev.c | 172

[libvirt] [PATCHv2 2/2] util: don't use netlink to save/set mac for macvtap+passthrough+802.1Qbh

2015-09-01 Thread Laine Stump
Before libvirt sets the MAC address of the physdev (the physical ethernet device) linked to a macvtap passthrough device, it always saves the previous MAC address to restore when the guest is finished (following a "leave nothing behind" policy). For a long time it accomplished the save/restore

[libvirt] [PATCHv2 0/2] macvtap: don't use netlink to save/set mac for macvtap+passthrough+802.1Qbh

2015-09-01 Thread Laine Stump
These two patches are the v2 of a single patch that I sent last week: https://www.redhat.com/archives/libvir-list/2015-August/msg00889.html At the time I sent that patch, I had no hardware to test it on, but was operating on a misunderstood assumption - someone in the know had told me that

Re: [libvirt] [PATCH libvirt master v2] interface type: add udp socket support

2015-09-01 Thread Jonathan Toppins
On 09/01/2015 02:11 PM, Laine Stump wrote: On 08/31/2015 04:06 PM, Jonathan Toppins wrote: On 08/31/2015 03:25 PM, Guido Günther wrote: Hi, On Sat, Aug 29, 2015 at 04:19:10PM -0400, Jonathan Toppins wrote: Adds a new interface type using UDP sockets, this seems only applicable to QEMU but

[libvirt] Release of libvirt-1.2.19

2015-09-01 Thread Daniel Veillard
It's out ! Tagged in git, signed tarball and rpms are available from the usual place: ftp://libvirt.org/libvirt/ I also pushed the python bindings out at: ftp://libvirt.org/libvirt/python This is still a relatively small release at around 200 commits, but with user noticeable features

[libvirt] [PATCH 1/4] virfile: Add error for root squash change mode failure

2015-09-01 Thread John Ferlan
This will only be seen when debugging, but in order to help determine whether a virFileOpenForceOwnerMode failed during an NFS root-squash volume/file creation, add an error message from the child. Signed-off-by: John Ferlan --- src/util/virfile.c | 7 ++- 1 file

[libvirt] [PATCH 2/4] virfile: Introduce virFileUnlink

2015-09-01 Thread John Ferlan
In an NFS root-squashed environment the 'vol-delete' command will fail to 'unlink' the target volume since it was created under a different uid:gid. This code continues the concepts introduced in virFileOpenForked and virDirCreate[NoFork] with respect to running the unlink command under the

[libvirt] [PATCH 3/4] storage: Correct the 'mode' check

2015-09-01 Thread John Ferlan
Commit id '7c2d65dde2' changed the default value of mode to be -1 if not supplied in the XML, which should cause creation of the volume using the default mode of VIR_STORAGE_DEFAULT_VOL_PERM_MODE; however, the check made was whether mode was '0' or not to use default or provided value. This patch

[libvirt] [PATCH 4/4] storage: Handle failure from refreshVol

2015-09-01 Thread John Ferlan
In an NFS root-squash environment it was possible that if the just created volume from XML wasn't properly created with the right uid/gid and/or mode, then the followup refreshVol will fail to open the volume in order to get the allocation/capacity values. This would leave the volume still on the

[libvirt] [PATCH 0/4] Resolve a few NFS root-squash related issues

2015-09-01 Thread John Ferlan
The following series of patches resolve a few issues found within and because of an NFS root-squash environment. Patch 1: No real change - mostly to get data on which path was failing Patch 2: Create a virFileUnlink() API which will essentially follow the code that virFileCreateAs[Forked] and

Re: [libvirt] [RFC PATCH 0/3] Implement mockup capabilities cache in QEMU tests

2015-09-01 Thread Cole Robinson
On 08/18/2015 05:40 AM, Pavel Fedin wrote: > Since commit e8d55172544c1fafe31a9e09346bdebca4f0d6f9 qemu driver checks > emulator capabilities during domain XML post-parse. However, test suite > does not initialize it, therefore a condition to skip all checks if there > is no cache supplied was

Re: [libvirt] [PATCH] qemu: Default to virtio network devices on ppc64

2015-09-01 Thread Martin Kletzander
On Mon, Aug 31, 2015 at 02:39:08PM +0200, Andrea Bolognani wrote: Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1254044 --- You could be a bit more expressive in the commit message, you know ;) src/qemu/qemu_domain.c | 3 ++-

[libvirt] Missing CPU vendor in capabilities in 1.2.18+

2015-09-01 Thread Guido Günther
Hi, We have a report in Debian[1] where after a update from 1.2.16 to 1.2.18 VMs on a Intel i5 CPU fail to start due to libvirt not being able to match the CPU vendor: # virsh start sid error: Failed to start domain sid error: unsupported configuration: guest and host CPU are not

[libvirt] [libvirt-python][PATCH] generator: fix build fail with old xml lib

2015-09-01 Thread Luyao Huang
https://bugzilla.redhat.com/show_bug.cgi?id=1222795#c6 if build libvirt-python with some old xml lib (python-pyxml), build will fail and error like this: File "generator.py", line 139, in start if "string" in attrs: File

[libvirt] libvirtlight problem with Xen

2015-09-01 Thread Eric
I'm trying to use virt-manager with Xen. My Dom0 is Debian 8. When I create a DomU (Ubuntu Trusty) as a PV guest, the boot fails with an error saying that libvirtlight failed to connect. The opinion from the virt-manager list group is that the problem is libvirt, not virt-manager. I've

Re: [libvirt] [PATCH] virVMXParseDisk: Recognize scsi-passthru

2015-09-01 Thread Matthias Bolte
Ok here's my patch for this: https://www.redhat.com/archives/libvir-list/2015-September/msg5.html Regards, Matthias 2015-08-28 12:08 GMT+02:00 Matthias Bolte : > 2015-08-28 11:36 GMT+02:00 Michal Privoznik : >>

[libvirt] [PATCH 0/3] vmx: Add handling for CDROM devices with SCSI passthru and other minor fixes

2015-09-01 Thread Matthias Bolte
This patch series addresses this bug report: https://bugzilla.redhat.com/show_bug.cgi?id=1172544 It's mean as a replacement for this patch: https://www.redhat.com/archives/libvir-list/2015-August/msg00970.html Matthias Bolte (3): vmx: Some whitespace cleanup vmx: The virVMXParseDisk

[libvirt] [PATCH 2/3] vmx: The virVMXParseDisk deviceType can be NULL, add some missing checks

2015-09-01 Thread Matthias Bolte
--- src/vmx/vmx.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index ba4d046..9d1574f 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -2178,8 +2178,9 @@ virVMXParseDisk(virVMXContext *ctx, virDomainXMLOptionPtr

[libvirt] [PATCH 1/3] vmx: Some whitespace cleanup

2015-09-01 Thread Matthias Bolte
--- src/vmx/vmx.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 36e2891..ba4d046 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -2,7 +2,7 @@ * vmx.c: VMware VMX parsing/formatting functions * *

[libvirt] [PATCH 3/3] vmx: Add handling for CDROM devices with SCSI passthru

2015-09-01 Thread Matthias Bolte
https://bugzilla.redhat.com/show_bug.cgi?id=1172544 --- src/vmx/vmx.c | 36 -- tests/vmx2xmldata/vmx2xml-cdrom-scsi-passthru.vmx | 6 ++ tests/vmx2xmldata/vmx2xml-cdrom-scsi-passthru.xml | 24 +++ tests/vmx2xmldata/vmx2xml-esx-in-the-wild-7.vmx |

Re: [libvirt] [PATCH] docs: Drop unused rule for internals/%.html.tmp target

2015-09-01 Thread Michal Privoznik
On 31.08.2015 18:11, Guido Günther wrote: > On Mon, Aug 31, 2015 at 05:22:23PM +0200, Martin Kletzander wrote: >> On Thu, Aug 20, 2015 at 10:50:54AM +0200, Guido Günther wrote: >>> On Thu, Aug 20, 2015 at 03:12:36AM +0200, Michal Privoznik wrote: On 19.08.2015 14:40, Guido Günther wrote:

Re: [libvirt] [PATCH v3 2/5] vz: add migration backbone code

2015-09-01 Thread Daniel P. Berrange
On Mon, Aug 31, 2015 at 11:40:55AM +0300, Nikolay Shirokovskiy wrote: > > > On 28.08.2015 19:37, Daniel P. Berrange wrote: > > On Fri, Aug 28, 2015 at 12:18:30PM +0300, Nikolay Shirokovskiy wrote: > >> > >> > >> On 27.08.2015 13:34, Daniel P. Berrange wrote: > >>> On Tue, Aug 25, 2015 at