Re: [libvirt] [sandbox PATCH v3 01/22] Add virt-sandbox-image

2015-09-04 Thread Daniel P. Berrange
On Tue, Aug 18, 2015 at 06:53:22AM +, Eren Yagdiran wrote: > From: Daniel P Berrange > > virt-sandbox-image.py is a python script that lets you download Docker > images easily. It is a proof of concept code and consumes Docker Rest API. > --- > po/POTFILES.in

Re: [libvirt] [sandbox PATCH v4 01/21] Add virt-sandbox-image

2015-09-04 Thread Daniel P. Berrange
On Fri, Aug 28, 2015 at 01:47:29PM +, Eren Yagdiran wrote: > From: Daniel P Berrange > > virt-sandbox-image.py is a python script that lets you download Docker > images easily. It is a proof of concept code and consumes Docker Rest API. > --- > po/POTFILES.in

Re: [libvirt] [PATCH 0/4] Several virsh initialization adjustments

2015-09-04 Thread Erik Skultety
On 04/09/15 13:47, Ján Tomko wrote: > On Fri, Sep 04, 2015 at 01:10:02PM +0200, Erik Skultety wrote: >> When looking at commit 4fdd873f, I've come to notice, that after my changes >> to >> virsh (834c5720), vshInit always calls vshReadlineInit and that is because >> client mode defaults to

Re: [libvirt] [sandbox PATCH v4 02/21] Fix virt-sandbox-image

2015-09-04 Thread Daniel P. Berrange
On Fri, Aug 28, 2015 at 01:47:30PM +, Eren Yagdiran wrote: > Authentication fix for Docker REST API. > --- > virt-sandbox-image/virt-sandbox-image.py | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) ACK Regards, Daniel -- |: http://berrange.com -o-

[libvirt] [PATCH 3/4] vsh: Introduce vshInitReload

2015-09-04 Thread Erik Skultety
Commit a0b6a36f separated vshInitDebug from the original vshInit (before virsh got split and vshInit became virshInit - commit 834c5720) in order to be able to debug command line parsing. After the parsing is finished, debugging is reinitialized to work properly. There might as well be other

Re: [libvirt] [sandbox PATCH v4 05/21] Image: Discard caching bytecode

2015-09-04 Thread Daniel P. Berrange
On Fri, Aug 28, 2015 at 01:47:33PM +, Eren Yagdiran wrote: > --- > virt-sandbox-image/virt-sandbox-image.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/virt-sandbox-image/virt-sandbox-image.py > b/virt-sandbox-image/virt-sandbox-image.py > index 55aea6a..9e98bf2 100755 > ---

[libvirt] [PATCH sandbox 2/4] Sync and unmount filesystems during shutdown

2015-09-04 Thread Daniel P. Berrange
To ensure that all pending I/O for filesytems backed by block devices is flushed to disk, it is important to sync and unmount the filesystems during shutdown. To avoid relying on the kernel reboot-on-panic behaviour, we also explicitly call reboot to power off the guest. Signed-off-by: Daniel P.

[libvirt] [PATCH sandbox 3/4] Fix passing of strace option to guest kernel

2015-09-04 Thread Daniel P. Berrange
The libvirt-sandbox-init-qemu command expects to see 'strace=' or 'strace=some,list,of,syscalls' but we only passed 'strace'. This meant strace could never be enabled. Signed-off-by: Daniel P. Berrange --- libvirt-sandbox/libvirt-sandbox-builder-machine.c | 7 ++-

[libvirt] [PATCH 0/2] Change name of the domain upon successful rename

2015-09-04 Thread Martin Kletzander
Try running the example added in 1/2 before and after applying 2/2. Martin Kletzander (2): Add example that renames domain there and back Change name of the domain upon successful rename .gitignore | 1 + configure.ac | 1 + examples/rename/Makefile.am |

Re: [libvirt] [PATCH v2 2/2] virsh: Enhance the detailed output of domblklist for networked source

2015-09-04 Thread John Ferlan
On 09/04/2015 04:26 AM, Michal Privoznik wrote: > On 03.09.2015 22:47, John Ferlan wrote: >> >> >> On 09/02/2015 11:58 AM, Michal Privoznik wrote: >>> From: Lin Ma >>> >>> Format & output more detailed information about networked source >>> >>> e.g: The output without the patch:

Re: [libvirt] [sandbox PATCH v4 04/21] Image: virt-sandbox-image default dir constants

2015-09-04 Thread Daniel P. Berrange
On Fri, Aug 28, 2015 at 01:47:32PM +, Eren Yagdiran wrote: > Conflicts: > virt-sandbox-image/virt-sandbox-image.py > --- > virt-sandbox-image/virt-sandbox-image.py | 8 > 1 file changed, 8 insertions(+) > > diff --git a/virt-sandbox-image/virt-sandbox-image.py >

Re: [libvirt] [sandbox PATCH v4 03/21] Image: Add Hooking Mechanism

2015-09-04 Thread Daniel P. Berrange
On Fri, Aug 28, 2015 at 01:47:31PM +, Eren Yagdiran wrote: > Any custom source provider can be added to virt-sandbox-image as a source > --- > .gitignore | 1 + > bin/Makefile.am | 16 > bin/virt-sandbox-image.in

Re: [libvirt] [PATCH v2 0/2] Need to perform address checks for ccw/s390

2015-09-04 Thread Ján Tomko
On Thu, Sep 03, 2015 at 02:51:54PM -0400, John Ferlan wrote: > Assumptions were made that if someone provided an address type ccw or > s390 that it would occur only if using an enabled emulator. Turns out > that premise isn't necessarily true and it leads to libvirtd crashing > for hotplugs and

Re: [libvirt] [PATCH 1/2] Add example that renames domain there and back

2015-09-04 Thread Daniel P. Berrange
On Fri, Sep 04, 2015 at 02:10:07PM +0200, Martin Kletzander wrote: > And in the middle it prints out its name to demonstrate changes in later > patch(es). > > Signed-off-by: Martin Kletzander > --- > .gitignore | 1 + > configure.ac| 1 + >

Re: [libvirt] [PATCH 2/2] Change name of the domain upon successful rename

2015-09-04 Thread Daniel P. Berrange
On Fri, Sep 04, 2015 at 02:10:08PM +0200, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > src/remote/remote_driver.c | 41 + > src/remote/remote_protocol.x | 2 +- > 2 files changed, 42 insertions(+), 1

Re: [libvirt] [sandbox PATCH v4 06/21] Image: Add check_writable and runtime resolver

2015-09-04 Thread Daniel P. Berrange
On Fri, Aug 28, 2015 at 01:47:34PM +, Eren Yagdiran wrote: > These helper functions are for selecting right directories according > to running user privileges > --- > virt-sandbox-image/virt-sandbox-image.py | 27 ++- > 1 file changed, 26 insertions(+), 1 deletion(-) >

[libvirt] [PATCH 0/4] Several virsh initialization adjustments

2015-09-04 Thread Erik Skultety
When looking at commit 4fdd873f, I've come to notice, that after my changes to virsh (834c5720), vshInit always calls vshReadlineInit and that is because client mode defaults to interactive which might be changed after command line arguments are parsed. So this series addresses this minor issue

[libvirt] [PATCH 4/4] vsh: Make vshInitDebug static

2015-09-04 Thread Erik Skultety
There's no reason why debug initialization could not be made completely hidden, just like readline initialization is. The point of the global initializer vshInit is to make initialization of smaller features transparent to the user/caller. --- tools/vsh.c | 2 +- tools/vsh.h | 1 - 2 files

[libvirt] [PATCH 2/4] vsh: adjust vshInit signature and remove redundant error label

2015-09-04 Thread Erik Skultety
As part of the effort to stay consistent, change the vshInit signature from returning int to returning bool. Moreover, remove the unnecessary error label as there is no cleanup that would make use of it. --- tools/virsh.c | 2 +- tools/vsh.c | 14 +- tools/vsh.h | 2 +- 3 files

Re: [libvirt] [PATCH 3/4] vsh: Introduce vshInitReload

2015-09-04 Thread Ján Tomko
On Fri, Sep 04, 2015 at 01:10:05PM +0200, Erik Skultety wrote: > Commit a0b6a36f separated vshInitDebug from the original vshInit > (before virsh got split and vshInit became virshInit - commit 834c5720) > in order to be able to debug command line parsing. > After the parsing is finished,

[libvirt] [PATCH 1/2] Add example that renames domain there and back

2015-09-04 Thread Martin Kletzander
And in the middle it prints out its name to demonstrate changes in later patch(es). Signed-off-by: Martin Kletzander --- .gitignore | 1 + configure.ac| 1 + examples/rename/Makefile.am | 24 +++ examples/rename/rename.c|

[libvirt] [PATCH 2/2] Change name of the domain upon successful rename

2015-09-04 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- src/remote/remote_driver.c | 41 + src/remote/remote_protocol.x | 2 +- 2 files changed, 42 insertions(+), 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c

Re: [libvirt] [PATCH 0/4] Several virsh initialization adjustments

2015-09-04 Thread Ján Tomko
On Fri, Sep 04, 2015 at 01:10:02PM +0200, Erik Skultety wrote: > When looking at commit 4fdd873f, I've come to notice, that after my changes to > virsh (834c5720), vshInit always calls vshReadlineInit and that is because > client mode defaults to interactive which might be changed after command

Re: [libvirt] [PATCH 1/4] virsh: Do not make interactive mode default

2015-09-04 Thread Ján Tomko
On Fri, Sep 04, 2015 at 01:10:03PM +0200, Erik Skultety wrote: > Currently, we set interactive mode as default possibly reverting the > setting after we parse the command line arguments. There's nothing > particulary wrong with that, but a call to vshReadlineInit is performed > always in the

[libvirt] [PATCH v2] examples: Add example polkit ACL rules

2015-09-04 Thread Jiri Denemark
Creating ACL rules is not exactly easy and existing examples are pretty simple. This patch adds a somewhat complex example which defines several roles. Admins can do everything, operators can do basic operations on any domain and several groups of users who act as operators but only on a limited

Re: [libvirt] [PATCH v2] examples: Add example polkit ACL rules

2015-09-04 Thread Daniel P. Berrange
On Fri, Sep 04, 2015 at 02:19:09PM +0200, Jiri Denemark wrote: > Creating ACL rules is not exactly easy and existing examples are pretty > simple. This patch adds a somewhat complex example which defines several > roles. Admins can do everything, operators can do basic operations > on any domain

Re: [libvirt] [PATCH v4 5/6] vz: support misc migration options

2015-09-04 Thread Nikolay Shirokovskiy
On 04.09.2015 11:44, Daniel P. Berrange wrote: > On Fri, Sep 04, 2015 at 10:42:00AM +0300, Nikolay Shirokovskiy wrote: >> >> >> On 03.09.2015 20:04, Daniel P. Berrange wrote: >>> On Wed, Sep 02, 2015 at 03:09:26PM +0300, Nikolay Shirokovskiy wrote: From: nshirokovs...@virtuozzo.com

Re: [libvirt] [PATCH v4 2/6] vz: add migration backbone code

2015-09-04 Thread Nikolay Shirokovskiy
On 04.09.2015 11:40, Daniel P. Berrange wrote: > On Fri, Sep 04, 2015 at 10:56:52AM +0300, Nikolay Shirokovskiy wrote: @@ -1396,6 +1585,9 @@ static virHypervisorDriver vzDriver = { .domainBlockStatsFlags = vzDomainBlockStatsFlags, /* 1.2.17 */ .domainInterfaceStats =

[libvirt] [PATCH 1/4] virsh: Do not make interactive mode default

2015-09-04 Thread Erik Skultety
Currently, we set interactive mode as default possibly reverting the setting after we parse the command line arguments. There's nothing particulary wrong with that, but a call to vshReadlineInit is performed always in the global initializer just because the default mode is interactive. Rather than

[libvirt] [PATCH sandbox 4/4] Don't close immediately when getting EOF on RPC console

2015-09-04 Thread Daniel P. Berrange
The RPC console is closed when the libvirt-sandbox-init-common binary reports the exit of the guest process. We still have some cleanup code that runs in the guest, for example, syncing and ummounting filesystems. We want to be able to see debug and/or error messages from this code, so we should

[libvirt] [PATCH sandbox 0/4] Fix data retention with QEMU sandboxes

2015-09-04 Thread Daniel P. Berrange
In testing the docker sandbox patches I found that with QEMU sandboxes, we would randomly loose data written to the block device. This meant that after untar'ing the image contents into the qcow2 the filesystem was left empty! Eventually I realized that there was no where we are calling sync() to

[libvirt] [PATCH sandbox 1/4] push changing of user ID down into child process

2015-09-04 Thread Daniel P. Berrange
When running interactive sandboxes, don't drop privileges in the long running libvirt-sandbox-init-common process. This needs to be privileged in order to sync, unmount and shutdown the guest when the user command is finished. Push changing of user ID into the child process, between fork & exec.

Re: [libvirt] [sandbox PATCH v4 11/21] Image: Add run args

2015-09-04 Thread Daniel P. Berrange
On Fri, Aug 28, 2015 at 01:47:39PM +, Eren Yagdiran wrote: > Commandline parameters for running a template > --- > virt-sandbox-image/virt-sandbox-image.py | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/virt-sandbox-image/virt-sandbox-image.py >

[libvirt] [PATCH v5 2/5] vz: add migration backbone code

2015-09-04 Thread Nikolay Shirokovskiy
From: nshirokovs...@virtuozzo.com This patch makes basic vz migration possible. For example by virsh: virsh -c vz:///system migrate $NAME vz+ssh://$DST/system --p2p Vz migration is implemented as p2p migration. The reason is that vz sdk do all the job. The question

[libvirt] [PATCH v5 1/5] vz: save session uuid on login

2015-09-04 Thread Nikolay Shirokovskiy
This session uuid acts as authN token for different multihost vz operations one of which is migration. Unfortunately we can't get it from server at any time thus we need to save it at login. Signed-off-by: Nikolay Shirokovskiy --- src/vz/vz_sdk.c | 39

[libvirt] [PATCH v5 0/5] vz: add migration support

2015-09-04 Thread Nikolay Shirokovskiy
NOTE that minimal command to migrate vz domain is like next: virsh -c vz:///system migrate 200 vz+ssh://shiny0/system --p2p --live --compressed --persistent --undefinesource Difference from v4: 1. move preparation of the migration uri from src to dst as dst intended to do it. 2. change

Re: [libvirt] [PATCH v2] examples: Add example polkit ACL rules

2015-09-04 Thread Jiri Denemark
On Fri, Sep 04, 2015 at 14:19:09 +0200, Jiri Denemark wrote: > Creating ACL rules is not exactly easy and existing examples are pretty > simple. This patch adds a somewhat complex example which defines several > roles. Admins can do everything, operators can do basic operations > on any domain and

[libvirt] [PATCH 5/5] conf: Remove need for a couple of sa_asserts

2015-09-04 Thread John Ferlan
Remove the need for a couple of sa_asserts. Signed-off-by: John Ferlan --- src/conf/domain_conf.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f95190f..6df1618 100644 ---

[libvirt] [PATCH 2/5] lxc: Avoid Coverity SIZEOF_MISMATCH

2015-09-04 Thread John Ferlan
Commit id '692e9fac7' used virProcessSetNamespaces instead of inlining the similar functionality; however, Coverity notes that the function prototype expects a size_t value and not an enum and complains. So, just pass as a size_t to avoid the noise. Signed-off-by: John Ferlan

[libvirt] [PATCH 1/5] qemu: Check virGetLastError return value for migration finish failure

2015-09-04 Thread John Ferlan
Commit id '2e7cea243' added a check for an error from Finish instead of 'unexpected error'; however, if for some reason there wasn't an error, then virGetLastError could return NULL resulting in the NULL pointer deref to err->domain. Signed-off-by: John Ferlan ---

[libvirt] [PATCH 4/5] util: Avoid Coverity FORWARD_NULL

2015-09-04 Thread John Ferlan
Coverity claims it could be possible to call virDBusTypeStackFree with *stack == NULL and although the two API's that call it don't appear to allow that - I suppose it's better to be safe than sorry Signed-off-by: John Ferlan --- src/util/virdbus.c | 4 1 file changed,

[libvirt] [PATCH] cpu: Introduce IvyBridge CPU model

2015-09-04 Thread Jiri Denemark
https://bugzilla.redhat.com/show_bug.cgi?id=1254420 Signed-off-by: Jiri Denemark --- src/cpu/cpu_map.xml | 49 + 1 file changed, 49 insertions(+) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index d2469ee..51aa899

[libvirt] [PATCH v5 4/5] vz: support misc migration options

2015-09-04 Thread Nikolay Shirokovskiy
From: nshirokovs...@virtuozzo.com Migration API has a lot of options. This patch intention is to provide support for those options that can be trivially supported and give estimation for other options support in this commit message. I. Supported. 1.

[libvirt] [PATCH v5 5/5] vz: cleanup: define vz format of uuids

2015-09-04 Thread Nikolay Shirokovskiy
vz puts uuids into curly braces. Simply introduce new contstant to reflect this and get rid of magic +2 in code. Signed-off-by: Nikolay Shirokovskiy --- src/vz/vz_sdk.c | 12 ++-- src/vz/vz_utils.h |2 ++ 2 files changed, 8 insertions(+), 6

[libvirt] [PATCH v5 3/5] vz: support domain rename on migrate

2015-09-04 Thread Nikolay Shirokovskiy
From: nshirokovs...@virtuozzo.com Signed-off-by: Nikolay Shirokovskiy --- src/vz/vz_driver.c |9 - src/vz/vz_sdk.c| 16 +--- src/vz/vz_sdk.h|5 - 3 files changed, 21 insertions(+), 9

Re: [libvirt] [sandbox PATCH v4 13/21] Image: Add get_disk function to Source

2015-09-04 Thread Daniel P. Berrange
On Fri, Aug 28, 2015 at 01:47:41PM +, Eren Yagdiran wrote: > Provide a way to know which disk image to use for the sandbox depending on > the used source > DockerSource will need to locate the topmost disk image among all the layers > images > --- >

Re: [libvirt] [sandbox PATCH v4 14/21] Image: Add run function

2015-09-04 Thread Daniel P. Berrange
On Fri, Aug 28, 2015 at 01:47:42PM +, Eren Yagdiran wrote: > Run an already-built template > If there is no execution command specified by user, source.get_command will > find the command to invoke > --- > virt-sandbox-image/virt-sandbox-image.py | 25 + > 1 file

[libvirt] [PATCH 3/5] virfile: Avoid Coverity IDENTICAL_BRANCHES error

2015-09-04 Thread John Ferlan
In virFileNBDDeviceFindUnused if virFileNBDDeviceIsBusy returns 0, then both branches jumped to cleanup, so just use ignore_value since the function returns NULL or some memory and the caller handles the error. Signed-off-by: John Ferlan --- src/util/virfile.c | 3 +-- 1

[libvirt] [PATCH 0/5] Resolve some Coverity related errors

2015-09-04 Thread John Ferlan
Patches 1, 3, & 4 show up periodically in my Coverity runs, but not always. Usually only when some sort of self inflicted build error only gets a partial build followed by a complete analysis phase. Patch 2 is related to a Coverity error seen in private integration testing as well. Although it

Re: [libvirt] [PATCH v5 0/5] vz: add migration support

2015-09-04 Thread Maxim Nestratov
04.09.2015 17:18, Nikolay Shirokovskiy пишет: NOTE that minimal command to migrate vz domain is like next: virsh -c vz:///system migrate 200 vz+ssh://shiny0/system --p2p --live --compressed --persistent --undefinesource Difference from v4: 1. move preparation of the migration uri from src

Re: [libvirt] [PATCH v2] examples: Add example polkit ACL rules

2015-09-04 Thread Jiri Denemark
On Fri, Sep 04, 2015 at 13:26:17 +0100, Daniel P. Berrange wrote: > On Fri, Sep 04, 2015 at 02:19:09PM +0200, Jiri Denemark wrote: > > Creating ACL rules is not exactly easy and existing examples are pretty > > simple. This patch adds a somewhat complex example which defines several > > roles.

[libvirt] [PATCH sandbox] Require libvirt-glib >= 0.2.2 for LXC fsdriver format fix

2015-09-04 Thread Daniel P. Berrange
Versions of libvirt-glib < 0.2.2 are buggy when configuring the format/driver attributes, causing the disk to be setup as a plain volume instead of nbd. Signed-off-by: Daniel P. Berrange --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH v5 0/5] vz: add migration support

2015-09-04 Thread Maxim Nestratov
04.09.2015 17:48, Maxim Nestratov пишет: 04.09.2015 17:18, Nikolay Shirokovskiy пишет: NOTE that minimal command to migrate vz domain is like next: virsh -c vz:///system migrate 200 vz+ssh://shiny0/system --p2p --live --compressed --persistent --undefinesource Difference from v4: 1. move

Re: [libvirt] [PATCH sandbox] Require libvirt-glib >= 0.2.2 for LXC fsdriver format fix

2015-09-04 Thread Cedric Bosdonnat
On Fri, 2015-09-04 at 16:30 +0100, Daniel P. Berrange wrote: > Versions of libvirt-glib < 0.2.2 are buggy when configuring the > format/driver attributes, causing the disk to be > setup as a plain volume instead of nbd. ACK -- Cedric > Signed-off-by: Daniel P. Berrange >

Re: [libvirt] [PATCH 1/5] qemu: Check virGetLastError return value for migration finish failure

2015-09-04 Thread Laine Stump
On 09/04/2015 10:30 AM, John Ferlan wrote: Commit id '2e7cea243' added a check for an error from Finish instead of 'unexpected error'; however, if for some reason there wasn't an error, then virGetLastError could return NULL resulting in the NULL pointer deref to err->domain. ACK. --

Re: [libvirt] [PATCH libvirt master v2] interface type: add udp socket support

2015-09-04 Thread Jonathan Toppins
On 09/02/2015 04:23 AM, Ján Tomko wrote: On Sat, Aug 29, 2015 at 04:19:10PM -0400, Jonathan Toppins wrote: Adds a new interface type using UDP sockets, this seems only applicable to QEMU but have edited tree-wide to support the new interface type. The interface type required the addition of a

Re: [libvirt] [PATCH 5/5] conf: Remove need for a couple of sa_asserts

2015-09-04 Thread Laine Stump
On 09/04/2015 10:31 AM, John Ferlan wrote: Remove the need for a couple of sa_asserts. Signed-off-by: John Ferlan --- src/conf/domain_conf.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

Re: [libvirt] [PATCH 2/5] lxc: Avoid Coverity SIZEOF_MISMATCH

2015-09-04 Thread Laine Stump
On 09/04/2015 10:30 AM, John Ferlan wrote: Commit id '692e9fac7' used virProcessSetNamespaces instead of inlining the similar functionality; however, Coverity notes that the function prototype expects a size_t value and not an enum and complains. So, just pass as a size_t to avoid the noise.

Re: [libvirt] [PATCH 3/5] virfile: Avoid Coverity IDENTICAL_BRANCHES error

2015-09-04 Thread Laine Stump
On 09/04/2015 10:31 AM, John Ferlan wrote: In virFileNBDDeviceFindUnused if virFileNBDDeviceIsBusy returns 0, then both branches jumped to cleanup, so just use ignore_value since the function returns NULL or some memory and the caller handles the error. Signed-off-by: John Ferlan

Re: [libvirt] [PATCH 4/5] util: Avoid Coverity FORWARD_NULL

2015-09-04 Thread Laine Stump
On 09/04/2015 10:31 AM, John Ferlan wrote: Coverity claims it could be possible to call virDBusTypeStackFree with *stack == NULL and although the two API's that call it don't appear to allow that - I suppose it's better to be safe than sorry Signed-off-by: John Ferlan ---

Re: [libvirt] [PATCH v2 2/2] virsh: Enhance the detailed output of domblklist for networked source

2015-09-04 Thread Lin Ma
在 2015年09月04日 18:53, John Ferlan 写道: On 09/04/2015 04:26 AM, Michal Privoznik wrote: On 03.09.2015 22:47, John Ferlan wrote: On 09/02/2015 11:58 AM, Michal Privoznik wrote: From: Lin Ma Format & output more detailed information about networked source e.g: The output

Re: [libvirt] [PATCH 2/5] lxc: Avoid Coverity SIZEOF_MISMATCH

2015-09-04 Thread John Ferlan
On 09/04/2015 01:41 PM, Laine Stump wrote: > On 09/04/2015 10:30 AM, John Ferlan wrote: >> Commit id '692e9fac7' used virProcessSetNamespaces instead of inlining >> the similar functionality; however, Coverity notes that the function >> prototype expects a size_t value and not an enum and

Re: [libvirt] [PATCH v4 5/6] vz: support misc migration options

2015-09-04 Thread Nikolay Shirokovskiy
On 03.09.2015 20:04, Daniel P. Berrange wrote: > On Wed, Sep 02, 2015 at 03:09:26PM +0300, Nikolay Shirokovskiy wrote: >> From: nshirokovs...@virtuozzo.com >> >> Migration API has a lot of options. This patch intention is to provide >> support for those options that

Re: [libvirt] [PATCH v4 2/6] vz: add migration backbone code

2015-09-04 Thread Nikolay Shirokovskiy
On 03.09.2015 19:45, Daniel P. Berrange wrote: > On Wed, Sep 02, 2015 at 03:09:23PM +0300, Nikolay Shirokovskiy wrote: >> From: nshirokovs...@virtuozzo.com >> >> This patch makes basic vz migration possible. For example by virsh: >> >> virsh -c vz:///system migrate

Re: [libvirt] [PATCH v2 2/2] virsh: Enhance the detailed output of domblklist for networked source

2015-09-04 Thread Lin Ma
Just tested the patch, It works well. The changes makes more sense, Thanks for helping me to improve the patch! 在 2015年09月02日 23:58, Michal Privoznik 写道: From: Lin Ma Format & output more detailed information about networked source e.g: The output without the patch: $ virsh

Re: [libvirt] [RFC PATCH 0/3] Implement mockup capabilities cache in QEMU tests

2015-09-04 Thread Pavel Fedin
Hello! > It's just an assert. We have those for various reasons and extra > carefulness cannot hurt. I don't think it needs differentiating > between whether the code is ran in tests or not. It would need differentiating because in tests we should not talk to the real filesystem, while in

Re: [libvirt] [PATCH V2] libxl: don't overwrite error from virNetSocketNewConnectTCP()

2015-09-04 Thread Michal Privoznik
On 03.09.2015 22:55, John Ferlan wrote: > > > On 09/03/2015 01:40 PM, Jim Fehlig wrote: >> Remove redundant error reporting in libxlDomainMigrationPerform(). >> virNetSocketNewConnectTCP() is perfectly capable of reporting >> sensible errors. >> >> Signed-off-by: Jim Fehlig >>

Re: [libvirt] [PATCH v2 2/2] virsh: Enhance the detailed output of domblklist for networked source

2015-09-04 Thread Michal Privoznik
On 03.09.2015 22:47, John Ferlan wrote: > > > On 09/02/2015 11:58 AM, Michal Privoznik wrote: >> From: Lin Ma >> >> Format & output more detailed information about networked source >> >> e.g: The output without the patch: >> $ virsh domblklist $DOMAIN --details >> Type

Re: [libvirt] [PATCH v4 2/6] vz: add migration backbone code

2015-09-04 Thread Daniel P. Berrange
On Fri, Sep 04, 2015 at 10:56:52AM +0300, Nikolay Shirokovskiy wrote: > >> @@ -1396,6 +1585,9 @@ static virHypervisorDriver vzDriver = { > >> .domainBlockStatsFlags = vzDomainBlockStatsFlags, /* 1.2.17 */ > >> .domainInterfaceStats = vzDomainInterfaceStats, /* 1.2.17 */ > >>

Re: [libvirt] [PATCH v4 5/6] vz: support misc migration options

2015-09-04 Thread Daniel P. Berrange
On Fri, Sep 04, 2015 at 10:42:00AM +0300, Nikolay Shirokovskiy wrote: > > > On 03.09.2015 20:04, Daniel P. Berrange wrote: > > On Wed, Sep 02, 2015 at 03:09:26PM +0300, Nikolay Shirokovskiy wrote: > >> From: nshirokovs...@virtuozzo.com > >> > >> Migration API has a