From: Chen Hanxiao
Use toadd->use directly.
Signed-off-by: Chen Hanxiao
---
src/util/virbuffer.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/util/virbuffer.c b/src/util/virbuffer.c
index 5b338f8..55dad37 100644
--- a/src/util/virbuffer.c
+++ b/src/util/virbuffer
On 11/13/2015 10:00 AM, Dario Faggioli wrote:
> Hello,
>
> The Xen Project's automated test suite is failing at running its
> libvirt tests for a few time, like this:
>
> On Wed, 2015-11-04 at 09:04 +, osstest service owner wrote:
>> flight 63528 libvirt real [real]
>> http://logs.test-lab.xenp
2015-11-13 0:30 GMT+02:00 Jiri Denemark :
> On Thu, Nov 12, 2015 at 23:47:54 +0200, noxdafox wrote:
> > Greetings,
> >
> > I was investigating on an issue in which QEMU's dynamic ownership was
> > not properly working when calling qemuDomainCoreDumpWithFormat().
>
> Could describe this issue you a
Prior to this patch, libxl events were delivered to libvirt via
the libxlDomainEventHandler callback registered with libxl.
Documenation in $xensrc/tools/libxl/libxl_event.h states that the
callback "may occur on any thread in which the application calls
libxl". This can result in deadlock since ma
Hi,
>> +guint settime_flags;
>> +
>> +g_return_val_if_fail(GVIR_IS_DOMAIN(dom), FALSE);
>> +g_return_val_if_fail(err == NULL || *err == NULL, FALSE);
>
> I'd keep a g_return_val_if_fail(flags == 0, FALSE);
But doesn't that make G_GNUC_UNUSED declaration wrong then? I think
it's more i
KVM can't virtualize rdtscp on AMD CPUs yet, so there's no point
in enabling it by default on AMD CPU models, as all we are
getting are confused users because of the "host doesn't support
requested feature" warnings.
Disable rdtscp on Opteron_G* models, but keep compatibility on
pc-*-2.4 and older
On Fri, Nov 13, 2015 at 11:25:14 +0100, Peter Krempa wrote:
> On Thu, Nov 12, 2015 at 19:37:10 +0100, Jiri Denemark wrote:
> > Traditionally, we pass incoming migration URI on QEMU command line,
> > which has some drawbacks. Depending on the URI QEMU may initialize its
> > migration state immediate
Libvirt already has two types of panic devices - pvpanic and pSeries firmware.
This patch introduces the 'model' attribute and a new type of panic device.
'isa' model is for ISA pvpanic device.
'pseries' model is a default value for pSeries guests.
'hyperv' model is the new type. It's used for Hyp
Panic device type used depends on 'model' attribute.
If no model is specified then device type depends on hypervisor
and guest arch. 'pseries' model is used for pSeries guest and
'isa' model is used in other cases.
XML:
QEMU command line:
qemu -cpu ,hv_crash
---
src/qemu/qemu_command.c | 6
'model' attribute was added to a panic device but only one panic
device is allowed. This patch changes panic device presence
from 'optional' to 'zeroOrMore'.
---
docs/formatdomain.html.in | 1 +
docs/schemas/domaincommon.rng | 4 +--
src/conf/domain_conf.c| 73 ++-
---
tests/qemuargv2xmltest.c | 1 +
.../qemuxml2argv-hyperv-panic.args | 21 +++
.../qemuxml2argvdata/qemuxml2argv-hyperv-panic.xml | 25 +
.../qemuxml2argv-panic-double.args | 21 +++
.../qemuxml2ar
A new Hyper-V cpu feature 'hv_crash' was added to QEMU. The feature
will become available in v2.5.0.
What is changed in v4:
* panic model attribute is added even if it wasn't specified
by the user [5/6], tests updated.
* configuration with multiple panic defices of same model is
rejected [
Only one panic device per model is allowed.
---
src/conf/domain_conf.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 2f17675..b4a46ad 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -3747,6
Choose 'ise' or 'pseries' model for panic device 'default' model
value.
Fixed tests and add two new outputs for xml-2-xml tests.
Set value
---
src/qemu/qemu_command.c| 14 ++
src/qemu/qemu_domain.c | 9 +++
.../qemuxml2argvdata
Hello,
The Xen Project's automated test suite is failing at running its
libvirt tests for a few time, like this:
On Wed, 2015-11-04 at 09:04 +, osstest service owner wrote:
> flight 63528 libvirt real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/63528/
>
> Regressions :-(
>
> T
virCgroupNewMachine used to add the pidleader to the newly created
machine cgroup. Do not do this implicit anymore.
Signed-off-by: Henning Schild
---
src/lxc/lxc_cgroup.c | 6 ++
src/qemu/qemu_cgroup.c | 6 ++
src/util/vircgroup.c | 22 --
3 files changed, 12 in
Hi,
i already explained some of the cgroup problems in some detail so i
will not do that again.
https://www.redhat.com/archives/libvir-list/2015-October/msg00876.html
I managed to solve some of the problems in the current codebase, and
am now sharing the patches. But they are really just half of
Moving tasks to cgroups implied sched_setaffinity. Changing the cpus in
a set implies the same for all tasks in the group.
The old code put the the thread into the cpuset inherited from the
machine cgroup, which allowed it to run outside of vcpupin for a short
while.
Signed-off-by: Henning Schild
The machine cgroup is a superset, a parent to the emulator and vcpuX
cgroups. The parent cgroup should never have any tasks directly in it.
In fact the parent cpuset might contain way more cpus than the sum of
emulatorpin and vcpupins. So putting tasks in the superset will allow
them to run outside
On Thu, Nov 12, 2015 at 19:37:25 +0100, Jiri Denemark wrote:
> NBD storage migration will not work with offline migration anyway and we
> already checked that the user did not ask for it. Thus it doesn't make
> sense to keep the code after 'done' label where we jump in case of
> offline migration.
On Thu, Nov 12, 2015 at 19:37:24 +0100, Jiri Denemark wrote:
> Some failure paths in qemuMigrationPrepareAny forgot to kill the just
> started QEMU process. This patch fixes this by combining 'stop' and
> 'endjob' label into a new label 'stopjob'. This name was chosen to avoid
> confusion with the
On 11/12/2015 01:37 PM, Jiri Denemark wrote:
> Finishes starting a new domain launched by qemuProcessLaunch.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 76
> +
> src/qemu/qemu_process.h | 6
> 2 files changed, 57 in
On 11/12/2015 01:37 PM, Jiri Denemark wrote:
> Once qemuProcessInit was called, qemuProcessLaunch will launch a new
> QEMU process with stopped virtual CPUs.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 162
>
> src/qemu/q
On Thu, Nov 12, 2015 at 19:37:23 +0100, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_migration.c | 154
> +-
> 1 file changed, 85 insertions(+), 69 deletions(-)
>
ACK
signature.asc
Description: Digital signature
--
libv
On Thu, Nov 12, 2015 at 19:37:22 +0100, Jiri Denemark wrote:
> Finishes starting a new domain launched by qemuProcessLaunch.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 76
> +
> src/qemu/qemu_process.h | 6
> 2 files
On Thu, Nov 12, 2015 at 19:37:21 +0100, Jiri Denemark wrote:
> Once qemuProcessInit was called, qemuProcessLaunch will launch a new
> QEMU process with stopped virtual CPUs.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 162
>
On 12-11-15 23:04, Claudio Bley wrote:
> Hi.
>
> At Mon, 9 Nov 2015 13:48:18 +0100,
> Wido den Hollander wrote:
>>
>> This allows us to send Qemu Guest Agent commands to running domains.
>>
>> Signed-off-by: Wido den Hollander
>> ---
>> src/main/java/org/libvirt/Domain.java | 36
>>
On Thu, Nov 12, 2015 at 19:37:20 +0100, Jiri Denemark wrote:
> qemuProcessStart is going to be split in three parts: qemuProcessInit,
> qemuProcessLaunch, and qemuProcessFinish so that migration Prepare phase
> can insert additional code in the process. qemuProcessStart will be a
> small wrapper fo
Introduce support for connectGetAllDomainStats call that
allow us to _all_ domain(s) statistics including network, block,
cpus and memory. Changes are rather mechanical and mostly
take care of the format to export the data.
Signed-off-by: Joao Martins
---
Changes since v1:
- Rework flags checkin
Hey,
[ Apologies for resending this series before receiving comments, but I
found two issues (namely on patch 3 and 4) and thus I am reposting it
as v3 having those fixed. ]
This series bring support for various statistics about domains
regarding CPU, Memory, Network Interfaces, Block and Job
Introduces support for domainGetJobStats which has the same
info as domainGetJobInfo but in a slightly different format.
Another difference is that virDomainGetJobStats can also
retrieve info on the most recently completed job. Though so
far this is only used in the source node to know if the
migra
Introduce a new helper function "virDiskNameParse" which extends
virDiskNameToIndex but handling both disk index and partition index.
Also rework virDiskNameToIndex to be based on virDiskNameParse.
A test is also added for this function testing both valid and
invalid disk names.
Signed-off-by: Joa
Introduce support for domainGetJobInfo to get info about the
ongoing job. If the job is active it will update the
timeElapsed which is computed with the "started" field added to
struct libxlDomainJobObj. For now we support just the very basic
info and all jobs have VIR_DOMAIN_JOB_UNBOUNDED (i.e. n
Introduce support for domainInterfaceStats API call for querying
network interface statistics. Consequently it also enables the
use of `virsh domifstat ` command.
After succesful guest creation we fill the network
interfaces names based on domain, device id and append suffix
if it's emulated in t
Introduce support for domainMemoryStats API call, which
consequently enables the use of `virsh dommemstat` command to
query for memory statistics of a domain. We support
the following statistics: balloon info, available and currently
in use. swap-in, swap-out, major-faults, minor-faults require
coo
Introduce initial support for domainBlockStats API call that
allow us to query block device statistics. openstack nova
uses this API call to query block statistics, alongside
virDomainMemoryStats and virDomainInterfaceStats. Note that
this patch only introduces it for VBD for starters. QDisk
will
Introduce support for domainGetCPUStats API call and consequently
allow us to use `virsh cpu-stats`. The latter returns a more brief
output than the one provided by`virsh vcpuinfo`.
Signed-off-by: Joao Martins
---
Changes since v1:
- Remove libxl_vcpuinfo_dispose() in favor or using
libxl_vcpui
On Thu, Nov 12, 2015 at 19:37:19 +0100, Jiri Denemark wrote:
> Remembering to call qemuMonitorSetDomainLog in the right paths before
> calling qemuProcessStop is annoying and easy to forget. And I already
> forget to do so in commit v1.2.8-52-g0389060: logfd may be leaked if
forgot
> QEMU process
On Thu, Nov 12, 2015 at 19:37:18 +0100, Jiri Denemark wrote:
> Every caller setting migrateFrom already sets
> VIR_QEMU_PROCESS_START_PAUSED flag anyway.
Indeed.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 3 ---
> 1 file changed, 3 deletions(-)
ACK
signature.asc
Desc
On Thu, Nov 12, 2015 at 19:37:17 +0100, Jiri Denemark wrote:
> qemuProcessMakeDir is used for creating a per-domain directory in a
> given parent directory.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 59
> +
> 1 file change
On Wed, Nov 04, 2015 at 04:58:45PM -0500, John Ferlan wrote:
> Details in the patches - essentially testing found an issue creating
> and destroying an FC/SCSI pool due to the refresh thread created for
> bz 1152382 running after the destroy.
>
> Seen using script which has
> for i in 1 2 3 ;
On Thu, Nov 12, 2015 at 19:37:16 +0100, Jiri Denemark wrote:
> qemuProcessStart is so big that any nontrivial code should be moved to
> dedicated functions to make the code easier to read and maintain.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 56
> +
On Thu, Nov 12, 2015 at 19:37:15 +0100, Jiri Denemark wrote:
> Move {Enter,Exit}Monitor calls inside qemuProcessSetLinkStates to
> simplify qemuProcessStart.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 38 +++---
> 1 file changed, 23 inserti
On Thu, 2015-11-12 at 11:11 +0300, Nikolay Shirokovskiy wrote:
> Hi, everyone.
>
> I plan to add means to configure vz containers memory setting and have trouble
> getting it done thru libvirt interface. Looks like current interface fits good
> for vm memory managment but its not clear how to use
On Thu, 2015-10-22 at 11:13 +0300, Mikhail Feoktistov wrote:
> Built-in drivers in libvirt are initialized before libvirtd initialization.
> Libvirt loads shared drivers on libvirtd initialization step.
> For built-in drivers we can't set shared drivers, because they are not
> initialized yet.
> Th
On Thu, Nov 12, 2015 at 19:37:14 +0100, Jiri Denemark wrote:
> qemuProcessStart is so big that any nontrivial code should be moved to
> dedicated functions to make the code easier to read and maintain.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 105
>
On 13.11.2015 12:12, Jiri Denemark wrote:
On Fri, Nov 13, 2015 at 11:30:30 +0300, Dmitry Andreev wrote:
A new Hyper-V cpu feature 'hv_crash' was added to QEMU. The feature
will become available in v2.5.0.
This patch adds support for this feature.
n & Addressing -> Compose messages in HTML for
On Thu, Nov 12, 2015 at 19:37:13 +0100, Jiri Denemark wrote:
> qemuProcessStart is so big that any nontrivial code should be moved to
> dedicated functions to make the code easier to read and maintain.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 147
>
On Thu, Nov 12, 2015 at 19:37:12 +0100, Jiri Denemark wrote:
> qemuProcessStart is so big that any nontrivial code should be moved to
> dedicated functions to make the code easier to read and maintain.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 80
> +
On Thu, Nov 12, 2015 at 19:37:11 +0100, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_process.c | 22 +++---
> 1 file changed, 11 insertions(+), 11 deletions(-)
ACK
signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@
On Thu, Nov 12, 2015 at 19:37:10 +0100, Jiri Denemark wrote:
> Traditionally, we pass incoming migration URI on QEMU command line,
> which has some drawbacks. Depending on the URI QEMU may initialize its
> migration state immediately without giving us a chance to set any
> additional migration para
On Thu, Nov 12, 2015 at 19:37:09 +0100, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_monitor.c | 12
> src/qemu/qemu_monitor.h | 3 +++
> src/qemu/qemu_monitor_json.c | 25 +
> src/qemu/qemu_monitor_json.h | 5 +
>
On Thu, Nov 12, 2015 at 19:37:08 +0100, Jiri Denemark wrote:
> We only started an async job for incoming migration from another host.
> When we were starting a domain from scratch or restoring from a saved
> state (migration from file) we didn't set any async job. Let's introduce
> a new QEMU_ASYNC
On Thu, Nov 12, 2015 at 19:37:07 +0100, Jiri Denemark wrote:
> Incoming migration may require quite a few parameters (URI, fd, path) to
> be considered while starting QEMU and we will soon add another one.
> Let's group all of them in a single struct.
>
> Signed-off-by: Jiri Denemark
> ---
> src
On Thu, Nov 12, 2015 at 19:37:06 +0100, Jiri Denemark wrote:
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_command.c | 39 ---
> src/qemu/qemu_command.h | 5 -
> src/qemu/qemu_migration.c | 40
> src/qemu
On Thu, Nov 12, 2015 at 19:37:05 +0100, Jiri Denemark wrote:
> Make callers of qemuBuildCommandLine responsible for providing the URI
> which should be passed as a parameter for -incoming.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_command.c | 32
>
On Fri, Nov 13, 2015 at 10:28:02AM +0100, Christian Loehle wrote:
> On 11/11/2015 10:17 AM, Daniel P. Berrange wrote:
> >> +virCommandSetOutputBuffer(cmd, &output);
> >> +size_t count = -1; // Don't count table header line
> >> +size_t i = 0;
> >> +if (virCommandRun(cmd, NULL) < 0)
On Fri, Nov 13, 2015 at 10:28:08 +0100, Jiri Denemark wrote:
> On Fri, Nov 13, 2015 at 10:06:08 +0100, Peter Krempa wrote:
> > On Thu, Nov 12, 2015 at 19:37:04 +0100, Jiri Denemark wrote:
> > > Move the code from qemuBuildCommandLine into dedicated functions.
> > >
> > > Signed-off-by: Jiri Denema
On 11/11/2015 10:17 AM, Daniel P. Berrange wrote:
>> +virCommandSetOutputBuffer(cmd, &output);
>> +size_t count = -1; // Don't count table header line
>> +size_t i = 0;
>> +if (virCommandRun(cmd, NULL) < 0)
>> +goto error;
>> +while (output[i] != '\0') {
>> +if
On Fri, Nov 13, 2015 at 10:06:08 +0100, Peter Krempa wrote:
> On Thu, Nov 12, 2015 at 19:37:04 +0100, Jiri Denemark wrote:
> > Move the code from qemuBuildCommandLine into dedicated functions.
> >
> > Signed-off-by: Jiri Denemark
> > ---
> >
> > Notes:
> > Both functions will later be moved
On Fri, Nov 13, 2015 at 11:30:30 +0300, Dmitry Andreev wrote:
> A new Hyper-V cpu feature 'hv_crash' was added to QEMU. The feature
> will become available in v2.5.0.
>
> This patch adds support for this feature.
>
> The previous version of this patch is
> https://www.redhat.com/archives/libvi
On Thu, Nov 12, 2015 at 19:37:04 +0100, Jiri Denemark wrote:
> Move the code from qemuBuildCommandLine into dedicated functions.
>
> Signed-off-by: Jiri Denemark
> ---
>
> Notes:
> Both functions will later be moved to qemu_migration.c
>
> src/qemu/qemu_command.c | 75
> ++
'model' attribute was added to a panic device but only one panic
device is allowed. This patch changes panic device presence
from 'optional' to 'zeroOrMore'.
---
docs/formatdomain.html.in | 1 +
docs/schemas/domaincommon.rng | 4 +--
src/conf/domain_conf.c| 73 ++-
Panic device type used depends on 'model' attribute.
If no model is specified then device type depends on hypervisor
and guest arch. 'pseries' model is used for pSeries guest and
'isa' model is used in other cases.
XML:
QEMU command line:
qemu -cpu ,hv_crash
---
src/qemu/qemu_command.c | 6
---
tests/qemuargv2xmltest.c | 1 +
.../qemuxml2argv-hyperv-panic.args | 21 +++
.../qemuxml2argvdata/qemuxml2argv-hyperv-panic.xml | 25 +
.../qemuxml2argv-panic-double.args | 21 +++
.../qemuxml2ar
A new Hyper-V cpu feature 'hv_crash' was added to QEMU. The feature
will become available in v2.5.0.
This patch adds support for this feature.
The previous version of this patch is
https://www.redhat.com/archives/libvir-list/2015-November/msg00400.html
What is changed:
* 'model' is an option
Libvirt already has two types of panic devices - pvpanic and pSeries firmware.
This patch introduces the 'model' attribute and a new type of panic device.
'isa' model is for ISA pvpanic device.
'pseries' model is a default value for pSeries guests.
'hyperv' model is the new type. It's used for Hyp
On Thu, Nov 12, 2015 at 19:37:03 +0100, Jiri Denemark wrote:
> Move the code from qemuMigrationFinish into a dedicated function.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_migration.c | 45 +
> 1 file changed, 29 insertions(+), 16 deletions
68 matches
Mail list logo
