Re: [libvirt] [PATCH 0/3] build: drop some nested makefiles

On Sun, Jan 10, 2016 at 06:06:20PM -0500, Cole Robinson wrote: This kills some nested makefiles. They don't hurt much but they are largely redudant so don't serve much usefulness either. After this we have a strict two level Makefile hierarchy, which is an easy rule of thumb to follow. The

Re: [libvirt] [PATCH 1/3] build: Kill include/libvirt/Makefile.am

On Sun, Jan 10, 2016 at 06:06:21PM -0500, Cole Robinson wrote: Move all the logic to include/Makefile.am, simplify it with a wildcard, then kill include/libvirt/Makefile.am --- configure.ac| 2 +- include/Makefile.am | 19 +-- include/libvirt/Makefile.am |

Re: [libvirt] [PATCH 1/2] cgroup: fix including sys/mount.h for OpenBSD

On Sun, Jan 10, 2016 at 11:29:47PM +0300, Roman Bogorodskiy wrote: Martin Kletzander wrote: On Fri, Jan 08, 2016 at 10:36:07PM +0300, Roman Bogorodskiy wrote: >From: Jasper Lievisse Adriaanse > >Include sys/param.h along with sys/mount.h to fix compilation on >OpenBSD. >

Re: [libvirt] [PATCH v2 3/3] Unify int types handling in protocol files

Should this patch by itself be enough to fix the OSX compilation problem? :) eg should I test it with just this? + Justin On 2016-01-11 00:34, Roman Bogorodskiy wrote: From: Jasper Lievisse Adriaanse Some of the protocol files already include handing of the missing int

Re: [libvirt] [PATCH v2 3/3] Unify int types handling in protocol files

Justin Clift wrote: > Should this patch by itself be enough to fix the OSX compilation > problem? :) > > eg should I test it with just this? Yeah, it should. One thing, though: it patches the .x files, not the generated files. On OpenBSD I wasn't able to build things from git because rpcgen

[libvirt] [PATCH v2] libvirtd: Increase NL buffer size for lots of interface

1. When switching CPUs to offline/online in a system more than 128 cpus 2. When using virsh to destroy domain in a system with more interface All of above happens nl_recv returned with error: No buffer space available. This patch sets the socket buffer size to 128K and turns on message peeking

Re: [libvirt] [PATCH v2] libvirtd: Increase NL buffer size for lots of interface

Sorry for the wrong function in libnl3. please use the PATCH v3 On 2016年01月11日 14:46, Leno Hou wrote: 1. When switching CPUs to offline/online in a system more than 128 cpus 2. When using virsh to destroy domain in a system with more interface All of above happens nl_recv returned with error:

[libvirt] [PATCH v3] libvirtd: Increase NL buffer size for lots of interface

1. When switching CPUs to offline/online in a system more than 128 cpus 2. When using virsh to destroy domain in a system with more interface All of above happens nl_recv returned with error: No buffer space available. This patch sets the socket buffer size to 128K and turns on message peeking

Re: [libvirt] [PATCH v1] libvirtd: Increase NL buffer size for lots of interface

[libvirt][PATCH v2] libvirtd: Increase NL buffer size for lots of interface has been sent. Appreciated your comment and review. Thanks On 2016年01月07日 02:25, Laine Stump wrote: Now that everyone is back from holidays, I wanted to revisit this patch (since the message I'm replying to contains

Re: [libvirt] [PATCH 4/4] qemu: command: wire up usage of q35/ich9 disable s3/s4

On Sun, Jan 10, 2016 at 03:27:12PM -0500, Cole Robinson wrote: On 01/10/2016 04:54 AM, Martin Kletzander wrote: On Sat, Jan 09, 2016 at 04:32:23PM -0500, Cole Robinson wrote: If the q35 specific disable s3/s4 setting isn't disabled, fallback to this reads weirdly, maybe you meant "supported"

Re: [libvirt] [PATCH 4/4] qemu: command: wire up usage of q35/ich9 disable s3/s4

On Sat, Jan 09, 2016 at 04:32:23PM -0500, Cole Robinson wrote: If the q35 specific disable s3/s4 setting isn't disabled, fallback to this reads weirdly, maybe you meant "supported" instead of "disabled"? specifying the PIIX setting, which is the previous behavior. It doesn't have any effect,

Re: [libvirt] [PATCH 0/4] qemu: Support disable_s3/s4 for -M q35

On Sat, Jan 09, 2016 at 04:32:19PM -0500, Cole Robinson wrote: q35/ICH9 uses a different qemu option for disabling s3/s4 support. Probe for it and wire it up. Cole Robinson (4): qemu: capabilities: s/Pixx/Piix/g qemu: caps: Rename CAPS_DISABLE_S[34] to CAPS_PIIX_DISABLE_S[34] qemu: caps:

Re: [libvirt] [PATCH] examples: Use one top level makefile

On Sat, Jan 09, 2016 at 09:20:44PM -0500, Cole Robinson wrote: Using one Makefile per example subdirectory essentially serializes 'make' calls. Convert to one example/Makefile that builds and distributes all the subdir files. This reduces example/ rebuild time from about 5.8 seconds to 1.5

Re: [libvirt] [PATCH] Avoid wild securityManager pointer in tests

On Sat, Jan 09, 2016 at 05:32:46PM -0500, Cole Robinson wrote: On 01/09/2016 12:36 PM, Martin Kletzander wrote: For some reason we are not setting the driver with memset() to zeros. But since commit 74abc3deac6e14ffa9151e425c6e6cd2b075aac5 driver->securityManager is being accessed and

Re: [libvirt] [PATCH lxc_ethernet] lxc:support network type with ethernet

On Mon, Nov 30, 2015 at 12:47:44PM +, zhongguoche...@163.com wrote: From: z00209963 Going through some older patches I noticed this one. There are few questions / hints for next time. You could use your whole name so that they are properly attributed

Re: [libvirt] [PATCH 3/4] qemu: caps: check for q35/ICH9 disable S3/S4

On Sat, Jan 09, 2016 at 04:35:45PM -0500, Cole Robinson wrote: On 01/09/2016 04:32 PM, Cole Robinson wrote: Update test data to match --- src/qemu/qemu_capabilities.c | 9 +++ src/qemu/qemu_capabilities.h | 2 +

Re: [libvirt] [PATCH 1/2] cgroup: fix including sys/mount.h for OpenBSD

On Fri, Jan 08, 2016 at 10:36:07PM +0300, Roman Bogorodskiy wrote: From: Jasper Lievisse Adriaanse Include sys/param.h along with sys/mount.h to fix compilation on OpenBSD. Signed-off-by: Roman Bogorodskiy --- src/util/vircgroup.c | 3 ++- 1 file

Re: [libvirt] [PATCH] Unify int types handling in protocol files

On Sun, Jan 10, 2016 at 02:49:52AM +0300, Roman Bogorodskiy wrote: From: Jasper Lievisse Adriaanse Some of the protocol files already include handing of the missing int types such as xdr_uint64_t, some don't. To fix it everywhere, move out of the appropriate defines to

Re: [libvirt] [PATCH 2/2] Use struct sockpeercred when available

On Fri, Jan 08, 2016 at 10:36:08PM +0300, Roman Bogorodskiy wrote: From: Jasper Lievisse Adriaanse OpenBSD uses 'struct sockpeercred' instead of 'struct ucred'. Add a configure check that detects its presence and use if in the code that could be compiled on OpenBSD.

Re: [libvirt] [PATCH v3 1/6] rpc: Introduce new element 'name' to virnetserver structure

On Mon, Nov 30, 2015 at 04:03:00PM +0100, Erik Skultety wrote: By adding this element, we'll be able to reference servers on client side. This is merely because when listing clients or managing clients, it would be convenient to know which server they're connected to. Also reflect this change in

Re: [libvirt] [PATCH v3 1/6] rpc: Introduce new element 'name' to virnetserver structure

On Mon, Nov 30, 2015 at 04:03:00PM +0100, Erik Skultety wrote: By adding this element, we'll be able to reference servers on client side. This is merely because when listing clients or managing clients, it would be convenient to know which server they're connected to. Also reflect this change in

Re: [libvirt] [PATCH v3 2/6] virnetdaemon: Add post exec restart support for multiple servers

On Mon, Nov 30, 2015 at 04:03:01PM +0100, Erik Skultety wrote: Since the daemon can manage and add (at fresh start) multiple servers, we also should be able to add them from a JSON state file in case of a daemon restart. This patch introduces virNetDaemonAddServersPostExec method which harvests

Re: [libvirt] [PATCH 4/4] qemu: command: wire up usage of q35/ich9 disable s3/s4

On 01/10/2016 04:54 AM, Martin Kletzander wrote: > On Sat, Jan 09, 2016 at 04:32:23PM -0500, Cole Robinson wrote: >> If the q35 specific disable s3/s4 setting isn't disabled, fallback to > > this reads weirdly, maybe you meant "supported" instead of "disabled"? > Yeah, I meant supported. Fixed

Re: [libvirt] [PATCH] Unify int types handling in protocol files

On Sun, Jan 10, 2016 at 10:53:19PM +0300, Roman Bogorodskiy wrote: Martin Kletzander wrote: On Sun, Jan 10, 2016 at 02:49:52AM +0300, Roman Bogorodskiy wrote: >From: Jasper Lievisse Adriaanse > >Some of the protocol files already include handing of the missing int >types

Re: [libvirt] [PATCH v3 3/6] admin: Move admin_server.{h, c} to admin.{h, c}

On Mon, Nov 30, 2015 at 04:03:02PM +0100, Erik Skultety wrote: This change is merely because admin_server would contain all the code from dispatchers and helpers to the actual APIs. Admin should have similar structure to the daemon-side remote driver - dispatchers and helpers in a separate

Re: [libvirt] [PATCH 2/2] Use struct sockpeercred when available

Martin Kletzander wrote: > On Fri, Jan 08, 2016 at 10:36:08PM +0300, Roman Bogorodskiy wrote: > >From: Jasper Lievisse Adriaanse > > > >OpenBSD uses 'struct sockpeercred' instead of 'struct ucred'. Add a > >configure check that detects its presence and use if in the code

Re: [libvirt] [PATCH 1/2] cgroup: fix including sys/mount.h for OpenBSD

Martin Kletzander wrote: > On Fri, Jan 08, 2016 at 10:36:07PM +0300, Roman Bogorodskiy wrote: > >From: Jasper Lievisse Adriaanse > > > >Include sys/param.h along with sys/mount.h to fix compilation on > >OpenBSD. > > > >Signed-off-by: Roman Bogorodskiy

Re: [libvirt] [PATCH] Unify int types handling in protocol files

Martin Kletzander wrote: > On Sun, Jan 10, 2016 at 02:49:52AM +0300, Roman Bogorodskiy wrote: > >From: Jasper Lievisse Adriaanse > > > >Some of the protocol files already include handing of the missing int > >types such as xdr_uint64_t, some don't. To fix it everywhere,

Re: [libvirt] [PATCH v3 4/6] admin: Introduce virAdmServer structure

On Mon, Nov 30, 2015 at 04:03:03PM +0100, Erik Skultety wrote: This is the key structure of all management operations performed on the daemon/clients. An admin client needs to be able to identify another client (either admin or non-privileged client) to perform an action on it. This

Re: [libvirt] [PATCH] examples: Use one top level makefile

On 01/10/2016 05:37 AM, Martin Kletzander wrote: > On Sat, Jan 09, 2016 at 09:20:44PM -0500, Cole Robinson wrote: >> Using one Makefile per example subdirectory essentially serializes 'make' >> calls. Convert to one example/Makefile that builds and distributes >> all the subdir files. This reduces

[libvirt] [PATCH 2/3] build: Kill docs/schemas/Makefile.am

Move the logic to docs/Makefile.am, and simplify it with a wildcard expression. --- configure.ac | 1 - docs/Makefile.am | 10 ++ docs/schemas/Makefile.am | 35 --- 3 files changed, 6 insertions(+), 40 deletions(-) delete mode 100644

[libvirt] [PATCH 1/3] build: Kill include/libvirt/Makefile.am

Move all the logic to include/Makefile.am, simplify it with a wildcard, then kill include/libvirt/Makefile.am --- configure.ac| 2 +- include/Makefile.am | 19 +-- include/libvirt/Makefile.am | 44 3 files

[libvirt] [PATCH 3/3] build: Kill tools/wireshark Makefiles

Just handle it all in tools/Makefile.am. I verified the generated output looks similar to the pre patch output, but I didn't test it. --- Makefile.am | 2 +- configure.ac| 4 +--- tools/Makefile.am | 52

[libvirt] [PATCH 0/3] build: drop some nested makefiles

This kills some nested makefiles. They don't hurt much but they are largely redudant so don't serve much usefulness either. After this we have a strict two level Makefile hierarchy, which is an easy rule of thumb to follow. The first two patches clean up blantantly redundant makesfiles Patch 3 is

[libvirt] [PATCH v2 2/3] Use struct sockpeercred when available

From: Jasper Lievisse Adriaanse OpenBSD uses 'struct sockpeercred' instead of 'struct ucred'. Add a configure check that detects its presence and use if in the code that could be compiled on OpenBSD. Signed-off-by: Roman Bogorodskiy --- configure.ac

[libvirt] [PATCH v2 1/3] cgroup: don't include sys/mount.h if not needed

From: Jasper Lievisse Adriaanse As cgroup implementation only works on Linux, it does not make much sense to include sys/mount.h if other requirements are not met, such as HAVE_MNTENT_H and HAVE_GETMNTENT_R. Also, it fixes build on OpenBSD that requires to include

[libvirt] [PATCH v2 3/3] Unify int types handling in protocol files

From: Jasper Lievisse Adriaanse Some of the protocol files already include handing of the missing int types such as xdr_uint64_t, some don't. To fix it everywhere, move out of the appropriate defines to the utils/virxdrdefs.h file and include it where needed. Signed-off-by: