Re: [libvirt] [PATCH v2 5/6] tests: qemuxml2xml: assign device addresses

On 02/09/2016 10:59 AM, Cole Robinson wrote: We use the PreFormat callback for this. Many test cases need to be extended to pass in proper qemuCaps flags so AssignAddresses doesn't throw errors. One test case (pcie-root-port-too-many) is dropped, since it was meant only for checking an error

Re: [libvirt] [PATCH v2 4/6] tests: utils: Add PreFormat callback for CompareXML2XML helper

On 02/09/2016 10:59 AM, Cole Robinson wrote: This allows individual driver tests to hook in their own code before the def is formatted and compared. We will eventually use this in the qemuxml2xml --- Oops. I ACKed 5/6 before this one (after looking ahead to see how this would be used).

Re: [libvirt] [PATCH v2 3/6] tests: qemuxml2xml: Allow test cases to pass in qemuCaps

On 02/09/2016 02:57 PM, Laine Stump wrote: > On 02/09/2016 10:58 AM, Cole Robinson wrote: >> Similar to how we do it for qemuxml2argvtest. This will be used in future >> patches. >> --- >> tests/qemuxml2xmltest.c | 27 --- >> 1 file changed, 16 insertions(+), 11

Re: [libvirt] [PATCH v2 1/6] tests: qemuxml2argv: remove some QEMU_CAPS_DEVICE problem cases

On 02/09/2016 01:31 PM, Laine Stump wrote: > On 02/09/2016 10:58 AM, Cole Robinson wrote: >> When we unconditionally enable QEMU_CAPS_DEVICE, these tests need >> some massaging, so do it ahead of time to not mix it in with the >> big test refresh. >> >> - minimal-s390 is not a real world working

Re: [libvirt] [PATCH v2 2/6] tests: Unconditionally enable QEMU_CAPS_DEVICE

On 02/09/2016 10:58 AM, Cole Robinson wrote: QEMU_CAPS_DEVICE is always enabled for qemu binaries we support. Sync qemuxml2* to match, and regenerate all test output. The change in the .c makes sense, a scan through a color-coded diff of the .args changes didn't show anything that *didn't*

Re: [libvirt] [PATCH v2 4/6] tests: utils: Add PreFormat callback for CompareXML2XML helper

On 02/09/2016 03:13 PM, Laine Stump wrote: > On 02/09/2016 10:59 AM, Cole Robinson wrote: >> This allows individual driver tests to hook in their own code before >> the def is formatted and compared. >> >> We will eventually use this in the qemuxml2xml >> --- > > Oops. I ACKed 5/6 before this one

[libvirt] [PATCH] virDomainFormatSchedDef: Initialize @priority

Older gcc fails to see that the variable is set iff @hasPriority == true in which case the former is set a value. Initialize the value while declaring it to make the compiler shut up. Signed-off-by: Michal Privoznik --- This maybe isn't the best approach, to workaround

Re: [libvirt] [PATCHv2] leaseshelper: split out virLeaseNew

On 02/05/2016 11:49 AM, Ján Tomko wrote: > For the actions ADD and OLD, split out creating the new lease object, > as well as getting the environment variables that do not affect > the parsing of command line arguments. > --- > v2: do not pass argc, argv to the function > >

[libvirt] Dropping RHEL-6/CentOS-6 support

Dear list, I've noticed a failed build on CentOS-6 after some commits. Problem was that old gcc is not wise enough and produces a false positive. I've proposed a patch for that [1] but honestly, neither am I - like Peter - very fond of this approach. We should not try to fix a good code because

Re: [libvirt] [PATCH] virDomainFormatSchedDef: Initialize @priority

On 09.02.2016 09:50, Peter Krempa wrote: > On Tue, Feb 09, 2016 at 09:29:48 +0100, Michal Privoznik wrote: >> On 09.02.2016 09:26, Peter Krempa wrote: >>> On Tue, Feb 09, 2016 at 09:08:49 +0100, Michal Privoznik wrote: --- This maybe isn't the best approach, to workaround false

[libvirt] [PATCH] qemu migration: assign addresses in xml passed as parameter

Usecase: 1. define domain with xml A where addresses are not set 2. migrate with '--xml A' You get ABI incompatibility because we comprare xmls with addresses set and not. This patch assign addresses in parameter xml so the comprasion is fair. Signed-off-by: Nikolay Shirokovskiy

Re: [libvirt] [PATCH] virDomainFormatSchedDef: Initialize @priority

On Tue, Feb 09, 2016 at 09:29:48 +0100, Michal Privoznik wrote: > On 09.02.2016 09:26, Peter Krempa wrote: > > On Tue, Feb 09, 2016 at 09:08:49 +0100, Michal Privoznik wrote: > >> --- > >> > >> This maybe isn't the best approach, to workaround false > >> positives. I'm open to discussion. > > > >

Re: [libvirt] [libvirt-glib 1/3] Add GVirConfigDomainHostdev

On Mon, Feb 08, 2016 at 04:22:47PM +, Zeeshan Ali (Khattak) wrote: > Hi, > > On Fri, Jan 29, 2016 at 5:18 PM, Christophe Fergeau > wrote: > > Hey, > > > > A gconfig: prefix in the commit shortlog would be nice > > Hmm.. maybe for consistency, yes but I'll remove

Re: [libvirt] [PATCH] virDomainFormatSchedDef: Initialize @priority

On 09.02.2016 09:26, Peter Krempa wrote: > On Tue, Feb 09, 2016 at 09:08:49 +0100, Michal Privoznik wrote: >> Older gcc fails to see that the variable is set iff @hasPriority >> == true in which case the former is set a value. Initialize the >> value while declaring it to make the compiler shut

Re: [libvirt] [libvirt-glib 2/3] Add GVirConfigDomainHostdevPci

On Mon, Feb 08, 2016 at 04:58:34PM +, Zeeshan Ali (Khattak) wrote: > Hi, > > >> + */ > >> +GVirConfigDomainHostdevPci *gvir_config_domain_hostdev_pci_new(void) > >> +{ > >> +GVirConfigObject *object; > >> + > >> +object = gvir_config_object_new(GVIR_CONFIG_TYPE_DOMAIN_HOSTDEV_PCI, >

Re: [libvirt] [PATCH] virDomainFormatSchedDef: Initialize @priority

On Tue, Feb 09, 2016 at 09:08:49 +0100, Michal Privoznik wrote: > Older gcc fails to see that the variable is set iff @hasPriority > == true in which case the former is set a value. Initialize the > value while declaring it to make the compiler shut up. > Initializing it may confuse a next

Re: [libvirt] Dropping RHEL-6/CentOS-6 support

On Tue, Feb 09, 2016 at 12:59:45 +, Daniel Berrange wrote: > On Tue, Feb 09, 2016 at 01:56:19PM +0100, Michal Privoznik wrote: > > On 09.02.2016 13:52, Daniel P. Berrange wrote: > > > On Tue, Feb 09, 2016 at 12:07:43PM +0100, Michal Privoznik wrote: ... > > > IMHO it is well premature to

Re: [libvirt] Dropping RHEL-6/CentOS-6 support

On Tue, Feb 09, 2016 at 04:19:48PM +0100, Andrea Bolognani wrote: > On Tue, 2016-02-09 at 14:18 +, Daniel P. Berrange wrote: > > > The above is to point out that users of Centos 6 usually won't compile > > > libvirt and qemu from sources since they want to enjoy benefits of a > > > stable

Re: [libvirt] [PATCH 5/7] qemu: Always enable GIC on ARM virt machines

Before I forget ;-) or put it off in lieu of other exciting things... On 02/08/2016 12:20 PM, Andrea Bolognani wrote: > On Mon, 2016-02-08 at 10:24 -0500, John Ferlan wrote: >>> For existing guests, means , but we pick the >>> default every single time the XML is loaded instead of explicitly

Re: [libvirt] Dropping RHEL-6/CentOS-6 support

On Tue, Feb 09, 2016 at 03:15:31PM +0100, Peter Krempa wrote: > On Tue, Feb 09, 2016 at 12:59:45 +, Daniel Berrange wrote: > > On Tue, Feb 09, 2016 at 01:56:19PM +0100, Michal Privoznik wrote: > > > On 09.02.2016 13:52, Daniel P. Berrange wrote: > > > > On Tue, Feb 09, 2016 at 12:07:43PM

Re: [libvirt] Dropping RHEL-6/CentOS-6 support

On Tue, 2016-02-09 at 14:18 +, Daniel P. Berrange wrote: > > The above is to point out that users of Centos 6 usually won't compile > > libvirt and qemu from sources since they want to enjoy benefits of a > > stable platform with tested software. Sticking upstream versions on top > > of that

Re: [libvirt] Found mem leak in libvirtd, need help to debug

On 09.02.2016 13:36, Piotr Rybicki wrote: > Hi guys. > > W dniu 2015-11-20 o 11:29, Piotr Rybicki pisze: >> >>> I've seen some of theese already. The bug is actually not in libvirt but >>> in gluster's libgfapi library, so any change in libvirt won't help. >>> >>> This was tracked in gluster as:

Re: [libvirt] question about rdma migration

Hi Roy, On 02/09/2016 03:57 AM, Roy Shterman wrote: Hi, I tried to understand the rdma-migration in qemu code and i have two questions about it: 1. I'm working with qemu-kvm using libvirt and i'm getting MEMLOCKmax locked-in-memory address space 65536 65536 bytes in qemu process

[libvirt] [PATCH] util: Get rid of virStringListLen()

It does exactly the same thing as virStringListLenght() and it's used in one place only. Signed-off-by: Martin Kletzander --- src/util/virpolkit.c | 2 +- src/util/virstring.c | 14 -- src/util/virstring.h | 2 -- 3 files changed, 1 insertion(+), 17

Re: [libvirt] Dropping RHEL-6/CentOS-6 support

On Tue, Feb 09, 2016 at 01:56:19PM +0100, Michal Privoznik wrote: > On 09.02.2016 13:52, Daniel P. Berrange wrote: > > On Tue, Feb 09, 2016 at 12:07:43PM +0100, Michal Privoznik wrote: > >> Dear list, > >> > >> I've noticed a failed build on CentOS-6 after some commits. Problem was > >> that old

[libvirt] [PATCH] leaseshelper: swap two parameters of virLeaseNew

My commit e11aa74 messed up the parameter order. Reported by John Ferlan. --- src/network/leaseshelper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Pushed as trivial. diff --git a/src/network/leaseshelper.c b/src/network/leaseshelper.c index 2a0b18c..55ddd58 100644 ---

Re: [libvirt] Found mem leak in libvirtd, need help to debug

Hi guys. W dniu 2015-11-20 o 11:29, Piotr Rybicki pisze: I've seen some of theese already. The bug is actually not in libvirt but in gluster's libgfapi library, so any change in libvirt won't help. This was tracked in gluster as: https://bugzilla.redhat.com/show_bug.cgi?id=1093594 I

Re: [libvirt] Dropping RHEL-6/CentOS-6 support

On Tue, Feb 09, 2016 at 12:07:43PM +0100, Michal Privoznik wrote: > Dear list, > > I've noticed a failed build on CentOS-6 after some commits. Problem was > that old gcc is not wise enough and produces a false positive. I've > proposed a patch for that [1] but honestly, neither am I - like Peter

Re: [libvirt] [PATCH] qemu: fix hot unplug of PCI devices with VFIO

Hi all, I'm new to this community and this is the first patch/fix that I'm trying to get merged. I would appreciate if people could review it and give me some feedback. Do I need to raise a bug as well ? Regards, /ludovic On 02/05/2016 02:11 PM, Ludovic Beliveau wrote: > Currently, on hot

[libvirt] [PATCH 3/5] vbox: remove extra spaces from assignments

--- src/vbox/vbox_common.c | 10 +++ src/vbox/vbox_tmpl.c | 72 +- 2 files changed, 41 insertions(+), 41 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index ccc7dc3..56d80a3 100644 --- a/src/vbox/vbox_common.c +++

Re: [libvirt] [PATCH] Fix '-pie' build with clang

On Tue, 2016-02-09 at 13:13 +0100, Martin Kletzander wrote: > Commit 97e70a593589e8f0432a748b4b93c3cdc18b9e5a added the option -pie to > CFLAGS and LDFLAGS, however '-pie' is just a linker option.  That > wouldn't be a problem.  However, clang is checking for that and outputs > an error or unused

Re: [libvirt] Dropping RHEL-6/CentOS-6 support

On Tue, 2016-02-09 at 12:07 +0100, Michal Privoznik wrote: > Dear list, >  > I've noticed a failed build on CentOS-6 after some commits. Problem was > that old gcc is not wise enough and produces a false positive. I've > proposed a patch for that [1] but honestly, neither am I - like Peter - >

[libvirt] [PATCH 1/2] qemu: Refactor qemuParseCommandLine error path for vnc parse

Rather than have vnc be a variable within the if, promote it to the top, then adjust the code to use the error label to call virDomainGraphicsDefFree Signed-off-by: John Ferlan --- src/qemu/qemu_command.c | 24 ++-- 1 file changed, 6 insertions(+), 18

[libvirt] [PATCH 0/2] Check return status for virDomainGraphicsListenSetAddress

The second patch is a result of a Coverity found issue - the first one is collateral damage found because my first pass just checked the status and went to error resulting in a resource leak Rather than add two more lines for calling the graphic def free function, it was just easier to

[libvirt] [PATCH 2/2] qemu: Check return status for virDomainGraphicsListenSetAddress

Recent refactors in the vbox code to check the return status for the function tipped Coverity's scales of justice for any functions that do not check status - such as this one. Add a check of the status, adjust the long line too. Signed-off-by: John Ferlan ---

Re: [libvirt] Dropping RHEL-6/CentOS-6 support

On 09.02.2016 13:52, Daniel P. Berrange wrote: > On Tue, Feb 09, 2016 at 12:07:43PM +0100, Michal Privoznik wrote: >> Dear list, >> >> I've noticed a failed build on CentOS-6 after some commits. Problem was >> that old gcc is not wise enough and produces a false positive. I've >> proposed a patch

[libvirt] [PATCH 3/6] storage:dir: adapts .uploadVol .dowloadVol for ploop volume

In case of ploop volume, target path of the volume is the path to the directory that contains image file named root.hds and DiskDescriptor.xml. While using uploadVol and downloadVol callbacks we need to open root.hds itself. To accomplish this goal we must change path from path/to/ploop directory

[libvirt] [PATCH 2/6] storage:dir: .deleteVol callback for ploop volume

Deletes whole directory of a ploop volume. To delete ploop image it has to be unmounted. Signed-off-by: Olga Krishtal --- src/storage/storage_backend.c| 6 ++ src/storage/storage_backend.h| 2 ++ src/storage/storage_backend_fs.c | 5 + 3 files changed,

[libvirt] [PATCH 4/6] storage:dir: .resizeVol callback for ploop volume

To change the size of ploop image file we use ploop resize cmd that takes 2 args: new size and path/to/DiskDescriptor.xml Signed-off-by: Olga Krishtal --- src/storage/storage_backend.c| 28 src/storage/storage_backend.h| 5 +

[libvirt] [PATCH 5/6] storage:dir: .wipeVol is left unsupported for ploop volume

Returns error in case of vol-wipe cmd for a ploop volume Signed-off-by: Olga Krishtal --- src/storage/storage_backend.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index fb4d1b9..21dd96d 100644

[libvirt] [PATCH 6/6] storage:dir: adapts .refreshVol .refreshPool for ploop volumes

To update information about ploop volumes inside the a single pool we need to be sure that it is the ploop directory and not some other directory. Ploop volume directory obligatory contains root.hds - image file and disk descriptor - DiskDescriptor.xml. If path to a volume is a path to some

[libvirt] [PATCH 2/5] vbox: remove extra spaces from variable initializations

--- src/vbox/vbox_common.c | 282 src/vbox/vbox_storage.c | 2 +- src/vbox/vbox_tmpl.c| 96 - 3 files changed, 190 insertions(+), 190 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index

[libvirt] [PATCH 0/5] vbox: remove extra spaces

Ján Tomko (5): vbox: remove extra spaces from macro definitions vbox: remove extra spaces from variable initializations vbox: remove extra spaces from assignments vbox: remove extra spaces from function headers vbox: remove more extra spaces src/vbox/vbox_V2_2.c | 4 +-

[libvirt] [PATCH] Fix '-pie' build with clang

Commit 97e70a593589e8f0432a748b4b93c3cdc18b9e5a added the option -pie to CFLAGS and LDFLAGS, however '-pie' is just a linker option. That wouldn't be a problem. However, clang is checking for that and outputs an error or unused argument: error: argument unused during compilation: '-pie'

[libvirt] [PATCH 4/5] vbox: remove extra spaces from function headers

Also fix the curly brace to pass sytnax-check. --- src/vbox/vbox_common.c | 21 +++-- src/vbox/vbox_tmpl.c | 13 +++-- 2 files changed, 18 insertions(+), 16 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 56d80a3..718a2f8 100644 ---

[libvirt] [PATCH 1/6] storage:dir: .buildVol and .buildVolFrom callbacks for ploop

These callbacks let us to create ploop volumes in directory pools. If a ploop volume was created via buildVol callback, then this volume is an empty ploop device with DiskDescriptor.xml. If the volume was created via .buildFrom - then its content is the same as input volume. Ploop volume consists

[libvirt] [PATCH v3 0/6] storage:dir: ploop volumes support

v3: - no VIR_STORAGE_VOL_PLOOP type any more - adapted all patches according to previous change - fixed comments v2: - fixed memory leak - chenged the return value of all helper functions to 0/-1. Now check for success is smth like that: virPloop() < 0 - fixed some identation issues. --

[libvirt] [PATCH 5/5] vbox: remove more extra spaces

--- src/vbox/vbox_common.c| 4 ++-- src/vbox/vbox_common.h| 4 ++-- src/vbox/vbox_snapshot_conf.c | 4 ++-- src/vbox/vbox_tmpl.c | 6 +++--- src/vbox/vbox_uniformed_api.h | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/vbox/vbox_common.c

[libvirt] [PATCH 1/5] vbox: remove extra spaces from macro definitions

--- src/vbox/vbox_V2_2.c | 4 ++-- src/vbox/vbox_V3_0.c | 4 ++-- src/vbox/vbox_V3_1.c | 4 ++-- src/vbox/vbox_V3_2.c | 4 ++-- src/vbox/vbox_V4_0.c | 4 ++-- src/vbox/vbox_V4_1.c | 4 ++-- src/vbox/vbox_V4_2.c | 4 ++-- src/vbox/vbox_V4_2_20.c| 4

Re: [libvirt] [PATCHv2] leaseshelper: split out virLeaseNew

On Tue, Feb 09, 2016 at 06:11:07AM -0500, John Ferlan wrote: > > > On 02/05/2016 11:49 AM, Ján Tomko wrote: > > +static int > > +virLeaseNew(virJSONValuePtr *lease_ret, > > +const char *mac, > > +const char *clientid, > > +const char *ip, > > +

Re: [libvirt] Dropping RHEL-6/CentOS-6 support

On Tue, Feb 09, 2016 at 13:24:16 +0100, Andrea Bolognani wrote: > On Tue, 2016-02-09 at 12:07 +0100, Michal Privoznik wrote: > > Dear list, > >  > > I've noticed a failed build on CentOS-6 after some commits. Problem was > > that old gcc is not wise enough and produces a false positive. I've > >

Re: [libvirt] [PATCH] virDomainFormatSchedDef: Initialize @priority

On Tue, Feb 09, 2016 at 09:08:49AM +0100, Michal Privoznik wrote: > Older gcc fails to see that the variable is set iff @hasPriority > == true in which case the former is set a value. Initialize the > value while declaring it to make the compiler shut up. > > Signed-off-by: Michal Privoznik

[libvirt] [PATCH v2 3/6] tests: qemuxml2xml: Allow test cases to pass in qemuCaps

Similar to how we do it for qemuxml2argvtest. This will be used in future patches. --- tests/qemuxml2xmltest.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index ec4aabb..d4e94f0 100644 ---

[libvirt] [PATCH v2 1/6] tests: qemuxml2argv: remove some QEMU_CAPS_DEVICE problem cases

When we unconditionally enable QEMU_CAPS_DEVICE, these tests need some massaging, so do it ahead of time to not mix it in with the big test refresh. - minimal-s390 is not a real world working config, so drop it - disk-usb was testing for an old code path that will be removed. instead use it to

[libvirt] [PATCH v2 6/6] tests: qemu: More aarch64 virtio and pci tests

Clarify the point of some of the test cases by renaming them. Add more xml2xml tests. --- ...> qemuxml2argv-aarch64-virtio-pci-default.args} | 0 ...=> qemuxml2argv-aarch64-virtio-pci-default.xml} | 0 ...2argv-aarch64-virtio-pci-manual-addresses.args} | 0

Re: [libvirt] Found mem leak in libvirtd, need help to debug

On 09.02.2016 16:34, Piotr Rybicki wrote: > > > W dniu 2016-02-09 o 16:12, Michal Privoznik pisze: >> On 09.02.2016 13:36, Piotr Rybicki wrote: >>> Hi guys. >>> >>> W dniu 2015-11-20 o 11:29, Piotr Rybicki pisze: > I've seen some of theese already. The bug is actually not in >

Re: [libvirt] Found mem leak in libvirtd, need help to debug

W dniu 2016-02-09 o 16:12, Michal Privoznik pisze: On 09.02.2016 13:36, Piotr Rybicki wrote: Hi guys. W dniu 2015-11-20 o 11:29, Piotr Rybicki pisze: I've seen some of theese already. The bug is actually not in libvirt but in gluster's libgfapi library, so any change in libvirt won't

Re: [libvirt] [PATCH 1/2] qemu: Refactor qemuParseCommandLine error path for vnc parse

On Tue, Feb 09, 2016 at 07:34:01AM -0500, John Ferlan wrote: > Rather than have vnc be a variable within the if, promote it > to the top, then adjust the code to use the error label to call > virDomainGraphicsDefFree > > Signed-off-by: John Ferlan > --- >

Re: [libvirt] [PATCH 1/2] qemu: Refactor qemuParseCommandLine error path for vnc parse

On 02/09/2016 10:35 AM, Ján Tomko wrote: > On Tue, Feb 09, 2016 at 07:34:01AM -0500, John Ferlan wrote: >> Rather than have vnc be a variable within the if, promote it >> to the top, then adjust the code to use the error label to call >> virDomainGraphicsDefFree >> >> Signed-off-by: John Ferlan

Re: [libvirt] Dropping RHEL-6/CentOS-6 support

On Tue, 2016-02-09 at 15:24 +, Daniel P. Berrange wrote: > > I tend to agree with Peter when he says that people stick with older > > versions of software because they have a working setup and don't want > > to risk it breaking, and replacing vendor-provided system components > > with manually

Re: [libvirt] [PATCH 7/9] tests: utils: Add PreFormat callback for CompareXML2XML helper

On Thu, Jan 28, 2016 at 03:30:12PM -0500, Cole Robinson wrote: This allows individual driver tests to hook in their own code before the def is formatted and compared. We will eventually use this in the qemuxml2xml --- tests/bhyvexml2xmltest.c | 3 ++- tests/genericxml2xmltest.c | 3 ++-

[libvirt] [PATCH v2 0/6] tests: qemu: unconditionally enable QEMU_CAPS_DEVICE

First series is here: https://www.redhat.com/archives/libvir-list/2016-January/msg01233.html This series does two main things: it conditionally enables QEMU_CAPS_DEVICE in the test suite (since that's all we support nowadays), and it unconditionally calls qemuDomainAssignAddresses for

[libvirt] [PATCH v2 4/6] tests: utils: Add PreFormat callback for CompareXML2XML helper

This allows individual driver tests to hook in their own code before the def is formatted and compared. We will eventually use this in the qemuxml2xml --- tests/bhyvexml2xmltest.c | 3 ++- tests/genericxml2xmltest.c | 3 ++- tests/lxcxml2xmltest.c | 3 ++- tests/qemuxml2xmltest.c| 6

Re: [libvirt] [PATCH 2/9] tests: qemuxml2xml: Always use different output file

On 02/08/2016 10:27 AM, Martin Kletzander wrote: > > I didn't mean to stall this series. I'm fine with this going in, > especially if we clean it up afterwards. > No worries, the bits you raised are valid concerns. > So if you also copy the missing files, of course (current list of test >

Re: [libvirt] [PATCH 2/2] qemu: Check return status for virDomainGraphicsListenSetAddress

On Tue, Feb 09, 2016 at 07:34:02AM -0500, John Ferlan wrote: > Recent refactors in the vbox code to check the return status for the > function tipped Coverity's scales of justice for any functions that > do not check status - such as this one. > > Add a check of the status, adjust the long line

Re: [libvirt] [PATCH] util: Get rid of virStringListLen()

On 02/09/2016 10:28 AM, Martin Kletzander wrote: > It does exactly the same thing as virStringListLenght() and it's used in > one place only. > Typo there: s/Lenght/Length/g ACK otherwise - Cole -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] virDomainFormatSchedDef: Initialize @priority

On Tue, Feb 09, 2016 at 09:26:33AM +0100, Peter Krempa wrote: > On Tue, Feb 09, 2016 at 09:08:49 +0100, Michal Privoznik wrote: > > Older gcc fails to see that the variable is set iff @hasPriority > > == true in which case the former is set a value. Initialize the > > value while declaring it to

Re: [libvirt] [PATCH 7/9] tests: utils: Add PreFormat callback for CompareXML2XML helper

On 02/09/2016 10:55 AM, Martin Kletzander wrote: > On Thu, Jan 28, 2016 at 03:30:12PM -0500, Cole Robinson wrote: >> This allows individual driver tests to hook in their own code before >> the def is formatted and compared. >> >> We will eventually use this in the qemuxml2xml >> --- >>

Re: [libvirt] Dropping RHEL-6/CentOS-6 support

On Tue, Feb 09, 2016 at 12:07:43PM +0100, Michal Privoznik wrote: > Dear list, > > I've noticed a failed build on CentOS-6 after some commits. Problem was > that old gcc is not wise enough and produces a false positive. Actually, gcc is doing exactly what we told it todo. We include

Re: [libvirt] [PATCH 1/7] gic: Introduce virGICVersion enumeration

On 02/08/2016 10:15 AM, Andrea Bolognani wrote: > On Sat, 2016-02-06 at 18:27 -0500, Cole Robinson wrote: >> On 02/03/2016 03:25 PM, Andrea Bolognani wrote: >>> We currently blindly accept any numeric value as a GIC version, even >>> thought only GIC v2 and GIC v3 actually exist; on the other

[libvirt] [PATCH] virStringListLength: Ensure const correctness

The virStringListLength function does not ever modify the passed string list. It merely counts the items in it. Make sure that we reflect this bit in the function header. Signed-off-by: Michal Privoznik --- This is hugely driven by a compilation error observed after the

Re: [libvirt] [PATCH v2 5/6] tests: qemuxml2xml: assign device addresses

On 02/09/2016 10:59 AM, Cole Robinson wrote: We use the PreFormat callback for this. Many test cases need to be extended to pass in proper qemuCaps flags so AssignAddresses doesn't throw errors. One test case (pcie-root-port-too-many) is dropped, since it was meant only for checking an error

Re: [libvirt] [PATCH v2 6/6] tests: qemu: More aarch64 virtio and pci tests

On 02/09/2016 10:59 AM, Cole Robinson wrote: Clarify the point of some of the test cases by renaming them. Add more xml2xml tests. --- ...> qemuxml2argv-aarch64-virtio-pci-default.args} | 0 ...=> qemuxml2argv-aarch64-virtio-pci-default.xml} | 0

Re: [libvirt] [PATCH] virStringListLength: Ensure const correctness

On 02/09/2016 01:19 PM, Andrea Bolognani wrote: > On Tue, 2016-02-09 at 18:18 +0100, Michal Privoznik wrote: >> The virStringListLength function does not ever modify the passed >> string list. It merely counts the items in it. Make sure that we >> reflect this bit in the function header. >> >>

Re: [libvirt] [PATCH v2 5/6] tests: qemuxml2xml: assign device addresses

On 02/09/2016 04:17 PM, Laine Stump wrote: > On 02/09/2016 10:59 AM, Cole Robinson wrote: >> We use the PreFormat callback for this. Many test cases need to be extended >> to pass in proper qemuCaps flags so AssignAddresses doesn't throw errors. >> >> One test case (pcie-root-port-too-many) is

Re: [libvirt] [PATCH v2 6/6] tests: qemu: More aarch64 virtio and pci tests

On 02/09/2016 03:50 PM, Laine Stump wrote: > On 02/09/2016 10:59 AM, Cole Robinson wrote: >> Clarify the point of some of the test cases by renaming them. Add more >> xml2xml tests. >> --- >> ...> qemuxml2argv-aarch64-virtio-pci-default.args} | 0 >> ...=>

Re: [libvirt] [PATCH v2 5/6] tests: qemuxml2xml: assign device addresses

On 02/09/2016 03:11 PM, Laine Stump wrote: > On 02/09/2016 10:59 AM, Cole Robinson wrote: >> We use the PreFormat callback for this. Many test cases need to be extended >> to pass in proper qemuCaps flags so AssignAddresses doesn't throw errors. >> >> One test case (pcie-root-port-too-many) is

Re: [libvirt] [PATCH v2 1/6] tests: qemuxml2argv: remove some QEMU_CAPS_DEVICE problem cases

On 02/09/2016 01:46 PM, Cole Robinson wrote: On 02/09/2016 01:31 PM, Laine Stump wrote: On 02/09/2016 10:58 AM, Cole Robinson wrote: When we unconditionally enable QEMU_CAPS_DEVICE, these tests need some massaging, so do it ahead of time to not mix it in with the big test refresh. -

Re: [libvirt] [PATCH] remote: set VIR_TYPED_PARAM_STRING_OKAY on migration

On 02/08/2016 02:18 PM, Erik Skultety wrote: > On 05/02/16 20:24, Joao Martins wrote: >> Commit 8cd1d54 ("util: Export remoteSerializeTypedParameters >> internally via util") consolidates both daemon and remote >> driver typed param serialization functions. Though as is >> no flags are passed

Re: [libvirt] [PATCH v2 1/6] tests: qemuxml2argv: remove some QEMU_CAPS_DEVICE problem cases

On 02/09/2016 02:28 PM, Laine Stump wrote: > On 02/09/2016 01:46 PM, Cole Robinson wrote: >> On 02/09/2016 01:31 PM, Laine Stump wrote: >>> On 02/09/2016 10:58 AM, Cole Robinson wrote: When we unconditionally enable QEMU_CAPS_DEVICE, these tests need some massaging, so do it ahead of

Re: [libvirt] [PATCH] virStringListLength: Ensure const correctness

On Tue, 2016-02-09 at 18:18 +0100, Michal Privoznik wrote: > The virStringListLength function does not ever modify the passed > string list. It merely counts the items in it. Make sure that we > reflect this bit in the function header. >  > Signed-off-by: Michal Privoznik >

Re: [libvirt] [PATCH v2 1/6] tests: qemuxml2argv: remove some QEMU_CAPS_DEVICE problem cases

On 02/09/2016 10:58 AM, Cole Robinson wrote: When we unconditionally enable QEMU_CAPS_DEVICE, these tests need some massaging, so do it ahead of time to not mix it in with the big test refresh. - minimal-s390 is not a real world working config, so drop it - disk-usb was testing for an old code

Re: [libvirt] [PATCH v4 2/2] libxl: keepalive messages support

On 02/05/2016 01:45 PM, Joao Martins wrote: > This patch introduces keep alive messages support for P2P migration > and it adds two new configuration entries namely 'keepalive_interval' > 'keepalive_count' to control it. Behavior of these entries is the > same as qemu driver thus the description

Re: [libvirt] [PATCH v2 5/6] tests: qemuxml2xml: assign device addresses

On 02/09/2016 04:19 PM, Cole Robinson wrote: On 02/09/2016 04:17 PM, Laine Stump wrote: On 02/09/2016 10:59 AM, Cole Robinson wrote: We use the PreFormat callback for this. Many test cases need to be extended to pass in proper qemuCaps flags so AssignAddresses doesn't throw errors. One test

Re: [libvirt] [PATCH v4 1/2] libxl: add p2p migration

On 02/05/2016 01:45 PM, Joao Martins wrote: > Introduce support for VIR_MIGRATE_PEER2PEER in libvirt migration. > Most of the changes occur at the source and no modifications at > the receiver. > > In P2P mode there is only the Perform phase so we must handle the > connection with the destination