[libvirt] [PATCH v3 1/2] migration: add target peer disks port

Some hypervisors (namely qemu) can have a separate connecton for non-shared disks migration of active domains. Currently we have no means to control the port of such a connection. At the same time we have options to control port of memory migration traffic (thru migration uri) as well as

[libvirt] [PATCH v3 1/2] qemuMigrationCookieAddPersistent: move it out and change argument type

This changes allow to use qemuMigrationCookieAddPersistent with an XML definition that isn't assigned to any domain. --- src/qemu/qemu_migration.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index

[libvirt] [PATCH] qemu-hotplug: fix eject media

QEMU changed the error message to: "Tray of device 'drive-sata0-0-1' is not open" and they may change the error massage in the future. This updates the code to not depend on the text from the error message but only on error itself. One more improvement is that we will store the

[libvirt] [PATCH] Use vir*Error instead of VIR_ERROR in qemuStateInitialize

--- src/qemu/qemu_driver.c | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a0d6596..d39058a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -639,7 +639,6 @@

Re: [libvirt] [PATCH V2 0/4] Extend to a tristate

Ping V2 :-). FYI, Joao has {Reviewed,Tested}-by the series. Thanks! Regards, Jim On 03/07/2016 09:02 PM, Jim Fehlig wrote: > On 02/29/2016 09:00 PM, Jim Fehlig wrote: >> An expanded V2 of >> >> https://www.redhat.com/archives/libvir-list/2016-February/msg00140.html >> >> In V2, the feature is

[libvirt] CfP 11th Workshop on Virtualization in High-Performance Cloud Computing (VHPC '16)

CALL FOR PAPERS 11th Workshop on Virtualization in High­-Performance Cloud Computing (VHPC '16) held in conjunction with the International Supercomputing Conference - High Performance, June 19-23, 2016, Frankfurt, Germany.

Re: [libvirt] [PATCH 04/10] secret: Introduce virSecretObjListFindBy{UUID|Usage} support

On 03/02/2016 11:55 AM, John Ferlan wrote: > New API's including unlocked and Locked versions in order to be able > to use in either manner. > > Support for searching hash object lists instead of linked lists will > replace existing secret_driver functions secretFindByUUID and > secretFindByUsage

Re: [libvirt] [PATCH 20/24] hostdev: Save netdev configuration of actual device

On Wed, 2016-03-16 at 15:05 -0400, John Ferlan wrote: > > > And yes, I'm still curious about virHostdevPCINodeDeviceDetach and how > > > that plays into things. > > >  > > What exactly is confusing you about that function? >  > It's somewhere that puts devices on the inactiveList via >

[libvirt] [libvirt-perl][PATCH] Add VIR_MIGRATE_PARAM_DISKS_PORT constant

Signed-off-by: Michal Privoznik --- Changes| 1 + Virt.xs| 13 +++-- lib/Sys/Virt/Domain.pm | 6 ++ 3 files changed, 18 insertions(+), 2 deletions(-) diff --git a/Changes b/Changes index 8f2cba6..9ca0a76 100644 --- a/Changes +++

Re: [libvirt] [PATCH v2 0/7] vz: add disk and controller check in domainPostParse phase

ACK to the series, but please fix [patch 4/7] On 16.03.2016 17:21, Maxim Nestratov wrote: Changes from v1 === A new patch moving prlsdkCheckDiskUnsupportedParams to vz_utils.c added. Commit messages reworded. Minor formatting issues fixed. Maxim Nestratov (1): vz: move

[libvirt] [PATCH v2 2/3] qemu: Omit SPICE address if no port is specified

Currently -spice addr=127.0.0.1 is generated, but spice-server is going to ignore this as no port is specified. --- src/qemu/qemu_command.c| 60 +++--- .../qemuxml2argv-controller-order.args | 2 +- 2 files changed, 32 insertions(+), 30

Re: [libvirt] [PATCH v2] migration: add option to set target ndb server port

On 16.03.2016 18:59, Jiri Denemark wrote: > On Tue, Feb 16, 2016 at 10:31:50 +0300, Nikolay Shirokovskiy wrote: >> Current libvirt + qemu pair lacks secure migrations in case of >> VMs with non-shared disks. The only option to migrate securely >> natively is to use tunneled mode and some kind of

Re: [libvirt] [PATCH v2] migration: add option to set target ndb server port

On Thu, Mar 17, 2016 at 15:58:50 +0300, Nikolay Shirokovskiy wrote: > > > On 16.03.2016 18:59, Jiri Denemark wrote: > > On Tue, Feb 16, 2016 at 10:31:50 +0300, Nikolay Shirokovskiy wrote: > >> Current libvirt + qemu pair lacks secure migrations in case of > >> VMs with non-shared disks. The only

Re: [libvirt] [PATCH] conf: nodedev: Remove inverted match logic

On Wed, 2016-03-16 at 13:18 +0100, Jiri Denemark wrote: > On Wed, Mar 16, 2016 at 13:09:39 +0100, Andrea Bolognani wrote: > > > > Commit c1276177f832 simplified the match logic; this commit > > gets rid of the inverted logic to make the code even more > > straightforward. > > --- > >  

[libvirt] [PATCH v2 1/2] nodedev: Indent PCI express for future fix

Best viewed with '-w' as this is just an adjustment for future patch to be readable without that. Signed-off-by: Martin Kletzander --- src/node_device/node_device_udev.c | 38 -- 1 file changed, 20 insertions(+), 18 deletions(-) diff

Re: [libvirt] guys is the header file broken??

On Fri, 2016-03-18 at 14:00 +0530, Dravid Kumar wrote: > cause i get this error  > > me.cpp: In function ‘int main(int, char**)’: > me.cpp:23:45: error: ‘virConnectCreateXML’ was not declared in this scope >  dom = virConnectCreateXML(conn, xmlconfig, 0); >

Re: [libvirt] Does the proposed solution belong in KVM input devices?

On Wed, Mar 16, 2016 at 04:21:23AM +0100, ban...@openmailbox.org wrote: qemu-discuss doesn't seem the best place to reach the devs. I saw most of the work on KVM input devices was done by Gerd Hoffman and Dan Berrange. Dan do you think the QEMU virtual keyboard is the right place for a solution

[libvirt] [PATCH] conf: nodedev: Remove inverted match logic

Commit c1276177f832 simplified the match logic; this commit gets rid of the inverted logic to make the code even more straightforward. --- src/conf/node_device_conf.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/src/conf/node_device_conf.c

[libvirt] [PATCH v4 0/2] migration: add option to set target ndb server port

Current libvirt + qemu pair lacks secure migrations in case of VMs with non-shared disks. The only option to migrate securely natively is to use tunneled mode and some kind of secure destination URI. But tunelled mode does not support non-shared disks. The other way to make migration secure is to

Re: [libvirt] [PATCH 0/5] virlog: Refactor parsing log outputs

On Wed, Mar 16, 2016 at 12:05:32PM +0100, Erik Skultety wrote: Please actually provide content in the cover letter describing what the series is attempting todo. It is not sufficient to just let people guess at goals based on individual commit messages. > Erik Skultety (5): > virlog: Change

[libvirt] [PATCH 3/7] qemu: monitor: Remove JSON impls of drive_add and drive_del

qemu won't ever add those functions directly to QMP. They will be replaced with 'blockdev-add' and 'blockdev-del' eventually. At this time there's no need to keep the stubs around. Additionally the drive_del stub in JSON contained dead code in the attempt to report errors.

Re: [libvirt] [RFC PATCH] hostdev: add support for "managed='detach'"

Sorry, apparently missed this reply previously On Wed, 16 Mar 2016 11:19:38 +0100 Andrea Bolognani wrote: > On Tue, 2016-03-15 at 13:31 -0600, Alex Williamson wrote: > > So we have all sorts of driver issues that are sure to come and go over > > time and all sorts of use

Re: [libvirt] [PATCH v5 8/9] nss: Introduce a test

On Tue, Mar 15, 2016 at 06:05:55PM +0100, Michal Privoznik wrote: A small test to see how is the nss module working. Signed-off-by: Michal Privoznik --- cfg.mk | 2 +- tests/Makefile.am | 18 tests/nssdata/virbr0.status | 20 +

Re: [libvirt] [PATCH v5 7/9] Implement _nss_libvirt_gethostbyname4_r

On Tue, Mar 15, 2016 at 06:05:54PM +0100, Michal Privoznik wrote: This function is a different beast compared to previous ones. But yet again, nothing surprising is happening here. Signed-off-by: Michal Privoznik --- tools/nss/libvirt_nss.c| 92

Re: [libvirt] [PATCH v2 2/2] nodedev: Expose PCI header type

On Thu, Mar 17, 2016 at 04:07:25PM +, Daniel P. Berrange wrote: On Thu, Mar 17, 2016 at 04:05:18PM +, Daniel P. Berrange wrote: On Thu, Mar 17, 2016 at 04:51:06PM +0100, Martin Kletzander wrote: > If we expose this information, which is one byte in every PCI config > file, we let all

[libvirt] [PATCH v2 0/2] qemu: Support for QXL heads

v2: don't change heads when migrating v1: https://www.redhat.com/archives/libvir-list/2016-March/msg00410.html Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1283207 Martin Kletzander (2): qemu: Check for qxl's max_outputs parameter qemu: Add support to QXL's max_outputs parameter

Re: [libvirt] [PATCH 03/10] secret: Add hashed virSecretObj and virSecretObjList

On 03/02/2016 11:55 AM, John Ferlan wrote: > Add definitions and infrastucture required for a hashed virSecretObj > and virSecretObjList including the class, object, lock setup, and > disposal API's. Nothing will call these yet. > > This infrastructure will replace the forward linked list logic >

Re: [libvirt] [PATCH] qemu: Don't access uninitialized memory

On 16/03/16 10:48, Martin Kletzander wrote: > Very early ping, I know, but it's almost trivial and it fixes a crash > when running domxml-to-native. > > On Fri, Mar 11, 2016 at 02:25:16PM +0100, Martin Kletzander wrote: >> In qemuConnectDomainXMLToNative() we set up the monitor, but we never >>

[libvirt] [Issue]: Regarding client socket getting closed from the server once the lxc container is started

Hi Folks, Using libvirt python bindings we are creating an lxc container.Here is the problem that we see sometimes (say 20 % of the time) when we create a new container. 1.container gets created, and also starts.However the we are not able to enter the namepace of the container.It throws an

[libvirt] [PATCH v4 0/2] persistent live migration with specified XML

v4: wrong param name in commit msg v3: - use shorter name for param and rename args - move qemuMigrationCookieAddPersistent out from qemuMigrationBakeCookie - rebase to master v2: reimplemented with new migration param Libvirt doesn't allow to specify destination persistent domain

[libvirt] [PATCH v3 1/2] nodedev: Indent PCI express for future fix

Best viewed with '-w' as this is just an adjustment for future patch to be readable without that. Signed-off-by: Martin Kletzander --- src/node_device/node_device_udev.c | 38 -- 1 file changed, 20 insertions(+), 18 deletions(-) diff

Re: [libvirt] [PATCH 22/24] hostdev: Streamline device ownership tracking

[...] >>> -/* Step 5: Now mark all the devices as active */ >>> +/* Step 5: Move devices from the inactive list to the active list */ >>> for (i = 0; i < virPCIDeviceListCount(pcidevs); i++) { >>> virPCIDevicePtr pci = virPCIDeviceListGet(pcidevs, i); >>> +

[libvirt] [PATCH v2 2/4] hostdev: Save netdev configuration of actual device

We would be just fine looking up the information in pcidevs most of the time; however, some corner cases would not be handled properly, so look up the actual device instead. --- src/util/virhostdev.c | 41 ++--- 1 file changed, 22 insertions(+), 19 deletions(-)

Re: [libvirt] [PATCH v4 2/5] qemu monitor: add multithread compress parameters accessors

On Fri, Mar 04, 2016 at 14:20:55 +0300, Nikolay Shirokovskiy wrote: > From: ShaoHe Feng > > Signed-off-by: ShaoHe Feng > Signed-off-by: Nikolay Shirokovskiy > --- > src/qemu/qemu_monitor.c | 22 + >

Re: [libvirt] [PATCH v2 1/2] qemuMigrationCookieAddPersistent: change argument type

On Fri, Mar 11, 2016 at 18:13:39 +0300, Dmitry Andreev wrote: > It wasn't possible to add XML not assigned to a domain because > virDomainObjPtr was an argument type. > --- > src/qemu/qemu_migration.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git

[libvirt] [PATCH 1/3] tests: virlogtest: Fix testLogParseOutputs return value

The test can return positive value even though it should have failed. It just returns the value parser returned, which should be flipped back to -1 if something went wrong or the result was unexpected, but it isn't. --- tests/virlogtest.c | 9 + 1 file changed, 5 insertions(+), 4

Re: [libvirt] [libvirt-sandbox PATCH] Silence PyGIWarnings

On Fri, Mar 18, 2016 at 06:32:21PM +0100, Guido Günther wrote: > This fixes > > /usr/bin/virt-sandbox-service:22: PyGIWarning: LibvirtGObject was imported > without specifying a version first. Use gi.require_version('LibvirtGObject', > '1.0') before import to ensure that the right version gets

[libvirt] [PATCH v2 3/7] vz: check supported disk format and bus

From: Mikhail Feoktistov Now we check disk parameters correctness in DomainPostParse. Signed-off-by: Maxim Nestratov --- src/vz/vz_driver.c | 6 +- src/vz/vz_sdk.c| 24 ++-- src/vz/vz_utils.c | 50

Re: [libvirt] [PATCH] bhyve: caps: Log error message when CPU init fails

On 03/19/2016 02:48 PM, Roman Bogorodskiy wrote: > Cole Robinson wrote: > >> virBhyveCapsInitCPU will raise a libvirt error; even though we treat >> it as non-fatal we should log the actual message. >> --- >> src/bhyve/bhyve_capabilities.c | 2 +- >> 1 file changed, 1 insertion(+), 1

Re: [libvirt] [PATCH] nss: don't try to build nss plugin when disabled

On 03/19/2016 01:10 PM, Roman Bogorodskiy wrote: > Even if nss is disabled, the build system tries to build some > targets like libnss_libvirt_impl.la and nsstest. Hide those > under the "if WITH_NSS" block like the rest of NSS plugin bits. > --- > tests/Makefile.am | 8 ++-- >

Re: [libvirt] [PATCH v2 1/3] qemu: Make all SPICE command-line args optional

On Wed, Mar 16, 2016 at 05:45:03PM +0100, Christophe Fergeau wrote: > The end goal is to avoid adding -spice port=0,addr=127.0.0.1 to QEMU command > line when no SPICE port is specified in libvirt XML. > > Currently, the code relies on port=xx to always be present, so subsequent > args can be

[libvirt] [PATCH] docs: fix libvirt version for vram64 in formatdomain.html.in

Signed-off-by: Pavel Hrdina --- Pushed under trivial rule. docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 41f2488..423dcdc 100644 --- a/docs/formatdomain.html.in +++

Re: [libvirt] [libvirt-php 0/3] small improvements

2016-03-07 18:40 GMT+03:00 Vasiliy Tolstov : > Add some more libvirt functions support to binding. > Also add some checks to prevent malloc SIZE_MAX memory > in case of errors > > Vasiliy Tolstov (3): > add some checks to prevent overflow > add block_commit support and

[libvirt] [PATCH 1/2] hostdev: Detect untracked inactive devices

Unmanaged devices are attached to guests in two steps: first, the device is detached from the host and marked as inactive; subsequently, it is marked as active and attached to the guest. If the daemon is restarted between these two operations, we lose track of the inactive device. Steps 5 and 6

Re: [libvirt] [PATCH] bhyve: process: Log error message when kill fails

On 03/19/2016 03:04 PM, Roman Bogorodskiy wrote: > Cole Robinson wrote: > >> virProcessKillPainfully will raise a libvirt error, so log it. We >> can drop the manual pid logging since ProcessKill always reports >> the pid in its error message. >> --- >> src/bhyve/bhyve_process.c | 5 ++--- >>

Re: [libvirt] [PATCH] bhyve: process: Log error message when kill fails

Cole Robinson wrote: > virProcessKillPainfully will raise a libvirt error, so log it. We > can drop the manual pid logging since ProcessKill always reports > the pid in its error message. > --- > src/bhyve/bhyve_process.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff

Re: [libvirt] [PATCH] bhyve: caps: Log error message when CPU init fails

Cole Robinson wrote: > virBhyveCapsInitCPU will raise a libvirt error; even though we treat > it as non-fatal we should log the actual message. > --- > src/bhyve/bhyve_capabilities.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/bhyve/bhyve_capabilities.c

Re: [libvirt] [PATCH v3 2/2] nodedev: Expose PCI header type

On 03/17/2016 12:18 PM, Martin Kletzander wrote: > If we expose this information, which is one byte in every PCI config > file, we let all mgmt apps know whether the device itself is an endpoint > or not so it's easier for them to decide whether such device can be > passed through into a VM

[libvirt] [PATCH v4 1/2] migration: add target peer disks port

Some hypervisors (namely qemu) can have a separate connecton for non-shared disks migration of active domains. Currently we have no means to control the port of such a connection. At the same time we have options to control port of memory migration traffic (thru migration uri) as well as

[libvirt] [PATCH v2 0/2] nodedev: Expose PCI header type information

v2: Removed reporting. v1: https://www.redhat.com/archives/libvir-list/2016-March/msg00645.html Martin Kletzander (2): nodedev: Indent PCI express for future fix nodedev: Expose PCI header type docs/schemas/nodedev.rng | 12 +++ src/conf/node_device_conf.c

Re: [libvirt] [RFC PATCH] hostdev: add support for "managed='detach'"

On Thu, 17 Mar 2016 17:59:53 + "Daniel P. Berrange" wrote: > On Thu, Mar 17, 2016 at 11:52:14AM -0600, Alex Williamson wrote: > > On Thu, 17 Mar 2016 17:32:08 + > > "Daniel P. Berrange" wrote: > > > > > On Tue, Mar 15, 2016 at 02:21:35PM

Re: [libvirt] [PATCH 00/12] qemu_process cleanups and test improvement

Rebased version of this patch series: https://github.com/Antique/libvirt/tree/qemu-process -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 2/6] vsh: Refactor vshCommandOptScaledInt

Fix control flow and spacing issues. --- tools/vsh.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tools/vsh.c b/tools/vsh.c index 047a0cc..cbe8189 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -1143,18 +1143,16 @@ vshCommandOptScaledInt(vshControl *ctl, const

[libvirt] [PATCH v2 0/3] Cosmetic changes to SPICE QEMU commandline

Hey, This is a v2 of the series I previously sent. Changes since v1: - much nicer cmdline generation in patch 1/3 - improved commit log in 1/3 - moved part of patch 1/3 to 3/3 - added test case in 3/3 Christophe -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH v3 0/2] nodedev: Expose PCI header type information

v3: changed 'header' to 'capability', only reported for non-endpoints v2: Removed reporting. https://www.redhat.com/archives/libvir-list/2016-March/msg00774.html v1: https://www.redhat.com/archives/libvir-list/2016-March/msg00645.html Martin Kletzander (2): nodedev: Indent PCI express

[libvirt] [PATCH] tests: Set PATH in each test

Currently we spawn couple of binaries in our test suite. Moreover, we provide some spoofed versions of system binaries hoping that those will be executed instead of the system ones. For instance, for testing SSH socket we have written our own ssh binary for producing predictable results. We

Re: [libvirt] [PATCH] tests: Set PATH in each test

On Thu, Mar 17, 2016 at 02:31:49PM +0100, Michal Privoznik wrote: > Currently we spawn couple of binaries in our test suite. > Moreover, we provide some spoofed versions of system binaries > hoping that those will be executed instead of the system ones. > For instance, for testing SSH socket we

[libvirt] [PATCH v2 1/7] vz: save vz version in connection structure

From: Mikhail Feoktistov Move code from connectGetVersion callback to vzInitVersion function --- src/vz/vz_driver.c | 50 +++--- src/vz/vz_utils.c | 47 +++ src/vz/vz_utils.h |

Re: [libvirt] [PATCH v3 1/2] nodedev: Indent PCI express for future fix

On 03/17/2016 12:18 PM, Martin Kletzander wrote: > Best viewed with '-w' as this is just an adjustment for future patch to > be readable without that. > > Signed-off-by: Martin Kletzander > --- > src/node_device/node_device_udev.c | 38 >

[libvirt] [PATCH 0/7] qemu: block job/disk related cleanups

I've accumulated quite a few patches in my branch to add support for allowing to use 'detect zeroes' for the block copy job. These are pathches that make sense to be posted separately. Peter Krempa (7): qemu: hotplug: Assume support for -device in qemuDomainAttachSCSIDisk qemu: monitor: Drop

Re: [libvirt] netlink message help

2016-03-16 22:34 GMT+03:00 Vasiliy Tolstov : > I'm try to implement adding addresses to ehternet devices via libvirt > and i need to add address with peer (like point to point) > in iproute : ip a add xx.xx.xx.xx peer yy.yy.yy.yy dev tapNNN > > In netlink as i see i need to

[libvirt] [PATCH] nss: don't try to build nss plugin when disabled

Even if nss is disabled, the build system tries to build some targets like libnss_libvirt_impl.la and nsstest. Hide those under the "if WITH_NSS" block like the rest of NSS plugin bits. --- tests/Makefile.am | 8 ++-- tools/Makefile.am | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-)

[libvirt] [PATCH v2 0/4] hostdev: Cleanups and fixes

Respin of patches 20, 22, 23 and 24 from https://www.redhat.com/archives/libvir-list/2016-March/msg00209.html Patches 01-19 have already been pushed; patch 21 has been converted into the tiny series https://www.redhat.com/archives/libvir-list/2016-March/msg00792.html which this one depends

Re: [libvirt] [PATCH v5 6/9] nss: Implement _nss_libvirt_gethostbyname3_r

On Tue, Mar 15, 2016 at 06:05:53PM +0100, Michal Privoznik wrote: The implementation is pretty straightforward. Moreover, because of the nature of things, gethostbyname_r and gethostbyname2_r can be implemented at the same time too. Signed-off-by: Michal Privoznik ---

[libvirt] [PATCH v2 3/4] hostdev: Use actual device when reattaching

Instead of forcing the values for the unbind_from_stub, remove_slot and reprobe properties, look up the actual device and use that when calling virPCIDeviceReattach(). This ensures the device is restored to its original state after reattach: for example, if it was not bound to any driver before

Re: [libvirt] [PATCH v2] qemu: Move last error save/restore to qemuBuildNetCommandLine

On Tue, Mar 15, 2016 at 07:40:01AM -0400, John Ferlan wrote: On 03/15/2016 07:36 AM, John Ferlan wrote: Commit 'ef2ab8fd' moved just the virDomainConfNWFilterTeardown and left the logic to save/restore the current error essentially doing nothing in the error path for qemuBuildCommandLine. So

Re: [libvirt] [PATCH v2 2/2] qemu: migration: new migration param for persistent destination XML

On Fri, Mar 11, 2016 at 18:13:40 +0300, Dmitry Andreev wrote: > Migration API allows to specify a destination domain configuration. > Offline domain has only inactive XML and it is replaced by configuration > specified using VIR_MIGRATE_PARAM_DEST_XML param. In case of live > migration

Re: [libvirt] [RFC PATCH] hostdev: add support for "managed='detach'"

On Tue, Mar 15, 2016 at 02:21:35PM -0400, Laine Stump wrote: > On 03/15/2016 01:00 PM, Daniel P. Berrange wrote: > >On Mon, Mar 14, 2016 at 03:41:48PM -0400, Laine Stump wrote: > >>Suggested by Alex Williamson. > >> > >>If you plan to assign a GPU to a virtual machine, but that GPU happens > >>to

[libvirt] [PATCH 2/3] tests: Add new testcases to test parsing of log filters in virlogtest

--- tests/virlogtest.c | 41 + 1 file changed, 41 insertions(+) diff --git a/tests/virlogtest.c b/tests/virlogtest.c index acb0b08..332b5e4 100644 --- a/tests/virlogtest.c +++ b/tests/virlogtest.c @@ -75,6 +75,37 @@ testLogParseOutputs(const void *opaque)

Re: [libvirt] [PATCH v5 6/9] nss: Implement _nss_libvirt_gethostbyname3_r

On Fri, Mar 18, 2016 at 04:18:15PM +0100, Michal Privoznik wrote: On 18.03.2016 15:10, Martin Kletzander wrote: On Tue, Mar 15, 2016 at 06:05:53PM +0100, Michal Privoznik wrote: The implementation is pretty straightforward. Moreover, because of the nature of things, gethostbyname_r and

[libvirt] [PATCH v3 2/2] qemu: implement setting target disks migration port

Mostly it is just passing new parameter here and there. In case of zero value we fallback to auto selecting port and thus keep backward compatibility. Also we need to fix places of auto selected port managment. We should bother only when auto selected was done that is when externally specified

[libvirt] [PATCH v2 2/7] vz: add vzCapabilities to connection structure

From: Mikhail Feoktistov As far as Virtuozzo6 and Virtuozzo7 support different disk types for virtual machines (ploop and qcow2 respectively) and different buses (vz6: IDE, SCSI, SATA; vz7: IDE SCSI) we add vzCapabilities structure to help undestand which disk formats

[libvirt] [PATCH] Don't warn about nonexisting connection drivers

--- src/driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/driver.c b/src/driver.c index 2985538..1514a3b 100644 --- a/src/driver.c +++ b/src/driver.c @@ -62,7 +62,7 @@ virDriverLoadModule(const char *name) return NULL; if (access(modfile, R_OK) < 0)

Re: [libvirt] [PATCH 18/21] admin: Add virAdmConnectLookupServer

On Wed, Mar 16, 2016 at 12:47:53PM +0100, Erik Skultety wrote: On 10/03/16 05:54, Martin Kletzander wrote: It does not have a suffix ByName because there are no other means of looking up the server and since the name is known, this should be the preferred one. Signed-off-by: Martin Kletzander

Re: [libvirt] [PATCH 2/2] nodedev: Expose PCI header type

On Thu, Mar 17, 2016 at 10:00:36AM +, Daniel P. Berrange wrote: On Wed, Mar 16, 2016 at 10:46:10AM +0100, Martin Kletzander wrote: On Tue, Mar 15, 2016 at 04:37:55PM +, Daniel P. Berrange wrote: >On Tue, Mar 15, 2016 at 05:23:30PM +0100, Martin Kletzander wrote: >>If we expose this

Re: [libvirt] autocreate tap device for VIR_DOMAIN_NET_TYPE_ETHERNET

2016-03-18 18:50 GMT+03:00 Daniel P. Berrange : > I'm a little puzzelled why you're adding this 'peer' address in here > and throughout the code. This patch is supposedly just moving the > existing QEMU logic out into the libvirt layer, so AFAICT, this should > not require any

[libvirt] [PATCH v2 2/2] qemu: Add support to QXL's max_outputs parameter

Historically, we added heads=1 to videos, but for example for qxl, we did not reflect that on the command line. Implementing that now could mean that if user were to migrate from older to newer libvirt, the command-line for qemu would differ. In order for that not to happen a migration cookie

[libvirt] [PATCH] vz: code refactoring

In prlsdkAddNet() Attach/DetachNet() functions privconn should be the first argument --- src/vz/vz_driver.c | 4 ++-- src/vz/vz_sdk.c| 16 src/vz/vz_sdk.h| 4 ++-- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c

[libvirt] [PATCH v2 7/7] vz: set default SCSI model

From: Mikhail Feoktistov Each version of virtuozzo supports only one type of SCSI controller So if we add disk on SCSI bus, we should set SCSI controller model. We can take it from vzCapabilities structure. --- src/vz/vz_driver.c | 2 +- src/vz/vz_sdk.c| 27

Re: [libvirt] [PATCH 02/10] Add secretObjFromSecret

On 03/02/2016 11:54 AM, John Ferlan wrote: > Signed-off-by: John Ferlan > --- > src/secret/secret_driver.c | 45 + > 1 file changed, 21 insertions(+), 24 deletions(-) > > diff --git a/src/secret/secret_driver.c

[libvirt] [PATCH v4 2/2] qemu: implement setting target disks migration port

Mostly it is just passing new parameter here and there. In case of zero value we fallback to auto selecting port and thus keep backward compatibility. Also we need to fix places of auto selected port managment. We should bother only when auto selected was done that is when externally specified

[libvirt] [libvirt-sandbox PATCH] sandbox-builder: Don't try g_file_enumerator_next_file if enumerator is NULL

Passing the NULL enumerator to g_file_enumerator_next_file makes us overwrite error information otherwise: $ sudo bin/virt-sandbox-service create --unitfile foo.service foo (process:18529): GLib-GIO-CRITICAL **: g_file_enumerator_next_file: assertion 'G_IS_FILE_ENUMERATOR (enumerator)'

[libvirt] [libvirt-sandbox PATCH] tests: add file extension for host mounts

otherwise we fail in gvir_sandbox_util_guess_image_format with "Cannot identify file extension in '/tmp/home' --- libvirt-sandbox/tests/test-config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-sandbox/tests/test-config.c b/libvirt-sandbox/tests/test-config.c

Re: [libvirt] [PATCH 0/6] vz: add disk and controller check in domainPostParse phase

15.03.2016 10:47, Mikhail Feoktistov пишет: Mikhail Feoktistov (6): vz: save vz version in connection structure vz: add vzCapabilities to connection structure vz: check supported disk format and bus vz: report correct disk format in domainGetXMLDesc vz: check supported controllers

[libvirt] [PATCH v2 3/3] qemu: Don't add -spice port=0 when no port is specified

If a has no port nor tlsPort set, the generated QEMU command line will contain -spice port=0. This is later going to be ignored by spice-server, but it's better not to add it at all in this situation. As an empty -spice is not allowed, we still need to append port=0 if we did not add any other

[libvirt] Where does 'rx_drop' in 'domifstat' come from?

Any idea why I'd see drops on an interface? mini@ykaul-mini:~/ovirt-system-tests$ sudo virsh domifstat 111 vnet1 vnet1 rx_bytes 25488 vnet1 rx_packets 387 vnet1 rx_errs 0 *vnet1 rx_drop 1424* vnet1 tx_bytes 5751 vnet1 tx_packets 39 vnet1 tx_errs 0 vnet1 tx_drop 0 I have several others VMs in the

Re: [libvirt] [PATCH] conf: nodedev: Remove inverted match logic

On Wed, Mar 16, 2016 at 13:09:39 +0100, Andrea Bolognani wrote: > Commit c1276177f832 simplified the match logic; this commit > gets rid of the inverted logic to make the code even more > straightforward. > --- > src/conf/node_device_conf.c | 28 ++-- > 1 file changed, 14

[libvirt] [PATCH 1/6] vsh: Tweak error message for scaled integers

It was too similar to the non-scaled alternative. before: error: Numeric value 'abc' for option is malformed or out of range after: error: Scaled numeric value 'abc' for option is malformed or out of range --- tests/virsh-optparse | 6 +++--- tools/vsh.c | 4 ++-- 2 files changed, 5

Re: [libvirt] question about rdma migration

Hi Jirka, Thanks for your answer, but I'm looking for a way to set RLIMIT_MEMLOCK without locking all VM memory. I'm wondering if there is a way to set RLIMIT_MEMLOCK without using the methods you wrote above. Regards, Roy On Tue, Mar 15, 2016 at 8:02 PM, Jiri Denemark

Re: [libvirt] [PATCH v2 3/3] qemu: Don't add -spice port=0 when no port is specified

On Fri, Mar 18, 2016 at 10:28:10AM +0100, Ján Tomko wrote: > > @@ -7234,7 +7234,14 @@ > > qemuBuildGraphicsSPICECommandLine(virQEMUDriverConfigPtr cfg, > > virBufferTrim(, ",", -1); > > > > virCommandAddArg(cmd, "-spice"); > > -virCommandAddArgBuffer(cmd, ); > > +/* If we did

[libvirt] [PATCH v2 2/2] nodedev: Expose PCI header type

If we expose this information, which is one byte in every PCI config file, we let all mgmt apps know whether the device itself is an endpoint or not so it's easier for them to decide whether such device can be passed through into a VM (endpoint) or not (*-bridge). Resolves:

Re: [libvirt] [PATCH v2] migration: add option to set target ndb server port

On Tue, Feb 16, 2016 at 10:31:50 +0300, Nikolay Shirokovskiy wrote: > Current libvirt + qemu pair lacks secure migrations in case of > VMs with non-shared disks. The only option to migrate securely > natively is to use tunneled mode and some kind of secure > destination URI. But tunelled mode does

Re: [libvirt] [PATCH v4 0/2] migration: add option to set target ndb server port

On Thu, Mar 17, 2016 at 17:58:46 +0300, Nikolay Shirokovskiy wrote: > Current libvirt + qemu pair lacks secure migrations in case of > VMs with non-shared disks. The only option to migrate securely > natively is to use tunneled mode and some kind of secure > destination URI. But tunelled mode does

[libvirt] [PATCH 5/6] virsh: blockcopy: Support --bytes and scaled integers

Reuse the approach and helper from the last patch. --- tools/virsh-domain.c | 31 +++ tools/virsh.pod | 8 +--- 2 files changed, 24 insertions(+), 15 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index cd616a8..4053c75 100644 ---

Re: [libvirt] [PATCH 20/24] hostdev: Save netdev configuration of actual device

On Wed, 2016-03-16 at 19:50 +0100, Andrea Bolognani wrote: > > Thinking in terms of current code - step4 will take the everything that > > was formerly on the active list and: > >   > > 1. Steal the pcidevs entry > >   > > 2. Call virHostdevReattachPCIDevice with the stolen lookaside pcidevs > >

Re: [libvirt] [RFC PATCH] hostdev: add support for "managed='detach'"

On Thu, Mar 17, 2016 at 05:37:28PM -0400, Laine Stump wrote: > On 03/17/2016 02:32 PM, Daniel P. Berrange wrote: > >On Thu, Mar 17, 2016 at 12:18:49PM -0600, Alex Williamson wrote: > >>On Thu, 17 Mar 2016 17:59:53 + > >>"Daniel P. Berrange" wrote: > >> > >>>I don't think

[libvirt] [PATCH 6/6] virsh: blockpull: Support --bytes and scaled integers

Reuse the approach and helper from the last patch. --- tools/virsh-domain.c | 15 +-- tools/virsh.pod | 9 - 2 files changed, 17 insertions(+), 7 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 4053c75..f808c73 100644 ---

Re: [libvirt] [PATCH 3/5] virlog: Refactor virLogParseOutputs

On Wed, Mar 16, 2016 at 12:05:35PM +0100, Erik Skultety wrote: > The problem with the original virLogParseOutputs method was that the way it > parsed the input, walking the string char by char and using absolute jumps > depending on the virLogDestination type, was rather complicated to read. >

Re: [libvirt] [PATCH] network: differentiate macvtap/bridge from host-bridge based networks

On Fri, Mar 11, 2016 at 11:13:50AM -0500, Laine Stump wrote: > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1316465 > > An attempt to simplify the code for the VIR_NETWORK_FORWARD_BRIDGE > case of networkUpdateState in commit b61db335 (first in release > 1.2.14) resulted in networks

Re: [libvirt] [PATCH v4 2/5] qemu monitor: add multithread compress parameters accessors

On Fri, Mar 04, 2016 at 14:20:55 +0300, Nikolay Shirokovskiy wrote: > From: ShaoHe Feng > > Signed-off-by: ShaoHe Feng > Signed-off-by: Nikolay Shirokovskiy > --- > src/qemu/qemu_monitor.c | 22 + >

  1   2   >