Re: [libvirt] [PATCH v2 0/2] uml: only build on Linux

Cole Robinson wrote: > On 05/08/2016 09:31 AM, Roman Bogorodskiy wrote: > > Changes since v1: > > > > - Add forgotten with_libvirtd check and unite it with the > > with_linux check > > - Minor code formatting fixes in m4/virt-driver-uml.m4 > > > > Roman Bogorodskiy (2): > >

[libvirt] [PATCH] conf: don't redefine virDomainCapsDeviceHostdev

Commit 5ed235c6 added unnecessary redifinition of virDomainCapsDeviceHostdev in conf/domain_capabilities.h. This breaks build with clang 3.4: In file included from conf/domain_capabilities.c:25: conf/domain_capabilities.h:88:44: error: redefinition of typedef 'virDomainCapsDeviceHostdev' is a C11

Re: [libvirt] (no subject)

On 05/09/2016 08:10 PM, Lovely K. wrote: > plz added me ...i need a some application for development Without more details (including a decent subject line), it's very hard to tell what you want help with. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library

[libvirt] (no subject)

plz added me ...i need a some application for development -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2] virsh: blkdeviotune: accept human readable values for bytes

On Mon, May 9, 2016 at 11:32 AM, Michal Privoznik wrote: > On 04.05.2016 16:25, Nishith Shah wrote: > > [1] .. here. > > > Use vshCommandOptScaledInt instead of vshCommandOptULongLong so that > > values with suffixes can be passed when bytes are being passed along. > >

Re: [libvirt] [PATCH v2 0/2] uml: only build on Linux

On 05/08/2016 09:31 AM, Roman Bogorodskiy wrote: > Changes since v1: > > - Add forgotten with_libvirtd check and unite it with the > with_linux check > - Minor code formatting fixes in m4/virt-driver-uml.m4 > > Roman Bogorodskiy (2): > configure: split out UML driver checks > uml:

Re: [libvirt] [PATCH 4/4] qemu_hotplug: fix checking graphics ports

On 05/09/2016 09:48 AM, Pavel Hrdina wrote: > We cannot change ports for running domain and we should error out if > autoport is enabled. > > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu_hotplug.c | 13 > + >

Re: [libvirt] [PATCH 3/4] qemu_process: merge graphics code into qemuProcessSetupGraphics

On 05/09/2016 09:48 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu_process.c | 45 ++--- > 1 file changed, 14 insertions(+), 31 deletions(-) ACK - Cole -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 2/4] graphics: generate fake ports also for tests

On 05/09/2016 09:48 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu_driver.c | 12 > src/qemu/qemu_process.c| 22 > -- > src/qemu/qemu_process.h

Re: [libvirt] [PATCH 1/4] qemu_process: separate graphics port reservation

On 05/09/2016 09:48 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > src/qemu/qemu_process.c | 27 --- > 1 file changed, 20 insertions(+), 7 deletions(-) ACK - Cole -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH REPOST 20/38] virlog: Split output parsing and output defining to separate operations

On 05/04/2016 10:30 AM, Erik Skultety wrote: > Everything has been prepared to successfully split parsing and defining logic > to separate operations. > --- > src/util/virlog.c | 160 > + > src/util/virlog.h | 15 +++-- > tests/testutils.c

Re: [libvirt] [PATCH REPOST 22/38] virlog: Split parsing and setting priority

On 05/04/2016 10:30 AM, Erik Skultety wrote: > Handling of outputs and filters has been changed in a way that splits > parsing and defining. Do the same thing for logging priority as well, this > however, doesn't need much of a preparation. > --- > src/util/virlog.c | 21 + >

Re: [libvirt] [PATCH REPOST 16/38] virlog: Introduce virLogOutputListFree

On 05/04/2016 10:30 AM, Erik Skultety wrote: > This is just a convenience method for discarding a list of outputs instead of > using a 'for' loop everywhere. It is safe to pass -1 as the number of elements > in the list as well as passing NULL as list reference. > --- > src/libvirt_private.syms |

Re: [libvirt] [PATCH REPOST 19/38] virlog: Make virLogReset methods use of virLog(Output|Filter)ListFree

On 05/04/2016 10:30 AM, Erik Skultety wrote: > Now that methods to free logging related lists were introduced, put them to a > use. > --- > src/util/virlog.c | 15 --- > 1 file changed, 4 insertions(+), 11 deletions(-) > > diff --git a/src/util/virlog.c b/src/util/virlog.c > index

Re: [libvirt] [PATCH REPOST 15/38] virlog: Introduce virLogOutputFree

On 05/04/2016 10:30 AM, Erik Skultety wrote: > Add a complementary method to virLogOutputNew. > --- > src/libvirt_private.syms | 1 + > src/util/virlog.c| 21 - > src/util/virlog.h| 1 + > 3 files changed, 18 insertions(+), 5 deletions(-) > > diff --git

Re: [libvirt] [PATCH 0/3] libxl: support Xen migration stream V2

On 05/03/2016 07:19 AM, Wei Liu wrote: > On Mon, May 02, 2016 at 07:01:16PM -0600, Jim Fehlig wrote: >> Hi all, >> >> This patch adds support for Xen migration stream V2 to the libvirt >> libxl driver. In the process it fixes save/restore and migration >> tests in OSSTest, which have been failing

Re: [libvirt] [PATCH REPOST 04/38] virlog: Export virLogOutputPtr through header

On 05/04/2016 10:30 AM, Erik Skultety wrote: > It needs to be exported, since some caller might (for some reason) want to > create a logging output without calling the parser which does this. Also, > some methods will use virLogOutputPtr as data type for one of its arguments. > --- >

Re: [libvirt] [PATCH REPOST 05/38] virlog: Export virLogFilterPtr through header

On 05/04/2016 10:30 AM, Erik Skultety wrote: > As with outputs, some methods declared through a header file need to know > the datatype because of their arguments. > --- > src/util/virlog.c | 2 -- > src/util/virlog.h | 3 +++ > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [libvirt] [PATCH REPOST 03/38] virlog: Convert virLogFilters to a list of pointers to filters

On 05/04/2016 10:30 AM, Erik Skultety wrote: > Same as with outputs; since the operations will be further divided into > smaller > tasks, creating a filter will become a separate operation that will return > a reference to a newly created filter. > --- > src/util/virlog.c | 41

Re: [libvirt] [PATCH REPOST 02/38] virlog: Convert virLogOutputs to a list of pointers to outputs

On 05/04/2016 10:30 AM, Erik Skultety wrote: > Right now, we define outputs one after another. However, the correct flow > should be to define a set of outputs as a whole unit. Therefore each output > should be first created, placed into an array/list and the list will be > defined. Output

Re: [libvirt] [PATCH REPOST 01/38] virlog: Return void instead of int in virLogReset methods

On 05/04/2016 10:30 AM, Erik Skultety wrote: > In this particular case, reset is meant as clearing the whole list of > outputs/filters, not resetting it to a predefined default setting. Looking at > it from that perspective, returning the number of records removed doesn't help > the caller in any

Re: [libvirt] [PATCH 3/5] domaincaps: Report graphics spiceGL

On 05/09/2016 09:48 AM, Daniel P. Berrange wrote: > On Mon, May 09, 2016 at 09:30:30AM -0400, Cole Robinson wrote: >> On 05/09/2016 07:30 AM, Pavel Hrdina wrote: >>> On Sun, May 08, 2016 at 01:49:06PM -0400, Cole Robinson wrote: Reports a tristate enum value for acceptable graphics type=spice

Re: [libvirt] [PATCH 5/5] domaincaps: Report graphics spiceGL

On 05/09/2016 05:27 AM, Michal Privoznik wrote: > On 08.05.2016 19:49, Cole Robinson wrote: >> Reports a tristate enum value for acceptable video model=virtio >> . >> >> Wire it up for qemu too. 'no' is always a valid value, so we >> unconditionally report it. >> --- >>

Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

On Mon, May 09, 2016 at 03:06:18PM +0200, David Hildenbrand wrote: > > > > > > > > > > Just FYI, on other architectures (e.g. s390x), other conditions (e.g. > > > > > cpu > > > > > generation) also define if a CPU model is runnable, so the pure > > > > > availability of > > > > > features does

Re: [libvirt] [PATCH] qemu: add default pci-root device to mips*/malta guests

On 05/09/2016 01:55 PM, Aurelien Jarno wrote: > On 2016-05-04 09:54, Cole Robinson wrote: >> Thanks for the patch. >> >> Can you provide a working mips XML config? We don't have one in the unit test >> suite. >> >> On 05/03/2016 05:23 PM, Aurelien Jarno wrote: >>> The MIPS Malta board has a root

Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

On Mon, May 09, 2016 at 09:20:15AM -0600, Eric Blake wrote: > On 05/06/2016 12:11 PM, Eduardo Habkost wrote: > > Extend query-cpu-definitions schema to allow it to return two new > > optional fields: "runnable" and "unavailable-features". > > "runnable" will tell if the CPU model can be run in the

Re: [libvirt] [PATCH/RFC] Add missing delta from Ubuntu to apparmor profiles

Hi, > Stefan Bader wrote (20 May 2015 10:11:45 GMT) : > intrigeri wrote (15 Jun 2015 15:09:11 GMT) : > My (possibly incomplete) records say that I've tested the latest > proposed patch set back in February (<85iof8v6j5@boum.org>). >> Since I lost most context by now, I will try to find my

Re: [libvirt] [PATCH] qemu: add default pci-root device to mips*/malta guests

On 2016-05-04 09:54, Cole Robinson wrote: > Thanks for the patch. > > Can you provide a working mips XML config? We don't have one in the unit test > suite. > > On 05/03/2016 05:23 PM, Aurelien Jarno wrote: > > The MIPS Malta board has a root PCI controller. It is not sent during > > migration,

Re: [libvirt] NFS over AF_VSOCK in

On Mon, May 09, 2016 at 04:57:17PM +0100, Stefan Hajnoczi wrote: > virtio-vsock support has been added to the nfs-ganesha NFS server. I'm > currently working on upstreaming virtio-vsock into Linux and QEMU. I > also have patches for the Linux NFS client and server. > > Users wishing to share a

[libvirt] NFS over AF_VSOCK in

virtio-vsock support has been added to the nfs-ganesha NFS server. I'm currently working on upstreaming virtio-vsock into Linux and QEMU. I also have patches for the Linux NFS client and server. Users wishing to share a file system with the guest will need to configure the NFS server. Perhaps

Re: [libvirt] [PATCH 8/8] Revert "conf: Validate disk lun using correct types"

On 05/09/2016 04:59 AM, Peter Krempa wrote: > On Fri, May 06, 2016 at 11:19:05 -0400, John Ferlan wrote: >> >> >> On 05/02/2016 10:32 AM, Peter Krempa wrote: >>> This reverts commit c79ebf53b5fe0a33bf407b3bcb49e3a27ec97eb4. >>> >>> We can't just add checks to the XML parser once we've accepted

Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

On 05/06/2016 12:11 PM, Eduardo Habkost wrote: > Extend query-cpu-definitions schema to allow it to return two new > optional fields: "runnable" and "unavailable-features". > "runnable" will tell if the CPU model can be run in the current > host. "unavailable-features" will contain a list of CPU >

Re: [libvirt] [PATCH 25/27] fdstream: Suppress use of IO helper for sparse streams

On 05.05.2016 17:51, Eric Blake wrote: > On 05/05/2016 09:32 AM, Daniel P. Berrange wrote: >> On Thu, Apr 28, 2016 at 12:05:12PM +0200, Michal Privoznik wrote: >>> This is kind of a hacky approach to the following problem, but so >>> far I am unable to come up with anything better. On some >>>

Re: [libvirt] Introducing myself (GSoC 2016 student)

On 05/09/2016 08:42 AM, Katerina Koukiou wrote: > Hi, > my name is Katerina Koukiou and I got selected as a GSoC student this year > to work on libvirt. My project is to add libvirt support for migration of > lxc containers using a tool called CRIU. > For the time, I am in my final year of

Re: [libvirt] [PATCH 3/5] domaincaps: Report graphics spiceGL

On 09.05.2016 13:30, Pavel Hrdina wrote: > On Sun, May 08, 2016 at 01:49:06PM -0400, Cole Robinson wrote: >> Reports a tristate enum value for acceptable graphics type=spice >> . >> >> Wire it up for qemu too. 'no' is always a valid value, so we >> unconditionally report it. >> --- > > [...] >

Re: [libvirt] [PATCH 00/27] Introduce sparse streams

On Mon, May 09, 2016 at 04:43:44PM +0200, Michal Privoznik wrote: > On 05.05.2016 18:10, Daniel P. Berrange wrote: > > On Thu, Apr 28, 2016 at 12:04:47PM +0200, Michal Privoznik wrote: > >> > > > > While it looks ok-ish in the context of the RecvAll function, > > because you have skipFunc +

Re: [libvirt] [PATCH 25/27] fdstream: Suppress use of IO helper for sparse streams

On 05.05.2016 18:12, Daniel P. Berrange wrote: > On Thu, May 05, 2016 at 09:51:22AM -0600, Eric Blake wrote: >> On 05/05/2016 09:32 AM, Daniel P. Berrange wrote: >>> On Thu, Apr 28, 2016 at 12:05:12PM +0200, Michal Privoznik wrote: This is kind of a hacky approach to the following problem,

Re: [libvirt] [PATCH 04/27] Introduce virStreamSkip

On 05.05.2016 16:37, Eric Blake wrote: > On 04/28/2016 04:04 AM, Michal Privoznik wrote: >> This API can be used to tell the other side of the stream to skip >> some bytes in the stream. This can be used to create a sparse >> file on the receiving side of a stream. >> >> It takes just one argument

Re: [libvirt] [PATCH 05/27] Introduce virStreamRegisterSkip and virStreamSkipCallback

On 05.05.2016 16:49, Eric Blake wrote: > On 04/28/2016 04:04 AM, Michal Privoznik wrote: >> The former is a public API and registers a callback that >> will be called whenever the other side of a stream calls >> virStreamSkip. The latter is a wrapper that actually calls >> the callback. It is not

Re: [libvirt] [PATCH 00/27] Introduce sparse streams

On 05.05.2016 18:10, Daniel P. Berrange wrote: > On Thu, Apr 28, 2016 at 12:04:47PM +0200, Michal Privoznik wrote: >> > > While it looks ok-ish in the context of the RecvAll function, > because you have skipFunc + recvFunc both being invoked > asynchronously, this design feels a quite odd when

Re: [libvirt] [PATCH 3/5] domaincaps: Report graphics spiceGL

On Mon, May 09, 2016 at 09:30:30AM -0400, Cole Robinson wrote: > On 05/09/2016 07:30 AM, Pavel Hrdina wrote: > > On Sun, May 08, 2016 at 01:49:06PM -0400, Cole Robinson wrote: > >> Reports a tristate enum value for acceptable graphics type=spice > >> . > >> > >> Wire it up for qemu too. 'no' is

[libvirt] [PATCH 3/4] qemu_process: merge graphics code into qemuProcessSetupGraphics

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_process.c | 45 ++--- 1 file changed, 14 insertions(+), 31 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 3d46695..eddf3a7 100644 ---

[libvirt] [PATCH 0/4] some graphics cleanups and improvements

Pavel Hrdina (4): qemu_process: separate graphics port reservation graphics: generate fake ports also for tests qemu_process: merge graphics code into qemuProcessSetupGraphics qemu_hotplug: fix checking graphics ports src/qemu/qemu_driver.c | 12 ---

[libvirt] [PATCH 4/4] qemu_hotplug: fix checking graphics ports

We cannot change ports for running domain and we should error out if autoport is enabled. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_hotplug.c | 13 + .../qemuhotplug-graphics-spice-listen-network.xml | 2 +- 2

[libvirt] [PATCH 1/4] qemu_process: separate graphics port reservation

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_process.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 22b27b3..f110a66 100644 --- a/src/qemu/qemu_process.c +++

[libvirt] [PATCH 2/4] graphics: generate fake ports also for tests

Signed-off-by: Pavel Hrdina --- src/qemu/qemu_driver.c | 12 src/qemu/qemu_process.c| 22 -- src/qemu/qemu_process.h| 8

Re: [libvirt] [PATCH 3/5] domaincaps: Report graphics spiceGL

On Mon, May 09, 2016 at 09:30:30 -0400, Cole Robinson wrote: > On 05/09/2016 07:30 AM, Pavel Hrdina wrote: > > On Sun, May 08, 2016 at 01:49:06PM -0400, Cole Robinson wrote: > > Really wish someone would have chimed in with this to my (unresponded) RFC > email about these things... > >

Re: [libvirt] [PATCH 3/5] domaincaps: Report graphics spiceGL

On 05/09/2016 05:26 AM, Michal Privoznik wrote: > On 08.05.2016 19:49, Cole Robinson wrote: >> Reports a tristate enum value for acceptable graphics type=spice >> . > > This ^^ is part of graphics element as follows: > > > > .. > >> >> Wire it up for qemu too. 'no' is always a valid value,

Re: [libvirt] [PATCH 3/5] domaincaps: Report graphics spiceGL

On 05/09/2016 07:30 AM, Pavel Hrdina wrote: > On Sun, May 08, 2016 at 01:49:06PM -0400, Cole Robinson wrote: >> Reports a tristate enum value for acceptable graphics type=spice >> . >> >> Wire it up for qemu too. 'no' is always a valid value, so we >> unconditionally report it. >> --- > > [...] >

Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

> > > > > > > > Just FYI, on other architectures (e.g. s390x), other conditions (e.g. > > > > cpu > > > > generation) also define if a CPU model is runnable, so the pure > > > > availability of > > > > features does not mean that a cpu model is runnable. > > > > > > > > We could have

[libvirt] Introducing myself (GSoC 2016 student)

Hi, my name is Katerina Koukiou and I got selected as a GSoC student this year to work on libvirt. My project is to add libvirt support for migration of lxc containers using a tool called CRIU. For the time, I am in my final year of undergraduate studies in Electrical and Computer Engineering, at

Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

On Mon, May 09, 2016 at 02:05:05PM +0200, David Hildenbrand wrote: > > On Mon, May 09, 2016 at 10:54:53AM +0200, David Hildenbrand wrote: > > > > Extend query-cpu-definitions schema to allow it to return two new > > > > optional fields: "runnable" and "unavailable-features". > > > > "runnable"

[libvirt] [PATCH] qemu.conf: spaces correction

libvirt/qemu.conf: spaces correction --- src/qemu/qemu.conf | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index 4fa5e8a..5cf4599 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@

Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

> On Mon, May 09, 2016 at 10:54:53AM +0200, David Hildenbrand wrote: > > > Extend query-cpu-definitions schema to allow it to return two new > > > optional fields: "runnable" and "unavailable-features". > > > "runnable" will tell if the CPU model can be run in the current > > > host.

Re: [libvirt] [PATCH 0/9] Add runnability info to query-cpu-definitions

> This series extends query-cpu-definitions to include two extra > fields: "runnable", and "unavailable-features". > > This will return information based on the current machine and > accelerator only. In the future we may extend these mechanisms to > allow querying other machines and other

Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

> Extend query-cpu-definitions schema to allow it to return two new > optional fields: "runnable" and "unavailable-features". > "runnable" will tell if the CPU model can be run in the current > host. "unavailable-features" will contain a list of CPU > properties that are preventing the CPU model

Re: [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

On Mon, May 09, 2016 at 10:54:53AM +0200, David Hildenbrand wrote: > > Extend query-cpu-definitions schema to allow it to return two new > > optional fields: "runnable" and "unavailable-features". > > "runnable" will tell if the CPU model can be run in the current > > host. "unavailable-features"

Re: [libvirt] [PATCH] util: polkit: Fix polkit agent startup

On Mon, May 09, 2016 at 11:10:15 +0200, Peter Krempa wrote: > Commit 0b36b0e9 broke polkit agent startup when attempting to fix a > coverity warning. Refactor it properly so that we don't need the 'cmd' > intermediate variable. > --- > src/util/virpolkit.c | 26 -- > 1

Re: [libvirt] [PATCH 4/8] qemu: command: Use more appropriate checking function for block devices

On Fri, May 06, 2016 at 11:09:38 -0400, John Ferlan wrote: > > > On 05/02/2016 10:32 AM, Peter Krempa wrote: > > In qemuCheckDiskConfig would now use virDomainDiskSourceIsBlockType just > > as a glorified version of virStorageSourceIsBlockLocal that reports > > error messages. Replace it with

Re: [libvirt] [PATCH 3/5] domaincaps: Report graphics spiceGL

On Sun, May 08, 2016 at 01:49:06PM -0400, Cole Robinson wrote: > Reports a tristate enum value for acceptable graphics type=spice > . > > Wire it up for qemu too. 'no' is always a valid value, so we > unconditionally report it. > --- [...] > diff --git

Re: [libvirt] [PATCH 1/8] util: Replace virDomainDiskSourceIsBlockType with a new helper

On Fri, May 06, 2016 at 10:33:49 -0400, John Ferlan wrote: > On 05/02/2016 10:32 AM, Peter Krempa wrote: > > For disks sources described by a libvirt volume we don't need to do a > > complicated check since virStorageTranslateDiskSourcePool already > > correctly determines the actual disk type. >

Re: [libvirt] [PATCH v2 3/8] Add support for fetching statistics of completed jobs

Hi, FYI as tracking down that failure did cost me some time and hopefully this summary will help other to avoid this situation: Am 09.09.2014 um 11:54 schrieb Jiri Denemark: > virDomainGetJobStats gains new VIR_DOMAIN_JOB_STATS_COMPLETED flag that > can be used to fetch statistics of a completed

Re: [libvirt] [PATCH 1/5] domaincaps: Report graphics type enum

On 08.05.2016 19:49, Cole Robinson wrote: > Requires adding the plumbing for > Wire it up for qemu too > --- > I stuck the element between and to match > the ordering in XML > > docs/formatdomaincaps.html.in | 30 > +- > docs/schemas/domaincaps.rng

Re: [libvirt] [PATCH 2/5] domaincaps: Report video modelType

On 08.05.2016 19:49, Cole Robinson wrote: > Requires adding the plumbing for > The value is to match the associated domain > XML of > > Wire it up for qemu too > --- > docs/formatdomaincaps.html.in | 29 > ++ > docs/schemas/domaincaps.rng

Re: [libvirt] [PATCH 3/5] domaincaps: Report graphics spiceGL

On 08.05.2016 19:49, Cole Robinson wrote: > Reports a tristate enum value for acceptable graphics type=spice > . This ^^ is part of graphics element as follows: .. > > Wire it up for qemu too. 'no' is always a valid value, so we > unconditionally report it. > --- >

Re: [libvirt] [PATCH 5/5] domaincaps: Report graphics spiceGL

On 08.05.2016 19:49, Cole Robinson wrote: > Reports a tristate enum value for acceptable video model=virtio > . > > Wire it up for qemu too. 'no' is always a valid value, so we > unconditionally report it. > --- > docs/formatdomaincaps.html.in | 9 + >

Re: [libvirt] [PATCH 4/5] qemu: command: unconditionally allow accel3d='no'

On 08.05.2016 19:49, Cole Robinson wrote: > This matches how we handle spice gl='no' even if spice GL isn't > supported. Not too interesting in practice but I figure we should > be consistent > --- > src/qemu/qemu_command.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[libvirt] [PATCH] util: polkit: Fix polkit agent startup

Commit 0b36b0e9 broke polkit agent startup when attempting to fix a coverity warning. Refactor it properly so that we don't need the 'cmd' intermediate variable. --- src/util/virpolkit.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git

Re: [libvirt] [PATCH 8/8] Revert "conf: Validate disk lun using correct types"

On Fri, May 06, 2016 at 11:19:05 -0400, John Ferlan wrote: > > > On 05/02/2016 10:32 AM, Peter Krempa wrote: > > This reverts commit c79ebf53b5fe0a33bf407b3bcb49e3a27ec97eb4. > > > > We can't just add checks to the XML parser once we've accepted such > > configuration in the past. > > --- > >

Re: [libvirt] [PATCH 0/4] qemu_monitor_json: Refactor even more

On 06.05.2016 20:03, John Ferlan wrote: > > > On 05/04/2016 08:33 AM, Michal Privoznik wrote: >> All these patches will be squashed into one, but I've split them >> into multiple because of easier review. >> >> Michal Privoznik (4): >> qemu_monitor_json: Follow refactor >> qemu_monitor_json:

Re: [libvirt] [PATCH] qemu: domain: Don't treat unknown storage type as not having backing chain

On Fri, May 06, 2016 at 11:23:13 -0400, John Ferlan wrote: [...] > > Do you believe it still would be worthwhile to add: > > if (virDomainDiskGetFormat(def) == VIR_STORAGE_FILE_NONE) > virDomainDiskSetFormat(def, VIR_STORAGE_FILE_RAW); > > in virStorageTranslateDiskSourcePool in

Re: [libvirt] [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions

Eduardo Habkost writes: > Extend query-cpu-definitions schema to allow it to return two new > optional fields: "runnable" and "unavailable-features". > "runnable" will tell if the CPU model can be run in the current > host. "unavailable-features" will contain a list of CPU >

Re: [libvirt] [PATCHv2] virsh: blkdeviotune: accept human readable values for bytes

On 04.05.2016 16:25, Nishith Shah wrote: [1] .. here. > Use vshCommandOptScaledInt instead of vshCommandOptULongLong so that > values with suffixes can be passed when bytes are being passed along. > Values for the iops parameters still need to be given in the absolute > form as they are not