Some Intel processor families (e.g. the Intel Xeon processor E5 v3
family) introduced some PQos (Platform Qos) features, including CMT
(Cache Monitoring echnology) and MBM (Memory Bandwidth Monitoring),
to monitor or control shared resource. This patch add them into x86
part of cpu_map.xml to be us
On 06/16/16 11:55, Eduardo Habkost wrote:
> On Thu, Jun 16, 2016 at 12:04:50PM +0200, Paolo Bonzini wrote:
> > On 16/06/2016 08:05, Haozhong Zhang wrote:
> > > From: Ashok Raj
> > >
> > > On Intel platforms, this patch adds LMCE to KVM MCE supported
> > > capabilities and handles guest access to
On Fri, 10 Jun 2016 17:52:47 +0200
Andrea Bolognani wrote:
> On Tue, 2016-05-31 at 16:08 +1000, David Gibson wrote:
> > > QEMU fails with errors like
> > >
> > > qemu-kvm: Cannot support more than 8 threads on PPC with KVM
> > > qemu-kvm: Cannot support more than 1 threads on PPC with TCG
>
$subj: "supplementary"
On 06/15/2016 11:58 AM, Peter Krempa wrote:
> Since introduction of the DAC security driver we've documented that
> seclabels with a leading + can be used with numerical uid. This would
> not work though with the rest of libvirt if the uid was not actually
> used in the sys
On 06/16/2016 10:59 PM, Jim Fehlig wrote:
> Commit 2a58ed0b added support for creating guests with USB
> hostdevs. Commit fc21d10 later added support for hotplut of
^ hotplug
> USB hostdevs. Advertise support for USB hostdevs in the
> domca
Commit 2a58ed0b added support for creating guests with USB
hostdevs. Commit fc21d10 later added support for hotplut of
USB hostdevs. Advertise support for USB hostdevs in the
domcapabilities.
Signed-off-by: Jim Fehlig
---
src/libxl/libxl_capabilities.c | 5 +
1 file changed, 5 insertions(+)
On 06/10/2016 11:33 AM, Michal Privoznik wrote:
> The problem is this: when working on redirdev detach, I've
> noticed that even though I've passed device alias in the input
> device XML, it got transformed into inactive in
> qemuDomainDetachDeviceLive() while in
> qemuDomainDetachDeviceConfig()
On 06/10/2016 11:33 AM, Michal Privoznik wrote:
> For some reason, as soon as redirdev is detached, qemu removes
> the chardev too. Well, it's easier for us then, so hard feelings
> here.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_driver.c | 4 ++-
> src/qemu/qemu_hotplug.c |
On 06/10/2016 11:32 AM, Michal Privoznik wrote:
> This is fairly simple. We lookup the device in the array of
> devices and remove it. No magic.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_driver.c | 13 -
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
ACK - al
On 06/10/2016 11:32 AM, Michal Privoznik wrote:
> This is really simple, we just need to append the device into the
> domain def and that's it.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_driver.c | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
ACK
John
--
On 06/10/2016 11:32 AM, Michal Privoznik wrote:
> This is going to be important later when we received
> DEVICE_DELETED event on the qemu monitor. If we do,
> virDomainDefFindDevice() is called to find the device for given
> device alias in the virDomainDef tree. When we enable removal for
> redi
On 06/10/2016 11:32 AM, Michal Privoznik wrote:
> Basically, there are just two functions introduced here:
> virDomainRedirdevDefFind which looks up given redirdev in domain
> definition, and virDomainRedirdevDefRemove which removes the
> device at given index in the array of devices.
>
> Signed
Changes since v1:
* Enum numeration fixed
* Macro getting "usage" field fixed
Changes since v2:
* previous patches were on wrong branch
* qemu's stat name was "stat-available-memory"
Changes since v3:
* 3rd patch added
Changes since v4:
* Formatted and rephrased commit messages
* fixed libvi
From: Derbyshev Dmitry
Currently 'memtotal' in virtio drivers and qemu corresponds
to 'available' in libvirt. Because of that we introduce libvirt 'usable'
parameter, which maps to 'stat-available-memory' balloon statistics.
As balloon statistics isn't reported in hmp, so no modification is made
From: Derbyshev Dmitry
QEMU reports timestamp along with other memory statistics, but this
information is not reported by libvirt statistics API.
It could be useful to determine if the data reported is fresh or not.
Signed-off-by: Derbyshev Dmitry
---
include/libvirt/libvirt-domain.h | 5
From: Derbyshev Dmitry
To collect all balloon statistics for all guests it was necessary to make
several libvirt requests. Now it's possible to get all balloon statiscs via
single connectGetAllDomainStats call.
Signed-off-by: Derbyshev Dmitry
Signed-off-by: Maxim Nestratov
---
src/qemu/qemu_d
08.06.2016 16:30, Derbyshev Dmitriy пишет:
From: Derbyshev Dmitry
QEMU reports timestamp and available along with other memory statistics.
This information was not saved into domain statistics.
Also, to collect all balloon statistics for all guests it was necessary to make
several libvirt req
On 06/10/2016 11:32 AM, Michal Privoznik wrote:
> There's currently just one limitation: redirdevs that want to go
> on USB bus require a USB controller, surprisingly.
> At the same time, since I'm using virDomainDefHasUSB() in this
> new validator function, it has to be moved a few lines up and
On 06/16/2016 05:40 AM, Joao Martins wrote:
> On 06/16/2016 06:11 AM, Jim Fehlig wrote:
>> When converting domXML to xen xl.cfg, backendtype should
>> not be emitted if is not specified. Moreover,
>> should be converted to backendtype
>> qdisk, similar to handling of in libxlMakeDisk()
>> in lib
On 06/16/2016 02:24 PM, John Ferlan wrote:
On 06/16/2016 01:29 PM, Laine Stump wrote:
Commit b3d069872ce53eb added peer address setting to the low level
virNetDevSetIPAddress() function, but ended up causing a segfault in
cases where the caller passed NULL for peer address.
Commit a3510e33d33e
On 06/16/2016 01:29 PM, Laine Stump wrote:
> Commit b3d069872ce53eb added peer address setting to the low level
> virNetDevSetIPAddress() function, but ended up causing a segfault in
> cases where the caller passed NULL for peer address.
>
> Commit a3510e33d33e52c fixed the segfault, but managed
On 06/15/2016 11:15 AM, Peter Krempa wrote:
> The parser was totaly broken. Fix it by rewriting it. Add tests so that
> it doesn't happen.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1346723
> ---
> src/conf/domain_conf.c | 47
> -
On 06/15/2016 11:15 AM, Peter Krempa wrote:
> There was no documentation at all for the XML part. I added at least
> some. The 2.0.0 introduction date is deliberate as the parser for the
> XML is broken.
>
> The schema file was missing entries for 'mbml' and 'mbmt'.
> ---
> docs/formatdomain.ht
On 06/15/2016 11:15 AM, Peter Krempa wrote:
> A bug in the code used the value of the first perf event as state for
> all the mentioned one rather than extracting individual ones.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1346730
> ---
> src/qemu/qemu_driver.c | 2 +-
> 1 file c
On 06/15/2016 09:56 AM, Peter Krempa wrote:
> ---
> src/bhyve/bhyve_driver.c | 2 +-
> src/conf/domain_audit.c| 2 +-
> src/conf/domain_conf.c | 22 +++---
> src/conf/domain_conf.h | 2 +-
> src/libvirt_private.syms | 2 +-
> src/libxl/libxl_driver.c | 6 ++
Hi,
There is a typo in the commit message.
This patch is for introducing virsh pool-event command.
Thanks,
Jovanka
On Thu, Jun 16, 2016 at 7:27 PM, Jovanka Gulicoska <
jovanka.gulico...@gmail.com> wrote:
> ---
> tools/virsh-pool.c | 184
> +
On 06/15/2016 09:56 AM, Peter Krempa wrote:
> While we need to know the difference between the total memory stored in
> and the actual size not included in the possible memory modules
> we can't pre-calculate it reliably. This is due to the fact that
> libvirt's XML is copied via formatting and
Commit b3d069872ce53eb added peer address setting to the low level
virNetDevSetIPAddress() function, but ended up causing a segfault in
cases where the caller passed NULL for peer address.
Commit a3510e33d33e52c fixed the segfault, but managed to cause us to
skip setting the broadcast address when
---
tools/virsh-pool.c | 184 +
tools/virsh.pod| 18 ++
2 files changed, 202 insertions(+)
diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c
index f9299e2..18e218c 100644
--- a/tools/virsh-pool.c
+++ b/tools/virsh-pool.c
@@ -32,6 +32
On 06/14/2016 07:08 AM, Chen Hanxiao wrote:
> From: Chen Hanxiao
>
> Signed-off-by: Chen Hanxiao
>
> ---
> src/util/vireventpoll.c | 1 -
> 1 file changed, 1 deletion(-)
>
ACK, pushed.
Tks,
John
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/l
Without that we might get similar messages in the log:
error : virDriverLoadModule:73 : failed to load module
/usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so
/usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so: undefined
symbol: virStorageFileCreate
Signed-off-by: Mart
On 06/14/2016 05:22 PM, Jovanka Gulicoska wrote:
> Changes since v1: use double newline spacing, change LIBVIRT_CHECK_VERSION
> to 2.0.0
>
> Python buindings and tests for storage pool lifecycle events API.
> Function storageDetailToString() is not implemented for now.
>
> Jovanka Gulicoska (2):
Add a new TLS X.509 certificate type - "chardev". This will handle the
creation of a TLS certificate capability (and possibly repository) for
properly configured character device TCP backends.
Unlike the vnc and spice there is no "listen" or "passwd" associated. The
credentials will be handled via
Rather than specify perhaps multiple TLS X.509 certificate directories,
let's create a "default" directory which can then be used if the service
(e.g. for now vnc and spice) does not supply a default directory.
Since the default for vnc and spice may have existed before without being
supplied, the
If the incoming XML defined a path to a TLS X.509 certificate environment,
add the necessary 'tls-creds-x509' object to the VIR_DOMAIN_CHR_TYPE_TCP
character device.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.h | 1 +
src/qemu/qemu_command.c | 2 +-
src/qemu/qemu_command.h
When building a chardev device string for tcp, add the necessary pieces to
access provide the TLS X.509 path to qemu. This includes generating the
'tls-creds-x509' object and then adding the 'tls-creds' parameter to the
VIR_DOMAIN_CHR_TYPE_TCP command line.
Finally add the tests for the qemu comm
v2: http://www.redhat.com/archives/libvir-list/2016-June/msg01044.html
Patches 3 and 4 from original already pushed.
Changes since v2:
Patch 1: (the two bullets were ACK'd, but 3rd introduced new change so repost)
* Change to using /etc/pki/qemu as the default directory name
* Add descr
Something weird happened with the series titles, they have 'python' in the
name! Did you trigger send-email from the libvirt-python.git directory, or
maybe you edited .git/config in the wrong repo?
Anyways, I've pushed patches 1-6 with the following changes to this patch:
On 06/16/2016 04:08 AM,
On 06/16/2016 11:17 AM, Martin Kletzander wrote:
> John suggested I clean up some things, so here they are. 2 out of 3
> are trivial, but the first patch would look really really ugly if I
> wquashed them together (feel free to try).
>
I create enough ugly patches - no need to see more ;-)
>
On 06/16/2016 04:09 AM, Jovanka Gulicoska wrote:
> Add virsh-pool support for storage pool lifecycle events
> ---
> tools/virsh-pool.c | 184
> +
> 1 file changed, 184 insertions(+)
>
I needed this diff to get things working:
diff --git a/too
Best viewed with -w since this is mostly just an indentation patch.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_driver.c | 49 +++--
1 file changed, 23 insertions(+), 26 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
John suggested I clean up some things, so here they are. 2 out of 3
are trivial, but the first patch would look really really ugly if I
wquashed them together (feel free to try).
Martin Kletzander (3):
qemu: Unify automatic coredump filenames
qemu: Follow coding style convention
qemu: Remo
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_driver.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 31ab732d8baa..8a3e61c96f11 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -3930,7 +3930,10
Just create a helper for it and use it.
Signed-off-by: Martin Kletzander
---
src/qemu/qemu_driver.c | 63 ++
1 file changed, 33 insertions(+), 30 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index f289a831bb53..31ab732
On Thu, Jun 16, 2016 at 12:04:50PM +0200, Paolo Bonzini wrote:
> On 16/06/2016 08:05, Haozhong Zhang wrote:
> > From: Ashok Raj
> >
> > On Intel platforms, this patch adds LMCE to KVM MCE supported
> > capabilities and handles guest access to LMCE related MSRs.
> >
> > Signed-off-by: Ashok Raj
On Thu, Jun 16, 2016 at 09:06:29AM -0400, John Ferlan wrote:
On 06/13/2016 10:34 AM, Martin Kletzander wrote:
Similarly to commit d294f6b0dff7, if the name is long enough, the
filename can be longer than filesystem's limit.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1334237
Signed
On Thu, 2016-06-16 at 15:10 +0100, Daniel P. Berrange wrote:
> > > diff --git a/docs/downloads.html.in b/docs/downloads.html.in
> > > index f213b29..1a3400a 100644
> > > --- a/docs/downloads.html.in
> > > +++ b/docs/downloads.html.in
> > > @@ -28,8 +28,8 @@
> > >
> > >
> > >
> > >
On Thu, Jun 16, 2016 at 04:03:01PM +0200, Andrea Bolognani wrote:
> On Wed, 2016-06-15 at 15:03 +0200, Andrea Bolognani wrote:
> > diff --git a/docs/downloads.html.in b/docs/downloads.html.in
> > index f213b29..1a3400a 100644
> > --- a/docs/downloads.html.in
> > +++ b/docs/downloads.html.in
> > @@
On 16/06/16 15:37, Daniel P. Berrange wrote:
> On Tue, May 31, 2016 at 10:52:35AM +0200, Erik Skultety wrote:
>> On 11/05/16 16:12, Daniel P. Berrange wrote:
>>> The logging framework has categories which can be selectively
>>> enabled/disabled by setting a suitable LIBVIRT_LOG_FILTERS
>>> environm
On Wed, 2016-06-15 at 15:03 +0200, Andrea Bolognani wrote:
> diff --git a/docs/downloads.html.in b/docs/downloads.html.in
> index f213b29..1a3400a 100644
> --- a/docs/downloads.html.in
> +++ b/docs/downloads.html.in
> @@ -28,8 +28,8 @@
>
>
>
> - href="ftp://libvirt.org/libvirt/l
On 06/15/2016 02:54 AM, sannyshao wrote:
> ---
> tools/virsh-network.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
I altered the text though to follow other dumpxml's (dumpxml,
iface-dumpxml, and pool-dumpxml ".help" strings :
"show inactive defined XML"
And altered the commit
On Tue, May 31, 2016 at 10:52:35AM +0200, Erik Skultety wrote:
> On 11/05/16 16:12, Daniel P. Berrange wrote:
> > The logging framework has categories which can be selectively
> > enabled/disabled by setting a suitable LIBVIRT_LOG_FILTERS
> > environment variable or config file setting.
> >
> > Al
On Thu, Jun 16, 2016 at 06:42:27AM -0400, John Ferlan wrote:
> If the incoming XML defined a path to a TLS X.509 certificate environment,
> add the necessary 'tls-creds-x509' object to the VIR_DOMAIN_CHR_TYPE_TCP
> character device.
>
> Signed-off-by: John Ferlan
> ---
> src/conf/domain_conf.h
On Thu, Jun 16, 2016 at 06:42:26AM -0400, John Ferlan wrote:
> When building a chardev device string for tcp, add the necessary pieces to
> access provide the TLS X.509 path to qemu. This includes generating the
> 'tls-creds-x509' object and then adding the 'tls-creds' parameter to the
> VIR_DOMAI
On Thu, Jun 16, 2016 at 06:42:22AM -0400, John Ferlan wrote:
> Rather that specify perhaps multiple TLS X.509 certificate directories,
> let's create a "default" directory which can then be used if the service
> (e.g. for now vnc and spice) does not supply a default directory.
>
> Since the defaul
On Thu, Jun 16, 2016 at 06:42:25AM -0400, John Ferlan wrote:
> Soon at least one of them will need to grab something out of the
> qemu config structure
>
> Signed-off-by: John Ferlan
> ---
> src/qemu/qemu_command.c | 56
> ++---
> 1 file changed, 34 i
On 06/09/2016 08:15 AM, Cole Robinson wrote:
> Just a couple error message tweaks/cleanups regarding active
> block jobs, noticed while looking at
> https://bugzilla.redhat.com/show_bug.cgi?id=1342276
>
> Cole Robinson (2):
> qemu: More usage of qemuDomainDiskBlockJobIsActive
> qemu: migrati
On Thu, Jun 16, 2016 at 06:42:24AM -0400, John Ferlan wrote:
> It's not used externally anywhere else
>
> Signed-off-by: John Ferlan
> ---
> src/qemu/qemu_command.c | 2 +-
> src/qemu/qemu_command.h | 6 --
> 2 files changed, 1 insertion(+), 7 deletions(-)
ACK
Regards,
Daniel
--
|: http:
On Thu, Jun 16, 2016 at 06:42:23AM -0400, John Ferlan wrote:
> Add a new TLS X.509 certificate type - "chartcp" (a/k/a charTCP). This will
> handle the creation of a TLS certificate capability (and possibly repository)
> for properly configured character device TCP backends.
>
> Unlike the vnc and
On Thu, Jun 16, 2016 at 06:42:22AM -0400, John Ferlan wrote:
> Rather that specify perhaps multiple TLS X.509 certificate directories,
> let's create a "default" directory which can then be used if the service
> (e.g. for now vnc and spice) does not supply a default directory.
>
> Since the defaul
On Thu, Jun 16, 2016 at 10:46:43 +0200, Ján Tomko wrote:
> virsh-synopsis takes even longer than virsh-all which is
> already makred as expensive.
> ---
> tests/virsh-optparse | 2 ++
> tests/virsh-synopsis | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/tests/virsh-optparse b/tests/v
On 06/13/2016 10:34 AM, Martin Kletzander wrote:
> Similarly to commit d294f6b0dff7, if the name is long enough, the
> filename can be longer than filesystem's limit.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1334237
>
> Signed-off-by: Martin Kletzander
> ---
> src/qemu/qemu_d
On Wed, 2016-06-15 at 12:51 -0400, Laine Stump wrote:
> Until now, a Q35 domain (or arm/virt, or any other domain that has a
> pcie-root bus) would always have a pci-bridge added, so that there
> would be a hotpluggable standard PCI slot available to plug in any PCI
> devices that might be added. T
Patches 1 and 2 are tiny fixes and cleanups. 3 has the essence.
Nikolay Shirokovskiy (3):
vz: use state variable sdkdom in prlsdkApplyConfig
vz: remove redundant variable in prlsdkHandleVmAddedEvent
vz: make vz driver more responsive
src/vz/vz_driver.c | 183 +++
On Wed, 2016-06-15 at 12:51 -0400, Laine Stump wrote:
> Previously there was no way to have a Q35 domain that didn't have
> these two controllers. This patch skips their creation as long as
> there are some other kinds of pci controllers at index 1 and 2
> (e.g. some pcie-root-port controllers).
>
Hello guys!
I got into problem with installing IPv6 default gateway on centos7 guest
while running dhcpv6.
=== Scheme ===
Guest has two network interfaces.
*eth0* is connected to Host-Only network over virbr0. This network has
dhcpv6 set up.
[root@s143 ~]# virsh net-dumpxml Host-Only
H
Signed-off-by: Nikolay Shirokovskiy
---
src/vz/vz_sdk.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index 092954d..c9f89ab 100644
--- a/src/vz/vz_sdk.c
+++ b/src/vz/vz_sdk.c
@@ -1781,7 +1781,6 @@ prlsdkHandleVmAddedEvent(vzDriverPtr driver,
sdk domain handle is unique per connection so there is
no sense to query it again if we have it in vzDomObjPtr.
Side effect of prlsdkSdkDomainLookupByUUID is refreshing
domain config is of no use too as PrlVm_BeginEdit do it too.
Signed-off-by: Nikolay Shirokovskiy
---
src/vz/vz_sdk.c | 14 -
Current vz driver implementation is not usable when it comes to
long runnig operations. Migration or saving a domain blocks all
other operations even query ones which are expecteted to be available.
This patch address this problem.
All vz driver API calls fall into next 3 groups:
1. only query
On 06/16/2016 06:03 AM, Ján Tomko wrote:
> On Wed, Jun 15, 2016 at 06:45:59PM -0400, John Ferlan wrote:
>>
>>
>> On 06/15/2016 01:19 PM, Ján Tomko wrote:
>>> Regression introduced by commit 71b803a for [1] that prevents
>>> starting up
>>> a logical pool created with
>>> after it has been moved
On 06/16/2016 06:11 AM, Jim Fehlig wrote:
> When converting domXML to xen xl.cfg, backendtype should
> not be emitted if is not specified. Moreover,
> should be converted to backendtype
> qdisk, similar to handling of in libxlMakeDisk()
> in libxl_conf.c.
>
> Prior to this change, connectDomain
this patch is for help document
thanks very much
At 2016-06-16 17:39:12, "Daniel P. Berrange" wrote:
>On Mon, Jun 13, 2016 at 05:58:06PM +0800, longguang.yue wrote:
>> From 98a2e7784f14f1c69dbb93e0bfb6539987aa16d4 Mon Sep 17 00:00:00 2001
>> From: yuelongguang
>> Date: Mon, 13 Jun 2016 17:2
Rather than inline code secret lookup for rbd/iscsi, use the common function.
Signed-off-by: John Ferlan
---
src/Makefile.am | 1 +
src/storage/storage_backend_iscsi.c | 49 +
src/storage/storage_backend_rbd.c | 48 +++---
Add utility to format the virSecretLookupTypeDefPtr in XML
Signed-off-by: John Ferlan
---
src/libvirt_private.syms | 1 +
src/util/virsecret.c | 23 +++
src/util/virsecret.h | 3 +++
src/util/virstoragefile.c | 18 ++
4 files changed, 29 insertion
Rather than assume/pass the protocol to the qemuDomainSecretPlainSetup
and qemuDomainSecretAESSetup, determine and pass the secretUsageType
which is then used in the virSecretGetSecretString call
For the two callers that convert from virStorageNetProtocol, add
a new helper qemuDomainSecretProtocol
Extracted from the LUKS series (patches 4-9 and patch 14):
http://www.redhat.com/archives/libvir-list/2016-June/msg00804.html
with a couple of modifications as I working through the TLS code...
1. Instead of looking the LookupDef 'secdef', call it 'seclookupdef'
(it's just clearer that way
Move to virsecret.c and rename to virSecretParseSecret. Also convert to
usage xmlNodePtr and virXMLPropString rather than virXPathString.
Signed-off-by: John Ferlan
---
po/POTFILES.in| 1 +
src/libvirt_private.syms | 1 +
src/util/virsecret.c | 44
Move the enum into a new src/util/virsecret.h, rename it to be
virSecretLookupType. Add a src/util/virsecret.h in order to perform
a couple of simple operations on the secret XML and virSecretLookupTypeDef
for clearing and copying.
This includes quite a bit of collateral damage, but the goal is to
Rather than pass authdef, pass the 'authdef->username' and the
'&authdef->seclookupdef'
Note that a username may be NULL.
Signed-off-by: John Ferlan
---
src/qemu/qemu_domain.c | 39 +++
1 file changed, 23 insertions(+), 16 deletions(-)
diff --git a/src/qemu/
Add a new secret type known as "key" - it will handle adding the secret
objects that need a key (or passphrase) without a specific username.
Signed-off-by: John Ferlan
---
docs/aclpolkit.html.in | 4 +++
docs/formatsecret.html.in | 57 +++--
Soon at least one of them will need to grab something out of the
qemu config structure
Signed-off-by: John Ferlan
---
src/qemu/qemu_command.c | 56 ++---
1 file changed, 34 insertions(+), 22 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu
Rather that specify perhaps multiple TLS X.509 certificate directories,
let's create a "default" directory which can then be used if the service
(e.g. for now vnc and spice) does not supply a default directory.
Since the default for vnc and spice may have existed before without being
supplied, the
It's not used externally anywhere else
Signed-off-by: John Ferlan
---
src/qemu/qemu_command.c | 2 +-
src/qemu/qemu_command.h | 6 --
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index cbd40ea..4719881 100644
--- a/src/qemu/q
Add a new TLS X.509 certificate type - "chartcp" (a/k/a charTCP). This will
handle the creation of a TLS certificate capability (and possibly repository)
for properly configured character device TCP backends.
Unlike the vnc and spice there is no "listen" or "passwd" associated. The
credentials wil
If the incoming XML defined a path to a TLS X.509 certificate environment,
add the necessary 'tls-creds-x509' object to the VIR_DOMAIN_CHR_TYPE_TCP
character device.
Signed-off-by: John Ferlan
---
src/conf/domain_conf.h | 1 +
src/qemu/qemu_command.c | 2 +-
src/qemu/qemu_command.h
When building a chardev device string for tcp, add the necessary pieces to
access provide the TLS X.509 path to qemu. This includes generating the
'tls-creds-x509' object and then adding the 'tls-creds' parameter to the
VIR_DOMAIN_CHR_TYPE_TCP command line.
Finally add the tests for the qemu comm
v1: http://www.redhat.com/archives/libvir-list/2016-June/msg00824.html
Based on Dan's review from patch 4, alter the methodology to use the
libvirt qemu config file to add support for a 'default' and (at first)
a 'chartcp' (I could use chardev, but I was concerned that would imply
more options - u
Commit id '743db933' broke at least one syntax check rule regard open/close
braces and perhaps more with spacing. Just remove the braces
Signed-off-by: John Ferlan
---
Pushed as build breaker
src/util/virauthconfig.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/ut
On Wed, Jun 15, 2016 at 06:45:59PM -0400, John Ferlan wrote:
On 06/15/2016 01:19 PM, Ján Tomko wrote:
Regression introduced by commit 71b803a for [1] that prevents starting up
a logical pool created with
after it has been moved to a different physical volume.
Is there a bug for this? XML e
On Mon, Jun 13, 2016 at 05:58:06PM +0800, longguang.yue wrote:
> From 98a2e7784f14f1c69dbb93e0bfb6539987aa16d4 Mon Sep 17 00:00:00 2001
> From: yuelongguang
> Date: Mon, 13 Jun 2016 17:29:57 +0800
> Subject: [PATCH] add default mapping of credentials to machine
>
> ---
> src/util/virauthconfig.c
Do not generate random bignums and stop doing expensive
virsh tests by default.
Ján Tomko (2):
tests: mock gnutls_dh_params_generate2
tests: mark virsh-optparse and virsh-synopsis as expensive
tests/virnettlscontexttest.c | 2 +-
tests/virnettlssessiontest.c | 2 +-
tests/virrandommock.c
virsh-synopsis takes even longer than virsh-all which is
already makred as expensive.
---
tests/virsh-optparse | 2 ++
tests/virsh-synopsis | 2 ++
2 files changed, 4 insertions(+)
diff --git a/tests/virsh-optparse b/tests/virsh-optparse
index cbd6c30..cb0f3d4 100755
--- a/tests/virsh-optparse
++
This function generates some big random numbers.
Skip it in tests to save time.
---
tests/virnettlscontexttest.c | 2 +-
tests/virnettlssessiontest.c | 2 +-
tests/virrandommock.c| 12
3 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/tests/virnettlscontexttest
On Thu, Jun 16, 2016 at 09:14:12AM +0200, Peter Krempa wrote:
> On Wed, Jun 15, 2016 at 18:10:01 +0100, Daniel Berrange wrote:
> > On Mon, Jun 13, 2016 at 02:48:51PM +0200, Peter Krempa wrote:
>
> TL;DR: I mostly agree with your suggestions altough there's a slight
> problem with the suggested XML
Add storage event handling infrastructure to storage_event.[ch], following
the network_event.[ch] pattern.
---
src/Makefile.am | 5 +
src/conf/storage_event.c | 237 +++
src/conf/storage_event.h | 60
src/libvirt_private.syms |
---
examples/object-events/event-test.c | 73 +
1 file changed, 73 insertions(+)
diff --git a/examples/object-events/event-test.c
b/examples/object-events/event-test.c
index c1ff4a7..215e026 100644
--- a/examples/object-events/event-test.c
+++ b/examples/objec
Add virsh-pool support for storage pool lifecycle events
---
tools/virsh-pool.c | 184 +
1 file changed, 184 insertions(+)
diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c
index f9299e2..cd40749 100644
--- a/tools/virsh-pool.c
+++ b/tools/vi
Implement storage pool event callbacks for START, STOP, DEFINE, UNDEFINED
and REFRESHED in functions when a storage pool is created/started/stopped
etc. accordingly
---
src/conf/storage_conf.h | 4 ++
src/storage/storage_driver.c | 110 +++
2 files ch
Storage pool lifecycle event API entry points for registering and deregistering
storage pool events, as well as types of events associated with storage pools.
These entry points will be used for implementing asynchronous lifecycle events.
Storage pool API:
virConnectStoragePoolEventRegisterAny
vir
Also includes unittests for storage pool lifecycle events API
---
src/test/test_driver.c | 71 +++
tests/objecteventtest.c | 177
2 files changed, 248 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
inde
1 - 100 of 103 matches
Mail list logo
