On Tue, Oct 04, 2016 at 11:28:15AM +0200, Martin Kletzander wrote:
> On Tue, Oct 04, 2016 at 02:34:57PM +1100, Sam Bobroff wrote:
> >On Mon, Oct 03, 2016 at 04:27:25PM +0200, Martin Kletzander wrote:
> >>On Mon, Aug 01, 2016 at 02:01:22PM +1000, Sam Bobroff wrote:
> >>>Hi libvirt people,
> >>>
> >>
On 10/04/2016 11:02 AM, Ian Jackson wrote:
Currently, osstest wrongly thinks that ARM can do save/restore,
because `virsh help' does mention the save command (on all
architectures).
Additionally, check the virth capabilities xpath
/capabilities/host/migration_features
to try to see whether th
On 10/04/2016 11:02 AM, Ian Jackson wrote:
Do not grep the virsh capabilities output (!) Instead, parse the XML
using perl's XML modules and look for the specific feature flag using
an XPATH pattern.
AFAICT from looking at the XML, that's
But the original code
On 09/27/2016 11:21 AM, Michal Privoznik wrote:
> On 23.09.2016 14:56, John Ferlan wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1349898
>>
>> Do a little housekeeping and minor adjustments to existing code, then
>> add the various "-length" options for the code.
>>
>>
>> John Ferlan (12
Hi Ian,
On 04/10/2016 10:05, Ian Jackson wrote:
Ian Jackson writes ("[OSSTEST PATCH 1/2] libvirt: Check migration capabilities using
proper XML parser"):
Do not grep the virsh capabilities output (!) Instead, parse the XML
using perl's XML modules and look for the specific feature flag using
On Wed, Oct 05, 2016 at 01:26:31PM -0400, Laine Stump wrote:
> On 10/05/2016 11:50 AM, Richard W.M. Jones wrote:
> >(b) It would be nice to turn the whole thing off for people who don't
> >care about / need hotplugging.
>
> I had contemplated having an "availablePCIeSlots" (or something like
> tha
On 10/05/2016 11:50 AM, Richard W.M. Jones wrote:
I was asked to look at the impact on boot times of adding (empty) PCIe
root ports to the device model. The proposal from Laine is to add a
few of these to every guest to allow hotplugging.
Last time I looked into this I found that probing any (l
On 10/05/2016 12:25 PM, Martin Kletzander wrote:
On Wed, Oct 05, 2016 at 11:34:13AM -0400, Laine Stump wrote:
When I added support for the pcie-expander-bus controller in commit
bc07251f, I incorrectly thought that it only had a single slot
available. Actually it has 32 slots, just like the root
On Wed, Oct 05, 2016 at 11:34:13AM -0400, Laine Stump wrote:
When I added support for the pcie-expander-bus controller in commit
bc07251f, I incorrectly thought that it only had a single slot
available. Actually it has 32 slots, just like the root complex aka
pcie-root (the part that I *did* get
Hi,
FYI, I've written a PCP plugin (PMDA in PCP parlance) to support most
hypervisor / domain information and metrics available over the libvirt
Python API, it's up to date as of libvirt 2.3 (so it already supports
the recently added perf event metrics).
In case you haven't heard about PCP, here'
On 10/05/2016 04:29 AM, Marko Myllynen wrote:
> Hi,
>
> FWIW, FYI, I've contributed completions for the commands part of libvirt
> to zsh upstream, here's a quick screenshot:
>
> $ virsh
> zsh: do you wish to see all 222 possibilities (111 lines)? n
> $ virsh allocpages
> --add--all
I was asked to look at the impact on boot times of adding (empty) PCIe
root ports to the device model. The proposal from Laine is to add a
few of these to every guest to allow hotplugging.
Last time I looked into this I found that probing any (legacy) PCI
device is expensive because of the ineffi
On Wed, Oct 05, 2016 at 12:29:59PM +0300, Marko Myllynen wrote:
Hi,
FWIW, FYI, I've contributed completions for the commands part of libvirt
to zsh upstream, here's a quick screenshot:
$ virsh
zsh: do you wish to see all 222 possibilities (111 lines)? n
$ virsh allocpages
--add--all
On Wed, Oct 05, 2016 at 16:07:09 +0200, Martin Kletzander wrote:
> On Wed, Oct 05, 2016 at 09:26:43AM +0200, Jiri Denemark wrote:
> >@@ -2648,7 +2647,7 @@ vshReadlineParse(const char *text, int state)
> > static vshCommandParser parser, sanitizer;
> > vshCommandToken tk;
> > static cons
When I added support for the pcie-expander-bus controller in commit
bc07251f, I incorrectly thought that it only had a single slot
available. Actually it has 32 slots, just like the root complex aka
pcie-root (the part that I *did* get correct is that unlike pcie-root
a pcie-expander-bus doesn't al
On Wed, Oct 05, 2016 at 09:37:50 -0400, John Ferlan wrote:
> On 09/27/2016 12:39 PM, Peter Krempa wrote:
> > Add code that takes a string and matches it against the data passed as
> > arguments from qemu. This is a simpler version of
> > qemuMonitorTestAddItemParams.
> > ---
> > tests/qemumonitort
On Mon, Sep 12, 2016 at 17:34:39 +0300, Nikolay Shirokovskiy wrote:
> Hi, all.
>
> In case migration fails due to destination qemu exits unexpectedly user
> recevies the qemu log in the error message. Unfortunately log is truncated and
> the most interesting part is missed (below is the example
On Mon, Sep 12, 2016 at 17:34:42 +0300, Nikolay Shirokovskiy wrote:
This is a pretty big change but you did not write anything to describe
or justify it.
> ---
> src/logging/log_handler.c | 38 --
> src/logging/log_protocol.x | 5 +
> 2 files changed, 41
On Wed, Oct 05, 2016 at 09:39:06 -0400, John Ferlan wrote:
>
>
> On 09/27/2016 12:39 PM, Peter Krempa wrote:
> > Since introduction of chardev hotplug the code was wrong for the UDP
> > case and basically created a TCP socket instead. Use proper objects and
> > type for UDP.
> >
> > Resolves: ht
On Wed, Oct 05, 2016 at 16:52:08 +0300, Nikolay Shirokovskiy wrote:
> ---
> src/qemu/qemu_monitor_json.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
> index e1494df..6c2884d 100644
> --- a/src/qemu/qemu
On Wed, Oct 05, 2016 at 09:26:43AM +0200, Jiri Denemark wrote:
GCC complained that
vsh.c: In function 'vshReadlineOptionsGenerator':
vsh.c:2622:29: warning: unused variable 'opt' [-Wunused-variable]
const vshCmdOptDef *opt = &cmd->opts[list_index];
^
vsh.c: In
Hi,
FWIW, FYI, I've contributed completions for the commands part of libvirt
to zsh upstream, here's a quick screenshot:
$ virsh
zsh: do you wish to see all 222 possibilities (111 lines)? n
$ virsh allocpages
--add--all--cellno --pagecount --pagesize
$ virsh start
f23-test
On Wed, Oct 05, 2016 at 09:47:15 -0400, John Ferlan wrote:
>
>
> On 10/05/2016 03:48 AM, Peter Krempa wrote:
> > On Tue, Oct 04, 2016 at 11:28:55 -0400, John Ferlan wrote:
> >> Provide the Steal API for any code paths that will desire to grab the
> >> entire array and then free it afterwards rath
---
src/qemu/qemu_blockjob.c | 13 +++--
src/qemu/qemu_blockjob.h | 3 ++-
src/qemu/qemu_domain.h | 1 +
src/qemu/qemu_driver.c | 4 ++--
src/qemu/qemu_migration.c| 34 ++
src/qemu/qemu_monitor.c | 5 +++--
src/qemu/qemu_moni
---
src/qemu/qemu_monitor_json.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index e1494df..6c2884d 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu/qemu_monitor_json.c
@@ -841,10 +841,8 @@ qemuMonito
BLOCK_JOB_COMPLETED has error field set on error from day one (12bd451f)
thus there is no need to guess for error. Is it true that when
len == offset then can be no error?
---
src/qemu/qemu_monitor_json.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_monitor
On 10/05/2016 03:48 AM, Peter Krempa wrote:
> On Tue, Oct 04, 2016 at 11:28:55 -0400, John Ferlan wrote:
>> Provide the Steal API for any code paths that will desire to grab the
>> entire array and then free it afterwards rather than relying to freeing
>> the whole chain from the reply.
>>
>> Sig
So that you can see nice report on migration:
"error: operation failed: migration of disk sda failed: No space left on device"
Nikolay Shirokovskiy (3):
qemu: simplify switch case for blockjob events
qemu: use blockjob completed event's error field to detect errors
qemu: report block job er
On 09/27/2016 12:39 PM, Peter Krempa wrote:
> Since introduction of chardev hotplug the code was wrong for the UDP
> case and basically created a TCP socket instead. Use proper objects and
> type for UDP.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1377602
> ---
> src/qemu/qemu_mo
On 09/27/2016 12:39 PM, Peter Krempa wrote:
> The chardev attach test would do all the tests in one virTestRun
> instance. If one sub-test failed then the test would report failure
> improperly and the error would be hard to debug since the error pointer
> was overwritten.
> ---
> tests/qemumoni
On 09/27/2016 12:39 PM, Peter Krempa wrote:
> ---
> src/qemu/qemu_monitor_json.c | 39 +++
> 1 file changed, 15 insertions(+), 24 deletions(-)
>
ACK,
John
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-lis
Polite ping? :)
On 09/26/2016 01:16 PM, Corey S. McQuay wrote:
Currently Libvirt allows attempts to migrate read only disks. Qemu cannot
handle this as read only
disks cannot be written to on the destination system. The end result is a
cryptic error message
and a failed migration.
This patch
On 09/27/2016 12:39 PM, Peter Krempa wrote:
> Until now the test was rather useless since it didn't check the
> arguments formatted and didn't use properly configured chardev objects.
>
> Add the expected arguments and instrument the test to validate them.
> Modify some test cases to actually ad
On 09/27/2016 12:39 PM, Peter Krempa wrote:
> Add code that takes a string and matches it against the data passed as
> arguments from qemu. This is a simpler version of
> qemuMonitorTestAddItemParams.
> ---
> tests/qemumonitortestutils.c | 112
> +++
> te
On 09/27/2016 12:39 PM, Peter Krempa wrote:
> Use much simpler logic to determine parts of the code to print.
> ---
> src/conf/domain_conf.c | 42 --
> 1 file changed, 16 insertions(+), 26 deletions(-)
>
ACK
John
--
libvir-list mailing list
libvir-list
On Tue, 2016-10-04 at 11:50 -0400, Laine Stump wrote:
> > All these differences between the code you're removing and
> > the code that's supposed to replace it make me wonder whether
> > I'm missing something. Feel free to point out my mistake
> > right about... Now! :)
>
> Yeah, you're missing th
On 09/13/2016 05:48 PM, Eric Farman wrote:
On 09/13/2016 04:49 PM, John Ferlan wrote:
[...]
Thanks for the review. (Silent ACK on a lot of the above comments.)
I'll try to get these all in place for a v3 with a little runway before
the next freeze.
OK - hopefully I won't be neck deep
On Mon, Sep 26, 2016 at 08:18:30 -0400, John Ferlan wrote:
In subject: Static is not the same as stack allocated.
> Rather than use static/stack state context pointers, let's allocate and
same here.
> free the state context pointer. In doing so, we'll shrink the code a bit
> since many routine
On Wed, 2016-09-28 at 10:04 +0100, Daniel P. Berrange wrote:
> We do *not* apply
> a strict 80 character limit in libvirt.
Is that so? I was under the impression that we did, mostly
due to the fact that long lines are often pointed out
during review, but turns out that in fact the HACKING file
men
Hi, thanks all for review
Comments inside
Best regards
Jarek
> -Original Message-
> From: Daniel P. Berrange [mailto:berra...@redhat.com]
> Sent: Tuesday, October 04, 2016 5:15 PM
> To: Michal Privoznik
> Cc: Safka, JaroslavX ; libvir-list@redhat.com
> Subject: Re: [libvirt] [PATCH 1/2]
On Mon, Sep 26, 2016 at 08:18:29 -0400, John Ferlan wrote:
> Since none of the callers check the status, let's just alter it from
> a (global!) int to be a static void.
global?
>
> While we're at it - scrap the local runtime variable and just do the
> math in the VIR_DEBUG directly.
>
> Signed-
On Mon, Sep 26, 2016 at 08:18:31 -0400, John Ferlan wrote:
> No sense opening a connection only to fail because we don't support the
> type of build being attempted.
>
> Signed-off-by: John Ferlan
> ---
> src/storage/storage_backend_rbd.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletion
Hello Michal,
Well, in fact I think this should be vice versa. Docker is using LXCs
but not through libvirt. And as much as I wish they had chosen to have
libvirt backend, they hadn't. I mean, docker is a management application
so in the stack it sits above libvirt. But on the other hand, one coul
On Tue, Oct 04, 2016 at 11:28:58 -0400, John Ferlan wrote:
> This will fetch "this device" from the recently returned 'dev' and perform
It fetches the device alias actually. "this device" is just a code
nuance.
> common error checking for the paths that call it.
>
> Signed-off-by: John Ferlan
>
On Tue, Oct 04, 2016 at 11:28:57 -0400, John Ferlan wrote:
> This will grab the 'dev' from devices and do the common validation checks.
>
> Signed-off-by: John Ferlan
> ---
> src/qemu/qemu_monitor_json.c | 37 +
> 1 file changed, 21 insertions(+), 16 deletions
On Tue, Oct 04, 2016 at 11:28:56 -0400, John Ferlan wrote:
> Reduce some cut-n-paste code by creating common helper. Make use of the
> recently added virJSONValueObjectStealArray to grab the devices list as
> part of the common code (we we can Free the reply) and return devices for
> each of the ca
On Tue, Oct 04, 2016 at 11:28:55 -0400, John Ferlan wrote:
> Provide the Steal API for any code paths that will desire to grab the
> entire array and then free it afterwards rather than relying to freeing
> the whole chain from the reply.
>
> Signed-off-by: John Ferlan
> ---
> src/libvirt_privat
adding cc
On 26.09.2016 13:36, Nikolay Shirokovskiy wrote:
>
>
> On 26.09.2016 13:04, Peter Krempa wrote:
>> On Mon, Sep 26, 2016 at 12:15:42 +0300, Nikolay Shirokovskiy wrote:
>>> On 26.09.2016 12:01, Peter Krempa wrote:
>>
>> [...]
>>
>>> Sorry, I forget to write down the motivation.
>>>
>>> I
hey,
On Tue, Oct 04, 2016 at 04:30:14PM +0100, Daniel P. Berrange wrote:
> > +
> > +/**
> > + * gvir_config_domain_graphics_listen_address_get_inet_address:
> > + *
> > + * Returns the #GInetAddress associated with the
> > #GVirConfigDomainGraphicsListenAddress.
> > + *
> > + * Returns: (transfer
In d18c7d7124 we have tried to implement virNodeGetFreePages API
to test driver. And for a very limited definition of success we
have succeeded. But, we can do better. Firstly, we can teach our
internal representation of a NUMA cell that there are different
page sizes and that they create a pool (f
Now that our cells in test driver are huge pages aware, we can
implement virNodeAllocPages. Basically there's just one catch. If
users specify startCell == -1, they want the huge pages change to
be stretched over all the nodes. Therefore we just recalculate
the change they want to make to each node
Consider the following scenario:
virsh # freecell --all
0: 2048 KiB
1: 4096 KiB
Total: 6144 KiB
virsh # freecell 0
0: 2048 KiB
virsh # freecell 1
1: 4096 KiB
And now before this change:
virsh # freecell 2
After this change:
We have inclination to calling our loop variables i, j, k, not u.
Signed-off-by: Michal Privoznik
---
src/test/test_driver.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index a382d89..758327c 100644
BLURB
Michal Privoznik (4):
testOpenDefault: Rename loop variable
testNodeGetCellsFreeMemory: Fix off by one error
test driver: Store memory per NUMA node
test_driver: Implement virNodeAllocPages
src/test/test_driver.c | 198 -
1 file chang
GCC complained that
vsh.c: In function 'vshReadlineOptionsGenerator':
vsh.c:2622:29: warning: unused variable 'opt' [-Wunused-variable]
const vshCmdOptDef *opt = &cmd->opts[list_index];
^
vsh.c: In function 'vshReadlineParse':
vsh.c:2830:44: warning: 'opt' may
On Tue, Oct 04, 2016 at 18:25:32 +0200, Michal Privoznik wrote:
> On 04.10.2016 18:03, Peter Krempa wrote:
> > On Fri, Sep 30, 2016 at 15:28:08 +0200, Daniel Veillard wrote:
> >> On Fri, Sep 30, 2016 at 11:37:08AM +0200, Guido Günther wrote:
> >>> On Tue, Sep 27, 2016 at 10:14:36PM +0200, Daniel Ve
56 matches
Mail list logo