On Mon, Dec 19, 2016 at 15:10:01 +0100, Pavel Hrdina wrote:
> On Mon, Dec 19, 2016 at 02:16:38PM +0100, Jiri Denemark wrote:
> > On Fri, Dec 16, 2016 at 10:10:36 +0100, Pavel Hrdina wrote:
> > > Signed-off-by: Pavel Hrdina
...
> > This hunk doesn't seem to be correct. First,
---
src/qemu/qemu_migration.c | 40 ++--
src/qemu/qemu_monitor.c | 24
src/qemu/qemu_monitor.h | 4
3 files changed, 2 insertions(+), 66 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index
There is no disks statistics when migrating with VIR_MIGRATE_NON_SHARED_*
for qemu that supports nbd. The reason is that disks are copied via disk
mirroring
and not in the scope of migration job itself. Let's enhance
qemuMigrationFetchJobStatus
to take mirror jobs into account.
Now
Current migration stats will show something like [1] when in
the process of mirroring of non shared disks. This gives very
little info on the migration progress. Likewise completed stats miss
disks mirroring info.
This patch provides disks stats in the said phase like in [2] so
user can now
On 12/16/2016 10:26 PM, ashish mittal wrote:
> Hi John,
>
> Thanks for the review and your comments. Sorry about the delay in
> reply. Our qemu patch has been undergoing a lot of changes, and we
> were hoping to finalize some things before the next libvirt patch.
>
I've been following the
On Wed, 2016-12-14 at 20:26 +0200, Marcel Apfelbaum wrote:
> > > > > > Maybe I just don't quite get the relationship between Root
> > > > > > Complexes and Root Buses, but I guess my question is: what
> > > > > > is preventing us from simply doing whatever a
> > > > > > spapr-pci-host-bridge is
On Fri, Dec 16, 2016 at 05:24:54PM +0100, Peter Krempa wrote:
> s/MD5 checkout/MD5 hash/
> ---
> src/locking/sanlock.conf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
ACK
Pavel
signature.asc
Description: Digital signature
--
libvir-list mailing list
libvir-list@redhat.com
On Fri, Dec 16, 2016 at 05:24:53PM +0100, Peter Krempa wrote:
> The error would be overwritten otherwise producing a meaningless error
> message.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1302171
> ---
> src/qemu/qemu_driver.c | 6 ++
> 1 file changed, 6 insertions(+)
ACK
On Fri, Dec 16, 2016 at 10:10:48 +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> configure.ac | 35 +-
> m4/virt-pthread.m4 | 56
> ++
> 2 files changed, 57
Signed-off-by: Michal Privoznik
---
src/security/security_selinux.c | 193 +++-
1 file changed, 190 insertions(+), 3 deletions(-)
diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c
index fec19b98c..af226bff6
It doesn't make much sense to have two different prefix for
functions within the same driver.
Signed-off-by: Michal Privoznik
---
src/security/security_selinux.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git
With our new qemu namespace code in place, the relabelling of
devices is done not as good is it could: a child process is
spawned, it enters the mount namespace of the qemu process and
then runs desired API of the security driver.
Problem with this approach is that internal state transition of
the
The code at the very bottom of the DAC secdriver that calls
chown() should be fine with read-only data. If something needs to
be prepared it should have been done beforehand.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_driver.c| 28
Signed-off-by: Michal Privoznik
---
src/security/security_dac.c | 193
1 file changed, 193 insertions(+)
diff --git a/src/security/security_dac.c b/src/security/security_dac.c
index b6f75fe1d..0208c1751 100644
---
In eadaa97548 I've tried to solve the issue of setting seclabels
on private /dev/* entries. While my approach works, it has tiny
flaw - anything that happens in the namespace stays in the
namespace. I mean, if there's a internal state change occurring
on relabel operation (it should not, and it
So far if qemu is spawned under separate mount namespace in order
to relabel everything it needs an access to the security driver
is run in that namespace too. This has a very nasty down side -
it is being run in a separate process, so any internal state
transition is NOT reflected in the dameon.
On Fri, Dec 16, 2016 at 10:10:47 +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> configure.ac | 83 ++
> m4/virt-polkit.m4 | 107
> ++
> 2 files changed, 110
On Fri, Dec 16, 2016 at 10:10:46 +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> configure.ac | 17 +++--
> m4/virt-firewalld.m4 | 43 +++
> 2 files changed, 46 insertions(+), 14 deletions(-)
>
On Fri, Dec 16, 2016 at 10:10:45 +0100, Pavel Hrdina wrote:
> Rename DRIVER_MODULE_(LDFLAGS|LIBS|CFLAGS) to unify the naming.
>
> Signed-off-by: Pavel Hrdina
> ---
> configure.ac | 39 ---
> m4/virt-driver-modules.m4 | 58
>
On Fri, Dec 16, 2016 at 10:10:44 +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> configure.ac | 26 --
> m4/virt-dlopen.m4 | 45 +
> 2 files changed, 49 insertions(+), 22 deletions(-)
>
Surprisingly there was a virDomainPCIAddressReleaseAddr() function
already, but it was completely unused. Since we don't reserve entire
slots at once any more, there is no need to release entire slots
either, so we just replace the single call to
virDomainPCIAddressReleaseSlot() with a call to
This function is only called in two places, and the function itself is
just adding a single argument and calling
virDomainPCIAddressReserveNextAddr(), so we can remove it and instead
call virDomainPCIAddressReserveNextAddr() directly. (The main
motivation for doing this is to free up the name so
It is now only used in domain_addr.c.
---
src/conf/domain_addr.c | 2 +-
src/conf/domain_addr.h | 6 --
src/libvirt_private.syms | 1 -
3 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c
index b02d52c..bb51579 100644
---
This function doesn't actually reserve an entire slot any more, it
reserves a single PCI address, so this name is more appropriate.
---
src/bhyve/bhyve_device.c | 8 ++--
src/conf/domain_addr.c | 2 +-
src/conf/domain_addr.h | 2 +-
src/libvirt_private.syms | 2
With the advent of VIR_PCI_CONNECT_AGGREGATE_SLOT, the new name is
more appropriate, since the address contained may be another address
on the same slot as last time, not necessarily a new slot.
---
src/conf/domain_addr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
(rebase of the original patches to make review easier)
Some of the patches that enabled sharing PCI slots by multiple
pcie-root-ports made the idea of reserving an entire slot obsolete. To
reduce confusion and misunderstandings, this patch series gets rid of
the name "Slot" in all of the
All occurences of the former use fromConfig=true, and that's exactly
how virDomainPCIAddressReserveSlot() calls
virDomainPCIaddressReserveAddr(), so just use *Slot() so that *Addr()
can be made static to conf/domain_addr.c (both functions will be
renamed in upcoming patches).
---
Although setting virDomainPCIAddressReserveAddr()'s fromConfig=true is
correct when a PCI addres is coming from a domain's config, the *true*
purpose of the fromConfig argument is to lower restrictions on what
kind of device can plug into what kind of controller - if fromConfig
is true, then a
This function doesn't actually reserve an entire slot any more, it
reserves a single PCI address, so this name is more appropriate.
---
src/qemu/qemu_domain_address.c | 45 +-
1 file changed, 23 insertions(+), 22 deletions(-)
diff --git
This is in preparation for renaming virDomainPCIAddressReserveSlot()
to virDomainPCIAddressReserveAddr(), which is a better description of
what it does.
---
src/conf/domain_addr.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/conf/domain_addr.c
Since we don't actually reserve an entire slot at a time anymore, the
name of this function is just confusing, and it's almost identical in
operation to virDomainPCIAddressReserveNextAddr() anyway, so remove
the *Slot() function and replace calls to it with calls to *Addr(...,
-1).
---
fromConfig should be true if the caller want
virDomainPCIAddressValidate() to loosen restrictions on its
interpretation of the pciConnectFlags. In particular, either
PCI_DEVICE or PCIE_DEVICE will be counted as equivalent to both, and
HOTPLUG will be ignored. In a few cases where libvirt was
Set the VIR_PCI_CONNECT_AGGREGATE_SLOT flag for pcie-root-ports so
that they will be assigned to all the functions on a slot.
Some qemu test case outputs had to be adjusted due to the
pcie-root-ports now being put on multiple functions.
---
src/conf/domain_addr.c | 2
virDomainPCIAddressGetNextSlot() starts searching from the last
allocated address and goes to the end of all the buses, then goes back
to the first bus and searchs from there up to the starting point (in
case any address has been freed since the last time an address was
allocated. The loops for
When keeping track of which functions of which slots are allocated, we
will need to have more information than just the current bitmap with a
bit for each function that is currently stored for each slot in a
virDomainPCIAddressBus. To prepare for adding more per-slot info, this
patch changes "int
There is a very slight time advantage to beginning the search for the
next unused PCI address at the slot *after* the previous find (which
is now used), but if we do that, we will miss allocating the other
functions of the same slot (when we implement a
VIR_PCI_CONNECT_AGGREGATE_SLOT flag to
If a PCI device has VIR_PCI_CONNECT_AGGREGATE_SLOT set in its
pciConnectFlags, then during address assignment we allow multiple
instances of this type of device to be auto-assigned to multiple
functions on the same device. A slot is used for aggregating multiple
devices only if the first device
setting reserveEntireSlot really accomplishes nothing - instead of
going to the trouble of computing the value for reserveEntireSlot and
then possibly setting *all* functions of the slot as in-use, we can
just set the in-use bit only for the specific function being used by a
device. Later we will
If the multifunction attribute isn't set in the config for the device
at function 0 of a slot used for multifunction, it would previously
have been an error. This patch will instead automatically correct the
omission (but only if it hasn't been set at all - if someone
explicitly has
Another rebase of the series with no other changes
Laine Stump (8):
conf: use struct instead of int for each slot in
virDomainPCIAddressBus
conf: eliminate concept of "reserveEntireSlot"
conf: eliminate repetitive code in virDomainPCIAddressGetNextSlot()
conf: start search for next
This function iterates through all the devices in a domain to
determine if the address it has been given is part of a "multifunction
device" (i.e. multiple devices connected to different functions of the
same slot).
This implementation may seem a bit inefficient because it has to
iterate through
On Fri, Dec 16, 2016 at 10:10:43 +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> m4/virt-libxml.m4 | 16 +++-
> 1 file changed, 3 insertions(+), 13 deletions(-)
ACK
Jirka
--
libvir-list mailing list
libvir-list@redhat.com
On Fri, Dec 16, 2016 at 10:10:42 +0100, Pavel Hrdina wrote:
> Pkg-config file libxml-2.0.pc was introduced in libxml2-2.2.4 and we
> require at least 2.6.0 so the crazy xml2-config check can be dropped.
>
> Signed-off-by: Pavel Hrdina
> ---
> m4/virt-libxml.m4 | 20
On Fri, Dec 16, 2016 at 10:10:41 +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> configure.ac | 55 +++
> m4/virt-libxml.m4 | 78
> +++
> 2 files changed, 81
On Fri, Dec 16, 2016 at 10:10:40 +0100, Pavel Hrdina wrote:
> This allows to use two or more LIBVIRT_CHECK_(LIB|LIB_ALT|PKG) macros
> for one library. For example, when we check for existence of
> pgk-config file of some library and we know that not all versions of
> that library that libvirt
On Fri, Dec 16, 2016 at 10:10:39 +0100, Pavel Hrdina wrote:
> Usage of AC_REQUIRE will mess with order how LIBVIRT_CHECK_* macros
> are composed into configure.ac. This ensures that the output of
> configure --help is properly ordered and grouped into sections.
>
> Signed-off-by: Pavel Hrdina
On Mon, Dec 19, 2016 at 02:16:38PM +0100, Jiri Denemark wrote:
> On Fri, Dec 16, 2016 at 10:10:36 +0100, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina
> > ---
> > configure.ac | 381
> > ++-
> >
On Fri, Dec 16, 2016 at 10:10:38 +0100, Pavel Hrdina wrote:
> Following patch will update LIBVIRT_CHECK_(LIB|LIB_ALT|PKG) macros in
> a way that you will be able to call a another macro as a fallback if
> the first one fails. To allow that, we need to move the
> LIBVIRT_ARG_WITH out of those
On Sun, 2016-12-18 at 20:37 -0500, Laine Stump wrote:
> On 12/16/2016 11:58 AM, Martin Wilck wrote:
> > "Static" DHCP networks are those where no dynamic DHCP range is
> > defined, only a list of host entries is used to serve permanent
> > IP addresses. On such networks, we don't want dnsmasq to
Ha intrigeri beat me by 3 minutes with feedback :-)
Tested it as well over lunch time, working for me too now:
That said:
Acked-by Christian Ehrhardt
On Mon, Dec 19, 2016 at 2:35 PM, intrigeri
wrote:
> Hi,
>
> Guido Günther:
> >
Hi,
Guido Günther:
> to cure
> + virsh lxc-enter-namespace --noseclabel
> libvirt: error : Expected at least one file descriptor
> error: internal error: Child process (2714) unexpected exit status 125
> caused by
> apparmor="DENIED" operation="open" info="Failed name lookup -
On Fri, Dec 16, 2016 at 10:10:37 +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> configure.ac| 84
> ++---
> m4/virt-compile-warnings.m4 | 20 +--
> 2 files changed, 44 insertions(+), 60
On Fri, Dec 16, 2016 at 10:10:36 +0100, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> configure.ac | 381
> ++-
> m4/virt-apparmor.m4 | 6 +-
> m4/virt-driver-bhyve.m4 | 5 +-
>
On Fri, Dec 16, 2016 at 10:10:35 +0100, Pavel Hrdina wrote:
> This macro helps to create unified output of "configure --help".
>
> Signed-off-by: Pavel Hrdina
> ---
> m4/virt-lib.m4 | 38 ++
> 1 file changed, 38 insertions(+)
Most of the
On Fri, Dec 16, 2016 at 10:10:34 +0100, Pavel Hrdina wrote:
> Those macros helps to create unified output of "configure --help".
"These macros help create"...
>
> Signed-off-by: Pavel Hrdina
> ---
> m4/virt-lib.m4 | 86
>
On Mon, Dec 19, 2016 at 10:30:54 +0100, Pavel Hrdina wrote:
> On Fri, Dec 16, 2016 at 09:23:27PM +0100, Jiri Denemark wrote:
> > On Fri, Dec 16, 2016 at 10:10:33 +0100, Pavel Hrdina wrote:
> > > The LIBVIRT_RESULT does a nice formatting of the output and ensures
> > > that the format is unified.
>
On Tue, 2016-12-13 at 17:08 +, Daniel P. Berrange wrote:
> The github.com/rgbkrk/libvirt-go bindings were the most complete
> bindings historically, but their API coverage stops at 1.2.4,
> with exception of a couple of newer APIs.
>
> The new bindings at
Follow up of commit 340bb6b7 to add unit tests for the QED format
support. Also add missing QED case in xenFormatXLDisk()
---
v2:
* Separated the QED test files into another set ti make this
test conditionnal
* Removed useless #ifdef
src/xenconfig/xen_xl.c | 3 +++
On Mon, 2016-12-19 at 10:40 +0100, Peter Krempa wrote:
> On Mon, Dec 19, 2016 at 10:28:55 +0100, Cédric Bosdonnat wrote:
> > Follow up of commit 340bb6b7 to add unit tests for the QED format
> > support. Also add missing QED case in xenFormatXLDisk()
> > ---
> > src/xenconfig/xen_xl.c
On Mon, Dec 19, 2016 at 10:27:05 +0100, Pavel Hrdina wrote:
> On Fri, Dec 16, 2016 at 09:14:56PM +0100, Jiri Denemark wrote:
> > On Fri, Dec 16, 2016 at 21:11:57 +0100, Jiri Denemark wrote:
> > > On Fri, Dec 16, 2016 at 10:10:32 +0100, Pavel Hrdina wrote:
> > > > All checks that prints result at
On Wed, Dec 14, 2016 at 09:23:43 +, Daniel P. Berrange wrote:
> In the website reorg we accidentally lost all links to the nice
> reformatted news.html file. Add a link on the front page, and
> also extend the download page table so that it includes links
> to API docs and news files for each
On Wed, Dec 14, 2016 at 11:00:27 +, Daniel P. Berrange wrote:
> Previously the way Fedora installed /usr/bin/nosetests allowed it
> to be invoked with either python 2 or 3. Since Fedora 25 though,
> it contains a module name that only exists on python 2. So we need
> to be more intelligent and
On Mon, Dec 19, 2016 at 10:28:55 +0100, Cédric Bosdonnat wrote:
> Follow up of commit 340bb6b7 to add unit tests for the QED format
> support. Also add missing QED case in xenFormatXLDisk()
> ---
> src/xenconfig/xen_xl.c | 5 +
>
On Fri, Dec 16, 2016 at 09:23:27PM +0100, Jiri Denemark wrote:
> On Fri, Dec 16, 2016 at 10:10:33 +0100, Pavel Hrdina wrote:
> > The LIBVIRT_RESULT does a nice formatting of the output and ensures
> > that the format is unified.
> >
> > Signed-off-by: Pavel Hrdina
> > ---
> >
Follow up of commit 340bb6b7 to add unit tests for the QED format
support. Also add missing QED case in xenFormatXLDisk()
---
src/xenconfig/xen_xl.c | 5 +
tests/xlconfigdata/test-disk-positional-parms-full.cfg | 2 +-
On Fri, Dec 16, 2016 at 09:14:56PM +0100, Jiri Denemark wrote:
> On Fri, Dec 16, 2016 at 21:11:57 +0100, Jiri Denemark wrote:
> > On Fri, Dec 16, 2016 at 10:10:32 +0100, Pavel Hrdina wrote:
> > > All checks that prints result at the end of configure uses
> > > LIBVIRT_RESULT_${CHECK_NAME}. Create
On Sat, Dec 17, 2016 at 03:54:29PM +0100, intrigeri wrote:
> Hi,
>
> Daniel P. Berrange:
> > On Mon, Dec 12, 2016 at 04:04:34PM +0100, Martin Kletzander wrote:
> >> Didn't we have a policy of using real names in commit messages? I
> >> remember someone advocating that (Eric?), so I did that as
On Fri, Dec 16, 2016 at 19:07:42 -0500, Laine Stump wrote:
> On 12/16/2016 01:09 PM, Jiri Denemark wrote:
> > Similarly to localOnly DNS domain, localPtr attribute can be used to
> > tell the DNS server not to forward reverse lookups for unknown IPs which
> > belong to the virtual network.
> >
>
On Fri, Dec 16, 2016 at 23:12:11 +0530, Nitesh Konkar wrote:
> Currently 'virsh perf domainName --enable a,b' command
> fails to enable/disable perf event b if perf event a has
> failed to get enabled/disabled. This patch fixes this
> issue.
>
> Signed-off-by: Nitesh Konkar
69 matches
Mail list logo