[libvirt] Question about hypervisor that are not tristate

Happy new year! Nearly a year ago I reported an issue with the hypervisor feature on Xen [1] and am now seeing a similar issue with the feature. Setting the default value of pae changed between xend and libxl. When not specified, xend would enable pae for HVM domains. Clients such as xm and

Re: [libvirt] [PATCH v2 0/4] Allow creation of vHBA by parent_wwnn/wwpn or fabric_name

On 01/06/2017 08:56 AM, Ján Tomko wrote: > On Wed, Jan 04, 2017 at 05:48:34PM -0500, John Ferlan wrote: >> v1: >> http://www.redhat.com/archives/libvir-list/2016-November/msg00866.html >> >> Based on ACKs some of the v1 changes were pushed to make this series >> appear shorter. >> >> Changes

Re: [libvirt] [PATCH 0/2] Attempt, and fail, to fix build with Clang 3.9 / Linux

On 01/02/2017 12:15 PM, Andrea Bolognani wrote: > The last one I was unable to work around in any sensible > manner: when linking, clang fails with > > ../gnulib/lib/.libs/libgnu.a(mgetgroups.o): > In function `realloc_groupbuf': > .../libvirt/gnulib/lib/mgetgroups.c:45: > undefined

[libvirt] [PATCH] libxl: implement virDomainGetMaxVcpus

The libxl driver already supports getting maximum vcpu count via libxlDomainGetVcpusFlags, allowing to trivially implement virDomainGetMaxVcpus. Signed-off-by: Jim Fehlig --- docs/news.html.in| 2 ++ src/libxl/libxl_driver.c | 8 2 files changed, 10

Re: [libvirt] Proposal PCI/PCIe device placement on PAPR guests

[Added Laine to CC, fixed qemu-devel address] On Thu, 2017-01-05 at 16:46 +1100, David Gibson wrote: [...] >   * To allow for hotplugged devices, libvirt should also add a number > of additional, empty vPHBs (the PAPR spec allows for hotplug of > PHBs, but this is not yet implemented in

[libvirt] [PATCH] bhyve: fix interface type handling for argv2xml

When generating a domain XML from native command (i.e. via the connectDomainXMLFromNative call), we should use interface type 'bridge' rather than 'ethernet' because we only support bridges at this point. As we don't have bridge name explicitly specified on the command line, just use 'virbr0' as

Re: [libvirt] [PATCH v3 6/8] qemu: use virDomainPCIAddressIsMulti() to determine multifunction setting

On Mon, Dec 19, 2016 at 10:23:16AM -0500, Laine Stump wrote: > If the multifunction attribute isn't set in the config for the device > at function 0 of a slot used for multifunction, it would previously > have been an error. This patch will instead automatically correct the > omission (but only if

Re: [libvirt] [PATCH v2] libxl: define a per-domain logger.

On 01/06/2017 08:25 AM, Daniel P. Berrange wrote: On Fri, Jan 06, 2017 at 08:15:58AM -0700, Jim Fehlig wrote: On 01/06/2017 01:04 AM, Cedric Bosdonnat wrote: On Thu, 2017-01-05 at 15:45 -0700, Jim Fehlig wrote: Cédric Bosdonnat wrote: libxl doesn't provide a way to write one log for each

[libvirt] [PATCH v2 0/3] virsh: pool-list: introduce option --name and --uuid

virsh # pool-list --name default root virsh # pool-list --uuid 76bd3b4d-2d23-4741-b6de-7377fa4320a1 f97964af-a3df-44ff-8664-886729035c09 virsh # pool-list --uuid --name 76bd3b4d-2d23-4741-b6de-7377fa4320a1 default f97964af-a3df-44ff-8664-886729035c09 root v2: do something like 'virsh list`

[libvirt] [PATCH v2 3/3] virsh: pool-list: allow both --uuid and --name in one cmd

From: Chen Hanxiao This patch will allow --uuid and --name in one cmd. The pool's UUID and name will be printed side by side. Signed-off-by: Chen Hanxiao --- tools/virsh-pool.c | 8 +++- tools/virsh.pod| 5 - 2 files changed, 11

[libvirt] [PATCH v2 2/3] virsh: pool-list: introduce --name for printing pool's name only

From: Chen Hanxiao This patch will introduce option --name. If specified, only name of pools will be printed out. Signed-off-by: Chen Hanxiao --- tools/virsh-pool.c | 22 -- tools/virsh.pod| 4 +++- 2 files changed, 23

[libvirt] [PATCH v2 1/3] virsh: pool-list: introduce --uuid for printing pool's UUID only

From: Chen Hanxiao This patch will introduce option --uuid. If specified, only UUID of pools will be printed out. Signed-off-by: Chen Hanxiao --- tools/virsh-pool.c | 20 tools/virsh.pod| 4 ++-- 2 files changed, 22

Re: [libvirt] [PATCH v2] libxl: define a per-domain logger.

On Fri, Jan 06, 2017 at 08:15:58AM -0700, Jim Fehlig wrote: > On 01/06/2017 01:04 AM, Cedric Bosdonnat wrote: > > On Thu, 2017-01-05 at 15:45 -0700, Jim Fehlig wrote: > > > Cédric Bosdonnat wrote: > > > > libxl doesn't provide a way to write one log for each domain. Thus > > > > we need to demux

Re: [libvirt] [PATCH v3 8/8] conf: aggregate multiple pcie-root-ports onto a single slot

On Fri, 2017-01-06 at 09:53 -0500, Laine Stump wrote: > > I noticed most of the pcie-root-ports get a new value for the > > port attribute after the change, while the chassis attribute > > remains always the same AFAICT. >  > That's because the chassis attribute is just set to the index of the  >

Re: [libvirt] [PATCH 9/9] secret: add support for value change events

On Fri, Jan 06, 2017 at 04:02:45PM +0100, Michal Privoznik wrote: > On 01/05/2017 02:59 PM, Daniel P. Berrange wrote: > > Emit an event whenever a secret value changes > > > > Signed-off-by: Daniel P. Berrange > > --- > > daemon/remote.c | 29

Re: [libvirt] [PATCH v3 6/8] qemu: use virDomainPCIAddressIsMulti() to determine multifunction setting

On 12/20/2016 10:19 AM, Andrea Bolognani wrote: On Mon, 2016-12-19 at 10:23 -0500, Laine Stump wrote: If the multifunction attribute isn't set in the config for the device at function 0 of a slot used for multifunction, it would previously have been an error. This patch will instead

Re: [libvirt] [PATCH 1/9] Add domain event for metadata changes

On Fri, Jan 06, 2017 at 04:02:44PM +0100, Michal Privoznik wrote: > On 01/05/2017 02:59 PM, Daniel P. Berrange wrote: > > When changing the metadata via virDomainSetMetadata, we now > > emit an event to notify the app of changes. This is useful > > when co-ordinating different applications

[libvirt] [PATCH] Fix the incorrect memory freeing which will result in crash

The number of elements in new_params is equal to the length of info, instead of nparams, so it's wrong to free new_params using nparams. Signed-off-by: Wu Zongyong --- libvirt-override.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [libvirt] [PATCH v2] libxl: define a per-domain logger.

On 01/06/2017 01:04 AM, Cedric Bosdonnat wrote: On Thu, 2017-01-05 at 15:45 -0700, Jim Fehlig wrote: Cédric Bosdonnat wrote: libxl doesn't provide a way to write one log for each domain. Thus we need to demux the messages. If our logger doesn't know to which domain to attribute a message, then

Re: [libvirt] [PATCH 9/9] secret: add support for value change events

On 01/05/2017 02:59 PM, Daniel P. Berrange wrote: > Emit an event whenever a secret value changes > > Signed-off-by: Daniel P. Berrange > --- > daemon/remote.c | 29 > include/libvirt/libvirt-secret.h | 1 + > src/conf/secret_event.c

Re: [libvirt] [PATCH 1/9] Add domain event for metadata changes

On 01/05/2017 02:59 PM, Daniel P. Berrange wrote: > When changing the metadata via virDomainSetMetadata, we now > emit an event to notify the app of changes. This is useful > when co-ordinating different applications read/write of > custom metadata. > > Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH 0/9] More event handling support

On 01/05/2017 02:59 PM, Daniel P. Berrange wrote: > This series adds suppoort for more events > > - Event when in a domain changes > - Event when virSecret are created/deleted > - Event when virSecret value is changed > > The latter two of course required wiring up the secret object > for

Re: [libvirt] [PATCH go-xml] Added Storage Pool and Storage Volume XML schemes.

On Fri, Jan 06, 2017 at 03:09:59PM +0100, Alexey Slaykovsky wrote: > Signed-off-by: Alexey Slaykovsky > --- > domain.go | 9 +- > domain_test.go | 8 +- > memory.go | 31 + > storage.go | 159 ++ > storage_test.go | 413 >

Re: [libvirt] [PATCH v3 8/8] conf: aggregate multiple pcie-root-ports onto a single slot

On 12/20/2016 12:50 PM, Andrea Bolognani wrote: On Mon, 2016-12-19 at 10:23 -0500, Laine Stump wrote: Set the VIR_PCI_CONNECT_AGGREGATE_SLOT flag for pcie-root-ports so that they will be assigned to all the functions on a slot. Some qemu test case outputs had to be adjusted due to the

[libvirt] [PATCH go-xml] Added Storage Pool and Storage Volume XML schemes.

Signed-off-by: Alexey Slaykovsky --- domain.go | 9 +- domain_test.go | 8 +- memory.go | 31 + storage.go | 159 ++ storage_test.go | 413 5 files changed, 609

Re: [libvirt] [PATCH v2 1/4] nodedev: Add the ability to create vHBA by parent wwnn/wwpn or fabric_wwn

On Wed, Jan 04, 2017 at 05:48:35PM -0500, John Ferlan wrote: @@ -31,6 +31,28 @@ + + + + + + + + + + + + + + + + + + + + + + Could this be

Re: [libvirt] [PATCH v2 0/4] Allow creation of vHBA by parent_wwnn/wwpn or fabric_name

On Wed, Jan 04, 2017 at 05:48:34PM -0500, John Ferlan wrote: v1: http://www.redhat.com/archives/libvir-list/2016-November/msg00866.html Based on ACKs some of the v1 changes were pushed to make this series appear shorter. Changes since v1 - Patch 1 (formerly patch 4) Rather than separate

[libvirt] [PATCH 2/2] docs: add news entry

Signed-off-by: Nitesh Konkar --- docs/news.html.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/news.html.in b/docs/news.html.in index e544cfa..481ae39 100644 --- a/docs/news.html.in +++ b/docs/news.html.in @@ -46,8 +46,9 @@

[libvirt] [PATCH 1/2] perf: add cache_l1d perf event support

This patch adds support and documentation for a generalized hardware cache event called cache_l1d perf event. Signed-off-by: Nitesh Konkar --- docs/formatdomain.html.in | 7 +++ docs/schemas/domaincommon.rng | 1 +

Re: [libvirt] Proposal PCI/PCIe device placement on PAPR guests

Resending because of bad qemu-devel address... On Thu, 5 Jan 2017 16:46:18 +1100 David Gibson wrote: > There was a discussion back in November on the qemu list which spilled > onto the libvirt list about how to add support for PCIe devices to > POWER VMs,

Re: [libvirt] Proposal PCI/PCIe device placement on PAPR guests

On Thu, 5 Jan 2017 16:46:18 +1100 David Gibson wrote: > There was a discussion back in November on the qemu list which spilled > onto the libvirt list about how to add support for PCIe devices to > POWER VMs, specifically 'pseries' machine type PAPR guests. > >

Re: [libvirt] [PATCH 6/9] qemu: qmp query-cpu-model-expansion command

On Sun, Dec 18, 2016 at 14:22:26 -0500, Jason J. Herne wrote: > From: "Collin L. Walling" > > query-cpu-model-expansion is used to get a list of features for a given cpu > model name or to get the model and features of the host hardware/environment > as seen by

Re: [libvirt] [PATCH 3/9] test-data: Qemu caps replies and xml for s390x qemu 2.7 and 2.8

On Sun, Dec 18, 2016 at 14:22:23 -0500, Jason J. Herne wrote: > From: "Collin L. Walling" > > Expected Qemu replies for versions 2.7 and 2.8 from the s390x > Qemu binary. > > Signed-off-by: Collin L. Walling > Signed-off-by: Jason J.

Re: [libvirt] [PATCH 8/9] tests: qemuxml2argv s390x cpu model

On Sun, Dec 18, 2016 at 14:22:28 -0500, Jason J. Herne wrote: > Test cases for qemu s390x cpu model argument generation. > > Signed-off-by: Jason J. Herne > --- > .../qemuxml2argv-cpu-s390-zEC12.args| 19 +++ >

Re: [libvirt] [PATCH 0/9] Qemu: s390: Cpu Model Support

On Sun, Dec 18, 2016 at 14:22:20 -0500, Jason J. Herne wrote: > This patch set enables cpu model support for s390. The user can now set exact > cpu models, query supported models via virsh domcapabilities, and use > host-model > and host-passthrough modes. The end result is that migration is

Re: [libvirt] [PATCH 1/9] s390: Cpu driver support for update and compare

On Sun, Dec 18, 2016 at 14:22:21 -0500, Jason J. Herne wrote: > Implement compare for s390. Required to test the guest against the host for > guest cpu model runnability checking. We always return IDENTICAL to bypass > Libvirt's checking. s390 will rely on Qemu to perform the runnability >

Re: [libvirt] [PATCH 7/9] qemu-caps: Get host model directly from Qemu when available

On Sun, Dec 18, 2016 at 14:22:27 -0500, Jason J. Herne wrote: > When qmp query-cpu-model-expansion is available probe Qemu for its view of the > host model. In kvm environments this can provide a more complete view of the > host model because features supported by Qemu and Kvm can be considered. >

Re: [libvirt] [PATCH 9/9] qemu: command: Support new cpu feature argument syntax

On Sun, Dec 18, 2016 at 14:22:29 -0500, Jason J. Herne wrote: > From: "Collin L. Walling" > > Qemu has abandoned the +/-feature syntax in favor of key=value. Some > architectures (s390) do not support +/-feature. So we update libvirt to handle > both formats. > > If

Re: [libvirt] [RFC] phi support in libvirt

(btw, if possible please try to avoid sending HTML email, or HTML+text email to the list - plaintext oinly email is preferred) On Mon, Dec 26, 2016 at 07:57:42PM +0800, Feng, Shaohe wrote: > for the NUMA format, > we still uses "memory" to describe the mcdram. > But we remove the cpus elements. >

Re: [libvirt] [PATCH 4/9] tests: domain capabilities: qemu 2.7 and 2.8 on s390x

On Sun, Dec 18, 2016 at 14:22:24 -0500, Jason J. Herne wrote: > From: "Collin L. Walling" > > Tests domain capabilities on s390x using the Qemu 2.8 capabilities data. > > Signed-off-by: Collin L. Walling > Signed-off-by: Jason J. Herne

Re: [libvirt] [PATCH 5/9] tests: qemu capabilites: qemu 2.7 and 2.8 on s390x

On Sun, Dec 18, 2016 at 14:22:25 -0500, Jason J. Herne wrote: > From: "Collin L. Walling" > > Tests Qemu capabilities on s390x before and after the availability of > the query-cpu-model-expansion QMP command. > > Signed-off-by: Collin L. Walling

Re: [libvirt] [PATCH v2 2/3] NEWS: Reformat at generation time

On Thu, 2017-01-05 at 16:45 +0100, Andrea Bolognani wrote: > > This avoids the need to rely on magic markers being the in > > intermediate text file, which could get mis-interpreted > > depending on what people write in the release notes. >  > The only case where that would happen would be if

Re: [libvirt] TSC frequency configuration & invtsc migration (was Re: [PATCH 4/4] kvm: Allow migration with invtsc)

On Thu, Jan 05, 2017 at 10:19:50AM -0200, Eduardo Habkost wrote: > On Thu, Jan 05, 2017 at 08:48:32AM -0200, Marcelo Tosatti wrote: > > On Wed, Jan 04, 2017 at 11:36:31PM -0200, Eduardo Habkost wrote: > > > On Wed, Jan 04, 2017 at 08:26:27PM -0200, Marcelo Tosatti wrote: > > > > On Wed, Jan 04,

[libvirt] [PATCH 2/4] qemuDomainGetPreservedMounts: Do not special case /dev

The c1140eb9e got me thinking. We don't want to special case /dev in qemuDomainGetPreservedMounts(), but in all other places in the code we special case it anyway. I mean, /var/run/libvirt/$domain.dev path is constructed separately just so that it is not constructed here. It makes only a little

[libvirt] [PATCH 4/4] qemu: Drop qemuDomainDeleteNamespace

After previous commits, this function is no longer needed. Signed-off-by: Michal Privoznik --- src/qemu/qemu_domain.c | 33 - src/qemu/qemu_domain.h | 3 --- src/qemu/qemu_process.c | 2 -- 3 files changed, 38 deletions(-) diff --git

[libvirt] [PATCH 3/4] qemuDomainCreateNamespace: move mkdir to qemuDomainBuildNamespace

Again, there is no need to create /var/lib/libvirt/$domain.* directories in CreateNamespace(). It is sufficient to create them as soon as we need them which is in BuildNamespace. This way we don't leave them around for the whole lifetime of domain. Signed-off-by: Michal Privoznik

[libvirt] [PATCH 0/4] qemu: Don't leave temp mount dirs around

After yesterday's patches [1] and fixing BZ [2] with them, the comment 4 got me thinking: why leave /var/run/libvirt/$domain.pts and similar temporary directories around? We need them just for a very short time. After that we might as well remove them. 1:

[libvirt] [PATCH 1/4] qemuDomainCreateNamespace: s/unlink/rmdir/

If something goes wrong in this function we try a rollback. That is unlink all the directories we created earlier. For some weird reason unlink() was called instead of rmdir(). Signed-off-by: Michal Privoznik --- src/qemu/qemu_domain.c | 4 ++-- 1 file changed, 2

Re: [libvirt] [PATCH v2] libxl: define a per-domain logger.

On Thu, 2017-01-05 at 15:45 -0700, Jim Fehlig wrote: > Cédric Bosdonnat wrote: > > libxl doesn't provide a way to write one log for each domain. Thus > > we need to demux the messages. If our logger doesn't know to which > > domain to attribute a message, then it will write it to the default > >