[libvirt] [GSOC] project libvirt fuzzing

Dear all, This is my first post in the list. I am currently a graduate student studying computer science, particularly interested in visualization technologies and I have been using QEMU for a variety of projects for a while. Two of the courses that I am taking this semester really attracted me

[libvirt] [PATCH] qemu: Drop virQEMUCapsFreeStringList

The implementation matches virStringListFreeCount. The only difference between the two functions is the ordering of their parameters. Signed-off-by: Jiri Denemark --- src/qemu/qemu_capabilities.c | 31 +-- 1 file changed, 9 insertions(+), 22

Re: [libvirt] [PATCH v2] Document preferred naming conventions

On 03/03/2017 02:16 PM, Daniel P. Berrange wrote: On Fri, Mar 03, 2017 at 07:57:24PM +0100, Jiri Denemark wrote: Hmm, so what do we do if there is an object, an action, and a subject? Good question :-) Typically accessors which are designed to return some specific part of the object. For

Re: [libvirt] [PATCH v2] Document preferred naming conventions

On Fri, Mar 03, 2017 at 19:16:58 +, Daniel P. Berrange wrote: > On Fri, Mar 03, 2017 at 07:57:24PM +0100, Jiri Denemark wrote: > > On Fri, Mar 03, 2017 at 17:47:23 +, Daniel P. Berrange wrote: > > > This documents the preferred conventions for naming files, > > > structs, enums, typedefs

Re: [libvirt] [Qemu-devel] [PATCH RESEND] qdev: Make "hotplugged" property read-only

On Mon, Feb 27, 2017 at 07:05:24PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > The "hotplugged" property is user visible, but it was never meant > > to be set by the user. There are probably multiple ways to break > > or crash device code by overriding

Re: [libvirt] [PATCH v2] Document preferred naming conventions

On Fri, Mar 03, 2017 at 07:57:24PM +0100, Jiri Denemark wrote: > On Fri, Mar 03, 2017 at 17:47:23 +, Daniel P. Berrange wrote: > > This documents the preferred conventions for naming files, > > structs, enums, typedefs and functions. > > > > Signed-off-by: Daniel P. Berrange

[libvirt] [PATCH] news: Move host CPU model improvement to 3.2.0

Signed-off-by: Jiri Denemark --- Pushed as trivial. docs/news.xml | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index e4b5a9d31..584c9afac 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -15,7

Re: [libvirt] [PATCH 0/2] cpu_x86: Disable TSX on broken models

On Fri, Feb 24, 2017 at 14:14:10 +0100, Pavel Hrdina wrote: > On Thu, Feb 16, 2017 at 03:02:17PM +0100, Jiri Denemark wrote: > > This series applies on top of "qemu: Detect host CPU model by asking > > QEMU on x86_64". > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1406791 > > > > Jiri

Re: [libvirt] [PATCH v3 00/28] qemu: Detect host CPU model by asking QEMU on x86_64

Thanks for the reviews. > Patches waiting for QEMU code to be pushed: > > - qemucapstest: Update test data for QEMU 2.9.0 > - domaincapstest: Add test data for QEMU 2.9.0 > - docs: Update description of the host-model CPU mode > - qemu: Rename hostCPU/feature element in capabilities cache > -

Re: [libvirt] [PATCH v2] Document preferred naming conventions

On Fri, Mar 03, 2017 at 17:47:23 +, Daniel P. Berrange wrote: > This documents the preferred conventions for naming files, > structs, enums, typedefs and functions. > > Signed-off-by: Daniel P. Berrange > --- > > Changed in v2: > > - Fix typo > - Add macro docs > -

[libvirt] [PATCH v2] Document preferred naming conventions

This documents the preferred conventions for naming files, structs, enums, typedefs and functions. Signed-off-by: Daniel P. Berrange --- Changed in v2: - Fix typo - Add macro docs - Clarify that $VERB is always last in function/macro names HACKING | 81

[libvirt] [PATCH v2 1/2] util: switch over to use keycodemapdb GIT submodule

A long time ago we imported the keymaps.csv file from GTK-VNC so we can do conversions between keycode sets. Meanwhile lots of bug fixes have gone into this CSV file and libvirt hasn't kept in sync. The keymaps.csv file and associated generator script has been pulled out of GTK-VNC into a

[libvirt] [PATCH v2 2/2] Add ability to generate man page describing key code names & values

Signed-off-by: Daniel P. Berrange --- libvirt.spec.in | 1 + mingw-libvirt.spec.in | 2 ++ src/Makefile.am | 42 +++--- tools/virsh.pod | 20 4 files changed, 62 insertions(+), 3 deletions(-) diff

[libvirt] [PATCH v2 0/2] Use the shared keycodemap database

Changed in v2: - Fixed make syntax-check errors - Auto-generate man pages listing value key codes for use with the virDomainSendKey API / virsh send-key command Daniel P. Berrange (2): util: switch over to use keycodemapdb GIT submodule Add ability to generate man page describing key

Re: [libvirt] [PATCH] Document preferred naming conventions

On Fri, Mar 03, 2017 at 03:19:46PM +0100, Michal Privoznik wrote: > On 03/03/2017 10:48 AM, Daniel P. Berrange wrote: > > This documents the preferred conventions for naming files, > > structs, enums, typedefs and functions. > > > > Signed-off-by: Daniel P. Berrange > > ---

Re: [libvirt] [PATCH] Document preferred naming conventions

On Fri, Mar 03, 2017 at 03:10:11PM +0100, Martin Kletzander wrote: > On Fri, Mar 03, 2017 at 09:48:23AM +, Daniel P. Berrange wrote: > > This documents the preferred conventions for naming files, > > structs, enums, typedefs and functions. > > > > Signed-off-by: Daniel P. Berrange

Re: [libvirt] [PATCH] Fix location of blkid.h in include header

On 03/03/2017 04:42 PM, Nehal J Wani wrote: > The build system for libvirt correctly detects the location of blkid > using PKG_CONFIG_PATH environment variable. The file blkid.pc states > that the include flags should be: 'Cflags: -I${includedir}/blkid' but > libvirt searches for blkid.h inside

[libvirt] [PATCH] Fix location of blkid.h in include header

The build system for libvirt correctly detects the location of blkid using PKG_CONFIG_PATH environment variable. The file blkid.pc states that the include flags should be: 'Cflags: -I${includedir}/blkid' but libvirt searches for blkid.h inside ${includedir}/blkid/blkid, which is wrong. Until now,

[libvirt] [PATCH 2/2] qemu: hotplug: Reset device removal waiting code after vCPU unplug

If the delivery of the DEVICE_DELETED event for the vCPU being deleted would time out, the code would not call 'qemuDomainResetDeviceRemoval'. Since the waiting thread did not unregister itself prior to stopping the waiting the monitor code would try to wake it up instead of dispatching it to the

[libvirt] [PATCH 1/2] qemu: hotplug: Add debug log when dispatching device removal to existing thread

Note that the waiting thread is singalled in the debug logs to simplify debugging. --- src/qemu/qemu_hotplug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 0c0885695..889f110a9 100644 --- a/src/qemu/qemu_hotplug.c +++

[libvirt] [PATCH 0/2] qemu: properly handle delayed vCPU hotunplug

Patch 1 would help in debugging this issue. Patch 2 fixes the bug. Peter Krempa (2): qemu: hotplug: Add debug log when dispatching device removal to existing thread qemu: hotplug: Reset device removal waiting code after vCPU unplug src/qemu/qemu_hotplug.c | 17 + 1 file

[libvirt] [PATCH 4/4] network: check accept_ra before enabling ipv6 forwarding

When enabling IPv6 on all interfaces, we may get the host Router Advertisement routes discarded. To avoid this, the user needs to set accept_ra to 2 for the interfaces with such routes. See https://www.kernel.org/doc/Documentation/networking/ip-sysctl.txt on this topic. To avoid user mistakenly

[libvirt] [PATCH 1/4] util: extract the request sending code from virNetlinkCommand()

Allow to reuse as much as possible from virNetlinkCommand(). This comment prepares for the introduction of virNetlindDumpCommand() only differing by how it handles the responses. --- src/util/virnetlink.c | 90 +++ 1 file changed, 55 insertions(+),

[libvirt] [PATCH 2/4] util: add virNetlinkDumpCommand()

virNetlinkCommand() processes only one response message, while some netlink commands like routes dumping need to process several ones. Add virNetlinkDumpCommand() as a virNetlinkCommand() sister. --- src/libvirt_private.syms | 1 + src/util/virnetlink.c| 55

[libvirt] [PATCH 3/4] bridge_driver.c: more uses of SYSCTL_PATH

Replace a few occurences of /proc/sys by the corresponding macro defined a few lines after: SYSCTL_PATH --- src/network/bridge_driver.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index c5ec2823d..3f6561055

[libvirt] [PATCH 0/4] Prevent loosing IPv6 routes due to forwarding

Hi all, When enabling IPv6 forwarding on hosts getting Router Advertised routes, the host looses the RA routes. To prevent this, check if the host has such routes. In case there are some, check that the accept_ra is set to 2 before bringing the network up. Cédric Bosdonnat (4): util: extract

Re: [libvirt] [PATCH] Document preferred naming conventions

On 03/03/2017 10:48 AM, Daniel P. Berrange wrote: > This documents the preferred conventions for naming files, > structs, enums, typedefs and functions. > > Signed-off-by: Daniel P. Berrange > --- > HACKING | 71 >

Re: [libvirt] [PATCH] Document preferred naming conventions

On Fri, Mar 03, 2017 at 09:48:23AM +, Daniel P. Berrange wrote: This documents the preferred conventions for naming files, structs, enums, typedefs and functions. Signed-off-by: Daniel P. Berrange --- HACKING | 71

Re: [libvirt] [PATCH v2 5/6] conf: Clean up the _virNodeDevCapData

On 03/03/2017 04:20 AM, Pavel Hrdina wrote: > On Thu, Mar 02, 2017 at 11:14:26AM -0500, John Ferlan wrote: >> Rather than a bunch of embedded union structs, let's create structs >> for each of the structs within the union and make the struct easier >> to read. >> >> Signed-off-by: John Ferlan

Re: [libvirt] [PATCH RFC 3/4] libxl: implement qemu-agent-command

On 03/03/2017 12:15 AM, Jim Fehlig wrote: > On 03/02/2017 11:46 AM, Jim Fehlig wrote: >> On 02/08/2017 09:44 AM, Joao Martins wrote: >>> Signed-off-by: Joao Martins > > Opps, forgot to mention that it would be helpful if the commit message > contained > info on what

Re: [libvirt] [PATCH] Document preferred naming conventions

On Fri, Mar 03, 2017 at 09:48:23 +, Daniel Berrange wrote: > This documents the preferred conventions for naming files, > structs, enums, typedefs and functions. > > Signed-off-by: Daniel P. Berrange > --- > HACKING | 71

[libvirt] [PATCH] news: Add an empty to each

The generated HTML will contain otherwise, which triggers an error during 'make check'. The proper fix would be not to generate the problematic HTML in the first place but, while I'm working on it, this workaround will do. --- Pushed as build-breaker. Sorry for the noise. docs/news.xml | 3 +++

Re: [libvirt] [PATCH RFC 3/4] libxl: implement qemu-agent-command

On 03/02/2017 06:46 PM, Jim Fehlig wrote: > On 02/08/2017 09:44 AM, Joao Martins wrote: >> Signed-off-by: Joao Martins >> --- Sorry - being an RFC I let myself be a little too clumsy on the commit messages. This was meant to have at least the bits mentioned in the cover

[libvirt] [PATCH] Post-release version bump to 3.2.0

--- Pushed as trivial. configure.ac | 2 +- docs/news.xml | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index ed49daa..e61ab7b 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU

Re: [libvirt] [PATCH RFC 2/4] qemu_agent: ignore requests echoed back by guest

On 03/02/2017 06:16 PM, Daniel P. Berrange wrote: > On Thu, Mar 02, 2017 at 11:10:10AM -0700, Jim Fehlig wrote: >> On 02/08/2017 09:44 AM, Joao Martins wrote: >>> Signed-off-by: Joao Martins >> >> Since it wasn't needed before, I think it is helpful for the commit

Re: [libvirt] [PATCH RFC 1/4] qemu_agent: move agent into util

On 03/03/2017 11:35 AM, Daniel P. Berrange wrote: > On Fri, Mar 03, 2017 at 11:36:25AM +, Joao Martins wrote: >> >> >> On 03/02/2017 05:58 PM, Jim Fehlig wrote: >>> Sorry for the review delay. >>> >>> On 02/08/2017 09:44 AM, Joao Martins wrote: As it could be shared with libxl which now

Re: [libvirt] [PATCH RFC 1/4] qemu_agent: move agent into util

On Fri, Mar 03, 2017 at 11:36:25AM +, Joao Martins wrote: > > > On 03/02/2017 05:58 PM, Jim Fehlig wrote: > > Sorry for the review delay. > > > > On 02/08/2017 09:44 AM, Joao Martins wrote: > >> As it could be shared with libxl which now allows channels to > >> be created. Also changed

Re: [libvirt] [PATCH RFC 2/4] qemu_agent: ignore requests echoed back by guest

On 03/02/2017 06:10 PM, Jim Fehlig wrote: > On 02/08/2017 09:44 AM, Joao Martins wrote: >> Signed-off-by: Joao Martins > > Since it wasn't needed before, I think it is helpful for the commit message > to > describe why the change is needed now. True, my apologies.

Re: [libvirt] [PATCH RFC 1/4] qemu_agent: move agent into util

On 03/02/2017 05:58 PM, Jim Fehlig wrote: > Sorry for the review delay. > > On 02/08/2017 09:44 AM, Joao Martins wrote: >> As it could be shared with libxl which now allows channels to >> be created. Also changed filename to match others in the same >> directory namely to virqemuagent.{h,c} >>

[libvirt] Availability of libvirt-3.1.0

I'm a bit late but I finally pushed the release, the signed tarball and rpms are at the usual place: ftp://libvirt.org/libvirt/ I also pushed a libvirt-python release that one can find at ftp://libvirt.org/libvirt/python/ * New features - storage: Add Virtuozzo storage backend storage

[libvirt] [PATCH] qemuDomainSaveImageUpdateDef: Don't overwrite errors from virDomainDefCheckABIStability

https://bugzilla.redhat.com/show_bug.cgi?id=1379200 When we are restoring a domain from a saved image, or just updating its XML in the saved image - we have to make sure that the ABI guests sees will not change. We have a function for that which reports errors. But for some reason if this

[libvirt] [PATCH] Document preferred naming conventions

This documents the preferred conventions for naming files, structs, enums, typedefs and functions. Signed-off-by: Daniel P. Berrange --- HACKING | 71 docs/hacking.html.in | 83

Re: [libvirt] [PATCH v2 5/6] conf: Clean up the _virNodeDevCapData

On Thu, Mar 02, 2017 at 11:14:26AM -0500, John Ferlan wrote: > Rather than a bunch of embedded union structs, let's create structs > for each of the structs within the union and make the struct easier > to read. > > Signed-off-by: John Ferlan > --- >

Re: [libvirt] [PATCH v2 0/6] Split out node device object into its own module

On Thu, Mar 02, 2017 at 11:14:21AM -0500, John Ferlan wrote: > v1: http://www.redhat.com/archives/libvir-list/2017-March/msg00046.html > > Differences... > > patch 1 and 3 are the same and both were ACK'd > patch 2 removes the lower case function name changes (a/k/a "vir" removal) > patch 4 is

Re: [libvirt] [PATCH v2 6/6] nodedev: Reduce virNodeDevCapDataPtr usage

On Thu, Mar 02, 2017 at 11:14:27AM -0500, John Ferlan wrote: > Replace with more data specific pointer types. > udevGetDMIData can be altered this way as well. ACK with that change. Erik -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [RFC PATCH 00/12] Support multiple PHBs on pSeries guests

On Fri, 2017-03-03 at 12:37 +1100, David Gibson wrote: > > Hm, you have a point. I'll try to see how difficult it > > would be to teach PCI devices about the quirkiness in > > bus naming when it comes to PHBs. >  > An update: I'm intending to squeeze the device tree fix to advertise > extended

Re: [libvirt] [RFC v2 0/2] vireventpoll implimentation using epoll

22-Feb-17 17:35, Dmitry Derbyshev пишет: Ping. Also, noticed that I renamed patch series, old name was "Substitute poll by epoll in virEventPollRunOnce". My bad. A few issues required to be fixed to make 'make syntax-check' pass. Otherwise looks good to me. Maxim /14/2017 9:04 PM,