[libvirt] [PATCH] hooks: Fix a wrong description

From: Chen Hanxiao In the definition of virHookQemuOpType and virHookNetworkOpType, we should use 'stopped' rather than 'shutdown'. Signed-off-by: Chen Hanxiao --- docs/hooks.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [libvirt] [PATCH 15/21] caps2xml resctrl-skx-twocaches

On Tue, Nov 14, 2017 at 04:20:45PM -0500, John Ferlan wrote: Would be nice to have more information here regarding what this is Only after sending have I found out that I somehow missed few commits when adding commit messages. This is one of the examples, another one is "conf:

Re: [libvirt] [[RFC] 0/8] Implement async QEMU event handling in libvirtd.

On Wed, Nov 15, 2017 at 12:07 AM, Marc Hartmayer < mhart...@linux.vnet.ibm.com> wrote: > On Tue, Oct 24, 2017 at 07:34 PM +0200, Prerna Saxena < > saxenap@gmail.com> wrote: > > As noted in > > https://www.redhat.com/archives/libvir-list/2017-May/msg00016.html > > libvirt-QEMU driver handles

[libvirt] [PATCH 1/2] caps: Add capability for maximum size of the qcow2 L2 table cache

Signed-off-by: Lin Ma --- src/qemu/qemu_capabilities.c | 5 + src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_2.10.0-gicv2.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0-gicv3.aarch64.xml |

[libvirt] [PATCH 0/2] Add 'l2-cache-size' property to specify maximum size of the L2 table cache for qcow2 image

Lin Ma (2): caps: Add capability for maximum size of the qcow2 L2 table cache qemu: Add support for 'l2-cache-size' property of qcow2 docs/formatdomain.html.in | 11 +++ docs/schemas/domaincommon.rng | 5 src/conf/domain_conf.c

[libvirt] [PATCH 2/2] qemu: Add support for 'l2-cache-size' property of qcow2

Signed-off-by: Lin Ma --- docs/formatdomain.html.in | 11 +++ docs/schemas/domaincommon.rng | 5 src/conf/domain_conf.c | 11 +++ src/conf/domain_conf.h | 1 +

Re: [libvirt] [PATCH 16/21] resctrl: Add functions to work with resctrl allocations

On 11/13/2017 03:50 AM, Martin Kletzander wrote: > With this commit we finally have a way to read and manipulate basic resctrl > settings. Locking is done only on exposed functions that read/write from/to > resctrlfs. Not in fuctions that are exposed in virresctrlpriv.h as those are functions

Re: [libvirt] [PATCH 2/2] AppArmor: use fine-grained mount rules instead of a blanket catch-all one

On Sun, 2017-11-05 at 15:29 +, intrigeri+libv...@boum.org wrote: > From: intrigeri > > This set of rules was proposed by Christian Boltz > > on https://bugzilla.opensuse.org/show_bug.cgi?id=1065123. > --- >

Re: [libvirt] [PATCH 1/2] AppArmor: add rules needed with additional mediation features brought by Linux 4.14.

On Sun, 2017-11-05 at 15:29 +, intrigeri+libv...@boum.org wrote: > From: intrigeri > > --- > examples/apparmor/libvirt-qemu | 4 > examples/apparmor/usr.sbin.libvirtd | 6 ++ > 2 files changed, 10 insertions(+) > > diff --git

Re: [libvirt] [PATCH 15/21] caps2xml resctrl-skx-twocaches

Would be nice to have more information here regarding what this is On 11/13/2017 03:50 AM, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > .../resctrl/info/L3/cbm_mask | 1 + > .../resctrl/info/L3/min_cbm_bits

Re: [libvirt] [[RFC] 0/8] Implement async QEMU event handling in libvirtd.

On Tue, Oct 24, 2017 at 07:34 PM +0200, Prerna Saxena wrote: > As noted in > https://www.redhat.com/archives/libvir-list/2017-May/msg00016.html > libvirt-QEMU driver handles all async events from the main loop. > Each event handling needs the per-VM lock to make forward

Re: [libvirt] Redesigning Libvirt: Adopting use of a safe language

The Problem(s) == When libvirt was created, C was the only viable choice for anything aiming to be a core system library component. At that time 2005, aside from C there were common choices of Java, Python, Perl. Java was way too heavy for a low level system component, Python was

Re: [libvirt] Redesigning Libvirt: Exploding the libvirtd architecture

The problem(s) == The libvirtd architecture has evolved over time, initially as an expediant solution to the problem of managing virtual networks and QEMU processes, and over time came to control all the other resources too. It is only avoided in the case of the stateless hypervisor

Re: [libvirt] Redesigning Libvirt: Better supporting non-hypervisor agnostic concepts

The problem(s) == While a hypervisor agnostic API is useful for some users, it is completely irrelevant, and potentally even painful, for other users. We made some concessions to this when we introduced hypervisor specific XML namespaces and option for hypervisor specific add-on APIs.

[libvirt] Redesigning Libvirt: Adapting for the next 12 years

Hold tight, this is a long one... It is hard for me to believe it, but the libvirt project is now 12 years old (born on Nov 2, 2005), and I've been working on it since March 2006, making it easily the most significant project I've worked on. It started off life as an attempt to provide a stable

Re: [libvirt] [PATCH] RFC: qemu: add vmcoreinfo support

ping, please review/comment On Mon, Nov 6, 2017 at 1:09 PM, wrote: > From: Marc-André Lureau > > Starting from qemu 2.11, the `-device vmcoreinfo` will create a fw_cfg > entry for a guest to store dump details, necessary to process

Re: [libvirt] [PATCH 11/21] conf: Format cache banks in capabilities with virPrettySize

On Tue, Nov 14, 2017 at 07:38:50AM -0500, John Ferlan wrote: On 11/13/2017 03:50 AM, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/conf/capabilities.c| 45 ++

[libvirt] [PATCH] qemu: taint domain if virDomainQemuAgentCommand API is used

This is similar to the virDomainQemuMonitorCommand API, it can change the domain state in a way that libvirt may not understand. Signed-off-by: Pavel Hrdina --- src/conf/domain_conf.c | 3 ++- src/conf/domain_conf.h | 1 + src/qemu/qemu_driver.c | 2 ++ 3 files changed, 5

[libvirt] [PATCH] qemuBuildDeviceAddressStr: Prefer default alias for PCI bus

https://bugzilla.redhat.com/show_bug.cgi?id=1434451 Just like in 9324f67a572f9b32 we need to put default pci-root alias onto the command line instead of the one provided by user. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c | 25 + 1

Re: [libvirt] [PATCH 09/21] util: Introduce virBitmapShrink

On Mon, Nov 13, 2017 at 03:42:40PM -0500, John Ferlan wrote: On 11/13/2017 03:50 AM, Martin Kletzander wrote: Sometimes the size of the bitmap matters and it might not be guessed correctly when parsing from some type of input. For example virBitmapNewData() has Byte granularity,

Re: [libvirt] [PATCH] qemuBuildDriveDevStr: Prefer default aliases for IDE bus

On 11/10/2017 04:03 PM, Ján Tomko wrote: > On Thu, Nov 09, 2017 at 01:43:22PM +0100, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1434451 >> >> When testing user aliases it was discovered that for 440fx >> machine type which has default IDE bus builtin, domain cannot >>

Re: [libvirt] [PATCH 14/21] tests: Change some schemata for the default group

On 11/13/2017 03:50 AM, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > tests/vircaps2xmldata/linux-resctrl-cdp/resctrl/schemata | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > I have no idea what the bits represent ;-), still...

Re: [libvirt] [PATCH 13/21] tests: Remove executable bits on plain data files

On 11/13/2017 03:50 AM, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > tests/vircaps2xmldata/linux-resctrl-cdp/resctrl/info/L3CODE/cbm_mask | 0 > tests/vircaps2xmldata/linux-resctrl-cdp/resctrl/info/L3CODE/min_cbm_bits | 0 >

Re: [libvirt] [PATCH 12/21] resctrl: Instantiate all resctrl information at once

On 11/13/2017 03:50 AM, Martin Kletzander wrote: > This allows for looking up the cache control information more sensibly from > conf/capabilities.c and also provides more data to the virresctrl module that > will get more usable later on. > > Signed-off-by: Martin Kletzander

Re: [libvirt] [PATCH 2/4] tests: Add tests for configuration of HPT resizing

On Mon, 2017-11-13 at 10:36 -0500, John Ferlan wrote: > Those against test bloat would point out only one of the three options > is really necessary... IDRC, but I also see the trend that could be > started as new things are added that have 10 different options. I'm > fine with any one of the 3

[libvirt] [RFC] externall (pull) backup API

Table of contents. I Preface 1. Fleece API 2. Export API 3. Incremental backups 4. Other hypervisors II Links I Preface This is a RFC for external (or pull) backup API in libvirt. There was a series [1] with more limited API scope and functionality for this kind of backup

Re: [libvirt] [PATCH 1/4] qemu: Enable configuration of HPT resizing for pSeries guests

On Mon, 2017-11-13 at 10:36 -0500, John Ferlan wrote: > > @@ -4776,6 +4777,13 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCaps, > > if (qemuCaps->version >= 2006000) > > virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_KERNEL_IRQCHIP_SPLIT); > > > > +/* HPT resizing is supported

Re: [libvirt] [PATCH 4/5] qemu: Support setting NUMA distances

On 11/14/2017 04:13 PM, Peter Krempa wrote: > On Tue, Nov 14, 2017 at 15:47:39 +0100, Michal Privoznik wrote: >> Since we already have such support for libxl all we need is qemu >> driver adjustment. And a test case. >> >> Signed-off-by: Michal Privoznik >> --- >>

Re: [libvirt] 答复: Help：Can libvirt restore several xen snapshots more faster at same time?

On 11/14/2017 03:34 AM, Chenjia (C) wrote: > Dear libvirt expert: > Thanks for your reply. > May be our description is not suitable, in last message,'snapshot' > means the domain state file which 'virsh save ' generate. > > Our project detailed steps are as follows: > 1)

Re: [libvirt] [PATCH 4/5] qemu: Support setting NUMA distances

On Tue, Nov 14, 2017 at 15:47:39 +0100, Michal Privoznik wrote: > Since we already have such support for libxl all we need is qemu > driver adjustment. And a test case. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_command.c| 36

Re: [libvirt] [PATCH] spec: don't package product dirs

On 13.11.2017 11:35, Martin Kletzander wrote: > On Thu, Sep 28, 2017 at 09:35:45AM +0300, Nikolay Shirokovskiy wrote: >> Directories /var/{lib,cache}/libvirt/qemu/ are created by libvirtd on >> start and their owner:group is changed according to the config. Thus >> no need to include them in

Re: [libvirt] [PATCH 03/21] util: Make prefix optional in virBitampString

On Mon, Nov 13, 2017 at 02:22:20PM -0500, John Ferlan wrote: $subj: s/virBitampString/virBitmapString/ hehe, good catch On 11/13/2017 03:50 AM, Martin Kletzander wrote: Signed-off-by: Martin Kletzander --- src/qemu/qemu_capabilities.c | 4 ++-- src/util/virbitmap.c

[libvirt] [PATCH 2/5] numa: Introduce virDomainNumaNodeDistanceSpecified

The function returns true/false depending on distance configuration being present in the domain XML. Signed-off-by: Michal Privoznik --- src/conf/numa_conf.c | 13 + src/conf/numa_conf.h | 4 src/libvirt_private.syms | 1 + 3 files changed, 18

[libvirt] [PATCH 3/5] qemu_capabilities: Introcude QEMU_CAPS_NUMA_DIST

This capability says if qemu is capable of specifying distances between NUMA nodes on the command line. Unfortunately, there's no real way to check this and thus we have to go with version check. QEMU introduced this in 0f203430dd8 (and friend) which was released in 2.10.0. Signed-off-by: Michal

[libvirt] [PATCH 5/5] news: Document which drivers support NUMA distances

Signed-off-by: Michal Privoznik --- docs/news.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/news.xml b/docs/news.xml index 3966710ee..502679917 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -43,7 +43,7 @@ A NUMA hardware

[libvirt] [PATCH 1/5] virDomainNumaGetNodeDistance: Fix input arguments validation

There's no point in checking if numa->mem_nodes[node].ndistances is set if we check for numa->mem_nodes[node].distances. However, it makes sense to check if the sibling node caller passed falls within boundaries. Signed-off-by: Michal Privoznik --- src/conf/numa_conf.c | 2

[libvirt] [PATCH 4/5] qemu: Support setting NUMA distances

Since we already have such support for libxl all we need is qemu driver adjustment. And a test case. Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c| 36 +++- .../qemuxml2argv-numatune-distances.args | 63

[libvirt] [PATCH 0/5] qemu: Support setting NUMA distances

Now that XML parsing & formatting is merged this is fairly trivial. Michal Privoznik (5): virDomainNumaGetNodeDistance: Fix input arguments validation numa: Introduce virDomainNumaNodeDistanceSpecified qemu_capabilities: Introcude QEMU_CAPS_NUMA_DIST qemu: Support setting NUMA distances

Re: [libvirt] [PATCH 02/21] util: Introduce virPrettySize

On Mon, Nov 13, 2017 at 01:36:58PM -0500, John Ferlan wrote: On 11/13/2017 03:50 AM, Martin Kletzander wrote: We can't output better memory sizes if we want to be compatible with libvirt older than the one which introduced /memory/unit, but for new things we can just output nicer capacity to

Re: [libvirt] [PATCH 3/5] libvirtd: Alter refcnt processing for domain server objects

On Sun, Nov 12, 2017 at 09:46:48AM -0500, John Ferlan wrote: > > [...] > > > Now the actual review. > > virNetDaemonAddServer is only used when spawning a new daemon or setting up > > LXC > > controller. The function essentially does: > > > > lock(@dmn) > > hash_table_add(@srv) > >

Re: [libvirt] [PATCH 3/5] libvirtd: Alter refcnt processing for domain server objects

On Fri, Nov 10, 2017 at 05:41:51PM -0500, John Ferlan wrote: > > > On 11/10/2017 10:08 AM, Erik Skultety wrote: > > On Tue, Nov 07, 2017 at 09:39:54PM -0500, John Ferlan wrote: > >> Whether the @srv/@srvAdm is added to the dmn->servers list or not, > >> the reference kept for the allocation can be

[libvirt] [PATCH 1/6] tests: add test cases for default sound output

These test cases models current situation where there is no way how to specify sound output and that it's based on which graphic device is the last one. Signed-off-by: Pavel Hrdina --- .../qemuxml2argv-sound-default-output-sdl.args | 23

[libvirt] [PATCH 0/6] implement support to configure sound output

Pavel Hrdina (6): tests: add test cases for default sound output qemu: move QEMU_AUDIO_DRIVER out of graphic into sound qemu: explicitly disable audio if there is no sound device conf: introduce element for devices qemu: implement element for devices tests: add test cases for

[libvirt] [PATCH 4/6] conf: introduce element for devices

So far it was not possible to specify how the audio output from guest should be presented to host/users. Now it will be possible to do so via element for device where you specify the output "type". Signed-off-by: Pavel Hrdina --- docs/formatdomain.html.in | 9 +++

[libvirt] [PATCH 5/6] qemu: implement element for devices

So far we were configuring the sound output based on what graphic device was configured in domain XML. This had a several disadvantages, it's not transparent, in case of multiple graphic devices it was overwritten by the last one and there was no simple way how to configure this per domain. The

[libvirt] [PATCH 6/6] tests: add test cases for specific sound output

Signed-off-by: Pavel Hrdina --- ...xml2argv-sound-multi-different-output-spice.xml | 29 ++ .../qemuxml2argv-sound-multi-pa-output-spice.args | 26 +++ .../qemuxml2argv-sound-multi-pa-output-spice.xml | 27

[libvirt] [PATCH 2/6] qemu: move QEMU_AUDIO_DRIVER out of graphic into sound

Setting the default audio output depends on specific graphic device but requires having sound device configured as well and it's the sound device that handles the audio. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_command.c| 84

[libvirt] [PATCH 3/6] qemu: explicitly disable audio if there is no sound device

If there is no sound device configured for the guest we can disable the audio output because hot-plugging sound devices isn't supported. Signed-off-by: Pavel Hrdina --- src/qemu/qemu_command.c | 5 +

[libvirt] [PATCH 2/2] daemon: virtlockd: Call virNetDaemonGetServer regardless of post exec

We need to call it anyway, so the else branch is redundant here. Signed-off-by: Erik Skultety --- It was either this or revert the order of the conditions so that the else branch/block is actually the bigger one, complying with our guidelines. src/locking/lock_daemon.c |

[libvirt] [PATCH 1/2] daemon: virtlogd: Drop the server shortcut ref pointer

We put the server into a hash table as we do with the other daemons, there is no compelling reason why it should have another pointer dedicated just to the server. Besides, the locking daemon doesn't have it and virtlogd is essentially a copy paste of virtlockd. Signed-off-by: Erik Skultety

[libvirt] [PATCH 0/2] virtlo(ck|g)d: Two simple improvements

Erik Skultety (2): daemon: virtlogd: Drop the server shortcut ref pointer daemon: virtlockd: Call virNetDaemonGetServer regardless of post exec src/locking/lock_daemon.c | 5 +++-- src/logging/log_daemon.c | 54 --- 2 files changed, 35

[libvirt] [PATCH go-xml] Support network backed serial interfaces

Adds network backing for a DomainChardevSource and protocol selection for serial device of type tcp. Signed-off-by: Jeroen Simonetti --- domain.go | 26 +- domain_test.go | 26 +++--- 2 files changed, 40 insertions(+), 12

Re: [libvirt] [PATCH 11/21] conf: Format cache banks in capabilities with virPrettySize

On 11/13/2017 03:50 AM, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > src/conf/capabilities.c| 45 > ++ > tests/vircaps2xmldata/vircaps-x86_64-caches.xml| 2 +- >

Re: [libvirt] [PATCH] vircapstest: Avoid (im)possible strcmp call with NULL argument

On 11/13/2017 10:44 PM, Jiri Denemark wrote: > Some compiler may get confused and decide we are calling strcmp with > NULL argument from test_virCapsDomainDataLookupLXC. Although this does > not really happen since the call is guarded with > (data->machinetype != expect_machinetype), using

[libvirt] [PATCH go-xml] Add support for panic device

Add DomainAddressISA for panic device address. Add DomainPanic. Add test code. Signed-off-by: zhenwei.pi --- domain.go | 38 ++ domain_test.go | 28 +--- 2 files changed, 63 insertions(+), 3