Re: [libvirt] Redesigning Libvirt: Adopting use of a safe language

On 11/16/2017 03:55 PM, John Ferlan wrote: On 11/14/2017 12:27 PM, Daniel P. Berrange wrote: Part of the problem is that, despite Linux having very low overhead thread spawning, threads still consume non-trivial resources, so we try to constrain how many we use, which forces an M:N

Re: [libvirt] [PATCH] docs: add a page describing support guarantees for libvirt features

On 11/16/2017 10:19 AM, Daniel P. Berrange wrote: While we have collective knowledge about the support status of various parts of libvirt, this has never been formally documented, leaving our users to guess. Signed-off-by: Daniel P. Berrange --- docs/docs.html.in|

Re: [libvirt] Redesigning Libvirt: Adopting use of a safe language

On 11/14/2017 12:27 PM, Daniel P. Berrange wrote: > The Problem(s) > == First off I'll state I'm not opposed to considering adopting or integrating a newer language. Still, I have my concerns, fears, uncertainty, and doubts. In a world where one must "adapt or die", I'm not opposed

Re: [libvirt] 答复: 答复: Help：Can libvirt restore several xen snapshots more faster at same time?

On 11/15/2017 02:36 AM, Chenjia (C) wrote: Dear libvirt expert: Thanks for your reply. if we use ' virsh restore file --bypass-cache', we got the error message: 'unsupported flags (0x1) in function libxlDomainRestoreFlags'. --bypass-cache is not yet supported in the Xen

Re: [libvirt] 答复: Help：Can libvirt restore several xen snapshots more faster at same time?

On 11/14/2017 08:22 AM, Michal Privoznik wrote: On 11/14/2017 03:34 AM, Chenjia (C) wrote: Dear libvirt expert: Thanks for your reply. May be our description is not suitable, in last message,'snapshot' means the domain state file which 'virsh save ' generate. Our

Re: [libvirt] [PATCH] virt-viewer.spec.in: fix build after spice-xpi-client removal

On Thu, Nov 16, 2017 at 06:42:01PM +0100, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This fixes commit 140cb84c2538bf0eab7dea2035dfecc4db74c784, where we > removed the spice-xpi-client-remote-viewer. > > Signed-off-by: Marc-André Lureau

[libvirt] [PATCH] virt-viewer.spec.in: fix build after spice-xpi-client removal

From: Marc-André Lureau This fixes commit 140cb84c2538bf0eab7dea2035dfecc4db74c784, where we removed the spice-xpi-client-remote-viewer. Signed-off-by: Marc-André Lureau --- virt-viewer.spec.in | 8 1 file changed, 8

[libvirt] [jenkins-ci PATCH 0/3] Add Fedora 27, remove Fedora 25

'tis the season. Andrea Bolognani (3): Add Fedora 27 builder Remove Fedora 25 builder guests: Adjust Fedora 26 install URL guests/host_vars/libvirt-fedora-26/install.yml | 2 +- .../install.yml| 2 +- .../main.yml

[libvirt] [jenkins-ci PATCH 3/3] guests: Adjust Fedora 26 install URL

Both Fedora 27 and Fedora Rawhide must be installed using Everything/ instead of Server/, so use it for Fedora 26 as well for consistency. Signed-off-by: Andrea Bolognani --- guests/host_vars/libvirt-fedora-26/install.yml | 2 +- 1 file changed, 1 insertion(+), 1

[libvirt] [jenkins-ci PATCH 2/3] Remove Fedora 25 builder

We keep only two stable versions of Fedora in our CI infrastructure at any given time: now that Fedora 27 has been added, Fedora 25 can be removed. Signed-off-by: Andrea Bolognani --- guests/host_vars/libvirt-fedora-25/install.yml | 3 -

[libvirt] [jenkins-ci PATCH 1/3] Add Fedora 27 builder

Fedora 27 has been released, so we can create a dedicated guest and start running CI jobs on it. Signed-off-by: Andrea Bolognani --- The changes in the vault are based on the assumption that the new libvirt-fedora-27 builder will reuse the Jenkins secret previously assigned

Re: [libvirt] [jenkins-ci PATCH 2/2] projects: Use {smp} in osinfo-db-master-build

On Thu, Nov 16, 2017 at 06:28:50PM +0100, Andrea Bolognani wrote: > We were hard-coding '3' instead of using the {smp} yaml variable, > which has been defined specifically for use in this context. > > Signed-off-by: Andrea Bolognani > --- > projects/osinfo-db.yaml | 2 +- >

Re: [libvirt] [jenkins-ci PATCH 1/2] jobs: Use $MAKE in autotools-mingw-job

On Thu, Nov 16, 2017 at 06:28:49PM +0100, Andrea Bolognani wrote: > We were hard-coding 'make' instead of using the $MAKE environment > variable, which has been defined specifically for use in this > context. > > Signed-off-by: Andrea Bolognani > --- > jobs/autotools.yaml |

[libvirt] [jenkins-ci PATCH 0/2] Small fixes

Andrea Bolognani (2): jobs: Use $MAKE in autotools-mingw-job projects: Use {smp} in osinfo-db-master-build jobs/autotools.yaml | 8 projects/osinfo-db.yaml | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) -- 2.14.3 -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [jenkins-ci PATCH 1/2] jobs: Use $MAKE in autotools-mingw-job

We were hard-coding 'make' instead of using the $MAKE environment variable, which has been defined specifically for use in this context. Signed-off-by: Andrea Bolognani --- jobs/autotools.yaml | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[libvirt] [jenkins-ci PATCH 2/2] projects: Use {smp} in osinfo-db-master-build

We were hard-coding '3' instead of using the {smp} yaml variable, which has been defined specifically for use in this context. Signed-off-by: Andrea Bolognani --- projects/osinfo-db.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libvirt] [jenkins-ci PATCH] projects: Port libvirt-cim to autotools-*-job

On Thu, Nov 16, 2017 at 06:14:47PM +0100, Andrea Bolognani wrote: > Now that libvirt-cim's autogen.sh script has been changed to > be compatible with the ones used by other libvirt-related > project, we can drop the ad-hoc rules used to build it and > adopt the standard autotools-*-job rules

Re: [libvirt] [cim PATCH 0/3] autogen.sh improvements

On Thu, Nov 16, 2017 at 06:12:53PM +0100, Andrea Bolognani wrote: > These changes are a requirement for porting the libvirt-cim > CI jobs to autotools-*-job. > > Andrea Bolognani (3): > autogen: Better error handling > autogen: Run configure automatically > autogen: Support running

[libvirt] [PATCH] docs: add a page describing support guarantees for libvirt features

While we have collective knowledge about the support status of various parts of libvirt, this has never been formally documented, leaving our users to guess. Signed-off-by: Daniel P. Berrange --- docs/docs.html.in| 3 + docs/support.html.in | 257

[libvirt] [PATCH] docs: don't use https in XML namespace URIs

The XML namespace URI for the QEMU/LXC drivers must use http as the protocol otherwise it won't match the parser's expectations. Signed-off-by: Daniel P. Berrange --- docs/drvlxc.html.in | 2 +- docs/drvqemu.html.in | 4 ++-- 2 files changed, 3 insertions(+), 3

[libvirt] [jenkins-ci PATCH] projects: Port libvirt-cim to autotools-*-job

Now that libvirt-cim's autogen.sh script has been changed to be compatible with the ones used by other libvirt-related project, we can drop the ad-hoc rules used to build it and adopt the standard autotools-*-job rules instead. Signed-off-by: Andrea Bolognani --- Not to be

[libvirt] [cim PATCH 2/3] autogen: Run configure automatically

This is in line with pretty much all libvirt-related projects, is entirely compatible with the old behavior and will enable some simplifications in the CI setup. Signed-off-by: Andrea Bolognani --- autogen.sh | 12 +++- 1 file changed, 11 insertions(+), 1

[libvirt] [cim PATCH 3/3] autogen: Support running out-of-tree

Instead of having to run autogen.sh inside the source directory first, before moving to a build directory and run configure there, it's now possible to run everything from the build directory. Signed-off-by: Andrea Bolognani --- autogen.sh | 10 ++ 1 file changed,

[libvirt] [cim PATCH 1/3] autogen: Better error handling

Instead of making the execution of each command dependend on the success of the previous one, check return values explicitly. Signed-off-by: Andrea Bolognani --- autogen.sh | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git

[libvirt] [PATCH 0/4] Convert virStoragePoolObj into virObjectLockable

Next in the push to get the storage pool objects to be more common is to use the virObjectLockable for the Pool objects. The patches describe the transformation. John Ferlan (4): storage: Introduce virStoragePoolObjEndAPI storage: Introduce virStoragePoolObjListForEach storage: Introduce

[libvirt] [PATCH 1/4] storage: Introduce virStoragePoolObjEndAPI

For now it'll just call the virStoragePoolObjUnlock, but a future adjustment will do something different. Since the new API will check for a NULL object before the Unlock call, callers no longer need to check for NULL before calling. The virStoragePoolObjUnlock is now private/static to

[libvirt] [PATCH 3/4] storage: Introduce virStoragePoolObjListSearch

Create an API to search through the storage pool objects looking for a specific truism from a callback API in order to return the specific storage pool object that is desired. Signed-off-by: John Ferlan --- src/conf/virstorageobj.c | 32 ++ src/conf/virstorageobj.h

[libvirt] [PATCH 4/4] storage: Convert virStoragePoolObj into virObjectLockable

Now that we're moved the object into virstorageobj, let's make the code use the lockable object. Signed-off-by: John Ferlan --- src/conf/virstorageobj.c | 136 + src/conf/virstorageobj.h | 3 - src/libvirt_private.syms

Re: [libvirt] Redesigning Libvirt: Adopting use of a safe language

On Thu, Nov 16, 2017 at 02:58:33PM +0100, Peter Krempa wrote: > On Tue, Nov 14, 2017 at 17:27:01 +, Daniel Berrange wrote: > > The Problem(s) > > == > > Note at first: This is a personal opinion. I'm not discrediting any > advantages a different language might have in technical

[libvirt] [PATCH 2/4] storage: Introduce virStoragePoolObjListForEach

Create an API to walk the pools->objs[] list in order to perform a callback function for each element of the objs array that doesn't care about whether the action succeeds or fails as the desire is to run the code over every element in the array rather than fail as soon as or if one fails.

[libvirt] [PATCH 0/2] vmcoreinfo feature

From: Marc-André Lureau Hi, Starting with QEMU 2.11, the guest can save kernel debug details when this feature is enabled and the kernel supports it. It is useful to process kernel dump with KASLR enabled, and also provides various kernel details to crash tools.

[libvirt] [PATCH 2/2] news: add vmcoreinfo feature details

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- docs/news.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index efde4c8b7..5eb0b79d6 100644 --- a/docs/news.xml +++

[libvirt] [PATCH 1/2] qemu: add vmcoreinfo support

From: Marc-André Lureau Starting from qemu 2.11, the `-device vmcoreinfo` will create a fw_cfg entry for a guest to store dump details, necessary to process kernel dump with KASLR enabled and providing additional kernel details. In essence, it is similar to -fw_cfg

Re: [libvirt] [PATCH v2 0/3] Fix user provided aliases for some devices

On Wed, Nov 15, 2017 at 03:40:14PM +0100, Michal Privoznik wrote: In case user provides an alias for a device that is implicit (e.g. IDE controller for 440fx, SATA for Q35, etc.) we don't put the device onto qemu command line. Therefore we can't set its alias. diff to v1: - more controllers

Re: [libvirt] [PATCH v2 1/3] virQEMUCapsHasPCIMultiBus: Fix @def type

On Wed, Nov 15, 2017 at 03:40:15PM +0100, Michal Privoznik wrote: This function only queries domani @def. It doesn't change it. s/domani/domain/ Therefore it should take const pointer. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 +-

Re: [libvirt] [PATCH 09/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PL011

On Thursday, 16 November 2017 16:44:24 CET Andrea Bolognani wrote: > On Thu, 2017-11-16 at 16:17 +0100, Pino Toscano wrote: > > On Thursday, 16 November 2017 14:56:32 CET Pavel Hrdina wrote: > > > How about we introduce another attribute/element that would specify the > > > exact model of the

Re: [libvirt] [PATCH 09/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PL011

On Thu, Nov 16, 2017 at 04:44:24PM +0100, Andrea Bolognani wrote: > On Thu, 2017-11-16 at 16:17 +0100, Pino Toscano wrote: > > On Thursday, 16 November 2017 14:56:32 CET Pavel Hrdina wrote: > > > How about we introduce another attribute/element that would specify the > > > exact model of the

Re: [libvirt] [PATCH 09/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PL011

On Thu, 2017-11-16 at 16:17 +0100, Pino Toscano wrote: > On Thursday, 16 November 2017 14:56:32 CET Pavel Hrdina wrote: > > How about we introduce another attribute/element that would specify the > > exact model of the serial device and it would be optional, libvirt would > > be able to choose the

[libvirt] [PATCH 3/3] qemu: use job to keep driver responsive on qemuDomainOpenChannel

As we now assume that virChrdevOpen can take a significant time we should take a job and drop vm lock during operation to keep qemu driver responsive. We drop vm lock but access vm structures after it because we are in exlusive modify job so vm structures can only be read concurrently. ---

[libvirt] [PATCH 0/3] qemu: handle connect hangs in virDomainOpenChannel

The problem is described in [1] in more details. From libvirt perspective we have whole driver became unresponsive if connect to channel unix socket hangs during virDomainOpenChannel. This series address this by first using job for the API call and second by introducing connect timeout so that

[libvirt] [PATCH 1/3] util: virFDStreamConnectUNIX: add missing error report

--- src/util/virfdstream.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/virfdstream.c b/src/util/virfdstream.c index be40379..1d064a7 100644 --- a/src/util/virfdstream.c +++ b/src/util/virfdstream.c @@ -1189,6 +1189,7 @@ int virFDStreamConnectUNIX(virStreamPtr st,

[libvirt] [PATCH 2/3] util: add 30s connection timeout to virFDStreamConnectUNIX

There is a bug in qemu currently on hanling agent channels. As a result if you open agent channel for guest without running an agent several times in raw you get hang on connect syscall eventually. Qemu will be fixed eventually but it is nice to handle hanging connect condition in libvirt. Let's

Re: [libvirt] [PATCH] RFC: qemu: add vmcoreinfo support

On Thu, Nov 16, 2017 at 09:27:52AM -0500, Marc-André Lureau wrote: Hi - Original Message - On Mon, Nov 06, 2017 at 01:09:09PM +0100, marcandre.lur...@redhat.com wrote: >From: Marc-André Lureau > >Starting from qemu 2.11, the `-device vmcoreinfo` will

Re: [libvirt] [PATCH 09/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PL011

On Thu, Nov 16, 2017 at 03:53:42PM +0100, Andrea Bolognani wrote: > On Thu, 2017-11-16 at 14:56 +0100, Pavel Hrdina wrote: > > Here the name "pl011" is even worse than "spapr-vty". It's a device > > name and there is also "pl022" (probably not supported by QEMU). The > > bus name is APB

Re: [libvirt] [PATCH 09/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PL011

On Thursday, 16 November 2017 14:56:32 CET Pavel Hrdina wrote: > How about we introduce another attribute/element that would specify the > exact model of the serial device and it would be optional, libvirt would > be able to choose the model if none is specified. Can you please provide an example

Re: [libvirt] [PATCH 07/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_SPAPR

On Thu, Nov 16, 2017 at 03:44:57PM +0100, Andrea Bolognani wrote: > On Thu, 2017-11-16 at 14:22 +0100, Pavel Hrdina wrote: > > On Wed, Nov 15, 2017 at 12:50:10PM +0100, Andrea Bolognani wrote: > > > We can finally introduce a specific target type for the spapr-vty > > > device used by pSeries

Re: [libvirt] [PATCH 09/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PL011

On Thu, 2017-11-16 at 14:56 +0100, Pavel Hrdina wrote: > Here the name "pl011" is even worse than "spapr-vty". It's a device > name and there is also "pl022" (probably not supported by QEMU). The > bus name is APB (Advanced Peripheral Bus). [1] [2] QEMU has pl031 and pl061 devices in addition

Re: [libvirt] [PATCH 07/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_SPAPR

On Thu, 2017-11-16 at 14:22 +0100, Pavel Hrdina wrote: > On Wed, Nov 15, 2017 at 12:50:10PM +0100, Andrea Bolognani wrote: > > We can finally introduce a specific target type for the spapr-vty > > device used by pSeries guests, which means isa-serial will no longer > > show up to confuse users. >

Re: [libvirt] [PATCH] RFC: qemu: add vmcoreinfo support

Hi - Original Message - > On Mon, Nov 06, 2017 at 01:09:09PM +0100, marcandre.lur...@redhat.com wrote: > >From: Marc-André Lureau > > > >Starting from qemu 2.11, the `-device vmcoreinfo` will create a fw_cfg > >entry for a guest to store dump details,

Re: [libvirt] [PATCH v2] storage: Resolve storage driver crash

On Thu, Nov 16, 2017 at 09:06:23AM -0500, John Ferlan wrote: Resolve a storage driver crash as a result of a long running storageVolCreateXML when the virStorageVolPoolRefreshThread is run as a result of when a storageVolUpload completed and ran the virStoragePoolObjClearVols without checking if

Re: [libvirt] [PATCH] RFC: qemu: add vmcoreinfo support

On Mon, Nov 06, 2017 at 01:09:09PM +0100, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Starting from qemu 2.11, the `-device vmcoreinfo` will create a fw_cfg entry for a guest to store dump details, necessary to process kernel dump with KASLR enabled

Re: [libvirt] [PATCH 05/14] conf: Introduce VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_NONE

On Thu, 2017-11-16 at 14:08 +0100, Pavel Hrdina wrote: > On Thu, Nov 16, 2017 at 02:00:24PM +0100, Andrea Bolognani wrote: > > On Thu, 2017-11-16 at 12:30 +0100, Pavel Hrdina wrote: > > > > @@ -9143,6 +9143,14 @@ qemuChrIsPlatformDevice(const virDomainDef *def, > > > > return true; >

[libvirt] [PATCH v2] storage: Resolve storage driver crash

Resolve a storage driver crash as a result of a long running storageVolCreateXML when the virStorageVolPoolRefreshThread is run as a result of when a storageVolUpload completed and ran the virStoragePoolObjClearVols without checking if the creation code was currently processing a buildVol after

Re: [libvirt] Redesigning Libvirt: Adopting use of a safe language

On Tue, Nov 14, 2017 at 17:27:01 +, Daniel Berrange wrote: > The Problem(s) > == Note at first: This is a personal opinion. I'm not discrediting any advantages a different language might have in technical sense. I'm against this. Go is a utterly ugly language. It looks as the

Re: [libvirt] [PATCH 09/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PL011

On Wed, Nov 15, 2017 at 12:50:12PM +0100, Andrea Bolognani wrote: > We can finally introduce a specific target type for the pl011 device > used by mach-virt guests, which means isa-serial will no longer show > up to confuse users. > > We make sure migration works in both directions by

[libvirt] [PATCH 3/3] tools: Enable warnings for more binaries/libs

Because WARN_CFLAGS and COVERAGE_CFLAGS are not set globally, we rely on each binary built to include WARN_CFLAGS/COVERAGE_CFLAGS. But it is easy to forget those - e.g. libvirt_shell.la. However, don't enable WARN_FLAGS (i.e. don't include AM_CFLAGS) for wireshark plugin - parts of that code are

[libvirt] [PATCH 2/3] tools: Set CFLAGS for wireshark properly

We want to set CFLAGS not CPPFLAGS. Signed-off-by: Michal Privoznik --- tools/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/Makefile.am b/tools/Makefile.am index 7513a73ac..a844dcbbc 100644 --- a/tools/Makefile.am +++

[libvirt] [PATCH 0/3] Couple of improvements

*** BLURB HERE *** Michal Privoznik (3): vsh: Make self-test more robust tools: Set CFLAGS for wireshark properly tools: Enable warnings for more binaries/libs tools/Makefile.am | 19 ++- tools/vsh.c | 29 ++--- 2 files changed, 32

[libvirt] [PATCH 1/3] vsh: Make self-test more robust

There are couple of limitations when it comes to option types and flags for the options. For instance, VSH_OT_STRING cannot have VSH_OFLAG_REQ set (commit c7543a728). For some reason this is checked in vshCmddefHelp() but not in vshCmddefCheckInternals(). Signed-off-by: Michal Privoznik

Re: [libvirt] [PATCH 0/2] Fix build with glibc-2.26 and clean up

On 11/16/2017 02:24 PM, Martin Kletzander wrote: > Not pushed as build fix as glibc-2.26 is not that spread and the second > patch is not a build fix. Review should be trivial, so hopefully almost > no review bandwidth goes to waste ;) > > Martin Kletzander (2): > build: Use XDR_CFLAGS in more

Re: [libvirt] [PATCH] qemu: taint domain if virDomainQemuAgentCommand API is used

On Tue, Nov 14, 2017 at 05:30:26PM +0100, Pavel Hrdina wrote: This is similar to the virDomainQemuMonitorCommand API, it can change the domain state in a way that libvirt may not understand. Signed-off-by: Pavel Hrdina --- ACK signature.asc Description: Digital signature

[libvirt] [PATCH 1/2] build: Use XDR_CFLAGS in more places

Since update to glibc-2.26 removed the /usr/include/rpc/rpc.h we used until now, it showed us a problem with not using XDR_CFLAGS properly. On linux that variable has usually -I/usr/include/tirpc because we already probe for it properly, we just don't use it everywhere we need. It is needed by

[libvirt] [PATCH 0/2] Fix build with glibc-2.26 and clean up

Not pushed as build fix as glibc-2.26 is not that spread and the second patch is not a build fix. Review should be trivial, so hopefully almost no review bandwidth goes to waste ;) Martin Kletzander (2): build: Use XDR_CFLAGS in more places tests: Remove pointless _CFLAGS variables

[libvirt] [PATCH 2/2] tests: Remove pointless _CFLAGS variables

If _CFLAGS for a binary is not specified it uses AM_CFLAGS. So doing $binary_CFLAGS = $(AM_CFLAGS) or $binary_CFLAGS = $(AM_CFLAGS) $(something_that_is_already_in_AM_CFLAGS) is pointless. So remove it for cleaner Makefile.am Signed-off-by: Martin Kletzander ---

Re: [libvirt] [PATCH 08/14] qemu: Support usb-serial and pci-serial on pSeries

On Wed, Nov 15, 2017 at 12:50:11PM +0100, Andrea Bolognani wrote: > The existing implementation set the address type for all serial > devices to spapr-vio, which made it impossible to use other devices > such as usb-serial and pci-serial; moreover, some decisions were > made based on the address

Re: [libvirt] [PATCH 07/14] conf: Add VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_SPAPR

On Wed, Nov 15, 2017 at 12:50:10PM +0100, Andrea Bolognani wrote: > We can finally introduce a specific target type for the spapr-vty > device used by pSeries guests, which means isa-serial will no longer > show up to confuse users. > > We make sure migration works in both directions by

Re: [libvirt] [PATCH 02/14] conf, qemu: Use type-aware switches where possible

On Thu, Nov 16, 2017 at 01:01:57PM +0100, Andrea Bolognani wrote: > On Thu, 2017-11-16 at 11:27 +0100, Pavel Hrdina wrote: > > On Wed, Nov 15, 2017 at 12:50:05PM +0100, Andrea Bolognani wrote: > > > The compiler can warn us if we add a value to the > > > virDomainChrSerialTargetType enumeration

Re: [libvirt] [PATCH 05/14] conf: Introduce VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_NONE

On Thu, Nov 16, 2017 at 02:00:24PM +0100, Andrea Bolognani wrote: > On Thu, 2017-11-16 at 12:30 +0100, Pavel Hrdina wrote: > > > @@ -9143,6 +9143,14 @@ qemuChrIsPlatformDevice(const virDomainDef *def, > > > return true; > > > } > > > > > > +/* If we got all the way here and

Re: [libvirt] [PATCH 5/5] libvirtd: Fix order of cleanup processing

On 11/16/2017 02:58 AM, Erik Skultety wrote: > On Fri, Nov 10, 2017 at 05:51:26PM -0500, John Ferlan wrote: >> >> >> On 11/10/2017 10:23 AM, Erik Skultety wrote: >>> On Tue, Nov 07, 2017 at 09:39:56PM -0500, John Ferlan wrote: Current cleanup processing is ad-hoc at best - it's led to a

Re: [libvirt] [PATCH 05/14] conf: Introduce VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_NONE

On Thu, 2017-11-16 at 12:30 +0100, Pavel Hrdina wrote: > > @@ -9143,6 +9143,14 @@ qemuChrIsPlatformDevice(const virDomainDef *def, > > return true; > > } > > > > +/* If we got all the way here and we're still stuck with the default > > + * target type for a serial

[libvirt] [PATCH 11/11] qemu: command: Mark disks as such in qemu

Qemu has now an internal mechanism for locking images to fix specific cases of disk corruption. This requires libvirt to mark the image as shared so that qemu lifts certain restrictions. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1378242 --- src/qemu/qemu_command.c

[libvirt] [PATCH 10/11] qemu: caps: Add capability for 'share-rw' disk option

'share-rw' for the disk device configures qemu to allow concurrent access to the backing storage. --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_2.10.0-gicv2.aarch64.xml | 1 +

[libvirt] [PATCH 09/11] qemu: Disallow pivot of shared disks to unsupported storage

Pivoting to a unsupported storage type might break the assumption that shared disks will not corrupt metadata. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1511480 --- src/qemu/qemu_driver.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH 07/11] qemu: domain: Reject shared disk access if backing format does not support it

Certain disk format drivers in qemu don't allow concurrent acces at the level of the format driver since it would corrupt the metadata. Reject shared access for a disk if the format does not support it. Currently only RAW format supports it since it does not have any metadata. Resolves:

[libvirt] [PATCH 04/11] qemu: domain: Move video device validation into separate function

--- src/qemu/qemu_domain.c | 43 ++- 1 file changed, 26 insertions(+), 17 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 7a369969d..acda06b91 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -3701,6

[libvirt] [PATCH 08/11] qemu: snapshot: Disallow snapshot of unsupported shared disks

Snapshots introduce a new layer into the backing chain, so we need to make sure that we don't use format which does not support being shared. This effectively disables snapshots on disks since only raw format is currently supported. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1511480

[libvirt] [PATCH 05/11] qemu: domain: Refactor domain device validation function

Use a style that will discourage from adding inline checks. --- src/qemu/qemu_domain.c | 79 +- 1 file changed, 52 insertions(+), 27 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index acda06b91..29fdb49d1 100644 ---

[libvirt] [PATCH 06/11] qemu: block: Add function to check if storage source allows concurrent access

Storage source format backing a shared device (e.g. running a cluster filesystem) needs to support the sharing so that metadata are not corrupted. Add a central function for checking this. --- src/qemu/qemu_block.c | 15 +++ src/qemu/qemu_block.h | 3 +++ 2 files changed, 18

[libvirt] [PATCH 03/11] qemu: domain: Move hostdev validation into separate function

--- src/qemu/qemu_domain.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 3755a2390..7a369969d 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -3684,6 +3684,23 @@

[libvirt] [PATCH 02/11] qemu: domain: Despaghetify qemuDomainDeviceDefValidate

Move network device validation into a separate function. --- src/qemu/qemu_domain.c | 158 ++--- 1 file changed, 84 insertions(+), 74 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index cc7596bad..3755a2390 100644 ---

[libvirt] [PATCH 01/11] qemu: Move snapshot disk validation functions into one

Move the code so that both the new image and old image can be verified in the same function. --- src/qemu/qemu_driver.c | 91 -- 1 file changed, 36 insertions(+), 55 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[libvirt] [PATCH 00/11] qemu: Fix disks for new qemu

Introduction of the disk image locking in qemu created a regression where disk shared access with would not work. Since the disk locking is a desired feature, allow libvirt to configure qemu in such way that disks are exempt from write locks. First few patches refactor some stuff so that it's

Re: [libvirt] [PATCH 1/2] storage: Resolve storage driver crash

On Wed, Nov 15, 2017 at 06:21:11PM -0500, John Ferlan wrote: On 11/07/2017 08:38 AM, John Ferlan wrote: On 11/07/2017 04:36 AM, Ján Tomko wrote: On Mon, Nov 06, 2017 at 03:53:08PM -0500, John Ferlan wrote: Resolve a storage driver crash as a result of a long running storageVolCreateXML

Re: [libvirt] [PATCH go-xml] Add support for panic device

On Thu, Nov 16, 2017 at 09:55:26AM +0800, zhenwei.pi wrote: > Add DomainAddressISA for panic device address. > Add DomainPanic. > Add test code. > > Signed-off-by: zhenwei.pi > --- > domain.go | 38 ++ > domain_test.go | 28

Re: [libvirt] PATCH go-xml : add virtualport support

On Wed, Nov 15, 2017 at 11:55:36AM +, Karol Czeryna wrote: > Hi guys! > > Working with terraform libvirt plugin I discovered lack of openvswitch > support - but in libvirt-go there is no support for virtualport entry.. this > patch adds virtualport support. Reviewed-by: Daniel P. Berrange

Re: [libvirt] [PATCH go-xml] Support network backed serial interfaces

On Tue, Nov 14, 2017 at 01:57:53PM +0100, Jeroen Simonetti wrote: > Adds network backing for a DomainChardevSource and > protocol selection for serial device of type tcp. > > Signed-off-by: Jeroen Simonetti > --- > domain.go | 26 +- >

Re: [libvirt] [PATCH 13/14] qemu: switch s390/s390x default console back to serial

Andrea Bolognani [2017-11-15, 12:50PM +0100]: > From: Pino Toscano > > Now that and on s390/s390x behave a bit more like the > other architectures, remove this extra differentation, and use sclp > console by default for new guests. New virtio

Re: [libvirt] [PATCH 12/14] conf: convert sclp/sclplm as

Andrea Bolognani [2017-11-15, 12:50PM +0100]: > From: Pino Toscano > > In case we are allowed to break the ABI of a s390/s390x guest, then > convert the first sclp/sclplm console from to , just > like it is done on other architectures. > >

Re: [libvirt] [PATCH 02/14] conf, qemu: Use type-aware switches where possible

On Thu, 2017-11-16 at 11:27 +0100, Pavel Hrdina wrote: > On Wed, Nov 15, 2017 at 12:50:05PM +0100, Andrea Bolognani wrote: > > The compiler can warn us if we add a value to the > > virDomainChrSerialTargetType enumeration but forget to handle > > it properly in the code. Let's take advantage of

Re: [libvirt] [PATCH 03/14] qemu: Introduce qemuDomainChrDefPostParse()

On Thu, 2017-11-16 at 11:30 +0100, Pavel Hrdina wrote: > > @@ -4096,13 +4109,6 @@ qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr > > dev, > > } > > } > > > > -/* set the default console type for S390 arches */ > > -if (dev->type == VIR_DOMAIN_DEVICE_CHR && > > -

Re: [libvirt] [PATCH 06/14] conf: Drop virDomainChrDeviceType.targetTypeAttr

On Wed, Nov 15, 2017 at 12:50:09PM +0100, Andrea Bolognani wrote: > This attribute was used to decide whether to format the type > attribute of the element, but the logic didn't take into > account all possible cases and as such could lead to unexpected > results. Moreover, it's one more thing to

Re: [libvirt] [PATCH 05/14] conf: Introduce VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_NONE

On Wed, Nov 15, 2017 at 12:50:08PM +0100, Andrea Bolognani wrote: > This is the first step in getting rid of the assumption that > isa-serial is the default target type for serial devices. > > Signed-off-by: Andrea Bolognani > --- > src/conf/domain_conf.c | 8

Re: [libvirt] [PATCH 04/14] conf: Run devicePostParse() again for the first serial device

On Wed, Nov 15, 2017 at 12:50:07PM +0100, Andrea Bolognani wrote: > The devicePostParse() callback is invoked for all devices so that > drivers have a chance to set their own specific values; however, > virDomainDefAddImplicitDevices() runs *after* the devicePostParse() > callbacks have been

Re: [libvirt] [PATCH 03/14] qemu: Introduce qemuDomainChrDefPostParse()

On Wed, Nov 15, 2017 at 12:50:06PM +0100, Andrea Bolognani wrote: > Having a separate function for char device handling is better than > adding even more code to qemuDomainDeviceDefPostParse(). > > Signed-off-by: Andrea Bolognani > --- > src/qemu/qemu_domain.c | 25

Re: [libvirt] [PATCH 02/14] conf, qemu: Use type-aware switches where possible

On Wed, Nov 15, 2017 at 12:50:05PM +0100, Andrea Bolognani wrote: > The compiler can warn us if we add a value to the > virDomainChrSerialTargetType enumeration but forget to handle > it properly in the code. Let's take advantage of that. > > This commit is best viewed with 'git diff -w'. This

Re: [libvirt] [PATCH 01/14] qemu: Add QEMU_CAPS_DEVICE_SPAPR_VTY

On Wed, Nov 15, 2017 at 12:50:04PM +0100, Andrea Bolognani wrote: > Up until now we assumed the spapr-vty device would always be > present, which is not very nice. Check for its availability before > using it instead. > > Signed-off-by: Andrea Bolognani > --- >

Re: [libvirt] [PATCH 19/21] tests: Add virresctrltest

On Wed, Nov 15, 2017 at 05:00:34PM -0500, John Ferlan wrote: > > > On 11/13/2017 03:50 AM, Martin Kletzander wrote: > > This test has 2 different uses: > > > > 1) DO_TEST_FREE initializes capabilities from vircaps2xmldata (since it > > exists > > there already) and then requests list of

Re: [libvirt] [PATCH] virsh: fixing wrong datatype of 'set-lifcycle-action' command options.

On 11/16/2017 04:01 AM, Julio Faracco wrote: > The 'set-lifcycle-action' is throwing a weird error after executing it with > the '--help' option. The command output is showing the options 'type' and > 'action' are as optional, but they aren't. Both are required. > > virsh # set-lifecycle-action

[libvirt] [PATCH] qemu: don't goto cleanup when qemuDomainRemoveDevice failed at function qemuProcessUpdateDevices

Function qemuProcessUpdateDevices was called at qemuProcessReconnect when we detach net device lively and killed libvirtd service at middle. qemu detached the device but libvirtd don't save it at runDir. when libvirtd restart, libvirtd will detach net device but qemu will return fail because

Re: [libvirt] [PATCH 17/21] conf: cachetune

On Mon, Nov 13, 2017 at 09:50:32AM +0100, Martin Kletzander wrote: > Signed-off-by: Martin Kletzander > --- > docs/formatdomain.html.in | 24 ++ > docs/schemas/domaincommon.rng | 32 +++ > src/conf/domain_conf.c

  1   2   >