Re: [libvirt] [PATCHv3 0/3] query-cpu-model-baseline QMP command

On 05/02/2018 03:34 PM, Collin Walling wrote: > On 05/02/2018 03:43 AM, Jiri Denemark wrote: >> On Tue, May 01, 2018 at 09:57:08 -0400, John Ferlan wrote: >>> >>> >>> On 04/30/2018 10:55 PM, Chris Venteicher wrote: This is part of resolution of:

Re: [libvirt] [PATCH 0/6] Complete cleanup of domain object usage

ping? Still need review on 1-3, & 6 Tks John On 04/24/2018 08:28 AM, John Ferlan wrote: > This should be the "last time" (famous last words) needing to alter > this processing. I hope to get more than one pair of eyes looking > at the series. I've looked at it long enough to feel comfortable

Re: [libvirt] [PATCH 35/35] tests: qemublock: Test handling of block devices

On 04/25/2018 11:15 AM, Peter Krempa wrote: > Make sure that 'host_device' is generated for type='block'. > > Signed-off-by: Peter Krempa > --- > tests/qemublocktest.c | 2 ++ > tests/qemublocktestdata/xml2json/block-raw-noopts.json | 12

Re: [libvirt] [PATCH] util: Clean up consumers of virJSONValueArraySize

ping? Tks, John On 04/19/2018 05:46 PM, John Ferlan wrote: > Rather than have virJSONValueArraySize return a -1 when the input > is not an array and then splat an error message, let's check for > an array before calling and then change the return to be a size_t > instead of ssize_t. > > That

Re: [libvirt] [PATCH 34/35] tests: qemublock: Test handling of all cache modes

On 04/25/2018 11:15 AM, Peter Krempa wrote: > The test cases would correspond to the following -drive command lines: > > dir-fat-cache.xml: > -drive > file=fat:/var/somefiles,if=none,id=drive-dummy,readonly=on,cache=directsync > -device

Re: [libvirt] [PATCH 33/35] tests: qemublock: Test handling of 'unmap' and 'detect-zeroes' options

On 04/25/2018 11:15 AM, Peter Krempa wrote: > The test cases would correspond to the following -drive command lines: > > file-backing_basic-detect.xml: > -drive > file=/var/lib/libvirt/images/a,format=qcow,if=none,id=drive-dummy,detect-zeroes=on > -device

Re: [libvirt] [PATCH 32/35] tests: qemublock: Add test combining authentication and encryption

On 04/25/2018 11:15 AM, Peter Krempa wrote: > iscsi and rbd support authentication of the connection. Combine it with > encryption of qcow2. > > The top level disk image would generate the following '-drive' cmdline: > > -drive

Re: [libvirt] [PATCH 31/35] tests: qemublock: basic qcow2 tests

On 04/25/2018 11:15 AM, Peter Krempa wrote: > Add tests for backing chain handling, including a very long chain which > is fully specified in the XML and an unterminated chain. > > The top level disk image would generate the following '-drive': > > file-qcow2-backing-chain-encryption.xml: >

Re: [libvirt] [PATCH 30/35] tests: qemublock: Add test for raw luks disk format

On 04/25/2018 11:15 AM, Peter Krempa wrote: > Apart from adding test data add a function which sets up fake secrets > for the test. > > The top level disk image would generate the following '-drive' cmdline: > > -drive >

Re: [libvirt] [PATCH 29/35] tests: qemublock: Add test cases for 'aio' options of 'file' storage

On 04/25/2018 11:15 AM, Peter Krempa wrote: > Test that the 'aio' option is applied correctly for the 'file' protocol > backend and across the backing chain. > > The top level disk image would generate the following '-drive' cmdline: > > file-backing_basic-aio_threads: > -drive >

Re: [libvirt] [PATCH 28/35] tests: qemublock: Add test-case for the 'vvfat' driver in qemu

On 04/25/2018 11:15 AM, Peter Krempa wrote: > Test mapping of the 'FAT' disk format to 'vvfat' in qemu. > > The top level disk image would generate the following '-drive' cmdline: > > dir-fat-readonly.xml: > -drive file=fat:/var/somefiles,if=none,id=drive-dummy,readonly=on > -device

Re: [libvirt] [PATCH 26/35] tests: qemublock: Add tests for all other format without special options

On 04/25/2018 11:15 AM, Peter Krempa wrote: > Similarly to the 'raw' case add tests for bochs, cloop, dmg, ploop, vdi > vhd, and vpc. Covering all supproted non-backing formats. supported > > Note that the JSON name for 'ploop' maps to 'parallels' and 'vhd' maps > to 'vhdx'. > > Files added

Re: [libvirt] [PATCH 27/35] tests: qemublock: Add tests for basic backing chain formats

On 04/25/2018 11:15 AM, Peter Krempa wrote: > Formats supporting backing chain such as qed, vmdk, don't have any other > parameters than the backing store and 'qcow' has only encryption params > which will be tested extra. Add this test case so they are covered since > any further test cases

Re: [libvirt] [PATCH 25/35] tests: qemublock: Add basic 'raw' file test

On 04/25/2018 11:15 AM, Peter Krempa wrote: > Test the JSON props generator with a very simple 'raw' image with no > other options. The node-names for the image are 31 bytes long so that we > validate our node name detector. > > The top level disk image would generate the following '-drive'

Re: [libvirt] [PATCH 24/35] tests: qemublock: Add testing of blockdev JSON property generator

On 04/25/2018 11:15 AM, Peter Krempa wrote: > Add a test infrastructure that will allow testing the JSON object > generator used for generating data to use with blockdev-add. > > The resulting disk including the backing chain is validated to conform > to the QAPI schema and the expected output

Re: [libvirt] [PATCH 23/35] qemu: domain: Tolerate NULL 'cfg' in qemuDomainPrepareDiskSourceChain

On 04/25/2018 11:15 AM, Peter Krempa wrote: > The function will be reused in the test code where we don't care much > that the gluster debug level can't be populated from the qemu config. > > Set the level only when 'cfg' is passed. > > Signed-off-by: Peter Krempa > --- >

Re: [libvirt] [PATCH 22/35] qemu: domain: Export qemuDomainDeviceDefValidateDisk

On 04/25/2018 11:15 AM, Peter Krempa wrote: > It will be used in the qemublocktest. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_domain.c | 2 +- > src/qemu/qemu_domain.h | 3 +++ > 2 files changed, 4 insertions(+), 1 deletion(-) > Reviewed-by: John Ferlan

Re: [libvirt] [PATCH 21/35] tests: Makefile: Sanitize entry for qemublocktest

On 04/25/2018 11:15 AM, Peter Krempa wrote: > Remove gnulib from _LDADD and move LDADDS to replace it. Also reformat > the _SOURCES so that they can be easily extended. > > Signed-off-by: Peter Krempa > --- > tests/Makefile.am | 8 +--- > 1 file changed, 5

Re: [libvirt] [PATCH 19/35] qemu: block: Add support for creating 'format' layer for blockdev-add

On 04/25/2018 11:15 AM, Peter Krempa wrote: > When using blockdev-add and friends, libvirt will need to create also > properties for the qcow2/raw/... format handler in qemu. This patch adds > the infrastructure and implements all formats known to libvirt including > all properties which are

Re: [libvirt] [PATCH 20/35] tests: qemublock: Rename variables in anticipation of new tests

On 04/25/2018 11:15 AM, Peter Krempa wrote: > New tests will add new data structures so rename the 'data' structure. > > Signed-off-by: Peter Krempa > --- > tests/qemublocktest.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > Reviewed-by: John Ferlan

Re: [libvirt] [PATCH 18/35] qemu: block: Always set discard for storage nodes

On 05/02/2018 03:39 PM, John Ferlan wrote: > > > On 04/25/2018 11:15 AM, Peter Krempa wrote: >> Enabling discard for the storage node allows the format drivers to >> discard snapshots and other things, while configuration of the format >> layer actually decides whether to actually discard data

Re: [libvirt] [PATCH 18/35] qemu: block: Always set discard for storage nodes

On 04/25/2018 11:15 AM, Peter Krempa wrote: > Enabling discard for the storage node allows the format drivers to > discard snapshots and other things, while configuration of the format > layer actually decides whether to actually discard data on request from > the host. > > Signed-off-by: Peter

Re: [libvirt] [PATCHv3 0/3] query-cpu-model-baseline QMP command

On 05/02/2018 03:43 AM, Jiri Denemark wrote: > On Tue, May 01, 2018 at 09:57:08 -0400, John Ferlan wrote: >> >> >> On 04/30/2018 10:55 PM, Chris Venteicher wrote: >>> This is part of resolution of: >>> https://bugzilla.redhat.com/show_bug.cgi?id=1511999 >>> >>> Signed-off-by: Chris Venteicher

Re: [libvirt] [PATCH 17/35] qemu: block: Format 'read-only' attribute for JSON disk protocol

On 04/25/2018 11:15 AM, Peter Krempa wrote: > This will be required when doing blockdev-add to conform with the > approach qemu would chose to create the disks. s/would chose/chooses/ If 'would' does stay, then it's still choose as chose would be past tense. > > Signed-off-by: Peter Krempa

Re: [libvirt] [PATCH 16/35] qemu: block: Format cache modes for disk storage backends

On 04/25/2018 11:15 AM, Peter Krempa wrote: > When used directly with blockdev-add/-blockdev the cache mode will need > to be specified directly for every image rather than just for the disk > itself. This implements the backing options 'direct' and 'no-flush'. > > Signed-off-by: Peter Krempa

Re: [libvirt] [PATCH 15/35] qemu: block: Validate node-names for use with qemu

On 04/25/2018 11:15 AM, Peter Krempa wrote: > qemu declares node-name as a 32 byte buffer and silently truncates > anything longer than that. This is unacceptable for libvirt, so we need > to make sure that we won't ever supply a node-name exceeding 31 chars. > > Add a function which will do

Re: [libvirt] [PATCH 14/35] qemu: block: Propagate 'legacy' parameter when formatting disk backing

On 04/25/2018 11:15 AM, Peter Krempa wrote: > The gluster protocol in qemu uses two styles, one of which is legacy and > not covered by the QAPI schema. To allow using of the new style in the > blockdev-add code, add a parameter for > qemuBlockStorageSourceGetBackendProps which will switch

Re: [libvirt] [PATCH 13/35] qemu: block: Properly handle block storage in JSON generator

On 04/25/2018 11:15 AM, Peter Krempa wrote: > Block storage should actually be passed to qemu via 'host_device' or > 'host_cdrom' according to the device type. There were no users of this > behaviour so we thankfully can change it. > > Signed-off-by: Peter Krempa > --- >

Re: [libvirt] [PATCH 12/35] qemu: domain: Store whether a virStorageSource is a host CDROM drive

On 04/25/2018 11:15 AM, Peter Krempa wrote: > Use virFileIsCdrom to detect whether a block device is a cdrom drive and > store it in virStorageSource. This will be necessary to correctly create > the 'host_cdrom' backend in qemu when using -blockdev. > > We assume that host_cdrom makes only

Re: [libvirt] [PATCH 11/35] util: file: Add helper to determine whether a path is a CDROM

On 04/25/2018 11:15 AM, Peter Krempa wrote: > Add detection mechanism which will allow to check whether a path to a > block device is a physical CDROM drive. This will be useful once we will > need to pass it to hypervisors. > > The linux implementation uses an ioctl to do the detection, while

Re: [libvirt] [PATCH] Qemu driver: Support network-backed pflash disks.

On Sat, Apr 28, 2018 at 1:11 AM, John Ferlan wrote: > > > On 04/20/2018 04:59 AM, Prerna Saxena wrote: > > So far libvirt domain XML only allows local filepaths that can be > > used to specify a loader element or its matching NVRAM disk. > > Given that Vms may themselves move

Re: [libvirt] [PATCH v4] tests/Makefile.am: use LIBTOOL variable instead of hardcoded name

On Wed, 2018-05-02 at 17:54 +0100, Maciej Wolny wrote: > Fixes "can't find libtool" error when running valgrind checks. > > Signed-off-by: Maciej Wolny > --- > tests/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[libvirt] [PATCH v4] tests/Makefile.am: use LIBTOOL variable instead of hardcoded name

Fixes "can't find libtool" error when running valgrind checks. Signed-off-by: Maciej Wolny --- tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 7b93fbde6..05db6b119 100644 ---

Re: [libvirt] [PATCH v2 3/8] all: Use realpath() instead of canonicalize_file_name()

On Wednesday, 2 May 2018 18:32:25 CEST Daniel P. Berrangé wrote: > On Mon, Apr 30, 2018 at 06:52:58PM +0200, Andrea Bolognani wrote: > > The latter is a glibc extension that's not available on other > > operating systems, notably FreeBSD. > > > > So far we have worked around the issue through

Re: [libvirt] [PATCH v2 3/8] all: Use realpath() instead of canonicalize_file_name()

On Wed, 2018-05-02 at 17:32 +0100, Daniel P. Berrangé wrote: > On Mon, Apr 30, 2018 at 06:52:58PM +0200, Andrea Bolognani wrote: > > The latter is a glibc extension that's not available on other > > operating systems, notably FreeBSD. > > > > So far we have worked around the issue through gnulib,

Re: [libvirt] [PATCH v2 3/8] all: Use realpath() instead of canonicalize_file_name()

On Wed, May 02, 2018 at 05:32:25PM +0100, Daniel P. Berrangé wrote: > On Mon, Apr 30, 2018 at 06:52:58PM +0200, Andrea Bolognani wrote: > > The latter is a glibc extension that's not available on other > > operating systems, notably FreeBSD. > > > > So far we have worked around the issue through

Re: [libvirt] [PATCH v2 3/8] all: Use realpath() instead of canonicalize_file_name()

On Mon, Apr 30, 2018 at 06:52:58PM +0200, Andrea Bolognani wrote: > The latter is a glibc extension that's not available on other > operating systems, notably FreeBSD. > > So far we have worked around the issue through gnulib, but that > makes it difficult to use mocking in our test suite, so

Re: [libvirt] [PATCH v3] tests/Makefile.am: use LIBTOOL variable instead of hardcoded name

On 02/05/18 17:15, Andrea Bolognani wrote: > On Wed, 2018-05-02 at 12:24 +0200, Andrea Bolognani wrote: >> On Tue, 2018-05-01 at 14:49 +0100, Maciej Wolny wrote: >>> Fixes "can't find libtool" error when running valgrind checks. >>> --- >>> tests/Makefile.am | 2 +- >>> 1 file changed, 1

Re: [libvirt] [PATCH v3] tests/Makefile.am: use LIBTOOL variable instead of hardcoded name

On Wed, 2018-05-02 at 12:24 +0200, Andrea Bolognani wrote: > On Tue, 2018-05-01 at 14:49 +0100, Maciej Wolny wrote: > > Fixes "can't find libtool" error when running valgrind checks. > > --- > > tests/Makefile.am | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

[libvirt] [PATCH 10/8] tests: Drop DO_TEST_LINUX()

Now that mocking NUMA information works on FreeBSD, there are no longer any test cases that need to be restricted to Linux only. Signed-off-by: Andrea Bolognani --- tests/qemuxml2argvtest.c | 46 +++--- 1 file changed, 15

[libvirt] [PATCH 9/8] tests: Extend NUMA mocking

While the current amount of mocking works just fine on most of our target platforms, it somehow causes issues when using Clang on FreeBSD. Work around the issue by mocking a couple more functions. It's not pretty, but it makes qemuxml2argvtest pass on FreeBSD at long last. Signed-off-by: Andrea

[libvirt] [dbus PATCH] Implement SetGuestVcpus method for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Domain.xml | 7 + src/domain.c| 62 + 2 files changed, 69 insertions(+) diff --git a/data/org.libvirt.Domain.xml b/data/org.libvirt.Domain.xml index

[libvirt] Release of libvirt-4.3.0

As planned the release is done, it is tagged into git and I pushed signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ I also pushed a release of the python bindings libvirt-python 4.3.0 at ftp://libvirt.org/libvirt/python As usual this release is a balance of

Re: [libvirt] [PATCH 02/35] qemu: domain: Format storage source node names into private data

On 05/02/2018 05:51 AM, Peter Krempa wrote: > On Tue, May 01, 2018 at 20:06:43 -0400, John Ferlan wrote: >> >> >> On 04/25/2018 11:15 AM, Peter Krempa wrote: >>> Save and restore node names if we know them in the status XML so that we >>> don't need to recalculate them or don't lose them in some

[libvirt] [GSoC] Introduction - nodejs bindings

Hi all, As a quick introduction, I'm Ramy Elkest, a student at Georgia Tech and one of the lucky ones selected by libvirt for this year's Google Summer of Code. During the next months I'll be working with my mentors Martin Kletzander and Erik Skultety to introduce nodejs to libvirt's family of

Re: [libvirt] [PATCH] conf: remove unused VIR_DOMAIN_FS_RAM_DEFAULT_USAGE

On Wed, May 02, 2018 at 14:46:33 +0200, Ján Tomko wrote: > Unused since its introduction in commit <76b644c>. > > Signed-off-by: Ján Tomko > --- > src/conf/domain_conf.h | 3 --- > 1 file changed, 3 deletions(-) ACK signature.asc Description: PGP signature -- libvir-list

[libvirt] [PATCH] Makefile: fix typo

s/atttribute/attribute/ Signed-off-by: Ján Tomko --- Pushed as trivial. src/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 0d8d380df1..0c380780c3 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@

[libvirt] [PATCH] conf: remove unused VIR_DOMAIN_FS_RAM_DEFAULT_USAGE

Unused since its introduction in commit <76b644c>. Signed-off-by: Ján Tomko --- src/conf/domain_conf.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 3c7eccb8ca..3e135c6364 100644 --- a/src/conf/domain_conf.h +++

Re: [libvirt] [PATCH v5 0/2] Avoid slash characteres for 'domrename' command.

Thanks, John! -- Julio Cesar Faracco 2018-05-01 19:56 GMT-03:00 John Ferlan : > > > On 05/01/2018 11:56 AM, Julio Faracco wrote: >> The commits enhace the 'domrename' command of QEMU and Test drivers to >> avoid slashes chars inside the new domain name. >> >> Julio Faracco

Re: [libvirt] [PATCH] docs: rng: Add missing element to panic device

Please use 'schema' instead of 'rng'. On Wed, May 02, 2018 at 13:59:06 +0200, Erik Skultety wrote: > Panic device has 2 optional sub-elements - and the > order of which should be interchangeable in the XML. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1456165 > > Signed-off-by:

[libvirt] [PATCH] docs: rng: Add missing element to panic device

Panic device has 2 optional sub-elements - and the order of which should be interchangeable in the XML. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1456165 Signed-off-by: Erik Skultety --- docs/schemas/domaincommon.rng | 14 -- 1 file changed, 8

Re: [libvirt] [PATCH] qemu: add sdl opengl support

On Wed, May 02, 2018 at 11:48:24AM +0100, Maciej Wolny wrote: > On 02/05/18 08:13, Daniel P. Berrangé wrote: > > On Tue, May 01, 2018 at 08:22:45PM +0100, Maciej Wolny wrote: > > > Add SDL graphics gl attribute, modify the domain XML schema, add a > > > test, modify the documentation to include

Re: [libvirt] [PATCH] qemu: add sdl opengl support

On 02/05/18 08:13, Daniel P. Berrangé wrote: On Tue, May 01, 2018 at 08:22:45PM +0100, Maciej Wolny wrote: Add SDL graphics gl attribute, modify the domain XML schema, add a test, modify the documentation to include the new option. Signed-off-by: Maciej Wolny ---

[libvirt] [PATCH] travis: Print test log file from distcheck as well

Since we started using `make distcheck` in travis, the part that's printing the tests/test-suite.log file is rather pointless. Let's check for both known locations (keeping the previous one there on purpose) so that the output is usable again. Signed-off-by: Martin Kletzander

[libvirt] [dbus PATCH v2 5/9] Implement NodeGetMemoryStats method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 44 2 files changed, 50 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index

[libvirt] [dbus PATCH v2 8/9] Implement NodeSuspendForDuration method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 8 src/connect.c| 42 ++ 2 files changed, 50 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index

[libvirt] [dbus PATCH v2 4/9] Implement NodeGetMemoryParameters method in Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 38 ++ 2 files changed, 44 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index

[libvirt] [dbus PATCH v2 3/9] Implement NodeGetInfo method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 5 + src/connect.c| 25 + tests/test_connect.py| 4 3 files changed, 34 insertions(+) diff --git a/data/org.libvirt.Connect.xml

[libvirt] [dbus PATCH v2 7/9] Implement NodeSetMemoryParameters method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 31 +++ 2 files changed, 37 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 610dda7..e46d28d

[libvirt] [dbus PATCH v2 1/9] Implement NodeGetCPUStats method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 7 +++ src/connect.c| 41 + tests/test_connect.py| 4 3 files changed, 52 insertions(+) diff --git a/data/org.libvirt.Connect.xml

[libvirt] [dbus PATCH v2 9/9] Implement NodeGetCPUMap method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 6 ++ src/connect.c| 35 +++ tests/test_connect.py| 4 3 files changed, 45 insertions(+) diff --git a/data/org.libvirt.Connect.xml

[libvirt] [dbus PATCH v2 2/9] Implement NodeGetFreeMemory method for Connect Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 5 + src/connect.c| 24 tests/test_connect.py| 4 3 files changed, 33 insertions(+) diff --git a/data/org.libvirt.Connect.xml

[libvirt] [dbus PATCH v2 6/9] Implement NodeGetSecurityModel method for Domain Interface

Signed-off-by: Katerina Koukiou --- data/org.libvirt.Connect.xml | 5 + src/connect.c| 23 +++ 2 files changed, 28 insertions(+) diff --git a/data/org.libvirt.Connect.xml b/data/org.libvirt.Connect.xml index 4a1ee4a..610dda7 100644

[libvirt] [dbus PATCH v2 0/9] NodeAPIs for Connect Interface

Changes from v1: * Added tests were the test driver exported the relevant API * Removed NodeGetCellsFreeMemory which will be sent in seperate patchset * Adjusted other comments from review Katerina Koukiou (9): Implement NodeGetCPUStats method for Connect Interface Implement NodeGetFreeMemory

Re: [libvirt] [PATCH v3] tests/Makefile.am: use LIBTOOL variable instead of hardcoded name

On Tue, 2018-05-01 at 14:49 +0100, Maciej Wolny wrote: > Fixes "can't find libtool" error when running valgrind checks. > --- > tests/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/Makefile.am b/tests/Makefile.am > index 7b93fbde6..05db6b119 100644 >

Re: [libvirt] [PATCH 02/35] qemu: domain: Format storage source node names into private data

On Tue, May 01, 2018 at 20:06:43 -0400, John Ferlan wrote: > > > On 04/25/2018 11:15 AM, Peter Krempa wrote: > > Save and restore node names if we know them in the status XML so that we > > don't need to recalculate them or don't lose them in some cases. > > > > Signed-off-by: Peter Krempa

Re: [libvirt] [PATCH 01/35] storage: Properly track that backing chain members are readonly

On Tue, May 01, 2018 at 20:06:40 -0400, John Ferlan wrote: > > > On 04/25/2018 11:15 AM, Peter Krempa wrote: > > Everything besides the top of the chain is readonly. Track this when > > parsing the XML and detecting the chain from the disk. Also fix the > > state when taking snapshots. > > > >

Re: [libvirt] [PATCH 00/14] nwfilter: refactor the driver to make it independent of virt drivers

On Mon, Apr 30, 2018 at 12:12:24PM -0400, Laine Stump wrote: > First - this is a *great* idea, and we should do something similar to > the network driver (keep track of all the connections to each network so > they can be re-connected when a network is stopped/started). Yes, this nwfilter

Re: [libvirt] [PATCH] news: Mention changes TLS non-shared-storage migration

On Wed, May 02, 2018 at 09:44:08 +0200, Peter Krempa wrote: > Signed-off-by: Peter Krempa > --- > docs/news.xml | 12 > 1 file changed, 12 insertions(+) > > diff --git a/docs/news.xml b/docs/news.xml > index caeda159a8..af57751e0c 100644 > --- a/docs/news.xml >

Re: [libvirt] [PATCH 2/2] tests: rewrite socket to do something sensible and reliable

On Tue, 2018-05-01 at 12:06 +0100, Daniel P. Berrangé wrote: > The current socket test is rather crazy in that it sets up a server > listening for sockets and then runs a client connect call, relying on > the fact that the kernel will accept this despite the application > not having called

Re: [libvirt] [PATCH 09/35] qemu: block: Add support for accessing directories via the 'vvfat' driver

On Tue, May 01, 2018 at 20:21:11 -0400, John Ferlan wrote: > > > On 04/25/2018 11:15 AM, Peter Krempa wrote: > > Handle VIR_STORAGE_TYPE_DIR in qemuBlockStorageSourceGetBackendProps so > > that a 'vvfat' driver is used, which emulates a FAT filesystem > > containing the folders. > > > > qemu

Re: [libvirt] [PATCH 1/2] tests: merge code for UNIX and TCP socket testing

On Tue, 2018-05-01 at 12:06 +0100, Daniel P. Berrangé wrote: > The test code for UNIX and TCP sockets will need to be rewritten and > extended later, and will benefit from code sharing. > > Signed-off-by: Daniel P. Berrangé > --- > tests/virnetsockettest.c | 120 >

Re: [libvirt] [PATCH 11/35] util: file: Add helper to determine whether a path is a CDROM

On Tue, May 01, 2018 at 20:25:09 -0400, John Ferlan wrote: > > > On 04/25/2018 11:15 AM, Peter Krempa wrote: > > Add detection mechanism which will allow to check whether a path to a > > block device is a physical CDROM drive. This will be useful once we will > > need to pass it to hypervisors.

Re: [libvirt] [PATCHv3 0/3] query-cpu-model-baseline QMP command

On Tue, May 01, 2018 at 09:57:08 -0400, John Ferlan wrote: > > > On 04/30/2018 10:55 PM, Chris Venteicher wrote: > > This is part of resolution of: > > https://bugzilla.redhat.com/show_bug.cgi?id=1511999 > > > > Signed-off-by: Chris Venteicher > > > > diff to v1: > > -

[libvirt] [PATCH] news: Mention changes TLS non-shared-storage migration

Signed-off-by: Peter Krempa --- docs/news.xml | 12 1 file changed, 12 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index caeda159a8..af57751e0c 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -157,6 +157,18 @@ + +

[libvirt] ZFS backend does fail if used on non top level pools

Hi, by discussing on bug [1] we found an issue in the ZFS storage backend. When one defines a zfs pool through XML (virsh pool-create --build) a top level ZFS pool will be created and works fine. The virsh pool-define-as counterpart to this is: $ fallocate -l 100M /tmp/Mzfs $ sudo zpool create

Re: [libvirt] [PATCH] qemu: add sdl opengl support

On Tue, May 01, 2018 at 08:22:45PM +0100, Maciej Wolny wrote: > Add SDL graphics gl attribute, modify the domain XML schema, add a > test, modify the documentation to include the new option. > > Signed-off-by: Maciej Wolny > --- > docs/schemas/domaincommon.rng