Re: [libvirt] Matching the type of mediated devices in the migration

2018-08-22 Thread Alex Williamson
On Thu, 23 Aug 2018 04:02:43 + "Tian, Kevin" wrote: > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Thursday, August 23, 2018 11:47 AM > > > > On Wed, 22 Aug 2018 02:30:12 + > > "Tian, Kevin" wrote: > > > > > > From: Alex Williamson

[libvirt] [PATCH] Add virNetlinkNewLink for simplifying virNetDev*Create

2018-08-22 Thread Shi Lei
This patch adds virNetlinkNewLink for simplifying virNetDevMacVLanCreate and virNetDevBridgeCreate. Signed-off-by: Shi Lei --- src/libvirt_private.syms| 1 + src/util/virnetdevbridge.c | 73 +++ src/util/virnetdevmacvlan.c | 137

Re: [libvirt] Matching the type of mediated devices in the migration

2018-08-22 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Thursday, August 23, 2018 11:47 AM > > On Wed, 22 Aug 2018 02:30:12 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > Sent: Wednesday, August 22, 2018 10:08 AM > > > > > > On

Re: [libvirt] Matching the type of mediated devices in the migration

2018-08-22 Thread Alex Williamson
On Wed, 22 Aug 2018 02:30:12 + "Tian, Kevin" wrote: > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Wednesday, August 22, 2018 10:08 AM > > > > On Wed, 22 Aug 2018 01:27:05 + > > "Tian, Kevin" wrote: > > > > > > From: Wang, Zhi A > > > > Sent: Wednesday,

Re: [libvirt] [PATCH] Take DryRun code out of virCommand* code flow

2018-08-22 Thread 石磊
>On Wed, Aug 22, 2018 at 11:37:34AM +0800, Shi Lei wrote: >> Since dry-run of cmd is just for tests now, it would be better to remove >> dry-run code and move them to testutils. Then the code flow in virCommand* >> could be more general. There are 3 steps in this patch: >> 1. Introduce a new

Re: [libvirt] [PATCH] util: eventpoll: Survive EBADF on macOS

2018-08-22 Thread Roman Bolshakov
On Wed, Aug 22, 2018 at 10:41:18AM +0100, Daniel P. Berrangé wrote: > I don't think we should go through the dispatch code when > we get EBADF, as the contents of the 'revents' fields are > undefined after we get an error. > > We should jump straight to the end where we have > "eventLoop.running

[libvirt] [PATCH] nwfilter: Add extra verbiage for binding create/delete

2018-08-22 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1609454 Add some cautionary words related to the create and delete NWFilter Binding use cases and possible issues that may result to the virsh nwfilter-binding-{create|delete} descriptions and the virNWFilterBinding{CreateXML|Delete) API descriptions.

[libvirt] [PATCH] nwfilter: Handle libvirtd restart if nwfilter binding deleted

2018-08-22 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1607202 It's stated that if the admin wants to shoot themselves in the foot by removing the nwfilter binding while the domain is running we will certainly allow that. However, in doing so we also run the risk that a libvirtd restart will cause the

[libvirt] [PATCH] qemu: fix error message on directory creation

2018-08-22 Thread Eric Blake
Minor copy-and-paste bug present since commit 462c74c3, in Apr 2010. Signed-off-by: Eric Blake --- Pushing this under the trivial rule. src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index

[libvirt] proposal: file renames for consistency

2018-08-22 Thread Eric Blake
We have an inconsistent mix of multi-word file names that use dash vs. underscore to separate those words. $ git ls-files '**/*_*' | wc 24972497 146485 $ git ls-files '**/*-*' | wc 81478147 26 Some of those are overlaps (meaning we can't make up our minds), such as:

[libvirt] libvirt and virt-manager - Unable to complete install: 'internal error: unsupported input bus usb'

2018-08-22 Thread Eduardo Lúcio Amorim Costa
I'm trying create a virtual machine using Xen as hypervisor and virt-manager (libvirt) as the management module. When trying to create the virtual machine I am getting the following error: " Unable to complete install: 'internal error: unsupported input bus usb' " ERROR DETAILS: Unable to

[libvirt] [PATCH v4 3/3] vsh: Added tests

2018-08-22 Thread Simon Kobyda
For now, there are 9 test cases - testVshTableNew: Creating table with empty header - testVshTableHeader: Printing table with/without header - testVshTableRowAppend: Appending row with various number of cells. Only row with same number of cells as in header is accepted. - testUnicode: Printing

[libvirt] [PATCH v4 1/3] vsh: Add API for printing tables.

2018-08-22 Thread Simon Kobyda
It solves problems with alignment of columns. Width of each column is calculated by its biggest cell. Should solve unicode bug. In future, it may be implemented in virsh, virt-admin... This API has 5 public functions: - vshTableNew - adds new table and defines its header - vshTableRowAppend -

[libvirt] [PATCH v4 2/3] virsh: Implement new table API for virsh list

2018-08-22 Thread Simon Kobyda
Instead of printing it straight in virsh, it creates table struct which is filled with header and rows(domains). It allows us to know more about table before printing to calculate alignment right. Signed-off-by: Simon Kobyda --- tests/virshtest.c| 14 ++--

[libvirt] [PATCH v4 0/3] vsh: Introduce new API for printing tables

2018-08-22 Thread Simon Kobyda
Created new API for priting tables, mainly to solve alignment problems. Implemented these test to virsh list. In the future, API may be everywhere in virsh and virt-admin. Also wrote basic tests for the new API, and corrected tests in virshtest which are influenced by implementation of the API in

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 12:49:48PM -0300, Eduardo Habkost wrote: > > The thing that has really tipped my mind this way is that even > > if we provide new device models, mgmt apps will be loathe to > > actually use them because it will prevent live migration of > > those guests to hosts with older

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-22 Thread Eduardo Habkost
On Wed, Aug 22, 2018 at 03:57:20PM +0100, Daniel P. Berrangé wrote: > On Wed, Aug 22, 2018 at 11:18:28AM -0300, Eduardo Habkost wrote: > > On Wed, Aug 22, 2018 at 02:44:40PM +0100, Daniel P. Berrangé wrote: [...] > > > An explicit virtio-transitional device is still two separate > > > devices

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 10:37:12AM -0400, Laine Stump wrote: > On 08/22/2018 09:44 AM, Daniel P. Berrangé wrote: > > Even if someone is willing to implement it in libvirt, we have to > > consider the cost of supporting it in both libvirt and applications > > using libvirt and the complexity it

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 11:18:28AM -0300, Eduardo Habkost wrote: > On Wed, Aug 22, 2018 at 02:44:40PM +0100, Daniel P. Berrangé wrote: > > On Wed, Aug 22, 2018 at 09:54:55AM -0300, Eduardo Habkost wrote: > > > On Wed, Aug 22, 2018 at 01:26:01PM +0100, Daniel P. Berrangé wrote: > > > > On Wed, Aug

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-22 Thread Laine Stump
On 08/22/2018 09:44 AM, Daniel P. Berrangé wrote: > On Wed, Aug 22, 2018 at 09:54:55AM -0300, Eduardo Habkost wrote: >> On Wed, Aug 22, 2018 at 01:26:01PM +0100, Daniel P. Berrangé wrote: >>> On Wed, Aug 22, 2018 at 09:01:35AM -0300, Eduardo Habkost wrote: On Wed, Aug 22, 2018 at 12:36:27PM

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-22 Thread Eduardo Habkost
On Wed, Aug 22, 2018 at 02:44:40PM +0100, Daniel P. Berrangé wrote: > On Wed, Aug 22, 2018 at 09:54:55AM -0300, Eduardo Habkost wrote: > > On Wed, Aug 22, 2018 at 01:26:01PM +0100, Daniel P. Berrangé wrote: > > > On Wed, Aug 22, 2018 at 09:01:35AM -0300, Eduardo Habkost wrote: > > > > On Wed, Aug

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 09:54:55AM -0300, Eduardo Habkost wrote: > On Wed, Aug 22, 2018 at 01:26:01PM +0100, Daniel P. Berrangé wrote: > > On Wed, Aug 22, 2018 at 09:01:35AM -0300, Eduardo Habkost wrote: > > > On Wed, Aug 22, 2018 at 12:36:27PM +0200, Andrea Bolognani wrote: > > > > On Tue,

[libvirt] [PATCH v2 1/3] ui: remove support for GTK2 in favour of GTK3

2018-08-22 Thread Daniel P . Berrangé
GTK2 was deprecated in the 2.12.0 release with: commit b7715af2b31f47060cc5b4be930d16c13be93fa9 Author: Daniel P. Berrange Date: Tue Dec 12 11:34:40 2017 + ui: deprecate use of GTK 2.x in favour of 3.x series The GTK 3.0 release was made in Feb, 2011:

[libvirt] [PATCH v2 3/3] ui: remove support for SDL1.2 in favour of SDL2

2018-08-22 Thread Daniel P . Berrangé
SDL1.2 was deprecated in the 2.12.0 release with: commit e52c6ba34149b4f39c3fd60e59ee32b809db2bfa Author: Daniel P. Berrange Date: Mon Jan 15 14:25:33 2018 + ui: deprecate use of SDL 1.2 in favour of 2.0 series The SDL 2.0 release was made in Aug, 2013:

[libvirt] [PATCH v2 2/3] ui: increase min required GTK3 version to 3.14.0

2018-08-22 Thread Daniel P . Berrangé
Per supported platforms doc[1], the various min GTK3 on relevant distros is: RHEL-7.0: 3.8.8 RHEL-7.2: 3.14.13 RHEL-7.4: 3.22.10 RHEL-7.5: 3.22.26 Debian (Stretch): 3.22.11 Debian (Jessie): 3.14.5 OpenBSD (Ports): 3.22.30 FreeBSD (Ports): 3.22.29 OpenSUSE Leap 15: 3.22.30

[libvirt] [PATCH v2 0/3] ui: remove deprecated UI frontends

2018-08-22 Thread Daniel P . Berrangé
We deprecated GTK2 and SDL1.2 in the 2.12.0 release, so they are able to be removed entirely in the 3.1.0 release. The min GTK3 version can also be bumped up based the distros we aim to support. Note that before this can merge, the openbsd VM test image needs to be updated to have SDL2, as

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-22 Thread Eduardo Habkost
On Wed, Aug 22, 2018 at 01:26:01PM +0100, Daniel P. Berrangé wrote: > On Wed, Aug 22, 2018 at 09:01:35AM -0300, Eduardo Habkost wrote: > > On Wed, Aug 22, 2018 at 12:36:27PM +0200, Andrea Bolognani wrote: > > > On Tue, 2018-08-21 at 14:21 -0400, Laine Stump wrote: > > > > On 08/17/2018 06:35 AM,

Re: [libvirt] [jenkins-ci PATCH v3 02/12] jobs: Remove archive_format from defaults

2018-08-22 Thread Erik Skultety
On Wed, Aug 22, 2018 at 01:12:58PM +0200, Andrea Bolognani wrote: > On Wed, 2018-08-22 at 12:37 +0200, Erik Skultety wrote: > > On Wed, Aug 22, 2018 at 11:44:17AM +0200, Andrea Bolognani wrote: > > > Instead of defining a default and overriding it on a > > > case-by-case basis, always define

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 09:01:35AM -0300, Eduardo Habkost wrote: > On Wed, Aug 22, 2018 at 12:36:27PM +0200, Andrea Bolognani wrote: > > On Tue, 2018-08-21 at 14:21 -0400, Laine Stump wrote: > > > On 08/17/2018 06:35 AM, Andrea Bolognani wrote: > > > > If we decide we want to explicitly spell out

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-22 Thread Eduardo Habkost
On Wed, Aug 22, 2018 at 12:36:27PM +0200, Andrea Bolognani wrote: > On Tue, 2018-08-21 at 14:21 -0400, Laine Stump wrote: > > On 08/17/2018 06:35 AM, Andrea Bolognani wrote: > > > If we decide we want to explicitly spell out the options instead > > > of relying on QEMU changing behavior based on

Re: [libvirt] [PATCH 0/3] qemu: Fix few issues from the -blockdev series

2018-08-22 Thread John Ferlan
On 08/22/2018 07:27 AM, Peter Krempa wrote: > All three should appease coverity. That they do... > > Peter Krempa (3): > qemu: hotplug: Don't generate alias when detaching controllers > qemu: hotplug: Don't leak 'nodename' in qemuDomainChangeMediaBlockdev > qemu: monitor: Fix device

Re: [libvirt] [PATCH] ppc: Remove deprecated ppcemb target

2018-08-22 Thread David Gibson
On Tue, Aug 21, 2018 at 01:27:48PM +0200, Thomas Huth wrote: > There is no known available OS for ppc around anymore that uses page > sizes below 4k, so it does not make much sense that we keep wasting > our time on building and testing the ppcemb-softmmu target. It has > been deprecated since two

[libvirt] [PATCH 3/3] qemu: monitor: Fix device matching in qemuMonitorJSONBlockIoThrottleInfo

2018-08-22 Thread Peter Krempa
We should compare the alias/qdev id only when it was provided by the caller and when it was found in the reply. Otherwise we could dereference a NULL pointer. STRNEQ_NULLABLE is not appropriate since it would return 'true' if the string was not present in the JSON output. Found by Coverity.

[libvirt] [PATCH 1/3] qemu: hotplug: Don't generate alias when detaching controllers

2018-08-22 Thread Peter Krempa
qemuDomainDetachControllerDevice contained code which implied that alias might be NULL when detaching the disk and tried to generate it. This is no longer possible so we can remove the code. Signed-off-by: Peter Krempa --- src/qemu/qemu_hotplug.c | 5 - 1 file changed, 5 deletions(-) diff

[libvirt] [PATCH 2/3] qemu: hotplug: Don't leak 'nodename' in qemuDomainChangeMediaBlockdev

2018-08-22 Thread Peter Krempa
qemuDomainDiskGetBackendAlias allocates a copy of the nodename string so we need to free it at the end. Found by Coverity. Signed-off-by: Peter Krempa --- src/qemu/qemu_hotplug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index

[libvirt] [PATCH 0/3] qemu: Fix few issues from the -blockdev series

2018-08-22 Thread Peter Krempa
All three should appease coverity. Peter Krempa (3): qemu: hotplug: Don't generate alias when detaching controllers qemu: hotplug: Don't leak 'nodename' in qemuDomainChangeMediaBlockdev qemu: monitor: Fix device matching in qemuMonitorJSONBlockIoThrottleInfo src/qemu/qemu_hotplug.c

Re: [libvirt] [jenkins-ci PATCH v3 02/12] jobs: Remove archive_format from defaults

2018-08-22 Thread Andrea Bolognani
On Wed, 2018-08-22 at 12:37 +0200, Erik Skultety wrote: > On Wed, Aug 22, 2018 at 11:44:17AM +0200, Andrea Bolognani wrote: > > Instead of defining a default and overriding it on a > > case-by-case basis, always define archive_format at the > > project level. > > > > This adds a bit of

Re: [libvirt] [PATCHv2 12/62] qemu: monitor: Allow using 'qdev' instead of 'device' for getting disk throttling

2018-08-22 Thread Peter Krempa
On Wed, Aug 22, 2018 at 06:47:45 -0400, John Ferlan wrote: > [...] > > > --- a/src/qemu/qemu_monitor_json.c > > +++ b/src/qemu/qemu_monitor_json.c > > @@ -4818,7 +4818,8 @@ int qemuMonitorJSONOpenGraphics(qemuMonitorPtr mon, > > } > > static int > >

Re: [libvirt] [jenkins-ci PATCH v3 01/12] jobs: Rename git-url -> git_url

2018-08-22 Thread Erik Skultety
On Wed, Aug 22, 2018 at 12:45:19PM +0200, Andrea Bolognani wrote: > On Wed, 2018-08-22 at 12:19 +0200, Erik Skultety wrote: > > On Wed, Aug 22, 2018 at 11:44:16AM +0200, Andrea Bolognani wrote: > > > Other user-defined variables use underscores as > > > separator instead of dashes; this change

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 12:36:27PM +0200, Andrea Bolognani wrote: > On Tue, 2018-08-21 at 14:21 -0400, Laine Stump wrote: > > On 08/17/2018 06:35 AM, Andrea Bolognani wrote: > > > If we decide we want to explicitly spell out the options instead > > > of relying on QEMU changing behavior based on

Re: [libvirt] [PATCH v3 1/3] vsh: Add API for printing tables.

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 12:50:12PM +0200, Simon Kobyda wrote: > On Tue, 2018-08-21 at 11:46 +0100, Daniel P. Berrangé wrote: > > On Tue, Aug 21, 2018 at 12:27:34PM +0200, Michal Privoznik wrote: > > > On 08/21/2018 11:18 AM, Simon Kobyda wrote: > > > > On Thu, 2018-08-16 at 12:28 +0100, Daniel P.

Re: [libvirt] [PATCHv2 45/62] qemu: hotplug: Implement removable media change for -blockdev

2018-08-22 Thread John Ferlan
[...] > +static int > +qemuDomainChangeMediaBlockdev(virQEMUDriverPtr driver, > + virDomainObjPtr vm, > + virDomainDiskDefPtr disk, > + virStorageSourcePtr newsrc, > + bool force) >

Re: [libvirt] [PATCH v3 1/3] vsh: Add API for printing tables.

2018-08-22 Thread Simon Kobyda
On Tue, 2018-08-21 at 11:46 +0100, Daniel P. Berrangé wrote: > On Tue, Aug 21, 2018 at 12:27:34PM +0200, Michal Privoznik wrote: > > On 08/21/2018 11:18 AM, Simon Kobyda wrote: > > > On Thu, 2018-08-16 at 12:28 +0100, Daniel P. Berrangé wrote: > > > > On Thu, Aug 16, 2018 at 12:56:24PM +0200,

Re: [libvirt] [PATCHv2 12/62] qemu: monitor: Allow using 'qdev' instead of 'device' for getting disk throttling

2018-08-22 Thread John Ferlan
[...] > --- a/src/qemu/qemu_monitor_json.c > +++ b/src/qemu/qemu_monitor_json.c > @@ -4818,7 +4818,8 @@ int qemuMonitorJSONOpenGraphics(qemuMonitorPtr mon, > } > static int > qemuMonitorJSONBlockIoThrottleInfo(virJSONValuePtr io_throttle, > - const char

Re: [libvirt] [jenkins-ci PATCH v3 01/12] jobs: Rename git-url -> git_url

2018-08-22 Thread Andrea Bolognani
On Wed, 2018-08-22 at 12:19 +0200, Erik Skultety wrote: > On Wed, Aug 22, 2018 at 11:44:16AM +0200, Andrea Bolognani wrote: > > Other user-defined variables use underscores as > > separator instead of dashes; this change will also > > help us out later. > > There are variables like

Re: [libvirt] [jenkins-ci PATCH v3 04/12] jobs: Declare empty values consistently

2018-08-22 Thread Erik Skultety
On Wed, Aug 22, 2018 at 11:44:19AM +0200, Andrea Bolognani wrote: > The pipe syntax is intended for multi-line preformatted > text, and is abused here. Use a saner syntax instead. > > Signed-off-by: Andrea Bolognani > --- Reviewed-by: Erik Skultety -- libvir-list mailing list

Re: [libvirt] [jenkins-ci PATCH v3 03/12] jobs: Move some parameters from jobs to defaults

2018-08-22 Thread Erik Skultety
On Wed, Aug 22, 2018 at 11:44:18AM +0200, Andrea Bolognani wrote: > The affected parameters are autogen_args, command and > command_pre_build. > > Moving their default value next to the other overridable > defaults makes sense, and it will help us out later. > > Signed-off-by: Andrea Bolognani >

Re: [libvirt] [jenkins-ci PATCH v3 02/12] jobs: Remove archive_format from defaults

2018-08-22 Thread Erik Skultety
On Wed, Aug 22, 2018 at 12:37:27PM +0200, Erik Skultety wrote: > On Wed, Aug 22, 2018 at 11:44:17AM +0200, Andrea Bolognani wrote: > > Instead of defining a default and overriding it on a > > case-by-case basis, always define archive_format at the > > project level. > > > > This adds a bit of

Re: [libvirt] [jenkins-ci PATCH v3 02/12] jobs: Remove archive_format from defaults

2018-08-22 Thread Erik Skultety
On Wed, Aug 22, 2018 at 11:44:17AM +0200, Andrea Bolognani wrote: > Instead of defining a default and overriding it on a > case-by-case basis, always define archive_format at the > project level. > > This adds a bit of duplication, but it's consistent with > how we define other metadata for

Re: [libvirt] [Qemu-devel] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

2018-08-22 Thread Andrea Bolognani
On Tue, 2018-08-21 at 14:21 -0400, Laine Stump wrote: > On 08/17/2018 06:35 AM, Andrea Bolognani wrote: > > If we decide we want to explicitly spell out the options instead > > of relying on QEMU changing behavior based on the slot type, which > > is probably a good idea anyway, I think we should

Re: [libvirt] [jenkins-ci PATCH v3 01/12] jobs: Rename git-url -> git_url

2018-08-22 Thread Erik Skultety
On Wed, Aug 22, 2018 at 11:44:16AM +0200, Andrea Bolognani wrote: > Other user-defined variables use underscores as > separator instead of dashes; this change will also > help us out later. There are variables like child-workspace, block-upstream, days-to-keep, etc. in most of the templates under

Re: [libvirt] [PATCH v3 01/12] conf: Add definitions for 'uid' and 'fid' PCI address attributes

2018-08-22 Thread Andrea Bolognani
On Wed, 2018-08-22 at 17:39 +0800, Yi Min Zhao wrote: > 在 2018/8/21 下午9:19, Andrea Bolognani 写道: > > On Tue, 2018-08-21 at 19:55 +0800, Yi Min Zhao wrote: > > > > > For zPCI address, if we use the same strategy as PCI part and user > > > > > wants to assign fid=0 to the specific device, he might

Re: [libvirt] [PATCH v3 09/12] qemu: Generate and use zPCI device in QEMU command line

2018-08-22 Thread Yi Min Zhao
在 2018/8/22 下午4:42, Andrea Bolognani 写道: On Wed, 2018-08-22 at 11:06 +0800, Yi Min Zhao wrote: 在 2018/8/20 下午7:14, Andrea Bolognani 写道: So which is unique: uid, fid, or the combination of the two? Could I have -device zpci,uid=1,fid=1 -device zpci,uid=1,fid=2 or would that not

Re: [libvirt] [PATCH v3 08/12] conf: Allocate/release 'uid' and 'fid' in PCI address

2018-08-22 Thread Andrea Bolognani
On Wed, 2018-08-22 at 11:00 +0800, Yi Min Zhao wrote: > 在 2018/8/17 上午12:06, Andrea Bolognani 写道: > > On Tue, 2018-08-07 at 17:10 +0800, Yi Min Zhao wrote: > > [...] > > > +static inline bool > > > +virDeviceInfoPCIAddressExtensionPresent(const virDomainDeviceInfo *info) > > > +{ > > > +return

Re: [libvirt] [Qemu-devel] [PATCH 3/3] ui: remove support for SDL1.2 in favour of SDL2

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 08, 2018 at 02:51:01PM +0100, Peter Maydell wrote: > On 8 August 2018 at 11:49, Daniel P. Berrangé wrote: > > SDL1.2 was deprecated in the 2.12.0 release with: > > > > commit e52c6ba34149b4f39c3fd60e59ee32b809db2bfa > > Author: Daniel P. Berrange > > Date: Mon Jan 15 14:25:33

Re: [libvirt] [PATCH] qemu: Start domain on a node without cpu affinity

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 09:48:10AM +0200, Peter Krempa wrote: > On Wed, Aug 22, 2018 at 00:31:29 +0300, Roman Bolshakov wrote: > > libvirt affinity wrappers don't support macOS Thread Affinity API: > > https://developer.apple.com/library/archive/releasenotes/Performance/RN-AffinityAPI/index.html >

[libvirt] [PATCH v2] virsh: Don't break loop of domblkinfo for disks

2018-08-22 Thread Han Han
https://bugzilla.redhat.com/show_bug.cgi?id=1619625 --all option is added to cmdDomblkinfo since commit 62c39193 allowing to show all block devices info. Reset error when empty source in case error breaks the loop of domblkinfo for disks. Signed-off-by: Han Han --- tools/virsh-domain-monitor.c

[libvirt] [jenkins-ci PATCH v3 12/12] lcitool: Document build action

2018-08-22 Thread Andrea Bolognani
Provide some examples and scenarios. Signed-off-by: Andrea Bolognani --- guests/README.markdown | 19 +++ 1 file changed, 19 insertions(+) diff --git a/guests/README.markdown b/guests/README.markdown index ddf0149..870619e 100644 --- a/guests/README.markdown +++

[libvirt] [jenkins-ci PATCH v3 11/12] guests: Support building on more targets

2018-08-22 Thread Andrea Bolognani
The Jenkins build jobs can only run on the subset of guests that are available on CentOS CI, but when we're running build jobs through lcitool we don't have that limitation and we can build on more targets. Signed-off-by: Andrea Bolognani --- guests/playbooks/build/jobs/defaults.yml |

[libvirt] [jenkins-ci PATCH v3 08/12] lcitool: Make playbook execution generic

2018-08-22 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- guests/lcitool | 87 ++ 1 file changed, 45 insertions(+), 42 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index f28199d..e0410f3 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -351,6 +351,50 @@

[libvirt] [jenkins-ci PATCH v3 06/12] guests: Add build projects

2018-08-22 Thread Andrea Bolognani
These tasks mirror the Jenkins projects contained in the top-level projects/ directory. Signed-off-by: Andrea Bolognani --- guests/playbooks/build/projects/libosinfo.yml | 36 + .../playbooks/build/projects/libvirt-cim.yml | 10 .../playbooks/build/projects/libvirt-dbus.yml |

[libvirt] [jenkins-ci PATCH v3 10/12] lcitool: Support building arbitrary branches

2018-08-22 Thread Andrea Bolognani
Building master is useful for CI purposes and to debug CI failures locally, but when developing we want to be able to build a personal branch to validate in-progress changes. Signed-off-by: Andrea Bolognani --- guests/lcitool | 30

[libvirt] [jenkins-ci PATCH v3 03/12] jobs: Move some parameters from jobs to defaults

2018-08-22 Thread Andrea Bolognani
The affected parameters are autogen_args, command and command_pre_build. Moving their default value next to the other overridable defaults makes sense, and it will help us out later. Signed-off-by: Andrea Bolognani --- jobs/autotools.yaml| 1 - jobs/defaults.yaml | 3 +++

[libvirt] [jenkins-ci PATCH v3 05/12] guests: Add build jobs

2018-08-22 Thread Andrea Bolognani
These tasks mirror the Jenkins jobs contained in the top-level jobs/ directory. Signed-off-by: Andrea Bolognani --- .../build/jobs/autotools-build-job.yml| 15 +++ .../build/jobs/autotools-check-job.yml| 16 .../build/jobs/autotools-rpm-job.yml | 15 +++

[libvirt] [jenkins-ci PATCH v3 00/12] lcitool: Add 'build' action

2018-08-22 Thread Andrea Bolognani
Changes from [v2]: * rebase on top of master (dbc2de85f775) and integrate recent changes to build rules on the Jenkins side; * drop a commit that had already been merged in the meantime. Changes from [v1]: * rebase on top of master (985ab833be9b) and integrate recent changes to

[libvirt] [jenkins-ci PATCH v3 07/12] guests: Add build playbook

2018-08-22 Thread Andrea Bolognani
This playbook represent the entry point for automated builds, and follows the same calling conventions as the existing update playbook. Signed-off-by: Andrea Bolognani --- guests/playbooks/build/main.yml | 16 1 file changed, 16 insertions(+) create mode 100644

[libvirt] [jenkins-ci PATCH v3 04/12] jobs: Declare empty values consistently

2018-08-22 Thread Andrea Bolognani
The pipe syntax is intended for multi-line preformatted text, and is abused here. Use a saner syntax instead. Signed-off-by: Andrea Bolognani --- jobs/defaults.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jobs/defaults.yaml b/jobs/defaults.yaml index

[libvirt] [jenkins-ci PATCH v3 09/12] lcitool: Add 'build' action

2018-08-22 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- guests/lcitool | 4 1 file changed, 4 insertions(+) diff --git a/guests/lcitool b/guests/lcitool index e0410f3..2901a92 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -323,6 +323,7 @@ class Application: common actions:

[libvirt] [jenkins-ci PATCH v3 01/12] jobs: Rename git-url -> git_url

2018-08-22 Thread Andrea Bolognani
Other user-defined variables use underscores as separator instead of dashes; this change will also help us out later. Signed-off-by: Andrea Bolognani --- jobs/autotools.yaml | 2 +- jobs/generic.yaml | 2 +- jobs/go.yaml | 2 +- jobs/perl-modulebuild.yaml

[libvirt] [jenkins-ci PATCH v3 02/12] jobs: Remove archive_format from defaults

2018-08-22 Thread Andrea Bolognani
Instead of defining a default and overriding it on a case-by-case basis, always define archive_format at the project level. This adds a bit of duplication, but it's consistent with how we define other metadata for projects and it will help us out later. Signed-off-by: Andrea Bolognani ---

Re: [libvirt] [PATCH] util: eventpoll: Survive EBADF on macOS

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 12:12:03AM +0300, Roman Bolshakov wrote: > Fixes: > https://www.redhat.com/archives/libvir-list/2017-January/msg00978.html > > QEMU is probed through monitor fd to check capabilities during libvirtd init. > The monitor fd is closed after probing by

Re: [libvirt] [PATCH v3 01/12] conf: Add definitions for 'uid' and 'fid' PCI address attributes

2018-08-22 Thread Yi Min Zhao
在 2018/8/21 下午9:19, Andrea Bolognani 写道: On Tue, 2018-08-21 at 19:55 +0800, Yi Min Zhao wrote: 在 2018/8/21 下午7:00, Andrea Bolognani 写道: On Tue, 2018-08-21 at 17:35 +0800, Yi Min Zhao wrote: I want to ask a question. For pci address, any pci device can't use slot 0. Is that a reason why PCI

[libvirt] [PATCH v3 0/9] RISC-V Guest Support

2018-08-22 Thread Lubomir Rintel
Hi. Third iteration of RISC-V guest support. I believe I addressed all points of Andrea's review. Tested with: images from [1]: virt-install \ --import --name riscv64 \ --arch riscv64 --machine virt \ --memory 2048 \ --rng /dev/urandom \ --disk

[libvirt] [PATCH v3 4/9] qemu: RISC-V machines have no PCI

2018-08-22 Thread Lubomir Rintel
Signed-off-by: Lubomir Rintel --- src/qemu/qemu_domain_address.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index 6c540a8094..551883e989 100644 --- a/src/qemu/qemu_domain_address.c +++

[libvirt] [PATCH v3 7/9] qemu: assign addresses to virtio devices on RISC-V

2018-08-22 Thread Lubomir Rintel
Signed-off-by: Lubomir Rintel --- src/qemu/qemu_domain_address.c | 16 1 file changed, 16 insertions(+) diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index 317f280f92..29a1def24c 100644 --- a/src/qemu/qemu_domain_address.c +++

[libvirt] [PATCH v3 3/9] util: add RISC-V architectures

2018-08-22 Thread Lubomir Rintel
Signed-off-by: Lubomir Rintel Reviewed-by: Andrea Bolognani --- docs/schemas/basictypes.rng | 2 ++ src/qemu/qemu_domain.c | 2 ++ src/util/virarch.c | 5 - src/util/virarch.h | 8 +++- 4 files changed, 15 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH v3 5/9] qemu: add qemuDomainIsRISCVVirt() and qemuDomainMachineIsRISCVVirt()

2018-08-22 Thread Lubomir Rintel
Signed-off-by: Lubomir Rintel --- src/qemu/qemu_domain.c | 22 ++ src/qemu/qemu_domain.h | 3 +++ 2 files changed, 25 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 60b4a9b412..b43e9b76d4 100644 --- a/src/qemu/qemu_domain.c +++

[libvirt] [PATCH v3 1/9] qemu: rename qemuDomainMachineIsVirt()

2018-08-22 Thread Lubomir Rintel
It's ARM specific. Signed-off-by: Lubomir Rintel --- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_domain.c | 6 +++--- src/qemu/qemu_domain.h | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c

[libvirt] [PATCH v3 6/9] qemu: add qemuDomainAssignVirtioMMIOAddresses()

2018-08-22 Thread Lubomir Rintel
Signed-off-by: Lubomir Rintel --- src/qemu/qemu_domain_address.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index 551883e989..317f280f92 100644 --- a/src/qemu/qemu_domain_address.c +++

[libvirt] [PATCH v3 2/9] qemu: rename qemuDomainArmVirt()

2018-08-22 Thread Lubomir Rintel
It's ARM specific. Signed-off-by: Lubomir Rintel --- src/qemu/qemu_capabilities.c | 4 ++-- src/qemu/qemu_command.c| 4 ++-- src/qemu/qemu_domain.c | 16 src/qemu/qemu_domain.h | 2 +- src/qemu/qemu_domain_address.c | 4 ++-- 5 files changed, 15

[libvirt] [PATCH v3 9/9] news: Add a mention of RISC-V guest support

2018-08-22 Thread Lubomir Rintel
Signed-off-by: Lubomir Rintel --- docs/news.xml | 8 1 file changed, 8 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index c6d03f5556..2b6d08dc02 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -53,6 +53,14 @@ bandwidth by using the memorytune element in

Re: [libvirt] [jenkins-ci PATCH v2 00/13] lcitool: Add 'build' action

2018-08-22 Thread Andrea Bolognani
On Wed, 2018-08-22 at 10:38 +0200, Erik Skultety wrote: > On Fri, Aug 17, 2018 at 04:18:16PM +0200, Andrea Bolognani wrote: > > Changes from [v1]: > > > > * rebase on top of master (985ab833be9b) and integrate recent > > changes to build rules on the Jenkins side; > > > > * build on more

Re: [libvirt] [PATCH] virsh: Don't break loop of domblkinfo for disks

2018-08-22 Thread Han Han
On Tue, Aug 21, 2018 at 11:26 PM, Peter Krempa wrote: > On Tue, Aug 21, 2018 at 21:23:42 +0800, Han Han wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1619625 > > > > --all option is added to cmdDomblkinfo since commit 62c39193 allowing to > > show all block devices info. Remove its

Re: [libvirt] [Qemu-devel] [PATCH] Remove deprecated -balloon option

2018-08-22 Thread David Hildenbrand
On 21.08.2018 12:05, Thomas Huth wrote: > The "-balloon" option has been replaced by "-device virtio-balloon". > It's been marked as deprecated since two releases, and nobody > complained, so let's remove it now. > > Signed-off-by: Thomas Huth > --- > docs/virtio-balloon-stats.txt | 6 +++--- >

Re: [libvirt] [PATCH v3 09/12] qemu: Generate and use zPCI device in QEMU command line

2018-08-22 Thread Andrea Bolognani
On Wed, 2018-08-22 at 11:06 +0800, Yi Min Zhao wrote: > 在 2018/8/20 下午7:14, Andrea Bolognani 写道: > > So which is unique: uid, fid, or the combination of the two? > > Could I have > > > >-device zpci,uid=1,fid=1 > >-device zpci,uid=1,fid=2 > > > > or would that not work? What about > > >

Re: [libvirt] [jenkins-ci PATCH v2 00/13] lcitool: Add 'build' action

2018-08-22 Thread Erik Skultety
On Fri, Aug 17, 2018 at 04:18:16PM +0200, Andrea Bolognani wrote: > Changes from [v1]: > > * rebase on top of master (985ab833be9b) and integrate recent > changes to build rules on the Jenkins side; > > * build on more targets. > > [v1]

Re: [libvirt] [PATCH] qemu: Start domain on a node without cpu affinity

2018-08-22 Thread Peter Krempa
On Wed, Aug 22, 2018 at 00:31:29 +0300, Roman Bolshakov wrote: > libvirt affinity wrappers don't support macOS Thread Affinity API: > https://developer.apple.com/library/archive/releasenotes/Performance/RN-AffinityAPI/index.html > > virProcessSetAffinity stub prevents libvirt from starting a qemu

Re: [libvirt] [PATCH] doc: better explanation for virStoragePoolSetAutostart

2018-08-22 Thread Erik Skultety
On Wed, Aug 22, 2018 at 08:43:32AM +0300, Dan Kenigsberg wrote: > The former documentation was an unhelpful tautology. The suggested doc > mimicks^Wcopies the one of virDomainSetAutostart. > > Signed-off-by: Dan Kenigsberg > --- > src/libvirt-storage.c | 3 ++- > 1 file changed, 2 insertions(+),