Re: [libvirt] [PATCH v3 3/4] qemu_domain: NVLink2 device tree functions for PPC64

2019-03-11 Thread Alexey Kardashevskiy
On 12/03/2019 09:15, Daniel Henrique Barboza wrote: > > > On 3/7/19 10:29 PM, Alexey Kardashevskiy wrote: >> >> On 08/03/2019 04:51, Piotr Jaroszynski wrote: >>> On 3/7/19 7:39 AM, Daniel Henrique Barboza wrote: On 3/7/19 12:15 PM, Erik Skultety wrote: > On Tue, Mar 05, 2019 at

[libvirt] [PATCH v4 5/8] virsh: Expose bulk snapshot dumpxml/import

2019-03-11 Thread Eric Blake
Add a new 'snapshot-import' command for bulk import. For bulk XML, it was easier to just add new flags to the existing 'snapshot-dumpxml' than to figure out a new command name. I debated about whether omitting the snapshotname should be enough to trigger the new API call, or whether to require a

[libvirt] [PATCH v4 0/8] bulk snapshot list/redefine (incremental backup saga)

2019-03-11 Thread Eric Blake
While looking at my work on incremental backups, Nir raised a good point: if we want to recreate a set of known checkpoints on one machine that will be taking over a domain from another machine, my initial proposal required making multiple API calls to list the XML for each checkpoint on the

[libvirt] [PATCH v4 2/8] snapshot: Support topological virDomainSnapshotForEach()

2019-03-11 Thread Eric Blake
Previous patches added topological sorting only for existing public API functions, but it turns out that it will also useful for an upcoming API addition that wants to visit all snapshots. Add a parameter, and update all existing callers (none of which care about ordering). Signed-off-by: Eric

[libvirt] [PATCH v4 6/8] test: Implement bulk snapshot operations

2019-03-11 Thread Eric Blake
Implement the new API calls for bulk snapshot dump and import. The bulk of the work is already done by the common code. Since each connection to test:///default restarts at the same canned state, this can easily be tested with: $ virsh -c test:///default " snapshot-create-as test s1

[libvirt] [PATCH v4 8/8] qemu: Implement bulk snapshot operations

2019-03-11 Thread Eric Blake
Implement the new API calls for bulk snapshot dump and import. This borrows from ideas in the test driver, but import is further complicated by the fact that qemu writes snapshot XML to disk, and thus must do additional validation after the initial parse to ensure the user didn't attempt to create

[libvirt] [PATCH v4 7/8] qemu: Factor out qemuDomainSnapshotValidate() helper

2019-03-11 Thread Eric Blake
Straight code motion, coupled with changing goto into return -1 as needed. This change will be important to later patches adding bulk redefinition (where each snapshot in a list has to meet the same constraints). Signed-off-by: Eric Blake Reviewed-by: John Ferlan --- src/qemu/qemu_driver.c |

[libvirt] [PATCH v4 1/8] snapshot: Add new API for bulk dumpxml/redefine

2019-03-11 Thread Eric Blake
Right now, copying the state of a transient domain with snapshots from one host to another requires multiple API calls on both machines - on the host: get the domain XML, get a list of the snapshots, and then for each snapshot get the snapshot's XML; then on the destination: create the domain,

[libvirt] [PATCH v4 4/8] remote: Wire up snapshot bulk dumpxml/import

2019-03-11 Thread Eric Blake
Typical copy-and-paste addition. Fortunately, the generator handles this one without needing manual overrides. Signed-off-by: Eric Blake --- src/remote/remote_driver.c | 6 -- src/remote/remote_protocol.x | 38 ++-- src/remote_protocol-structs | 17

[libvirt] [PATCH v4 3/8] snapshot: Tweaks to support new bulk dumpxml/import API

2019-03-11 Thread Eric Blake
Change the return value of virDomainSnapshotObjLisParse() to return the number of snapshots imported, and allow a return of 0 (the original proposal of adding a flag to virDomainSnapshotCreateXML required returning an arbitrary non-NULL snapshot, but with a new API that returns a count, we are no

[libvirt] [PATCH] virsh: Make self-test failures noisy

2019-03-11 Thread Eric Blake
In local testing, I accidentally introduced a self-test failure, and spent way too much time debugging it. Make sure the testsuite log includes some hint as to why command option validation failed. Signed-off-by: Eric Blake --- tools/vsh.c | 56

Re: [libvirt] [PATCH v3 3/4] qemu_domain: NVLink2 device tree functions for PPC64

2019-03-11 Thread Daniel Henrique Barboza
On 3/7/19 12:15 PM, Erik Skultety wrote: On Tue, Mar 05, 2019 at 09:46:08AM -0300, Daniel Henrique Barboza wrote: The NVLink2 support in QEMU implements the detection of NVLink2 capable devices by verfying the attributes of the VFIO mem region QEMU allocates for the NVIDIA GPUs. To properly

Re: [libvirt] [PATCH v3 3/4] qemu_domain: NVLink2 device tree functions for PPC64

2019-03-11 Thread Daniel Henrique Barboza
On 3/7/19 12:39 PM, Daniel Henrique Barboza wrote: On 3/7/19 12:15 PM, Erik Skultety wrote: On Tue, Mar 05, 2019 at 09:46:08AM -0300, Daniel Henrique Barboza wrote: The NVLink2 support in QEMU implements the detection of NVLink2 capable devices by verfying the attributes of the VFIO mem

Re: [libvirt] [PATCH v3 3/4] qemu_domain: NVLink2 device tree functions for PPC64

2019-03-11 Thread Daniel Henrique Barboza
On 3/7/19 10:29 PM, Alexey Kardashevskiy wrote: On 08/03/2019 04:51, Piotr Jaroszynski wrote: On 3/7/19 7:39 AM, Daniel Henrique Barboza wrote: On 3/7/19 12:15 PM, Erik Skultety wrote: On Tue, Mar 05, 2019 at 09:46:08AM -0300, Daniel Henrique Barboza wrote: The NVLink2 support in QEMU

Re: [libvirt] [PATCH python v2] Fix handling of optional params in blockCopy()

2019-03-11 Thread Nir Soffer
On Mon, Mar 11, 2019 at 11:35 PM Nir Soffer wrote: > Commit 2b4bd07e0a22 (Add check for params, nparams being a dictionary) > changed the way the optional params argument is treated. If > libvirt.virDomain.blockCopy() is called without specifying params, > params is None, and the call will fail

[libvirt] [PATCH python v2] Fix handling of optional params in blockCopy()

2019-03-11 Thread Nir Soffer
Commit 2b4bd07e0a22 (Add check for params, nparams being a dictionary) changed the way the optional params argument is treated. If libvirt.virDomain.blockCopy() is called without specifying params, params is None, and the call will fail with: TypeError: block params must be a dictionary This

[libvirt] [PATCH 6/6] lxc: Introduce method lxcDomainGetBalloonStats().

2019-03-11 Thread Julio Faracco
This method is responsible to fetch all Balloon Memory Stats and store data into virDomainStatsRecordPtr structure. Signed-off-by: Julio Faracco --- src/lxc/lxc_driver.c | 71 1 file changed, 71 insertions(+) diff --git a/src/lxc/lxc_driver.c

[libvirt] [PATCH 3/6] lxc: Introduce method lxcDomainGetStatsCpu().

2019-03-11 Thread Julio Faracco
This method is responsible to fetch all CPU Cgroup Stats and store data into virDomainStatsRecordPtr structure. Signed-off-by: Julio Faracco --- src/lxc/lxc_driver.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/src/lxc/lxc_driver.c

[libvirt] [PATCH 4/6] lxc: Introduce method lxcDomainGetStatsState().

2019-03-11 Thread Julio Faracco
This method is responsible to fetch all State Stats and store data into virDomainStatsRecordPtr structure. Signed-off-by: Julio Faracco --- src/lxc/lxc_driver.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index

[libvirt] [PATCH 2/6] lxc: Introduce method lxcDomainGetStats().

2019-03-11 Thread Julio Faracco
This method is responsible to fetch data like State, CPU, Disk and Balloon info (all single domain info) from each domain 'virDomainObjPtr'. Signed-off-by: Julio Faracco --- src/lxc/lxc_driver.c | 42 ++ 1 file changed, 42 insertions(+) diff --git

[libvirt] [PATCH 5/6] lxc: Introduce method lxcDomainGetBlockStats().

2019-03-11 Thread Julio Faracco
This method is responsible to fetch all Block Stats and store data into virDomainStatsRecordPtr structure. This particular method checks for LXC filesystem in host disk/partition and check for block disks like physical disks and partition that are considered block types. If the block type does not

[libvirt] [PATCH 0/6] lxc: Add suport to virConnectGetAllDomainStats().

2019-03-11 Thread Julio Faracco
This series has a collection of new methods to enable support for virConnectGetAllDomainStats() to LXC driver. The only difference is Disk Stats. It needs to consider only the host file system operations or any other block device as a external disk or partition. Julio Faracco (6): lxc:

[libvirt] [PATCH 1/6] lxc: Introduce method lxcConnectGetAllDomainStats().

2019-03-11 Thread Julio Faracco
This is an implementation of method used by driver to retrieve stats from all domain. Right now, this is a simple implementation considering only State, CPU, Disks and Balloon. Signed-off-by: Julio Faracco --- src/lxc/lxc_driver.c | 83 1 file

Re: [libvirt] [jenkins-ci PATCH] lcitool: Raise Error instead of Exception

2019-03-11 Thread Daniel P . Berrangé
On Mon, Mar 11, 2019 at 07:11:49PM +0100, Andrea Bolognani wrote: > On Mon, 2019-03-11 at 17:55 +, Daniel P. Berrangé wrote: > > On Mon, Mar 11, 2019 at 06:48:11PM +0100, Andrea Bolognani wrote: > > > This results in > > > > > > $ ./lcitool dockerfile dockerfile -x foo libvirt-debian-9

Re: [libvirt] [jenkins-ci PATCH] lcitool: Raise Error instead of Exception

2019-03-11 Thread Andrea Bolognani
On Mon, 2019-03-11 at 17:55 +, Daniel P. Berrangé wrote: > On Mon, Mar 11, 2019 at 06:48:11PM +0100, Andrea Bolognani wrote: > > This results in > > > > $ ./lcitool dockerfile dockerfile -x foo libvirt-debian-9 libvirt > > FROM debian:9 > > ./lcitool: Unsupported architecture ppc64el >

Re: [libvirt] [jenkins-ci PATCH] lcitool: Raise Error instead of Exception

2019-03-11 Thread Daniel P . Berrangé
On Mon, Mar 11, 2019 at 06:48:11PM +0100, Andrea Bolognani wrote: > This results in > > $ ./lcitool dockerfile dockerfile -x foo libvirt-debian-9 libvirt > FROM debian:9 > ./lcitool: Unsupported architecture ppc64el > > being printed on error, instead of the much nastier > > $ ./lcitool

[libvirt] [jenkins-ci PATCH] lcitool: Raise Error instead of Exception

2019-03-11 Thread Andrea Bolognani
This results in $ ./lcitool dockerfile dockerfile -x foo libvirt-debian-9 libvirt FROM debian:9 ./lcitool: Unsupported architecture ppc64el being printed on error, instead of the much nastier $ ./lcitool dockerfile dockerfile -x foo libvirt-debian-9 libvirt FROM debian:9 Traceback

Re: [libvirt] [jenkins-ci PATCH] lcitool: Fix name for ppc64le architecture

2019-03-11 Thread Andrea Bolognani
On Mon, 2019-03-11 at 18:13 +0100, Erik Skultety wrote: > On Mon, Mar 11, 2019 at 05:50:57PM +0100, Andrea Bolognani wrote: [...] > > @@ -118,7 +118,7 @@ class Util: > > "mips": "mips", > > "mipsel": "mipsel", > > "mips64el": "mips64el", > > -

Re: [libvirt] [jenkins-ci PATCH] lcitool: Fix name for ppc64le architecture

2019-03-11 Thread Erik Skultety
On Mon, Mar 11, 2019 at 05:50:57PM +0100, Andrea Bolognani wrote: > We're only exposing libvirt architecture names externally, > which means the correct value for little-endian 64-bit PowerPC > is ppc64le (VIR_ARCH_PPC64LE). > > Note that, while "ppc64el" is not an architecture name > libvirt

[libvirt] [dockerfiles PATCH] Fix name for ppc64le architecture

2019-03-11 Thread Andrea Bolognani
lcitool expects libvirt architecture names, which means the correct value for little-endian 64-bit PowerPC is ppc64le (VIR_ARCH_PPC64LE). Note that, while "ppc64el" is not an architecture name libvirt would recognize, mips64el (VIR_ARCH_MIPS64EL) and mipsel (VIR_ARCH_MIPSEL) are indeed correct.

[libvirt] [jenkins-ci PATCH] lcitool: Fix name for ppc64le architecture

2019-03-11 Thread Andrea Bolognani
We're only exposing libvirt architecture names externally, which means the correct value for little-endian 64-bit PowerPC is ppc64le (VIR_ARCH_PPC64LE). Note that, while "ppc64el" is not an architecture name libvirt would recognize, mips64el (VIR_ARCH_MIPS64EL) and mipsel (VIR_ARCH_MIPSEL) are

Re: [libvirt] [PATCH 2/2] rbd: optionally disable actual disk-usage during pool/volume refresh

2019-03-11 Thread Jason Dillaman
On Mon, Mar 11, 2019 at 11:50 AM Daniel P. Berrangé wrote: > > On Mon, Mar 11, 2019 at 11:39:55AM -0400, jdill...@redhat.com wrote: > > From: Jason Dillaman > > > > For pools with numerous volumes or very large volumes, the disk-usage > > calculation can take a non-trivial amount of time even

Re: [libvirt] [PATCH 2/2] rbd: optionally disable actual disk-usage during pool/volume refresh

2019-03-11 Thread Daniel P . Berrangé
On Mon, Mar 11, 2019 at 11:39:55AM -0400, jdill...@redhat.com wrote: > From: Jason Dillaman > > For pools with numerous volumes or very large volumes, the disk-usage > calculation can take a non-trivial amount of time even with the > fast-diff feature enabled (especially since the the usage is

[libvirt] [PATCH 0/2] rbd: improvements to actual disk-usage calculation

2019-03-11 Thread jdillama
From: Jason Dillaman The RBD fast-diff feature can vastly reduce the amount of time needed to calculate actual disk usage of volumes, but it might still be a slow operation for large RBD pools or pools with large RBD images. Therefore, this feature should be able to be optionally disabled if

[libvirt] [PATCH 1/2] rbd: do not attempt to use fast-diff if it's marked invalid

2019-03-11 Thread jdillama
From: Jason Dillaman The librbd API will transparently revert to a slow disk usage calculation method if the fast-diff map is marked as invalid. Signed-off-by: Jason Dillaman --- src/storage/storage_backend_rbd.c | 41 --- 1 file changed, 37 insertions(+), 4

Re: [libvirt] Contributing to Libvirt

2019-03-11 Thread Dan Fries
Hi Libvirt, It's often said that persistence and patience are the keys to success in life. I think persons managing content and marketing at Libvirt would be remiss for not trying out my work. Hoping to hear from you soon. Best, Dan On Monday, March 4, 2019 at 7:36 AM, Dan Fries wrote: >

[libvirt] [PATCH 2/2] rbd: optionally disable actual disk-usage during pool/volume refresh

2019-03-11 Thread jdillama
From: Jason Dillaman For pools with numerous volumes or very large volumes, the disk-usage calculation can take a non-trivial amount of time even with the fast-diff feature enabled (especially since the the usage is calculated serially for each image in the pool). The "rbd:config_opts" node now

[libvirt] [PATCH python] Fix handling of optional params in blockCopy()

2019-03-11 Thread Nir Soffer
Commit 2b4bd07e0a22 (Add check for params, nparams being a dictionary) changed the way the optional params argument is treated. If libvirt.virDomain.blockCopy() is called without specifying params, params is None, and the call will fail with: TypeError: block params must be a dictionary This

[libvirt] [PATCH 1/2] util: add virStringParseYesNo()

2019-03-11 Thread Shotaro Gotanda
This function parse and convert string "yes|no" into bool true|false. Signed-off-by: Shotaro Gotanda --- src/util/virstring.c | 32 src/util/virstring.h | 3 +++ 2 files changed, 35 insertions(+) diff --git a/src/util/virstring.c b/src/util/virstring.c index

[libvirt] [PATCH 0/2] Add function for XML yes|no string handling

2019-03-11 Thread Shotaro Gotanda
These patches are based on a bite-sized task proposed in https://wiki.libvirt.org/page/BiteSizedTasks and the mentor of this bite-sized task is Cole Robinson (Do I need to put the mentor in cc, in this case?) The function virStringParseYesNo() convert the string "yes" into bool true and "no"

[libvirt] [PATCH 2/2] conf: Use virStringParseYesNo()

2019-03-11 Thread Shotaro Gotanda
This commit remove redundant common pattern in our XML parsing that convert string 'yes' into true and 'no' into false, and error if we receive anything other values. Signed-off-by: Shotaro Gotanda --- src/conf/domain_conf.c | 30 +- src/conf/secret_conf.c | 12

Re: [libvirt] [PATCH v2 15/15] qemuxml2argvtest: Test os.firmware autoselection

2019-03-11 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 10:29:25AM +0100, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > tests/Makefile.am | 4 +- > ...arch64-os-firmware-efi.aarch64-latest.args | 37 ++ > .../aarch64-os-firmware-efi.xml | 30 >

Re: [libvirt] [PATCH v2 11/15] qemu_firmware: Introduce qemuFirmwareFillDomain()

2019-03-11 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 10:29:21AM +0100, Michal Privoznik wrote: > And finally the last missing piece. This is what puts it all > together. > > At the beginning, qemuFirmwareFillDomain() loads all possible > firmware description files based on algorithm described earlier. > Then it tries to find

Re: [libvirt] [PATCH v2 14/15] qemu: Enable firmware autoselection

2019-03-11 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 10:29:24AM +0100, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1564270 > > Now that everything is prepared for qemu driver we can enable > parser feature to allow users define such domains. > > Signed-off-by: Michal Privoznik > --- >

Re: [libvirt] [PATCH v2 13/15] qemuDomainDefValidate: Don't require SMM if automatic firmware selection enabled

2019-03-11 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 10:29:23AM +0100, Michal Privoznik wrote: > The firmware selection code will enable the feature if needed. > There's no need to require SMM to be enabled in that case. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_domain.c | 4 +++- > 1 file changed, 3

Re: [libvirt] [dockerfiles PATCH 0/4] Add cross-compilation Dockerfiles

2019-03-11 Thread Andrea Bolognani
On Mon, 2019-03-11 at 14:54 +, Daniel P. Berrangé wrote: > On Fri, Mar 08, 2019 at 07:00:46PM +0100, Andrea Bolognani wrote: > > lcitool supports generating Dockerfiles targeting cross-compilation > > of libvirt, so all that's left to do is teach the refresh script > > how to pass the

Re: [libvirt] [PATCH v2 10/15] qemufirmwaretest: Test qemuFirmwareFetchConfigs()

2019-03-11 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 10:29:20AM +0100, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > tests/Makefile.am | 1 + > .../etc/qemu/firmware/40-ovmf-sb-keys.json| 1 + > .../etc/qemu/firmware/60-ovmf-sb.json | 0 >

Re: [libvirt] [PATCH v2 08/15] test: Introduce qemufirmwaretest

2019-03-11 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 10:29:18AM +0100, Michal Privoznik wrote: > Test firmware description parsing so far. > > The test files come from three locations: > 1) ovmf-sb-keys.json and ovmf-sb.json come from OVMF > package from RHEL-7 (with slight name change to reflect their > features in filename

Re: [libvirt] [PATCH v2 07/15] qemu: Introduce basic skeleton for parsing firmware description

2019-03-11 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 10:29:17AM +0100, Michal Privoznik wrote: > The firmware description is a JSON file which follows > specification from qemu.git/docs/interop/firmware.json. The > description file basically says: Firmware file X is {bios|uefi}, > supports these targets and machine types,

Re: [libvirt] [PATCH v2 06/15] conf: Introduce firmware attribute to

2019-03-11 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 10:29:16AM +0100, Michal Privoznik wrote: > The idea is that using this attribute users enable libvirt to > automagically select firmware image for their domain. For > instance: > > > hvm > Ah, now I see why you need without a path specified. We need to be

Re: [libvirt] [PATCH v2 05/15] conf: Introduce VIR_DOMAIN_LOADER_TYPE_NONE

2019-03-11 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 10:29:15AM +0100, Michal Privoznik wrote: > This is going to extend virDomainLoader enum. The reason is that > once loader path is NULL its type makes no sense. However, since > value of zero corresponds to VIR_DOMAIN_LOADER_TYPE_ROM the > following XML would be produced: >

Re: [libvirt] [PATCH v2 02/15] qemu_domain: Separate NVRAM VAR store file name generation

2019-03-11 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 10:29:12AM +0100, Michal Privoznik wrote: > Move the code that (possibly) generates filename of NVRAM VAR > store into a single function so that it can be re-used later. > > Signed-off-by: Michal Privoznik > Reviewed-by: Laszlo Ersek > --- > src/qemu/qemu_domain.c | 26

Re: [libvirt] [PATCH v2 04/15] virDomainLoaderDefParseXML: Allow loader path to be NULL

2019-03-11 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 10:29:14AM +0100, Michal Privoznik wrote: > Except not really. At least for now. > > In the future, the firmware will be selected automagically. > Therefore, it makes no sense to require the pathname of a > specific firmware binary in the domain XML. But since it is not >

Re: [libvirt] [PATCH v2 03/15] qemu_capabilities: Expose qemu <-> libvirt arch translators

2019-03-11 Thread Daniel P . Berrangé
On Thu, Mar 07, 2019 at 10:29:13AM +0100, Michal Privoznik wrote: > In some cases, the string representing architecture is different > in qemu and libvirt. That is the reason why we have > virQEMUCapsArchFromString() and virQEMUCapsArchToString(). So > far, we did not need them outside of

Re: [libvirt] [dockerfiles PATCH 0/4] Add cross-compilation Dockerfiles

2019-03-11 Thread Daniel P . Berrangé
On Fri, Mar 08, 2019 at 07:00:46PM +0100, Andrea Bolognani wrote: > lcitool supports generating Dockerfiles targeting cross-compilation > of libvirt, so all that's left to do is teach the refresh script > how to pass the necessary information to lcitool. FWIW, I have been working on code to

Re: [libvirt] [PATCH 1/1] tests: fix valgrind.supp path in Makefile

2019-03-11 Thread Michal Privoznik
On 3/11/19 2:19 PM, Shotaro Gotanda wrote: At the current time, several test case result in failure in "make -C tests valgrind". This commit fix the problem. Signed-off-by: Shotaro Gotanda --- tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libvirt] [Qemu-devel] [PULL 0/7] Ui 20190307 patches

2019-03-11 Thread Samuel Thibault
Gerd Hoffmann, le lun. 11 mars 2019 09:33:40 +0100, a ecrit: > > > curses: better wide char support. > > > vnc: acl update, stall fix. > > > Hi; this fails to build on FreeBSD; linking the qemu-system-* > > binaries fails with: > > > > /usr/bin/ld: undefined reference to symbol `libiconv_open'

Re: [libvirt] [Qemu-devel] [PULL 0/5] Ui 20190311 v2 patches

2019-03-11 Thread Daniel P . Berrangé
cb/tags/pull-nbd-2019-03-08' > > into staging (2019-03-09 20:55:44 +) > > > > are available in the Git repository at: > > > > git://git.kraxel.org/qemu tags/ui-20190311-v2-pull-request > > > > for you to fetch changes up to 0143840771548e8ffece831398d745880ddfa080:

Re: [libvirt] [Qemu-devel] [PULL 0/5] Ui 20190311 v2 patches

2019-03-11 Thread Peter Maydell
in the Git repository at: > > git://git.kraxel.org/qemu tags/ui-20190311-v2-pull-request > > for you to fetch changes up to 0143840771548e8ffece831398d745880ddfa080: > > monitor: deprecate acl_show, acl_reset, acl_policy, acl_add, a

Re: [libvirt] [PATCH 0/2] Miscellaneous MBA fixes

2019-03-11 Thread Michal Privoznik
On 3/11/19 11:24 AM, Martin Kletzander wrote: Both together fix https://bugzilla.redhat.com/show_bug.cgi?id=1686274 Martin Kletzander (2): resctrl: Do not calculate free bandwidth for MBA resctrl: Set MBA defaults properly src/util/virresctrl.c | 89

[libvirt] [PATCH 1/1] tests: fix valgrind.supp path in Makefile

2019-03-11 Thread Shotaro Gotanda
At the current time, several test case result in failure in "make -C tests valgrind". This commit fix the problem. Signed-off-by: Shotaro Gotanda --- tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index

[libvirt] [PATCH 0/1] Fix valgrind.supp path in Makefile.am

2019-03-11 Thread Shotaro Gotanda
Hello, I'm Shotaro Gotanda from the University of Tokyo. I'm currently working toward GSOC'19, and creating several pathes for a bite-sized task. In that process, I encountered a problem in valgrind test. In detail, "make -C tests valgrind" failed with several cases even in master branch(commit

Re: [libvirt] [PATCH python] Fix handling of optional params in blockCopy()

2019-03-11 Thread Nir Soffer
On Mon, Mar 11, 2019 at 12:00 PM Daniel P. Berrangé wrote: > On Sun, Mar 10, 2019 at 03:03:25AM +0200, Nir Soffer wrote: > > Commit 2b4bd07e0a22 (Add check for params, nparams being a dictionary) > > changed the way the optional params argument is treated. If > > libvirt.virDomain.blockCopy() is

Re: [libvirt] [perl][PATCH] Add virConnectGetStoragePoolCapabilities binding

2019-03-11 Thread Daniel P . Berrangé
On Sat, Mar 09, 2019 at 09:39:32AM +0100, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > Changes | 1 + > examples/node-info.pl | 13 + > lib/Sys/Virt.pm | 6 ++ > lib/Sys/Virt.xs | 16 > 4 files changed, 36

[libvirt] [PATCH] news: Document kernel requirements for virtual networks

2019-03-11 Thread Michal Privoznik
After 7431b3eb9a05068e4b libvirt requires "filter", "nat" and "mangle" tables to exist for both IPv4 and IPv6. This fact was missed in the news.xml and since we don't have any better place to advertise that let's update old news. Signed-off-by: Michal Privoznik --- docs/news.xml | 4 +++- 1

Re: [libvirt] [PATCH] iptablesSetupPrivateChains: Be forgiving if a table does not exist

2019-03-11 Thread Daniel P . Berrangé
On Mon, Mar 11, 2019 at 12:55:33PM +0100, Michal Privoznik wrote: > On 3/11/19 11:43 AM, Daniel P. Berrangé wrote: > > > > > What I mean is that this transaction is checking the filter, nat and > > mangle tables of both ipv4 and ipv6. You have a missing mangle table > > for ipv6, but this

Re: [libvirt] [PATCH] iptablesSetupPrivateChains: Be forgiving if a table does not exist

2019-03-11 Thread Michal Privoznik
On 3/11/19 11:43 AM, Daniel P. Berrangé wrote: What I mean is that this transaction is checking the filter, nat and mangle tables of both ipv4 and ipv6. You have a missing mangle table for ipv6, but this "ignore errors" policy means we'll even ignore the missing "filter" table for ipv4 for

Re: [libvirt] [PATCH] iptablesSetupPrivateChains: Be forgiving if a table does not exist

2019-03-11 Thread Daniel P . Berrangé
On Mon, Mar 11, 2019 at 11:27:33AM +0100, Michal Privoznik wrote: > On 3/11/19 11:05 AM, Daniel P. Berrangé wrote: > > On Mon, Mar 11, 2019 at 09:37:52AM +0100, Michal Privoznik wrote: > > > The way this function works is that for both iptables and > > > ip6tables (or their firewalld friends) and

Re: [libvirt] [PATCH] iptablesSetupPrivateChains: Be forgiving if a table does not exist

2019-03-11 Thread Michal Privoznik
On 3/11/19 11:05 AM, Daniel P. Berrangé wrote: On Mon, Mar 11, 2019 at 09:37:52AM +0100, Michal Privoznik wrote: The way this function works is that for both iptables and ip6tables (or their firewalld friends) and for every table ("filter", "nat", "mangle") it lists chains defined for the table

[libvirt] [PATCH 0/2] Miscellaneous MBA fixes

2019-03-11 Thread Martin Kletzander
Both together fix https://bugzilla.redhat.com/show_bug.cgi?id=1686274 Martin Kletzander (2): resctrl: Do not calculate free bandwidth for MBA resctrl: Set MBA defaults properly src/util/virresctrl.c | 89 +-- 1 file changed, 52 insertions(+), 37

[libvirt] [PATCH 1/2] resctrl: Do not calculate free bandwidth for MBA

2019-03-11 Thread Martin Kletzander
For CAT we calculate unallocated parts of the cache, however with MBA this does not make sense as the purpose of that is to limit the bandwidth and the setting is only proportional relative to bandwidth settings for other groups. This means it makes sense to set the values to 100% even if there

[libvirt] [PATCH 2/2] resctrl: Set MBA defaults properly

2019-03-11 Thread Martin Kletzander
Similarly to CAT, when you set some values in an group, remove the group and recreate it, the previous values will be kept there. In order to not get values from a previous setting (a previous VM, for example), we need to set them to sensible defaults. The same way we do that for CAT, just set

Re: [libvirt] [PATCH] iptablesSetupPrivateChains: Be forgiving if a table does not exist

2019-03-11 Thread Daniel P . Berrangé
On Mon, Mar 11, 2019 at 09:37:52AM +0100, Michal Privoznik wrote: > The way this function works is that for both iptables and > ip6tables (or their firewalld friends) and for every table > ("filter", "nat", "mangle") it lists chains defined for the table > and then calls

Re: [libvirt] [PATCH python] Fix handling of optional params in blockCopy()

2019-03-11 Thread Daniel P . Berrangé
On Sun, Mar 10, 2019 at 03:03:25AM +0200, Nir Soffer wrote: > Commit 2b4bd07e0a22 (Add check for params, nparams being a dictionary) > changed the way the optional params argument is treated. If > libvirt.virDomain.blockCopy() is called without specifying params, > params is None, and the call

[libvirt] [PATCH] virfilewrapper: Fix indentation

2019-03-11 Thread Martin Kletzander
Signed-off-by: Martin Kletzander --- Pushed as trivial. tests/virfilewrapper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/virfilewrapper.h b/tests/virfilewrapper.h index 9e3816b64493..044c53223251 100644 --- a/tests/virfilewrapper.h +++ b/tests/virfilewrapper.h @@

Re: [libvirt] [PATCH 1/2] qemu: Improve validation for virtio input devices

2019-03-11 Thread Andrea Bolognani
On Fri, 2019-03-08 at 15:05 -0500, Cole Robinson wrote: > On 3/6/19 7:17 AM, Andrea Bolognani wrote: > > +DO_TEST_PARSE_ERROR("virtio-transitional-not-supported", > > +QEMU_CAPS_DEVICE_DMI_TO_PCI_BRIDGE, > > +QEMU_CAPS_DEVICE_PCI_BRIDGE, > > +

[libvirt] [PATCH] iptablesSetupPrivateChains: Be forgiving if a table does not exist

2019-03-11 Thread Michal Privoznik
The way this function works is that for both iptables and ip6tables (or their firewalld friends) and for every table ("filter", "nat", "mangle") it lists chains defined for the table and then calls iptablesPrivateChainCreate() over the list. The callback is then supposed to find libvirt private

Re: [libvirt] [Qemu-devel] [PULL 0/7] Ui 20190307 patches

2019-03-11 Thread Gerd Hoffmann
> > curses: better wide char support. > > vnc: acl update, stall fix. > Hi; this fails to build on FreeBSD; linking the qemu-system-* > binaries fails with: > > /usr/bin/ld: undefined reference to symbol `libiconv_open' (try adding > -liconv) > //usr/local/lib/libiconv.so.2: could not read

[libvirt] [PULL 2/5] curses: support wide input

2019-03-11 Thread Gerd Hoffmann
From: Samuel Thibault This makes use of wide curses functions instead of 8bit functions. This allows to type e.g. accented letters. Unfortunately, key codes are then returned with values that could be confused with wide characters by ncurses, so we need to add a maybe_keycode variable to know

[libvirt] [PULL 3/5] vnc: fix update stalls

2019-03-11 Thread Gerd Hoffmann
vnc aborts display update jobs on video mode switches and page flips. That can cause vnc update stalls in case an unfinished vnc job gets aborted. The vnc client will never receive the requested update then. Fix that by copying the state from job_update back to update in that case. Reports

[libvirt] [PULL 4/5] vnc: allow specifying a custom authorization object name

2019-03-11 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The VNC server has historically had support for ACLs to check both the SASL username and the TLS x509 distinguished name. The VNC server was responsible for creating the initial ACL, and the client app was then responsible for populating it with rules using the HMP

[libvirt] [PULL 0/5] Ui 20190311 v2 patches

2019-03-11 Thread Gerd Hoffmann
The following changes since commit e2a18635a400b0e68679614132e9ef6316105590: Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2019-03-08' into staging (2019-03-09 20:55:44 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/ui-20190311-v2-pull-request

[libvirt] [PULL 5/5] monitor: deprecate acl_show, acl_reset, acl_policy, acl_add, acl_remove

2019-03-11 Thread Gerd Hoffmann
From: Daniel P. Berrangé The various ACL related commands are obsolete now that the QAuthZ framework for authorization is fully integrated throughout QEMU network services. These only ever worked with VNC and were never used by libvirt. Mark it as deprecated with no direct replacement to be

[libvirt] [PULL 1/5] Reduce curses escdelay from 1s to 25ms

2019-03-11 Thread Gerd Hoffmann
From: Samuel Thibault By default, curses will only report single ESC key event after 1s delay, since ESC is also used for keypad escape sequences. This however makes users believe that ESC is not working. Reducing to 25ms provides good user experience, while still allowing 25ms for keypad

Re: [libvirt] New Feature: Intel MKTME Support

2019-03-11 Thread Mohammed, Karimullah
Hi Daniel, Thank you for your valuable suggestion and we started looking into Libvirt code in that perspective and will soon send a low level design for our implementation of keyctl calls in Libvirt. We will put together QEMU monitoring commands as well as vm launch, using mktme keys in one