Signed-off-by: Han Han
---
src/libvirt-admin.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libvirt-admin.c b/src/libvirt-admin.c
index 4ae50b188f..cf40ea122e 100644
--- a/src/libvirt-admin.c
+++ b/src/libvirt-admin.c
@@ -1236,7 +1236,7 @@ virAdmConnectSetLoggingFilters
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 76 ++
1 file changed, 76 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 99cba7db42..d6f1adf6e9 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index d6f1adf6e9..6698fb7cf6 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -3070,6 +3070,17 @@ testDomai
Signed-off-by: Ilias Stamatis
---
src/test/test_driver.c | 70 ++
1 file changed, 70 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index a6f239b9f1..99cba7db42 100755
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@
The current implementation of testDomainGetVcpus is erroneous. When
offline vcpus are encountered in the vm definition, the corresponding
fields in the output array are left empty. Additionally some vcpus are
not reported at all due to the wrong invariant checking done in the
loop.
Make testDomain
Ilias Stamatis (4):
test_driver: make testDomainGetVcpus report all vcpus
test_driver: implement virDomainGetGuestVcpus
test_driver: implement virDomainSetVcpu
test_driver: implement virDomainSetGuestVcpus
src/test/test_driver.c | 167 +++--
1 file chan
(CCing Nikolay Shirokovskiy, author of 29f2b5248c )
On 8/7/19 8:34 AM, Roman Bolshakov wrote:
An attempt to poweroff a VM from inside triggers the error for existing
session of virsh console and it returns with non-zero exit code:
error: internal error: console stream EOF
The message and st
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> Unlike host-model, host-passthrough does not do any check, it just passes
> "-cpu host" blindly. Therefore, lack of flags can and will result in
> crashes---SIGSEGV if it happens in userspace, but worse if for example the
> destination doesn't have an
Unlike host-model, host-passthrough does not do any check, it just passes
"-cpu host" blindly. Therefore, lack of flags can and will result in
crashes---SIGSEGV if it happens in userspace, but worse if for example the
destination doesn't have an MSR that should be there according to the
kernel.
Pa
On Fri, 2019-08-02 at 14:54 +0200, Paolo Bonzini wrote:
> host-passthrough documentation menions that the source and
Small nit: menions -> mentions
> destination
> hosts are not identical in both hardware and
> configuration. Configuration
> actually includes microcode version and QEMU version,
On Wed, 2019-07-31 at 15:29 +0200, Fabiano Fidêncio wrote:
> libosinfo Dockerfile will consist on a single container that will be
No opinion on the patch, but... "consist on" -> "consist of" ;)
> able to build & test libosinfo, osinfo-db-tools, and osinfo-db. And
> from
> those "subprojects", onl
On Wed, 2019-08-07 at 10:30 +0200, Michal Privoznik wrote:
> v2 of:
>
> https://www.redhat.com/archives/libvir-list/2019-July/msg01225.html
>
> diff to v1:
> - Rebase and adapt to new checkpoint completer
>
> Michal Prívozník (15):
> tools: s/Nodedev/NodeDevice/
> tools: Expose virshCommaStr
On Wed, 2019-08-07 at 16:50 +0200, Fabiano Fidêncio wrote:
> This patch series aims to add libosinfo Dockerfiles to this project, so
> those containers can be used by libosinfo projects' gitlab CI.
>
> Please, take a look at each patch for more context of what has been done.
>
> Changes since v2:
This reverts commit f38d553e2d6ec2f041cb7947b5eafcdd3b26ae65.
Gnulib's make coverage (or init-coverage, build-coverage, gen-coverage)
is not a 1-1 replacement for the original configure option. Our old
--enable-test-coverage seems to be close to gnulib's make build-coverage
except gnulib runs lcov
QEMU finally exposes an interface which allows us to instruct it to
format or create arbitrary images. This is required for blockdev
integration of block copy and snapshots as we need to pre-format images
prior to use with blockdev-add.
This path introduces job handling and also helpers for format
Rather than copying just the top level image, let's copy the full user
provided backing chain.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_blockjob.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c
index 8
The only code path which calls the parser with the
VIR_DOMAIN_DEF_PARSE_DISK_SOURCE is from qemuDomainBlockCopy. Since that
code path can properly handle backing chains for the disk and it's
desired to pass the parsed chains to the block copy code remove the
condition which prevents parsing the el
Allow reusing original backing chain when doing a shallow copy without
reuse of external image. The existing logic didn't allow it but it will
be possible. Also add a note to explain that logic.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 29 +
1 file cha
Rename qemuDomainObjPrivateXMLFormatBlockjobFormatChain to
qemuDomainObjPrivateXMLFormatBlockjobFormatSource and add a 'chain'
parameter which allows controlling whether the backing chain is
formatted.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 32 ++--
In commit 3f93884a4d0 where the job handling of commit jobs with
blockdev was added I've forgot to add a 'break' in the switch fomatting
the status XML. Thankfully this would not be a problem as the cases
where this fell through didn't have any code.
Signed-off-by: Peter Krempa
---
src/qemu/qemu
Add virStorageFileSupportsCreate which allows silent check whether
virStorageFileCreate is implemented.
Signed-off-by: Peter Krempa
---
src/libvirt_private.syms | 1 +
src/util/virstoragefile.c | 20
src/util/virstoragefile.h | 1 +
3 files changed, 22 insertions(+)
diff
Now that we support blockdev for qemuDomainBlockCopy we can allow
copying to remote destinations as well.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 47 --
1 file changed, 32 insertions(+), 15 deletions(-)
diff --git a/src/qemu/qemu_driver.c
The utility of the function is extremely limited as for block copy
we need to register the mirror chain earlier than when it's set with the
disk. This means that it would be open-coded in that case.
Avoid any weird usage and just open-code the only current usage, remove
the function, and reword th
Modify the return value so that callers don't have to repeat logic.
Signed-off-by: Peter Krempa
---
src/util/virstoragefile.c | 39 ---
1 file changed, 20 insertions(+), 19 deletions(-)
diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c
index
Implement job handling for the block copy job (drive/blockdev-mirror)
when using -blockdev. In contrast to the previously implemented
blockjobs the block copy job introduces new images to the running qemu
instance, thus requires a bit more handling.
When copying to new images the code now makes us
Add support for running a block-copy with -blockdev. This requires us to
format our own images, so this series also adds support for
blockdev-create which allows to do such a thing with qemu directly.
blockdev-create will also be used with snapshots.
Peter Krempa (12):
qemu: domain: Allow forma
Commit 16ca234b56fac82 refactored how the 'shallow' and 'reuse' flags
are accessed but neglected to fix the clearing of 'shallow' in case when
the disk has no backing chain. This means that we'd request a shallow
copy even without backing chain and also a few checks would work wrong.
Fix it by usi
On Thu, 2019-08-08 at 16:37 +0100, Daniel P. Berrangé wrote:
> On Thu, Aug 08, 2019 at 05:33:40PM +0200, Andrea Bolognani wrote:
> > On Thu, 2019-08-08 at 16:10 +0100, Daniel P. Berrangé wrote:
> > > +++ b/src/remote/remote_daemon_dispatch.c
> > > @@ -2077,6 +2105,9 @@ remoteDispatchConnectOpen(vir
On Thu, Aug 08, 2019 at 05:33:40PM +0200, Andrea Bolognani wrote:
> On Thu, 2019-08-08 at 16:10 +0100, Daniel P. Berrangé wrote:
> > +++ b/src/remote/remote_daemon_dispatch.c
> > @@ -2077,6 +2105,9 @@ remoteDispatchConnectOpen(virNetServerPtr server
> > ATTRIBUTE_UNUSED,
> > unsigned int flag
On Thu, 2019-08-08 at 16:10 +0100, Daniel P. Berrangé wrote:
> +++ b/src/remote/remote_daemon_dispatch.c
> @@ -2077,6 +2105,9 @@ remoteDispatchConnectOpen(virNetServerPtr server
> ATTRIBUTE_UNUSED,
> unsigned int flags;
> struct daemonClientPrivate *priv =
> virNetServerClientGetPrivate
On Thu, 2019-08-08 at 16:10 +0100, Daniel P. Berrangé wrote:
> +++ b/src/remote/remote_daemon.c
> @@ -906,9 +912,9 @@ daemonUsage(const char *argv0, bool privileged)
> { "-h | --help", N_("Display program help") },
> { "-v | --verbose", N_("Verbose messages") },
> { "-d |
On Thu, 2019-08-08 at 16:10 +0100, Daniel P. Berrangé wrote:
> +++ b/src/remote/libvirtd.conf.in
> # Use of TLS requires that x509 certificates be issued. The default locations
> # for the certificate files is as follows:
> #
> -# /etc/pki/CA/cacert.pem - The CA master certific
The virtvboxd daemon will be responsible for providing the vbox API
driver functionality. The vbox driver is still loaded by the main
libvirtd daemon at this stage, so virtvboxd must not be running at
the same time.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
.gitignore
The virtstoraged daemon will be responsible for providing the storage API
driver functionality. The storage driver is still loaded by the main
libvirtd daemon at this stage, so virtstoraged must not be running at
the same time.
Reviewed-by: Christophe de Dinechin
Reviewed-by: Andrea Bolognani
Si
The driver dispatch methods access the priv->conn variables directly.
In future we want to dynamically open the connections for the secondary
driver. Thus we want the methods to call a method to get the connection
handle instead of assuming the private variable is non-NULL.
Reviewed-by: Andrea Bol
The make logic assumes that the SYSTEMD_UNIT_FILES var can be built from
SYSTEMD_UNIT_FILES_IN by simply dropping the directory prefix and the
.in suffix.
This won't work in future when a single .in unit file can be used to
generate multiple different units.
Reviewed-by: Andrea Bolognani
Signed-
The virtqemud daemon will be responsible for providing the qemu API
driver functionality. The qemu driver is still loaded by the main
libvirtd daemon at this stage, so virtqemud must not be running at
the same time.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
.gitignore
The virtxend daemon will be responsible for providing the libxl API
driver functionality. The libxl driver is still loaded by the main
libvirtd daemon at this stage, so virtxend must not be running at
the same time.
This naming is slightly different than other drivers. With the libxl
driver, the u
The virtvzd daemon will be responsible for providing the vz API
driver functionality. The vz driver is still loaded by the main
libvirtd daemon at this stage, so virtvzd must not be running at
the same time.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
.gitignore
When running in libvirtd, we are happy for any of the drivers to simply
skip their initialization in virStateInitialize, as other drivers are
still potentially useful.
When running in per-driver daemons though, we want the daemon to abort
startup if the driver cannot initialize itself, as the daem
The ssh, libssh, libssh2 & unix transports all need to use a UNIX socket
path, and duplicate some of the same logic for error checking. Pull this
out into a separate method to increase code sharing.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
src/remote/remote_driver.c |
The virtbhyved daemon will be responsible for providing the bhyve API
driver functionality. The bhyve driver is still loaded by the main
libvirtd daemon at this stage, so virtbhyved must not be running at
the same time.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
.gitign
Using @VARNAME@ is a normal style of automake, so lets match that.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
build-aux/augeas-gentest.pl | 2 +-
src/bhyve/test_libvirtd_bhyve.aug.in| 2 +-
src/libxl/test_libvirtd_libxl.aug.in| 2 +-
src/locking/test
Instead of open-coding a string -> enum conversion, use the enum helpers
for the remote driver transport. The old code uses STRCASEEQ, so we must
force the URI transport to lowercase for sake of back-compatibility.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
src/remote/r
The libvirtd daemon provides the traditional libvirt experience where
all the drivers are in a single daemon, and is accessible over both
local UNIX sockets and remote IP sockets.
In the new world we're having a set of per-driver daemons which will
primarily be accessed locally via their own UNIX
The remote daemon tries to print out its help text in a couple of giant
blocks of text. This has already lead to duplication of the text for the
privileged vs unprivileged execution mode. With the introduction of more
daemons, this text is going to be duplicated many more times with small
variation
The augeas-gentest.pl program merges a config file into a augeas
file, saving the output to a new file. It is going to be useful
to further process the output file, and it would be easier if this can
be done with a pipeline, so change augeas-gentest.pl to write to stdout
instead of a file.
Reviewe
The client parameter is always used to get access to the private data
struct.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
src/remote/remote_daemon_dispatch.c | 98 ++---
1 file changed, 49 insertions(+), 49 deletions(-)
diff --git a/src/remote/re
When the client has a connection to one of the hypervisor specific
daemons (eg virtqemud), the app may still expect to use the secondary
driver APIs (storage, network, etc). None of these will be registered in
the hypervisor daemon, so we must explicitly open a connection to each
of the daemons for
Instead of each subdir containing its own custom rule for checking the
augeas tests, use common rule for all.
The new rule searches both src + build dirs for include files, since
some augeas files will be auto-generated very shortly.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrang
The virtnwfilterd daemon will be responsible for providing the nwfilter API
driver functionality. The nwfilter driver is still loaded by the main
libvirtd daemon at this stage, so virtnwfilterd must not be running at
the same time.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
Historically URIs handled by the remote driver will always connect to
the libvirtd UNIX socket. There will now be one daemon per driver, and
each of these has its own UNIX sockets to connect to.
It will still be possible to run the traditional monolithic libvirtd
though, which will have the origin
The virtnodedevd daemon will be responsible for providing the nodedev API
driver functionality. The nodedev driver is still loaded by the main
libvirtd daemon at this stage, so virtnodedevd must not be running at
the same time.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
The virtproxyd daemon is merely responsible for forwarding RPC calls to
one of the other per-driver daemons. As such, it does not have any
drivers loaded and so regular auto-probing logic will not work. We need
it to be able to handle NULL URIs though, so must implement some kind of
alternative pro
If the event (un)registration methods are invoked while no connection is
open, they jump to a cleanup block which unlocks a mutex which is not
currently locked.
Reviewed-by: Ján Tomko
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
src/remote/remote_daemon_dispatch.c | 64 +
Prepare for reusing libvirtd socket unit files with other daemons by
making various parts of their config conditionally defined by the make
rules.
Reviewed-by: Christophe de Dinechin
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
src/remote/Makefile.inc.am | 4 ++
The same make variables will be useful for building both libvirtd and
the split daemons, so refactor & rename variables to facilitate reuse.
Automake gets annoyed if you define a variable ending LDFLAGS:
src/remote/Makefile.inc.am:53: warning: variable 'REMOTE_DAEMON_LDFLAGS' is
defined but no p
The make rules for the systemd socket unit files are all essentially
identical and can be collapsed into a single generic rule. The service
unit file rule can be simplified too.
Reviewed-by: Christophe de Dinechin
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
src/Makefile
Substitute in the @sysconfigdir@ value instead of /etc.
Reviewed-by: Christophe de Dinechin
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
src/locking/Makefile.inc.am | 1 +
src/locking/virtlockd.service.in| 2 +-
src/logging/Makefile.inc.am | 1 +
s
The virtlxcd daemon will be responsible for providing the lxc API
driver functionality. The lxc driver is still loaded by the main
libvirtd daemon at this stage, so virtlxcd must not be running at
the same time.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
.gitignore
The current make rules are inconsistent about which directory the
augeas test files are created in. Put them all in the same dir as
their source.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
.gitignore | 9 ++---
src/bhyve/Makefile.inc.am | 8
The driver dispatch methods access the priv->conn variables directly.
In future we want to dynamically open the connections for the secondary
driver. Thus we want the methods to call a method to get the connection
handle instead of assuming the private variable is non-NULL.
Reviewed-by: Andrea Bol
The virtinterfaced daemon will be responsible for providing the interface API
driver functionality. The interface driver is still loaded by the main
libvirtd daemon at this stage, so virtinterfaced must not be running at
the same time.
Reviewed-by: Christophe de Dinechin
Reviewed-by: Andrea Bolog
GNULIB sets $(LIBSOCKET) on mingw to pull in the windows socket
APIs. This is trivially not required, since we don't build libvirtd
on mingw.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
src/remote/Makefile.inc.am | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/rem
Prepare for reusing libvirtd source to create other daemons by making
the daemon name conditionally defined by the make rules.
Reviewed-by: Christophe de Dinechin
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
src/remote/Makefile.inc.am| 1 +
src/remote/remote_dae
We already have a variable that lists all augeas test files, so we can
add everything to CLEANFILES at once.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
src/Makefile.am | 1 +
src/libxl/Makefile.inc.am | 1 -
src/locking/Makefile.inc.am | 4 +---
src/loggin
The virtnetworkd daemon will be responsible for providing the network API
driver functionality. The network driver is still loaded by the main
libvirtd daemon at this stage, so virtnetworkd must not be running at
the same time.
Reviewed-by: Christophe de Dinechin
Reviewed-by: Andrea Bolognani
Si
The admin client now supports addressing the per-driver daemons using
the obvious URI schemes for each daemon. eg virtqemud:///system
virtqemud:///session, etc.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
src/libvirt-admin.c | 33 -
1 file
The virtsecretd daemon will be responsible for providing the secret API
driver functionality. The secret driver is still loaded by the main
libvirtd daemon at this stage, so virtsecretd must not be running at
the same time.
Reviewed-by: Christophe de Dinechin
Reviewed-by: Andrea Bolognani
Signed
This is what all the driver refactoring I've done has been about
enabling.
We gain new daemons for each driver, for the primary virt drivers:
virtlibxld
virtlxcd
virtqemud
virtvboxd
virtvzd
And again for the secondary drivers
virtinterfaced
virtnetworkd
virtnodedevd
virtnwfilt
Prepare for reusing libvirtd source to create other daemons by making
the driver(s) to load conditionally defined by the make rules.
If nothing is set, all drivers will be loaded, ignoring any missing ones
as historically done.
If MODULE_NAME is set only one driver will be loaded and that one mus
Prepare for reusing libvirtd augeas defintions with other daemons by
making the config parameters for IP sockets conditionally defined by
the make rules.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
.gitignore | 1 +
src/remote/Makefile.
Prepare for reusing libvirtd config to create other daemons by making
the config parameters for IP sockets conditionally defined by the make
rules.
The main libvirtd daemon will retain IP listen ability, but all the
driver specific daemons will be local UNIX sockets only. Apps needing
IP connectiv
Prepare for reusing libvirtd source to create other daemons by making
the use of IP sockets conditionally defined by the make rules.
The main libvirtd daemon will retain IP listen ability, but all the
driver specific daemons will be local UNIX sockets only. Apps needing
IP connectivity will connec
Instead of adding generated config files to CLEANFILES and BUILT_SOURCES
in each makefile, add them all at once.
Reviewed-by: Andrea Bolognani
Signed-off-by: Daniel P. Berrangé
---
src/Makefile.am | 3 +++
src/locking/Makefile.inc.am | 8
2 files changed, 3 insertions(+), 8
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
.../net-user.x86_64-4.0.0.args| 34 +++
tests/qemuxml2argvtest.c | 16 +
tests/testutilsqemu.h | 1 +
3 files changed, 51 insertions(+)
create mode
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_hotplug.c | 33 ++---
src/qemu/qemu_monitor.c | 13 ++---
src/qemu/qemu_monitor.h | 3 ++-
3 files changed, 42 insertions(+), 7 deletions(-)
diff --git a/src/qemu/qemu_hotplug.c b/sr
From: Marc-André Lureau
When the network interface is of "user" type, and QEMU has the "-net
socket,fd=" datagram support, call qemuInterfacePrepareSlirp() to
probe and associate a slirp-helper with the interface.
The usage of automated slirp-helper can be prevented with
disableSlirp (in particu
From: Marc-André Lureau
Add a generic way to run a command through the security management.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_security.c | 22 ++
src/qemu/qemu_security.h | 6 ++
2 files changed, 28 insertions(+)
diff --git a/src/qemu/qemu_security.c
From: Marc-André Lureau
If a slirp-helper is associated with a network interface,
prepare/start/stop the process via qemu-extdevice.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_extdevice.c | 47 +--
src/qemu/qemu_extdevice.h | 5 +++--
src/qemu/qemu_
From: Marc-André Lureau
pid filenames (from swtpm and other helpers from this series) are
based on VM shortname, which is derived from VM id. If the id is reset
to early, the state filenames will not be found.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_process.c | 4 ++--
1 file change
From: Marc-André Lureau
A slirp helper is a process that provides user-mode networking through
a unix domain socket. It is expected to follow the following
specification:
https://gitlab.freedesktop.org/slirp/libslirp-rs/blob/master/src/bin/README.rst
Signed-off-by: Marc-André Lureau
---
m4/vir
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_domain.c | 39 +++
src/qemu/qemu_domain.h | 12
2 files changed, 51 insertions(+)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 806dbfd1f8..7315fe103
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_migration.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 86b4bfd970..c607e9f909 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_
From: Marc-André Lureau
Once QEMU is started, the qemuDomainLogContext is owned by it, and can
no longer be used from libvirt. Instead, use
qemuDomainLogAppendMessage() which will redirect the log.
This is not strictly necessary for swtpm, but the following patches
are going to reuse qemuExtDevi
From: Marc-André Lureau
dbus_message_new() does not construct correct replies by itself, it is
recommended to use dbus_message_new_method_return() instead.
Signed-off-by: Marc-André Lureau
---
src/util/virdbus.c | 18 --
src/util/virdbus.h | 6 --
tests/virfirewa
From: Marc-André Lureau
Datagram socket is available since qemu 4.0, commit
fdec16e3c2a614e2861f3086b05d444b5d8c3406 ("net/socket: learn to talk
with a unix dgram socket").
Required for slirp-helper communication.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c
From: Marc-André Lureau
For VM started and migrated/saved without slirp-helpers, let's prevent
the automatic setup (as it would fail to migrate otherwise).
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_domain.c | 30 --
src/qemu/qemu_domain.h | 2 ++
src/qemu/
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_migration.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 7c6be201b9..86b4bfd970 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migrati
From: Marc-André Lureau
If a slirp-helper is associated with a network interface (after
probing & preparing succesfully), pass the socket fd to QEMU and use
"-net socket,fd=".
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_command.c | 35 +--
src/qemu/qemu_c
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/conf/domain_conf.c | 21 -
src/conf/domain_conf.h | 6 ++
2 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 0456369d55..fb0904177f 100644
From: Marc-André Lureau
Save & restore the slirp helper PID associated with a network
interface & the probed features.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_domain.c | 137 +
src/qemu/qemu_domain.h | 2 +-
2 files changed, 138 insertions(+
From: Marc-André Lureau
This object is being proposed to qemu upstream "Add dbus-vmstate
object". It handles data migration of external processes.
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 3 insertions(+)
dif
From: Marc-André Lureau
The unit provides the functions associated with a slirp-helper:
- probing / checking capabilities
- opening the socketpair
- starting / stoping the helper
- registering for dbus-vmstate migration
Signed-off-by: Marc-André Lureau
---
src/qemu/Makefile.inc.am | 2 +
src
From: Marc-André Lureau
It is failing, because it ends up being parsed with version='default'
and expects '1.2' instead.
Signed-off-by: Marc-André Lureau
---
tests/qemuxml2argvdata/tpm-emulator.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemuxml2argvdata/tpm-e
From: Marc-André Lureau
Hi,
SLIRP networking can be running in a separate process. This allows for
stricter security policies for QEMU & SLIRP, as SLIRP is notoriously
not very safe (discussed on ML, various CVEs, and even the code says
so explicitly in the comments), yet people rely on it for v
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qemu/qemu_conf.c | 4
src/qemu/qemu_conf.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 4b84cb6dea..7d2e84b5bb 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_c
From: Marc-André Lureau
Add dbusVMStates to keep a list of dbus-vmstate objects needed for
migration. They are populated on the command line during start or
qemuDBusVMStateAdd/Remove() will hotplug them as needed.
Signed-off-by: Marc-André Lureau
---
src/qemu/Makefile.inc.am | 2 +
src/qemu/q
From: Marc-André Lureau
Consistent code style across editors.
Signed-off-by: Marc-André Lureau
---
.editorconfig | 21 +
1 file changed, 21 insertions(+)
create mode 100644 .editorconfig
diff --git a/.editorconfig b/.editorconfig
new file mode 100644
index 00..e76
Fix some typos and grammar (calling something safer and error-prone is
odd, and 'ther eneeds' is an obvious typo), and reflow some long
lines.
Signed-off-by: Eric Blake
---
Makefile.ci | 38 +-
1 file changed, 21 insertions(+), 17 deletions(-)
diff --git a/Ma
1 - 100 of 128 matches
Mail list logo