Re: [PATCH] net: Remove deprecated [hub_id name] tuple of 'hostfwd_add' / 'hostfwd_remove'

* Thomas Huth (th...@redhat.com) wrote: > On 05/12/2019 11.41, Thomas Huth wrote: > > It's been deprecated since QEMU v3.1.0. Time to finally remove it now. > > > > Signed-off-by: Thomas Huth For hmp: Acked-by: Dr. David Alan Gilbert would want an ack from Samuel (or maybe Marc-André) Dave

Re: [libvirt PATCH] docs: add news item about GNULIB removal

On Fri, 2020-02-07 at 16:21 +, Daniel P. Berrangé wrote: > While we have CI testing coverage for many platforms, we don't test any > non-GLibC based Linux and there are other non-Linux platforms we don't It's "glibc", not "GLibC". > officially target, both of which might hit regressions. >

[libvirt PATCH] docs: add news item about GNULIB removal

While we have CI testing coverage for many platforms, we don't test any non-GLibC based Linux and there are other non-Linux platforms we don't officially target, both of which might hit regressions. Signed-off-by: Daniel P. Berrangé --- docs/news.xml | 19 +++ 1 file changed, 19

[libvirt PATCH] docs: reduce excessive spacing in ToC for RST files

The table of contents in the RST based files uses tags inside the , which results in 1em's worth of spacing above & below each entry. This results in way too much whitespace in the ToC. Signed-off-by: Daniel P. Berrangé --- docs/libvirt.css | 4 1 file changed, 4 insertions(+) diff --git

[libvirt PATCH] src: use closefrom() for mass closing of FDs

On FreeBSD 12 the default ulimit settings allow for 100,000 open file descriptors. As a result spawning processes in libvirt is abominably slow. Fortunately FreeBSD has long since provided a good solution in the form of closefrom(), which closes all FDs equal to or larger than the specified

Re: [PATCH 1/2] docs: virsh: Modernize docs for qemu-monitor-command

On 2/7/20 3:07 AM, Peter Krempa wrote: Mention that we actually by default use QMP and clarify the rest of the documentation. Signed-off-by: Peter Krempa --- docs/manpages/virsh.rst | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git

Re: [libvirt PATCH] docs: add a kbase explaining security protections for QEMU passthrough

On Thu, Feb 06, 2020 at 01:05:37PM +, Daniel P. Berrangé wrote: The core content reads very well. A couple of minor nit-picks inline. [...] > diff --git a/docs/kbase/qemu-passthrough-security.rst > b/docs/kbase/qemu-passthrough-security.rst > new file mode 100644 > index

Re: New release of libvirt-php?

On 2/7/20 2:10 PM, Neal Gompa wrote: Hey, Agreed, I will create a release over the weekend. Michal

[libvirt PATCH] tests: avoid referencing stale readdir pointer

The contents of 'struct dirent' are only valid until the next call to readdir() or closedir(). It is thus invalid to save a pointer to the 'd_name' field. Somehow this hasn't affected the test suite until recently when FreeBSD 12 started showing use of uninitialized memory resulting in test

Re: [PATCH v3 5/7] ui/gtk: implement show-cursor option

On 2/7/20 4:17 AM, Gerd Hoffmann wrote: When specified just set null_cursor to NULL so we get the default pointer instead of a blank pointer. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index

[libvirt PATCH v2 7/8] docs: List the armvtimer timer among all others

Signed-off-by: Andrea Bolognani --- docs/formatdomain.html.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 44e2062d01..3e899ffe4e 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@

[libvirt PATCH v2 6/8] tests: Add test case for the armvtimer timer

Signed-off-by: Andrea Bolognani --- .../clock-timer-armvtimer.aarch64-latest.args | 32 +++ .../clock-timer-armvtimer.xml | 27 tests/qemuxml2argvtest.c | 2 ++ .../clock-timer-armvtimer.aarch64-latest.xml | 1 +

[libvirt PATCH v2 8/8] news: Mention the armvtimer timer

Signed-off-by: Andrea Bolognani --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index f567a1182e..5aa9d081a7 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -82,6 +82,16 @@ "type" and "persistent" attributes.

[libvirt PATCH v2 2/8] qemu: Add the QEMU_CAPS_CPU_KVM_NO_ADJVTIME capability

We will use this capability to detect whether the QEMU binary supports the kvm-no-adjvtime CPU feature. Reviewed-by: Ján Tomko Signed-off-by: Andrea Bolognani --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 +

[libvirt PATCH v2 1/8] qemu: Use switch statement in qemuBuildCpuCommandLine()

Make sure we are taking all possible virDomainTimerNameType values into account. This will make upcoming changes easier. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_command.c | 34 -- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git

[libvirt PATCH v2 3/8] conf: Introduce VIR_DOMAIN_TIMER_NAME_ARMVTIMER

This new timer model will be used to control the behavior of the virtual timer for KVM ARM/virt guests. Signed-off-by: Andrea Bolognani --- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c| 1 + src/conf/domain_conf.h| 1 + src/libxl/libxl_conf.c| 1 +

[libvirt PATCH v2 4/8] qemu: Validate configuration for the armvtimer timer

Its use is limited to certain guest types, and it only supports a subset of all possible tick policies. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_domain.c | 33 + 1 file changed, 33 insertions(+) diff --git a/src/qemu/qemu_domain.c

[libvirt PATCH v2 5/8] qemu: Format the armvtimer timer on the command line

Its behavior is controlled by a KVM-specific CPU feature. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_command.c | 13 + 1 file changed, 13 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 71ae1f72e5..60f8820c64 100644 ---

[libvirt PATCH v2 0/8] qemu: Add support for the armvtimer timer

This new timer model can be used to control the behavior of the virtual timer for KVM ARM/virt guests. Changes from [v1]: * redesign the XML interface completely, notably moving the configuration knob from to . [v1] https://www.redhat.com/archives/libvir-list/2020-January/msg01475.html

Re: [PATCH v3 1/7] ui: add show-cursor option

Gerd Hoffmann writes: > When enabled, this forces showing the mouse cursor, > i.e. do not hide the pointer on mouse grabs. > Defaults to off. > > Signed-off-by: Gerd Hoffmann > --- > qapi/ui.json | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/qapi/ui.json b/qapi/ui.json > index

Re: New release of libvirt-php?

On Fri, Feb 7, 2020 at 8:10 AM Neal Gompa wrote: > > Hey, > > It's been a couple of years (!!!) since the last libvirt-php release. > Since then, the code has been pretty dramatically restructured to more > closely mimic how libvirt and other bindings are structured. With that > and the new API

New release of libvirt-php?

Hey, It's been a couple of years (!!!) since the last libvirt-php release. Since then, the code has been pretty dramatically restructured to more closely mimic how libvirt and other bindings are structured. With that and the new API add just pushed, could we get a new release of libvirt-php?

Re: [libvirt PATCH 2/2] qemu: preserve error on bandwidth rollback

On 2/7/20 8:54 AM, Ján Tomko wrote: We call APIs that reset the error in the rollback code. Preserve the error from the original call that failed. This turns the boringly cryptic: error: Unable to set interface parameters error: An error occurred, but the cause is unknown to the

Re: [libvirt PATCH 1/2] qemu: do not revert to NULL bandwidth

On 2/7/20 8:54 AM, Ján Tomko wrote: Otherwise an attempt to set an invalid value: virsh domiftune rhel8.2 vnet0 --outbound 4294968 on an interface with no bandwidth set crashes. Signed-off-by: Ján Tomko Fixes: f02e21cb3379a41cd42f2d8116f2d10dabace83b

Re: [libvirt PATCH 0/3] qemu: Fix default CPU for old s390 machine types

On Fri, Feb 7, 2020 at 9:35 AM Christian Ehrhardt < christian.ehrha...@canonical.com> wrote: > > > On Thu, Feb 6, 2020 at 11:25 AM Jiri Denemark wrote: > >> See the last patch for detailed description and >> https://bugzilla.redhat.com/show_bug.cgi?id=1795651 for a discussion >> about this

[libvirt PATCH 2/2] qemu: preserve error on bandwidth rollback

We call APIs that reset the error in the rollback code. Preserve the error from the original call that failed. This turns the boringly cryptic: error: Unable to set interface parameters error: An error occurred, but the cause is unknown to the unexpectedly anarchist: error: internal error:

[libvirt PATCH 0/2] qemu: fix crash on invalid bandwidth request

https://bugzilla.redhat.com/show_bug.cgi?id=1800505 Ján Tomko (2): qemu: do not revert to NULL bandwidth qemu: preserve error on bandwidth rollback src/qemu/qemu_driver.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) -- 2.21.1

[libvirt PATCH 1/2] qemu: do not revert to NULL bandwidth

Otherwise an attempt to set an invalid value: virsh domiftune rhel8.2 vnet0 --outbound 4294968 on an interface with no bandwidth set crashes. Signed-off-by: Ján Tomko Fixes: f02e21cb3379a41cd42f2d8116f2d10dabace83b https://bugzilla.redhat.com/show_bug.cgi?id=1800505 --- src/qemu/qemu_driver.c

Re: [libvirt PATCH] testutils: print a helpful summary of failed tests

On Thu, Feb 06, 2020 at 05:35:05PM +0100, Ján Tomko wrote: > When debugging test failures in seven independent test > cases, it might be helpful to only gather the debug output > of the failing cases. > > Record the indexes of the tests that fail and print them > in the VIR_TEST_RANGE of the

[PATCH v3 5/7] ui/gtk: implement show-cursor option

When specified just set null_cursor to NULL so we get the default pointer instead of a blank pointer. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index d18892d1de61..a685d1ae0848 100644 --- a/ui/gtk.c

[PATCH v3 3/7] ui/sdl: switch to new show-cursor option

Use DisplayOpts settings instead of cursor_hide global variable. Also make "-display sdl,show-cursor=on" work. Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 16 vl.c | 10 ++ 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index

[PATCH v3 2/7] ui: wire up legacy -show-cursor option

Set new show-cursor display option when legacy -show-cursor is specified on the command line. Signed-off-by: Gerd Hoffmann --- vl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/vl.c b/vl.c index 7dcb0879c497..5419b3d68200 100644 --- a/vl.c +++ b/vl.c @@ -3554,6 +3554,8 @@ int main(int

[PATCH v3 6/7] ui: drop curor_hide global variable.

No users left. Signed-off-by: Gerd Hoffmann --- include/sysemu/sysemu.h | 1 - vl.c| 2 -- 2 files changed, 3 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 6358a324a711..7956e9054ade 100644 --- a/include/sysemu/sysemu.h +++

[PATCH v3 7/7] ui: deprecate legacy -show-cursor option

Signed-off-by: Gerd Hoffmann Reviewed-by: Ján Tomko --- vl.c | 2 ++ qemu-deprecated.texi | 5 + 2 files changed, 7 insertions(+) diff --git a/vl.c b/vl.c index 62efcd15c0bf..001be469c2e9 100644 --- a/vl.c +++ b/vl.c @@ -3562,6 +3562,8 @@ int main(int argc, char **argv,

[PATCH v3 0/7] ui: rework -show-cursor option

Add -display {sdl,gtk,cocoa},show-cursor=on as replacement for -show-cursor. sdl + cocoa are switched over (no change in behavior), gtk support is added. Gerd Hoffmann (7): ui: add show-cursor option ui: wire up legacy -show-cursor option ui/sdl: switch to new show-cursor option

[PATCH v3 4/7] ui/cocoa: switch to new show-cursor option

Use DisplayOpts settings to set the new file-global cursor_hide variable, stop using the qemu-global cursor_hide variable. Signed-off-by: Gerd Hoffmann --- ui/cocoa.m | 4 1 file changed, 4 insertions(+) diff --git a/ui/cocoa.m b/ui/cocoa.m index fbb5b1b45f81..f7b323044582 100644 ---

[PATCH v3 1/7] ui: add show-cursor option

When enabled, this forces showing the mouse cursor, i.e. do not hide the pointer on mouse grabs. Defaults to off. Signed-off-by: Gerd Hoffmann --- qapi/ui.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qapi/ui.json b/qapi/ui.json index e04525d8b44b..b9df7fe7b5cb 100644 ---

Re: [libvirt-php PATCH] libvirt-domain: Introduce libvirt_domain_reset()

On 2/6/20 7:35 PM, Marcus Recck wrote: We currently have all other power-related functions implemented, but are missing the ability to call virDomainReset from the PHP bindings. This adds that functionality. Signed-off-by: Marcus Recck --- doc/source/libvirt/entities.functions.xml | 1 +

[PATCH 1/2] docs: virsh: Modernize docs for qemu-monitor-command

Mention that we actually by default use QMP and clarify the rest of the documentation. Signed-off-by: Peter Krempa --- docs/manpages/virsh.rst | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index

[PATCH 2/2] virsh: Allow extracting 'return' section of QMP command in 'qemu-monitor-command'

Simplify gathering the actual return value from a passed-through QMP command when using 'qemu-monitor-command' by adding '--return-value' switch which just extracts the 'return' section and alternatively reports an error if the section is not present. This simplifies gathering of some test data

[PATCH 0/2] virsh: qemu-monitor-command: Improve docs and retrun value handling

2/2 was already reviewed, but it depends on the docs patch. Peter Krempa (2): docs: virsh: Modernize docs for qemu-monitor-command virsh: Allow extracting 'return' section of QMP command in 'qemu-monitor-command' docs/manpages/virsh.rst | 24 ++ tools/virsh-domain.c

Re: [libvirt PATCH 3/3] qemu_capabilities: Disable CPU models on old s390 machine types

It does what it is supposed to do even so version checking is not really nice but not spending the effort to design a new qom interface is OK. @Christian Ehrhardt: I guess you need to add the ubuntu effected machine type(s) to s390HostPassthroughOnlyMachines as well as add an adjusted test

Re: [libvirt PATCH 0/3] qemu: Fix default CPU for old s390 machine types

On Thu, Feb 6, 2020 at 11:25 AM Jiri Denemark wrote: > See the last patch for detailed description and > https://bugzilla.redhat.com/show_bug.cgi?id=1795651 for a discussion > about this topic. > > Jiri Denemark (3): > qemu: Pass machine type to virQEMUCapsIsCPUModeSupported > qemuxml2*test:

Re: [libvirt PATCH 2/3] qemuxml2*test: Add default CPU tests for s390-ccw-virtio-2.7 machines

Would it make sense to test for cpu mode host-model to remain with machine='s390-ccw-virtio-2.8' as well? Reviewed-by: Boris Fiuczynski On 2/6/20 11:24 AM, Jiri Denemark wrote: Signed-off-by: Jiri Denemark --- ...t-cpu-kvm-ccw-virtio-2.7.s390x-latest.args | 34 +++

Re: [libvirt PATCH 1/3] qemu: Pass machine type to virQEMUCapsIsCPUModeSupported

Looks good. Reviewed-by: Boris Fiuczynski On 2/6/20 11:24 AM, Jiri Denemark wrote: The usability of a specific CPU mode may depend on machine type, let's prepare for this by passing it to virQEMUCapsIsCPUModeSupported. Signed-off-by: Jiri Denemark --- src/qemu/qemu_capabilities.c | 12

Re: [PATCH v2 0/6] ui: rework -show-cursor option

On Thu, Feb 06, 2020 at 02:20:02PM +0100, Gerd Hoffmann wrote: > On Thu, Feb 06, 2020 at 11:52:05AM +, Peter Maydell wrote: > > On Thu, 6 Feb 2020 at 11:29, Gerd Hoffmann wrote: > > > > > > > > > > This cover letter is missing a description of what the patchset does... > > > > The closest