Hi All,
Gentle Reminder,
Please have a look at my email below. It would be great if anyone can help
me with this project.
Thanks & Regards,
Prakhar Bansal
Graduate Student' 20, Computer Engineering
Iowa State University, Ames, IA
On Tue, Mar 24, 2020 at 11:36 PM PRAKHAR BANSAL
wrote:
> Hi
Signed-off-by: Han Han
---
docs/schemas/domaincommon.rng | 350 ++
1 file changed, 186 insertions(+), 164 deletions(-)
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index d79dee65..96eccaad 100644
--- a/docs/schemas/domaincommon.rng
On 3/24/20 3:44 AM, Jiri Denemark wrote:
The situation on the first machine is a bit strange as there are no
features disabled in host-model CPU definition, which makes it unclear
why QEMU reports Cascadelake-Server as unusable (QEMU reports the
reason, but we don't do so yet).
I got back to
Since we enabled use of EPEL in our CentOS installs, we should pull in
the ccache package to speed up builds.
Signed-off-by: Daniel P. Berrangé
---
guests/vars/mappings.yml | 1 -
1 file changed, 1 deletion(-)
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index
On Wed, 2020-03-25 at 11:18 +0100, Michal Privoznik wrote:
[...]
> void
> -qemuGetMemoryBackingBasePath(virQEMUDriverConfigPtr cfg,
> +qemuGetMemoryBackingBasePath(virQEMUDriverPtr driver,
> char **path)
> {
> -*path = g_strdup_printf("%s/libvirt/qemu",
On Wed, 2020-03-25 at 11:18 +0100, Michal Privoznik wrote:
> This reverts commit 06a19921b6a522cd7b4d352c9320909752947de3.
>
> What I haven't realized when writing this ^^ commit is that the
> virQEMUDriver structure already stores the root directory path.
> And since the pointer is immutable it
On Wed, 2020-03-25 at 11:18 +0100, Michal Privoznik wrote:
> The cfg->root is going away, therefore get the info right from
> the driver structure.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_domain.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Andrea
On Wed, 2020-03-25 at 11:18 +0100, Michal Privoznik wrote:
> This function returns embeddedRoot member of the driver
> structure.
>
> Signed-off-by: Michal Privoznik
> ---
> src/qemu/qemu_conf.c | 12
> src/qemu/qemu_conf.h | 1 +
> 2 files changed, 13 insertions(+)
Reviewed-by:
On Wed, 2020-03-25 at 11:18 +0100, Michal Privoznik wrote:
> The code that generates "qemu-embed-$hash" is going to be useful
> in more places. Separate it out into a function.
>
> Signed-off-by: Michal Privoznik
> ---
> src/hypervisor/domain_driver.c | 42 ++
>
On Wed, 2020-03-25 at 11:18 +0100, Michal Privoznik wrote:
> The virDomainGenerateMachineName() function doesn't belong in
> src/conf/ really, because it has nothing to do with domain XML
> parsing. It landed there because of lack of better place in the
> past. But now that we have src/hypervisor/
On Wed, 2020-03-25 at 11:18 +0100, Michal Privoznik wrote:
> The virQEMUDriverConfigNew() accepts path to root directory for
> embed mode as an argument. If the argument is not NULL it uses
> the passed value as prefix for some internal paths (e.g.
> cfg->libDir). If it is NULL though, it looks if
On Wed, Mar 25, 2020 at 5:08 PM Fabiano Fidêncio wrote:
>
> On Wed, Mar 25, 2020 at 4:51 PM Felipe Borges wrote:
> >
> > Signed-off-by: Felipe Borges
> > ---
> > libvirt-gobject/libvirt-gobject-domain.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
On 3/25/20 7:18 AM, Michal Privoznik wrote:
After my first round of patches got merged [1], some new problems
arose. They are not as serious (except maybe for 7/9) but they are still
problematic for sure. Mostly in scenarios where a mgmt application uses
the embedded driver and has multiple
On 25.03.20 08:06, Bjoern Walk wrote:
> Update s390x capabilities for QEMU 4.2 with the actual GA version for
> QEMU and on the latest z15 machine.
Maybe add:
As these files were generated on a z15 and the previous data was taken on a z13
this now indicates, z15 (gen15a) AND z14 to be
On Wed, Mar 25, 2020 at 4:51 PM Felipe Borges wrote:
>
> Signed-off-by: Felipe Borges
> ---
> libvirt-gobject/libvirt-gobject-domain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libvirt-gobject/libvirt-gobject-domain.c
> b/libvirt-gobject/libvirt-gobject-domain.c
Signed-off-by: Peter Krempa
---
.../disk-network-http.x86_64-latest.xml | 71 +++
tests/qemuxml2xmltest.c | 2 +
2 files changed, 73 insertions(+)
create mode 100644 tests/qemuxml2xmloutdata/disk-network-http.x86_64-latest.xml
diff --git
The quotes are forbidden only inside the value, but the value itself may
be enclosed in quotes. Fix the RNG schema and validator and add a test
case.
https://bugzilla.redhat.com/show_bug.cgi?id=1804750
Signed-off-by: Peter Krempa
---
docs/schemas/domaincommon.rng | 2 +-
The validator didn't accept the quoted version of the cookie value. Add
a test and fix the issue.
Peter Krempa (2):
qemuxml2xmltest: Wire up 'disk-network-http' case
virStorageSourceNetCookieValidate: Accept quoted cookie value
docs/schemas/domaincommon.rng | 2 +-
Signed-off-by: Felipe Borges
---
libvirt-gobject/libvirt-gobject-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt-gobject/libvirt-gobject-domain.c
b/libvirt-gobject/libvirt-gobject-domain.c
index 399b118..0a16cb4 100644
---
These are mapped respectively to VIR_DOMAIN_UNDEFINE_NVRAM and
VIR_DOMAIN_UNDEFINE_KEEP_NVRAM.
Fixes issues such as https://bugzilla.redhat.com/1817031
Signed-off-by: Felipe Borges
---
libvirt-gobject/libvirt-gobject-domain.h | 2 ++
1 file changed, 2 insertions(+)
diff --git
Commit 5540acb9a2b added a minimum size verification for the target
size of ppc64 NVDIMMs but forgot to remove a MAX() size check that
was being used in earlier reviews of that commit. The size
verification makes this check unneeded since we're making sure
that guestArea will always be at least
On 23. 3. 2020 10:45, Prathamesh Chavan wrote:
> Hi Everyone,
Hey!
It's nice to see somebody new interested in libvirt.
>
> I'm Prathamesh Chavan, a final year student at studying Computer
> Science and Engineering at IIT Kharagpur. I've been part of GSoC'17
> under the Git Organization and
On Tue, 2020-03-24 at 14:33 -0300, Daniel Henrique Barboza wrote:
> The PMU feature is enabled by default in ppc64 guests and can't
> be disabled via Libvirt or QEMU [1]. The current PMU feature
> implementation does not allow PMU to enabled or disabled in the
> ppc64 guest. Declaring the PMU
On Tue, 2020-03-24 at 14:33 -0300, Daniel Henrique Barboza wrote:
> Hyperv features are supported by both x86 and aarch64. The
> declaration in the XML by itself is benign to other architectures,
> but any of its 14 current features will break QEMU with an error
> like this (from ppc64):
>
>
On Tue, 2020-03-24 at 14:33 -0300, Daniel Henrique Barboza wrote:
> The 'pvspinlock' feature is x86 only. The "" declaration
> will always have a value 'on' or 'off', and both will break QEMU when
> launching non-x86 guests. This is the error message for
> "" when running a ppc64 guest:
>
>
On Tue, 2020-03-24 at 14:33 -0300, Daniel Henrique Barboza wrote:
[...]
> Suggested-by: Andrea Bolognani
Merely providing review feedback is not usually considered enough to
get Suggested-by credits, so I'll drop this.
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1236440
The consensus
On Wed, 2020-03-25 at 12:19 +, Daniel P. Berrangé wrote:
> On Wed, Mar 25, 2020 at 12:27:33PM +0100, Andrea Bolognani wrote:
> > This kind of testing will still be limited by the fact that merge
> > requests will not be able to use these dedicated runners. Compare
> > this to something like
On Wed, Mar 25, 2020 at 12:27:33PM +0100, Andrea Bolognani wrote:
> On Wed, 2020-03-25 at 10:44 +, Daniel P. Berrangé wrote:
> > On Wed, Mar 25, 2020 at 11:27:31AM +0100, Andrea Bolognani wrote:
> > > On Wed, 2020-03-25 at 09:35 +0100, Erik Skultety wrote:
> > > > Related to the availability
On a Monday in 2020, Peter Krempa wrote:
Don't report cases when the guest information is not requested
explicitly and not present either.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_driver.c | 45 +++---
1 file changed, 20 insertions(+), 25 deletions(-)
On a Monday in 2020, Peter Krempa wrote:
Use qemuAgentCommandFull so that callers of qemuAgentGetFSInfo can
suppress error reports if the function is not supported by the guest
agent.
Since this patch removes the last use of
qemuAgentErrorCommandUnsupported the whole function is deleted as
On a Monday in 2020, Peter Krempa wrote:
Use qemuAgentCommandFull so that callers of qemuAgentGetOSInfo can
suppress error reports if the function is not supported by the guest
agent.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_agent.c | 17 +
src/qemu/qemu_agent.h | 3 ++-
On a Monday in 2020, Peter Krempa wrote:
Use qemuAgentCommandFull so that callers of qemuAgentGetTimezone can
suppress error reports if the function is not supported by the guest
agent.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_agent.c | 17 +
src/qemu/qemu_agent.h | 3
On a Monday in 2020, Peter Krempa wrote:
Use qemuAgentCommandFull so that callers of qemuAgentGetUsers can
suppress error reports if the function is not supported by the guest
agent.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_agent.c | 17 +
src/qemu/qemu_agent.h | 3 ++-
On a Monday in 2020, Peter Krempa wrote:
Use qemuAgentCommandFull in qemuAgentGetHostname so that we can suppress
error reports if the caller will not require them. Callers for now
always require error reporting but will be fixed later.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_agent.c |
On Wed, Mar 25, 2020 at 12:27:33PM +0100, Andrea Bolognani wrote:
> On Wed, 2020-03-25 at 10:44 +, Daniel P. Berrangé wrote:
> > On Wed, Mar 25, 2020 at 11:27:31AM +0100, Andrea Bolognani wrote:
> > Also, even with merge request testing, we'll still want to test everything
> > post-merge, as
On Wed, 2020-03-25 at 11:30 +, Daniel P. Berrangé wrote:
> On Wed, Mar 25, 2020 at 12:18:00PM +0100, Andrea Bolognani wrote:
> > On Wed, 2020-03-25 at 10:54 +, Daniel P. Berrangé wrote:
> > > By default jobs in a stage get given a dependency
> > >
> > > "needs: [ jobs from prev
On Wed, Mar 25, 2020 at 12:27:33PM +0100, Andrea Bolognani wrote:
> On Wed, 2020-03-25 at 10:44 +, Daniel P. Berrangé wrote:
> > On Wed, Mar 25, 2020 at 11:27:31AM +0100, Andrea Bolognani wrote:
> > > On Wed, 2020-03-25 at 09:35 +0100, Erik Skultety wrote:
> > > > Related to the availability
On Wed, Mar 25, 2020 at 12:18:00PM +0100, Andrea Bolognani wrote:
> On Wed, 2020-03-25 at 10:54 +, Daniel P. Berrangé wrote:
> > On Wed, Mar 25, 2020 at 11:48:35AM +0100, Andrea Bolognani wrote:
> > > Given the intentions, I think the current split can be improved
> > > further: having
On Wed, 2020-03-25 at 10:44 +, Daniel P. Berrangé wrote:
> On Wed, Mar 25, 2020 at 11:27:31AM +0100, Andrea Bolognani wrote:
> > On Wed, 2020-03-25 at 09:35 +0100, Erik Skultety wrote:
> > > Related to the availability of shared runners, for
> > > merge_requests/post_merge
> > > builds only,
On Wed, 2020-03-25 at 10:54 +, Daniel P. Berrangé wrote:
> On Wed, Mar 25, 2020 at 11:48:35AM +0100, Andrea Bolognani wrote:
> > Given the intentions, I think the current split can be improved
> > further: having cross_build as a separate stage from native_build
> > means that the former has
On Wed, Mar 25, 2020 at 11:48:35AM +0100, Andrea Bolognani wrote:
> On Tue, 2020-03-24 at 18:21 +, Daniel P. Berrangé wrote:
> > On Tue, Mar 24, 2020 at 06:47:01PM +0100, Andrea Bolognani wrote:
> > > I don't get the rationale behind the split.
> > >
> > > Right now we're not using merge
On Tue, 2020-03-24 at 18:23 +, Daniel P. Berrangé wrote:
> On Tue, Mar 24, 2020 at 06:51:10PM +0100, Andrea Bolognani wrote:
> > On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote:
> > > +# This artifact published by this job is downloaded to push to Weblate
> > > +# for translation
On Tue, 2020-03-24 at 18:21 +, Daniel P. Berrangé wrote:
> On Tue, Mar 24, 2020 at 06:47:01PM +0100, Andrea Bolognani wrote:
> > I don't get the rationale behind the split.
> >
> > Right now we're not using merge requests, but we're limiting the
> > number of jobs for the merge request case;
On Wed, Mar 25, 2020 at 11:27:31AM +0100, Andrea Bolognani wrote:
> On Wed, 2020-03-25 at 09:35 +0100, Erik Skultety wrote:
> > On Tue, Mar 24, 2020 at 06:21:24PM +, Daniel P. Berrangé wrote:
> > > On Tue, Mar 24, 2020 at 06:47:01PM +0100, Andrea Bolognani wrote:
> > > > * pick a selection
On Wed, 2020-03-25 at 09:35 +0100, Erik Skultety wrote:
> On Tue, Mar 24, 2020 at 06:21:24PM +, Daniel P. Berrangé wrote:
> > On Tue, Mar 24, 2020 at 06:47:01PM +0100, Andrea Bolognani wrote:
> > > * pick a selection of jobs that includes both native and cross
> > > build, across various
This reverts commit 06a19921b6a522cd7b4d352c9320909752947de3.
What I haven't realized when writing this ^^ commit is that the
virQEMUDriver structure already stores the root directory path.
And since the pointer is immutable it can be accessed right from
the structure and thus there is no need to
This function returns embeddedRoot member of the driver
structure.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_conf.c | 12
src/qemu/qemu_conf.h | 1 +
2 files changed, 13 insertions(+)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 15837cece4..fb7c5a1a8a
So far, libvirt generates the following path for memory:
$memoryBackingDir/libvirt/qemu/$id-$shortName/ram-nodeN
where $memoryBackingDir is the path where QEMU mmaps() memory for
the guest (e.g. /var/lib/libvirt/qemu/ram), $id is domain ID
and $shortName is shortened version of domain name. So
So far, libvirt generates the following path for automatic dumps:
$autoDumpPath/$id-$shortName-$timestamp
where $autoDumpPath is where libvirt stores dumps of guests (e.g.
/var/lib/libvirt/qemu/dump), $id is domain ID and $shortName is
shortened version of domain name. So for instance, the
The virDomainGenerateMachineName() function doesn't belong in
src/conf/ really, because it has nothing to do with domain XML
parsing. It landed there because of lack of better place in the
past. But now that we have src/hypervisor/ the function should
live there. At the same time, the function
So far, libvirt generates the following path for hugepages:
$mnt/libvirt/qemu/$id-$shortName
where $mnt is the mount point of hugetlbfs corresponding to
hugepages of desired size (e.g. /dev/hugepages), $id is domain ID
and $shortName is shortened version of domain name. So for
instance, the
The cfg->root is going away, therefore get the info right from
the driver structure.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_domain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index b921126e1c..e0a2f3c695
The code that generates "qemu-embed-$hash" is going to be useful
in more places. Separate it out into a function.
Signed-off-by: Michal Privoznik
---
src/hypervisor/domain_driver.c | 42 ++
src/hypervisor/domain_driver.h | 4
src/libvirt_private.syms
After my first round of patches got merged [1], some new problems
arose. They are not as serious (except maybe for 7/9) but they are still
problematic for sure. Mostly in scenarios where a mgmt application uses
the embedded driver and has multiple forks/instances sharing essentially
the same
The virQEMUDriverConfigNew() accepts path to root directory for
embed mode as an argument. If the argument is not NULL it uses
the passed value as prefix for some internal paths (e.g.
cfg->libDir). If it is NULL though, it looks if the other
argument, @privileged is true or false and generates
On Tue, Mar 24, 2020 at 04:24:05PM +, Daniel P. Berrangé wrote:
> Whenever there is a change to the translatable strings we need to push
> a new libvirt.pot to weblate. This only needs to be done when code
> merges into git master, so the job is restricted to that branch.
>
> Signed-off-by:
On Tue, Mar 24, 2020 at 06:23:19PM +, Daniel P. Berrangé wrote:
> On Tue, Mar 24, 2020 at 06:51:10PM +0100, Andrea Bolognani wrote:
> > On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote:
> > > +# This artifact published by this job is downloaded to push to Weblate
> > > +# for
On Tue, Mar 24, 2020 at 06:48:52PM +0100, Andrea Bolognani wrote:
> On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote:
> > We don't need the full git history when running CI jobs. From a code POV
> > we only need the most recent commit, but we want to be able to run
> > checks on the
On 24. 3. 2020 17:14, Rafael Fonseca wrote:
> The logic setting a device default should be in the post parse function
> of individual driver code, not in `src/conf/domain_conf.c`.
>
> Rafael Fonseca (7):
> bhyve: move video default logic to driver
> libxl: move video default logic to driver
>
On Tue, Mar 24, 2020 at 06:47:50PM +0100, Andrea Bolognani wrote:
> On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote:
> > To facilitate future jobs that will use FreeBSD
> >
> > Signed-off-by: Daniel P. Berrangé
> > ---
> > .gitlab-ci.yml | 13 -
> > 1 file changed, 8
On Tue, Mar 24, 2020 at 06:21:24PM +, Daniel P. Berrangé wrote:
> On Tue, Mar 24, 2020 at 06:47:01PM +0100, Andrea Bolognani wrote:
> > On Tue, 2020-03-24 at 16:24 +, Daniel P. Berrangé wrote:
> > > To control the total CI execution time, we split the native jobs into
> > > two distinct
On Tue, Mar 24, 2020 at 04:24:02PM +, Daniel P. Berrangé wrote:
> This patch adds x86_64 native CI jobs for all distros that we currently
> build container images for. This is a superset of the Linux jobs run on
> current Jenkins and Travis platforms.
>
> The remaining missing platforms are
On Tue, Mar 24, 2020 at 04:24:01PM +, Daniel P. Berrangé wrote:
> This pulls in the mingw cross build jobs using Fedora 30 as a base,
> matching what is done on Jenkins and Travis.
>
> Signed-off-by: Daniel P. Berrangé
> ---
Reviewed-by: Erik Skultety
On 25. 3. 2020 0:58, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Unfortunately, advisory record locking lose the lock if any fd refering
> to the file is closed. There doesn't seem to be a way to preserve the
> lock atomically. We could eventually retake the lock if low
On Tue, Mar 24, 2020 at 04:23:58PM +, Daniel P. Berrangé wrote:
> We're going to add more build jobs to CI, and users have limited time
> granted on the shared CI runners. The number of cross-build jobs
> currently present is not sustainable, so cut it down to two interesting
> jobs to cover
On Tue, Mar 24, 2020 at 06:26:15PM +0100, Andrea Bolognani wrote:
> On Tue, 2020-03-24 at 16:23 +, Daniel P. Berrangé wrote:
> > Run the bare minimum build that is possible to create the docs. Ideally
> > the '--without-remote' arg would be passed, but there are several bugs
> > preventing a
On Wed, Mar 25, 2020 at 08:06:20 +0100, Bjoern Walk wrote:
> Update s390x capabilities for QEMU 4.2 with the actual GA version for
> QEMU and on the latest z15 machine.
I'm not familiar with the machine so I don't want to review the CPU
changes caused by using a different machine.
> This picks
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 1 +
src/conf/network_conf.c | 31 +--
2 files changed, 2 insertions(+), 30 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index 20878a8..702018b 100644
---
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 1 +
src/conf/network_conf.c | 100 ++-
2 files changed, 15 insertions(+), 86 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index 14561d9..4caea02 100644
---
Signed-off-by: Shi Lei
---
docs/schemas/network.rng| 3 +++
src/conf/network_conf.c | 12 ++--
src/conf/network_conf.h | 15 ---
src/network/bridge_driver.c | 2 +-
4 files changed, 10 insertions(+), 22 deletions(-)
diff --git a/docs/schemas/network.rng
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 1 +
src/conf/network_conf.c | 15 +++
2 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index b97510f..ba5db0b 100644
--- a/docs/schemas/network.rng
+++
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 7 +++--
po/POTFILES.in | 1 +
src/conf/network_conf.c | 66 +---
3 files changed, 13 insertions(+), 61 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index
Update s390x capabilities for QEMU 4.2 with the actual GA version for
QEMU and on the latest z15 machine.
This picks up the new blockdev capability, so we need to refresh a bunch
of test cases as well.
Reviewed-by: Boris Fiuczynski
Signed-off-by: Bjoern Walk
---
I have stripped the replies
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 1 +
src/conf/network_conf.c | 150 +--
2 files changed, 3 insertions(+), 148 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index 884cd64..7084248 100644
---
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 1 +
src/conf/network_conf.c | 20 ++--
2 files changed, 3 insertions(+), 18 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index 1d7b854..b97510f 100644
--- a/docs/schemas/network.rng
+++
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 3 +-
src/conf/network_conf.c | 71 +---
2 files changed, 3 insertions(+), 71 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index ba5db0b..db04b7c 100644
---
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 1 +
src/conf/network_conf.c | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index cd5be22..1d7b854 100644
--- a/docs/schemas/network.rng
+++
Let makefiles call RNG2C for generating codes automatically.
Signed-off-by: Shi Lei
---
src/Makefile.am | 16 +++-
src/access/Makefile.inc.am | 2 +-
src/conf/Makefile.inc.am| 10 +-
src/esx/Makefile.inc.am | 2 +-
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 6 +-
src/conf/network_conf.c | 33 +++--
2 files changed, 32 insertions(+), 7 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index 702018b..884cd64 100644
---
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 4
src/conf/network_conf.c | 17 ++---
2 files changed, 6 insertions(+), 15 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index 7084248..cd5be22 100644
--- a/docs/schemas/network.rng
+++
Outline
=
In libvirt world, objects(like domain, network, etc.) are described with two
representations: structures in c-language and XML specified by relax-ng.
Since c-language-implementation and xml restricted by relax-ng are merely
the different expressions of the same object-model, we
Meta 'U8' corresponds to 'uint8_t'.
Add virStrToLong_u8p when parsing uint8_t.
Signed-off-by: Shi Lei
---
src/util/virstring.c | 15 +++
src/util/virstring.h | 5 +
2 files changed, 20 insertions(+)
diff --git a/src/util/virstring.c b/src/util/virstring.c
index
When directive property 'args.noctxt" is set, there's no 'ctxt' argument
for the parse function. So RNG2C uses virXMLChildNode, virXMLChildNodeSet
and virXMLPropString to construct implementation of the parse function.
Signed-off-by: Shi Lei
---
src/util/virxml.c | 57
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 3 +++
docs/schemas/networkcommon.rng | 2 +-
src/conf/network_conf.h| 12
3 files changed, 4 insertions(+), 13 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index 4d23c8f..1747fc2
Generated codes by RNG2C need to invoke VIR_ENUM_IMPL and VIR_ENUM_DECL.
Move them from virenum.h to internal.h for convenience.
This patch also prepares for next patch:
replacing virTristateBool/virTristateSwitch(hardcoded) with namesakes.
Signed-off-by: Shi Lei
---
src/internal.h | 19
RNG2C has three subcommands: 'list'/'show' for previewing directives
and generated codes; 'generate' for Makefile to generate and output codes.
Signed-off-by: Shi Lei
---
po/POTFILES.in |1 +
rng2c/directive.py | 1693
rng2c/generator.py |
Add virSocketAddrParse, virSocketAddrFormat, virSocketAddrClear and
virSocketAddrCheck. In generated codes by RNG2C, these functions are
called for handling virSocketAddr.
Signed-off-by: Shi Lei
---
docs/schemas/basictypes.rng | 1 +
src/util/virsocketaddr.c| 27 +++
Signed-off-by: Shi Lei
---
docs/schemas/basictypes.rng | 14 ++
src/util/Makefile.inc.am| 2 ++
src/util/virenum.c | 15 ---
src/util/virenum.h | 21 +++--
4 files changed, 19 insertions(+), 33 deletions(-)
diff --git
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 8 ++
src/conf/network_conf.c | 58 +++-
2 files changed, 47 insertions(+), 19 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index 919464d..ee4487e 100644
---
When RNG2C generates codes for builtin 'Bool.on_off', it includes
virStringParseOnOff in those codes.
Signed-off-by: Shi Lei
---
src/util/virstring.c | 22 ++
src/util/virstring.h | 5 +
2 files changed, 27 insertions(+)
diff --git a/src/util/virstring.c
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 1 +
src/conf/network_conf.c | 37 +
2 files changed, 6 insertions(+), 32 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index b0f4a64..07fbd5b 100644
---
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 13 ++-
src/conf/network_conf.c | 218 +--
2 files changed, 152 insertions(+), 79 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index c902f7e..14561d9 100644
---
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 13 ++---
src/conf/Makefile.inc.am | 2 ++
src/conf/network_conf.c | 60
3 files changed, 11 insertions(+), 64 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 13 -
src/conf/network_conf.c | 60 +++-
2 files changed, 53 insertions(+), 20 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index 4caea02..b0f4a64 100644
---
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 4
src/conf/network_conf.h | 9 -
2 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index 1747fc2..c83a796 100644
--- a/docs/schemas/network.rng
+++
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 3 +++
src/conf/network_conf.h | 8 +---
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index 6045322..4d23c8f 100644
--- a/docs/schemas/network.rng
+++
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 7 +++-
src/conf/network_conf.c | 69 +---
2 files changed, 57 insertions(+), 19 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index 07fbd5b..20878a8 100644
---
Signed-off-by: Shi Lei
---
docs/schemas/network.rng | 4
src/conf/network_conf.h | 7 ---
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng
index c83a796..0034c4f 100644
--- a/docs/schemas/network.rng
+++
98 matches
Mail list logo