Re: Re: [RFC 00/29] RFC: Generate object-model code based on relax-ng files

2020-04-21 Thread Shi Lei
... ... >The key question is just how difficult will it be to write a tool that >can parse the C header files, and magic comments, to output suitable >XML parser/formatter functions ? There's no easy way to answer that >without someone trying it. > > >Regards, >Daniel >-- >|: https://berrange.com

[PATCH] docs: Remove stray parenthesis

2020-04-21 Thread Jim Fehlig
Commit fadbaa2375 introduced a stray parenthesis in formatdomain.html.in. Remove it. Signed-off-by: Jim Fehlig --- Pushing under the trivial rule. docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in

[PATCH] news: Document new Xen hypervisor features

2020-04-21 Thread Jim Fehlig
Signed-off-by: Jim Fehlig --- docs/news.xml | 22 ++ 1 file changed, 22 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 99c65447b0..074dc22e97 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -66,6 +66,28 @@ feedback from users on how well it works

Re: [libvirt PATCH v3 5/5] Add second qom-list-types call to test data.

2020-04-21 Thread tobin
On 2020-04-21 04:50, Peter Krempa wrote: On Mon, Apr 20, 2020 at 15:25:10 -0400, Tobin Feldman-Fitzthum wrote: We make an additional call to qom-list-types. Adjust qemucapabilitiesdata accordingly. Signed-off-by: Tobin Feldman-Fitzthum --- .../caps_2.10.0.aarch64.replies |

Re: [libvirt-python PATCH v2] setup: require python >= 3.5 to build

2020-04-21 Thread Philipp Hahn
Am 20.04.20 um 15:57 schrieb Daniel P. Berrangé: > Pytjon 3.5 is the oldest Python version available across our supported > build platforms. > > Signed-off-by: Daniel P. Berrangé Reviewed-by: Philipp Hahn > --- > setup.py | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >

Re: [libvirt PATCH 1/6] slirp: leave the dbus daemon running on error

2020-04-21 Thread Marc-André Lureau
Hi On Tue, Apr 21, 2020 at 7:42 PM Michal Privoznik wrote: > > On 4/21/20 6:50 PM, Marc-André Lureau wrote: > > Hi > > > > On Tue, Apr 21, 2020 at 6:04 PM Michal Privoznik > > wrote: > >> > >> On 4/8/20 7:23 PM, marcandre.lur...@redhat.com wrote: > >>> From: Marc-André Lureau > >>> > >>>

[PATCH v2] docs: Document reserved PCI addresses for QEMU

2020-04-21 Thread Michal Privoznik
>From time to time we are asked which PCI addresses are reserved in QEMU. Let's document them in one place, it's easier than reconstructing the list from the code each time. Signed-off-by: Michal Privoznik --- diff to v1: - All Laine's comment worked in, hopefully. docs/pci-addresses.rst | 50

Re: [libvirt PATCH 1/6] slirp: leave the dbus daemon running on error

2020-04-21 Thread Michal Privoznik
On 4/21/20 6:50 PM, Marc-André Lureau wrote: Hi On Tue, Apr 21, 2020 at 6:04 PM Michal Privoznik wrote: On 4/8/20 7:23 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Don't stop the DBus daemon if a slirp helper failed to start, as it may be shared with other helpers.

Re: [libvirt PATCH] virsh: Fix return code for dump and migrate

2020-04-21 Thread Daniel P . Berrangé
On Tue, Apr 21, 2020 at 07:15:00PM +0200, Andrea Bolognani wrote: > When the job monitoring logic was refactored, these two commands > were not converted properly and the result is that a successful > dump or migration (char '0') would be reported as a failed one > (int 48) instead. > > Fixes:

Re: [libvirt PATCH] CONTRIBUTING: Include information on build dependencies

2020-04-21 Thread Laine Stump
On 4/20/20 6:54 AM, Andrea Bolognani wrote: libvirt depends on a ton of packages, so trying to install them all by using the classic approach of repeatedly running configure and reacting to each failure by installing the corresponding missing package will inevitably lead to frustration. Luckily

[libvirt PATCH] virsh: Fix return code for dump and migrate

2020-04-21 Thread Andrea Bolognani
When the job monitoring logic was refactored, these two commands were not converted properly and the result is that a successful dump or migration (char '0') would be reported as a failed one (int 48) instead. Fixes: dc0771cfa2e78ffecd7c8234538ee548748d7bef Reported-by: Brian Rak Signed-off-by:

Re: [PATCH] docs: Document reserved PCI addresses for QEMU

2020-04-21 Thread Laine Stump
On 4/21/20 11:01 AM, Michal Privoznik wrote: >From time to time we are asked which PCI addresses are reserved in QEMU. Let's document them in one place, it's easier than reconstructing the list from the code each time. Definitely a good idea. I'm pasting in some notes I added when replying

[libvirt PATCH] conf: split out virDomainFeaturesDefParse

2020-04-21 Thread Ján Tomko
The virDomainDefParseXML function has grown so large it broke the build: ../../src/conf/domain_conf.c:20362:1: error: stack frame size of 4168 bytes in function 'virDomainDefParseXML' [-Werror,-Wframe-larger-than=] Signed-off-by: Ján Tomko --- Technically a build breaker fix. I'm sure I will

Re: [libvirt PATCH 1/6] slirp: leave the dbus daemon running on error

2020-04-21 Thread Marc-André Lureau
Hi On Tue, Apr 21, 2020 at 6:04 PM Michal Privoznik wrote: > > On 4/8/20 7:23 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Don't stop the DBus daemon if a slirp helper failed to start, as it > > may be shared with other helpers. > > > > Signed-off-by: Marc-André

Re: [PATCH v2 01/40] util: virresctrl: convert classes to GObject

2020-04-21 Thread Jonathon Jongsma
On Tue, 2020-04-21 at 15:48 +0200, Rafael Fonseca wrote: > @@ -793,21 +830,13 @@ virResctrlGetInfo(virResctrlInfoPtr resctrl) > virResctrlInfoPtr > virResctrlInfoNew(void) > { > -virResctrlInfoPtr ret = NULL; > - > -if (virResctrlInitialize() < 0) > -return NULL; > - > -ret

Re: [libvirt PATCH 1/6] slirp: leave the dbus daemon running on error

2020-04-21 Thread Michal Privoznik
On 4/8/20 7:23 PM, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Don't stop the DBus daemon if a slirp helper failed to start, as it may be shared with other helpers. Signed-off-by: Marc-André Lureau --- src/qemu/qemu_slirp.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v2 00/40] convert virObjects to GObject

2020-04-21 Thread Jonathon Jongsma
On Tue, 2020-04-21 at 15:26 +0100, Daniel P. Berrangé wrote: > On Tue, Apr 21, 2020 at 04:12:09PM +0200, Rafael Fonseca wrote: > > On Tue, Apr 21, 2020 at 4:03 PM Daniel P. Berrangé < > > berra...@redhat.com> wrote: > > > On Tue, Apr 21, 2020 at 03:48:41PM +0200, Rafael Fonseca wrote: > > > >

[PATCH] docs: Document reserved PCI addresses for QEMU

2020-04-21 Thread Michal Privoznik
>From time to time we are asked which PCI addresses are reserved in QEMU. Let's document them in one place, it's easier than reconstructing the list from the code each time. Signed-off-by: Michal Privoznik --- docs/pci-addresses.rst | 40 1 file changed,

Re: [PATCH v2 00/40] convert virObjects to GObject

2020-04-21 Thread Daniel P . Berrangé
On Tue, Apr 21, 2020 at 04:12:09PM +0200, Rafael Fonseca wrote: > On Tue, Apr 21, 2020 at 4:03 PM Daniel P. Berrangé > wrote: > > > > On Tue, Apr 21, 2020 at 03:48:41PM +0200, Rafael Fonseca wrote: > > > This patch series convert various simple instances of virObject to a > > > GObject

Re: [PATCH v2 00/40] convert virObjects to GObject

2020-04-21 Thread Rafael Fonseca
On Tue, Apr 21, 2020 at 4:03 PM Daniel P. Berrangé wrote: > > On Tue, Apr 21, 2020 at 03:48:41PM +0200, Rafael Fonseca wrote: > > This patch series convert various simple instances of virObject to a > > GObject equivalent. > > > > virLockableObject and virObjects which are subclassed will be

Re: [PATCH v2 00/40] convert virObjects to GObject

2020-04-21 Thread Daniel P . Berrangé
On Tue, Apr 21, 2020 at 03:48:41PM +0200, Rafael Fonseca wrote: > This patch series convert various simple instances of virObject to a > GObject equivalent. > > virLockableObject and virObjects which are subclassed will be covered > in future patchsets. > > New in v2: > - use *Dispose for

[PATCH v2 25/40] datatypes: convert virStorageVol to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/conf/virstorageobj.c | 2 +- src/datatypes.c | 72 src/datatypes.h | 15 src/libvirt-storage.c| 6 +-- src/libvirt_private.syms | 2 +- src/qemu/qemu_migration.c|

[PATCH v2 00/40] convert virObjects to GObject

2020-04-21 Thread Rafael Fonseca
This patch series convert various simple instances of virObject to a GObject equivalent. virLockableObject and virObjects which are subclassed will be covered in future patchsets. New in v2: - use *Dispose for unreffing objects and *Finalize for freeing data, as suggested in the GLib

[PATCH v2 37/40] qemu: convert virQEMUDriverConfig to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/qemu/qemu_conf.c | 36 ++-- src/qemu/qemu_conf.h | 19 --- src/qemu/qemu_driver.c | 2 +- tests/domaincapstest.c | 2 +- tests/testutilsqemu.c | 2 +- 5 files changed, 33 insertions(+), 28 deletions(-)

[PATCH v2 40/40] util: convert virStorageSource to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/libvirt_private.syms | 1 + src/qemu/qemu_blockjob.c | 67 --- src/qemu/qemu_domain.c| 11 +++ src/util/virstoragefile.c | 43 - src/util/virstoragefile.h | 6 ++-- 5 files changed, 57

[PATCH v2 15/40] admin: convert virAdmServer to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/admin/libvirt-admin.c| 2 +- src/admin/libvirt_admin_private.syms | 2 +- src/datatypes.c | 56 src/datatypes.h | 20 ++ src/rpc/gendispatch.pl | 1 +

[PATCH v2 27/40] datatypes: convert virSecret to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/conf/secret_event.c | 15 +++ src/conf/virsecretobj.c | 2 +- src/datatypes.c | 68 - src/datatypes.h | 14 +++--- src/libvirt-secret.c| 7 ++-

[PATCH v2 18/40] datatypes: convert virDomainSnapshot to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/conf/virdomainsnapshotobjlist.c | 7 +-- src/datatypes.c | 68 - src/datatypes.h | 12 +++-- src/libvirt-domain-snapshot.c | 7 ++- src/libvirt_private.syms| 2 +-

[PATCH v2 21/40] datatypes: convert virNetwork to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/conf/domain_conf.c | 6 +-- src/conf/network_event.c| 7 +-- src/conf/virnetworkobj.c| 5 +- src/datatypes.c | 74 +++-- src/datatypes.h | 19

[PATCH v2 30/40] rpc: gendispatch: use g_autoptr where possible

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/rpc/gendispatch.pl | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/src/rpc/gendispatch.pl b/src/rpc/gendispatch.pl index 8c45fa3bc7..e605d50060 100755 --- a/src/rpc/gendispatch.pl +++ b/src/rpc/gendispatch.pl @@

[PATCH v2 29/40] datatypes: convert virDomain to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/conf/domain_event.c | 58 ++-- src/datatypes.c | 80 ++-- src/datatypes.h | 20 ++-- src/esx/esx_driver.c| 7 +- src/hyperv/hyperv_driver.c | 8 +-

[PATCH v2 34/40] hypervisor: convert virHostdevManager to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/hypervisor/virhostdev.c | 49 + src/hypervisor/virhostdev.h | 13 +++--- src/libxl/libxl_driver.c| 2 +- src/lxc/lxc_driver.c| 2 +- src/qemu/qemu_driver.c | 2 +- 5 files changed, 51 insertions(+),

[PATCH v2 28/40] datatypes: convert virStream to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/conf/virchrdev.c| 4 +-- src/datatypes.c | 56 ++--- src/datatypes.h | 14 src/libvirt-stream.c| 7 ++-- src/libvirt_private.syms| 2 +-

[PATCH v2 33/40] libxl: convert libxlDriverConfig to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/libxl/libxl_conf.c | 62 -- src/libxl/libxl_conf.h | 12 ++- src/libxl/libxl_driver.c| 162 src/libxl/libxl_migration.c | 21 ++--- tests/testutilsxen.c| 2 +- 5 files changed, 107

[PATCH v2 39/40] conf: convert virSaveCookie to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/conf/snapshot_conf.c | 2 +- src/conf/snapshot_conf.h | 2 +- src/conf/virsavecookie.c | 10 src/conf/virsavecookie.h | 14 +-- src/qemu/qemu_domain.c | 53 +++- src/qemu/qemu_domain.h | 12 ++---

[PATCH v2 19/40] datatypes: convert virNWFilter to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/conf/virnwfilterobj.c | 7 +--- src/datatypes.c | 70 +++ src/datatypes.h | 10 +++--- src/libvirt-nwfilter.c| 7 ++-- src/libvirt_private.syms | 2 +- src/rpc/gendispatch.pl| 1 + 6 files

[PATCH v2 22/40] datatypes: convert virNetworkPort to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/conf/domain_conf.c | 6 +-- src/conf/virnetworkobj.c| 5 +-- src/datatypes.c | 66 - src/datatypes.h | 15 --- src/libvirt-network.c | 7 ++-

[PATCH v2 12/40] util: convert dnsmasqCaps to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/libvirt_private.syms| 1 + src/network/bridge_driver.c | 22 ++- src/util/virdnsmasq.c | 56 + src/util/virdnsmasq.h | 6 ++-- tests/networkxml2conftest.c | 10 ++- 5 files changed, 42

[PATCH v2 26/40] datatypes: convert virNodeDevice to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/conf/node_device_event.c | 11 +++--- src/conf/node_device_util.c | 4 +-- src/conf/virnodedeviceobj.c | 3 +- src/datatypes.c | 67 +--- src/datatypes.h | 14 src/libvirt-nodedev.c

[PATCH v2 16/40] admin: convert virAdmClient to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/admin/libvirt-admin.c| 2 +- src/admin/libvirt_admin_private.syms | 2 +- src/datatypes.c | 36 ++-- src/datatypes.h | 13 +- src/rpc/gendispatch.pl | 1 +

[PATCH v2 31/40] conf: convert virNetworkXMLOption to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/conf/network_conf.c | 24 ++-- src/conf/network_conf.h | 12 +--- src/network/bridge_driver.c | 2 +- tests/networkxml2xmltest.c | 3 +-- 4 files changed, 17 insertions(+), 24 deletions(-) diff --git

[PATCH v2 13/40] conf: convert virDomainChrSourceDef to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/conf/domain_conf.c | 52 +++- src/conf/domain_conf.h | 9 ++- src/libvirt_private.syms | 1 + src/qemu/qemu_domain.c | 5 ++-- src/qemu/qemu_process.c | 3 +-- src/qemu/qemu_virtiofs.c | 12 -- 6

[PATCH v2 38/40] conf: convert virDomain*Private to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/conf/domain_conf.c| 21 ++- src/conf/domain_conf.h| 18 +- src/qemu/qemu_domain.c| 359 +- src/qemu/qemu_domain.h| 145 ++- src/util/virstoragefile.c | 2 +- src/util/virstoragefile.h | 3

[PATCH v2 09/40] bhyve: convert virBhyveDriverConfig to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/bhyve/bhyve_capabilities.c | 3 +-- src/bhyve/bhyve_conf.c | 36 +- src/bhyve/bhyve_driver.c | 2 +- src/bhyve/bhyve_utils.h| 11 +-- 4 files changed, 29 insertions(+), 23 deletions(-) diff

[PATCH v2 23/40] datatypes: convert virInterface to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/conf/virinterfaceobj.c | 5 +- src/datatypes.c | 68 + src/datatypes.h | 10 ++-- src/interface/interface_backend_netcf.c | 7 +-- src/interface/interface_backend_udev.c

[PATCH v2 14/40] rpc: gendispatch: prepare for GObject conversion

2020-04-21 Thread Rafael Fonseca
As we slowly convert virObject to GObject, prepare gendispatch.pl to choose the right unref implementation for each object type. Once a type has been converted, just add it to the `gobject_impl` hash. Note though that types explicitly declared should be changed directly where they are used.

[PATCH v2 24/40] datatypes: convert virStoragePool to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/conf/storage_event.c| 15 +++ src/conf/virstorageobj.c| 2 +- src/datatypes.c | 70 - src/datatypes.h | 15 --- src/libvirt-storage.c | 6 +--

[PATCH v2 10/40] rpc: convert virNetServerService to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/lxc/lxc_controller.c | 5 +- src/rpc/virnetserver.c| 7 +-- src/rpc/virnetserverprogram.h | 7 ++- src/rpc/virnetserverservice.c | 103 +- tests/virnetdaemontest.c | 4 +- 5 files changed, 61

[PATCH v2 20/40] datatypes: convert virNWFilterBinding to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/conf/virnwfilterbindingobjlist.c | 2 +- src/datatypes.c | 68 +++- src/datatypes.h | 14 -- src/libvirt-nwfilter.c | 7 ++- src/libvirt_private.syms | 1 +

[PATCH v2 11/40] conf: convert virDomainCapsCPUModels to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/conf/domain_capabilities.c | 48 ++ src/conf/domain_capabilities.h | 10 --- src/libvirt_private.syms | 1 + tests/cputest.c| 35 - 4 files changed, 44 insertions(+), 50

[PATCH v2 36/40] qemu: convert qemuBlockJobData to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/qemu/qemu_blockjob.c | 67 ++- src/qemu/qemu_blockjob.h | 15 ++--- src/qemu/qemu_domain.c| 4 +-- src/qemu/qemu_hotplug.c | 3 +- src/qemu/qemu_migration.c | 16 +++--- 5 files changed, 55 insertions(+),

[PATCH v2 17/40] datatypes: convert virDomainCheckpoint to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/conf/virdomaincheckpointobjlist.c | 7 +-- src/datatypes.c | 68 ++- src/datatypes.h | 14 -- src/libvirt-domain-checkpoint.c | 7 ++- src/libvirt_private.syms | 2

[PATCH v2 02/40] conf: capabilities: convert virCaps to GOBject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/bhyve/bhyve_capabilities.c | 16 --- src/bhyve/bhyve_driver.c| 29 +++ src/conf/capabilities.c | 51 +++-- src/conf/capabilities.h | 6 ++-- src/conf/storage_capabilities.c | 4

[PATCH v2 35/40] libxl: convert libxlMigrationDstArgs to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/libxl/libxl_migration.c | 76 - 1 file changed, 49 insertions(+), 27 deletions(-) diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c index 50225855ae..8530b172ec 100644 ---

[PATCH v2 32/40] lxc: convert virLXCDriverConfig to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/lxc/lxc_conf.c| 31 +-- src/lxc/lxc_conf.h| 10 +++-- src/lxc/lxc_driver.c | 50 +++ src/lxc/lxc_process.c | 33 +--- 4 files changed, 50 insertions(+), 74

[PATCH v2 06/40] rpc: convert virNetServerProgram to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/locking/lock_daemon.c | 28 ++-- src/logging/log_daemon.c| 28 ++-- src/lxc/lxc_controller.c| 11 +++--- src/remote/remote_daemon.c | 52 ++---

[PATCH v2 08/40] bhyve: convert bhyveMonitor to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/bhyve/bhyve_monitor.c | 48 +-- src/bhyve/bhyve_monitor.h | 3 ++- 2 files changed, 33 insertions(+), 18 deletions(-) diff --git a/src/bhyve/bhyve_monitor.c b/src/bhyve/bhyve_monitor.c index e5cd39a086..3efa3323ff 100644

[PATCH v2 05/40] rpc: convert virNetClientProgram to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/admin/admin_remote.c| 9 +++ src/locking/lock_driver_lockd.c | 19 +++--- src/logging/log_manager.c | 15 +-- src/lxc/lxc_monitor.c | 2 +- src/remote/remote_driver.c | 46 +++--

[PATCH v2 03/40] qemu: convert virQEMUCaps to GObject

2020-04-21 Thread Rafael Fonseca
virFileCache had to also be changed to properly unref the QEMUCaps objects; in turn, virfilecachetest was also converted to GObject so it plays nicely with virFileCache. Signed-off-by: Rafael Fonseca --- src/qemu/qemu_capabilities.c | 162 +--

[PATCH v2 04/40] util: add function to unref array of GObjects

2020-04-21 Thread Rafael Fonseca
As types are slowly converted to GObject, a helper function to unref all the GObjects in an array will come in handy, as it's already the case with virObject. Signed-off-by: Rafael Fonseca --- src/libvirt_private.syms | 1 + src/util/virobject.c | 24

[PATCH v2 07/40] conf: convert virDomainXMLOption to GObject

2020-04-21 Thread Rafael Fonseca
Signed-off-by: Rafael Fonseca --- src/bhyve/bhyve_driver.c | 2 +- src/conf/domain_conf.c| 29 +++-- src/conf/domain_conf.h| 9 + src/esx/esx_driver.c | 2 +- src/libvirt_private.syms | 1 + src/libxl/libxl_driver.c | 2

[PATCH v2 01/40] util: virresctrl: convert classes to GObject

2020-04-21 Thread Rafael Fonseca
This patch changes virResctrlInfo, virResctrlAlloc and virResctrlMonitor from virObject to GObject. Signed-off-by: Rafael Fonseca --- src/conf/capabilities.c | 2 +- src/conf/domain_conf.c | 19 ++--- src/libvirt_private.syms | 3 + src/util/virresctrl.c| 164

Re: [PATCH 20/36] datatypes: convert virNetworkPort to GObject

2020-04-21 Thread Rafael Fonseca
On Wed, Apr 8, 2020 at 11:37 PM Jonathon Jongsma wrote: > > On Fri, 2020-04-03 at 17:15 +0200, Rafael Fonseca wrote: > > @@ -482,14 +495,14 @@ virNetworkFinalize(GObject *obj) > > * @uuid: pointer to the uuid > > * > > * Allocates a new network port object. When the object is no longer > >

[PATCH v2 3/5] docs: Docs and rng schemas for io_uring

2020-04-21 Thread Han Han
Signed-off-by: Han Han --- docs/formatdomain.html.in | 3 ++- docs/schemas/domaincommon.rng | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 00776668..b2f87e8a 100644 --- a/docs/formatdomain.html.in +++

[PATCH v2 5/5] news: qemu: support async IO mode 'io_uring'

2020-04-21 Thread Han Han
Signed-off-by: Han Han --- docs/news.xml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 4d0efd42..2b00a5ae 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -56,6 +56,17 @@ hotplug/unplug attempts, but this is often undesireable).

[PATCH v2 0/5] qemu: spport AIO interface io_uring

2020-04-21 Thread Han Han
Changes from v1: - Separate the news XML patch from the docs patch - More details in the descrition of news XML - Change bus type of unit tests XML from ide to virtio - Fix missing spaces in docs patch - Reorder the sequence of patches git repo:

[PATCH v2 4/5] tests: Tests for io mode io_uring

2020-04-21 Thread Han Han
Signed-off-by: Han Han --- tests/qemublocktest.c | 1 + ...le-backing_basic-aio_io_uring-srconly.json | 44 + .../file-backing_basic-aio_io_uring.json | 66 +++ .../file-backing_basic-aio_io_uring.xml | 47 +

[PATCH v2 1/5] qemu_capabilities: Introduce QEMU_CAPS_AIO_IO_URING

2020-04-21 Thread Han Han
Add io_uring value to capability replies. The capability QEMU_CAPS_AIO_IO_URING will be used for io_uring aio mode, introduced from QEMU 5.0, linux 5.1. Signed-off-by: Han Han --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h

[PATCH v2 2/5] qemu: Implement the aio mode io_uring

2020-04-21 Thread Han Han
This aio mode was added since Linux 5.1[1], QEMU 5.0.0[2], which will deliever faster and more efficient I/O operations for the file, host_device, host_cdrom backends. Reference: [1]: https://lwn.net/Articles/810414/ [2]: https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg07686.html

[PATCH v2 0/5] qemu: Support rbd namespace attribute

2020-04-21 Thread Han Han
Change from v1: - Add rbd namespace member to aarch64 capability replies. Add rbd namespace capability test for aarch64. - Provide more details in news xml v1: https://www.redhat.com/archives/libvir-list/2020-April/msg00388.html git repo:

[PATCH v2 5/5] news: qemu: Support rbd namespace

2020-04-21 Thread Han Han
Signed-off-by: Han Han --- docs/news.xml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 0d3f3386..14ebc15f 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -44,6 +44,16 @@ + + + qemu: Support rbd namespace

[PATCH v2 4/5] doc: rng schemas and html doc for rbd namespace attribute

2020-04-21 Thread Han Han
Signed-off-by: Han Han --- docs/formatdomain.html.in | 5 + docs/schemas/domaincommon.rng | 3 +++ 2 files changed, 8 insertions(+) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index d56600dc..06e1a7ee 100644 --- a/docs/formatdomain.html.in +++

[PATCH v2 3/5] qemu: Implement rbd namespace attribute

2020-04-21 Thread Han Han
Ceph Nautilus supports separate image namespaces within a pool for tenant isolation and QEMU added it as a rbd blockdev options from 5.0.0. This optional attribute is used to access a image with namespace. Add unit tests for this attribute. https://bugzilla.redhat.com/show_bug.cgi?id=1816909

[PATCH v2 2/5] conf: Support to parse rbd namespace attribute

2020-04-21 Thread Han Han
Signed-off-by: Han Han --- src/conf/domain_conf.c| 4 src/util/virstoragefile.h | 1 + 2 files changed, 5 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6ad7552b..a4ee2e1e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9488,6

[PATCH v2 1/5] qemu_capabilities: Add QEMU_CAPS_RBD_NAMESPACE

2020-04-21 Thread Han Han
Add rbd namespace in aarch64 capability replies. The capability flag will be used for rbd namespace option. The rbd namespace is introduced since ceph Nautilus and qemu v5.0.0. Signed-off-by: Han Han --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h

RE: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

2020-04-21 Thread Tian, Kevin
> From: Yan Zhao > Sent: Tuesday, April 21, 2020 10:37 AM > > On Tue, Apr 21, 2020 at 06:56:00AM +0800, Alex Williamson wrote: > > On Sun, 19 Apr 2020 21:24:57 -0400 > > Yan Zhao wrote: > > > > > On Fri, Apr 17, 2020 at 07:24:57PM +0800, Cornelia Huck wrote: > > > > On Fri, 17 Apr 2020 05:52:02

Re: [RFC 00/29] RFC: Generate object-model code based on relax-ng files

2020-04-21 Thread Daniel P . Berrangé
On Wed, Mar 25, 2020 at 03:11:40PM +0800, Shi Lei wrote: > Outline > = > > In libvirt world, objects(like domain, network, etc.) are described with two > representations: structures in c-language and XML specified by relax-ng. > Since c-language-implementation and xml restricted by

Re: [PATCH 0/5] Xen: Add support for xl.cfg passthrough setting

2020-04-21 Thread Michal Privoznik
On 4/18/20 12:29 AM, Jim Fehlig wrote: Hi All, Note: This series is based on Marek's patches adding support for e820_host https://www.redhat.com/archives/libvir-list/2020-April/msg00633.html which I've ACK'ed, but am waiting to commit until this related setting is hashed out. This series

Re: [libvirt PATCH v3 3/5] add virQEMUCapsProbeQMPTCGState function to set QEMU_CAPS_TCG_DISABLED

2020-04-21 Thread Peter Krempa
On Mon, Apr 20, 2020 at 15:25:08 -0400, Tobin Feldman-Fitzthum wrote: > virQEMUCapsProbeQMPTCGState will set QEMU_CAPS_TCG_DISABLED if QEMU > version is at least 2.10, KVM is enabled, and qom-list-types does > not include tcg-accel. > > Signed-off-by: Tobin Feldman-Fitzthum > --- >

Re: [libvirt PATCH v3 5/5] Add second qom-list-types call to test data.

2020-04-21 Thread Peter Krempa
On Mon, Apr 20, 2020 at 15:25:10 -0400, Tobin Feldman-Fitzthum wrote: > We make an additional call to qom-list-types. Adjust > qemucapabilitiesdata accordingly. > > Signed-off-by: Tobin Feldman-Fitzthum > --- > .../caps_2.10.0.aarch64.replies | 2699 ++- >

Re: [libvirt-ci PATCH v2] Fix comment about not building libvirt-tck on CentOS

2020-04-21 Thread Michal Privoznik
On 4/21/20 10:23 AM, Andrea Bolognani wrote: The comment is singling out perl-generators, but actually there's a bunch of more critical Perl packages missing. Update the comment to reflect that. Signed-off-by: Andrea Bolognani --- guests/playbooks/build/projects/libvirt-tck.yml | 4 ++--

[libvirt-ci PATCH v2] Fix comment about not building libvirt-tck on CentOS

2020-04-21 Thread Andrea Bolognani
The comment is singling out perl-generators, but actually there's a bunch of more critical Perl packages missing. Update the comment to reflect that. Signed-off-by: Andrea Bolognani --- guests/playbooks/build/projects/libvirt-tck.yml | 4 ++-- jenkins/projects/libvirt-tck.yaml | 4