Re: [PATCH] lxc: Set default security model in XML parser config

2020-12-04 Thread Jim Fehlig
On 12/4/20 2:35 AM, Daniel P. Berrangé wrote: On Thu, Dec 03, 2020 at 04:25:42PM -0700, Jim Fehlig wrote: Attempting to create a lxc domain with fails virsh --connect lxc:/// create distro_nosec.xml error: Failed to create domain from distro_nosec.xml error: unsupported configuration: Security

Re: [PATCH v2 00/10] qemu: add option to process offloaded legacy blockjob event ealier

2020-12-04 Thread Nikolay Shirokovskiy
On 04.12.2020 19:46, Peter Krempa wrote: > On Fri, Dec 04, 2020 at 19:28:55 +0300, Nikolay Shirokovskiy wrote: >> >> >> On 04.12.2020 19:24, Peter Krempa wrote: >>> On Fri, Dec 04, 2020 at 19:00:57 +0300, Nikolay Shirokovskiy wrote: On 04.12.2020 18:52, Peter Krempa wrote: > O

Re: [PATCH v2 00/10] qemu: add option to process offloaded legacy blockjob event ealier

2020-12-04 Thread Nikolay Shirokovskiy
On 04.12.2020 19:24, Peter Krempa wrote: > On Fri, Dec 04, 2020 at 19:00:57 +0300, Nikolay Shirokovskiy wrote: >> >> >> On 04.12.2020 18:52, Peter Krempa wrote: >>> On Fri, Dec 04, 2020 at 18:44:00 +0300, Nikolay Shirokovskiy wrote: On 04.12.2020 18:11, Peter Krempa wrote: > On Fri, Nov

Re: [PATCH v2 00/10] qemu: add option to process offloaded legacy blockjob event ealier

2020-12-04 Thread Nikolay Shirokovskiy
On 04.12.2020 18:52, Peter Krempa wrote: > On Fri, Dec 04, 2020 at 18:44:00 +0300, Nikolay Shirokovskiy wrote: >> On 04.12.2020 18:11, Peter Krempa wrote: >>> On Fri, Nov 13, 2020 at 09:53:28 +0300, Nikolay Shirokovskiy wrote: > > [...] > >> Ok. By the way what about the issue described in >>

Re: [PATCH v2 00/10] qemu: add option to process offloaded legacy blockjob event ealier

2020-12-04 Thread Nikolay Shirokovskiy
On 04.12.2020 18:11, Peter Krempa wrote: > On Fri, Nov 13, 2020 at 09:53:28 +0300, Nikolay Shirokovskiy wrote: >> This is successor to [1] but I changed the subject as in the review the patch >> 'qemu: sync backing chain update in virDomainGetBlockJobInfo' was not >> considered good one from des

Re: [RFCv2 00/46] RFC: Generate parsexml/formatbuf functions based on directives

2020-12-04 Thread Daniel P . Berrangé
On Fri, Sep 04, 2020 at 11:34:52AM +0800, Shi Lei wrote: > V1 here: [https://www.redhat.com/archives/libvir-list/2020-June/msg00357.html] > > Differ from V1: > > * Move the generator into scripts/xmlgen and rename it 'xmlgen'. > > * Declare virXMLChildNode and virXMLChildNodeSet in libvirt_p

Re: [RFCv2 42/46] conf: Replace virDomainGraphicsListenDefParseXML(hardcoded) with namesake(generated)

2020-12-04 Thread Daniel P . Berrangé
On Fri, Sep 04, 2020 at 11:35:34AM +0800, Shi Lei wrote: > Signed-off-by: Shi Lei > --- > src/conf/domain_conf.c | 109 --- > src/conf/domain_conf.h | 18 ++--- > src/qemu/qemu_command.c | 2 + > src/qemu/qemu_hotplug.c | 1 +

Re: [PATCH v3 3/5] domain_conf.c: revert auto-alignment of pSeries NVDIMM in post parse

2020-12-04 Thread Daniel Henrique Barboza
On 12/4/20 3:15 PM, Andrea Bolognani wrote: On Fri, 2020-12-04 at 13:50 -0300, Daniel Henrique Barboza wrote: On 12/4/20 12:13 PM, Andrea Bolognani wrote: I suggest you instead do a pseudo-revert, where you rename the function (without otherwise altering its signature) and move it to the par

Re: [RFCv2 37/46] conf: Replace virDomainGraphicsDefParseXMLSpice(hardcoded) with virDomainGraphicsSpiceDefParseXML(generated)

2020-12-04 Thread Daniel P . Berrangé
On Fri, Sep 04, 2020 at 11:35:29AM +0800, Shi Lei wrote: > Signed-off-by: Shi Lei > --- > src/conf/domain_conf.c | 272 ++--- > src/conf/domain_conf.h | 37 +++--- > 2 files changed, 26 insertions(+), 283 deletions(-) > > diff --git a/src/conf/domain_conf.c b

Re: [PATCH v3 3/5] domain_conf.c: revert auto-alignment of pSeries NVDIMM in post parse

2020-12-04 Thread Andrea Bolognani
On Fri, 2020-12-04 at 13:50 -0300, Daniel Henrique Barboza wrote: > On 12/4/20 12:13 PM, Andrea Bolognani wrote: > > I suggest you instead do a pseudo-revert, where you rename the > > function (without otherwise altering its signature) and move it to > > the part of qemu_domain.c where you are ulti

Re: [RFCv2 05/46] util: Add helper functions for 'bool' and 'time_t' and cooperate with xmlgen

2020-12-04 Thread Daniel P . Berrangé
On Fri, Sep 04, 2020 at 11:34:57AM +0800, Shi Lei wrote: > Signed-off-by: Shi Lei > --- > src/libvirt_private.syms | 3 +++ > src/util/virstring.c | 57 > src/util/virstring.h | 9 +++ > 3 files changed, 69 insertions(+) > > diff --git a/src

Re: [RFCv2 00/46] RFC: Generate parsexml/formatbuf functions based on directives

2020-12-04 Thread Daniel P . Berrangé
On Fri, Sep 04, 2020 at 11:34:52AM +0800, Shi Lei wrote: > V1 here: [https://www.redhat.com/archives/libvir-list/2020-June/msg00357.html] > For those new and changed directives, illustrate them by an example: > > struct _virDomainGraphicsAuthDef { /* genparse, genformat:separate */ > char *

Re: [PATCH 0/7] qemu: Add workaround for apps polling virDomainGetBlockJobInfo with pre-blockdev qemu

2020-12-04 Thread Michal Privoznik
On 12/4/20 4:07 PM, Peter Krempa wrote: This is a workaround for the issue that Nikolay tries to fix in: https://www.redhat.com/archives/libvir-list/2020-November/msg00669.html This one is a far more focused hack for apps which don't bother to update to events for block job completion checking.

Re: [PATCH 3/7] qemuMonitorBlockJobInfo: Store 'ready' and 'ready_present' separately

2020-12-04 Thread Michal Privoznik
On 12/4/20 4:07 PM, Peter Krempa wrote: Don't make the logic confusing by representing the 3 options using an integer with negative values. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 9 + src/qemu/qemu_monitor.h | 3 ++- src/qemu/qemu_monitor_json.c | 8 ++--

Re: [RFCv2 01/46] scripts: Add a tool to generate xml parse/format functions

2020-12-04 Thread Daniel P . Berrangé
On Fri, Sep 04, 2020 at 11:34:53AM +0800, Shi Lei wrote: > This tool is used to generate parsexml/formatbuf functions. > It is based on libclang and its python-binding. > Some directives (such as genparse, xmlattr, etc.) need to be added on > the declarations of structs to direct the tool. In test

Re: [PATCH v2 RESEND] lxc: Cleanup after failed startup

2020-12-04 Thread Martin Kletzander
On Thu, Dec 03, 2020 at 09:46:20PM +0100, Michal Privoznik wrote: If starting an container fails, the virLXCProcessStop() is called. But since vm->def->id is not set until libvirt_lxc is spawned (the domain's ID is PID of that process), virLXCProcessStop() returns early as virDomainObjIsActive()

Re: [PATCH v3 3/5] domain_conf.c: revert auto-alignment of pSeries NVDIMM in post parse

2020-12-04 Thread Daniel Henrique Barboza
On 12/4/20 12:13 PM, Andrea Bolognani wrote: On Fri, 2020-12-04 at 15:55 +0100, Andrea Bolognani wrote: On Thu, 2020-12-03 at 22:05 -0300, Daniel Henrique Barboza wrote: This reverts commit d3f3c2c97f9b92c982ff809479495f44614edb88 (domain_conf.c: auto-align pSeries NVDIMM in virDomainMemoryD

Re: [PATCH v2 00/10] qemu: add option to process offloaded legacy blockjob event ealier

2020-12-04 Thread Peter Krempa
On Fri, Dec 04, 2020 at 19:28:55 +0300, Nikolay Shirokovskiy wrote: > > > On 04.12.2020 19:24, Peter Krempa wrote: > > On Fri, Dec 04, 2020 at 19:00:57 +0300, Nikolay Shirokovskiy wrote: > >> > >> > >> On 04.12.2020 18:52, Peter Krempa wrote: > >>> On Fri, Dec 04, 2020 at 18:44:00 +0300, Nikolay

Re: [PATCH libvirt v4 00/12] Support AP card, AP queues and AP matrix

2020-12-04 Thread Cornelia Huck
On Fri, 4 Dec 2020 16:31:56 +0100 Boris Fiuczynski wrote: > On 12/4/20 11:24 AM, Erik Skultety wrote: > > On Thu, Dec 03, 2020 at 06:59:32PM +0100, Shalini Chellathurai Saroja > > wrote: > >> Add support for AP card devices, AP queues and AP matrix devices in > >> libvirt node device driver. >

Re: [PATCH v2 00/10] qemu: add option to process offloaded legacy blockjob event ealier

2020-12-04 Thread Peter Krempa
On Fri, Dec 04, 2020 at 19:00:57 +0300, Nikolay Shirokovskiy wrote: > > > On 04.12.2020 18:52, Peter Krempa wrote: > > On Fri, Dec 04, 2020 at 18:44:00 +0300, Nikolay Shirokovskiy wrote: > >> On 04.12.2020 18:11, Peter Krempa wrote: > >>> On Fri, Nov 13, 2020 at 09:53:28 +0300, Nikolay Shirokovsk

Re: [PATCH] qemu: Drop @qemuCaps argument from qemuDomainDefValidateMemoryHotplug()

2020-12-04 Thread Peter Krempa
On Fri, Dec 04, 2020 at 16:29:51 +0100, Michal Privoznik wrote: > After previous cleanup the @qemuCaps argument in > qemuDomainDefValidateMemoryHotplug() is unused and thus doesn't > need to be passed. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_domain.c | 2 -- > src/qemu/qemu_d

Re: [PATCH] apparmor: Drop needless check in AppArmorSetMemoryLabel()

2020-12-04 Thread Peter Krempa
On Fri, Dec 04, 2020 at 16:31:03 +0100, Michal Privoznik wrote: > The AppArmorSetMemoryLabel() is a callback that is called from > qemuSecuritySetMemoryLabel() which never passes NULL as @mem. > Therefore, there is no need to check whether @mem is NULL. Also, > no other driver does that and just de

Re: [PATCH v2 00/10] qemu: add option to process offloaded legacy blockjob event ealier

2020-12-04 Thread Peter Krempa
On Fri, Dec 04, 2020 at 18:44:00 +0300, Nikolay Shirokovskiy wrote: > On 04.12.2020 18:11, Peter Krempa wrote: > > On Fri, Nov 13, 2020 at 09:53:28 +0300, Nikolay Shirokovskiy wrote: [...] > Ok. By the way what about the issue described in > > [PATCH v2 09/10] qemu: fix race on legacy block com

Re: [PATCH libvirt v4 00/12] Support AP card, AP queues and AP matrix

2020-12-04 Thread Boris Fiuczynski
On 12/4/20 11:24 AM, Erik Skultety wrote: On Thu, Dec 03, 2020 at 06:59:32PM +0100, Shalini Chellathurai Saroja wrote: Add support for AP card devices, AP queues and AP matrix devices in libvirt node device driver. --- v4: - Added virNodeDevAPAdapterParseXML function to extract the adapter

[PATCH] apparmor: Drop needless check in AppArmorSetMemoryLabel()

2020-12-04 Thread Michal Privoznik
The AppArmorSetMemoryLabel() is a callback that is called from qemuSecuritySetMemoryLabel() which never passes NULL as @mem. Therefore, there is no need to check whether @mem is NULL. Also, no other driver does that and just dereference it immediately. Signed-off-by: Michal Privoznik --- src/sec

[PATCH] qemu: Drop @qemuCaps argument from qemuDomainDefValidateMemoryHotplug()

2020-12-04 Thread Michal Privoznik
After previous cleanup the @qemuCaps argument in qemuDomainDefValidateMemoryHotplug() is unused and thus doesn't need to be passed. Signed-off-by: Michal Privoznik --- src/qemu/qemu_domain.c | 2 -- src/qemu/qemu_domain.h | 1 - src/qemu/qemu_hotplug.c | 2 +- src/qemu/qemu_validate.c | 2 +

Re: [PATCH v3 5/5] qemu_domain.c: align all pSeries mem modules when PARSE_ABI_UPDATE

2020-12-04 Thread Andrea Bolognani
On Thu, 2020-12-03 at 22:05 -0300, Daniel Henrique Barboza wrote: > qemuDomainAlignMemorySizes() has an operation order problem. We are > calculating 'initialmem' without aligning the memory modules first. > Since we're aligning the dimms afterwards this can create inconsistencies > in the end resu

Re: [PATCH v3 3/5] domain_conf.c: revert auto-alignment of pSeries NVDIMM in post parse

2020-12-04 Thread Andrea Bolognani
On Fri, 2020-12-04 at 15:55 +0100, Andrea Bolognani wrote: > On Thu, 2020-12-03 at 22:05 -0300, Daniel Henrique Barboza wrote: > > This reverts commit d3f3c2c97f9b92c982ff809479495f44614edb88 > > (domain_conf.c: auto-align pSeries NVDIMM in virDomainMemoryDefPostParse()). > > > > This reverts comm

Re: [PATCH v2 00/10] qemu: add option to process offloaded legacy blockjob event ealier

2020-12-04 Thread Peter Krempa
On Fri, Nov 13, 2020 at 09:53:28 +0300, Nikolay Shirokovskiy wrote: > This is successor to [1] but I changed the subject as in the review the patch > 'qemu: sync backing chain update in virDomainGetBlockJobInfo' was not > considered good one from design POV. However I think the basic patch is > he

[PATCH 6/7] qemu: monitor: Remove unused qemuMonitorGetBlockJobInfo

2020-12-04 Thread Peter Krempa
Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.c | 29 - src/qemu/qemu_monitor.h | 4 2 files changed, 33 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 551b65e778..40f2997cb6 100644 --- a/src/qemu/qemu_monitor.c +++ b/s

[PATCH 5/7] qemuDomainGetBlockJobInfo: Use qemuMonitorGetAllBlockJobInfo

2020-12-04 Thread Peter Krempa
Replace qemuMonitorGetBlockJobInfo by qemuMonitorGetAllBlockJobInfo and hash table lookup. This basically open-codes qemuMonitorGetBlockJobInfo, but it will be removed in next patch. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 20 1 file changed, 12 insertions(+

[PATCH 3/7] qemuMonitorBlockJobInfo: Store 'ready' and 'ready_present' separately

2020-12-04 Thread Peter Krempa
Don't make the logic confusing by representing the 3 options using an integer with negative values. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 9 + src/qemu/qemu_monitor.h | 3 ++- src/qemu/qemu_monitor_json.c | 8 ++-- src/qemu/qemu_process.c | 4 ++--

[PATCH 0/7] qemu: Add workaround for apps polling virDomainGetBlockJobInfo with pre-blockdev qemu

2020-12-04 Thread Peter Krempa
This is a workaround for the issue that Nikolay tries to fix in: https://www.redhat.com/archives/libvir-list/2020-November/msg00669.html This one is a far more focused hack for apps which don't bother to update to events for block job completion checking. Peter Krempa (7): virDomainGetBlockJob

[PATCH 4/7] qemuBlockJobInfoTranslate: Use explicit comparison against 0

2020-12-04 Thread Peter Krempa
Using ! on integers is misleading. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 800f98e474..b82f7e249a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_drive

[PATCH 7/7] qemuDomainGetBlockJobInfo: Work stats for unfinished pre-blockdev blockjob

2020-12-04 Thread Peter Krempa
If the job has finished, but we didn't yet process the completion fake that it's still incomplete so that apps which decided to poll qemuDomainGetBlockJobInfo rather than use events can be sure that the XML update was completed. Signed-off-by: Peter Krempa --- src/qemu/qemu_driver.c | 14 +++

[PATCH 1/7] virDomainGetBlockJobInfo: Discourage polling for block job completion detection

2020-12-04 Thread Peter Krempa
Add a note saying that polling virDomainGetBlockJobInfo is not a good idea. Use events instead. Signed-off-by: Peter Krempa --- src/libvirt-domain.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index f5cd43ecea..5d3747fd39 100644 --- a/src/

[PATCH 2/7] virDomainGetBlockJobInfo: Reword docs for fallback values

2020-12-04 Thread Peter Krempa
Explicitly state that if 'end == 1' the data doesn't represent actual progress in most cases. Signed-off-by: Peter Krempa --- src/libvirt-domain.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 5d3747fd39.

Re: [PATCH v3 1/5] tests: Sync some ppc64 tests

2020-12-04 Thread Andrea Bolognani
On Thu, 2020-12-03 at 22:05 -0300, Daniel Henrique Barboza wrote: > From: Andrea Bolognani > > The ppc64 tests > > memory-hotplug-ppc64-nonuma > memory-hotplug-nvdimm-ppc64 > > are not passed the same information for qemuxml2argv and > qemuxml2xml tests; the former, in particular, doesn't s

Re: [PATCH v2 0/6] add post parse pSeries mem align, when ABI_UPDATE

2020-12-04 Thread Andrea Bolognani
On Thu, 2020-12-03 at 17:04 -0300, Daniel Henrique Barboza wrote: > On 12/3/20 11:37 AM, Andrea Bolognani wrote: > > This is where I'm a bit confused. IIUC the new value for , > > 1572992 KiB, is exactly 1 GiB (initial NUMA memory) + 512 MiB (NVDIMM > > guest area size) + 128 KiB (NVDIMM label size

Re: [PATCH v3 3/5] domain_conf.c: revert auto-alignment of pSeries NVDIMM in post parse

2020-12-04 Thread Andrea Bolognani
On Thu, 2020-12-03 at 22:05 -0300, Daniel Henrique Barboza wrote: > This reverts commit d3f3c2c97f9b92c982ff809479495f44614edb88 > (domain_conf.c: auto-align pSeries NVDIMM in virDomainMemoryDefPostParse()). > > This reverts commit ace5931553c87beebb6b3cd994061742b3f88238 > (conf, qemu: move qemuD

Re: Ping: [PATCH] Qemu: migration: Not bind RAM info with active migration status

2020-12-04 Thread Daniel Henrique Barboza
On 12/4/20 5:12 AM, zhukeqian wrote: Hi folks, Kindly ping. I found that this patch is not applied. Has reviewed by Daniel Henrique Barboza and Daniel P. Berrangé. It has my ACK, but looking into the messages I see that Daniel was inquiring about this being a bug fix or an enhancement (he

Re: [PATCH v2 27/27] news: document recent virtio memory addition

2020-12-04 Thread Peter Krempa
On Thu, Dec 03, 2020 at 13:36:30 +0100, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > NEWS.rst | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index 135c4e2fe0..adedf15d2b 100644 > --- a/NEWS.rst > +++ b/NEWS.rst > @@ -13,6 +13,15 @@ v7

Re: [PATCH v2 25/27] virsh: Simplify @flags handing in cmdSetmem() and cmdSetmaxmem()

2020-12-04 Thread Peter Krempa
On Thu, Dec 03, 2020 at 13:36:28 +0100, Michal Privoznik wrote: > What code tries to achieve is that if no flags were provided to > either 'setmem' or 'setmaxmem' commands then the old (no flags) > API is called to be able to communicate with older daemons. > Well, the code can be simplified a bit.

[PATCH 2/2] qemu: Restore default root qdisc when QoS is cleared out

2020-12-04 Thread Michal Privoznik
When an interface has some bandwidth limitation set (it's root qdisc is htb in that case) but this gets cleared out via public API call (virDomainSetInterfaceParameters() or virDomainUpdateDeviceFlags()) then virNetDevBandwidthSet() clears out whatever qdiscs were set on the interface and kernel pl

[PATCH 0/2] qemu: Restore default root qdisc when QoS is cleared out

2020-12-04 Thread Michal Privoznik
This fixes my previous series: https://www.redhat.com/archives/libvir-list/2020-October/msg00636.html Michal Prívozník (2): qemu: Set default qdisc before setting bandwidth qemu: Restore default root qdisc when QoS is cleared out src/qemu/qemu_command.c | 4 ++-- src/qemu/qemu_driver.c |

[PATCH 1/2] qemu: Set default qdisc before setting bandwidth

2020-12-04 Thread Michal Privoznik
While the code that's setting default qdisc is clever enough to not overwrite any bandwidth (potentially) set by virNetDevBandwidthSet() (and thus the root qdisc htb is not replaced with noqueue), it does print a debug message when that's the case. It's needless. We can set the root qdisc beforehan

Re: [PATCH v2 26/27] virsh: Introduce --virtio to setmem

2020-12-04 Thread Peter Krempa
On Thu, Dec 03, 2020 at 13:36:29 +0100, Michal Privoznik wrote: > Provide an user friendly way of modifying 'requested-size' of a > virtio-mem device. New --node and --alias arguments are > introduced but they are needed only if it is not clear which > virtio-mem does user mean. > > Signed-off-by:

Re: [RFCv2 02/46] maint: Check python3-clang

2020-12-04 Thread Daniel P . Berrangé
On Fri, Sep 04, 2020 at 11:34:54AM +0800, Shi Lei wrote: > Make sure python3-clang has been installed. > > Signed-off-by: Shi Lei > --- > meson.build | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/meson.build b/meson.build > index 1eadea3..f97a03b 100644 > --- a/meson.build > +++

Re: [PATCH v2 23/27] qemu: Wire up MEMORY_DEVICE_SIZE_CHANGE event

2020-12-04 Thread Peter Krempa
On Thu, Dec 03, 2020 at 13:36:26 +0100, Michal Privoznik wrote: > As advertised in previous commit, this event is delivered to us > when virtio-mem module changes the allocation inside the guest. > It comes with one attribute - size - which holds the new size of > the virtio-mem (well, allocated si

Re: [PATCH 5/5] conf: checkpoint: Don't require when redefining checkpoints

2020-12-04 Thread Daniel Henrique Barboza
On 12/2/20 11:13 AM, Peter Krempa wrote: The domain definition stored with a checkpoint isn't used currently apart from matching disks when creating a new checkpoints. As some users of the incremental backup API want to provide backups in offline mode under their control (obviously while comp

Re: [PATCH 4/5] conf: checkpoint: Prepare internals for missing domain definition

2020-12-04 Thread Daniel Henrique Barboza
On 12/2/20 11:13 AM, Peter Krempa wrote: Coniditonalize code which assumes that the domain definition stored in s/Coniditonalize/Conditionalize the checkpoint is present. Signed-off-by: Peter Krempa --- Reviewed-by: Daniel Henrique Barboza src/conf/checkpoint_conf.c

Re: [PATCH 3/5] virDomainCheckpointRedefineCommit: Don't check ABI of definition in checkpoint

2020-12-04 Thread Daniel Henrique Barboza
On 12/2/20 11:13 AM, Peter Krempa wrote: Checking the definition ABI when redefining checkpoints doesn't make much sense for the following reasons: * the domain definition in the checkpoint is mostly unused (a relic adopted from the snapshot code) * can be very easily overriden by deletin

Re: [PATCH 2/5] virDomainCheckpointDefParse: Use 'unsigned int' for flags

2020-12-04 Thread Daniel Henrique Barboza
On 12/2/20 11:13 AM, Peter Krempa wrote: Fix the type for a variable holding flags to the usual 'unsigned int' and change the name to be more appropriate to it's use. s/it's/its Reviewed-by: Daniel Henrique Barboza Signed-off-by: Peter Krempa --- src/conf/checkpoint_conf.c | 6 +++--

Re: [PATCH 1/5] virDomainCheckpointDefParse: Don't extract unused domain type

2020-12-04 Thread Daniel Henrique Barboza
On 12/2/20 11:13 AM, Peter Krempa wrote: We can extract './domain' directly and let the parser deal with the type. Signed-off-by: Peter Krempa --- Reviewed-by: Daniel Henrique Barboza src/conf/checkpoint_conf.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) dif

Re: [PATCH v2 20/27] conf: Introduce virtio-mem model

2020-12-04 Thread Peter Krempa
On Fri, Dec 04, 2020 at 13:17:52 +0100, Peter Krempa wrote: > On Thu, Dec 03, 2020 at 13:36:23 +0100, Michal Privoznik wrote: > > QEMU gained this new virtio-mem model. It's similar to pc-dimm > > in a sense that guest uses it as memory, but in a sense very > > different from it as it can dynamical

Re: [PATCH v2 22/27] qemu: Wire up live update

2020-12-04 Thread Peter Krempa
On Thu, Dec 03, 2020 at 13:36:25 +0100, Michal Privoznik wrote: > As advertised in the previous commit, we want' to be able to > change 'requested-size' attribute of virtio-mem on the fly. This > commit does exactly that. Changing anything else is checked for > and forbidden. > > Signed-off-by: Mi

Re: [PATCH v2 20/27] conf: Introduce virtio-mem model

2020-12-04 Thread Peter Krempa
On Thu, Dec 03, 2020 at 13:36:23 +0100, Michal Privoznik wrote: > QEMU gained this new virtio-mem model. It's similar to pc-dimm > in a sense that guest uses it as memory, but in a sense very > different from it as it can dynamically change allocation, > without need for hotplug. More specifically,

Re: [PATCH v2 19/27] qemu: Build command line for virtio-pmem

2020-12-04 Thread Peter Krempa
On Thu, Dec 03, 2020 at 13:36:22 +0100, Michal Privoznik wrote: > Now we have everything prepared for generating the command line. > The device alias prefix was chosen to be 'virtiopmem'. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1735375 > Signed-off-by: Michal Privoznik > --- >

Re: [libvirt PATCH] cpu_map: Fix Icelake Server model number

2020-12-04 Thread Jiri Denemark
On Wed, Dec 02, 2020 at 11:38:22 +0100, Tim Wiederhake wrote: > See arch/x86/include/asm/intel-family.h in the Kernel: > #define INTEL_FAM6_ICELAKE_X0x6A > > Signed-off-by: Tim Wiederhake > --- > src/cpu_map/x86_Icelake-Server-noTSX.xml | 2 +- > src/cpu_map/x86_Icelake-Server.

Re: [PATCH libvirt v4 00/12] Support AP card, AP queues and AP matrix

2020-12-04 Thread Erik Skultety
On Thu, Dec 03, 2020 at 06:59:32PM +0100, Shalini Chellathurai Saroja wrote: > Add support for AP card devices, AP queues and AP matrix devices in > libvirt node device driver. > --- > v4: > - Added virNodeDevAPAdapterParseXML function to extract the adapter >parsing logic. > - Modified accor

Re: [PATCH libvirt v4 06/12] nodedev: detect AP matrix device

2020-12-04 Thread Erik Skultety
On Thu, Dec 03, 2020 at 06:59:38PM +0100, Shalini Chellathurai Saroja wrote: > Add support for AP matrix device in libvirt node device driver. > > Signed-off-by: Shalini Chellathurai Saroja > Reviewed-by: Bjoern Walk > Reviewed-by: Boris Fiuczynski > --- > docs/schemas/nodedev.rng |

Re: [PATCH libvirt v4 12/12] NEWS: mention node device driver support for AP devices

2020-12-04 Thread Erik Skultety
On Thu, Dec 03, 2020 at 06:59:44PM +0100, Shalini Chellathurai Saroja wrote: > Signed-off-by: Shalini Chellathurai Saroja > --- > NEWS.rst | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index 135c4e2f..5fa9d68f 100644 > --- a/NEWS.rst > +++ b/NEWS.rst > @@ -

Re: [PATCH] lxc: Set default security model in XML parser config

2020-12-04 Thread Daniel P . Berrangé
On Thu, Dec 03, 2020 at 04:25:42PM -0700, Jim Fehlig wrote: > Attempting to create a lxc domain with fails > > virsh --connect lxc:/// create distro_nosec.xml > error: Failed to create domain from distro_nosec.xml > error: unsupported configuration: Security driver model '(null)' is not > availa

Re: [PATCH v2 18/27] qemu_command: Move dimm into qemuBuildDeviceAddressStr()

2020-12-04 Thread Peter Krempa
On Thu, Dec 03, 2020 at 13:36:21 +0100, Michal Privoznik wrote: > So far our memory modules could go only into DIMM slots. But with > virtio model this assumption is no longer true - virtio-pmem goes > onto PCI bus. But for formatting PCI address onto command line we > already have a function - qem

Re: [PATCH] lxc: Set default security model in XML parser config

2020-12-04 Thread Michal Privoznik
On 12/4/20 12:25 AM, Jim Fehlig wrote: Attempting to create a lxc domain with fails virsh --connect lxc:/// create distro_nosec.xml error: Failed to create domain from distro_nosec.xml error: unsupported configuration: Security driver model '(null)' is not available The lxc driver does not se

Re: [PATCH v2 17/27] qemu: Create virtio-pmem in domain namespace

2020-12-04 Thread Peter Krempa
On Thu, Dec 03, 2020 at 13:36:20 +0100, Michal Privoznik wrote: > Some users might wanto have virtio-pmem backed by a block device > in which case we have to create the device in domain namespace. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_namespace.c | 19 +-- > 1

Re: [PATCH v2 16/27] qemu: Allow virtio-pmem in CGroups

2020-12-04 Thread Peter Krempa
On Thu, Dec 03, 2020 at 13:36:19 +0100, Michal Privoznik wrote: > Some users might wanto have virtio-pmem backed by a block device > in which case we have to allow the device in CGroups. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_cgroup.c | 43 -

Re: [PATCH v2 15/27] security: Relabel virtio mem

2020-12-04 Thread Peter Krempa
On Thu, Dec 03, 2020 at 13:36:18 +0100, Michal Privoznik wrote: > Signed-off-by: Michal Privoznik > --- > src/security/security_apparmor.c | 26 > src/security/security_dac.c | 42 +--- > src/security/security_selinux.c | 42 +

Ping: [PATCH] Qemu: migration: Not bind RAM info with active migration status

2020-12-04 Thread zhukeqian
Hi folks, Kindly ping. I found that this patch is not applied. Has reviewed by Daniel Henrique Barboza and Daniel P. Berrangé. Cheers, Keqian On 2020/7/15 14:18, Keqian Zhu wrote: > For that Qemu supports returning incoming migration info since its commit > 65ace0604551 (migration: add postcopy

Re: [PATCH v2 13/27] qemu_capabilities: Introduce QEMU_CAPS_DEVICE_VIRTIO_{P}MEM_PCI

2020-12-04 Thread Peter Krempa
On Thu, Dec 03, 2020 at 13:36:16 +0100, Michal Privoznik wrote: > In this commit two new capabilities are introduced that reflect > device support by give qemu: > > QEMU_CAPS_DEVICE_VIRTIO_MEM_PCI, /* -device virtio-mem-pci */ > QEMU_CAPS_DEVICE_VIRTIO_PMEM_PCI, /* -device virtio-pmem-pci */ > >

Re: [PATCH] spec: keep existing nwfilters uuid on update

2020-12-04 Thread Michal Privoznik
On 12/3/20 6:31 PM, Andrea Bolognani wrote: On Thu, 2020-12-03 at 17:39 +0100, Michal Privoznik wrote: On 10/26/20 10:21 AM, Nikolay Shirokovskiy wrote: -cp %{_datadir}/libvirt/nwfilter/*.xml %{_sysconfdir}/libvirt/nwfilter/ +# keep existing filters uuid on update +for dfile in %{_datadir}/libv

Re: [PATCH v2 12/27] conf: Introduce virtio-pmem model

2020-12-04 Thread Peter Krempa
On Thu, Dec 03, 2020 at 13:36:15 +0100, Michal Privoznik wrote: > The virtio-pmem is a virtio variant of NVDIMM and just like > NVDIMM virtio-pmem also allows accessing host pages bypassing > guest page cache. The difference is that if a regular file is > used to back guest's NVDIMM (model='nvdimm'