On Fri, Oct 08, 2021 at 18:51:54 +0200, Andrea Bolognani wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1653327
>
> Signed-off-by: Andrea Bolognani
> ---
> src/qemu/qemu_command.c | 17 ++---
> .../virtio-iommu-aarch64.aarch64-latest.args| 1 +
> ..
Commit 58ba0f6a3d7342fba29edbbf2bb9cb5497c870e5 added a capability which
is supported by all qemu versions we support. Remove it and the
associated dead code. Since the capability isn't present in any upstream
release we can delete it completely.
Specifically the commit itself states that it was i
On Fri, Oct 08, 2021 at 13:20:54 +0200, Ján Tomko wrote:
> On a Friday in 2021, Kristina Hanicova wrote:
> > On Thu, Oct 7, 2021 at 6:43 PM Ján Tomko wrote:
> >
> > > On a Thursday in 2021, Peter Krempa wrote:
> > > >In many cases we use a signed value, but use the sign to note that it
> > > >was
On Mon, Oct 11, 2021 at 09:04:43AM +0200, Peter Krempa wrote:
> On Fri, Oct 08, 2021 at 18:51:54 +0200, Andrea Bolognani wrote:
> > case VIR_DOMAIN_IOMMU_MODEL_VIRTIO:
> > +if (qemuBuildVirtioDevStr(&opts, "virtio-iommu", qemuCaps,
> > + VIR_DOMAIN_DEVI
This question is still open:
where should the libxl specific setting be specified?
Olaf
Am Sun, 25 Jul 2021 10:17:49 +0200
schrieb Olaf Hering :
> I think it is wrong to use internal libvirt values for internal libxentoollog
> values.
>
> There has to be a separate configuration setting to sp
Signed-off-by: Tim Wiederhake
---
src/cpu/cpu_arm.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/cpu/cpu_arm.c b/src/cpu/cpu_arm.c
index 09ade1d422..ac174891b7 100644
--- a/src/cpu/cpu_arm.c
+++ b/src/cpu/cpu_arm.c
@@ -39,12 +39,11 @@
#include "virxml.h"
#def
A function to compare two `virCPUData` objects. This is a prerequisite
for a later series, that will add the host's cpuid information to the
cpu flag cache as per [1], to solve BZ 1953389 [2].
[1] https://listman.redhat.com/archives/libvir-list/2021-August/msg00293.html
[2] https://bugzilla.redhat
Signed-off-by: Tim Wiederhake
---
src/cpu/cpu.c| 29 +
src/cpu/cpu.h| 9 +
src/libvirt_private.syms | 1 +
3 files changed, 39 insertions(+)
diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c
index b4965f3ee0..a3531dd665 100644
--- a/src/cpu/
Signed-off-by: Tim Wiederhake
---
src/cpu/cpu_ppc64.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/src/cpu/cpu_ppc64.c b/src/cpu/cpu_ppc64.c
index 4909f61ff1..fcd68c8a7c 100644
--- a/src/cpu/cpu_ppc64.c
+++ b/src/cpu/cpu_ppc64.c
@@ -578,6 +578,31 @@ ppc64DriverD
Signed-off-by: Tim Wiederhake
---
src/cpu/cpu_arm.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/src/cpu/cpu_arm.c b/src/cpu/cpu_arm.c
index ac174891b7..c9114d53bf 100644
--- a/src/cpu/cpu_arm.c
+++ b/src/cpu/cpu_arm.c
@@ -124,6 +124,32 @@ virCPUarmDataClear(vi
Signed-off-by: Tim Wiederhake
---
src/cpu/cpu_x86.c | 69 +++
1 file changed, 69 insertions(+)
diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
index 1b829e5658..55da407ec4 100644
--- a/src/cpu/cpu_x86.c
+++ b/src/cpu/cpu_x86.c
@@ -3369,6 +3369,74 @@
On a Monday in 2021, Peter Krempa wrote:
Commit 58ba0f6a3d7342fba29edbbf2bb9cb5497c870e5 added a capability which
is supported by all qemu versions we support. Remove it and the
associated dead code. Since the capability isn't present in any upstream
release we can delete it completely.
Specific
On Mon, Oct 11, 2021 at 13:26:14 +0200, Ján Tomko wrote:
> On a Monday in 2021, Peter Krempa wrote:
> > Commit 58ba0f6a3d7342fba29edbbf2bb9cb5497c870e5 added a capability which
> > is supported by all qemu versions we support. Remove it and the
> > associated dead code. Since the capability isn't p
In a50c473ad6c9 ("qemu: move temp file of screenshot and memorypeek to
per-domain dir") and c4f3c955d578 ("qemu: don't change ownership of
cache directory"), I move the temporary files of screenshot and
memorypeek from the cache directory to per-domain directory, and the
only user of the cache dire
This is v2 of:
https://listman.redhat.com/archives/libvir-list/2021-August/msg00698.html
When migrating using shared fs, the dst host will remember the image
labels again before launching the VM and the src host will remove the
image labels after migration. It leads to that the image labels lost
After migration, some labels of images need to be updated. So add
virSecurityManagerUpdateImageLabel to do it.
Signed-off-by: Peng Liang
---
src/libvirt_private.syms| 1 +
src/security/security_driver.h | 5 +
src/security/security_manager.c | 29 +
sr
Signed-off-by: Peng Liang
---
src/security/security_util.c | 32
src/security/security_util.h | 4
2 files changed, 36 insertions(+)
diff --git a/src/security/security_util.c b/src/security/security_util.c
index 26a7861e2935..07960b577e1a 100644
--- a/src/s
virSecurity{DAC,SELinux}SetImageLabelInt will be added in the next
patch, so rename virSecurity{DAC,SELinux}SetImageLabelInternal to
virSecurity{DAC,SELinux}SetImageLabelSingle to avoid confusion and keep
consistent with virSecurity{DAC,SELinux}RestoreImageLabelInt and
virSecurity{DAC,SELinux}Resto
Bacause the timestamp XATTR (the uptime of the host) is used to validate
the remembered labels, it need to update after migration.
Signed-off-by: Peng Liang
---
src/qemu/qemu_migration.c | 12
1 file changed, 12 insertions(+)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_m
Signed-off-by: Peng Liang
---
src/security/security_selinux.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c
index cc7245332980..5c491fc131ea 100644
--- a/src/security/security_selinux.c
+++ b/src/security/
Signed-off-by: Peng Liang
---
src/security/security_stack.c | 20
1 file changed, 20 insertions(+)
diff --git a/src/security/security_stack.c b/src/security/security_stack.c
index 3c2239910aa5..7712cac3b542 100644
--- a/src/security/security_stack.c
+++ b/src/security/securi
Signed-off-by: Peng Liang
---
src/security/security_dac.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/security/security_dac.c b/src/security/security_dac.c
index 1733d63410b3..d1e1552bb683 100644
--- a/src/security/security_dac.c
+++ b/src/security/security_dac.c
@
After migration, the image labels will be removed in the src host (on
success) or the dst host (on failure). However, if we migrate using
shared fs and remove image labels after migration in one host, the image
labels will also lost in another host, which leads to that the ownership
of the image w
When migrating with shared fs, the image labels has been remembered in
the src host. If the dst host trys to remember image labels again, then
the origin labels remembered in the src host will lost.
Signed-off-by: Peng Liang
---
src/security/security_dac.c | 32 +++--
Signed-off-by: Peng Liang
---
src/qemu/qemu_security.c | 10 ++
src/qemu/qemu_security.h | 5 +
2 files changed, 15 insertions(+)
diff --git a/src/qemu/qemu_security.c b/src/qemu/qemu_security.c
index 19d957dd4b96..d8f2049e0d46 100644
--- a/src/qemu/qemu_security.c
+++ b/src/qemu/qe
Libvirt will put the pid file of pr-helper to per-domain directory.
However, the ownership of the per-domain directory is the user to run
the QEMU process and the user has the write permission of the directory.
If VM escape occurs, the attacker can
1. write arbitrary content to the pid file (if run
Please see the commit messages for detail.
Peng Liang (2):
qemu: Move pid file of pr-helper to stateDir
qemu: Move pid file of virtiofsd to stateDir
src/qemu/qemu_process.c | 6 --
src/qemu/qemu_virtiofs.c | 8
2 files changed, 8 insertions(+), 6 deletions(-)
--
2.31.1
Libvirt will put the pid file of virtiofsd to per-domain directory.
However, the ownership of the per-domain directory is the user to run
the QEMU process and the user has the write permission of the directory.
If VM escape occurs, the attacker can
1. write arbitrary content to the pid file (if run
After a review from Jano I set out to fix also the test invocations to
use real capabilities. This has shown that there was a bug in the
validation logic which was pointed out by Jano in the output error file
change.
This version fixes the bug, improves testing and then removes the
useless capabil
The error that "acpi-bridge-hotplug" is not supported would be triggered
only if both the ICH9 and PIIX don't support the capability and the
machine is q35. This makes no sense.
We want to check that the appropriate platform supports the appropriate
feature.
Fixes: 7300ccc9b3e
Signed-off-by: Pete
https://www.libvirt.org/coding-style.html#error-message-format
Signed-off-by: Peter Krempa
---
src/qemu/qemu_validate.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index be609c9d39..e530368cb3 100644
--- a/src/qemu
We can use two real example configs to prove the support without the
need for using fake capabilities. Fix the recently added test cases.
Fixes: 133d7983d6c
Signed-off-by: Peter Krempa
---
...fx-acpi-root-hotplug-disable.x86_64-5.1.0.err} | 0
...-acpi-root-hotplug-disable.x86_64-latest.args} |
We can use real example configs to prove the support without the
need for using fake capabilities. Fix the recently added test cases.
The negative case for 'pc-i440fx-acpi-hotplug-bridge-disable' is removed
completely as there is no real qemu libvirt supports which wouldn't
have the capability.
F
Signed-off-by: Peter Krempa
---
...i-hotplug-bridge-disable.x86_64-latest.xml | 36 +
.../pc-i440fx-acpi-hotplug-bridge-disable.xml | 1 -
...pi-hotplug-bridge-enable.x86_64-latest.xml | 36 +
.../pc-i440fx-acpi-hotplug-bridge-enable.xml | 1 -
...cpi-root-hotplug-disab
Commit 58ba0f6a3d7342fba29edbbf2bb9cb5497c870e5 added a capability which
is supported by all qemu versions we support. Remove it and the
associated dead code. Since the capability isn't present in any upstream
release we can delete it completely.
Specifically the commit itself states that it was i
We have input files for those, provide also xml2argv testing since we
have them.
Signed-off-by: Peter Krempa
---
...i-hotplug-bridge-enable.x86_64-latest.args | 34 +
...-acpi-root-hotplug-enable.x86_64-5.1.0.err | 1 +
...cpi-root-hotplug-enable.x86_64-latest.args | 34
Add support for deserializing the binary PCI/PCIe VPD format and storing
results in memory.
The VPD format is specified in "I.3. VPD Definitions" in PCI specs
(2.2+) and "6.28.1 VPD Format" PCIe 4.0. As section 6.28 in PCIe 4.0
notes, the PCI Local Bus and PCIe VPD formats are binary compatible
an
Describes the format of the newly added VPD capability and gives and
example for a real-world device.
Signed-off-by: Dmitrii Shcherbakov
---
docs/drvnodedev.html.in | 69 +
docs/formatnode.html.in | 63 -
2 files changed
* XML serialization and deserialization of PCI VPD;
* PCI VPD capability flags added and used in relevant places;
* XML to XML tests for the added capability.
Signed-off-by: Dmitrii Shcherbakov
---
docs/schemas/nodedev.rng | 96 ++
include/libvirt/libvirt-nodedev.h
Signed-off-by: Dmitrii Shcherbakov
---
NEWS.rst | 22 ++
1 file changed, 22 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index ae678bffc4..7d4244e938 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -40,6 +40,28 @@ v7.9.0 (unreleased)
domain definition when the guest was first
Add helper functions to virpci to provide means of checking for a VPD
file presence and for VPD resource retrieval using the PCI VPD parser.
The added test assesses the basic functionality of VPD retrieval while
the full parser is tested by virpcivpdtest.
Signed-off-by: Dmitrii Shcherbakov
---
Add support for deserializing the binary PCI/PCIe VPD format and
exposing VPD resources as XML elements in a new nested capability
of PCI/PCIe devices called 'vpd'.
The series contains the following incremental changes:
* The PCI VPD parser module, in-memory resource representation
and tests;
*
On a Monday in 2021, Peter Krempa wrote:
We can use real example configs to prove the support without the
need for using fake capabilities. Fix the recently added test cases.
The negative case for 'pc-i440fx-acpi-hotplug-bridge-disable' is removed
completely as there is no real qemu libvirt supp
On a Monday in 2021, Peter Krempa wrote:
After a review from Jano I set out to fix also the test invocations to
use real capabilities. This has shown that there was a bug in the
validation logic which was pointed out by Jano in the output error file
change.
The cover letter mentions my name tw
On a Thursday in 2021, Peter Krempa wrote:
Introduce infrastructure to format 'drive' addresses via the standard
helper rather than hand-rolled generators used inline.
The code needs to know the disk bus to format the correct address which
is passed in via an internal field in virDomainDeviceDri
Kevin Wolf writes:
> ERRP_GUARD() makes debugging easier by making sure that &error_abort
> still fails at the real origin of the error instead of
> error_propagate().
>
> Signed-off-by: Kevin Wolf
Yes, please!
Reviewed-by: Markus Armbruster
On a Thursday in 2021, Peter Krempa wrote:
Move the code from 'qemuValidateDomainDeviceDefDiskFrontend' into
'qemuValidateDomainDeviceDefAddressDrive' which is called from
'qemuValidateDomainDeviceDefAddress' so that we have all address
validation code together.
This also allows us to remove the
On a Thursday in 2021, Peter Krempa wrote:
Since 'qemuBuildDeviceAddressProps' now also builds 'drive' addresses
the generator is way simpler and doesn't use any special fields.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 56 -
src/qemu/qemu_
On a Thursday in 2021, Peter Krempa wrote:
Simplify the generator by shuffling around few fields.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c| 10 +++---
.../hostdev-scsi-lsi.x86_64-4.1.0.args | 12 ++--
.../hostdev-scsi-lsi.x86_64-l
On a Thursday in 2021, Peter Krempa wrote:
The support for the 'ioeventfd' knob of virtio devices was introduced by
QEMU commit 25db9ebe15125 contained in v0.14.0-rc0 and it can't be
compiled out. Thus libvirt can assume it's support and remove
its support
it's supported
conditional code.
Si
On a Thursday in 2021, Peter Krempa wrote:
It's not used since last commit.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
[...]
38 files changed, 2 insertions(+), 39 deletions(-)
Review
On a Thursday in 2021, Peter Krempa wrote:
The 'event_idx' option for virtio devices was introduced by QEMU commit
bcbabae8f which is contained in v0.15.0-rc0 and can't be compiled out,
thus we don't need to conditionally enable it.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 6 ++
On a Thursday in 2021, Peter Krempa wrote:
Both are assumed as always present since last commit.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 6 ++
src/qemu/qemu_capabilities.h | 4 ++--
tests/qemucapabilitiesdata/caps_2.11.0.s390x
On a Thursday in 2021, Peter Krempa wrote:
Extract the logic to determine the actual settings into
'qemuBuildDiskGetErrorPolicy' so that it can be reused when we'll
convert the disk -device formatter to JSON.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 29 +++--
On a Thursday in 2021, Peter Krempa wrote:
The types for the special fields of the 'virtio-blk-pci' according to
QEMU are:
iothread=>
ioeventfd= - on/off (default: true)
event_idx= - on/off (default: true)
scsi=- on/off (default: false)
num-queues=- (default: 655
On a Thursday in 2021, Peter Krempa wrote:
virtio-net-pci specific properties and their types according to QEMU:
tx=
ioeventfd= - on/off (default: true)
event_idx= - on/off (default: true)
csum=- on/off (default: true)
gso= - on/off (default: true)
host_t
On a Thursday in 2021, Peter Krempa wrote:
Move the bootindex before the address so that the code is simpler.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 6 +-
tests/qemuxml2argvdata/aarch64-video-virtio-gpu-pci.args| 2 +-
tests/qemuxml2a
On a Thursday in 2021, Peter Krempa wrote:
Now that all users were converted to qemuBuildRomProps we can remove the
old code and un-mark qemuBuildRomProps as unused.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 34 +-
1 file changed, 1 insertion(+), 3
On a Thursday in 2021, Peter Krempa wrote:
Move the code into a new function called qemuBuildControllerSCSIDevStr
so that the code is self contained and the original function easier to
follow.
This patch also moves the formatting of the properties relevant only for
the 'virtio-scsi' controller t
On a Thursday in 2021, Peter Krempa wrote:
Move the code into a new function called qemuBuildControllerPCIDevStr
so that the code is self contained and the original function easier to
follow.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 157 ++--
On a Thursday in 2021, Peter Krempa wrote:
Internally format the SCSI controller properties into JSON, but convert
it back to a string so that we for now change just the SCSI controller.
The change in tests is expected as the 'reg' field for a spapr-vio
address is expected to be a number:
$ qe
On a Thursday in 2021, Peter Krempa wrote:
Internally format the PCI controller properties into JSON, but convert
it back to a string so that we for now change just the SCSI controller.
The change in tests is expected as the 'port' field for various PCI
controllers is expected to be a number and
On a Thursday in 2021, Peter Krempa wrote:
Move the validation code into a separate function. For now the
validation is still kept in the commandline format step as simply just
moving it to the validator causes failures in the test suite, which will
need to be investigated deeper.
Signed-off-by:
On a Thursday in 2021, Peter Krempa wrote:
Internally format the PCI controller properties into JSON, but convert
it back to a string as preparation for upcoming refactors.
The following types are declared for the properties we use by QEMU:
'nec-usb-xhci'
p2=- (default: 4)
p3=
On a Thursday in 2021, Peter Krempa wrote:
The handlers for PCI, SCSI and USB controllers already use JSON
internally. This patch converts 'virtio-serial', 'ccid' and 'sata' to do
the same and passes out the JSON directly so that it can be used in
monitor code to avoid conversion.
From the cont
On a Thursday in 2021, Peter Krempa wrote:
Build commandlines for character devices via JSON.
For devices using 'VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_SERIAL' address
type 'qemuBuildDeviceAddressProps' will now generate the address. The
only special property is 'nr'. QEMU declares it as:
nr=
On a Thursday in 2021, Peter Krempa wrote:
Build the properties of 'vhost-scsi' device via JSON. In comparison to
previous similar refactors this also modifies the hotplug code to attach
the vhost fd handle explicitly rather than using
'qemuMonitorAddDeviceWithFd'.
The 'vhost-scsi' device doesn'
On a Thursday in 2021, Peter Krempa wrote:
Build the properties of 'vhost-vsock' device via JSON. In comparison to
previous similar refactors this also modifies the hotplug code to attach
the vhost fd handle explicitly rather than using
'qemuMonitorAddDeviceWithFd'.
The properties of vhost-vsock
On a Thursday in 2021, Peter Krempa wrote:
Remove the old-style 'device_add' helpers which parse the commandline
arguments to JSON since we now coverted all usage to use JSON directly.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 34
src/qemu/qemu_monitor.h | 7
On a Thursday in 2021, Peter Krempa wrote:
The 'vhost-user-fs-pci' has following properties we control:
chardev= - ID of a chardev to use as a backend
queue-size=- (default: 128)
tag=
bootindex=
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 43 -
On a Thursday in 2021, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 37 -
1 file changed, 20 insertions(+), 17 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Thursday in 2021, Peter Krempa wrote:
We control the following properties of the devices in question:
'virtio-gpu'
virgl= - on/off (default: true)
'qxl'
ram_size= - (default: 67108864)
vram_size= - (default: 67108864)
vram64_size_mb= - (default: 4294967295)
vgame
On a Thursday in 2021, Peter Krempa wrote:
The sound devices have only the 'audiodev' property which is a string.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 40 +++-
1 file changed, 23 insertions(+), 17 deletions(-)
diff --git a/src/qemu/qemu_c
On a Thursday in 2021, Peter Krempa wrote:
The codec devices have the following properties we control:
cad= - (default: 4294967295)
audiodev= - ID of an audiodev to use as a backend
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 64 ++-
On a Thursday in 2021, Peter Krempa wrote:
All virtio devices were converted to the new JSON formatter so we can
remove the old one.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 65 +
1 file changed, 1 insertion(+), 64 deletions(-)
Reviewed
On a Thursday in 2021, Peter Krempa wrote:
The 'usb-hub' device doesn't have any special properties.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 33 ++---
1 file changed, 18 insertions(+), 15 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
On a Thursday in 2021, Peter Krempa wrote:
We control only the 'tpmdev' property of TPM devices which is a string.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 32 +++
.../ppc64-tpmproxy-with-tpm.ppc64-latest.args | 2 +-
.../tpm-emulator-spapr.
On a Thursday in 2021, Peter Krempa wrote:
All users were converted to the JSON counterpart.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 99 +
1 file changed, 1 insertion(+), 98 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
De
On a Monday in 2021, Ján Tomko wrote:
On a Thursday in 2021, Peter Krempa wrote:
We control only the 'tpmdev' property of TPM devices which is a string.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 32 +++
.../ppc64-tpmproxy-with-tpm.ppc64-late
On Mon, Oct 11, 2021 at 04:51:40PM +0200, Ján Tomko wrote:
> On a Monday in 2021, Peter Krempa wrote:
> > +++
> > b/tests/qemuxml2argvdata/aarch64-acpi-hotplug-bridge-disable.aarch64-latest.err
> > @@ -0,0 +1 @@
> > +XML error: The PCI controller with index='0' must be model='pcie-root' for
> > t
On Sat, Oct 09, 2021 at 02:09:40PM +0200, Markus Armbruster wrote:
> The next commit will add feature flags to enum members. There's a
> problem, though: query-qmp-schema shows an enum type's members as an
> array of member names (SchemaInfoEnum member @values). If it showed
> an array of objects
On Sat, Oct 09, 2021 at 02:09:43PM +0200, Markus Armbruster wrote:
> This copies the code implementing the policy from qapi/qmp-dispatch.c
> to qapi/qobject-input-visitor.c. Tolerable, but if we acquire more
> copes, we should look into factoring them out.
copies
>
> Signed-off-by: Markus Armbr
On Sat, Oct 09, 2021 at 02:09:44PM +0200, Markus Armbruster wrote:
> Several moons ago, Vladimir posted
>
> Subject: [PATCH v2 3/3] qapi: deprecate drive-backup
> Date: Wed, 5 May 2021 16:58:03 +0300
> Message-Id: <20210505135803.67896-4-vsement...@virtuozzo.com>
> https://lists.g
Am Mon, 11 Oct 2021 13:25:20 -0600
schrieb Jim Fehlig :
> >> I think it is wrong to use internal libvirt values for internal
> >> libxentoollog values.
> What is gained over the sparse mapping? Are values not covered actually
> useful
> in practice? Also, how are the values specified when usi
On Fri, Oct 08, 2021 at 03:34:36PM +0200, Kevin Wolf wrote:
> From: Damien Hedde
>
> qdev_set_id() is mostly used when the user adds a device (using
> -device cli option or device_add qmp command). This commit adds
> an error parameter to handle the case where the given id is
> already taken.
>
Some people from Red Hat does not use 'redhat.com' domain emails.
They use personal or other domains.
Signed-off-by: Julio Faracco
---
docs/gitdm/companies/ibm| 1 -
docs/gitdm/companies/redhat | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/gitdm/companies/ibm b/doc
On 10/11/21 04:30, Olaf Hering wrote:
This question is still open:
where should the libxl specific setting be specified?
Sorry for not responding to your earlier mail.
Am Sun, 25 Jul 2021 10:17:49 +0200
schrieb Olaf Hering :
I think it is wrong to use internal libvirt values for internal l
On 10/11/21 14:38, Olaf Hering wrote:
Am Mon, 11 Oct 2021 13:25:20 -0600
schrieb Jim Fehlig :
I think it is wrong to use internal libvirt values for internal libxentoollog
values.
What is gained over the sparse mapping? Are values not covered actually useful
in practice? Also, how are the val
88 matches
Mail list logo
