[PATCH] qemu: tpm: Enable creation of certs for TPM 1.2 in non-privileged mode

When 'swtpm_setup --print-capabilities' shows the 'tpm12-not-need-root' flag, then it is possible to create certificates for the TPM 1.2 also in non-privileged mode since swtpm_setup doesn't need tcsd anymore. Check for this flag and create the certificates if this flag is found. Signed-off-by:

Re: [PATCH] qemu: Extend qemu.conf with PCR banks to activate during 'TPM manufacturing'

On 10/28/21 14:16, Daniel P. Berrangé wrote: On Thu, Oct 28, 2021 at 01:51:33PM -0400, Stefan Berger wrote: On the libvirt side, I think we could have a domain XML config option for PCR banks, to allow the built-in default or admin local default to be override per-VM. Is there an example of

[libvirt PATCH v2 0/3] PCI VPD: Handle More Edge Cases

This patch set improves edge case testing: * The parser is now more strict about checking boundary conditions when parsing fields: an invalid field length is a possibility which is now being accounted for; * The parser will now make sure that RV and RW fields are the last in their

[libvirt PATCH v2 2/3] PCI VPD: Skip fields with invalid values

While invalid values need to be ignored when presenting VPD data to the user, it would be good to attempt to parse a valid portion of the VPD instead of marking it invalid as a whole. Based on a mailing list discussion, the set of accepted characters is extended to the set of printable ASCII

[libvirt PATCH v2 3/3] PCI VPD: Fix a wrong return code in a test case

The test case should return -1, not 0 in case a valid resource could not be parsed successfully but the ret value is initialized to 0. Signed-off-by: Dmitrii Shcherbakov --- tests/virpcivpdtest.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/virpcivpdtest.c

[libvirt PATCH v2 1/3] PCI VPD: handle additional edge cases

* RV and RW fields must be at the last position in their respective section (per the conditions in the spec). Therefore, the parser now stops iterating over fields as soon as it encounters one of those fields and checks whether the end of the resource has been reached; * The lack of the RW

Re: [PATCH v2 8/9] qapi: Factor out compat_policy_input_ok()

On 10/29/21 18:55, Markus Armbruster wrote: > Markus Armbruster writes: > >> The code to check policy for handling deprecated input is triplicated. >> Factor it out into compat_policy_input_ok() before I mess with it in >> the next commit. >> >> Signed-off-by: Markus Armbruster >> Reviewed-by:

Re: [PATCH v2 8/9] qapi: Factor out compat_policy_input_ok()

Markus Armbruster writes: > The code to check policy for handling deprecated input is triplicated. > Factor it out into compat_policy_input_ok() before I mess with it in > the next commit. > > Signed-off-by: Markus Armbruster > Reviewed-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH v2 5/9] qapi: Generalize struct member policy checking

On 10/29/21 17:34, Markus Armbruster wrote: > Eric Blake writes: > >> On Thu, Oct 28, 2021 at 12:25:16PM +0200, Markus Armbruster wrote: >>> The generated visitor functions call visit_deprecated_accept() and >>> visit_deprecated() when visiting a struct member with special feature >>> flag

Re: [PATCH v2 5/9] qapi: Generalize struct member policy checking

On 10/29/21 16:01, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 10/28/21 12:25, Markus Armbruster wrote: >>> The generated visitor functions call visit_deprecated_accept() and >>> visit_deprecated() when visiting a struct member with special feature >>> flag 'deprecated'.

Re: [PATCH v2 6/9] qapi: Generalize command policy checking

On 10/29/21 17:28, Eric Blake wrote: > On Thu, Oct 28, 2021 at 12:25:17PM +0200, Markus Armbruster wrote: >> The code to check command policy can see special feature flag >> 'deprecated' as command flag QCO_DEPRECATED. I want to make feature >> flag 'unstable' visible there as well, so I can add

Re: [PATCH v2 5/9] qapi: Generalize struct member policy checking

Eric Blake writes: > On Thu, Oct 28, 2021 at 12:25:16PM +0200, Markus Armbruster wrote: >> The generated visitor functions call visit_deprecated_accept() and >> visit_deprecated() when visiting a struct member with special feature >> flag 'deprecated'. This makes the feature flag visible to the

Re: [PATCH v2 6/9] qapi: Generalize command policy checking

On Thu, Oct 28, 2021 at 12:25:17PM +0200, Markus Armbruster wrote: > The code to check command policy can see special feature flag > 'deprecated' as command flag QCO_DEPRECATED. I want to make feature > flag 'unstable' visible there as well, so I can add policy for it. > > To let me make it

Re: [PATCH v2 5/9] qapi: Generalize struct member policy checking

On Thu, Oct 28, 2021 at 12:25:16PM +0200, Markus Armbruster wrote: > The generated visitor functions call visit_deprecated_accept() and > visit_deprecated() when visiting a struct member with special feature > flag 'deprecated'. This makes the feature flag visible to the actual > visitors. I

Re: [PATCH v2 9/9] qapi: Extend -compat to set policy for unstable interfaces

Eric Blake writes: > On Thu, Oct 28, 2021 at 12:25:20PM +0200, Markus Armbruster wrote: >> New option parameters unstable-input and unstable-output set policy >> for unstable interfaces just like deprecated-input and >> deprecated-output set policy for deprecated interfaces (see commit >>

Re: [PATCH v2 9/9] qapi: Extend -compat to set policy for unstable interfaces

On Thu, Oct 28, 2021 at 12:25:20PM +0200, Markus Armbruster wrote: > New option parameters unstable-input and unstable-output set policy > for unstable interfaces just like deprecated-input and > deprecated-output set policy for deprecated interfaces (see commit > 6dd75472d5 "qemu-options: New

Re: [PATCH 8/9] qapi: Factor out compat_policy_input_ok()

Philippe Mathieu-Daudé writes: > On 10/26/21 11:46, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 10/25/21 07:25, Markus Armbruster wrote: The code to check policy for handling deprecated input is triplicated. Factor it out into compat_policy_input_ok() before

Re: [PATCH v2 5/9] qapi: Generalize struct member policy checking

Philippe Mathieu-Daudé writes: > On 10/28/21 12:25, Markus Armbruster wrote: >> The generated visitor functions call visit_deprecated_accept() and >> visit_deprecated() when visiting a struct member with special feature >> flag 'deprecated'. This makes the feature flag visible to the actual >>

Re: [PATCH 0/7] qemu: Various monitor cleanups and removal of legacy cpu hotplug

On a Friday in 2021, Peter Krempa wrote: Peter Krempa (7): qemuMonitorJSONQueryBlock: Reformat function header qemuMonitorJSONBlockInfoAdd: Refactor hash table addition qemuhotplugtest: Remove tests for legacy cpu hotplug on x86 qemuDomainHotplugAddVcpu: Remove legacy hotplug branch qemu:

Re: [PATCH 4/7] qemuDomainHotplugAddVcpu: Remove legacy hotplug branch

On a Friday in 2021, Peter Krempa wrote: Report an error if the new hotplug is not supported and remove the alternate code paths. The modern cpu-hotplug code was introduced in qemu-2.7. We keep the capability so that proper errors are reported in case a platform doesn't support hotplug.

Re: [PATCH v2 5/9] qapi: Generalize struct member policy checking

On 10/28/21 12:25, Markus Armbruster wrote: > The generated visitor functions call visit_deprecated_accept() and > visit_deprecated() when visiting a struct member with special feature > flag 'deprecated'. This makes the feature flag visible to the actual > visitors. I want to make feature flag

Re: [PATCH v2 5/9] qapi: Generalize struct member policy checking

Juan Quintela writes: > Markus Armbruster wrote: >> The generated visitor functions call visit_deprecated_accept() and >> visit_deprecated() when visiting a struct member with special feature >> flag 'deprecated'. This makes the feature flag visible to the actual >> visitors. I want to make

[PATCH 2/7] qemuMonitorJSONBlockInfoAdd: Refactor hash table addition

Open code virHashAddEntry so that the error code path can be avoided. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index

[PATCH 7/7] qemuMonitorJSONSave[Physical|Virtual]Memory: Reformat function headers

Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 2ba8da454b..7d21e23800 100644 --- a/src/qemu/qemu_monitor_json.c +++

[PATCH 6/7] qemuMonitorEjectMedia: Remove stale comment

The QMP implementation didn't use any new approach. The command itself is now only used with legacy qemu versions. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.h | 4 1 file changed, 4 deletions(-) diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index

[PATCH 5/7] qemu: monitor: Remove unused qemuMonitorSetCPU

Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.c | 14 -- src/qemu/qemu_monitor.h | 2 -- src/qemu/qemu_monitor_json.c | 25 - src/qemu/qemu_monitor_json.h | 1 - tests/qemumonitorjsontest.c | 2 -- 5 files changed, 44 deletions(-) diff

[PATCH 3/7] qemuhotplugtest: Remove tests for legacy cpu hotplug on x86

Modern cpu hotplug was introduced in qemu-2.7, thus all qemu versions actually support it. Remove the tests for the legacy hotplug. Signed-off-by: Peter Krempa --- tests/qemuhotplugtest.c | 1 - .../x86-old-bulk-domain.xml | 21 --

[PATCH 4/7] qemuDomainHotplugAddVcpu: Remove legacy hotplug branch

Report an error if the new hotplug is not supported and remove the alternate code paths. The modern cpu-hotplug code was introduced in qemu-2.7. We keep the capability so that proper errors are reported in case a platform doesn't support hotplug. Signed-off-by: Peter Krempa ---

[PATCH 1/7] qemuMonitorJSONQueryBlock: Reformat function header

Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index e9be9bdabd..19af6219aa 100644 --- a/src/qemu/qemu_monitor_json.c +++

Re: [PATCH for 7.9.0] NEWS: Document my bugfixes for v7.9.0

On Fri, Oct 29, 2021 at 15:02:44 +0200, Michal Privoznik wrote: > There are two bugs I fixed worth mentioning in the 7.9.0 release > notes. > > Signed-off-by: Michal Privoznik > --- > NEWS.rst | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/NEWS.rst b/NEWS.rst > index

[PATCH 0/7] qemu: Various monitor cleanups and removal of legacy cpu hotplug

Peter Krempa (7): qemuMonitorJSONQueryBlock: Reformat function header qemuMonitorJSONBlockInfoAdd: Refactor hash table addition qemuhotplugtest: Remove tests for legacy cpu hotplug on x86 qemuDomainHotplugAddVcpu: Remove legacy hotplug branch qemu: monitor: Remove unused

Re: [PATCH 2/9] qapi: Mark unstable QMP parts with feature 'unstable'

On Mon, Oct 25, 2021 at 07:25:25AM +0200, Markus Armbruster wrote: > Add special feature 'unstable' everywhere the name starts with 'x-', > except for InputBarrierProperties member x-origin and > MemoryBackendProperties member x-use-canonical-path-for-ramblock-id, > because these two are actually

[PATCH for 7.9.0] NEWS: Document my bugfixes for v7.9.0

There are two bugs I fixed worth mentioning in the 7.9.0 release notes. Signed-off-by: Michal Privoznik --- NEWS.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 1d2d31430f..1bb6897abd 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -86,6 +86,21 @@

Re: [libvirt PATCH] spec: Depend on qemu-kvm-block-driver-curl in RHEL-9

On Fri, Oct 29, 2021 at 02:53:09PM +0200, Jiri Denemark wrote: > On Wed, Oct 27, 2021 at 15:38:22 +0100, Daniel P. Berrangé wrote: > > On Wed, Oct 27, 2021 at 03:58:29PM +0200, Jiri Denemark wrote: > > > The curl block driver is no longer a requirement for qemu-kvm package in > > > RHEL-9, which

Re: [PATCH 0/4] Some news and docs update for v7.9.0

On 10/28/21 9:07 AM, Han Han wrote: > > Han Han (4): > docs: Fix a typo of page_per_vq > news: News for the new virtio attribute page_per_vq > docs: Make the version requirement more clear for rbd encryption > news: Add support for librbd encryption > > NEWS.rst

Re: [libvirt PATCH] spec: Depend on qemu-kvm-block-driver-curl in RHEL-9

On Wed, Oct 27, 2021 at 15:38:22 +0100, Daniel P. Berrangé wrote: > On Wed, Oct 27, 2021 at 03:58:29PM +0200, Jiri Denemark wrote: > > The curl block driver is no longer a requirement for qemu-kvm package in > > RHEL-9, which breaks support for https network disks. Let's depend on it > >

[PATCH v2 8/8] testQEMUSchemaValidateEnum: Validate deprecated members

Starting from QEMU-6.2 enum members can be deprecated. Add support to the validator. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- tests/testutilsqemuschema.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/testutilsqemuschema.c b/tests/testutilsqemuschema.c

[PATCH v2 7/8] testQEMUSchemaValidateDeprecated: Move to the top

Move the function to the top of the file so other functions placed towards the top will be able to reuse it. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- tests/testutilsqemuschema.c | 82 ++--- 1 file changed, 41 insertions(+), 41 deletions(-)

[PATCH v2 5/8] testQEMUSchemaValidateEnum: Refactor logic to simplify switching to new QMP schema format

QEMU-6.2 is reporting enum values in the new 'members' array which we'll be switching to. Rewrite the logic so that adding the new checker is more straightforward. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- tests/testutilsqemuschema.c | 29 ++--- 1

[PATCH v2 6/8] testQEMUSchemaValidateEnum: Use new 'members' for 'enum' meta type

Switch to the new more featured way to report enum members which will also allow us to detect use of deprecated members. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- tests/testutilsqemuschema.c | 17 + 1 file changed, 17 insertions(+) diff --git

[PATCH v2 2/8] virQEMUQAPISchemaTraverseEnum: Move helper variables into loop

Move them closer to where they are actually used. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- src/qemu/qemu_qapi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_qapi.c b/src/qemu/qemu_qapi.c index 36b184b226..165ecf1180 100644 ---

[PATCH v2 4/8] virQEMUQAPISchemaTraverseEnum: Allow query of enume type features

QEMU-6.2 added feature flags for enum types. Add support for querying them into our QMP schema query language. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- src/qemu/qemu_qapi.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git

[PATCH v2 3/8] virQEMUQAPISchemaTraverseEnum: Use the modern 'members' array

Starting from QEMU-6.2 enum members are reported as an array of objects under new name "values" so that extra data can be reported for each member. Modify the code so that we prefer 'members' and skip 'values' completely if we've used 'members'. Signed-off-by: Peter Krempa Reviewed-by: Michal

[PATCH v2 1/8] qemucapabilitiestest: Update capability probe for qemu-6.2 on x86_64

Update to v6.1.0-1735-gc52d69e7db which has Markus' patches for improvements of enum probing. Signed-off-by: Peter Krempa --- .../caps_6.2.0.x86_64.replies | 3513 +++-- .../caps_6.2.0.x86_64.xml |2 +- 2 files changed, 3097 insertions(+), 418

[PATCH v2 0/8] qemu: QAPI-schema: Add support for enum value 'features'

Patches 2-8 were already reviewed by Michal. 1/8 is new as the qemu functionality was just merged upstream. Peter Krempa (8): qemucapabilitiestest: Update capability probe for qemu-6.2 on x86_64 virQEMUQAPISchemaTraverseEnum: Move helper variables into loop virQEMUQAPISchemaTraverseEnum:

[PATCH] ch_driver: Drop needless fwd declaration

In ch_driver.c there are two forward declarations that are not needed. Drop them. Signed-off-by: Michal Privoznik --- src/ch/ch_driver.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index 1824d2fd16..9eaf3ee499 100644 --- a/src/ch/ch_driver.c

Re: [libvirt PATCH 08/13] ch_cgroup: methods for cgroup mgmt in ch driver

On 10/22/21 5:37 PM, Praveen K Paladugu wrote: > From: Vineeth Pillai > > Signed-off-by: Vineeth Pillai > Signed-off-by: Praveen K Paladugu > --- > po/POTFILES.in | 1 + > src/ch/ch_cgroup.c | 457 > src/ch/ch_cgroup.h | 45 + >

Re: [libvirt PATCH 07/13] ch_monitor: Get nicindexes in prep for cgroup mgmt

On 10/22/21 5:37 PM, Praveen K Paladugu wrote: > From: Vineeth Pillai > > Signed-off-by: Vineeth Pillai > Signed-off-by: Praveen Paladugu > Signed-off-by: Praveen K Paladugu > --- > src/ch/ch_conf.h| 5 +++ > src/ch/ch_domain.c | 26 +- > src/ch/ch_domain.h | 4 +-- >

Re: [libvirt PATCH 02/13] ch: Explicitly link to virt_util_lib

On 10/22/21 5:37 PM, Praveen K Paladugu wrote: > From: Vineeth Pillai > > link to virt_util_lib while building ch driver. > > Signed-off-by: Vineeth Pillai > Signed-off-by: Praveen K Paladugu > --- > src/ch/meson.build | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

Re: [libvirt PATCH 07/13] ch_monitor: Get nicindexes in prep for cgroup mgmt

On 10/22/21 5:37 PM, Praveen K Paladugu wrote: > From: Vineeth Pillai > > Signed-off-by: Vineeth Pillai > Signed-off-by: Praveen Paladugu > Signed-off-by: Praveen K Paladugu > --- > src/ch/ch_conf.h| 5 +++ > src/ch/ch_domain.c | 26 +- > src/ch/ch_domain.h | 4 +-- >

Re: [libvirt PATCH 05/13] ch_driver, ch_domain: vcpu info getter callbacks

On 10/22/21 5:37 PM, Praveen K Paladugu wrote: > From: Vineeth Pillai > > Signed-off-by: Vineeth Pillai > Signed-off-by: Praveen K Paladugu > --- > src/ch/ch_domain.c | 25 > src/ch/ch_domain.h | 4 ++ > src/ch/ch_driver.c | 138 + > 3

Re: [libvirt PATCH 00/13] cgroup and thread management in ch driver.

On 10/22/21 5:37 PM, Praveen K Paladugu wrote: > This patchset adds support for cgroup management of ch threads. This version > correctly manages cgroups for vcpu and emulator threads created by ch. cgroup > management for iothreads is not yet supported. > > Along with cgroup management, this

Re: [libvirt PATCH 01/13] util: Helper functions to get process info

On 10/22/21 5:37 PM, Praveen K Paladugu wrote: > From: Vineeth Pillai > > These helper methods are used to capture vcpu information > in ch driver. > > Signed-off-by: Vineeth Pillai > Signed-off-by: Praveen K Paladugu > --- > src/util/virprocess.c | 136

Re: [libvirt PATCH 09/13] ch_driver, ch_domain: vcpupin callback in ch driver

On 10/22/21 5:37 PM, Praveen K Paladugu wrote: > From: Vineeth Pillai > > Signed-off-by: Vineeth Pillai > Signed-off-by: Praveen K Paladugu > --- > src/ch/ch_domain.c | 30 + > src/ch/ch_domain.h | 1 + > src/ch/ch_driver.c | 151 + > 3

Re: [PATCH v2 4/9] qapi: Tools for sets of special feature flags in generated code

On 10/28/21 12:25, Markus Armbruster wrote: > New enum QapiSpecialFeature enumerates the special feature flags. > > New helper gen_special_features() returns code to represent a > collection of special feature flags as a bitset. > > The next few commits will put them to use. > > Signed-off-by:

Re: [PATCH v2 7/9] qapi: Generalize enum member policy checking

On 10/28/21 12:25, Markus Armbruster wrote: > The code to check enumeration value policy can see special feature > flag 'deprecated' in QEnumLookup member flags[value]. I want to make > feature flag 'unstable' visible there as well, so I can add policy for > it. > > Instead of extending flags[],

Re: [PATCH v2 6/9] qapi: Generalize command policy checking

Markus Armbruster wrote: > The code to check command policy can see special feature flag > 'deprecated' as command flag QCO_DEPRECATED. I want to make feature > flag 'unstable' visible there as well, so I can add policy for it. > > To let me make it visible, add member @special_features (a

Re: [PATCH v2 5/9] qapi: Generalize struct member policy checking

Markus Armbruster wrote: > The generated visitor functions call visit_deprecated_accept() and > visit_deprecated() when visiting a struct member with special feature > flag 'deprecated'. This makes the feature flag visible to the actual > visitors. I want to make feature flag 'unstable' visible

Re: [PATCH v2 4/9] qapi: Tools for sets of special feature flags in generated code

Markus Armbruster wrote: > New enum QapiSpecialFeature enumerates the special feature flags. > > New helper gen_special_features() returns code to represent a > collection of special feature flags as a bitset. > > The next few commits will put them to use. > > Signed-off-by: Markus Armbruster >

libvirt-7.9.0 release candidate 2

I have just tagged v7.9.0-rc2 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make

答复: [PATCH v3 0/4] Add qemu support setting qos via ovs on ovs interface

Hi Yalan, You are right about it. For other interface type, values in tc rules are calculated by multiply 8*1000 instead of 8*1024. I didn’t notice it. To make them uniform, I will fix it in next patch. Really thanks for your help. Best Regards, Jinsheng Zhang 发件人: Yalan Zhang

Re: [PATCH v3 0/4] Add qemu support setting qos via ovs on ovs interface

Hi Jinsheng, I asked as I have mixed the "K" as 1000. Thank you for the explanation, I'm clear now. And I found the "inbound.peak : *200" *was calculated to "ceil 1638Kbit", maybe 1600Kbit is more reasonable? as I found for other interface type like nat, it was 1600Kbit from tc output. Please

Re: [PATCH 1/3] docs: Mention QEMU version requirement for queue-size

On Fri, Oct 29, 2021 at 14:19:21 +0800, Han Han wrote: > Signed-off-by: Han Han > --- > docs/formatdomain.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst > index 58768f7e5e..dbda54dc93 100644 > ---

[PATCH 3/4] qemu_agent: Drop destroy callback

After previous cleanups this callback is unused. Remove it. Signed-off-by: Michal Privoznik --- src/qemu/qemu_agent.h | 2 -- src/qemu/qemu_process.c | 9 - 2 files changed, 11 deletions(-) diff --git a/src/qemu/qemu_agent.h b/src/qemu/qemu_agent.h index 81b45b8e5d..b5954e76e7 100644

[PATCH 4/4] qemuMonitorOpen: Rework domain object refcounting

Similarly to one of previous commits, there's no need to increment domain object refcounter before unlocking it. Any number of lock and unlock calls over domain object has no effect on the refcounter. Signed-off-by: Michal Privoznik --- src/qemu/qemu_monitor.c | 5 - 1 file changed, 5

[PATCH 2/4] qemuAgentOpen: Rework domain object refcounting

Currently, when opening an agent socket the qemuConnectAgent() increments domain object refcounter and calls qemuAgentOpen() where the domain object pointer is simply stored inside _qemuAgent struct. If qemuAgentOpen() fails, then it clears @cb member only to avoid qemuProcessHandleAgentDestroy()

[PATCH 1/4] qemu_agent: Rework domain object locking when opening agent

Just like qemuMonitorOpen(), hold the domain object locked throughout the whole time of qemuConnectAgent() and unlock it only for a brief time of actual connect() (because this is the only part that has a potential of blocking). The reason is that qemuAgentOpen() does access domain object (well,

[PATCH 0/4] qemu_agent: Rework domain object handling in open

The most important patch is the first one because it fixes a race condition. The rest is just a cleanup I've noticed while looking at the code. Michal Prívozník (4): qemu_agent: Rework domain object locking when opening agent qemuAgentOpen: Rework domain object refcounting qemu_agent: Drop

[PATCH] news: Support vhostuser in virsh attach-interface since v7.7.0

Signed-off-by: Han Han --- NEWS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 5f1cf19940..694c506cad 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -162,6 +162,8 @@ v7.7.0 (2021-09-01) forbidden for older qemus which don't support the update API as the guest

[PATCH 3/3] news: Add validation flags for creating of net, nwfilter-binding, net port

Signed-off-by: Han Han --- NEWS.rst | 12 1 file changed, 12 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index cb1234e891..7815f1100f 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -96,6 +96,18 @@ v7.8.0 (2021-10-01) Implement the queue-size from QEMU to adjust the virtio disk

[PATCH 2/3] news: Add queue_size option to virtio disk

Signed-off-by: Han Han --- NEWS.rst | 4 1 file changed, 4 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 5f1cf19940..cb1234e891 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -92,6 +92,10 @@ v7.8.0 (2021-10-01) active. This information can also be retrieved with the new virsh command

[PATCH 1/3] docs: Mention QEMU version requirement for queue-size

Signed-off-by: Han Han --- docs/formatdomain.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 58768f7e5e..dbda54dc93 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -3086,7 +3086,7 @@ paravirtualized

[PATCH 0/3] Docs and news update for v7.8.0

Han Han (3): docs: Mention QEMU version requirement for queue-size news: Add queue_size option to virtio disk news: Add validation flags for creating of net, nwfilter-binding, net port NEWS.rst | 16 docs/formatdomain.rst | 2 +- 2 files changed, 17

Re: [PATCH v3 0/4] Add qemu support setting qos via ovs on ovs interface

Hi Jinsheng, Get it. Thank you for the explanation! --- Best Regards, Yalan Zhang IRC: yalzhang On Thu, Oct 28, 2021 at 4:20 PM Jinsheng Zhang (张金生)-云服务集团 < zhangj...@inspur.com> wrote: > Hi Yalan, > > It seems that there is no output error abount inbound settings from your > statistics.