Re: [PATCH v3 0/3] qapi & doc: deprecate drive-backup

2021-11-03 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Hi all! > > See 03 commit message for details. 01-02 are preparation docs update. > > v3: wording fix-ups and improvements suggested by Kashyap > v2: add a lot of documentation changes > v1 was "[PATCH] qapi: deprecate drive-backup" > > > Note, that this

Re: [PATCH v4 5/5] block: Deprecate transaction type drive-backup

2021-11-03 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 25.10.2021 07:24, Markus Armbruster wrote: >> Several moons ago, Vladimir posted >> >> Subject: [PATCH v2 3/3] qapi: deprecate drive-backup >> Date: Wed, 5 May 2021 16:58:03 +0300 >>

[libvirt PATCH] docs: fix documentation for nodedev-start

2021-11-03 Thread Jonathon Jongsma
Presumably the result of a copy/paste mistake, the the argument for the `nodedev-start` command was described as a 'network' rather than a 'device'. Signed-off-by: Jonathon Jongsma --- pushed as trivial docs/manpages/virsh.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3 0/2] qemu: tpm: Activate PCR banks of a TPM 2.0 before VM start

2021-11-03 Thread Stefan Berger
This series of patches adds support for activating the PCR banks of a TPM 2.0 before starting a VM. Stefan Stefan Berger (2): qemu: Move code to add encryption options for swtpm_setup into function qemu: tpm: Extend TPM domain XML with PCR banks to activate docs/formatdomain.rst

[PATCH v3 2/2] qemu: tpm: Extend TPM domain XML with PCR banks to activate

2021-11-03 Thread Stefan Berger
Extend the TPM backend XML with a node 'active_pcr_banks' that allows a user to specify the PCR banks to activate before starting a VM. Valid choices for PCR banks are sha1, sha256, sha384 and sha512. When the XML node is provided, the set of active PCR banks is 'enforced' by running swtpm_setup

[PATCH v3 1/2] qemu: Move code to add encryption options for swtpm_setup into function

2021-11-03 Thread Stefan Berger
Move the code that adds encryption options for the swtpm_setup command line into its own function. Signed-off-by: Stefan Berger --- src/qemu/qemu_tpm.c | 54 +++-- 1 file changed, 37 insertions(+), 17 deletions(-) diff --git a/src/qemu/qemu_tpm.c

Re: [PATCH 0/4] qemu: Report stats for backing images

2021-11-03 Thread Ján Tomko
On a Monday in 2021, Peter Krempa wrote: Management tools such as oVirt need to monitor the 'allocation' of the backup job scratch file or disk copy target. Add the stats to the bulk stats. The stats can be queried by: $ virsh domstats $VM --block --backing Patch 1 fixes a bug in the status

[PATCH] meson: Fix rst2html5 detection

2021-11-03 Thread Andrea Bolognani
The first part of the version string contains the name that the rst2html5 command was invoked as, which can differ based on the operating system: on FreeBSD, for example, it's rst2html5.py instead of just rst2html5. Fix our detection logic so that it works regardless of the specific name used for

[libvirt PATCH 1/3] remote: warn on low SSF

2021-11-03 Thread Ján Tomko
Prepare for deprecating old kerberos ciphers by warning users with a SSF lower than 112. Signed-off-by: Ján Tomko --- src/remote/remote_driver.c | 5 + src/remote/remote_driver.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c

[libvirt PATCH 0/3] daemon: allow setting minimum SSF level

2021-11-03 Thread Ján Tomko
https://bugzilla.redhat.com/show_bug.cgi?id=1431589 Ján Tomko (3): remote: warn on low SSF daemon: virNetSASLContext: store tcpMinSSF daemon: add tcp_min_ssf option src/libvirt_sasl.syms | 1 + src/remote/libvirtd.aug.in | 1 + src/remote/libvirtd.conf.in

[libvirt PATCH 2/3] daemon: virNetSASLContext: store tcpMinSSF

2021-11-03 Thread Ján Tomko
Store the minimum SSF value for TCP connections in virNetSASLContext and introduce a getter for it. Signed-off-by: Ján Tomko --- src/libvirt_sasl.syms | 1 + src/remote/remote_daemon.c | 3 ++- src/remote/remote_daemon_dispatch.c | 2 +- src/rpc/virnetsaslcontext.c

[libvirt PATCH 3/3] daemon: add tcp_min_ssf option

2021-11-03 Thread Ján Tomko
Add an option to allow the admin to requet a higher minimum SSF for connections than the built-in default. The current default is 56 (single DES equivalent, to support old kerberos) and will be raised to 112 in the future. https://bugzilla.redhat.com/show_bug.cgi?id=1431589 Signed-off-by: Ján

Re: [PATCH v2 2/2] qemu: tpm: Extend TPM domain XML with PCR banks to activate

2021-11-03 Thread Daniel P . Berrangé
On Wed, Nov 03, 2021 at 09:07:11AM -0400, Stefan Berger wrote: > > On 11/2/21 05:57, Daniel P. Berrangé wrote: > > On Tue, Nov 02, 2021 at 10:38:05AM +0100, Michal Prívozník wrote: > > > > Yes, the golden rule of XML design is that you should not have to write > > a second parser to interpret

Re: [PATCH v2 2/2] qemu: tpm: Extend TPM domain XML with PCR banks to activate

2021-11-03 Thread Stefan Berger
On 11/2/21 05:57, Daniel P. Berrangé wrote: On Tue, Nov 02, 2021 at 10:38:05AM +0100, Michal Prívozník wrote: Yes, the golden rule of XML design is that you should not have to write a second parser to interpret the value of an attribute / element. Any structure should be represented in the

Re: [PULL 00/10] Misc 20211102 patches

2021-11-03 Thread Richard Henderson
On 11/2/21 12:26 PM, Gerd Hoffmann wrote: The following changes since commit 8cb41fda78c7ebde0dd248c6afe1d336efb0de50: Merge remote-tracking branch 'remotes/philmd/tags/machine-20211101' into staging (2021-11-02 05:53:45 -0400) are available in the Git repository at:

[libvirt PATCHv2 7/7] qemu: retire QEMU_CAPS_SPICE_UNIX

2021-11-03 Thread Ján Tomko
It is now unused. Signed-off-by: Ján Tomko Reviewed-by: Tim Wiederhake --- src/qemu/qemu_capabilities.c | 3 +-- src/qemu/qemu_capabilities.h | 2 +- tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 -

[libvirt PATCHv2 6/7] qemu: always assume QEMU_CAPS_SPICE_UNIX

2021-11-03 Thread Ján Tomko
The presence of this capability depends on QEMU being compiled with spice that has the SPICE_ADDR_FLAG_UNIX_ONLY constant. It was added by spice commit 5365caeaae released in spice v0.12.6, which is older than the spice version on our supported architectures. Signed-off-by: Ján Tomko

[libvirt PATCHv2 5/7] tests: convert name-escape to use real caps

2021-11-03 Thread Ján Tomko
For later QEMUs than 2.11 we do FD passing for character devices, so lock the capabilites to this exact version. Signed-off-by: Ján Tomko --- ...-escape.args => name-escape.x86_64-2.11.0.args} | 7 --- tests/qemuxml2argvtest.c | 14 +- 2 files changed,

[libvirt PATCHv2 4/7] tests: qemuxml2argv: use latest caps for spice tests

2021-11-03 Thread Ján Tomko
Signed-off-by: Ján Tomko Reviewed-by: Tim Wiederhake --- .../graphics-spice-agent-file-xfer.args | 32 -- ...s-spice-agent-file-xfer.x86_64-latest.args | 35 +++ .../graphics-spice-agentmouse.args| 34 --- ...aphics-spice-agentmouse.x86_64-latest.args |

[libvirt PATCHv2 3/7] tests: qemuxml2xml: use latest caps for spice tests

2021-11-03 Thread Ján Tomko
Signed-off-by: Ján Tomko Reviewed-by: Tim Wiederhake --- ...s-spice-auto-socket-cfg.x86_64-latest.xml} | 5 ++- ...phics-spice-auto-socket.x86_64-latest.xml} | 5 ++- ...phics-spice-compression.x86_64-latest.xml} | 5 ++- ...hics-spice-egl-headless.x86_64-latest.xml} | 5 ++- ...

[libvirt PATCHv2 2/7] tests: qemuxml2xmltest: move graphics-spice-timeout

2021-11-03 Thread Ján Tomko
Move the test closer to other graphics-spice tests. Signed-off-by: Ján Tomko Reviewed-by: Tim Wiederhake --- tests/qemuxml2xmltest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index a066c35db0..3abf58a9f4 100644

[libvirt PATCHv2 1/7] tests: remove disks from spice tests

2021-11-03 Thread Ján Tomko
Reduce the churn in following patches. Signed-off-by: Ján Tomko Reviewed-by: Tim Wiederhake --- .../graphics-spice-agent-file-xfer.args | 2 -- .../graphics-spice-agent-file-xfer.xml | 5 - .../qemuxml2argvdata/graphics-spice-agentmouse.args | 2 --

[libvirt PATCHv2 0/7] qemu: retire QEMU_CAPS_SPICE_UNIX

2021-11-03 Thread Ján Tomko
Tim already acked v1, but I noticed a failure in the CI in patch 5/7 because with the latest caps, we try to create a logfile for one chardev in /tmp. Fix that by only testing name-escape with v2.11.0 QEMU caps. I've heard rumors of Peter having a patch ready that would make qemuxml2argv testing

Re: [libvirt PATCH 2/2] meson: Detect and reject invalid rst2html5 command

2021-11-03 Thread Andrea Bolognani
On Wed, Nov 03, 2021 at 10:26:12AM +, Daniel P. Berrangé wrote: > On Wed, Nov 03, 2021 at 04:15:49AM -0500, Andrea Bolognani wrote: > > Since no actual NACK has been raised over the past three months, nor > > has an alternative implementation materialized, I went ahead and > > pushed the

Re: [PATCH v2 1/1] virt-aa-helper: Purge profile if corrupted

2021-11-03 Thread Ján Tomko
On a Tuesday in 2021, Ioanna Alifieraki wrote: This commit aims to address the bug reported in [1] and [2]. If the profile is corrupted (0-size) the VM cannot be launched. To overcome this, check if the profile exists and if it has 0 size remove it. [1]

Re: [libvirt PATCH 2/2] meson: Detect and reject invalid rst2html5 command

2021-11-03 Thread Daniel P . Berrangé
On Wed, Nov 03, 2021 at 04:15:49AM -0500, Andrea Bolognani wrote: > On Wed, Oct 06, 2021 at 10:58:29AM -0500, Andrea Bolognani wrote: > > Dan, should I consider your criticism of the approach an explicit > > NACK? If not, I will pick up Pavel's ACK and push this. > > > > I think the latter is the

Re: [libvirt PATCH 0/2] meson: Enable ZFS storage backend even more often

2021-11-03 Thread Tim Wiederhake
On Wed, 2021-11-03 at 11:12 +0100, Andrea Bolognani wrote: > And drop some useless code. > > Andrea Bolognani (2): >   meson: Enable ZFS storage backend even more often >   meson: Stop looking up ZFS programs at build time > >  meson.build   | 16 >  

Re: [libvirt PATCH 0/7] qemu: retire QEMU_CAPS_SPICE_UNIX

2021-11-03 Thread Tim Wiederhake
On Tue, 2021-11-02 at 16:27 +0100, Ján Tomko wrote: > One less thing to probe via query-command-line-options > > Ján Tomko (7): >   tests: remove disks from spice tests >   tests: qemuxml2xmltest: move graphics-spice-timeout >   tests: qemuxml2xml: use latest caps for spice tests >   tests:

[libvirt PATCH 2/2] meson: Stop looking up ZFS programs at build time

2021-11-03 Thread Andrea Bolognani
At this point, we're no longer using the availability of the ZFS programs at build time to decide whether to enable ZFS support, so the only purpose of these find_program() calls is to record their absolute paths. However, the virCommand facilities that we're ultimately using to run them are

[libvirt PATCH 1/2] meson: Enable ZFS storage backend even more often

2021-11-03 Thread Andrea Bolognani
Commit 73a2ff36163e already improved the situation a lot. This pushes things even further. If the user or, more likely, the distro packager explicitly asked for ZFS support to be enabled, then we should comply with that request regardless of whether the necessary programs are available at build

[libvirt PATCH 0/2] meson: Enable ZFS storage backend even more often

2021-11-03 Thread Andrea Bolognani
And drop some useless code. Andrea Bolognani (2): meson: Enable ZFS storage backend even more often meson: Stop looking up ZFS programs at build time meson.build | 16 src/storage/storage_backend_zfs.c | 3 +++ 2 files changed, 3 insertions(+), 16

Re: [PATCH 0/5] Various cleanups

2021-11-03 Thread Tim Wiederhake
On Tue, 2021-11-02 at 18:10 +0100, Michal Privoznik wrote: > I've been playing with cocci lately and noticed it had troubles > parsing > some files. When I looked into them I had trouble parsing them as > well. > > Michal Prívozník (5): >   node_device_conf: Bring variables into loops >  

Re: [libvirt PATCH 2/2] meson: Detect and reject invalid rst2html5 command

2021-11-03 Thread Andrea Bolognani
On Wed, Oct 06, 2021 at 10:58:29AM -0500, Andrea Bolognani wrote: > Dan, should I consider your criticism of the approach an explicit > NACK? If not, I will pick up Pavel's ACK and push this. > > I think the latter is the right thing to do, on the basis that it > will leave us in a place that's

Re: [libvirt PATCH] tests: qemuxml2argv: remove validation warning

2021-11-03 Thread Peter Krempa
On Wed, Nov 03, 2021 at 09:26:22 +0100, Ján Tomko wrote: > This warning is emitted for pretty much every test case, > making it hard to see what the actual error is. > > Signed-off-by: Ján Tomko > --- > tests/qemuxml2argvtest.c | 2 -- > 1 file changed, 2 deletions(-) Yeah, it's quite

[libvirt PATCH] tests: qemuxml2argv: remove validation warning

2021-11-03 Thread Ján Tomko
This warning is emitted for pretty much every test case, making it hard to see what the actual error is. Signed-off-by: Ján Tomko --- tests/qemuxml2argvtest.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 804f01fb01..f7ae792371