[PATCH] tools: Fix install_mode for some scripts

2022-12-07 Thread Michal Privoznik
Scripts from the following list were installed with group write bit set: virt-xml-validate, virt-pki-validate, virt-sanlock-cleanup, libvirt-guests.sh. This is very unusual and in contrast with the way other scripts/binaries are installed. Resolves:

Re: [PATCH] cpu_map: Add -noMPX models for x86 Icelake Server

2022-12-07 Thread Lena Voytek
Hello all, Over the past few months there have been a few more reports of users unable to use Openstack Nova on their Icelake CPU. Updating virsh capabilities to properly display that mpx is unavailable fixes it. Is there an ideal way to update this change such that it gets accepted into libvirt?

Re: [libvirt PATCH v3 01/18] schema: allow 'ssh' as a protocol for network disks

2022-12-07 Thread Jonathon Jongsma
On 12/7/22 5:15 AM, Peter Krempa wrote: On Tue, Nov 15, 2022 at 12:07:18 +0100, Ján Tomko wrote: On a Thursday in 2022, Jonathon Jongsma wrote: There was support in the code for parsing protocol='ssh' on network disk sources, but it was not present in the xml schema. Add this to the schema and

Release of libvirt-php-0.5.7

2022-12-07 Thread Michal Prívozník
The 0.5.7 release of libvirt-php is tagged and tarball is available at: https://libvirt.org/sources/php/ Notable changes: * Dropped support for PHP-6.0 and older * Fixed libvirt_connect_get_machine_types() with PHP-7.0 and newer * Dropped imagick dependency * Bug fixes Thanks to everybody who

Re: [libvirt PATCH v3 08/18] qemu: Add qemuNbdkitProcess

2022-12-07 Thread Peter Krempa
On Thu, Oct 20, 2022 at 16:58:59 -0500, Jonathon Jongsma wrote: > An object for storing information about a nbdkit process that is serving > a specific virStorageSource. At the moment, this information is just > stored in the private data of virStorageSource and not used at all. > Future commits

Re: [libvirt PATCH v3 07/18] qemu: use file cache for nbdkit caps

2022-12-07 Thread Peter Krempa
On Thu, Oct 20, 2022 at 16:58:58 -0500, Jonathon Jongsma wrote: > Add the virFileCache implementation for nbdkit capabilities to the qemu > driver. This allows us to determine whether nbdkit is installed and > which plugins are supported. it also has persistent caching and the > capabilities are

Re: [PATCH v4] virsh: Add message to terminal when running snapshot-revert

2022-12-07 Thread Ján Tomko
On a Wednesday in 2022, Haruka Ohata wrote: When running virsh snapshot-* command, such as snapshot-create-as / snapshot-delete, it prints a result message. On the other hand virsh snapshot-revert command doesn't print a result message. So, This patch fixes to add message when running virsh

Re: RFC: New APIs for delegation of privileged operations

2022-12-07 Thread Daniel P . Berrangé
On Wed, Dec 07, 2022 at 12:42:06PM +0100, Martin Kletzander wrote: > On Thu, Dec 01, 2022 at 10:17:49AM +, Daniel P. Berrangé wrote: > > The other end of the > > > > virInternalSetProcessSetMaxMemLockHandler > > > > wouldn't have ability to validate the VM identity even if we > > passed it,

Re: [libvirt PATCH v3 06/18] qemu: implement persistent file cache for nbdkit caps

2022-12-07 Thread Peter Krempa
On Thu, Oct 20, 2022 at 16:58:57 -0500, Jonathon Jongsma wrote: > Implement the loadFile and saveFile virFileCacheHandlers callbacks so > that nbdkit capabilities are cached perstistently across daemon > restarts. The format and implementation is modeled on the qemu > capabilities, but simplified

Re: [PATCH 0/5] qemu: Prefer PNG for domain screenshots

2022-12-07 Thread Ján Tomko
On a Wednesday in 2022, Michal Privoznik wrote: Whilst preparing for libvirt-php release, I want to ditch its imagick dependency which is needed to convert PPM to PNG. But I've learned that QEMU is able to return PNG already which looks more versatile than PPM anyways. Michal Prívozník (5):

Re: [PATCH 0/5] qemu: Prefer PNG for domain screenshots

2022-12-07 Thread Martin Kletzander
On Wed, Dec 07, 2022 at 12:20:48PM +0100, Michal Privoznik wrote: Whilst preparing for libvirt-php release, I want to ditch its imagick dependency which is needed to convert PPM to PNG. But I've learned that QEMU is able to return PNG already which looks more versatile than PPM anyways. Michal

Re: [PATCH 4/5] qemu: Prefer PNG for domain screenshots

2022-12-07 Thread Martin Kletzander
On Wed, Dec 07, 2022 at 12:20:52PM +0100, Michal Privoznik wrote: Historically, QEMU took screenshots in PPM. While this might use to be popular format, as of v7.1.0-rc0~125^2~6 it is possible to take screenshots in PNG. This is more popular and renders almost everywhere, which is not the case

Re: [libvirt PATCH v3 05/18] qemu: implement basic virFileCache for nbdkit caps

2022-12-07 Thread Peter Krempa
On Thu, Oct 20, 2022 at 16:58:56 -0500, Jonathon Jongsma wrote: > Preparatory step for caching nbdkit capabilities. This patch implements > the newData and isValid virFileCacheHandlers callback functions. > > Signed-off-by: Jonathon Jongsma > --- > src/qemu/qemu_nbdkit.c | 93

Re: [libvirt PATCH v3 04/18] util: Allow virFileCache data to be any GObject

2022-12-07 Thread Peter Krempa
On Thu, Oct 20, 2022 at 16:58:55 -0500, Jonathon Jongsma wrote: > Since the libvirt documentation suggests to prefer GObject over > virObject, and since virObject is a GObject, change virFileCache to > allow GObjects as data. > > Signed-off-by: Jonathon Jongsma > --- > src/util/virfilecache.c |

Re: RFC: New APIs for delegation of privileged operations

2022-12-07 Thread Martin Kletzander
On Thu, Dec 01, 2022 at 10:17:49AM +, Daniel P. Berrangé wrote: On Wed, Nov 30, 2022 at 09:47:02AM +0100, Peter Krempa wrote: On Tue, Nov 29, 2022 at 09:05:33 -0800, Andrea Bolognani wrote: [...] > Proposal > > > In order to address the issues outlined above, I propose that we >

Re: [libvirt PATCH v3 03/18] qemu: expand nbdkit capabilities

2022-12-07 Thread Peter Krempa
On Thu, Oct 20, 2022 at 16:58:54 -0500, Jonathon Jongsma wrote: > In order to add caching of the nbdkit capabilities, we will need to > compare against file modification times, etc. So look up this > information when creating the nbdkit caps. > > Add a nbdkit_moddir build option to allow the

Re: [libvirt PATCH v3 02/18] qemu: Add functions for determining nbdkit availability

2022-12-07 Thread Peter Krempa
On Thu, Oct 20, 2022 at 16:58:53 -0500, Jonathon Jongsma wrote: > In future commits, we will optionally use nbdkit to serve some remote > disk sources. This patch queries to see whether nbdkit is installed on > the host and queries it for capabilities. The data will be used in later > commits. >

[PATCH 5/5] NEWS: Document change of screenshot format for QEMU

2022-12-07 Thread Michal Privoznik
Signed-off-by: Michal Privoznik --- NEWS.rst | 4 1 file changed, 4 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index bc61b9..39f508a6ce 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -19,6 +19,10 @@ v9.0.0 (unreleased) * **Improvements** + * qemu: Prefer PNG for domain screenshots +

[PATCH 3/5] qemu_monitor: Extend qemuMonitorScreendump() for @format

2022-12-07 Thread Michal Privoznik
The 'screendump' command has new argument 'format'. Let's expose this on our QMP level so that callers can specify the format, if they wish so. Signed-off-by: Michal Privoznik --- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_monitor.c | 7 --- src/qemu/qemu_monitor.h | 1 +

[PATCH 4/5] qemu: Prefer PNG for domain screenshots

2022-12-07 Thread Michal Privoznik
Historically, QEMU took screenshots in PPM. While this might use to be popular format, as of v7.1.0-rc0~125^2~6 it is possible to take screenshots in PNG. This is more popular and renders almost everywhere, which is not the case for PPM (for instance, modern browsers do not render it).

[PATCH 0/5] qemu: Prefer PNG for domain screenshots

2022-12-07 Thread Michal Privoznik
Whilst preparing for libvirt-php release, I want to ditch its imagick dependency which is needed to convert PPM to PNG. But I've learned that QEMU is able to return PNG already which looks more versatile than PPM anyways. Michal Prívozník (5): qemu_caps: Introduce

[PATCH 2/5] qemu_monitor: Debug print all arguments in qemuMonitorScreendump()

2022-12-07 Thread Michal Privoznik
For some reason, only @file argument is printed into debug logs. The rest of arguments was left out. Include all arguments. Signed-off-by: Michal Privoznik --- src/qemu/qemu_monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor.c

[PATCH 1/5] qemu_caps: Introduce QEMU_CAPS_SCREENSHOT_FORMAT_PNG

2022-12-07 Thread Michal Privoznik
In its v7.1.0-rc0~125^2~6 commit, QEMU gained support for taking screenshots in PNG format. Track this capability. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 +

Re: [libvirt PATCH v3 01/18] schema: allow 'ssh' as a protocol for network disks

2022-12-07 Thread Peter Krempa
On Tue, Nov 15, 2022 at 12:07:18 +0100, Ján Tomko wrote: > On a Thursday in 2022, Jonathon Jongsma wrote: > > There was support in the code for parsing protocol='ssh' on network disk > > sources, but it was not present in the xml schema. Add this to the > > schema and mention it in the