Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Thomas Huth
On 17/02/2023 17.38, Paolo Bonzini wrote: On 2/17/23 11:47, Daniel P. Berrangé wrote: On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: I feel the discussion petered out without a conclusion. I don't think letting the status quo win by inertia is a good outcome here. Which

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Thomas Huth
On 17/02/2023 18.43, Philippe Mathieu-Daudé wrote: (Cc'ing Huacai & Jiaxun). On 17/2/23 17:38, Paolo Bonzini wrote: On 2/17/23 11:47, Daniel P. Berrangé wrote: On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: I feel the discussion petered out without a conclusion. I don't

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Richard Henderson
On 2/17/23 06:06, Reinoud Zandijk wrote: On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: I feel the discussion petered out without a conclusion. I don't think letting the status quo win by inertia is a good outcome here. Which 32-bit hosts are still useful, and why?

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Philippe Mathieu-Daudé
(Cc'ing Huacai & Jiaxun). On 17/2/23 17:38, Paolo Bonzini wrote: On 2/17/23 11:47, Daniel P. Berrangé wrote: On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: I feel the discussion petered out without a conclusion. I don't think letting the status quo win by inertia is a

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Daniel P . Berrangé
On Fri, Feb 17, 2023 at 05:06:42PM +0100, Reinoud Zandijk wrote: > On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: > > I feel the discussion petered out without a conclusion. > > > > I don't think letting the status quo win by inertia is a good outcome > > here. > > > > Which

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Reinoud Zandijk
On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: > I feel the discussion petered out without a conclusion. > > I don't think letting the status quo win by inertia is a good outcome > here. > > Which 32-bit hosts are still useful, and why? NetBSD runs on a bunch of 32 bit-only

[libvirt PATCH v2] qemu: implement QEMU NBD source reconnect delay attribute

2023-02-17 Thread Christian Nautze
Currently it's only possible to set this parameter during domain creation via QEMU commandline passthrough feature. With the new delay attribute it's also possible to set this parameter if you want to attach a new NBD disk using "virsh attach-device domain device.xml" e.g.:

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Paolo Bonzini
On 2/17/23 11:47, Daniel P. Berrangé wrote: On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: I feel the discussion petered out without a conclusion. I don't think letting the status quo win by inertia is a good outcome here. Which 32-bit hosts are still useful, and why?

[PATCH] docs: ACL: Mention the ACL object name along with the corresponding libvirt object name

2023-02-17 Thread Peter Krempa
It's not trivial to figure out the ACL object name from our documentation. Add it above the table outlining existing permissions. Signed-off-by: Peter Krempa --- scripts/genaclperms.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/genaclperms.py b/scripts/genaclperms.py index

Re: [PATCH] docs: ACL: Show which permissions are allowed for unauthenticated connections

2023-02-17 Thread Daniel P . Berrangé
On Fri, Feb 17, 2023 at 04:33:12PM +0100, Peter Krempa wrote: > Certain APIs are allowed also without authentication but the ACL page > didn't outline which. Generate a new column with the information. > > Signed-off-by: Peter Krempa > --- > docs/acl.html.in | 3 ++- >

[PATCH] docs: ACL: Show which permissions are allowed for unauthenticated connections

2023-02-17 Thread Peter Krempa
Certain APIs are allowed also without authentication but the ACL page didn't outline which. Generate a new column with the information. Signed-off-by: Peter Krempa --- docs/acl.html.in | 3 ++- scripts/genaclperms.py | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 2/2] libvirt-nodedev: Allow read-only access to virNodeDeviceGetAutostart

2023-02-17 Thread Daniel P . Berrangé
On Fri, Feb 17, 2023 at 04:11:11PM +0100, Peter Krempa wrote: > Fetching whether a node-device is marked for autostart can be allowed > from read-only connections similarly to other objects. > > Fixes: c6607a25b93 > Signed-off-by: Peter Krempa > --- > src/libvirt-nodedev.c | 1 - > 1 file

Re: [PATCH 1/2] access: Allow 'node-device.read' permission for anonymous users

2023-02-17 Thread Daniel P . Berrangé
On Fri, Feb 17, 2023 at 04:11:10PM +0100, Peter Krempa wrote: > For all other objects we allow the 'read' permission for anonymous > users. In fact the idea is to allow all permissions users using the > readonly connection would have. > > This impacts the following APIs (in terms of RPC procedure

[PATCH v2 1/2] selinux: Swap two blocks handling setfilecon_raw() failure

2023-02-17 Thread Michal Privoznik
In virSecuritySELinuxSetFileconImpl() we have code that handles setfilecon_raw() failure. The code consists of two blocks: one for dealing with shared filesystem like NFS (errno is ENOTSUP or EROFS) and the other block that's dealing with EPERM for privileged daemon. Well, the order of these two

[PATCH v2 2/2] selinux: Don't ignore ENOENT in Permissive mode

2023-02-17 Thread Michal Privoznik
In selinux driver there's virSecuritySELinuxSetFileconImpl() which is responsible for actual setting of SELinux label on given file and handling possible failures. In fhe failure handling code we decide whether failure is fatal or not. But there is a bug: depending on SELinux mode (Permissive vs.

[PATCH v2 0/2] selinux: Don't ignore ENOENT in Permissive mode

2023-02-17 Thread Michal Privoznik
This is just a resend of the following series: https://listman.redhat.com/archives/libvir-list/2021-October/msg00738.html Michal Prívozník (2): selinux: Swap two blocks handling setfilecon_raw() failure selinux: Don't ignore ENOENT in Permissive mode src/security/security_selinux.c | 32

[PATCH 2/2] libvirt-nodedev: Allow read-only access to virNodeDeviceGetAutostart

2023-02-17 Thread Peter Krempa
Fetching whether a node-device is marked for autostart can be allowed from read-only connections similarly to other objects. Fixes: c6607a25b93 Signed-off-by: Peter Krempa --- src/libvirt-nodedev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libvirt-nodedev.c b/src/libvirt-nodedev.c

[PATCH 0/2] Read-only access to node devices

2023-02-17 Thread Peter Krempa
See individual patches. Peter Krempa (2): access: Allow 'node-device.read' permission for anonymous users libvirt-nodedev: Allow read-only access to virNodeDeviceGetAutostart src/access/viraccessperm.h | 1 + src/libvirt-nodedev.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-)

[PATCH 1/2] access: Allow 'node-device.read' permission for anonymous users

2023-02-17 Thread Peter Krempa
For all other objects we allow the 'read' permission for anonymous users. In fact the idea is to allow all permissions users using the readonly connection would have. This impacts the following APIs (in terms of RPC procedure names): $ git grep -A 3 node_device:read | grep REMOTE

Re: [PATCH v2 0/5] qemu_passt: Fix issues with PID file

2023-02-17 Thread Michal Prívozník
On 2/16/23 17:35, Laine Stump wrote: > On 2/16/23 8:32 AM, Michal Privoznik wrote: >> This is a v2 of: >> >> https://listman.redhat.com/archives/libvir-list/2023-February/237731.html >> >> diff to v1: >> - Merged patches that were ACKed in v1, >> - Dropped 4/4 from the original series (the one

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Stefan Weil
On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: Which 32-bit hosts are still useful, and why? Citing my previous mail: I now checked all downloads of the latests installers since 2022-12-30. qemu-w32-setup-20221230.exe – 509 different IP addresses

[PATCH] qemu: fix reconnect of unix socket is wrong

2023-02-17 Thread Zhenguo Yao
'reconnect' parameter doesn't pass to qemu properly when hotplug vhost-user device to vm. Fix this by making 'reconnect' to get correct value. Signed-off-by: Zhenguo Yao --- src/qemu/qemu_monitor_json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Daniel P . Berrangé
On Fri, Feb 17, 2023 at 12:05:46PM +0100, Stefan Weil wrote: > On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: > > > Which 32-bit hosts are still useful, and why? > > > Citing my previous mail: > >I now checked all downloads of the latests installers since 2022-12-30. >

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Markus Armbruster
Stefan Weil writes: > On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: > >> Which 32-bit hosts are still useful, and why? > > > Citing my previous mail: > >I now checked all downloads of the latests installers since 2022-12-30. > >qemu-w32-setup-20221230.exe – 509

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Claudio Fontana
On 1/30/23 12:44, Thomas Huth wrote: > Testing 32-bit host OS support takes a lot of precious time during the QEMU > contiguous integration tests, and considering that many OS vendors stopped > shipping 32-bit variants of their OS distributions and most hardware from > the past >10 years is

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Daniel P . Berrangé
On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: > I feel the discussion petered out without a conclusion. > > I don't think letting the status quo win by inertia is a good outcome > here. > > Which 32-bit hosts are still useful, and why? Which 32-bit hosts does Linux still

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Claudio Fontana
On 2/17/23 11:36, Markus Armbruster wrote: > I feel the discussion petered out without a conclusion. > > I don't think letting the status quo win by inertia is a good outcome > here. > > Which 32-bit hosts are still useful, and why? Hi Markus, if the question is very very general, my opinion

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Daniel P . Berrangé
On Fri, Feb 17, 2023 at 11:36:41AM +0100, Markus Armbruster wrote: > I feel the discussion petered out without a conclusion. > > I don't think letting the status quo win by inertia is a good outcome > here. > > Which 32-bit hosts are still useful, and why? > > Please note my question is not

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Markus Armbruster
I feel the discussion petered out without a conclusion. I don't think letting the status quo win by inertia is a good outcome here. Which 32-bit hosts are still useful, and why? Please note my question is not about the cost of keeping them (or savings from not keeping them), it's about the

Re: [libvirt PATCH v5 31/32] schema: add keyfile configuration for ssh disks

2023-02-17 Thread Peter Krempa
On Tue, Feb 14, 2023 at 11:08:18 -0600, Jonathon Jongsma wrote: > Authenticating via key file to an ssh server is often preferable to > logging in via password. In order to support this functionality add a > new xml element for ssh disks that allows the user to specify > a keyfile, username and

Re: [libvirt PATCH v5 29/32] schema: add configuration for host verification of ssh disks

2023-02-17 Thread Peter Krempa
On Thu, Feb 16, 2023 at 16:59:33 -0600, Jonathon Jongsma wrote: > On 2/16/23 10:45 AM, Peter Krempa wrote: > > On Tue, Feb 14, 2023 at 11:08:16 -0600, Jonathon Jongsma wrote: > > > In order to make ssh disks usable, we need to be able to validate a > > > remote host. To do this, add a xml element

Re: [libvirt PATCH v5 27/32] schema: add password configuration for ssh disk

2023-02-17 Thread Peter Krempa
On Thu, Feb 16, 2023 at 16:51:46 -0600, Jonathon Jongsma wrote: > On 2/16/23 10:43 AM, Peter Krempa wrote: > > On Tue, Feb 14, 2023 at 11:08:14 -0600, Jonathon Jongsma wrote: > > > Right now, ssh network disks are not usable. There is some basic support > > > in libvirt that is meant to support