[PATCH v2 1/1] qemu: Allow sockets in long or deep paths.

2023-04-27 Thread Nick Guenther
The qemu driver creates IPC sockets using absolute paths, but under POSIX socket paths are constrained pretty tightly. On systems with homedirs on an unusual mount point, like network homedirs, or just particularly long usernames, this could make starting VMs under qemu:///session impossible.

[PATCH v2 0/1] qemu: Allow sockets in long or deep paths.

2023-04-27 Thread Nick Guenther
v1: https://listman.redhat.com/archives/libvir-list/2023-April/239441.html Address v1's cleanup bugs by using g_autofree and the concurrency bugs by forking a subprocess before chdir(). It works! I have been working on the other solution of putting paths in /var/run, from

[PATCH 0/1] fix risc-v QEMU domains in non-RISC-V hosts

2023-04-27 Thread Daniel Henrique Barboza
Hi, For some reason didn't notice this was broken until recently. We're missing an API in the RISC-V CPU driver to allow QEMU TCG risc-v domains to run in non-native hosts. Daniel Henrique Barboza (1): cpu_riscv64.c: add update() implementation src/cpu/cpu_riscv64.c | 28

[PATCH 1/1] cpu_riscv64.c: add update() implementation

2023-04-27 Thread Daniel Henrique Barboza
At this moment it is not possible to launch a 'riscv64' domain of type 'qemu' (i.e. TCG) and machine 'virt' in a x86 host: $ sudo ./run tools/virsh start riscv-virt1 error: Failed to start domain 'riscv-virt1' error: this function is not supported by the connection driver: cannot update

libvirt-9.3.0 release candidate 2

2023-04-27 Thread Jiri Denemark
I have just tagged v9.3.0-rc2 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make

Re: [libvirt PATCH v2 1/1] meson: Check header usability

2023-04-27 Thread Andrea Bolognani
On Thu, Apr 27, 2023 at 03:23:29PM +0200, Michal Prívozník wrote: > On 4/27/23 15:12, Andrea Bolognani wrote: > > Do you think it's okay for me to push this now, so that it gets > > included in 9.3.0, or should I rather wait until after the release? > > It's a bug fix and as such can and in fact

Re: [libvirt PATCH v2 1/1] meson: Check header usability

2023-04-27 Thread Michal Prívozník
On 4/27/23 15:12, Andrea Bolognani wrote: > On Thu, Apr 27, 2023 at 02:57:54PM +0200, Michal Prívozník wrote: >> On 4/27/23 14:22, Andrea Bolognani wrote: >>> This fixes cross-building in some scenarios. >>> >>> Specifically, when building for armv7l on x86_64, has_header() >>> will see the x86_64

Re: [libvirt PATCH v2 1/1] meson: Check header usability

2023-04-27 Thread Andrea Bolognani
On Thu, Apr 27, 2023 at 02:57:54PM +0200, Michal Prívozník wrote: > On 4/27/23 14:22, Andrea Bolognani wrote: > > This fixes cross-building in some scenarios. > > > > Specifically, when building for armv7l on x86_64, has_header() > > will see the x86_64 version of the linux/kmv.h header and > >

Re: [libvirt PATCH v2 1/1] meson: Check header usability

2023-04-27 Thread Michal Prívozník
On 4/27/23 14:22, Andrea Bolognani wrote: > This fixes cross-building in some scenarios. > > Specifically, when building for armv7l on x86_64, has_header() > will see the x86_64 version of the linux/kmv.h header and > consider it to be usable. Later, when an attempt is made to > actually include

[libvirt PATCH v2 0/1] meson: Check header usability

2023-04-27 Thread Andrea Bolognani
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/850846324 Changes from [v1]: * replace all uses of has_header() with check_header(). [v1] https://listman.redhat.com/archives/libvir-list/2023-April/239672.html Andrea Bolognani (1): meson: Check header usability meson.build

[libvirt PATCH v2 1/1] meson: Check header usability

2023-04-27 Thread Andrea Bolognani
This fixes cross-building in some scenarios. Specifically, when building for armv7l on x86_64, has_header() will see the x86_64 version of the linux/kmv.h header and consider it to be usable. Later, when an attempt is made to actually include it, the compiler will quickly realize that things

Re: [libvirt PATCH] meson: Check usability of linux/kvm.h

2023-04-27 Thread Andrea Bolognani
On Thu, Apr 27, 2023 at 11:28:36AM +0100, Daniel P. Berrangé wrote: > On Thu, Apr 27, 2023 at 12:00:59PM +0200, Andrea Bolognani wrote: > > On Thu, Apr 27, 2023 at 11:50:05AM +0200, Michal Prívozník wrote: > > > But leaving meson aside, shouldn't we just use check_header() for every > > > header

Re: [libvirt PATCH] meson: Check usability of linux/kvm.h

2023-04-27 Thread Daniel P . Berrangé
On Thu, Apr 27, 2023 at 12:00:59PM +0200, Andrea Bolognani wrote: > On Thu, Apr 27, 2023 at 11:50:05AM +0200, Michal Prívozník wrote: > > On 4/27/23 11:41, Andrea Bolognani wrote: > > > +# headers for which we need to check actual usability. in most > > > +# cases, checking for presence is enough

Re: [PATCH] ci: Regenerate files

2023-04-27 Thread Pavel Hrdina
On Thu, Apr 27, 2023 at 11:44:30AM +0200, Michal Privoznik wrote: > This removes minor version number from OpenSUSE LEAP target names > and on CentOS Stream 9 installs flake8 from repositories, instead > of pip. > > Signed-off-by: Michal Privoznik > --- > ci/buildenv/centos-stream-9.sh

Re: [libvirt PATCH] meson: Check usability of linux/kvm.h

2023-04-27 Thread Andrea Bolognani
On Thu, Apr 27, 2023 at 11:50:05AM +0200, Michal Prívozník wrote: > On 4/27/23 11:41, Andrea Bolognani wrote: > > +# headers for which we need to check actual usability. in most > > +# cases, checking for presence is enough (and it's way faster) > > +check_headers = [ > > + 'linux/kvm.h', > > +]

Re: [libvirt PATCH] meson: Check usability of linux/kvm.h

2023-04-27 Thread Michal Prívozník
On 4/27/23 11:41, Andrea Bolognani wrote: > This fixes cross-building in some scenarios. > > Specifically, when building for armv7l on x86_64, has_header() > will see the x86_64 version of the header and consider it usable. > Later, when an attempt is made to actually use it, the compiler > will

[PATCH] ci: Regenerate files

2023-04-27 Thread Michal Privoznik
This removes minor version number from OpenSUSE LEAP target names and on CentOS Stream 9 installs flake8 from repositories, instead of pip. Signed-off-by: Michal Privoznik --- ci/buildenv/centos-stream-9.sh | 5 + .../{opensuse-leap-154.sh => opensuse-leap-15.sh}

[libvirt PATCH] meson: Check usability of linux/kvm.h

2023-04-27 Thread Andrea Bolognani
This fixes cross-building in some scenarios. Specifically, when building for armv7l on x86_64, has_header() will see the x86_64 version of the header and consider it usable. Later, when an attempt is made to actually use it, the compiler will quickly realize that things can't quite work. The

Re: [libvirt PATCH 0/2] docs: Link to java.libvirt.org

2023-04-27 Thread Andrea Bolognani
On Thu, Apr 27, 2023 at 09:12:22AM +0100, Daniel P. Berrangé wrote: > On Thu, Apr 27, 2023 at 09:56:06AM +0200, Peter Krempa wrote: > > On Thu, Apr 27, 2023 at 09:51:21 +0200, Andrea Bolognani wrote: > > > That's the new canonical location for information on > > > libvirt-java. > > > > > > A

Re: [libvirt PATCH 0/2] docs: Link to java.libvirt.org

2023-04-27 Thread Daniel P . Berrangé
On Thu, Apr 27, 2023 at 09:56:06AM +0200, Peter Krempa wrote: > On Thu, Apr 27, 2023 at 09:51:21 +0200, Andrea Bolognani wrote: > > That's the new canonical location for information on > > libvirt-java. > > > > A server-side redirect will have to be created in order > > to keep existing external

Re: [PATCH 0/2] tools: virsh-domain: display progress with enhanced granularity

2023-04-27 Thread Michal Prívozník
On 4/26/23 13:28, Shaleen Bathla wrote: > Changes since v1 > > - Remove superfluous parenthesis > - Update progress as 99.99 instead of 99.00 > - Add comment for auto-round-off prevention logic for double > >

Re: [libvirt PATCH 0/2] docs: Link to java.libvirt.org

2023-04-27 Thread Peter Krempa
On Thu, Apr 27, 2023 at 09:51:21 +0200, Andrea Bolognani wrote: > That's the new canonical location for information on > libvirt-java. > > A server-side redirect will have to be created in order > to keep existing external links working. Once this is done: Reviewed-by: Peter Krempa

[libvirt PATCH 1/2] docs: Link to java.libvirt.org

2023-04-27 Thread Andrea Bolognani
All the information from docs/java.rst have been transferred to the subproject's own website. Signed-off-by: Andrea Bolognani --- docs/bindings.rst | 3 ++- docs/docs.rst | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/bindings.rst b/docs/bindings.rst index

[libvirt PATCH 2/2] docs: Drop java.rst

2023-04-27 Thread Andrea Bolognani
We no longer link to it from anywhere. Signed-off-by: Andrea Bolognani --- docs/java.rst| 127 --- docs/meson.build | 1 - 2 files changed, 128 deletions(-) delete mode 100644 docs/java.rst diff --git a/docs/java.rst b/docs/java.rst deleted

[libvirt PATCH 0/2] docs: Link to java.libvirt.org

2023-04-27 Thread Andrea Bolognani
That's the new canonical location for information on libvirt-java. A server-side redirect will have to be created in order to keep existing external links working. Andrea Bolognani (2): docs: Link to java.libvirt.org docs: Drop java.rst docs/bindings.rst | 3 +- docs/docs.rst | 2

Re: [PATCH 2/2] tools: virsh-domain: display progress with enhanced granularity

2023-04-27 Thread Michal Prívozník
On 4/26/23 13:05, Martin Kletzander wrote: > On Wed, Apr 26, 2023 at 10:56:56AM +0530, Shaleen Bathla wrote: >> Switch from int to double for displaying job progress upto 2 decimal >> places. >> >> Signed-off-by: Shaleen Bathla >> --- >> tools/virsh-domain.c | 12 ++-- >> 1 file changed, 6