Re: [PATCH v2 1/1] qemu: Allow sockets in long or deep paths.

2023-04-28 Thread Nick Guenther
April 28, 2023 8:58 AM, "Michal Prívozník" wrote: > This only fixes the part that creates the socket. In some cases, libvirt > still needs to connect to them (e.g. monitor/guest agent sockets). That > code path still suffers from the limitation. True. But there's only 7 other places where

[PATCH v2 1/1] cpu_riscv64.c: add update() implementation

2023-04-28 Thread Daniel Henrique Barboza
At this moment it is not possible to launch a 'riscv64' domain if a CPU definition is presented in the domain. For example, adding this CPU definition: rv64 Will trigger the following error: $ sudo ./run tools/virsh start riscv-virt1 error: Failed to start domain 'riscv-virt1' error:

[PATCH v2 0/1] allow risc-v domains to use CPU definitions

2023-04-28 Thread Daniel Henrique Barboza
Hi, The bulk of the changes from v1 is in the commit message. See version 1 [1] for more details. Changes from v1: - rewrote the commit message to reflect the actual problem - changed virCPUriscvUpdate() to virCPURiscv64Update() to be in line with the name convention of the driver - v1 link:

Re: [PATCH 1/1] cpu_riscv64.c: add update() implementation

2023-04-28 Thread Daniel Henrique Barboza
On 4/28/23 12:40, Andrea Bolognani wrote: On Thu, Apr 27, 2023 at 06:04:10PM -0300, Daniel Henrique Barboza wrote: At this moment it is not possible to launch a 'riscv64' domain of type 'qemu' (i.e. TCG) and machine 'virt' in a x86 host: $ sudo ./run tools/virsh start riscv-virt1 error:

Re: [PATCH 1/1] cpu_riscv64.c: add update() implementation

2023-04-28 Thread Andrea Bolognani
On Thu, Apr 27, 2023 at 06:04:10PM -0300, Daniel Henrique Barboza wrote: > At this moment it is not possible to launch a 'riscv64' domain of type > 'qemu' (i.e. TCG) and machine 'virt' in a x86 host: > > $ sudo ./run tools/virsh start riscv-virt1 > error: Failed to start domain 'riscv-virt1' >

Re: [PATCH v2 1/1] qemu: Allow sockets in long or deep paths.

2023-04-28 Thread Michal Prívozník
On 4/28/23 07:14, Nick Guenther wrote: > The qemu driver creates IPC sockets using absolute paths, > but under POSIX socket paths are constrained pretty tightly. > On systems with homedirs on an unusual mount point, like > network homedirs, or just particularly long usernames, this > could make

Re: [PATCH 0/2] tools: virsh-domain: display progress with enhanced granularity

2023-04-28 Thread Martin Kletzander
On Thu, Apr 27, 2023 at 09:56:39AM +0200, Michal Prívozník wrote: On 4/26/23 13:28, Shaleen Bathla wrote: Changes since v1 - Remove superfluous parenthesis - Update progress as 99.99 instead of 99.00 - Add comment

Re: [PATCH 0/2] tools: virsh-domain: display progress with enhanced granularity

2023-04-28 Thread Martin Kletzander
On Wed, Apr 26, 2023 at 11:51:28AM +, Shaleen Bathla wrote: Missed adding V2 in subject title. Can someone please guide, if I should resend the patch series with the title correction or this can be taken forward ? That's fine, no need to resend just for this, that can happen to anyone.