Re: [PATCH] libxl: Defer starting job until migration perform phase

2023-07-10 Thread Jim Fehlig
On 7/7/23 14:17, Jim Fehlig wrote: Currently the libxl driver calls virDomainObjBeginJob in the begin phase of migration on the source host, expecting to call virDomainObjEndJob in the confirm phase. But the confirm phase is never executed if the prepare or perform phases fail. The job was

Re: [libvirt PATCH v3 4/5] qemu: allow use of async teardown in domain

2023-07-10 Thread Boris Fiuczynski
On 7/10/23 1:30 PM, Michal Prívozník wrote: On 7/5/23 08:20, Boris Fiuczynski wrote: Asynchronous teardown can be specified if the QEMU binary supports it by adding in the domain XML ... ... By default this new feature is disabled. Signed-off-by: Boris Fiuczynski

Re: [libvirt PATCH v3 4/5] qemu: allow use of async teardown in domain

2023-07-10 Thread Michal Prívozník
On 7/5/23 08:20, Boris Fiuczynski wrote: > Asynchronous teardown can be specified if the QEMU binary supports it by > adding in the domain XML > > > ... > > ... > > > By default this new feature is disabled. > > Signed-off-by: Boris Fiuczynski > Reviewed-by: Thomas Huth >

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-10 Thread Michal Prívozník
On 7/10/23 12:07, Daniel P. Berrangé wrote: > On Mon, Jul 10, 2023 at 12:02:35PM +0200, Boris Fiuczynski wrote: >> On 7/5/23 8:20 AM, Boris Fiuczynski wrote: >>> Enable by default asynchronous teardown on S390 hosts and add tests for >>> asynchronous teardown autogeneration support. >>> On S390

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-10 Thread Daniel P . Berrangé
On Mon, Jul 10, 2023 at 12:02:35PM +0200, Boris Fiuczynski wrote: > On 7/5/23 8:20 AM, Boris Fiuczynski wrote: > > Enable by default asynchronous teardown on S390 hosts and add tests for > > asynchronous teardown autogeneration support. > > On S390 hosts, Secure Execution guests can take a long

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-10 Thread Boris Fiuczynski
On 7/5/23 8:20 AM, Boris Fiuczynski wrote: Enable by default asynchronous teardown on S390 hosts and add tests for asynchronous teardown autogeneration support. On S390 hosts, Secure Execution guests can take a long time to shutdown, since the memory cleanup can take a long time. Since there is

Re: [libvirt PATCH v3 5/5] qemu: enable asynchronous teardown on s390x hosts by default

2023-07-10 Thread Boris Fiuczynski
On 7/5/23 4:47 PM, Daniel P. Berrangé wrote: On Wed, Jul 05, 2023 at 04:27:46PM +0200, Boris Fiuczynski wrote: On 7/5/23 3:08 PM, Daniel P. Berrangé wrote: On Wed, Jul 05, 2023 at 02:46:03PM +0200, Claudio Imbrenda wrote: On Wed, 5 Jul 2023 13:26:32 +0100 Daniel P. Berrangé wrote: [...] I

Re: [PATCH] qemu: Support removable for scsi disk

2023-07-10 Thread Han Han
Thanks On Mon, Jul 10, 2023 at 3:50 PM Michal Prívozník wrote: > On 6/29/23 13:03, Michal Prívozník wrote: > > On 6/5/23 07:07, Han Han wrote: > >> Allow //disk/target@removable for scsi disk devices, since QEMU has > support > >> the removable attribute for scsi-hd device from v0.14.0[1]. > >>

Re: [PATCH] qemu: Support removable for scsi disk

2023-07-10 Thread Michal Prívozník
On 6/29/23 13:03, Michal Prívozník wrote: > On 6/5/23 07:07, Han Han wrote: >> Allow //disk/target@removable for scsi disk devices, since QEMU has support >> the removable attribute for scsi-hd device from v0.14.0[1]. >> >> [1]: 419e691f8e: scsi-disk: Allow overriding SCSI INQUIRY removable bit >>