On Thu, Oct 26, 2023 at 06:48:28AM -0700, Andrea Bolognani wrote:
> Since we're just a few months away from the 10.0.0 release, I thought
> it would be a good time to bring up this idea.
>
> Can we move to date-based version numbers? I suggest having
>
> libvirt 24.01.0 instead of 10.0.0
>
On Wed, Oct 25, 2023 at 09:12:32AM -0700, Andrea Bolognani wrote:
> On Fri, Oct 20, 2023 at 12:48:26PM +0200, Michal Prívozník wrote:
> > On 10/4/23 07:58, Narayana Murty N wrote:
> > > This patch fixes this issue by returning the size=0 for architectures
> > > other than x86 and SuperH.
> >
> > Wh
On Mon, Oct 23, 2023 at 04:06:53PM +0200, Claudio Fontana wrote:
> On 10/11/23 17:29, Daniel P. Berrangé wrote:
> > On Wed, Oct 11, 2023 at 04:56:12PM +0200, Claudio Fontana wrote:
> >>
> >> On 10/11/23 16:05, Daniel P. Berrangé wrote:
> >>>
> >>
On Wed, Oct 18, 2023 at 12:38:10PM +0200, Juan Quintela wrote:
> Juan Quintela wrote:
> > Based on: Message-ID: <20231018100651.32674-1-quint...@redhat.com>
> > [PULL 00/11] Migration 20231018 patches
> >
> > And here we are, at v7:
> > - drop black line at the end of deprecated.rst
> >
On Sun, Oct 15, 2023 at 03:03:40PM -0400, Laine Stump wrote:
> On 10/12/23 3:37 PM, Praveen K Paladugu wrote:
> > Move guest interface management methods from qemu to hypervisor. These
> > methods will be shared by networking support in ch driver.
> >
> > Signed-off-by: Praveen K Paladugu
> > ---
Hello Libvirt Community,
For the last 18(!) years, libvirt community mailing lists have been kindly
hosted by Red Hat Corporate IT on the redhat.com Mailman installation.
In retrospect this wasn't the ideal home for community mailing lists but
that decision is ancient history.
Unfortunately as a
On Wed, Oct 11, 2023 at 04:56:12PM +0200, Claudio Fontana wrote:
>
> On 10/11/23 16:05, Daniel P. Berrangé wrote:
> >
> > Instead of using 'getfd' though we have to use 'add-fd'.
> >
> > Anyway, this lets us do FD passing as n
On Wed, Oct 11, 2023 at 03:46:59PM +0200, Claudio Fontana wrote:
> In terms of our use case, we would need to trigger these migrations from
> virsh save, restore, managedsave / start.
>
> 1) Can you confirm this is still a good target?
IIRC the 'dump' command also has a codepath that can exercis
Ping, for review feedback.
On Tue, Sep 26, 2023 at 05:11:44PM +0100, Daniel P. Berrangé wrote:
> The 'systemd-analyze security' command looks at the unit file
> configuration and reports on any settings which increase the
> attack surface for the daemon. Since most systemd
On Thu, Sep 28, 2023 at 03:32:15PM +0200, Andrea Bolognani wrote:
> Commit 56edf2fefe30 removed the last use.
>
> Signed-off-by: Andrea Bolognani
> ---
> libvirt.spec.in | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: ht
emote/libvirtd-admin.socket.in | 1 +
> src/remote/libvirtd-ro.socket.in | 1 +
> src/virtd-admin.socket.in | 1 +
> src/virtd-ro.socket.in | 1 +
> 8 files changed, 8 insertions(+)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berr
On Thu, Sep 28, 2023 at 06:52:35AM -0500, Andrea Bolognani wrote:
> On Thu, Sep 28, 2023 at 04:30:03AM -0500, Andrea Bolognani wrote:
> > On Thu, Sep 28, 2023 at 09:24:11AM +0100, Daniel P. Berrangé wrote:
> > > On Wed, Sep 27, 2023 at 06:19:07PM +0200, Andrea Bolognani wr
te mode 100644 src/nwfilter/virtnwfilterd.service.in
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.o
d, 5 insertions(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-http
will have to be
> masked.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/locking/virtlockd.service.in | 2 +-
> src/logging/virtlogd.service.in | 2 +-
> src/virtd.service.in | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P
irtd-ro.socket.in| 2 ++
> src/virtd.socket.in | 2 ++
> 10 files changed, 16 insertions(+)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-
d-tcp.socket.in | 2 +-
> src/virtd-tls.socket.in | 2 +-
> src/virtd.service.in | 2 +-
> src/virtd.socket.in | 2 +-
> src/vz/meson.build| 2 +-
> 33 files changed, 34 insertions(+), 34 deletions(-)
Reviewed-by:
3 files changed, 3 insertions(+), 30 deletions(-)
> create mode 100644 src/vbox/virtvboxd.service.extra.in
> delete mode 100644 src/vbox/virtvboxd.service.in
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/phot
On Thu, Sep 28, 2023 at 05:38:45AM -0500, Andrea Bolognani wrote:
> On Thu, Sep 28, 2023 at 11:16:53AM +0100, Daniel P. Berrangé wrote:
> > On Wed, Sep 27, 2023 at 06:19:09PM +0200, Andrea Bolognani wrote:
> > > Signed-off-by: Andrea Bolognani
> > > ---
> &g
> 3 files changed, 23 insertions(+), 48 deletions(-)
> create mode 100644 src/ch/virtchd.service.extra.in
> delete mode 100644 src/ch/virtchd.service.in
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/phot
--
> 3 files changed, 4 insertions(+), 31 deletions(-)
> create mode 100644 src/storage/virtstoraged.service.extra.in
> delete mode 100644 src/storage/virtstoraged.service.in
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https
te mode 100644 src/interface/virtinterfaced.service.in
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.o
nged, 3 insertions(+), 30 deletions(-)
> create mode 100644 src/vz/virtvzd.service.extra.in
> delete mode 100644 src/vz/virtvzd.service.in
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https:
--
> 3 files changed, 29 insertions(+), 52 deletions(-)
> create mode 100644 src/qemu/virtqemud.service.extra.in
> delete mode 100644 src/qemu/virtqemud.service.in
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.fli
On Wed, Sep 27, 2023 at 06:19:22PM +0200, Andrea Bolognani wrote:
> Now that the migration to common templates has been completed,
> we no longer need these.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/meson.build | 4
> 1 file changed, 4 deletions(-)
Reviewed-b
100644 src/secret/virtsecretd.service.in
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https:/
te mode 100644 src/node_device/virtnodedevd.service.in
Reviewed-by: Daniel P. Berrangé
Though I wonder if its worth just keeping an empty stub here, with
the section headings. It'd be a little confusing to see the stubs
present for some daemons but not others.
With regards,
Daniel
--
insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
> 3 files changed, 23 insertions(+), 48 deletions(-)
> create mode 100644 src/lxc/virtlxcd.service.extra.in
> delete mode 100644 src/lxc/virtlxcd.service.in
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/phot
100644 src/remote/virtproxyd.service.in
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https:/
--
> 3 files changed, 3 insertions(+), 30 deletions(-)
> create mode 100644 src/network/virtnetworkd.service.extra.in
> delete mode 100644 src/network/virtnetworkd.service.in
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https
> src/libxl/virtxend.socket.extra.in | 2 ++
> 4 files changed, 16 insertions(+), 37 deletions(-)
> create mode 100644 src/libxl/virtxend.service.extra.in
> delete mode 100644 src/libxl/virtxend.service.in
> create mode 100644 src/libxl/virtxend.socket.extra.in
Reviewed-
src/meson.build | 4
> 1 file changed, 4 insertions(+)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-p
ult without breaking anything.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/meson.build | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/
/meson.build | 3 +++
> 13 files changed, 46 insertions(+)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
On Wed, Sep 27, 2023 at 06:19:07PM +0200, Andrea Bolognani wrote:
> We already use templating to generate sockets, which are all
> based off libvirtd's. Push the idea further, and extend it to
> cover services as well.
>
> This is more challenging, as the various modular daemons each have
> their
.in| 1 -
> src/remote/libvirtd-tcp.socket.in | 1 -
> src/remote/libvirtd-tls.socket.in | 1 -
> src/remote/libvirtd.socket.in | 1 -
> 6 files changed, 7 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.f
rvice.in | 3 ++-
> src/virtd.service.in | 3 ++-
> 3 files changed, 6 insertions(+), 3 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https
remote/libvirtd.socket.in | 6 +++---
> 5 files changed, 21 insertions(+), 21 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop
---
> src/remote/meson.build | 3 ---
> 1 file changed, 3 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.co
cadence of the Go bindings follows the
> one of the C library.
>
> [1] https://gitlab.com/libvirt/libvirt-go-module/-/blob/master/VERSIONING.rst
>
> Signed-off-by: Andrea Bolognani
> ---
The caveats around skipping releases for Go also apply to the Perl
and Python too.
Reviewe
On Mon, Sep 25, 2023 at 08:58:39PM +0200, Andrea Bolognani wrote:
> Hypervisors are referred to by their user-facing name rather
> than the name of their libvirt driver, the monolithic daemon is
> explicitly referred to as legacy, and a consistent format is
> used throughout.
>
> Signed-off-by: An
;
> Signed-off-by: Andrea Bolognani
> ---
> src/locking/virtlockd.service.in | 4 ++--
> src/logging/virtlogd.service.in | 4 ++--
> src/remote/libvirtd.service.in | 4 ++--
> src/virtd.service.in | 4 ++--
> 4 files changed, 8 insertions(+), 8 deletions(-)
Rev
On Mon, Sep 25, 2023 at 08:58:38PM +0200, Andrea Bolognani wrote:
> They are unnecessary, since all sockets for a service are now
> enabled as soon as one of them is and each service has a very
> strong dependency on all of its sockets.
You earlier modified the .service units to have BindsTo= for
irtd-ro.socket.in| 2 ++
> src/virtd.socket.in | 2 ++
> 10 files changed, 16 insertions(+)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-
r.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/virtd-admin.socket.in | 2 ++
> src/virtd-ro.socket.in| 2 ++
> src/virtd-tcp.socket.in | 2 ++
> src/virtd-tls.socket.in | 2 ++
> src/virtd.service.in | 3 ++-
> src/virtd.socket.in | 2 ++
> 6 f
src/logging/virtlogd.service.in | 1 -
> src/logging/virtlogd.socket.in| 1 -
> 6 files changed, 6 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org
tcp.socket.in | 1 -
> src/virtd-tls.socket.in | 1 -
> src/virtd.socket.in | 1 -
> 10 files changed, 10 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :
ive when the hypervisor driver is
> started.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/libxl/meson.build | 1 +
> src/qemu/meson.build | 2 ++
> src/remote/libvirtd.service.in | 7 ++-
> 3 files changed, 9 insertions(+), 1 deletion(-)
Rev
✗ User=/DynamicUser=
This is highly desirable, but we currently read/write
logs as root, and directories we're told to write into
could be anywhere. So using a non-root user would have
a major risk of regressions for applications and also
have upgrade implications
Signed
On Tue, Sep 26, 2023 at 08:12:43AM -0500, Andrea Bolognani wrote:
> On Tue, Sep 26, 2023 at 01:14:33PM +0100, Daniel P. Berrangé wrote:
> > On Tue, Sep 26, 2023 at 07:02:19AM -0500, Andrea Bolognani wrote:
> > > I don't think it helps much with not storing additional data
On Tue, Sep 26, 2023 at 04:09:17AM -0500, Andrea Bolognani wrote:
> On Tue, Sep 26, 2023 at 09:44:52AM +0100, Daniel P. Berrangé wrote:
> > On Mon, Sep 25, 2023 at 08:58:33PM +0200, Andrea Bolognani wrote:
> > > This is the strongest relationship that can be declared between
&g
On Tue, Sep 26, 2023 at 07:02:19AM -0500, Andrea Bolognani wrote:
> On Tue, Sep 26, 2023 at 11:23:51AM +0100, Daniel P. Berrangé wrote:
> > On Tue, Sep 26, 2023 at 11:09:44AM +0200, Pavel Hrdina wrote:
> > > On Mon, Sep 25, 2023 at 08:58:24PM +0200, Andr
On Tue, Sep 26, 2023 at 02:11:37PM +0200, Marc Hartmayer wrote:
> On Mon, Sep 25, 2023 at 04:15 PM +0100, Daniel P. Berrangé
> wrote:
> > On Mon, Sep 25, 2023 at 03:39:09PM +0200, Marc Hartmayer wrote:
> >> When starting a guest via libvirt (`virsh start --console`), earl
On Tue, Sep 26, 2023 at 11:09:44AM +0200, Pavel Hrdina wrote:
> On Mon, Sep 25, 2023 at 08:58:24PM +0200, Andrea Bolognani wrote:
> > Signed-off-by: Andrea Bolognani
> > ---
> > src/ch/meson.build| 27
> > src/ch/virtchd.service.in | 44 ---
ult without breaking anything.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/meson.build | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/
On Mon, Sep 25, 2023 at 08:58:33PM +0200, Andrea Bolognani wrote:
> This is the strongest relationship that can be declared between
> two units, and causes the service to be terminated immediately
> if any of its sockets disappear. This is the behavior we want.
IIUC, this prevents running the serv
meson.build | 1 -
> src/vbox/meson.build| 1 -
> src/vz/meson.build | 1 -
> 12 files changed, 12 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.or
sockprefix@ in
> those cases, but in the most common scenario we can do away with
> the requirement by introducing a sensible default.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Dani
| 1 -
> src/secret/meson.build | 1 -
> src/storage/meson.build | 1 -
> src/vbox/meson.build| 1 -
> src/vz/meson.build | 1 -
> 14 files changed, 14 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com
ile this is our preferred configuration, we shouldn't prevent
> the admin to start them at boot if they want to.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/locking/virtlockd.service.in | 1 +
> src/logging/virtlogd.service.in | 1 +
> 2 files changed, 2 insertions(
Signed-off-by: Andrea Bolognani
> ---
> src/locking/virtlockd.service.in | 1 +
> src/logging/virtlogd.service.in | 1 +
> 2 files changed, 2 insertions(+)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/db
On Mon, Sep 25, 2023 at 08:58:05PM +0200, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani
> ---
> src/meson.build | 6 +++---
> src/remote/libvirtd.socket.in | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé
12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: htt
by: Andrea Bolognani
> ---
> src/meson.build | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-
Signed-off-by: Andrea Bolognani
> ---
> src/locking/meson.build | 2 +-
> src/logging/meson.build | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dbe
tually starts already.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/locking/virtlockd.service.in | 1 +
> src/logging/virtlogd.service.in | 1 +
> src/remote/libvirtd.service.in | 1 +
> 3 files changed, 3 insertions(+)
Reviewed-by: Daniel P. Berrangé
&g
the only exceptions.
>
> Signed-off-by: Andrea Bolognani
> ---
> src/locking/virtlockd.socket.in | 1 +
> src/logging/virtlogd.socket.in | 1 +
> 2 files changed, 2 insertions(+)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-h
On Mon, Sep 25, 2023 at 03:48:27PM +0100, Alex Bennée wrote:
> This might be premature but while streamling the avocado tests I
> realised the only tests we have are "check-tcg" ones. The aging
> fedora-criss-cross image works well enough for developers but can't be
> used in CI as we need supporte
On Mon, Sep 25, 2023 at 03:48:27PM +0100, Alex Bennée wrote:
> This might be premature but while streamling the avocado tests I
> realised the only tests we have are "check-tcg" ones. The aging
> fedora-criss-cross image works well enough for developers but can't be
> used in CI as we need supporte
; 16 files changed, 16 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
On Mon, Sep 25, 2023 at 03:39:09PM +0200, Marc Hartmayer wrote:
> When starting a guest via libvirt (`virsh start --console`), early
> console output was missed because the guest was started first and then
> the console was attached. This patch changes this to the following
> sequence:
>
> 1. crea
(!(conn = virConnectOpen("xen:///system")))
> +if (!(conn = virGetConnectNetwork()))
> goto cleanup;
>
> if (!(network =
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.f
gt; Flow control expressions and structures are a problem though in this
> regard, so let's just print some important values for debugging
> purposes.
>
> Signed-off-by: Erik Skultety
> ---
> ci/jobs.sh | 26 +-
> 1 file changed, 13 insertions(+
gt; command completely silently.
>
> Signed-off-by: Erik Skultety
> ---
> ci/jobs.sh | 5 +
> 1 file changed, 5 insertions(+)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|:
rik Skultety
> ---
> ci/jobs.sh | 7 +++
> 1 file changed, 7 insertions(+)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berra
ing to operate on the right set of daemons (monolithic vs modular),
> lets print the DAEMONS variable that we set depending on the distro we
> execute the tests on.
>
> Signed-off-by: Erik Skultety
> ---
> ci/jobs.sh | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Dani
On Mon, Sep 18, 2023 at 12:22:46PM +0200, Erik Skultety wrote:
> Unfortunately, once we go down the line of running our own scripts as
> part of GitLab CI jobs rather than open coding Shell in YAML, we lose
> the benefit of seeing each line the script executes. The downside of
> the default YAML ho
systemctl --quiet stop ${daemon}.service
> sudo systemctl restart ${daemon}.socket
> done
> @@ -113,7 +113,7 @@ run_integration() {
> # Shell scripts with -e by default and virsh returns an error if one
> tries
> # to start a machine/network that is alread
e can now do whatever formatting & readability adjustments we
> want.
>
> Signed-off-by: Erik Skultety
> ---
> ci/jobs.sh | 15 ---
> 1 file changed, 12 insertions(+), 3 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: http
> Signed-off-by: Erik Skultety
> ---
> ci/jobs.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o
ucting it to run the test suite sequentially leading to test
> stability issues, so abandoning the v98.0 was a good thing in the end.
Heh, ok ignore my comment in an earlier patch then :-)
> Signed-off-by: Erik Skultety
> ---
> ci/jobs.sh | 1 -
> 1 file changed, 1 deletion
6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-phot
ought
> to be started only on Stream 8.
>
> Signed-off-by: Erik Skultety
> ---
> ci/jobs.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dbe
ation-template.yml | 36 ++--
> ci/jobs.sh | 32
> 2 files changed, 34 insertions(+), 34 deletions(-)
Reviewed-by: Daniel P. Berrangé
> +run_integration() {
> +# Avocado >98.0 fails with the nwfilter TCK tests, so stick with 98
in the wild.
IOW, I don't mind dropping this blocking rule, but please update
the commit message to say we don't care that it is obsolescent
in POSIX.
Reviewed-by: Daniel P. Berrangé
>
> Signed-off-by: Erik Skultety
> ---
> build-aux/syntax-check.mk | 9 -
> 1 fil
On Mon, Sep 18, 2023 at 01:47:03PM +0200, Erik Skultety wrote:
> On Mon, Sep 18, 2023 at 11:31:53AM +0100, Daniel P. Berrangé wrote:
> > On Mon, Sep 18, 2023 at 12:22:45PM +0200, Erik Skultety wrote:
> > > We tried to evade usage of eval in commit 6214ae55f6a, but tryin
On Mon, Sep 18, 2023 at 12:22:45PM +0200, Erik Skultety wrote:
> We tried to evade usage of eval in commit 6214ae55f6a, but trying to
> use I/O redirections with a command doesn't have the desired effect,
> because when Shell eats the redirection it is applied to anything
> inside the run_cmd funct
On Thu, Sep 14, 2023 at 12:22:26PM +0200, Peter Krempa wrote:
> On Thu, Sep 14, 2023 at 09:44:16 +, Миронов Сергей Владимирович wrote:
> > No checks, dereferencing possible.
> >
> >
> > Return value of a function 'virDomainChrSourceDefNew'
> > is dereferenced at qemu_command.c without checkin
On Wed, Sep 13, 2023 at 04:14:55PM +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 13, 2023 at 05:07:27PM +0200, Ján Tomko wrote:
> > On a Tuesday in 2023, Daniel P. Berrangé wrote:
> > > On Tue, Sep 12, 2023 at 04:05:04PM +0200, Ján Tomko wrote:
> > > > On a Mond
On Wed, Sep 13, 2023 at 05:07:27PM +0200, Ján Tomko wrote:
> On a Tuesday in 2023, Daniel P. Berrangé wrote:
> > On Tue, Sep 12, 2023 at 04:05:04PM +0200, Ján Tomko wrote:
> > > On a Monday in 2023, Daniel P. Berrangé wrote:
> > > > I would expect libvirt to "do
for review anyway to see
> if there's an agreement on this approach.
These defaults for run_test() are consistent with the override
done in run_codestyle(), so:
Reviewed-by: Daniel P. Berrangé
>
> ci/jobs.sh | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --g
: Erik Skultety
> Reviewed-by: Daniel P. Berrangé
> Erik Skultety :
> ---
> .gitlab-ci.yml | 10 --
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 1c6af8f8b3..c837812091 100644
> --- a/.gitlab-ci.yml
On Tue, Sep 12, 2023 at 04:11:01PM -0500, Jonathon Jongsma wrote:
> On 9/12/23 7:00 AM, Peter Krempa wrote:
> > On Mon, Sep 11, 2023 at 16:53:42 -0500, Jonathon Jongsma wrote:
> > > see https://bugzilla.redhat.com/show_bug.cgi?id=1900770.
> > >
> > > Changes in v2:
> > > - Don't use virStorageSo
On Tue, Sep 12, 2023 at 04:05:04PM +0200, Ján Tomko wrote:
> On a Monday in 2023, Daniel P. Berrangé wrote:
> > On Mon, Sep 11, 2023 at 03:51:28PM +0200, Ján Tomko wrote:
> > > Signed-off-by: Ján Tomko
> > > ---
> > > docs/kbase/virtiofs.rst | 29 +++
On Mon, Sep 11, 2023 at 03:51:28PM +0200, Ján Tomko wrote:
> Signed-off-by: Ján Tomko
> ---
> docs/kbase/virtiofs.rst | 29 +
> 1 file changed, 29 insertions(+)
>
> diff --git a/docs/kbase/virtiofs.rst b/docs/kbase/virtiofs.rst
> index 5940092db5..ecfb8e4236 100644
>
'run_build'
> function twice, passing 'libvirt-pot-dep' and 'libvirt-pot' targets
> in a serial manner.
>
> Signed-off-by: Erik Skultety
> Erik Skultety :
> ---
> ci/build.sh | 11 +++
> 1 file changed, 11 insertions(+)
Reviewed
at will
> take care of a correct execution of a build job in a similar fashion as
> if the job ran in a GitLab environment.
>
> Signed-off-by: Erik Skultety
> Erik Skultety :
> ---
> ci/build.sh | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
With reg
file changed, 0 insertions(+), 0 deletions(-)
> rename ci/{build.sh => jobs.sh} (100%)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-htt
k
> with "sourcing" this file to populate the environment with function
> definitions.
>
> Signed-off-by: Erik Skultety
> Erik Skultety :
> ---
> ci/build.sh | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé
With reg
1 - 100 of 8073 matches
Mail list logo
