mment if so.
>
So that's checking if veth1 is an empty string and hence needs to have a name
assigned. I don't recall any special reason for using (1 > strlen()).
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Daniel Veillard wrote:
> On Fri, Jun 06, 2008 at 10:29:04AM +0100, Daniel P. Berrange wrote:
>> On Thu, Jun 05, 2008 at 11:59:34PM -0700, Dave Leskovec wrote:
>>> The lxc driver xml parser treats the console element as input when it
>>> should be
>>> output o
Daniel Veillard wrote:
> On Thu, May 29, 2008 at 03:44:24PM -0700, Dave Leskovec wrote:
...
>
> Hum, I'm surprized the PID file is removed only in lxcDomainUndefine.
> The PID file need to be re-created each time the domain is started. But
> a domain could be started and sto
Daniel P. Berrange wrote:
> On Fri, May 30, 2008 at 11:40:00AM -0700, Dave Leskovec wrote:
>> Daniel P. Berrange wrote:
>>> On Fri, May 30, 2008 at 02:28:46AM -0400, Daniel Veillard wrote:
>>>> On Thu, May 29, 2008 at 03:20:15PM -0700, Dave Leskovec wrote:
>>
Daniel P. Berrange wrote:
> On Fri, May 30, 2008 at 02:28:46AM -0400, Daniel Veillard wrote:
>> On Thu, May 29, 2008 at 03:20:15PM -0700, Dave Leskovec wrote:
>>> +if (ESRCH == errno) {
>>> +rc = 0;
>>> +DEBU
er, this time with the patch
Dave Leskovec wrote:
> This patch will use a file in the lxc configuration directory to store the tty
> forwarding process pid. The pid is stored after the process is fork()'d.
> It's
> loaded during startup when the config for a runni
his should avoid "losing" the
tty pid over a libvirtd restart.
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
This patch adds a check that validates that the container process pid still
exists. This should catch cases where the container exits while libvirtd is
down.
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
---
src/lxc_conf.c | 46
tial value).
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
---
src/lxc_driver.c |5 +
1 file changed, 5 insertions(+)
Index: b/src/lxc_driver.c
===
--- a/src/lxc_driver.c 2008-05-12 23:30:58.0
.
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
This patch ignores ECHILD from waitpid(). This can happen if libvirtd was
restarted and the container processes are no longer the children of libvirtd.
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
---
src/lxc_driver.c |4 ++--
1 file changed, 2 insertions
Daniel P. Berrange wrote:
> On Fri, May 09, 2008 at 10:16:38AM -0700, Dave Leskovec wrote:
>> We never really settled on the XML format for container network interfaces.
>> I
>> know a little more about what these look like now and have been working on
>> the
>>
I've been kicking around
are:
Virtual network
Bridge to LAN
All comments welcome.
Thanks!
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir
Jim Meyering wrote:
> Dave Leskovec <[EMAIL PROTECTED]> wrote:
>> Jim Meyering wrote:
>>> Dave Leskovec <[EMAIL PROTECTED]> wrote:
...
>> Index: b/qemud/qemud.c
>> ===
> ...
>> +s
Daniel Veillard wrote:
> On Tue, May 06, 2008 at 12:51:08AM -0700, Dave Leskovec wrote:
[...]
>> -close(vm->parentTty);
>> +//close(vm->parentTty);
>> close(vm->containerTtyFd);
>
> if we really don't need this anymore just remove it, if yo
t least not after the "-- " signature-introducer.
> Some mail clients (at least Gnus) ">"-quote only the part
> of your message that comes before the signature.
Well, I've been sending patches as attachments since my early ones were getting
mangled. I guess opti
ce an EPOLLIN is seen from an fd, another
one will not be surfaced until all data has been read from the file (EAGAIN is
returned by read).
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
---
src/lxc_driver.c | 174 -
Jim Meyering wrote:
> Dave Leskovec <[EMAIL PROTECTED]> wrote:
> ...
>>>> +#ifndef _SIGNAL_H
>>>> +#include
>>>> +#endif
>>> In practice it's fine to include unconditionally,
>>> and even multiple times. Have you e
Hi Jim,
Thanks for the review. Answers below -
Jim Meyering wrote:
> Dave Leskovec <[EMAIL PROTECTED]> wrote:
>> This patch allows the lxc driver to handle SIGCHLD signals from exiting
> ...
>
> Hi Dave,
> At least superficially, this looks fine.
> Two question
Daniel P. Berrange wrote:
> On Wed, Apr 30, 2008 at 11:38:01PM -0700, Dave Leskovec wrote:
>> This patch allows the lxc driver to handle SIGCHLD signals from exiting
>> containers. The handling will perform some cleanup such as waiting for
>> the container process and ki
function to handle them. This required some changes to
the way libvirtd was catching signals (to get the pid of the sending process) as
well as an addition to the state driver structure. The intent was to provide
future drivers access to signals as well.
--
Best Regards,
Dave Leskovec
IBM Linux
Thanks! Removing the if == NULL goto fail works. Patch is attached.
Daniel P. Berrange wrote:
> On Wed, Apr 30, 2008 at 05:22:22PM -0700, Dave Leskovec wrote:
>> Hi Dan,
>>
>> I updated today to the latest CVS and can no longer connect to the lxc
>> driver.
>
mething is added and hence this function returns NULL if
nothing is ever put in the buffer. I'm not familiar enough with the intended
behavior to know what the fix should be here.
Thanks!
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mai
:02:55PM -0700, Dave Leskovec wrote:
>> Reposting the patches to start, shutdown and destroy containers with updates
>> for
>> feedback received so far.
>
> This all looks fine to me, Jim founds some parts which might need
> cleanup, but maybe it would be more easilly a
Hi Jim,
Responses inline below and I've attached an updated patch. Thanks!
Jim Meyering wrote:
> Dave Leskovec <[EMAIL PROTECTED]> wrote:
>
>> This is a repost of the shutdown and destroy container support. Changes in
>> this
>
> A few comments:
&g
st of your comments were still applicable. I've addressed them inline below
and attached an updated patch.
Thanks again!
Jim Meyering wrote:
> Dave Leskovec <[EMAIL PROTECTED]> wrote:
>> This is a repost of the start container support. Changes from the last
>&
root process.
* Since the tty forwarding process is now outside the container, we have to kill
and wait for it in the destroy.
Thanks!
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
---
src/lxc_container.c | 21 +++
src/lxc_driver.c| 94
console
lxcExecContainerInit - see below, should not return
exit()
lxcExecContainerInit() - runs within container, root process
exec containers init
if exec fails, exit()
Thanks!
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
---
src/Makefile.am
Reposting the patches to start, shutdown and destroy containers with updates for
feedback received so far.
Thanks!
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir
ta);
> :+lxc_vm_t *vm = lxcFindVMByUUID(driver, dom->uuid);
> :+
>
Ah, ok. Yep, I can change that...
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Meant to include this in the last reply - Here's a patch for the lxcFreeVMs()
issue:
>
> This breaks doesn't it? After calling lxcFreeVM(), curVm is no longer valid
> since it was free()'d. Need to pull out the next pointer before lxcFreeVM().
>
--
Best Regar
m->next;
> - free(curVm);
> curVm = nextVm;
> }
> }
[...]
> --- 819,825
> void lxcFreeVM(lxc_vm_t *vm)
> {
> lxcFreeVMDef(vm->def);
> ! free(vm);
> }
This breaks doesn't it? After calling lxcFreeVM()
but
>> when running 'make check' as a normal user libvirtd is run as an
>> user and compiling the lxc driver in would break the regression tests
>
> Patch applied to CVS too,
>
> Daniel
>
Great, looks good. Thanks!
--
Best Regards,
Dave Lesko
Daniel Veillard wrote:
> On Wed, Mar 26, 2008 at 11:22:25PM -0700, Dave Leskovec wrote:
>> This patch contains the shutdown and destroy domain support for Linux
>> Containers.
>>
>> A shutdown of the container is requested by sending a SIGINT to the container
>>
Daniel Veillard wrote:
> On Wed, Mar 26, 2008 at 11:20:59PM -0700, Dave Leskovec wrote:
>> This is a repost of patch four in the last series I posted. It contains the
>> start container support. I've made some changes corresponding to Dan B's
>> patch
>> mov
Daniel Veillard wrote:
> On Wed, Mar 26, 2008 at 11:35:08PM -0700, Dave Leskovec wrote:
>> Sorry - I should have mentioned that the two lxc patches I just posted are
>> built
>> on Dan B's patch. The order is this:
>>
>> Dan's patch
>
>
Sorry - I should have mentioned that the two lxc patches I just posted are built
on Dan B's patch. The order is this:
Dan's patch
lxc_start.patch
lxc_stop.patch
Thanks!
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mailing list
L
container child processes with it.
Thanks!
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
---
src/lxc_container.c | 19
src/lxc_driver.c| 77 ++--
2 files changed, 93 insertions(+), 3 deletions
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
---
src/Makefile.am |1
src/lxc_container.c | 324
src/lxc_container.h | 44 +++
src/lxc_driver.c| 211 +
4 fil
ntainer init.
>
Right. Need to understand how a devpts namespace impacts this before going too
much further down that path.
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
config file instead of 'lxc'.
Thanks, this looks great.
Back when I posted the first pass of these patches, you mentioned it should be
defaulted to enabled only on Linux. I'm not an autoconf expert (or intermediate
for that matter). How do we default the enabled parm based on th
go via the daemon. So nothing happens directly as a child of the
> calling application - its all in the context of the daemon.
>
> Dan.
Ok, so I'll remove the forks and clean up the status and state handling.
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Daniel Veillard wrote:
> On Thu, Mar 20, 2008 at 01:25:05PM -0400, Daniel Veillard wrote:
>> On Thu, Mar 20, 2008 at 10:20:22AM -0700, Dave Leskovec wrote:
>>> Daniel Veillard wrote:
>>>> I would rather keep the type attribute value small, and if possible
>>
Daniel Veillard wrote:
> On Wed, Mar 19, 2008 at 11:14:59PM -0700, Dave Leskovec wrote:
>> This patch adds the lxc_driver source files.
[...]
>> +static virDrvOpenStatus lxcOpen(virConnectPtr conn,
>> +
Daniel Veillard wrote:
> On Wed, Mar 19, 2008 at 11:14:15PM -0700, Dave Leskovec wrote:
>> This patch adds the base linux container support.
>
> Looks fine to me, with the only suggestion below:
>
>>
Daniel Veillard wrote:
> On Wed, Mar 19, 2008 at 11:13:44PM -0700, Dave Leskovec wrote:
>> Greetings,
>
> Hello,
>
>> Following are the patches adding linux container support. The first three
>
> Great ! The container/ldom support and the Java bindings are
utput once the buffer has filled. When a user does connect to the console,
they may get a flood of (potentially very) old data. It would be nice to be
able to provide some more recent output once someone connects to the console.
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open
This patch adds the lxc_driver source files.
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
---
src/lxc_driver.c | 484 +++
src/lxc_driver.h | 45 +
2 files changed, 529 insertions(+)
Index: b/src
This patch adds the lxc_conf source files.
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
---
src/lxc_conf.c | 942 +
src/lxc_conf.h | 142
2 files changed, 1084 insertions(+)
Index: b/src
This patch adds the base linux container support.
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
---
configure.in|6 ++
include/libvirt/virterror.h |1 +
src/Makefile.am |2 ++
src/driver.h|1
All comments and questions are welcome.
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
ly or feasible such a use would be. I can definitely agree with your
comments from a consumers perspective. I don't have a big problem with
moving to the block.
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Daniel P. Berrange wrote:
On Wed, Feb 20, 2008 at 10:24:18PM -0800, Dave Leskovec wrote:
A sample XML format that can be used to define a linux container domain:
TestContainer3
/usr/sbin
Daniel P. Berrange wrote:
On Wed, Feb 20, 2008 at 10:24:49PM -0800, Dave Leskovec wrote:
This patch contains the base linux container support
* new switch --with-lxc to enable support (off by default)
Any reason this can't be on-by-default ? I know OpenVZ is off by default
bu
Hi Jim,
Thanks for the comments. I'll go back to attaching patches rather than
putting them inline and make the other suggested changes.
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redha
You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ */
+
+#ifndef LXC_DRIVER_H
+#define LXC_DRIVER_H
+
+#include
+
+#ifdef WITH_LXC
+
+/* Function declarations */
+int lxcRegister(void);
+
+#endif /* WITH_LXC */
+
+#endif /* LXC_DRIVER_H */
+
+/*
+ * Local variables:
+ * indent-tabs-mode: nil
+ * c-indent-level: 4
+ * c-basic-offset: 4
+ * tab-width: 4
+ * End:
+ */
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
virConnectPtr conn,
+ lxc_driver_t *driver,
+ lxc_vm_t *vm,
+ lxc_vm_def_t *def);
+int lxcLoadDriverConfig(virConnectPtr conn);
+int lxcLoadContainerInfo(virConnectPtr conn);
+lxc_vm_t * lxcAssignVMDef(virConnectPtr conn,
+ lxc_driver_t *driver,
+ lxc_vm_def_t *def);
+char *lxcGenerateXML(virConnectPtr conn,
+ lxc_driver_t *driver,
+ lxc_vm_t *vm,
+ lxc_vm_def_t *def,
+ int live);
+lxc_vm_t *lxcFindVMByID(const lxc_driver_t *driver, int id);
+lxc_vm_t *lxcFindVMByUUID(const lxc_driver_t *driver,
+ const unsigned char *uuid);
+lxc_vm_t *lxcFindVMByName(const lxc_driver_t *driver,
+ const char *name);
+void lxcRemoveInactiveVM(lxc_driver_t *driver,
+ lxc_vm_t *vm);
+void lxcFreeVMs(lxc_vm_t *vms);
+void lxcFreeVM(lxc_vm_t *vm);
+void lxcFreeVMDef(lxc_vm_def_t *vmdef);
+int lxcDeleteConfig(virConnectPtr conn,
+lxc_driver_t *driver,
+const char *configFile,
+const char *name);
+
+void lxcError(virConnectPtr conn,
+ virDomainPtr dom,
+ int code, const char *fmt, ...)
+ATTRIBUTE_FORMAT(printf,4,5);
+
+#endif /* WITH_LXC */
+#endif /* LXC_CONF_H */
+
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
00
@@ -296,6 +296,9 @@ virDefaultErrorFunc(virErrorPtr err)
case VIR_FROM_STATS_LINUX:
dom = "Linux Stats ";
break;
+case VIR_FROM_LXC:
+dom = "LXC ";
+break;
}
if ((err->dom != NULL) && (err->
27;ve left out the network definition as I'll be tackling that a little
later on...
I'm currently working on starting a container.
Any and all questions and comments are welcome.
Thanks!
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mail
tory from some source
3. General purpose file management APIs
Less is more. We can trivially do step 1, but I'll punt on the others
unless we have clear compelling need from applications.
Dan.
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list ma
rage API design...
Dan.
:-) It would eliminate the need for mounts. Does it make more sense to
integrate into the storage API design or leave the separate container
specific mounts?
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mailing list
L
e in here with any thoughts he may have?
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Daniel Hokka Zakrisson wrote:
Dave Leskovec wrote:
Thanks! I added CLONE_NEWIPC and CLONE_NEWUTS. Adding CLONE_NEWUSER
caused clone() to fail. I'm looking into that.
Make sure you have CONFIG_USER_NS=y
That was a little weird. I verified that I had that flag set. I did
Daniel Hokka Zakrisson wrote:
Dave Leskovec wrote:
Attached is a simple program that uses the clone() function to create a
container. This is not intended as a patch - just an example of what
creating a Linux Container looks like. Something along these lines will
be used by the Linux
Daniel P. Berrange wrote:
On Thu, Jan 24, 2008 at 04:06:17PM -0800, Dave Leskovec wrote:
Attached is a simple program that uses the clone() function to create a
container. This is not intended as a patch - just an example of what
creating a Linux Container looks like. Something along
run the program as
root or the clone() call will fail.
Any questions or comments are welcome. Thanks!
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
/*
* Copyright IBM Corp. 2008
*
* lxc_exec.c: example on creating a linux container
*
* Authors:
* David L
1.110
browndog
192.168.1.1
192.168.1.1
255.255.255.0
65536
Any other comments or questions?
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redha
Daniel Hokka Zakrisson wrote:
Dave Leskovec wrote:
Thanks again for the feedback. I've made the following additional
recommended changes:
* Changed filesystem tag for consistency
* Changed network spec to match most recent OpenVZ format. The latest
OpenVZ format I could find was
file(s) or will it be stored somewhere
else by a resource management facility such that it can associated it
with a container after a reboot?
Balbir Singh wrote:
* Daniel P. Berrange <[EMAIL PROTECTED]> [2008-01-15 15:52:13]:
On Tue, Jan 15, 2008 at 12:26:43AM -0800, Dav
_init
192.168.1.110
browndog
192.168.1.1
192.168.1.1
255.255.255.0
As always, all comments and questions are welcome.
Daniel P. Berrange wrote:
On Tue, Jan 15, 2008 at 12:26:43AM -0800, Dave Leskovec wrote:
Greetings,
Foll
65536
Does this look ok now? All comments and questions are welcome.
--
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
ially since there's an existing implementation (Thanks Dan!).
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
Daniel P. Berrange wrote:
On Thu, Jan 03, 2008 at 10:07:39AM +0530, Shuveb Hussain wrote:
Hi,
How do you plan to maintain VM states across ba
initialization
script that would take care of starting the appropriate items for the
container.
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
Shuveb Hussain wrote:
Hi,
Will definitely be a great enhancement!
On Dec 28, 2007 2:04 PM, Dave Leskovec <[EMAIL PROTEC
table of
their choosing. Would your suggestion be to limit the user to specify a
single app and if they want to run multiple apps, they should specify an
init script?
I've looked quite a bit at the OpenVZ driver and will take a look at the
VServer reference you provided.
Best Reg
r. All comments and
questions are welcome.
Best Regards,
Dave Leskovec
IBM Linux Technology Center
Open Virtualization
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
75 matches
Mail list logo