Re: [libvirt] [PATCH] Remove phyp driver

2020-01-08 Thread Eduardo Otubo
1133,7 @@ virHostCPUGetThreadsPerSubcore(virArch arch) > > goto out; > > } > > > > -/* For Phyp and KVM based guests the ioctl for KVM_CAP_PPC_SMT > > +/* For KVM based guests the ioctl for KVM_CAP_PPC_SMT > > *

Re: [libvirt] [PATCH 0/1] Bug: Sandbox: libvirt breakdowns qemu guest

2018-05-07 Thread Eduardo Otubo
=== > > Wrap the options except 'enable' for qemu_sandbox_opts by CONFIG_SECCOMP. > > > > Yi Min Zhao (1): > > sandbox: avoid to compile options if CONFIG_SECCOMP undefined > > > > vl.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > -- Eduardo Otubo -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Add Eduardo Otubo to Planet Virt-Tools

2018-01-18 Thread Eduardo Otubo
Adding Eduardo Otubo's blog information and avatar to config.ini at Planet Virt-Tools. Signed-ff-by: Eduardo Otubo --- updater/virt-tools/config.ini | 6 ++ updater/virt-tools/images/otubo.png | Bin 0 -> 10597 bytes 2 files changed, 6 insertions(+) create mode 100644 upda

Re: [libvirt] RFC: Drop unmaintained hv drivers? (phyp, xenapi, hyperv)

2016-04-18 Thread Eduardo Otubo
r dropping them > > > src/phyp/ : for power VM hypervisor. Added in July 2009. The last commit that > looks like it wasn't either internal API conversion, or caught by code > analysis, is: > > commit 41461ff7f7d6ee6679aae2a8004e305c5830c9e8 > Author: Eduardo Otubo > Date

Re: [libvirt] [PATCH] docs: rudimentary phyp documentation

2012-10-01 Thread Eduardo Otubo
internally, so phyp+ssh would be redundant. > + > + > +URI Format > + > +URIs have this general form ([...] marks an > +optional part, {...|...} marks a mandatory choice). > + > + > +phyp://[username@]{hmc|ivm}/managed_system Actually, in th

Re: [libvirt] SIGTERM undeclared, virNetSocketFree

2011-06-30 Thread Eduardo Otubo
libvirt-0.9.3/daemon' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/home/jhelfman/ports/devel/libvirt/work/libvirt-0.9.3' gmake: *** [all] Error 2 *** Error code 1 Same behaviour here. Talking in the IRC, we figured out --without-sasl tries to disable the use of sas

[libvirt] [PATCH] PHYP: Adding reboot domain function

2011-04-19 Thread Eduardo Otubo
Adding reboot function for pHyp driver. --- src/phyp/phyp_driver.c | 35 ++- 1 files changed, 34 insertions(+), 1 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index bb0e0ac..228751d 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/

[libvirt] [PATCHv6] PHYP: Adding network interface

2011-03-28 Thread Eduardo Otubo
This is the implementation of the previous patch now using virInterface* API. Ended up this patch got much more simpler, smaller and easier to review. Here is some details: * MAC size and interface name are fixed due to specifications on HMC, both are created automatically and CAN'T be speci

Re: [libvirt] [PATCHv5] PHYP: Adding network interface management

2011-03-28 Thread Eduardo Otubo
" -p %s -o r -s %d", def->name, slot); + +if (virBufferError(&buf)) { +virBufferFreeAndReset(&buf); +virReportOOMError(); +goto err; +} +goto err; + } + + char_ptr = strchr(ret, '\n'); + +memcpy(na

[libvirt] [PATCHv5] PHYP: Adding network interface management

2011-02-16 Thread Eduardo Otubo
This is the implementation of the previous patch now using virInterface* API. Ended up this patch got much more simpler, smaller and easier to review. Here is some details: * MAC size and interface name are fixed due to specifications on HMC, both are created automatically and CAN'T be speci

Re: [libvirt] [PATCHv4] PHYP: Adding network interface management

2011-02-15 Thread Eduardo Otubo
On 01/14/2011 10:07 PM, Eric Blake wrote: On 12/29/2010 11:04 AM, Eduardo Otubo wrote: This is the implementation of the previous patch now using virInterface* API. Ended up this patch got much more simpler, smaller and easier to review. Here is some details: Finally getting around to

Re: [libvirt] [PATCHv4] PHYP: Adding network interface management

2011-01-13 Thread Eduardo Otubo
Any chance to get a review for the next release? Thanks a lot :-) Regards, On 12/29/2010 04:04 PM, Eduardo Otubo wrote: This is the implementation of the previous patch now using virInterface* API. Ended up this patch got much more simpler, smaller and easier to review. Here is some details

[libvirt] [PATCHv4] PHYP: Adding network interface management

2010-12-29 Thread Eduardo Otubo
This is the implementation of the previous patch now using virInterface* API. Ended up this patch got much more simpler, smaller and easier to review. Here is some details: * MAC size and interface name are fixed due to specifications on HMC, both are created automatically and CAN'T be speci

Re: [libvirt] [PATCHv3] PHYP: Adding network interface management

2010-12-29 Thread Eduardo Otubo
On 12/14/2010 02:27 PM, Eric Blake wrote: On 12/13/2010 01:09 PM, Eduardo Otubo wrote: This is the implementation of the previous patch now using virInterface* API. Ended up this patch got much more simpler, smaller and easier to review. Here is some details: You may want to use --enable

[libvirt] [PATCHv3] PHYP: Adding network interface management

2010-12-13 Thread Eduardo Otubo
This is the implementation of the previous patch now using virInterface* API. Ended up this patch got much more simpler, smaller and easier to review. Here is some details: * MAC size and interface name are fixed due to specifications on HMC, both are created automatically and CAN'T be speci

Re: [libvirt] [PATCHv2] PHYP: Adding network interface management

2010-12-13 Thread Eduardo Otubo
On 12/09/2010 07:16 PM, Eric Blake wrote: On 11/22/2010 06:03 PM, Eduardo Otubo wrote: Apologies for my review backlog (if you haven't guessed, I sometimes table big patches for later, then forget to come back rapidly). No problem, I'll try to post earlier next time. Thanks anyway

Re: [libvirt] [PATCHv2] PHYP: Adding network interface management

2010-12-08 Thread Eduardo Otubo
Sorry for the tops posting, but I was wondering if someone could take a look at my patch v2, thanks. Regards, On 11/22/2010 11:03 PM, Eduardo Otubo wrote: This is the implementation of the previous patch now using virInterface* API. Ended up this patch got much more simpler, smaller and

[libvirt] [PATCHv2] PHYP: Adding network interface management

2010-11-22 Thread Eduardo Otubo
This is the implementation of the previous patch now using virInterface* API. Ended up this patch got much more simpler, smaller and easier to review. Here is some details: * MAC size and interface name are fixed due to specifications on HMC, both are created automatically and CAN'T be specifi

Re: [libvirt] [PATCH 1/3] PHYP: Separating UUID functions in another file

2010-11-22 Thread Eduardo Otubo
On 11/19/2010 07:37 PM, Eric Blake wrote: On 11/19/2010 07:55 AM, Eduardo Otubo wrote: I am moving all the UUID handling functions to phyp_uuid.[ch] files in order not to bloat the main files phyp_driver.[ch] too much. Doing this for two reasons: 1) Network management in pHyp does not

Re: [libvirt] [PATCH 0/3] PHYP: Adding network management support

2010-11-22 Thread Eduardo Otubo
On 11/22/2010 12:52 PM, Daniel P. Berrange wrote: On Fri, Nov 19, 2010 at 12:55:03PM -0200, Eduardo Otubo wrote: This is a series of 3 patches to add network management support for pHyp driver. Can you explain what sort of network connectivity you are managing here ? The virNetwork APIs are

[libvirt] [PATCH 3/3] PHYP: create, destroy and other network functions

2010-11-19 Thread Eduardo Otubo
Adding networkCreateXML, networkDestroy, networkIsActive and networkLookupByName. In the function phypCreateNetwork I just use the def->domain information to create the new network interface because of the behaviour of the HMC and the hypervisor: * HMC can't simply create a network interfa

[libvirt] [PATCH 2/3] PHYP: Adding basic network functions

2010-11-19 Thread Eduardo Otubo
Now adding some basic operation network functions and its UUID "helpers". --- src/phyp/phyp_driver.c | 202 ++- src/phyp/phyp_uuid.c | 177 ++ src/phyp/phyp_uuid.h |8 ++ 3 files changed, 382 insertions(+

[libvirt] [PATCH 1/3] PHYP: Separating UUID functions in another file

2010-11-19 Thread Eduardo Otubo
nt phypNumDomainsGeneric(virConnectPtr conn, unsigned int type); + +int phypListDomainsGeneric(virConnectPtr conn, int *ids, int nids, + unsigned int type); + +int waitsocket(int socket_fd, LIBSSH2_SESSION * session); + +int phypNumOfNetworks(virConnectPtr conn);

[libvirt] [PATCH 0/3] PHYP: Adding network management support

2010-11-19 Thread Eduardo Otubo
This is a series of 3 patches to add network management support for pHyp driver. Eduardo Otubo (3): PHYP: Separating UUID functions in another file PHYP: Adding basic network functions PHYP: create, destroy and other network functions po/POTFILES.in |1 + src/Makefile.am

Re: [libvirt] [PATCH] PHYP: Bad comparison when checking for existing domain name

2010-08-25 Thread Eduardo Otubo
On 08/17/2010 04:04 PM, Eduardo Otubo wrote: When creating a new domain from an XML, the check for an existing domain name should compare the return of the function to a a valid LPAR ID (!= -1) and not to error (== -1). --- src/phyp/phyp_driver.c |2 +- 1 files changed, 1 insertions(+), 1

[libvirt] [PATCHv3] PHYP: Checking for NULL values when building new guest

2010-08-25 Thread Eduardo Otubo
When creating a new gust, the function phypBuildLpar() was not checking for NULL values, making the driver to have a segmentation fault. --- src/phyp/phyp_driver.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp

Re: [libvirt] [PATCH] PHYP: Checking for NULL values when building new guest

2010-08-24 Thread Eduardo Otubo
0, then ERROR. Right? If not, could you explain the reasons? Thanks, -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19 8135 0885 eot...@linux.vnet.ibm.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCHv2] PHYP: Checking for NULL values when building new guest

2010-08-23 Thread Eduardo Otubo
I fixed the way I check for invalid values and changed the way I report errors (from VIR_ERROR0 to PHYP_ERROR). I'll change the VIR_WARNs in another different patch. --- src/phyp/phyp_driver.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/src/phyp/

[libvirt] [PATCH] PHYP: Checking for NULL values when building new guest

2010-08-20 Thread Eduardo Otubo
When creating a new gust, the function phypBuildLpar() was not checking for NULL values, making the driver to have a segmentation fault. --- src/phyp/phyp_driver.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_dri

[libvirt] [PATCH] PHYP: Bad comparison when checking for existing domain name

2010-08-17 Thread Eduardo Otubo
When creating a new domain from an XML, the check for an existing domain name should compare the return of the function to a a valid LPAR ID (!= -1) and not to error (== -1). --- src/phyp/phyp_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/phyp/phyp_driver.c

[libvirt] [PATCH] PHYP: Add rudimentary network driver

2010-08-12 Thread Eduardo Otubo
I changed virStorage[Open|Close] to virVIOSDriver[Open|Close] so the network driver can use it - since the network driver deals with Open/Close in the same way. --- src/phyp/phyp_driver.c | 33 + 1 files changed, 29 insertions(+), 4 deletions(-) diff --git a/src/

Re: [libvirt] [PATCH] phyp: Fixing possible buffer overflow

2010-08-06 Thread Eduardo Otubo
On 08/05/2010 04:04 PM, Laine Stump wrote: On 08/04/2010 03:00 PM, Eduardo Otubo wrote: Hello Laine, It's been quite a while since we had this discussion about my patch. Sorry about the delay on replaying, I had a congress and I've been sick in the last couple of days. Now going ba

Re: [libvirt] [PATCH] phyp: Fixing possible buffer overflow

2010-08-04 Thread Eduardo Otubo
ng as we're fixing this function, we may as well fix it in the best way possible. I just saw your patch now, seem reasonable. I understand your points and I believe your patch fixes the bug pretty well. Applied here, compiled and run with some tests, seems pretty ack for me. Thanks fo

Re: [libvirt] [RFC] Slides for FISL presentation

2010-07-16 Thread Eduardo Otubo
On 07/16/2010 04:22 AM, Eduardo Otubo wrote: Hello all, This is the first draft for my presentation at FISL. I would like you to take a look and give your opinions. Any comment is always welcome :-) Thank you! https://docs.google.com/leaf?id

[libvirt] [RFC] Slides for FISL presentation

2010-07-16 Thread Eduardo Otubo
now where to put the file, I hosted at google docs and made it public. You all should be able to download it. Any issues, please let me know. Thanks again. -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19 8135 0885 eot...@linux.vnet.ibm.c

Re: [libvirt] [PATCH] phyp: Fixing possible buffer overflow

2010-07-16 Thread Eduardo Otubo
On 07/15/2010 11:01 PM, Laine Stump wrote: On 07/15/2010 06:37 PM, Eduardo Otubo wrote: The line src/phyp/phyp_driver.c:427 was crashing by buffer overflow if the return of the command wasn't<=10. The highest number for a LPAR ID is 256 per machine, no need to allocate 10 bytes fo

[libvirt] [PATCH] phyp: Fixing possible buffer overflow

2010-07-15 Thread Eduardo Otubo
The line src/phyp/phyp_driver.c:427 was crashing by buffer overflow if the return of the command wasn't <=10. The highest number for a LPAR ID is 256 per machine, no need to allocate 10 bytes for it. So, adjusting the correct size (+1 byte for the '\n') and checking for errors. --- src/phyp/phyp_

Re: [libvirt] [PATCHv3 4/4] phyp: optimize use of sed

2010-06-24 Thread Eduardo Otubo
f(&buf, " -F name,state" + "|sed -n '/Not Activated/ {\n s/,.*$//\n p\n}'"); if (virBufferError(&buf)) { virBufferFreeAndReset(&buf); virReportOOMError(); I tested each sed expression on HMC shell, all of

Re: [libvirt] [PATCHv3 3/4] phyp: add storage management driver

2010-06-24 Thread Eduardo Otubo
On 06/24/2010 07:32 PM, Eric Blake wrote: From: Eduardo Otubo Add the storage management driver to the Power Hypervisor driver. This is a big but simple patch, it's just a new set of functions. This patch includes: * Storage driver: The set of pool-* and vol-* functions. * attach

Re: [libvirt] [PATCHv3 2/4] phyp: add rudimentary storage driver

2010-06-24 Thread Eduardo Otubo
On 06/24/2010 07:32 PM, Eric Blake wrote: From: Eduardo Otubo * src/phyp/phyp_driver.c (phypStorageDriver): New driver. (phypStorageOpen, phypStorageClose): New functions. (phypRegister): Register it. Signed-off-by: Eric Blake --- For my sanity, I split out the creation/registration of the

Re: [libvirt] [PATCHv3 1/4] phyp: reduce scope of driver functions

2010-06-24 Thread Eduardo Otubo
are of that and was planning a future patch with these changes. If you thought that would be better to clean these up early it's ok too. Thank you very much. The patch seems ok. I tested the commands with my HMC/VIOS and IVM and everything is still working. Thanks. ACK. []'s -- Eduard

[libvirt] [PATCH 1/2] Adding Storage Management driver (semantic changes)

2010-06-23 Thread Eduardo Otubo
This is the first patch, just over the semantic changes over the code itself. Added the whole storage management stack and fixed the echo $(( expr)) to just increment the variable in the return of the function. Hope we can get it acknowledged in time for the next release :) Thanks for all the comm

[libvirt] [PATCH 2/2] Adding Storage Management driver (style and indentation)

2010-06-23 Thread Eduardo Otubo
This is just the indentation, style and cleanup patch. --- src/phyp/phyp_driver.c | 100 +++ src/phyp/phyp_driver.h | 13 -- 2 files changed, 66 insertions(+), 47 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 5

Re: [libvirt] [PATCH] phyp: Adding Storage Management driver (comments fixed)

2010-06-23 Thread Eduardo Otubo
her hand, I agree that this still seems like something worth getting in 0.8.2 if we can clean it up fast enough. Do you need any help separating the patch into separate stages? I'll separate the identation from the semantic code right away. Thanks for the suggestion :) -- Eduardo Otubo

[libvirt] [PATCH] phyp: Adding Storage Management driver (comments fixed)

2010-06-21 Thread Eduardo Otubo
All the comments from the previous email from Eric Blake are now fixed. Also fixed some styling by using indent on the whole file. Hope we can get this patch pushed to 0.8.2. Any additional comments are always welcome. []'s --- src/phyp/phyp_driver.c | 395 +++

Re: [libvirt] [PATCH] phyp: Adding storage management driver

2010-06-21 Thread Eduardo Otubo
On 06/21/2010 05:05 PM, Eric Blake wrote: On 06/21/2010 12:32 PM, Eduardo Otubo wrote: Ouch. If the result of the `` command substitution begins with 0, you have a problem with octal numbers. Remember, $((010 + 1)) is not the same as $((10 + 1)). Perhaps you can modify the sed commands used

Re: [libvirt] [PATCH] phyp: Adding storage management driver

2010-06-21 Thread Eduardo Otubo
const char *xml, + unsigned int flags ATTRIBUTE_UNUSED) +{ + +virStoragePoolDefPtr def = NULL; +virStoragePoolPtr sp = NULL; virCheckFlags(0, NULL) (won't comment on it any more for this round of review...) +virStoragePoolPtr +phypGetStoragePoolLookUpByUUID(virConnectPtr conn, + const unsigned char *uuid) +{ ... +if (STREQLEN((char *) local_uuid, (char *) uuid, VIR_UUID_BUFLEN)) { Here, it is simpler to avoid the casts, by doing: if (!memcmp(local_uuid, uuid, VIR_UUID_BUFLEN)) { It also matches existing style in the rest of libvirt ('git grep "STREQLEN.*VIR_UUID"' vs. 'git grep -i "cmp.*VIR_UUID_BUFLEN"'). Ok. +int +phypNumOfStoragePools(virConnectPtr conn) +{ +} else { +virBufferVSprintf(&buf, "lsvg"); +} +virBufferVSprintf(&buf, "grep -c '^.*$'"); Missing a '|' before the grep. Ok. +} + +phypStorageOpen(virConnectPtr conn ATTRIBUTE_UNUSED, +virConnectAuthPtr auth ATTRIBUTE_UNUSED, +int flags ATTRIBUTE_UNUSED) Add a newline between the closing } of one function and the start of another. Overall, my review was mainly focused on style and shell portability. I don't have access to a phyp setup at the moment, so I can't really test if your various command lines make sense (I'm assuming they do). Towards the end, I kept on spotting (and ignoring) the same issues again, so remember to do global searches when addressing a comment, rather than just at the place where I made the comment. But in general, this looks promising, and hopefully we can get things turned around fast enough to decide whether this is worth including in libvirt 0.8.2. All the commands are tested and studied directly on the HMC/VIOS and IVM befores inserting on C code, so they really work :) All the issues you pointed were fixed in all worldwide code (not just the storage driver) Will send another patch right away after reading all the comments and making all the properly fixes. Thanks for all the comments! -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19 8135 0885 eot...@linux.vnet.ibm.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] phyp: Adding storage management driver

2010-06-18 Thread Eduardo Otubo
Hello Folks, This is the result of a couple of months of hard work. I added the storage management driver to the Power Hypervisor driver. This is a big but simple patch, it's just a new set of functions, nothing more. I could split it into multiple commits, but the feature freeze starts in some

Re: [libvirt] [PATCHv3] phyp: adding support for IVM

2010-06-16 Thread Eduardo Otubo
On 06/16/2010 07:04 PM, Eric Blake wrote: From: Eduardo Otubo Use virBuffer* API to contionally keep the portion of the command line specific to HMC, so that IVM can work. --- This starts from Eduardo's patch, then converts everything away from using double virAsprintf (in the HVM case)

Re: [libvirt] [PATCH] Assing support for IVM

2010-06-16 Thread Eduardo Otubo
On 06/16/2010 04:22 PM, Eduardo Otubo wrote: Fixing all pointed in the previous email. Thanks for all the comments. --- src/phyp/phyp_driver.c | 356 +--- src/phyp/phyp_driver.h |8 + 2 files changed, 252 insertions(+), 112 deletions(-) diff

[libvirt] [PATCH] Assing support for IVM

2010-06-16 Thread Eduardo Otubo
Fixing all pointed in the previous email. Thanks for all the comments. --- src/phyp/phyp_driver.c | 356 +--- src/phyp/phyp_driver.h |8 + 2 files changed, 252 insertions(+), 112 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_dri

Re: [libvirt] [PATCH] phyp: sed cleanups

2010-06-16 Thread Eduardo Otubo
f (&cmd, "chhwres -r proc -m %s --id %d -o %c --procunits %d 2>&1 |sed" - "-e 's/^.*\\([0-9]\\+.[0-9]\\+\\).*$/\\1/g'", + "-e 's/^.*\\([0-9][0-9]*.[0-9][0-9]*\\).*$/\\1/'", managed_system,

[libvirt] [PATCH] Adding support for IVM

2010-06-04 Thread Eduardo Otubo
Adding support for the IBM IVM Virtualization system under Power Hypervisor. --- src/phyp/phyp_driver.c | 644 ++-- src/phyp/phyp_driver.h |8 + 2 files changed, 471 insertions(+), 181 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/ph

[libvirt] FISL 11 - Abstract submited

2010-06-01 Thread Eduardo Otubo
hould talk about Libvirt as well, almost on the same way of FISL, some high level information and then some internals. So, I am opening this topic for comments and ideas. Any kind of help will be very welcome :) Thanks, [1] - http://softwarelivre.org/fisl11 -- Eduardo Otubo Software Engi

[libvirt] [PATCH] Strict check when listing domains

2010-06-01 Thread Eduardo Otubo
Now sending patches using format-patch and send-email, pretty interesting! This is the final version, fixing the style according to the new HACKING file. --- src/phyp/phyp_driver.c | 34 ++ 1 files changed, 14 insertions(+), 20 deletions(-) diff --git a/src/phyp

Re: [libvirt] [PATCH] Strict check when listing domains

2010-06-01 Thread Eduardo Otubo
uid_table->nlpars = nids_listdomains; /* try to get the table from server */ if (phypUUIDTable_Pull(conn) == -1) { -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19 8135 0885 eot...@linux.vnet.ibm.com -- libvir-list mailing

[libvirt] vol-list and other vol-* functions

2010-05-31 Thread Eduardo Otubo
get the path and there's some I can't, hence, I can't get LookUpByPath() function implemented correctly. Any ideas? Thanks, -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19 8135 0885 eot...@linux.vnet.ibm.com -- libvir-li

Re: [libvirt] [PATCH] phyp: first part of storage management driver

2010-05-25 Thread Eduardo Otubo
On 05/24/2010 09:27 PM, Stefan Berger wrote: Eduardo Otubo wrote on 05/18/2010 05:01:40 PM: > Please respond to otubo > > On 05/14/2010 05:27 PM, Stefan Berger wrote: > > > + > > > +virStoragePoolPtr > > > +phypSPLookupByName(vir

Re: [libvirt] [PATCH] build: fix HTML errors in nwfilter docs

2010-05-25 Thread Eduardo Otubo
|| ^ * docs/formatnwfilter.html.in: Fix invalid HTML constructs. Reported by Eduardo Otubo. Tested on my Ubuntu 10.04. ACK. --- Don't know why a build on Fedora didn't catch these, so I won't push until I get an ack that this fixes things on

[libvirt] [PATCH] virDrvStorageVolLookupByKey and virDrvStorageVolLookupByPath should use virStoragePoolPtr as parameter

2010-05-24 Thread Eduardo Otubo
) Functions now are able to access pool structure. This is particularly important for the optimization of the PowerHypervisor phypVolumeLookupByKey function. Thanks, -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19 8135 0885

Re: [libvirt] [PATCH] phyp: first part of storage management driver

2010-05-18 Thread Eduardo Otubo
err: +for (i = 0; i < got; i++) +VIR_FREE(pools[i]); +VIR_FREE(cmd); + VIR_FREE(ret); +return -1; +} + +virDrvOpenStatus +phypStorageOpen(virConnectPtr conn ATTRIBUTE_UNUSED, +virConnectAuthPtr auth ATTRIBUTE_UNUSED, +int flags ATTRIBUTE_UNUSED

[libvirt] [PATCH] phyp: first part of storage management driver

2010-05-13 Thread Eduardo Otubo
Hello all, This is the first patch about storage management driver on IBM Power Hypervisor. I reviewd a couple of times but perhaps I might be missing something. Any comments are welcome. []'s -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Gro

Re: [libvirt] [PATCH] Strict check when listing domains

2010-03-29 Thread Eduardo Otubo
I am really sorry. I sent an older version of the patch, here is the correct one. Eric Blake wrote: On 03/24/2010 11:19 AM, Eduardo Otubo wrote: /* exit early if there are no domains */ -if (nids == 0) +if (nids_numdomains == 0 || nids_listdomains == 0

[libvirt] [PATCH] Strict check when listing domains

2010-03-24 Thread Eduardo Otubo
-- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19 8135 0885 eot...@linux.vnet.ibm.com diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index e4d67dc..f9a36a1 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driv

[libvirt] [PATCH] phyp: too much timeout when polling socket

2009-11-10 Thread Eduardo Otubo
ch is more important than it seems, now I can write a script (using virsh) to test all the phyp features. Thanks! []'s -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19 8135 0885 eot...@linux.vnet.ibm.com diff --git a/src/phyp/phyp_

Re: [libvirt] [PATCH] phyp: ssh authentication with pub keys fixed

2009-11-10 Thread Eduardo Otubo
Eduardo Otubo wrote: Matthias Bolte wrote: 2009/11/9 Eduardo Otubo : Matthias Bolte wrote: diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index a92046a..f96d2d6 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c [...] @@ -282,10 +297,8 @@ openSSHSession

Re: [libvirt] [PATCH] phyp: ssh authentication with pub keys fixed

2009-11-09 Thread Eduardo Otubo
Matthias Bolte wrote: 2009/11/9 Eduardo Otubo : Matthias Bolte wrote: diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index a92046a..f96d2d6 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c [...] @@ -282,10 +297,8 @@ openSSHSession(virConnectPtr conn

Re: [libvirt] [PATCH] phyp: ssh authentication with pub keys fixed

2009-11-09 Thread Eduardo Otubo
(pvtkey); VIR_FREE(password); return NULL; exit: +VIR_FREE(userhome); VIR_FREE(pubkey) is missing here, it's there in the first version of this patch. Ok. Thanks again :) []'s -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Grou

Re: [libvirt] [PATCH] phyp: ssh authentication with pub keys fixed

2009-11-07 Thread Eduardo Otubo
Matthias Bolte wrote: 2009/11/6 Eduardo Otubo : +char *pubkey = NULL; +char *pvtkey = NULL; + +if (virAsprintf(&pubkey, "%s/.ssh/id_rsa.pub", getenv("HOME")) < 0) { +virReportOOMError(conn); +goto err; +} + +if (virAsprintf(&p

Re: [libvirt] [PATCH] create() and destroy() support for Power Hypervisor

2009-11-03 Thread Eduardo Otubo
D_BUFLEN because write() may write less bytes than requested. +close(fd); +return 0; + + err: +close(fd); +return -1; +} + You fixed most issues in this version of the patch, but some memory leaks are still there. All the other things are fixed. Thanks for all the comments. []

Re: [libvirt] [PATCH] create() and destroy() support for Power Hypervisor

2009-10-30 Thread Eduardo Otubo
to operate a HMC/IVM IBM system. This saves a lot of (useless) coding time for me :) * I solved all the other issues Matthias pointed. Next steps: * Find a better way to handle the uuid_table files without the need of use local temp files. * Storage management. Any comments

Re: [libvirt] [PATCH] create() and destroy() support for Power Hypervisor

2009-10-28 Thread Eduardo Otubo
Daniel Veillard wrote: On Mon, Oct 19, 2009 at 03:53:14PM -0200, Eduardo Otubo wrote: Mark McLoughlin wrote: On Tue, 2009-10-06 at 05:12 -0300, Eduardo Otubo wrote: I've been told that libvirt possibly would make a mini-release this week to push some major fixes on Fedora 12. F12 is f

Re: [libvirt] [PATCH] create() and destroy() support for Power Hypervisor

2009-10-19 Thread Eduardo Otubo
Mark McLoughlin wrote: On Tue, 2009-10-06 at 05:12 -0300, Eduardo Otubo wrote: I've been told that libvirt possibly would make a mini-release this week to push some major fixes on Fedora 12. F12 is frozen and there has been significant changes since 0.7.1; we don't have any immediat

[libvirt] [PATCH] create() and destroy() support for Power Hypervisor

2009-10-06 Thread Eduardo Otubo
there a little possibility to push these new phyp features too? This would be very important for the phyp project, since this functions are not just to manage partitions but manipulate them. Any comments are always welcome. []'s -- Eduardo Otubo Software Engineer Linux Technolog

Re: [libvirt] [PATCH] Power Hypervisor now with libssh2

2009-09-21 Thread Eduardo Otubo
Daniel Veillard wrote: On Wed, Aug 26, 2009 at 03:53:01AM -0300, Eduardo Otubo wrote: Hello friends, This is the new version of phyp driver now using libssh2. I also did some other changes: * Added some debug information. Sometimes its worth to know which command is being executed and

[libvirt] [PATCH] Power Hypervisor now with libssh2

2009-08-25 Thread Eduardo Otubo
7;ll be on vacations from 26th/august to 14th/september. I'll check my emails in the meanwhile, but no so often. Anyway, any comments on this patch are always welcome :) []'s -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19 813

Re: [libvirt] Power Hypervisor: Fix potential segfault and memleak in phypOpen

2009-08-14 Thread Eduardo Otubo
atch is compile-tested but I don't have a Power > > Hypervisor installation at hand to test it for real. > > I also don't have a Power Hypervisor, but it looks sane enough to me. I'll > say > ACK, but it's probably a good idea to get someone who has Power to

Re: [libvirt] [PATCH] Power Hypervisor support

2009-07-24 Thread Eduardo Otubo
On Fri, 2009-07-24 at 16:42 +0200, Daniel Veillard wrote: > On Wed, Jul 22, 2009 at 04:01:47PM -0300, Eduardo Otubo wrote: > > Hello everyone, > > > > This should be the official patch for the libvrt-0.7.0 release. Here > > I'll comment all the features alread

Re: [libvirt] [PATCH] Power Hypervisor support

2009-07-24 Thread Eduardo Otubo
On Thu, 2009-07-23 at 21:52 +0100, Daniel P. Berrange wrote: > On Wed, Jul 22, 2009 at 04:01:47PM -0300, Eduardo Otubo wrote: > > Hello everyone, > > > > This should be the official patch for the libvrt-0.7.0 release. Here > > I'll comment all the features alread

[libvirt] [PATCH] Power Hypervisor support

2009-07-22 Thread Eduardo Otubo
;list' and 'list --all' What is being implemented: * better and centralized control for UUID * definexml * CPU management commands Any comment are always welcome. []'s -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19

Re: [libvirt] [PATCH] Power Hypervisor Support for libvirt - minimum set of features

2009-07-06 Thread Eduardo Otubo
Hello all, This is the last version of this enormous PATCH. All minor bugs are fixed, and the minimal set of features are implemented. Any comments are alwayes welcome. []'s On Tue, 2009-06-23 at 10:55 -0300, Eduardo Otubo wrote: > Hello again, > > This is the life cycle operat

Re: [libvirt] [PATCH] Power Hypervisor Support for libvirt - minimum set of features

2009-06-29 Thread Eduardo Otubo
And all the other comments you did are now fixed. Thanks. (and sorry for the top posting) []'s On Mon, 2009-06-29 at 10:44 +0100, Daniel P. Berrange wrote: > On Mon, Jun 22, 2009 at 06:57:19PM -0300, Eduardo Otubo wrote: > > Hello all, > > > > This is the initial pa

Re: [libvirt] [PATCH] Power Hypervisor Support for libvirt - minimum set of features

2009-06-29 Thread Eduardo Otubo
efined, if not just create a new UUID for that lpar. But, in this case, virsh/libvirtd could be run from anywhere, so the xml file would be in other machine and so on. Then I thought I could create the XML in HMC's machine, then I would have a little more control of the UUIDs. What do you thi

Re: [libvirt] [PATCH] Power Hypervisor Support for libvirt - minimum set of features

2009-06-23 Thread Eduardo Otubo
Hello again, This is the life cycle operations I've been working on these days. Fortunately this is a smaller and more punctual diff. :) Any comment is always welcome. []'s On Mon, 2009-06-22 at 18:57 -0300, Eduardo Otubo wrote: > Hello all, > > This is the initial patch

[libvirt] [PATCH] Power Hypervisor Support for libvirt - minimum set of features

2009-06-22 Thread Eduardo Otubo
TODO list is now set to implement life cycle functions. Thanks in advance, []'s -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19 8135 0885 ot...@linux.vnet.ibm.com diff --git a/configure.in b/configure.in index 552c761..2

[libvirt] Libtool problem

2009-06-03 Thread Eduardo Otubo
f you guys could help me understanding this issue I would be very glad. Thanks, []'s -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19 8135 0885 ot...@linux.vnet.ibm.com -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-05-15 Thread Eduardo Otubo
; > > static virDomainPtr > > phypDomainLookupByName(virConnectPtr conn, const char *name) > > { > > SSH_SESSION *ssh_session = conn->privateData; > > virDomainPtr dom = NULL; > > > > int lpar_id = 0; > > int exit_status = 0; > >

[libvirt] Usage of UUID

2009-05-15 Thread Eduardo Otubo
he user decides to define it at libvirt. Am I thinking right? Thanks for the help. []'s -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19 8135 0885 ot...@linux.vnet.ibm.com -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-05-08 Thread Eduardo Otubo
Em Qua, 2009-05-06 às 09:44 +0100, Daniel P. Berrange escreveu: > On Mon, May 04, 2009 at 05:50:03PM -0300, Eduardo Otubo wrote: > > > > > > + > > > > +/* return the lpar_id given a name and a managed system name */ > > > > +static int > > >

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-05-06 Thread Eduardo Otubo
Em Qua, 2009-05-06 às 09:26 +0200, Daniel Veillard escreveu: > On Mon, May 04, 2009 at 05:50:03PM -0300, Eduardo Otubo wrote: > > Hello DV, > > Hi Eduardo, > > sorry for the delay I took a few days of vacations :-) Hello DV, Nice! Hope you enjoyed your vacations :

Re: [libvirt] Authentication with virConnectAuthPtr

2009-05-06 Thread Eduardo Otubo
virRaiseError() to adjust all the error messages into libvirt pattern. the modified function I made based on your sample code. Thanks for the help. []'s Em Ter, 2009-05-05 às 21:50 +0100, Daniel P. Berrange escreveu: > On Tue, May 05, 2009 at 04:06:12PM -0300, Eduardo Otubo wrote: >

[libvirt] Authentication with virConnectAuthPtr

2009-05-05 Thread Eduardo Otubo
no driver authenticatin agaist ssh channel, that's why I got so confused with this topic. I don't know if my thoughts are pretty clear here. But I would like to confirm the information 2 and 3, and check how 1 works. Could anyone help me? Thanks in advance, []'s -- Eduardo Ot

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-05-04 Thread Eduardo Otubo
h the data. Here youre just leaking memory >I'm afraid > > same thing for most of the commands in that file. Here, I just would like to free the Buffer, and this was the best way I find since I couldn't find any better function to manipulate this. How do I simply free a

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-04-23 Thread Eduardo Otubo
codes. * Logging and debugging messages. Any comments are welcome, []'s Em Sex, 2009-03-20 às 13:58 -0300, Eduardo Otubo escreveu: > Hello all, > > I've been working on a libvirt extension to manage IBM's Power VMs > (LPARs). The Power systems are managed through manageme

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-04-06 Thread Eduardo Otubo
dern standards. In their words "can't agree more with him. SSH1 support was made initialy to support old cisco routers". All of these issues will be available in the libssh-0.3, which will be released in the end of this week, 10/april. Do you think after all these changes libssh will

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-03-31 Thread Eduardo Otubo
cause it cannot be considered > secure by modern standards. I see no problem on changing my code to libssh2, I may change it and send another patch/rfc. Regards, -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19 8135 0885 ot...@linux.vnet.ibm.com -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-03-27 Thread Eduardo Otubo
> > AC_MSG_NOTICE([ LXC: $with_lxc]) > > +AC_MSG_NOTICE([ IBM HMC/IVM: $with_phyp]) > > AC_MSG_NOTICE([Test: $with_test]) > > AC_MSG_NOTICE([ Remote: $with_remote]) > > AC_MSG_NOTICE([ Network: $with_network]) > > Can you either shortern this to just '

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-03-27 Thread Eduardo Otubo
ill need to keep them as I did. > > > > + > > +if (VIR_ALLOC_N(lpar_name, 100 * sizeof(char))) > > +return NULL; > > + > > +if (VIR_ALLOC_N(lpar_uuid, 100 * sizeof(char))) > > +return NULL; > > You then wou

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-03-20 Thread Eduardo Otubo
Sorry all about my last email, the subject should be "[RFC] Power Hypervisor Libvirt support". There should be an error here. Thanks again, Em Sex, 2009-03-20 às 13:58 -0300, Eduardo Otubo escreveu: > Hello all, > > I've been working on a libvirt extension to manage

[libvirt] (no subject)

2009-03-20 Thread Eduardo Otubo
ver = $HMC = $managed_system. * Next features in my TODO list are "resume", "stop" and "reboot" the LPAR. Any comments are welcome. Thanks, -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19 8135 0885 ot...@li

  1   2   >