Re: [PATCH v6 0/8] support mode option for dirtyrate calculation

2022-02-21 Thread Hyman Huang
在 2022/2/21 20:35, Michal Prívozník 写道: On 2/20/22 14:28, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) v6: - rebase on mastr - drop the commit [PATCH v5 1/9] in this patchset, post an extra commit if needed in the future. Please review, thanks ! Regards Yong v5: - [PATCH v5

Re: [PATCH v6 7/8] virsh: Add mode option to domdirtyrate-calc virsh api

2022-02-21 Thread Hyman Huang
在 2022/2/21 20:34, Michal Prívozník 写道: On 2/20/22 14:28, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Extend domdirtyrate-calc virsh api with mode option, either of these three options "page-sampling,dirty-bitmap,dirty-ring" can be specified when calculating dirty

Re: [PATCH v6 2/8] qemu_driver: Probe capability before calculating dirty page rate

2022-02-21 Thread Hyman Huang
在 2022/2/21 20:34, Michal Prívozník 写道: On 2/20/22 14:28, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Probing QEMU_CAPS_CALC_DIRTY_RATE capability in advance in case of failure when calculating dirty page rate. Signed-off-by: Hyman Huang(黄勇) --- src/qemu/qemu_driver.c | 8

Re: [PATCH v5 1/9] qemu: Refactor dirty page rate calculation status implementation

2022-02-17 Thread Hyman Huang
在 2022/2/18 0:19, Michal Prívozník 写道: On 2/16/22 01:28, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) For any virTypedParameter API normal practice is to use a string to expose the data, not the rather enum integer value. So let's drop the virDomainDirtyRateStatus in p

Re: [PATCH v3 4/7] include: Introduce enum for qemuDomainStartDirtyRateCalc

2022-02-14 Thread Hyman Huang
在 2022/2/14 19:31, Daniel P. Berrangé 写道: On Mon, Feb 14, 2022 at 07:21:58PM +0800, Hyman Huang wrote: 在 2022/2/14 18:13, Michal Prívozník 写道: On 1/28/22 08:35, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Introduce virDomainDirtyRateCalcFlags and virDomainDirtyRateCalcMode to

Re: [PATCH v3 4/7] include: Introduce enum for qemuDomainStartDirtyRateCalc

2022-02-14 Thread Hyman Huang
在 2022/2/14 18:13, Michal Prívozník 写道: On 1/28/22 08:35, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Introduce virDomainDirtyRateCalcFlags and virDomainDirtyRateCalcMode to get ready for adding mode parameter to qemuDomainStartDirtyRateCalc. Signed-off-by: Hyman Huang(黄勇

Re: [PATCH v3 6/7] virsh: Add mode option to domdirtyrate-calc virsh api

2022-02-14 Thread Hyman Huang
在 2022/2/14 18:13, Michal Prívozník 写道: On 1/28/22 08:35, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Extend domdirtyrate-calc virsh api with mode option, either of these three options "page-sampling,dirty-bitmap,dirty-ring" can be specified when calculating dirty

Re: [PATCH v2 4/6] qemu_driver: Add mode option for qemuDomainStartDirtyRateCalc

2022-01-27 Thread Hyman Huang
在 2022/1/27 16:34, Peter Krempa 写道: On Thu, Jan 27, 2022 at 15:25:20 +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Add mode option to extend qemuDomainStartDirtyRateCalc API, which is introduced since qemu >= 6.2. Signed-off-by: Hyman Huang(黄勇) --- include/libv

Re: [PATCH v2 2/6] qemu_driver: Probe capability before calculating dirty page rate

2022-01-27 Thread Hyman Huang
在 2022/1/27 16:23, Peter Krempa 写道: On Thu, Jan 27, 2022 at 15:25:18 +0800, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Probing QEMU_CAPS_CALC_DIRTY_RATE capability in advance in case of failure when calculating dirty page rate. Signed-off-by: Hyman Huang(黄勇) --- src/qemu

Re: [PATCH v7 1/2] qemu: support dirty ring feature

2021-12-14 Thread Hyman Huang
On 12/14/21 20:21, Michal Prívozník wrote: On 12/14/21 10:22, Michal Prívozník wrote: On 11/23/21 15:36, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Dirty ring feature was introduced in qemu-6.1.0, this patch add the corresponding feature named 'dirty-ring', which en

Re: [PATCH v7 1/2] qemu: support dirty ring feature

2021-12-14 Thread Hyman Huang
On 12/14/21 17:22, Michal Prívozník wrote: On 11/23/21 15:36, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) Dirty ring feature was introduced in qemu-6.1.0, this patch add the corresponding feature named 'dirty-ring', which enable dirty ring feature when starting vm. To

Re: [PATCH v6 2/4] qemu_command: switch accelerator option to new style

2021-11-22 Thread Hyman Huang
在 2021/11/22 16:43, Peter Krempa 写道: On Sat, Nov 20, 2021 at 03:20:46 -0500, huang...@chinatelecom.cn wrote: From: Hyman Huang(黄勇) QEMU greater than 2.9.0 support '-accel' option, change the way of assembling commandline from "accel=kvm" to "-accel kvm" when s