dea. Still, it
seems like the cleanest approach even if it will be more work.
With all of that said, I know we want this fixed and your patch seems to
fix the problem. So if you need an R-b...
Reviewed-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
Can we have a new tag? :-D
Reviewed-by-wi
On 01/18/2017 12:00 PM, Eduardo Habkost wrote:
On Tue, Jan 17, 2017 at 10:22:10AM -0500, Jason J. Herne wrote:
On 01/16/2017 08:01 PM, Eduardo Habkost wrote:
This is a follow-up to the series that implements
query-cpu-model-expansion. Before including the test script, the
series has some fixes
PUModelInfo = NULL;
+
virCPUDefFree(qemuCaps->hostCPUModel);
qemuCaps->hostCPUModel = NULL;
}
Fwiw,
Looks good to me.
Reviewed-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
--
-- Jason J. Herne (jjhe...@linux.vnet.ibm.com)
--
libvir-list mailing list
libvir-list@red
eption(reply["error"]["desc"])
Exception: The CPU definition 'host' requires KVM
----------
Ran 2 tests in 74.622s
--
-- Jason J. Herne (jjhe...@linux.vnet.ibm.com)
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
the problem by silently ignoring generic errors stemming from
calls to query-cpu-model-expansion.
Reported-by: Farhan Ali <al...@linux.vnet.ibm.com>
Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
src/qemu/qemu_
to query-cpu-model-expansion.
Reported-by: Farhan Ali <al...@linux.vnet.ibm.com>
Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
src/qemu/qemu_monitor_json.c | 9 +
1 file changed, 9 insertions(+)
On 12/18/2016 02:22 PM, Jason J. Herne wrote:
This patch set enables cpu model support for s390. The user can now set exact
cpu models, query supported models via virsh domcapabilities, and use host-model
and host-passthrough modes. The end result is that migration is safer because
Qemu
On 12/18/2016 02:22 PM, Jason J. Herne wrote:
This patch set enables cpu model support for s390. The user can now set exact
cpu models, query supported models via virsh domcapabilities, and use host-model
and host-passthrough modes. The end result is that migration is safer because
Qemu
From: "Collin L. Walling" <wall...@linux.vnet.ibm.com>
Tests Qemu capabilities on s390x before and after the availability of
the query-cpu-model-expansion QMP command.
Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <j
or qmp
query-cpu-model-expansion) we use key=value else we fall back to +/-feature.
Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
src/qemu/qemu_command.c| 18 +++-
Test cases for qemu s390x cpu model argument generation.
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
.../qemuxml2argv-cpu-s390-zEC12.args| 19 +++
.../qemuxml2argv-cpu-s390-zEC12.xml | 21 +
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
# Conflicts:
# tests/qemucapabilitiesdata/caps_2.8.0.s390x.replies
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
src/qemu/qemu_capabilities.c | 185 -
tests/do
@linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
src/qemu/qemu_capabilities.c| 5 +-
src/qemu/qemu_capabilities.h| 3 +
src/qemu/qemu_monitor.c | 62 +
src/qemu/qemu_monitor.h
On s390, the host's features are heavily influenced by not only the host
hardware but also by hardware microcode level, host OS version, qemu
version and kvm version. In this environment it does not make sense to
attempt to report exact host details.
Signed-off-by: Jason J. Herne <j
2.8 on s390x
qemu: qmp query-cpu-model-expansion command
qemu: command: Support new cpu feature argument syntax
Jason J. Herne (4):
s390: Cpu driver support for update and compare
s390-cpu: Remove nodeData and decode
qemu-caps: Get host model directly from Qemu when available
tests: qem
;host-model" mode.
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
Acked-by: Jiri Denemark <jdene...@redhat.com>
---
po/POTFILES.in | 1 +
src/cpu/cpu_s390.c | 73 --
2 files changed, 72 insertions(+), 2 deletio
From: "Collin L. Walling" <wall...@linux.vnet.ibm.com>
Tests domain capabilities on s390x using the Qemu 2.8 capabilities data.
Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
tests/dom
On 12/15/2016 11:55 AM, Jiri Denemark wrote:
On Fri, Dec 09, 2016 at 14:38:29 -0500, Jason J. Herne wrote:
This patch set enables cpu model support for s390. The user can now set exact
cpu models, query supported models via virsh domcapabilities, and use host-model
and host-passthrough modes
On 12/15/2016 11:18 AM, Jiri Denemark wrote:
On Fri, Dec 09, 2016 at 14:38:35 -0500, Jason J. Herne wrote:
Documents in formatdomain.html that when migrating a guest
defined with the host-passthrough CPU model from a machine that
is running on a newer CPU model than the destination machine's
From: "Collin L. Walling" <wall...@linux.vnet.ibm.com>
Tests the domain capabilities on s390x using the Qemu 2.8 capabilities data.
Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
tests/dom
eatures
expected to be available on this model.
Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
tests/qemucapabilitiestest.c | 4
tests/testutilsqemu.c| 39 ++-
tests/test
red.
Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
src/qemu/qemu_capabilities.c | 180 ++-
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 177 insertions(+), 4 de
@linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
src/qemu/qemu_monitor.c | 62 ++
src/qemu/qemu_monitor.h | 22
src/qemu/qemu_monitor_json.c | 121 +++
src/qemu/qemu_monitor_json.h
or qmp
query-cpu-model-expansion) we use key=value else we fall back to +/-feature.
Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
src/qemu/qemu_command.c | 10 --
1 file changed, 8 insertions(+), 2 de
Test cases for qemu s390x cpu model argument generation.
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
.../qemuxml2argv-cpu-s390-zEC12.args| 19 +++
.../qemuxml2argv-cpu-s390-zEC12.xml | 21 +
Test that libvirt generates the correct cpu feature syntax when
query-cpu-model-expansion is supported and when it is not.
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
.../qemuxml2argv-cpu-features-post-qcme.args | 19 ++
.../qemuxml2argv-cpu-feature
Documents in formatdomain.html that when migrating a guest
defined with the host-passthrough CPU model from a machine that
is running on a newer CPU model than the destination machine's
CPU model, it is very likely that the guest will crash upon
arrival.
Signed-off-by: Jason J. Herne <j
feature argument syntax
test-data: Qemu caps replies and xml for s390x qemu 2.7 and 2.8
tests: qemu capabilites: qemu 2.7 and 2.8 on s390x
tests: domain capabilities: qemu 2.8 on s390x
Jason J. Herne (5):
s390: Cpu driver support for update and compare
s390-cpu: Remove nodeData and decode
;host-model" mode.
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
po/POTFILES.in | 1 +
src/cpu/cpu_s390.c | 73 --
2 files changed, 72 insertions(+), 2 deletions(-)
diff --git a/po/POTFILES.in b/po/POTFILES.
On s390 , the host's features are heavily influenced by not only the host
hardware but also by hardware microcode level, host OS version, qemu
version and kvm version. In this environment it does not make sense to
attempt to report exact host details.
Signed-off-by: Jason J. Herne <j
st's features with the correct policy
statements. Our call to virCPUDefStealModel will copy the features pointer
from guest to updated. What am I missing.
--
-- Jason J. Herne (jjhe...@linux.vnet.ibm.com)
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
-expansion command
qemu-caps: Get host model directly from Qemu when available
qemu: migration: warn if migrating with host-passthrough
qemu: command: Support new cpu feature argument syntax
Jason J. Herne (1):
s390: Cpu driver support for update and compare
po/POTFILES.in |
or qmp
query-cpu-model-expansion) we use key=value else we fall back to +/-feature.
Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
src/qemu/qemu_command.c | 10 --
1 file changed, 8 insertions(+), 2 de
@linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
src/qemu/qemu_monitor.c | 60
src/qemu/qemu_monitor.h | 22 +++
src/qemu/qemu_monitor_json.c | 94
src/qemu/qemu_moni
ost.
Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
src/qemu/qemu_migration.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index d4a55d8..f
eport exact host details.
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com>
---
src/cpu/cpu_s390.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/cpu/cpu_s390.c b/src/cpu/cpu_s390.c
i
red.
Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
src/qemu/qemu_capabilities.c | 109 +--
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 105 insertions(+), 5 de
;host-model" mode.
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
po/POTFILES.in | 1 +
src/cpu/cpu_s390.c | 54 --
2 files changed, 53 insertions(+), 2 deletions(-)
diff --git a/po/POTFILES.in b/po/POTFILES.
On 11/03/2016 08:54 AM, Jiri Denemark wrote:
On Wed, Nov 02, 2016 at 16:34:32 -0400, Jason J. Herne wrote:
From: "Collin L. Walling" <wall...@linux.vnet.ibm.com>
On s390 , the host's features are heavily influenced by not only the host
hardware but also by hardware microcod
On 11/03/2016 09:37 AM, Jiri Denemark wrote:
On Wed, Nov 02, 2016 at 16:34:30 -0400, Jason J. Herne wrote:
...
2. virsh baseline and compare support.
Both of these commands, for s390 at least, will need to spin up a Qemu session
with monitor to compute the result. The only place I see
red.
Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
src/qemu/qemu_capabilities.c | 88 +++-
1 file changed, 87 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qe
Look up the host model stored in qemuCaps for generation of the
-cpu model portion of the Qemu command line.
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
src/qemu/qemu_command.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/qemu/qemu_command.c b/sr
eport exact host details. Rather than use the generic "host"
we leave this field blank.
Signed-off-by: Collin L. Walling <wall...@linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
src/cpu/cpu_s390.c | 2 +-
1 file changed, 1 insertion(+
@linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
src/qemu/qemu_monitor.c | 28 +
src/qemu/qemu_monitor.h | 19 +
src/qemu/qemu_monitor_json.c | 98
src/qemu/qemu_monitor_json.h |
will rely on Qemu to perform the runnability checking.
Implement update for s390. required to support use of cpu "host-model" mode.
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
src/cpu/cpu_s390.c | 31 +--
1 file changed, 29 insertions
o
cpu model passthrough. What am I missing?
Thanks for your time.
Collin L. Walling (3):
s390: Report blank host model instead of "host"
qemu: qmp query-cpu-model-expansion command
qemu-caps: Get host model directly from Qemu when available
Jason J. Herne (2):
s390: Cpu driver su
On 09/29/2016 11:15 AM, Jiri Denemark wrote:
On Fri, Sep 23, 2016 at 15:51:12 -0400, Jason J. Herne wrote:
On 09/23/2016 08:05 AM, Jiri Denemark wrote:
The host-model part of the XML will show the result of
query-cpu-model-expansion on "host" model, or the result of querying th
causes migration to fail earlier and provides a meaningful error
message stating that
migrating read only disks is not supported.
Signed-off-by: Corey S. McQuay <csmcq...@linux.vnet.ibm.com>
Reviewed-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiu
Polite Ping? :)
On 09/23/2016 03:51 PM, Jason J. Herne wrote:
On 09/23/2016 08:05 AM, Jiri Denemark wrote:
On Thu, Sep 22, 2016 at 14:47:36 -0400, Jason J. Herne wrote:
...
1. We will invoke qemu to gather the host cpu data used for virsh
capabilities. Today this data seems to be collected
On 09/23/2016 08:05 AM, Jiri Denemark wrote:
On Thu, Sep 22, 2016 at 14:47:36 -0400, Jason J. Herne wrote:
...
1. We will invoke qemu to gather the host cpu data used for virsh
capabilities. Today this data seems to be collected directly from the
host hardware for most (all?) architectures
nt
to. Or if
we will want to change all architectures to this new interface at the
same time.
Any guidance?
Thanks for your time and consideration.
--
-- Jason J. Herne (jjhe...@linux.vnet.ibm.com)
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
is a
cryptic error message
and a failed migration.
This patch causes migration to fail earlier and provides a meaningful error
message stating that
migrating read only disks is not supported.
Signed-off-by: Corey S. McQuay <csmcq...@linux.vnet.ibm.com>
Reviewed-by: Jason J. Herne
On 08/17/2016 05:10 PM, Jason J. Herne wrote:
On 08/11/2016 08:57 AM, Corey S McQuay wrote:
On 08/10/2016 09:16 AM, Koniszewski, Pawel wrote:
-Original Message-
From: libvir-list-boun...@redhat.com [mailto:libvir-list-
boun...@redhat.com] On Behalf Of Corey S. McQuay
Sent: Friday
l do some more testing.
Pawel,
Thanks for taking a look. Does Corey's reply address your concerns?
--
-- Jason J. Herne (jjhe...@linux.vnet.ibm.com)
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
stem
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
Reviewed-by: Eric Farman <far...@linux.vnet.ibm.com>
---
src/util/virtypedparam.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/util/virtypedparam.c b/src/util/virtypedparam.c
index 138fc64..2
enough we
overrun the socket's pending connections queue.
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
Reviewed-by: Boris Fiuczynski <fiu...@linux.vnet.ibm.com>
---
daemon/libvirtd-config.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/daemon/libvirtd-config.c b/dae
: Only overwrite the newline if the string is not empty.
Reviewed-by: Bjoern Walk <bw...@linux.vnet.ibm.com>
Signed-off-by: Jason J. Herne <jjhe...@linux.vnet.ibm.com>
---
src/util/virnetdevopenvswitch.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --gi
On 02/05/2015 11:26 AM, Jason J. Herne wrote:
Hello Eric,
it has been quite a while since we have looked at this :). I'm
revisiting this problem and I find that it still exists. Here is an
archive link of our previous discussions on this:
https://www.redhat.com/archives/libvir-list/2014-July
saw
goodbye world) that you would also see the out of disk space message
ok. If I'm correct, then the question becomes... why don't I see it too? :)
Thanks for your time.
--
-- Jason J. Herne (jjhe...@linux.vnet.ibm.com)
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com
From: Jason J. Herne jjhe...@us.ibm.com
libvirt_iohelper is a helper process that is exec'ed and used to handle I/O
during a Qemu managed save operation. Due to a missing call to
virFileWrapperFdClose, all I/O error messages reported by iohelper are lost.
This patch adds a call
On 06/24/2014 03:21 PM, Eric Blake wrote:
On 06/24/2014 08:07 AM, Jason J. Herne wrote:
During a recent managed save operation I received the following error
message:
error: operation failed: domain save job: unexpectedly failed.
It turns out that I had run out of disk space. After
During a recent managed save operation I received the following error
message:
error: operation failed: domain save job: unexpectedly failed.
It turns out that I had run out of disk space. After a brief investigation I
discovered that libvirt_iohelper is exec'ed and is used to handle all
On 05/20/2014 02:08 PM, Jason J. Herne wrote:
During a recent managed save operation I received the following error
message:
error: operation failed: domain save job: unexpectedly failed.
It turns out that I had run out of disk space. After a brief
investigation I
discovered
From: Jason J. Herne jjhe...@us.ibm.com
qemuDomainObjStart is checking the return code from qemuDomainObjRestore for
errors even after determining that the return code is 0. This causes the
following error message to appear even when the restore was successful.
Unable to restore from managed
to the user when a
managed save
fails because of an I/O error.
--
-- Jason J. Herne (jjhe...@linux.vnet.ibm.com)
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
65 matches
Mail list logo
