the vsnprintf wrapper.
* bootstrap.conf (gnulib_modules): Add vsnprintf.
Reported by Matthias Bolte.
---
bootstrap.conf | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Followup. There are two forks of mingw - the older mingw project is
32-bit only, and has added wrappers
;
*version = 100 * major + 1000 * minor + micro;
Well, your patch fixes the problem, but virParseVersionString is used
in more places than just kernel version parsing, therefore I think it
relaxes parsing too much and we need a stricter approach for this.
--
Matthias Bolte
http
(vmwareExtractVersion): Likewise.
* src/xenapi/xenapi_driver.c (xenapiGetVersion): Likewise.
Reported by Matthias Bolte.
---
For the avoidance of any doubt, I'm posting a complete v3.
v2: check for overflow
v3: constrain result to 32-bits
src/esx/esx_driver.c | 2 +-
src/lxc
Move non-esx specific tests from esxutilstest there and add a
test for virParseVersionString.
---
tests/.gitignore |1 +
tests/Makefile.am|8 ++-
tests/esxutilstest.c | 70
tests/utiltest.c | 178 ++
4
2011/7/1 Eric Blake ebl...@redhat.com:
On 07/01/2011 11:59 AM, Matthias Bolte wrote:
Move non-esx specific tests from esxutilstest there and add a
test for virParseVersionString.
---
tests/.gitignore | 1 +
tests/Makefile.am | 8 ++-
tests/esxutilstest.c | 70
insertions(+), 0 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2011/6/29 Daniel Veillard veill...@redhat.com:
On Wed, Jun 29, 2011 at 02:14:19AM +0200, Matthias Bolte wrote:
addnhostsSave and hostsfileSave expect 0 return value on error from
addnhostsWrite and hostsfileWrite but then pass err instead of -err
to virReportSystemError that expects an errno
2011/6/28 simon jin simon...@linux.vnet.ibm.com:
于 2011-6-27 23:17, Laine Stump 写道:
On 06/27/2011 07:32 AM, Matthias Bolte wrote:
2011/6/27 simonsimon...@linux.vnet.ibm.com:
于 2011-6-27 13:01, Daniel Veillard 写道:
So we are entering the week freeze for the new version 0.9.3
I have made
networkSaveDnsmasqHostsfile was added in 8fa9c2214247 (Apr 2010).
It has a force flag. If the dnsmasq hostsfile already exists force
needs to be true to overwrite it. networkBuildDnsmasqArgv sets force
to false, networkDefine sets it to true. This results in the
hostsfile being written only in
2011/6/28 simon jin simon...@linux.vnet.ibm.com:
于 2011-6-28 16:20, Matthias Bolte 写道:
2011/6/28 simon jin simon...@linux.vnet.ibm.com:
于 2011-6-27 23:17, Laine Stump 写道:
On 06/27/2011 07:32 AM, Matthias Bolte wrote:
2011/6/27 simonsimon...@linux.vnet.ibm.com:
于 2011-6-27 13:01, Daniel
2011/6/15 Eric Blake ebl...@redhat.com:
On 06/15/2011 07:40 AM, Matthias Bolte wrote:
---
daemon/remote.c | 4 +-
include/libvirt/libvirt.h.in | 99
--
src/driver.h | 4 +-
src/libvirt.c | 38
---
This patch depends on
https://www.redhat.com/archives/libvir-list/2011-June/msg01423.html
src/network/bridge_driver.c | 23 +--
src/util/dnsmasq.c | 10 --
src/util/dnsmasq.h |4 ++--
3 files changed, 19 insertions(+), 18 deletions(-)
2011/6/28 Daniel P. Berrange berra...@redhat.com:
On Tue, Jun 28, 2011 at 01:51:29PM +0200, Matthias Bolte wrote:
2011/6/15 Eric Blake ebl...@redhat.com:
On 06/15/2011 07:40 AM, Matthias Bolte wrote:
---
daemon/remote.c | 4 +-
include/libvirt/libvirt.h.in | 99
Version 1.3 uses this macro
#define STAP_CAST(t) (size_t)t
that breaks if t is a function. For that to work it should probably
look like this
#define STAP_CAST(t) ((size_t)(t))
In systemtap 1.4 this was completely rewritten.
Anyway, before commit df0b57a95a767c t was always a variable,
2011/6/29 Eric Blake ebl...@redhat.com:
s/compliation/compilation/ in the subject
On 06/28/2011 04:34 PM, Matthias Bolte wrote:
Version 1.3 uses this macro
version 1.3 of sys/sdt.h
#define STAP_CAST(t) (size_t)t
that breaks if t is a function. For that to work it should probably
look
2011/6/28 Eric Blake ebl...@redhat.com:
On 06/28/2011 05:10 AM, Matthias Bolte wrote:
networkSaveDnsmasqHostsfile was added in 8fa9c2214247 (Apr 2010).
It has a force flag. If the dnsmasq hostsfile already exists force
needs to be true to overwrite it. networkBuildDnsmasqArgv sets force
2011/6/28 Eric Blake ebl...@redhat.com:
On 06/28/2011 06:08 AM, Matthias Bolte wrote:
---
This patch depends on
https://www.redhat.com/archives/libvir-list/2011-June/msg01423.html
which is now ACK'd.
src/network/bridge_driver.c | 23 +--
src/util/dnsmasq.c
addnhostsSave and hostsfileSave expect 0 return value on error from
addnhostsWrite and hostsfileWrite but then pass err instead of -err
to virReportSystemError that expects an errno value.
Also addnhostsWrite returns -ENOMEM and errno, change this to -errno.
addnhostsWrite and hostsfileWrite
. This can be fixed in Slackware's
libnl package by removing the inline keyword from the declaration of
nl_object_priv in /usr/include/netlink/object.h.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
configure without
arguments.
We're working on a fix for this.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2011/6/27 Eric Blake ebl...@redhat.com:
On 06/25/2011 10:10 AM, Matthias Bolte wrote:
2011/6/25 Eric Blake ebl...@redhat.com:
On 06/25/2011 06:41 AM, Matthias Bolte wrote:
networkxml2argvtest indirectly calls networkDnsmasqLeaseFileName
that depends on configure --localstatedir. Therefore
Convert networkDnsmasqLeaseFileName to a replaceable function pointer
that allow the testsuite to use a version of that function that is not
depending on configure --localstatedir.
This fixes 5 of 6 test failures, when configure --localstatedir isn't
set to /var.
---
The last failure is related
2011/6/27 Eric Blake ebl...@redhat.com:
On 06/27/2011 09:08 AM, Matthias Bolte wrote:
Convert networkDnsmasqLeaseFileName to a replaceable function pointer
that allow the testsuite to use a version of that function that is not
depending on configure --localstatedir.
This fixes 5 of 6 test
2011/6/27 Laine Stump la...@laine.org:
On 06/27/2011 07:32 AM, Matthias Bolte wrote:
2011/6/27 simonsimon...@linux.vnet.ibm.com:
于 2011-6-27 13:01, Daniel Veillard 写道:
So we are entering the week freeze for the new version 0.9.3
I have made an rc1 tarball available at:
ftp
networkxml2argvtest indirectly calls networkDnsmasqLeaseFileName
that depends on configure --localstatedir. Therefore, the .argv
files used in the test have to be created with this localstatedir.
Move the .argv to .argv.in files with a @localstatedir@ placeholder.
---
tests/.gitignore
2011/6/25 Eric Blake ebl...@redhat.com:
On 06/25/2011 06:41 AM, Matthias Bolte wrote:
networkxml2argvtest indirectly calls networkDnsmasqLeaseFileName
that depends on configure --localstatedir. Therefore, the .argv
files used in the test have to be created with this localstatedir.
Move
getifaddrs can return an IPv6 address, but getaddrinfo can fail
for an IPv6 address. Cover this combination.
---
This is only tested on my system with broken IPv6. Could someone test this
on an IPv6 capable system and ensure that the IPv6 tests aren't skipped now
by running
cd tests
make
2011/6/24 Eric Blake ebl...@redhat.com:
On 06/24/2011 09:39 AM, Matthias Bolte wrote:
getifaddrs can return an IPv6 address, but getaddrinfo can fail
for an IPv6 address. Cover this combination.
---
This is only tested on my system with broken IPv6. Could someone test this
on an IPv6
Commit cd48c3f4e95597 added a Py_ssize_t typedef for Python 2.7.
But Py_ssize_t was added in Python 2.5. This makes the build fail
for Python 2.6.
Adjust the check to match Python 2.5 to fix this.
---
python/typewrappers.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
2011/6/24 Eric Blake ebl...@redhat.com:
On 06/24/2011 11:36 AM, Matthias Bolte wrote:
Commit cd48c3f4e95597 added a Py_ssize_t typedef for Python 2.7.
But Py_ssize_t was added in Python 2.5. This makes the build fail
for Python 2.6.
Ah, well I guessed wrong.
Adjust the check to match
+Subproject commit 25e4c2ec96602d132ad4429d6eaebaea1a8f504b
--
1.7.4.4
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
is not listed in
bootstrap.conf, so it's probably pulled in as a dependency for another
module. But it doesn't hurt to be explicit and list it in
bootstrap.conf.
ACK, with that fixed.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https
changed, 4 insertions(+), 2 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2011/6/24 Taku Izumi izumi.t...@jp.fujitsu.com:
This patch introduces a new libvirt API (virDomainGetVcpupinInfo).
Just a comment on the name. I'd write pin with a capital P:
virDomainGetVcpuPinInfo
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list
Triggered a linker error on MinGW.
---
I'm pushing this one under the build breaker rule.
src/libvirt_private.syms |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 070b4c1..da7e186 100644
---
---
src/libvirt_private.syms |4 ++--
src/util/interface.c | 26 +-
src/util/interface.h |4 ++--
3 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index f34ef9e..ea2414d 100644
---
2011/6/24 Eric Blake ebl...@redhat.com:
On 06/24/2011 02:46 PM, Matthias Bolte wrote:
---
src/libvirt_private.syms | 4 ++--
src/util/interface.c | 26 +-
src/util/interface.h | 4 ++--
3 files changed, 17 insertions(+), 17 deletions(-)
ACK
2011/6/23 Laine Stump la...@laine.org:
On 06/22/2011 06:42 PM, Matthias Bolte wrote:
The refactoring in 6a5978833a5 and df3d8c362d3 was incomplete
as it accidentally moved macvtap related code out of a
#if WITH_MACVTAP in a #if __linux__ block. To fix this move
ifaceMacvtapLinkAdd
2011/6/23 Eric Blake ebl...@redhat.com:
On 06/22/2011 04:39 PM, Matthias Bolte wrote:
apibuild.py expects a sentence that starts with Returns
describing the return value of a function.
---
src/libvirt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/libvirt.c
in the code instead of HAVE_LIBNL. Or do
you plan to use libnl also for non-macvtap related code.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2011/6/23 Stefan Berger stef...@linux.vnet.ibm.com:
On 06/23/2011 08:41 AM, Matthias Bolte wrote:
2011/6/23 Stefan Bergerstef...@linux.vnet.ibm.com:
Set HAVE_LIBNL to be able to conditionally compile libnl code.
Signed-off-by: Stefan Bergerstef...@linux.vnet.ibm.com
---
configure.ac
return -1;
}
This fixes the problem for me as it restores the original conditionals
from before the refactoring.
ACK to the series, feel free to pick what ever version of 1/2 you like.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https
: Synchronize to upstream.
---
Well, most of it is module: Move AC_LIBOBJ invocations to module
description.
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2011/6/22 Eric Blake ebl...@redhat.com:
* src/libvirt.c (virConnectClose): Mention reference count return.
Reported by Michal Novotny, analyzed by Matthias Bolte.
---
src/libvirt.c | 7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
2011/6/22 Eric Blake ebl...@redhat.com:
On 06/22/2011 10:43 AM, Matthias Bolte wrote:
2011/6/22 Eric Blake ebl...@redhat.com:
* src/libvirt.c (virConnectClose): Mention reference count return.
Reported by Michal Novotny, analyzed by Matthias Bolte.
---
src/libvirt.c | 7 ++-
1 files
apibuild.py expects a sentence that starts with Returns
describing the return value of a function.
---
src/libvirt.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index 63fe7ff..69e0ea8 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@
The refactoring in 6a5978833a5 and df3d8c362d3 was incomplete
as it accidentally moved macvtap related code out of a
#if WITH_MACVTAP in a #if __linux__ block. To fix this move
ifaceMacvtapLinkAdd and ifaceMacvtapLinkDump back under
#if WITH_MACVTAP.
Also nlComm was moved from #if WITH_MACVTAP to
for specific backend) and
was not related to PATH_MAX here. As it's definitely wrong to have it
in this general place I think it's okay to remove it.
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo
.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
++--
src/xen/xm_internal.c | 19 ---
2 files changed, 18 insertions(+), 5 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
.
---
src/util/hostusb.c | 32 +---
src/util/pci.c | 31 +--
2 files changed, 50 insertions(+), 13 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com
the connection was
really closed or not.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
---
I'm pushing this under the build breaker rule.
src/nodeinfo.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/nodeinfo.c b/src/nodeinfo.c
index c6dbb84..9e0f906 100644
--- a/src/nodeinfo.c
+++ b/src/nodeinfo.c
@@ -685,23 +685,23 @@ int
2011/6/20 Daniel Veillard veill...@redhat.com:
On Thu, Jun 16, 2011 at 01:47:23PM +0200, Matthias Bolte wrote:
The XenAPI driver works like the ESX and PHyp driver by using its
own HTTPS based remote protocol.
---
libvirt.spec.in | 2 +-
1 files changed, 1 insertions(+), 1 deletions
2011/6/20 Wen Congyang we...@cn.fujitsu.com:
At 06/20/2011 04:40 PM, Matthias Bolte Write:
---
I'm pushing this under the build breaker rule.
src/nodeinfo.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/nodeinfo.c b/src/nodeinfo.c
index c6dbb84
2011/6/16 Jiri Denemark jdene...@redhat.com:
On Thu, Jun 16, 2011 at 11:43:08 +0200, Matthias Bolte wrote:
It was already generatable but skipped.
---
daemon/remote.c | 36
src/remote/remote_driver.c | 32
2011/6/20 Daniel Veillard veill...@redhat.com:
On Thu, Jun 16, 2011 at 11:43:53AM +0200, Matthias Bolte wrote:
---
daemon/remote.c | 64
--
daemon/remote_generator.pl | 28 ++
src/remote/remote_protocol.x | 2
2011/6/20 Matthias Bolte matthias.bo...@googlemail.com:
Broken by commit c4a8ca71b10eb adding the reset option.
Instead of altering a const string move the while loop into an
else clause.
---
tools/virsh.c | 110
-
1 files changed
Broken by commit c4a8ca71b10eb adding the reset option.
Instead of altering a const string move the while loop into an
else clause.
---
tools/virsh.c | 110 -
1 files changed, 54 insertions(+), 56 deletions(-)
diff --git a/tools/virsh.c
://www.redhat.com/archives/libvir-list/2011-June/msg00872.html
but yours is smaller, as I changed the control flow in mine.
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
not in the bindings yet. A potential caller would have to figure out
the value of the flag an pass it directly. This is not a showstopper
for your patch because at the moment the C# bindings currently miss
all flag values.
ACK and pushed, thanks.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir
2011/6/16 Eric Blake ebl...@redhat.com:
* tools/virsh.c (info_snapshot_create, info_save): Clarify
description.
* tools/virsh.pod (save): Likewise.
---
tools/virsh.c | 6 +++---
tools/virsh.pod | 8 +++-
2 files changed, 10 insertions(+), 4 deletions(-)
ACK.
--
Matthias
I can remove this one from my todo
list :)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2011/6/15 Eric Blake ebl...@redhat.com:
On 06/15/2011 10:39 AM, Matthias Bolte wrote:
virStreamRecv is for reading.
Also add some missing punctuation to virStreamSend's documentation.
---
src/libvirt.c | 8
1 files changed, 4 insertions(+), 4 deletions(-)
ACK.
Thanks
---
daemon/remote.c | 64 --
daemon/remote_generator.pl | 28 ++
src/remote/remote_protocol.x |2 +-
3 files changed, 29 insertions(+), 65 deletions(-)
diff --git a/daemon/remote.c b/daemon/remote.c
index
It was already generatable but skipped.
---
daemon/remote.c | 36
src/remote/remote_driver.c | 32
src/remote/remote_protocol.x |4 ++--
3 files changed, 2 insertions(+), 70 deletions(-)
diff --git
Removes special case code from the generator and handle additional
methods.
The generated version of remoteDispatchDomainPinVcpu(Flags) has no
length check, but this check was useless anyway as it was applied to
data that was already deserialized from its XDR form.
---
daemon/remote.c
The XenAPI driver works like the ESX and PHyp driver by using its
own HTTPS based remote protocol.
---
libvirt.spec.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 97ebd65..75b145a 100644
--- a/libvirt.spec.in
+++
-
1 files changed, 12 insertions(+), 9 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Also improve wording of some comments.
---
include/libvirt/libvirt.h.in | 36 ++--
1 files changed, 22 insertions(+), 14 deletions(-)
diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in
index 8ceafe5..cf1a682 100644
---
---
daemon/remote.c |4 +-
include/libvirt/libvirt.h.in | 99 --
src/driver.h |4 +-
src/libvirt.c| 38
src/nodeinfo.c | 40
src/nodeinfo.h
The position of the struct parameter in the function signature
differs. Instead of hardcoding the handling for this add an annotation
to the .x file to define the position.
---
daemon/remote_generator.pl | 42 --
src/remote/remote_protocol.x | 23
2011/6/15 Eric Blake ebl...@redhat.com:
On 06/15/2011 07:42 AM, Matthias Bolte wrote:
The position of the struct parameter in the function signature
differs. Instead of hardcoding the handling for this add an annotation
to the .x file to define the position.
---
daemon/remote_generator.pl
2011/6/15 Eric Blake ebl...@redhat.com:
On 06/15/2011 07:40 AM, Matthias Bolte wrote:
Also improve wording of some comments.
---
include/libvirt/libvirt.h.in | 36 ++--
1 files changed, 22 insertions(+), 14 deletions(-)
diff --git a/include/libvirt
Commit 64000eabedf2 is part 1, that only covered the daemon side by
accident. Part 2 covers the client side too.
---
daemon/remote_generator.pl | 17 +
1 files changed, 5 insertions(+), 12 deletions(-)
diff --git a/daemon/remote_generator.pl b/daemon/remote_generator.pl
index
2011/6/15 Eric Blake ebl...@redhat.com:
On 06/15/2011 09:35 AM, Matthias Bolte wrote:
Commit 64000eabedf2 is part 1, that only covered the daemon side by
accident. Part 2 covers the client side too.
---
daemon/remote_generator.pl | 17 +
1 files changed, 5 insertions
virStreamRecv is for reading.
Also add some missing punctuation to virStreamSend's documentation.
---
src/libvirt.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index 36a90d1..689b065 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
2011/6/13 Eric Blake ebl...@redhat.com:
* include/libvirt/libvirt.h.in (virDomainModificationImpact): Reword.
---
include/libvirt/libvirt.h.in | 15 ++-
1 files changed, 10 insertions(+), 5 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list
just fail with an RPC error.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
/archives/libvir-list/2011-May/msg00592.html
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
2011/6/14 Daniel P. Berrange berra...@redhat.com:
On Tue, Jun 14, 2011 at 11:21:39AM +0200, Matthias Bolte wrote:
2011/6/14 Daniel P. Berrange berra...@redhat.com:
On Tue, Jun 07, 2011 at 05:11:15PM +0800, Lai Jiangshan wrote:
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
src
, 10 insertions(+), 10 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
, 32 insertions(+), 12 deletions(-)
ACK.
--
Matthias Bolte
http://photron.blogspot.com
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
The VMware driver works like the OpenVZ driver by using a commandline
tool for management. It dosen't use it's own remote protocol.
---
libvirt.spec.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index c7ef8d0..97ebd65 100644
---
2011/6/9 Jiri Denemark jdene...@redhat.com:
On Thu, Jun 09, 2011 at 20:29:01 +0200, Matthias Bolte wrote:
The VMware driver works like the OpenVZ driver by using a commandline
tool for management. It dosen't use it's own remote protocol.
---
libvirt.spec.in | 2 +-
1 files changed, 1
Since the addition of the lock manager framework in 6a943419c528fdd7
dlopen is always required, but the checks in configure wasn't changed
to reflect that. This didn't show up directly because the VirtualBox
driver linking dlopen in covered it. But disabling the VirtualBox
driver makes the build
2011/6/8 Ruben Kerkhof ru...@rubenkerkhof.com:
On Tue, Jun 7, 2011 at 23:00, Matthias Bolte
matthias.bo...@googlemail.com wrote:
This is because of the locking manager using dlopen but not linking
against libdl explicitly. The VirtualBox driver happens to link libdl
in, but without it libdl
Those checks are already performed at the public API level.
---
src/esx/esx_driver.c | 10 --
src/esx/esx_storage_driver.c |5 -
2 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
index 500dc52..a5b96a9 100644
---
2011/6/6 Eric Blake ebl...@redhat.com:
On 06/06/2011 05:59 AM, Matthias Bolte wrote:
When virConnectGetType is called on a remote connection then the remote
driver returns the type of the underlying driver on the server side, for
example QEMU. Then virGetVersion compares hvType to a set
Shared folders are handled as filesystems and can also be hotplugged.
---
Currently this just maps shared folder to a filesystem element with type
mount. The filesystem element has an accessmode attribute that is not
useful for VirtualBox. Als the target element only has a dir attribute,
but
2011/6/7 Eric Blake ebl...@redhat.com:
On 06/07/2011 01:36 AM, Matthias Bolte wrote:
Those checks are already performed at the public API level.
---
src/esx/esx_driver.c | 10 --
src/esx/esx_storage_driver.c | 5 -
2 files changed, 0 insertions(+), 15 deletions
2011/6/6 Eric Blake ebl...@redhat.com:
Coverity 5.3.0 still outputs lots of COVERITY_* variables, but no
longer modifies COVERITY_BUILD_COMMAND in the environment. Pick
one that seems likely to stay around.
* configure.ac (STATIC_ANALYSIS): Detect newer Coverity.
---
configure.ac | 4
2011/6/6 Eric Blake ebl...@redhat.com:
Similar in nature to commit fd21ecfd, which shut up valgrind.
sigaction is apparently a nasty interface for code analyzers.
* src/util/util.c (virExecWithHook): Initialize entire var, since
coverity gripes about the (unused and non-standard)
2011/6/6 Eric Blake ebl...@redhat.com:
Detected by Coverity. cpumap was allocated with a value of
(unsigned short)*(int), which is an int computation, and then
promotes to size_t. On a 64-bit platform, this fails if bit
32 of the product is set (because of sign extension giving
a HUGE value
2011/6/6 Eric Blake ebl...@redhat.com:
Detected by Coverity. The code was doing math on shifted unsigned
char (which promotes to int), then promoting that to unsigned long
during assignment to size. On 64-bit platforms, this risks sign
extending values of size 2GiB. Bug present since
2011/6/6 Eric Blake ebl...@redhat.com:
Detected by Coverity. Commit a98d8f0d tried to make uuid debugging
more robust, but missed some APIs. And on the APIs that it visited,
the mere act of preparing the debug message ends up dereferencing
uuid prior to the null check. Which means the APIs
2011/6/6 Eric Blake ebl...@redhat.com:
Detected by Coverity. All existing callers happen to be in
range, so this isn't too serious.
* src/qemu/qemu_cgroup.c (qemuCgroupControllerActive): Check
bounds before dereference.
---
src/qemu/qemu_cgroup.c | 4 ++--
1 files changed, 2
2011/6/6 Eric Blake ebl...@redhat.com:
Coverity already saw through a NULL dereference without these
annotations, and gcc is still too puny to do good NULL analysis.
But clang still benefits (and is easier to run than coverity),
not to mention that adding this bit of documentation to the code
2011/6/6 Eric Blake ebl...@redhat.com:
Detected by Coverity. The only ways to get to the cleanup label
were by an early abort (list still NULL) or after successfully
transferring list to dest, so there is no list to clean up.
* src/secret/secret_driver.c (loadSecrets): Kill dead code.
---
2011/6/6 Eric Blake ebl...@redhat.com:
Coverity complained about these intentional fallthrough cases, but
not about other cases that were explicitly marked with nice comments.
For some reason, Coverity doesn't seem smart enough to parse the
up-front English comment in virsh about intentional
501 - 600 of 2383 matches
Mail list logo
