Fix for this:
http://www.redhat.com/archives/libvir-list/2014-November/msg00324.html
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index a5ed8ed..f674ba9 100644
On Tue, Nov 11, 2014 at 1:20 PM, John Ferlan wrote:
>
>
> On 10/29/2014 08:16 AM, Matthias Gatto wrote:
>> Check the arability of the options with the current qemu binary,
>> add them in the varable opt if yes, print a message if not.
>>
>> Signed-off-by: Ma
On Mon, Nov 10, 2014 at 5:25 PM, Michal Privoznik wrote:
> On 10.11.2014 16:19, Matthias Gatto wrote:
>>
>> Add support for bps_max and friends in the driver part.
>> In the part checking if a qemu is running, check if the running binary
>> support bps_max, if not pri
-list/2014-November/msg00271.html
I've fix the syntax error and the nparams detection problem
Signed-off-by: Matthias Gatto
---
include/libvirt/libvirt-domain.h | 56 +++
src/qemu/qemu_driver.c | 197 ---
src/qemu/qemu_monitor.c |
On Fri, Nov 7, 2014 at 4:56 PM, Michal Privoznik wrote:
> On 29.10.2014 13:15, Matthias Gatto wrote:
>>
>> This series of patches add support for bps_max, bps_rd_max, bps_wr_max,
>> bps_max, bps_rd_max, bps_wr_max, and iops_size in the functions
>> qemu
On Wed, Oct 29, 2014 at 1:15 PM, Matthias Gatto
wrote:
> This series of patches add support for bps_max, bps_rd_max, bps_wr_max,
> bps_max, bps_rd_max, bps_wr_max, and iops_size in the functions
> qemuDomainSetBlockIoTune
> and qemuDomainGetBlockIoTune.
> The last patch add su
Check the arability of the options with the current qemu binary,
add them in the varable opt if yes, print a message if not.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_command.c | 57 -
1 file changed, 56 insertions(+), 1 deletion(-)
diff
Add the new throttle options to virsh, and send them to libvirt.
Signed-off-by: Matthias Gatto
---
tools/virsh-domain.c | 119 +++
tools/virsh.pod | 10 +
2 files changed, 129 insertions(+)
diff --git a/tools/virsh-domain.c b/tools
Add support for bps_max and friends in the driver part.
In the part checking if a qemu is running, check if the running binary
support bps_max, if not print an error message, if yes add it to
"info" variable
Signed-off-by: Matthias Gatto
---
include/libvirt/libvirt-doma
Modify the structure _virDomainBlockIoTuneInfo to support these the new
options.
Change the initialization of the variable expectedInfo in qemumonitorjsontest.c
to avoid compiling problem.
Add documentation about the new xml options
Signed-off-by: Matthias Gatto
---
docs/formatdomain.html.in
Add the capability to detect if the qemu binary have the capability
to use bps_max and friends
Add a value in the enum virQEMUCapsFlags for the qemu capability.
Set it with virQEMUCapsSet if the binary suport bps_max and they friends.
Signed-off-by: Matthias Gatto
---
src/qemu
llfix
-Add comment (patch 4/7, 5/7)
-Undo the modification of the supportMaxOptions made
in the v5 because it was creating bugs(patch 4/5)
The 2 first patches have been reviewed by Eric Blake and sould be merge soon
The 3rd patch have been reviewed by Michal Privoznik and ack
Matthias Gat
Detect if the the qemu binary currently in use support the bps_max option,
If yes add it to the command, if not, just ignore the option.
We don't print error here, because the check for invalide arguments
has alerady been made in qemu_driver.c
Signed-off-by: Matthias Gatto
---
src
Add defines for the new options total_bytes_sec_max, write_bytes_sec_max,
read_bytes_sec_max, total_iops_sec_max, write_iops_sec_max, read_iops_sec_max,
size_iops_sec.
Signed-off-by: Matthias Gatto
---
include/libvirt/libvirt-domain.h | 54
1 file
On Sat, Oct 25, 2014 at 6:30 AM, Eric Blake wrote:
> On 10/07/2014 05:14 AM, Matthias Gatto wrote:
>> Detect if the the qemu binary currently in use suport the bps_max option,
>> If yes add it to the command, if not, just ignore the options.
>
> Ignoring options is wrong.
On Tue, Oct 7, 2014 at 1:14 PM, Matthias Gatto
wrote:
> This series of patches add support for bps_max, bps_rd_max, bps_wr_max,
> bps_max, bps_rd_max, bps_wr_max, and iops_size in the functions
> qemuDomainSetBlockIoTune and qemuDomainGetBlockIoTune.
> The last patch add suppo
Hello,
I'm implementing quorum in libvirt.
I've try to follow this proposal:
http://www.redhat.com/archives/libvir-list/2014-May/msg00546.html
At this point I've done this:
- add all the field need by quorum in _virStorageSource
(nBackingStores, threshold).
- handle more than one backing store in
_text modification.(remove old patch 5/7)
v5: Split patch 1/6 in two.
Add documentation for the new xml options (patch 2/7)
Change (void) to ATTRIBUTE_UNUSED (patch 4/7)
Capability detection of supportMaxOptions move before usage of
supportMaxOptions
Matthias Gatto (7):
qemu: Add defin
Detect if the the qemu binary currently in use suport the bps_max option,
If yes add it to the command, if not, just ignore the options.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_monitor_json.c | 57 +++-
1 file changed, 46 insertions(+), 11
Add defines for the news options total_bytes_sec_max, write_bytes_sec_max,
read_bytes_sec_max, total_iops_sec_max, write_iops_sec_max, read_iops_sec_max,
size_iops_sec.
Signed-off-by: Matthias Gatto
---
include/libvirt/libvirt.h.in | 54
1 file
Check the arability of the options with the current qemu binary, add them in
the varable opt if yes,
print a message if not.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_command.c | 57 -
1 file changed, 56 insertions(+), 1 deletion(-)
diff
Modify the structure _virDomainBlockIoTuneInfo to support these the new
options.
Change the initialization of the variable expectedInfo in qemumonitorjsontest.c
to avoid compiling problem.
Add documentation about the new xml options
Signed-off-by: Matthias Gatto
---
docs/formatdomain.html.in
Add support for bps_max and friends in the driver part.
In the part checking if a qemu is running, check if the running binary support
bps_max,
if not print an error message, if yes add it to "info" variable
Signed-off-by: Matthias Gatto
---
include/libvirt/libvirt.
Add the new throttle options to virsh, and send them to libvirt.
Signed-off-by: Matthias Gatto
---
tools/virsh-domain.c | 119 +++
tools/virsh.pod | 10 +
2 files changed, 129 insertions(+)
diff --git a/tools/virsh-domain.c b/tools
Add a value in the enum virQEMUCapsFlags for the qemu capability.
Set it with virQEMUCapsSet if the binary suport bps_max and they friends.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests
On Wed, Oct 1, 2014 at 6:05 PM, Michal Privoznik wrote:
> On 30.09.2014 16:09, Matthias Gatto wrote:
>>
>> Detect if the the qemu binary currently in use suport the bps_max option,
>> If yes add it to the command, if not, just ignore the options.
>>
>&
Detect if the the qemu binary currently in use suport the bps_max option,
If yes add it to the command, if not, just ignore the options.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_monitor_json.c | 59 +++-
1 file changed, 48 insertions(+), 11
Check the arability of the options with the current qemu binary, add them in
the varable opt if yes,
print a message if not.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_command.c | 57 -
1 file changed, 56 insertions(+), 1 deletion(-)
diff
in qemumonitorjsontest.c
to avoid compiling problem.
Allow libvirt to save the configuration.
Signed-off-by: Matthias Gatto
---
include/libvirt/libvirt.h.in | 54 +
src/conf/domain_conf.c | 110 ++-
src/conf/domain_conf.h
Add a value in the enum virQEMUCapsFlags for the qemu capability.
Set it with virQEMUCapsSet if the binary suport bps_max and they friends.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests
_text modification.(remove old patch 5/7)
Matthias Gatto (6):
qemu: Add defines for the news throttle options and modify the
structure _virDomainBlockIoTuneInfo.
qemu: Add the capability to detect if the qemu binary have the
capability to use bps_max and friends
qemu: Add bps_max and fr
Add support for bps_max and friends in the driver part.
In the part checking if a qemu is running, check if the running binary support
bps_max,
if not print an error message, if yes add it to "info" variable
Signed-off-by: Matthias Gatto
---
include/libvirt/libvirt.
Add the new throttle options to virsh, and send them to libvirt.
Signed-off-by: Matthias Gatto
---
tools/virsh-domain.c | 119 +++
tools/virsh.pod | 10 +
2 files changed, 129 insertions(+)
diff --git a/tools/virsh-domain.c b/tools
On Mon, Sep 29, 2014 at 10:32 AM, Matthias Gatto
wrote:
> On Thu, Sep 25, 2014 at 4:08 PM, Michal Privoznik wrote:
>> On 23.09.2014 16:13, Matthias Gatto wrote:
>>>
>>> This series of patches add support for bps_max, bps_rd_max, bps_wr_max,
>>> bps_max, bps_
On Thu, Sep 25, 2014 at 4:08 PM, Michal Privoznik wrote:
> On 23.09.2014 16:13, Matthias Gatto wrote:
>>
>> This series of patches add support for bps_max, bps_rd_max, bps_wr_max,
>> bps_max, bps_rd_max, bps_wr_max, and iops_size in the functions
>> q
Detect if the the qemu binary currently in use suport the bps_max option and
thy firends,
If yes add it to the command, if not, just ignore the options.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_monitor_text.c | 76
1 file changed, 69
Add the new throttle options to virsh, and send them to libvirt.
Signed-off-by: Matthias Gatto
---
tools/virsh-domain.c | 119 +++
tools/virsh.pod | 11 -
2 files changed, 129 insertions(+), 1 deletion(-)
diff --git a/tools/virsh
in qemumonitorjsontest.c
to avoid compiling problem.
Allow libvirt to save the configuration.
Signed-off-by: Matthias Gatto
---
include/libvirt/libvirt.h.in | 54 +++
src/conf/domain_conf.c | 89 +++-
src/conf/domain_conf.h
Check the arability of the options with the current qemu binary, add them in
the varable opt if yes,
print a message if not.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_command.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/src/qemu
Add support for bps_max and friends in the driver part.
In the part checking if a qemu is running, check if the running binary support
bps_max,
if not print an error message, if yes add it to "info" variable
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_driver.c
: Merge patch 1/9,2/9,5/9 together.
Change the capability detection.(patch 2/7 and 3/7).
Try to make the usage of QEMU_NB_BLOCK_IO_TUNE_PARAM_MAX more
explicit(patch 3/7).
Matthias Gatto (7):
qemu: Add defines for the news throttle options and modify the
structure
Add a value in the enum virQEMUCapsFlags for the qemu capability.
Set it with virQEMUCapsSet if the binary suport bps_max and they friends.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_capabilities.c | 4
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 5 insertions(+)
diff --git a
Detect if the the qemu binary currently in use suport the bps_max option,
If yes add it to the command, if not, just ignore the options.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_monitor_json.c | 59 +++-
1 file changed, 48 insertions(+), 11
On Mon, Sep 22, 2014 at 1:38 PM, Michal Privoznik wrote:
> On 22.09.2014 11:39, Matthias Gatto wrote:
>> For virQEMUCapsInitQMPMonitor I didn't find other way to check the
>> capability than to check the version, and virQEMUCapsComputeCmdFlags
>> is not call when qemu u
4 at 1:11 PM, Michal Privoznik wrote:
> On 15.09.2014 19:27, Matthias Gatto wrote:
>>
>> Modify the structure _virDomainBlockIoTuneInfo to support
>> total_bytes_sec_max, write_bytes_sec_max,
>> read_bytes_sec_max, total_iops_sec_max, write_iops_sec_max,
>> re
On Fri, Sep 19, 2014 at 1:11 PM, Michal Privoznik wrote:
> On 15.09.2014 19:27, Matthias Gatto wrote:
>>
>> Add a value in the enum virQEMUCapsFlags for the qemu capability.
>> Set it with virQEMUCapsSet if the binary suport bps_max and they friends.
>>
>> Sig
Add support for bps_max and friends in the driver part.
In the part checking if a qemu is running, check if the running binary support
bps_max,
if not print an error message, if yes add it to "info" variable
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_driv
Detect if the the qemu binary currently in use suport the bps_max option,
If yes add it to the command, if not, just ignore the options.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_monitor_json.c | 58
1 file changed, 48 insertions(+), 10
Check the arability of the options with the current qemu binary, add them in
the varable opt if yes,
print a message if not.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_command.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/src/qemu
Detect if the the qemu binary currently in use suport the bps_max option and
thy firends,
If yes add it to the command, if not, just ignore the options.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_monitor_text.c | 75
1 file changed, 69
Add defines for the news options total_bytes_sec_max, write_bytes_sec_max,
read_bytes_sec_max
total_iops_sec_max, write_iops_sec_max, read_iops_sec_max, size_iops_sec.
Signed-off-by: Matthias Gatto
---
include/libvirt/libvirt.h.in | 54
1 file
Add the new throttle options to virsh, and send them to libvirt.
Signed-off-by: Matthias Gatto
---
tools/virsh-domain.c | 119 +++
1 file changed, 119 insertions(+)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index f7193cb..cf7884f
Allow qemu driver to save the configuration use by bps_max and they friends.
Signed-off-by: Matthias Gatto
---
src/conf/domain_conf.c | 89 +-
1 file changed, 88 insertions(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf
the qemu binary suport the bps_max options and they friends.
Change the initialization of the variable expectedInfo in qemumonitorjsontest.c
to avoid compiling problem.
Signed-off-by: Matthias Gatto
---
src/conf/domain_conf.h | 8
tests/qemumonitorjsontest.c | 2 +-
2 files changed
Matthias Gatto (9):
qemu: Add defines for the news throttle options
qemu: Add news throttle options to the structure
_virDomainBlockIoTuneInfo.
qemu: Add the capabilitie to detect if the qemu binary have the
capability to use bps_max and friends
qemu: Add bps_max and friends qemu driver
Add a value in the enum virQEMUCapsFlags for the qemu capability.
Set it with virQEMUCapsSet if the binary suport bps_max and they friends.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_capabilities.c | 6 ++
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 7 insertions(+)
diff --git
Check the avability of the options with the current qemu binary, add them in
the varable opt if yes,
print a message if not.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_command.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/src/qemu
Add suport for bps_max and friends in the driver part.
In the part checking if a qemu is running, check if the running binary suport
bps_max,
if not prrint an error message, if yes add it to "info" variable
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_driv
Detect if the the qemu binary currentely in use suport the bps_max option and
thy firends,
If yes add it to the commande, if not, just ignore the options.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_monitor_text.c | 75
1 file changed, 69
Allow qemu driver to save the configuration use by bps_max and they friends.
Signed-off-by: Matthias Gatto
---
src/conf/domain_conf.c | 89 +-
1 file changed, 88 insertions(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf
Add defines for the new options total_bytes_sec_max, write_bytes_sec_max,
read_bytes_sec_max
total_iops_sec_max, write_iops_sec_max, read_iops_sec_max, size_iops_sec.
Signed-off-by: Matthias Gatto
---
include/libvirt/libvirt.h.in | 54
1 file
Detect if the the qemu binary currently in use suport the bps_max option,
If yes add it to the command, if not, just ignore the options.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_monitor_json.c | 58
1 file changed, 48 insertions(+), 10
Add the new throttle options to virsh, and send them to libvirt.
Signed-off-by: Matthias Gatto
---
tools/virsh-domain.c | 119 +++
1 file changed, 119 insertions(+)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index f7193cb..cf7884f
qemu binary suport the bps_max options and they friends.
Change the initialisation of the variable expectedInfo in the test file
qemumonitorjsontest.c
to avoid compilling problem.
Signed-off-by: Matthias Gatto
---
src/conf/domain_conf.h | 8
tests/qemumonitorjsontest.c | 2 +-
2
Add a value in the enum virQEMUCapsFlags for the qemu capability.
Set it with virQEMUCapsSet if the binary suport bps_max and they friends.
Signed-off-by: Matthias Gatto
---
src/qemu/qemu_capabilities.c | 6 ++
src/qemu/qemu_capabilities.h | 1 +
2 files changed, 7 insertions(+)
diff --git
This series of patches add suport for bps_max, bps_rd_max, bps_wr_max,
bps_max, bps_rd_max, bps_wr_max, and iops_size in the functions
qemuDomainSetBlockIoTune,
and qemuDomainGetBlockIoTune.
The last patch add suport for therse parameters to the virsh blkdeviotune
commande.
Matthias Gatto (9
M, Eric Blake wrote:
> On 08/05/2014 10:14 AM, Matthias Gatto wrote:
>> Hello,
>>
>> I'm implementing the "new" QEMU option of
>> block_set_io_throttle(@bps_max, @bps_rd_max...), but i have a problem:
>> The old version of QEMU(before 1.7) does not hand
Hello,
I'm implementing the "new" QEMU option of
block_set_io_throttle(@bps_max, @bps_rd_max...), but i have a problem:
The old version of QEMU(before 1.7) does not handle it, so I'd like to
know what function should i use to know the version of QEMU, and
what's the proper way to handle this probl
101 - 168 of 168 matches
Mail list logo
