Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-04-12 Thread Daniel Veillard
On Thu, Apr 12, 2007 at 05:40:23PM +0900, Atsushi SAKAI wrote: > Hi, Rich > > Thank you for your suggestion. > I fixed it. > > Changes > 1)changes static to dynamic. (like sedf, credit, weight, cap) > 2)virsh printf added various print patterns for scheduler parameters. > 3)Tab space changed(fr

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-04-12 Thread Atsushi SAKAI
Hi, Rich Thank you for your suggestion. I fixed it. Changes 1)changes static to dynamic. (like sedf, credit, weight, cap) 2)virsh printf added various print patterns for scheduler parameters. 3)Tab space changed(from 2 to 4) in xen_unified.c part Thanks Atsushi SAKAI "Richard W.M. Jones" <[

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-04-11 Thread Daniel Veillard
On Wed, Apr 11, 2007 at 02:22:43PM +0100, Richard W.M. Jones wrote: > Please don't return static strings from functions. It does not work > well in the remote case. > > I don't like the dynamic typing going on in this patch altogether, but > with the above statically allocated strings, I think

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-04-11 Thread Richard W.M. Jones
See also: http://www.redhat.com/archives/libvir-list/2007-February/msg00096.html Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Wind

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-04-11 Thread Richard W.M. Jones
--- libvirt.orig/src/libvirt.c 2007-04-04 23:19:49.0 +0900 +++ libvirt.sched/src/libvirt.c 2007-04-06 14:06:08.0 +0900 @@ -1423,6 +1423,113 @@ virConnectGetCapabilities (virConnectPtr return NULL; } +/** + * virDomainGetSchedulerType: + * @dom: pointer to the hypervisor con

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-04-10 Thread Atsushi SAKAI
Hi, Rich Thank you for your comments. The purpose for asking is, if I get a comment soon. It will shorten my working for this issue. But finally I read through the code. Anyway, the method for building XML document in libvirt is interesting for me. Thanks Atsushi SAKAI "Richard W.M. Jones" <[

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-04-10 Thread Richard W.M. Jones
Atsushi SAKAI wrote: 0)Is there any documents about libvirt/python/generator.py? It seems make python bindings from XML API description. No there isn't! I learned about it by reading the code & Makefile. It's not that hard to understand, but the naming of the files is quite illogical so it

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-04-10 Thread Richard W.M. Jones
Atsushi SAKAI wrote: 0)xen_unified.c tabspace seems 2, it should be fixed. If needed, I will post it as another patch. That's actually a mistake on my part. I meant to make it 4 spaces. Will fix ... Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street,

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-04-10 Thread Daniel Veillard
On Tue, Apr 10, 2007 at 02:18:56PM +0900, Atsushi SAKAI wrote: > Hi, > > I add comments to libvirt.h and libvirt.h.in. > This purposes is > apibuild.py can correctly generate libvirt-api.xml&libvirt-refs.xml. Actually apibuild.py extracts the comments from the C files after having scanned the

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-04-10 Thread Daniel Veillard
On Mon, Apr 09, 2007 at 04:35:15PM +0900, Atsushi SAKAI wrote: > Hi, Daniel > > I add argument description for libvirt.c/xen_internal.c > > virDomainGetSchedulerType > virDomainGetSchedulerParameters > virDomainSetSchedulerParameters > > xenHypervisorGetSchedulerType > xenHypervisorGetSchedulerP

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-04-10 Thread Daniel Veillard
On Mon, Apr 09, 2007 at 10:57:20AM +0900, Atsushi SAKAI wrote: > Hi, Daniel Hi Atsushi, sorry I'm just back from a long week-end here ... > Thank you for various comments. > > Anyway I have several questions. > 0)Is there any documents about libvirt/python/generator.py? > It seems make pyt

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-04-09 Thread Atsushi SAKAI
Hi, I add comments to libvirt.h and libvirt.h.in. This purposes is apibuild.py can correctly generate libvirt-api.xml&libvirt-refs.xml. But if I use "union", apibuild.py does not work and libvirt-api.xml is not included in union case. Is there any good idea? Thanks Atsushi SAKAI Atsushi SA

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-04-09 Thread Atsushi SAKAI
Hi, Daniel I add argument description for libvirt.c/xen_internal.c virDomainGetSchedulerType virDomainGetSchedulerParameters virDomainSetSchedulerParameters xenHypervisorGetSchedulerType xenHypervisorGetSchedulerParameters xenHypervisorSetSchedulerParameters Anyway Where should I describe thes

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-04-08 Thread Atsushi SAKAI
Hi, Daniel Thank you for various comments. Anyway I have several questions. 0)Is there any documents about libvirt/python/generator.py? It seems make python bindings from XML API description. 1)PROXY-API seems to be not fully supported to various read (for example vcpuinfo). This is just

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-04-06 Thread Daniel Veillard
On Fri, Apr 06, 2007 at 06:20:08PM +0900, Atsushi SAKAI wrote: > Hi, > > This patch intends to see and handle scheduler parameters. > This is based on ML discussion. > This patch just support Xen/Credit for Type/Parameters > Xen/SEDF for Type only. > And other scheduler i

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-04-06 Thread Atsushi SAKAI
Hi, This patch intends to see and handle scheduler parameters. This is based on ML discussion. This patch just support Xen/Credit for Type/Parameters Xen/SEDF for Type only. And other scheduler is not supported but it will be easy to add it. ===How to use (at commandlin

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-04-02 Thread Richard W.M. Jones
Daniel P. Berrange wrote: I think it is unavoidable that every impl is going to express the schedular parameters in a completely different way. Thus if we're going to have an API for fetching/updating schedular parameters then I think we need to have a weakly typed system which is extensible to

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-04-02 Thread Daniel P. Berrange
On Mon, Apr 02, 2007 at 04:10:53PM +0900, Atsushi SAKAI wrote: > Hi, Daniel and Rich > > Thanks for various comments. > > Qemu and Qemu with KVM uses default Linux scheduler. > (struct sched_param) > And Xen uses original scheduler. > > At this moment, we should support xen (sedf, credit) and >

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-04-02 Thread Atsushi SAKAI
Hi, Daniel and Rich Thanks for various comments. Qemu and Qemu with KVM uses default Linux scheduler. (struct sched_param) And Xen uses original scheduler. At this moment, we should support xen (sedf, credit) and Linux scheduler(sched_param). Is this enough? Or We should consider other paramet

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-03-29 Thread Daniel Veillard
On Thu, Mar 29, 2007 at 09:16:05PM +0900, Atsushi SAKAI wrote: > Hi, Rich > > Thank you for your comments. > (The primary motivation is take a comments!) > > I am wondering the libvirt policy about scheduer. > And I just know the Xen scheduler only. > Is any good idea to support this? So far

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-03-29 Thread Atsushi SAKAI
Hi, Rich Thank you for your comments. (The primary motivation is take a comments!) I am wondering the libvirt policy about scheduer. And I just know the Xen scheduler only. Is any good idea to support this? Thanks Atsushi SAKAI "Richard W.M. Jones" <[EMAIL PROTECTED]> wrote: > Atsushi SAKAI

Re: [Libvir] [PATCH][RFC] shows scheduler information

2007-03-29 Thread Richard W.M. Jones
Atsushi SAKAI wrote: Hi, This patch intends add a showing function of scheduler information. If apply this patch to current revision 1.490 and type virsh dominfo 0 then shows following scheduler information. Currently I assume credit scheduler only. getting function is implemented but setting

[Libvir] [PATCH][RFC] shows scheduler information

2007-03-29 Thread Atsushi SAKAI
Hi, This patch intends add a showing function of scheduler information. If apply this patch to current revision 1.490 and type virsh dominfo 0 then shows following scheduler information. Currently I assume credit scheduler only. getting function is implemented but setting function is not yet. I