Re: [Libvir] [PATCH] Implement memory operations for qemu driver

2008-03-19 Thread Daniel Veillard
On Tue, Mar 18, 2008 at 02:28:36PM -0400, Cole Robinson wrote: Cole Robinson wrote: The attached patch implements the following operations for the qemu driver: virDomainGetMaxMemory virDomainSetMaxMemory virDomainSetMemory A few questions/comments: 1) I changed maxmem and

Re: [Libvir] [PATCH] Implement memory operations for qemu driver

2008-03-18 Thread Richard W.M. Jones
On Mon, Mar 17, 2008 at 04:21:04PM -0400, Cole Robinson wrote: The attached patch implements the following operations for the qemu driver: virDomainGetMaxMemory virDomainSetMaxMemory virDomainSetMemory The patch itself, +1. Maybe we should investigate whether qemu/kvm does or will support

Re: [Libvir] [PATCH] Implement memory operations for qemu driver

2008-03-18 Thread Jim Meyering
Cole Robinson [EMAIL PROTECTED] wrote: The attached patch implements the following operations for the qemu driver: ... +qemudReportError(dom-conn, dom, NULL, VIR_ERR_INVALID_DOMAIN, + no domain with matching uuid '%s', dom-uuid); ... +

Re: [Libvir] [PATCH] Implement memory operations for qemu driver

2008-03-18 Thread Cole Robinson
Richard W.M. Jones wrote: 2) Should SetMaxMem be able to be called on a running guest? This code allows it, since maxmem is basically a metavalue that doesn't directly affect a guest. 3) Should maxmem be able to be set lower than the currently allocated mem? This code does not

Re: [Libvir] [PATCH] Implement memory operations for qemu driver

2008-03-18 Thread Cole Robinson
Jim Meyering wrote: Cole Robinson [EMAIL PROTECTED] wrote: The attached patch implements the following operations for the qemu driver: ... +qemudReportError(dom-conn, dom, NULL, VIR_ERR_INVALID_DOMAIN, + no domain with matching uuid '%s', dom-uuid); ... +

Re: [Libvir] [PATCH] Implement memory operations for qemu driver

2008-03-18 Thread Daniel Veillard
On Tue, Mar 18, 2008 at 10:05:48AM -0400, Cole Robinson wrote: Jim Meyering wrote: Cole Robinson [EMAIL PROTECTED] wrote: The attached patch implements the following operations for the qemu driver: ... +qemudReportError(dom-conn, dom, NULL, VIR_ERR_INVALID_DOMAIN, +

Re: [Libvir] [PATCH] Implement memory operations for qemu driver

2008-03-18 Thread Cole Robinson
Cole Robinson wrote: The attached patch implements the following operations for the qemu driver: virDomainGetMaxMemory virDomainSetMaxMemory virDomainSetMemory A few questions/comments: 1) I changed maxmem and memory in the qemu_vm_def struct to unsigned long to match the public

[Libvir] [PATCH] Implement memory operations for qemu driver

2008-03-17 Thread Cole Robinson
The attached patch implements the following operations for the qemu driver: virDomainGetMaxMemory virDomainSetMaxMemory virDomainSetMemory A few questions/comments: 1) I changed maxmem and memory in the qemu_vm_def struct to unsigned long to match the public api for memory values. Seems to