Re: [Libvir] [PATCH] Remote 4/8: Server-side call dispatch

2007-05-10 Thread Richard W.M. Jones
Richard W.M. Jones wrote: Daniel P. Berrange wrote: Finally, with CHECK_CONN; Is it possible to tweak the macro definition so its use appears as CHECK_CONN(client); So its clear what variable this macro is doing work against. Will do. Attached is the updated remote.c. The only

Re: [Libvir] [PATCH] Remote 4/8: Server-side call dispatch

2007-05-08 Thread Richard W.M. Jones
Daniel P. Berrange wrote: void remoteDispatchClientRequest (struct qemud_server *server ATTRIBUTE_UNUSED, struct qemud_client *client) char *args = NULL, *ret = NULL; Could those two variables instead be void * - to avoid the need to cast all assignments

Re: [Libvir] [PATCH] Remote 4/8: Server-side call dispatch

2007-05-07 Thread Daniel P. Berrange
On Sat, May 05, 2007 at 12:30:13PM +0100, Richard W.M. Jones wrote: > > You may notice in remoteDispatchClientRequest that parts are generated > automatically, eg. the dispatch switch statement: > > switch (req.proc) { > #include "remote_dispatch_proc_switch.h" > > default: > re