Re: [PATCH 00/55] Hyper-V: code cleanup & prep for future changes

2021-01-22 Thread Matt Coleman
> On Jan 22, 2021, at 12:12 PM, Matt Coleman wrote: > >> On Jan 22, 2021, at 12:07 PM, Matt Coleman wrote: >> >>> On Jan 22, 2021, at 11:30 AM, Laine Stump wrote: >>> >>> On 1/22/21 11:05 AM, Laine Stump wrote: 1) There are several cleanup functions in external libraries that in the >>>

Re: [PATCH 00/55] Hyper-V: code cleanup & prep for future changes

2021-01-22 Thread Matt Coleman
> On Jan 22, 2021, at 12:07 PM, Matt Coleman wrote: > >> On Jan 22, 2021, at 11:30 AM, Laine Stump wrote: >> >> On 1/22/21 11:05 AM, Laine Stump wrote: >>> 1) There are several cleanup functions in external libraries that in the >>> past were only called after checking that the pointer was !=

Re: [PATCH 00/55] Hyper-V: code cleanup & prep for future changes

2021-01-22 Thread Matt Coleman
> On Jan 22, 2021, at 11:30 AM, Laine Stump wrote: > > On 1/22/21 11:05 AM, Laine Stump wrote: >> 1) There are several cleanup functions in external libraries that in the >> past were only called after checking that the pointer was != NULL. g_autoptr >> cleanups need to handle being called with

Re: [PATCH 00/55] Hyper-V: code cleanup & prep for future changes

2021-01-22 Thread Laine Stump
On 1/22/21 11:05 AM, Laine Stump wrote: (Thought I sent this 7 hours ago before I went to sleep, but when I sat down this morning I saw it was still sitting there as a draft :-/) On 1/21/21 1:50 PM, Matt Coleman wrote: This series of patches simplifies the code in several ways and makes a few

Re: [PATCH 00/55] Hyper-V: code cleanup & prep for future changes

2021-01-22 Thread Daniel P . Berrangé
On Fri, Jan 22, 2021 at 11:05:22AM -0500, Laine Stump wrote: > (Thought I sent this 7 hours ago before I went to sleep, but when I sat down > this morning I saw it was still sitting there as a draft :-/) > > On 1/21/21 1:50 PM, Matt Coleman wrote: > > This series of patches simplifies the code in

Re: [PATCH 00/55] Hyper-V: code cleanup & prep for future changes

2021-01-22 Thread Laine Stump
(Thought I sent this 7 hours ago before I went to sleep, but when I sat down this morning I saw it was still sitting there as a draft :-/) On 1/21/21 1:50 PM, Matt Coleman wrote: This series of patches simplifies the code in several ways and makes a few changes required by the next round of pat

[PATCH 00/55] Hyper-V: code cleanup & prep for future changes

2021-01-21 Thread Matt Coleman
This series of patches simplifies the code in several ways and makes a few changes required by the next round of patches that I'll submit. Simplifications: * add a macro to cut down on repetitive SettingData code * enable GLib auto-cleanup for hypervObject and several OpenWSMAN types Changes: *

Re: [PATCH 00/55] Hyper-V: code cleanup & prep for future changes

2021-01-21 Thread Neal Gompa
On Thu, Jan 21, 2021 at 1:53 PM Matt Coleman wrote: > > This series of patches simplifies the code in several ways and makes a > few changes required by the next round of patches that I'll submit. > > Simplifications: > > * add a macro to cut down on repetitive SettingData code > * enable GLib aut