Re: [PATCH 1/2] virStorageBackendRBDGetVolNames: Fix memory leak in 'rbd_list2' version

2021-06-15 Thread Jano Tomko
On 6/15/21 4:16 PM, Peter Krempa wrote: > The 'rbd_image_spec_t' struct has two string members 'id' and > 'name'. We only stole the 'name' members thus the 'id's as well as the > whole list would be leaked on success. > > Restructure the code so that we copy out the image names and call > rbd_imag

[PATCH 1/2] virStorageBackendRBDGetVolNames: Fix memory leak in 'rbd_list2' version

2021-06-15 Thread Peter Krempa
The 'rbd_image_spec_t' struct has two string members 'id' and 'name'. We only stole the 'name' members thus the 'id's as well as the whole list would be leaked on success. Restructure the code so that we copy out the image names and call rbd_image_spec_list_cleanup on success rather than on error.