Re: [PATCH v2 09/13] vireventthread: exit thread synchronously on finalize

2020-09-04 Thread Daniel P . Berrangé
On Thu, Jul 23, 2020 at 01:14:09PM +0300, Nikolay Shirokovskiy wrote: > It useful to be sure no thread is running after we drop all references to > virEventThread. Otherwise in order to avoid crashes we need to synchronize > some > other way or we make extra references in event handler callbacks t

Re: [PATCH v2 09/13] vireventthread: exit thread synchronously on finalize

2020-08-10 Thread Daniel Henrique Barboza
On 7/23/20 7:14 AM, Nikolay Shirokovskiy wrote: It useful to be sure no thread is running after we drop all references to Nit: "It is useful to ..." Reviewed-by: Daniel Henrique Barboza virEventThread. Otherwise in order to avoid crashes we need to synchronize some other way or we make

[PATCH v2 09/13] vireventthread: exit thread synchronously on finalize

2020-07-23 Thread Nikolay Shirokovskiy
It useful to be sure no thread is running after we drop all references to virEventThread. Otherwise in order to avoid crashes we need to synchronize some other way or we make extra references in event handler callbacks to all the object in use. And some of them are not prepared to be refcounted. S