Re: [libvirt] [PATCH] Improve some error messages about unsupported APIs/URIs

2010-06-23 Thread Camilo Aguilar
Why not be consistent with http://libvirt.org/goals.html. I'm really agreed with use the concept hypervisor. On Tue, Jun 22, 2010 at 6:09 PM, Eric Blake wrote: > On 06/22/2010 03:48 PM, Justin Clift wrote: > > On 06/23/2010 04:16 AM, Matthias Bolte wrote: > >> case VIR_ERR_NO_SUPPORT: >

Re: [libvirt] [PATCH] Improve some error messages about unsupported APIs/URIs

2010-06-22 Thread Camilo Aguilar
how many drivers aren't hypervisors ? On Tue, Jun 22, 2010 at 6:09 PM, Eric Blake wrote: > On 06/22/2010 03:48 PM, Justin Clift wrote: > > On 06/23/2010 04:16 AM, Matthias Bolte wrote: > >> case VIR_ERR_NO_SUPPORT: > > if (info == NULL) > > > > Would it be practical

Re: [libvirt] [PATCH] Improve some error messages about unsupported APIs/URIs

2010-06-22 Thread Eric Blake
On 06/22/2010 03:48 PM, Justin Clift wrote: > On 06/23/2010 04:16 AM, Matthias Bolte wrote: >> case VIR_ERR_NO_SUPPORT: > if (info == NULL) > > Would it be practical to expand this with category messages like? > > case VIR_ERR_NO_SUPPORT_STORAGE: > if (inf

Re: [libvirt] [PATCH] Improve some error messages about unsupported APIs/URIs

2010-06-22 Thread Justin Clift
On 06/23/2010 04:16 AM, Matthias Bolte wrote: case VIR_ERR_NO_SUPPORT: > if (info == NULL) Would it be practical to expand this with category messages like? case VIR_ERR_NO_SUPPORT_STORAGE: if (info == NULL) errmsg = _("this function is not supp

Re: [libvirt] [PATCH] Improve some error messages about unsupported APIs/URIs

2010-06-22 Thread Matthias Bolte
2010/6/22 Daniel P. Berrange : > On Tue, Jun 22, 2010 at 08:01:09PM +0200, Matthias Bolte wrote: >> 2010/6/22 Daniel P. Berrange : >> > If there is no driver for a URI we report >> > >> >  "no hypervisor driver available" >> > >> > This is bad because not all virt drivers are hypervisors (ie contai

Re: [libvirt] [PATCH] Improve some error messages about unsupported APIs/URIs

2010-06-22 Thread Daniel P. Berrange
On Tue, Jun 22, 2010 at 08:01:09PM +0200, Matthias Bolte wrote: > 2010/6/22 Daniel P. Berrange : > > If there is no driver for a URI we report > > > >  "no hypervisor driver available" > > > > This is bad because not all virt drivers are hypervisors (ie container > > based virt). > > > > If there i

Re: [libvirt] [PATCH] Improve some error messages about unsupported APIs/URIs

2010-06-22 Thread Matthias Bolte
2010/6/22 Daniel P. Berrange : > If there is no driver for a URI we report > >  "no hypervisor driver available" > > This is bad because not all virt drivers are hypervisors (ie container > based virt). > > If there is no driver support for an API we report > >  "this function is not supported by t

Re: [libvirt] [PATCH] Improve some error messages about unsupported APIs/URIs

2010-06-22 Thread Eric Blake
On 06/22/2010 11:40 AM, Daniel P. Berrange wrote: > If there is no driver for a URI we report > > "no hypervisor driver available" > > This is bad because not all virt drivers are hypervisors (ie container > based virt). > > If there is no driver support for an API we report > > "this funct

[libvirt] [PATCH] Improve some error messages about unsupported APIs/URIs

2010-06-22 Thread Daniel P. Berrange
If there is no driver for a URI we report "no hypervisor driver available" This is bad because not all virt drivers are hypervisors (ie container based virt). If there is no driver support for an API we report "this function is not supported by the hypervisor" This is bad for the same reas