Re: [libvirt] [PATCH] avoid shutting down the vm twice

2011-02-02 Thread Jiri Denemark
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 6140f0f..c527bb7 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2972,7 +2972,11 @@ cleanup: * pretend we never started it */ virCommandFree(cmd); VIR_FORCE_CLOSE(logfile); -

Re: [libvirt] [PATCH] avoid shutting down the vm twice

2011-02-02 Thread Daniel P. Berrange
On Wed, Feb 02, 2011 at 02:18:47PM +0100, Jiri Denemark wrote: diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 6140f0f..c527bb7 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2972,7 +2972,11 @@ cleanup: * pretend we never started it

Re: [libvirt] [PATCH] avoid shutting down the vm twice

2011-02-02 Thread Eric Blake
On 02/02/2011 06:18 AM, Jiri Denemark wrote: + * vm is active before shutdown. + */ +if (virDomainObjIsActive(vm)) +qemudShutdownVMDaemon(driver, vm, 0); I'm still playing with this patch, but at first glance, it is making sense to me. The patch makes sense to me,

Re: [libvirt] [PATCH] avoid shutting down the vm twice

2011-01-27 Thread Eric Blake
On 01/26/2011 08:18 PM, Wen Congyang wrote: Steps to reproduce this bug: 1. use gdb to debug libvirtd, and set breakpoint in the function qemuConnectMonitor() 2. start a vm, and the libvirtd will be stopped in qemuConnectMonitor() 3. kill -STOP $(cat /var/run/libvirt/qemu/domain.pid) 4.

[libvirt] [PATCH] avoid shutting down the vm twice

2011-01-26 Thread Wen Congyang
Steps to reproduce this bug: 1. use gdb to debug libvirtd, and set breakpoint in the function qemuConnectMonitor() 2. start a vm, and the libvirtd will be stopped in qemuConnectMonitor() 3. kill -STOP $(cat /var/run/libvirt/qemu/domain.pid) 4. continue to run libvirtd in gdb, and libvirtd will