Re: [libvirt] [PATCH] docs: Add notes for VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA

2018-11-16 Thread Peter Krempa
On Wed, Nov 14, 2018 at 15:19:20 +0800, Han Han wrote: > When listing snapshot with VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA, it > always returns 0 or no snapshot. Because we never implement funtions > to list no-metadata snapshot in virDomainSnapshotObjListGetNames(): > > if ((data.flags &

Re: [libvirt] [PATCH] docs: Add notes for VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA

2018-11-15 Thread Han Han
On Thu, Nov 15, 2018 at 12:36 AM Andrea Bolognani wrote: > On Wed, 2018-11-14 at 15:19 +0800, Han Han wrote: > > When listing snapshot with VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA, it > > always returns 0 or no snapshot. Because we never implement funtions > > to list no-metadata snapshot in

Re: [libvirt] [PATCH] docs: Add notes for VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA

2018-11-14 Thread Andrea Bolognani
On Wed, 2018-11-14 at 15:19 +0800, Han Han wrote: > When listing snapshot with VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA, it > always returns 0 or no snapshot. Because we never implement funtions > to list no-metadata snapshot in virDomainSnapshotObjListGetNames(): > > if ((data.flags &

[libvirt] [PATCH] docs: Add notes for VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA

2018-11-13 Thread Han Han
When listing snapshot with VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA, it always returns 0 or no snapshot. Because we never implement funtions to list no-metadata snapshot in virDomainSnapshotObjListGetNames(): if ((data.flags & VIR_DOMAIN_SNAPSHOT_FILTERS_METADATA) ==