[libvirt] [PATCH] docs: expand the man page text for virsh setmaxmem

2011-01-27 Thread Justin Clift
Addresses BZ # 622534: https://bugzilla.redhat.com/show_bug.cgi?id=622534 --- tools/virsh.pod | 17 ++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 4e8b295..0d37512 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@

Re: [libvirt] [PATCH] docs: expand the man page text for virsh setmaxmem

2011-01-27 Thread Matthias Bolte
2011/1/27 Justin Clift jcl...@redhat.com: Addresses BZ # 622534:  https://bugzilla.redhat.com/show_bug.cgi?id=622534 ---  tools/virsh.pod |   17 ++---  1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 4e8b295..0d37512

Re: [libvirt] [PATCH] docs: expand the man page text for virsh setmaxmem

2011-01-27 Thread Justin Clift
On 28/01/2011, at 3:10 AM, Matthias Bolte wrote: snip I didn't post the patch yet, as it isn't finished yet. When my patch gets accepted your patch needs some small tweaks :) Heh, no worries. Can I can this as an ACK (for libvirt 0.8.7 thus far) though? :) Happy to tweak it again

Re: [libvirt] [PATCH] docs: expand the man page text for virsh setmaxmem

2011-01-27 Thread Eric Blake
On 01/27/2011 09:10 AM, Matthias Bolte wrote: 2011/1/27 Justin Clift jcl...@redhat.com: +Some hypervisors require a larger granularity than kilobytes, rounding down +or rejecting requests that are not an even multiple of the desired amount. +vSphere/ESX is one of these, requiring the parameter

Re: [libvirt] [PATCH] docs: expand the man page text for virsh setmaxmem

2011-01-27 Thread Justin Clift
On 28/01/2011, at 3:19 AM, Eric Blake wrote: Do we need three examples, or would two be sufficient? For example, vSphere/ESX has a 4MB granularity, so 263168 (257MB) would be rejected while 266240 (260MB) is valid. Yeah, that'd work too. I'll just that example then push it. -- libvir-list

Re: [libvirt] [PATCH] docs: expand the man page text for virsh setmaxmem

2011-01-27 Thread Eric Blake
On 01/27/2011 09:20 AM, Justin Clift wrote: On 28/01/2011, at 3:19 AM, Eric Blake wrote: Do we need three examples, or would two be sufficient? For example, vSphere/ESX has a 4MB granularity, so 263168 (257MB) would be rejected while 266240 (260MB) is valid. Yeah, that'd work too. I'll

Re: [libvirt] [PATCH] docs: expand the man page text for virsh setmaxmem

2011-01-27 Thread Justin Clift
On 28/01/2011, at 3:29 AM, Eric Blake wrote: On 01/27/2011 09:20 AM, Justin Clift wrote: On 28/01/2011, at 3:19 AM, Eric Blake wrote: Do we need three examples, or would two be sufficient? For example, vSphere/ESX has a 4MB granularity, so 263168 (257MB) would be rejected while 266240