Re: [libvirt] [PATCH] freebsd: Fix build problem due to picking up the wrong libvirt.h

2011-07-28 Thread Matthias Bolte
2011/7/26 Eric Blake ebl...@redhat.com: On 07/26/2011 02:45 PM, Matthias Bolte wrote: +++ b/configure.ac @@ -2011,8 +2011,16 @@ dnl Enable building libvirtd?  AM_CONDITIONAL([WITH_LIBVIRTD],[test x$with_libvirtd = xyes])  dnl Check for gettext - don't go any newer than what RHEL 5 supports

Re: [libvirt] [PATCH] freebsd: Fix build problem due to picking up the wrong libvirt.h

2011-07-28 Thread Eric Blake
On 07/28/2011 06:55 AM, Matthias Bolte wrote: Okay, this works for libvirt itself, but it fails for make check as the global CPPFLAGS also affect gnulib, but with this patch it doesn't contain the gettext related parts anymore and the gnulib tests fail to find libintl.h because of this. Is

Re: [libvirt] [PATCH] freebsd: Fix build problem due to picking up the wrong libvirt.h

2011-07-28 Thread Eric Blake
On 07/28/2011 07:51 AM, Eric Blake wrote: Is there any option in gnulib that would allow to inject GETTEXT_CPPFLAGS into the gnulib makefiles, or any other possibility to fix this? Fortunately, I know how to fix that - it involves changing our gnulib-tool to spit out gnulib.mk to be

Re: [libvirt] [PATCH] freebsd: Fix build problem due to picking up the wrong libvirt.h

2011-07-26 Thread Matthias Bolte
2011/6/1 Eric Blake ebl...@redhat.com: On 05/31/2011 02:51 PM, Matthias Bolte wrote: AM_GNU_GETTEXT calls AM_ICONV_LINK. AM_ICONV_LINK saves and alters CPPFLAGS, but doesn't restore it when it finds libiconv. This results in /usr/local/include ending up in the gcc command line before the

Re: [libvirt] [PATCH] freebsd: Fix build problem due to picking up the wrong libvirt.h

2011-07-26 Thread Eric Blake
On 07/26/2011 02:45 PM, Matthias Bolte wrote: +++ b/configure.ac @@ -2011,8 +2011,16 @@ dnl Enable building libvirtd? AM_CONDITIONAL([WITH_LIBVIRTD],[test x$with_libvirtd = xyes]) dnl Check for gettext - don't go any newer than what RHEL 5 supports +dnl +dnl save and restore CPPFLAGS around

[libvirt] [PATCH] freebsd: Fix build problem due to picking up the wrong libvirt.h

2011-05-31 Thread Matthias Bolte
AM_GNU_GETTEXT calls AM_ICONV_LINK. AM_ICONV_LINK saves and alters CPPFLAGS, but doesn't restore it when it finds libiconv. This results in /usr/local/include ending up in the gcc command line before the include path for the local include directory. This makes gcc pick a previous installed

Re: [libvirt] [PATCH] freebsd: Fix build problem due to picking up the wrong libvirt.h

2011-05-31 Thread Eric Blake
On 05/31/2011 02:51 PM, Matthias Bolte wrote: AM_GNU_GETTEXT calls AM_ICONV_LINK. AM_ICONV_LINK saves and alters CPPFLAGS, but doesn't restore it when it finds libiconv. This results in /usr/local/include ending up in the gcc command line before the include path for the local include